From 8cd208ebaa33627daf05d8ffff7b28e53a7067d0 Mon Sep 17 00:00:00 2001 From: "Christopher Lott (cl778h)" Date: Thu, 7 Sep 2017 08:52:41 -0400 Subject: Adjust code for Sonar issues Made non-functional updates to address static code analysis issues. Update license header with simple double-quote characters. Issue: PORTAL-72, PORTAL-90 Change-Id: Ic2c330daea07d721f0e6b350ebf03da97073f7ce Signed-off-by: Christopher Lott (cl778h) --- .../org/onap/portalsdk/analytics/AntBuild.java | 5 +- .../org/onap/portalsdk/analytics/RaptorObject.java | 4 +- .../portalsdk/analytics/config/ConfigLoader.java | 18 +- .../portalsdk/analytics/controller/Action.java | 8 +- .../analytics/controller/ActionHandler.java | 4 +- .../analytics/controller/ActionMapping.java | 6 +- .../portalsdk/analytics/controller/Controller.java | 4 +- .../analytics/controller/ErrorHandler.java | 18 +- .../analytics/controller/WizardProcessor.java | 4 +- .../analytics/controller/WizardSequence.java | 12 +- .../controller/WizardSequenceCrossTab.java | 10 +- .../controller/WizardSequenceDashboard.java | 10 +- .../analytics/controller/WizardSequenceLinear.java | 10 +- .../controller/WizardSequenceSQLBasedCrossTab.java | 10 +- .../controller/WizardSequenceSQLBasedHive.java | 10 +- .../controller/WizardSequenceSQLBasedLinear.java | 10 +- .../WizardSequenceSQLBasedLinearDatamining.java | 10 +- .../portalsdk/analytics/error/RaptorException.java | 4 +- .../analytics/error/RaptorRuntimeException.java | 4 +- .../analytics/error/RaptorSchedularException.java | 4 +- .../analytics/error/ReportSQLException.java | 4 +- .../analytics/error/UserAccessException.java | 4 +- .../analytics/error/UserDefinedException.java | 4 +- .../analytics/error/ValidationException.java | 4 +- .../onap/portalsdk/analytics/gmap/line/Line.java | 4 +- .../analytics/gmap/line/LineCollection.java | 4 +- .../portalsdk/analytics/gmap/line/LineInfo.java | 4 +- .../analytics/gmap/map/ColorProperties.java | 4 +- .../analytics/gmap/map/GMapProperties.java | 7 +- .../analytics/gmap/map/GeoCoordinate.java | 4 +- .../portalsdk/analytics/gmap/map/MapConstant.java | 4 +- .../onap/portalsdk/analytics/gmap/map/NovaMap.java | 4 +- .../analytics/gmap/map/layer/SwingLayer.java | 5 +- .../onap/portalsdk/analytics/gmap/node/Node.java | 4 +- .../analytics/gmap/node/NodeCollection.java | 4 +- .../portalsdk/analytics/gmap/node/NodeInfo.java | 4 +- .../portalsdk/analytics/gmap/utils/MapUtils.java | 11 +- .../analytics/gmap/utils/SwingWorker.java | 4 +- .../onap/portalsdk/analytics/model/DataCache.java | 24 +- .../portalsdk/analytics/model/ReportHandler.java | 4 +- .../portalsdk/analytics/model/ReportLoader.java | 4 +- .../portalsdk/analytics/model/SearchHandler.java | 32 +- .../analytics/model/base/ChartSeqComparator.java | 4 +- .../analytics/model/base/IdNameColLookup.java | 6 +- .../portalsdk/analytics/model/base/IdNameList.java | 8 +- .../analytics/model/base/IdNameLookup.java | 10 +- .../portalsdk/analytics/model/base/IdNameSql.java | 4 +- .../analytics/model/base/IdNameValue.java | 4 +- .../analytics/model/base/NameComparator.java | 6 +- .../analytics/model/base/OrderBySeqComparator.java | 4 +- .../analytics/model/base/OrderSeqComparator.java | 4 +- .../analytics/model/base/ReportSecurity.java | 4 +- .../analytics/model/base/ReportUserRole.java | 18 +- .../analytics/model/base/ReportWrapper.java | 4 +- .../analytics/model/definition/DBColumnInfo.java | 4 +- .../model/definition/DrillDownParamDef.java | 4 +- .../analytics/model/definition/Marker.java | 4 +- .../model/definition/ReportDefinition.java | 4 +- .../analytics/model/definition/ReportLogEntry.java | 4 +- .../analytics/model/definition/ReportMap.java | 8 +- .../analytics/model/definition/ReportSchedule.java | 4 +- .../analytics/model/definition/SecurityEntry.java | 6 +- .../analytics/model/definition/TableJoin.java | 4 +- .../analytics/model/definition/TableSource.java | 4 +- .../model/definition/wizard/ColumnEditJSON.java | 4 +- .../model/definition/wizard/ColumnJSON.java | 4 +- .../model/definition/wizard/DefinitionJSON.java | 4 +- .../model/definition/wizard/ElementJSON.java | 9 +- .../model/definition/wizard/FormEditJSON.java | 4 +- .../model/definition/wizard/IdNameBooleanJSON.java | 4 +- .../model/definition/wizard/ImportJSON.java | 6 +- .../model/definition/wizard/ListJSON.java | 7 +- .../model/definition/wizard/MessageJSON.java | 19 +- .../model/definition/wizard/NameBooleanJSON.java | 4 +- .../model/definition/wizard/QueryJSON.java | 10 +- .../model/definition/wizard/QueryResultJSON.java | 6 +- .../model/definition/wizard/RaptorError.java | 4 +- .../model/definition/wizard/RaptorResponse.java | 4 +- .../model/definition/wizard/SearchFieldJSON.java | 4 +- .../model/definition/wizard/WizardJSON.java | 4 +- .../portalsdk/analytics/model/pdf/PageEvent.java | 4 +- .../portalsdk/analytics/model/pdf/PdfBean.java | 4 +- .../analytics/model/pdf/PdfReportHandler.java | 4 +- .../analytics/model/runtime/BarChartOptions.java | 4 +- .../analytics/model/runtime/CategoryAxisJSON.java | 4 +- .../analytics/model/runtime/ChartD3Helper.java | 4 +- .../analytics/model/runtime/ChartJSON.java | 7 +- .../analytics/model/runtime/ChartJSONHelper.java | 4 +- .../analytics/model/runtime/ChartWebRuntime.java | 9 +- .../model/runtime/CommonChartOptions.java | 4 +- .../analytics/model/runtime/ErrorJSONRuntime.java | 19 +- .../model/runtime/FlexTimeSeriesChartOptions.java | 4 +- .../analytics/model/runtime/FormField.java | 28 +- .../analytics/model/runtime/FormatProcessor.java | 24 +- .../portalsdk/analytics/model/runtime/Item.java | 4 +- .../analytics/model/runtime/LookupDBInfo.java | 4 +- .../analytics/model/runtime/RangeAxisJSON.java | 4 +- .../analytics/model/runtime/ReportFormFields.java | 30 +- .../analytics/model/runtime/ReportJSONRuntime.java | 12 +- .../model/runtime/ReportParamDateValueParser.java | 14 +- .../analytics/model/runtime/ReportParamValues.java | 4 +- .../runtime/ReportParamValuesForPDFExcel.java | 4 +- .../analytics/model/runtime/ReportRuntime.java | 4 +- .../model/runtime/TimeSeriesChartOptions.java | 4 +- .../analytics/model/runtime/VisualManager.java | 11 +- .../analytics/model/search/ReportSearchResult.java | 11 +- .../model/search/ReportSearchResultJSON.java | 12 +- .../analytics/model/search/SearchResult.java | 11 +- .../analytics/model/search/SearchResultColumn.java | 6 +- .../analytics/model/search/SearchResultField.java | 6 +- .../analytics/model/search/SearchResultJSON.java | 12 +- .../analytics/model/search/SearchResultRow.java | 6 +- .../analytics/scheduler/SchedulerUtil.java | 6 +- .../portalsdk/analytics/scheduler/SendEmail.java | 4 +- .../analytics/scheduler/SendNotifications.java | 6 +- .../onap/portalsdk/analytics/system/AppUtils.java | 12 +- .../analytics/system/ConnectionUtils.java | 4 +- .../onap/portalsdk/analytics/system/DbUtils.java | 5 +- .../portalsdk/analytics/system/ExecuteQuery.java | 5 +- .../onap/portalsdk/analytics/system/Globals.java | 4 +- .../onap/portalsdk/analytics/system/IAppUtils.java | 12 +- .../onap/portalsdk/analytics/system/IDbUtils.java | 11 +- .../onap/portalsdk/analytics/system/RDbUtils.java | 9 +- .../portalsdk/analytics/system/RemDbUtils.java | 4 +- .../analytics/system/fusion/AntBuild.java | 4 +- .../analytics/system/fusion/AppUtils.java | 4 +- .../portalsdk/analytics/system/fusion/DbUtils.java | 13 +- .../analytics/system/fusion/RemoteDbUtils.java | 11 +- .../adapter/AdapterSessionFactoryContainer.java | 6 +- .../analytics/system/fusion/adapter/DateUtils.java | 4 +- .../system/fusion/adapter/FusionAdapter.java | 23 +- .../analytics/system/fusion/adapter/IdName.java | 4 +- .../analytics/system/fusion/adapter/Item.java | 4 +- .../analytics/system/fusion/adapter/Lookup.java | 6 +- .../system/fusion/adapter/RaptorAdapter.java | 4 +- .../system/fusion/adapter/SpringContext.java | 4 +- .../fusion/controller/FileServletController.java | 4 +- .../analytics/system/fusion/domain/CR_Report.java | 6 +- .../analytics/system/fusion/domain/QuickLink.java | 4 +- .../system/fusion/domain/RaptorSearch.java | 4 +- .../analytics/system/fusion/domain/ReportInfo.java | 4 +- .../system/fusion/service/RaptorService.java | 7 +- .../system/fusion/service/RaptorServiceImpl.java | 24 +- .../system/fusion/web/RaptorController.java | 4 +- .../system/fusion/web/RaptorControllerAsync.java | 4 +- .../fusion/web/ReportsSearchListController.java | 13 +- .../portalsdk/analytics/util/AppConstants.java | 6 +- .../org/onap/portalsdk/analytics/util/DataSet.java | 12 +- .../portalsdk/analytics/util/ExcelColorDef.java | 4 +- .../portalsdk/analytics/util/HtmlStripper.java | 6 +- .../org/onap/portalsdk/analytics/util/Log.java | 4 +- .../onap/portalsdk/analytics/util/RemDbInfo.java | 4 +- .../portalsdk/analytics/util/SQLCorrector.java | 4 +- .../onap/portalsdk/analytics/util/Scheduler.java | 12 +- .../org/onap/portalsdk/analytics/util/Utils.java | 20 +- .../onap/portalsdk/analytics/util/XSSFilter.java | 4 +- .../portalsdk/analytics/util/jar/ExtractJar.java | 4 +- .../analytics/util/upgrade/SystemUpgrade.java | 30 +- .../portalsdk/analytics/view/ColumnHeader.java | 6 +- .../portalsdk/analytics/view/ColumnHeaderRow.java | 8 +- .../portalsdk/analytics/view/ColumnVisual.java | 4 +- .../analytics/view/CrossTabColumnValues.java | 12 +- .../analytics/view/CrossTabOrderManager.java | 16 +- .../analytics/view/CrossTabTotalValue.java | 6 +- .../org/onap/portalsdk/analytics/view/DataRow.java | 7 +- .../onap/portalsdk/analytics/view/DataValue.java | 6 +- .../portalsdk/analytics/view/HtmlFormatter.java | 4 +- .../analytics/view/ReportColumnHeaderRows.java | 6 +- .../onap/portalsdk/analytics/view/ReportData.java | 19 +- .../portalsdk/analytics/view/ReportDataRows.java | 6 +- .../analytics/view/ReportRowHeaderCols.java | 6 +- .../onap/portalsdk/analytics/view/RowHeader.java | 6 +- .../portalsdk/analytics/view/RowHeaderCol.java | 8 +- .../analytics/xmlobj/ChartAdditionalOptions.java | 4 +- .../analytics/xmlobj/ChartDrillFormfield.java | 4 +- .../analytics/xmlobj/ChartDrillOptions.java | 5 +- .../portalsdk/analytics/xmlobj/ColFilterList.java | 5 +- .../portalsdk/analytics/xmlobj/ColFilterType.java | 4 +- .../analytics/xmlobj/CustomReportType.java | 4 +- .../analytics/xmlobj/DashboardEditorList.java | 5 +- .../analytics/xmlobj/DashboardEditorReport.java | 4 +- .../analytics/xmlobj/DashboardReports.java | 5 +- .../analytics/xmlobj/DashboardReportsNew.java | 5 +- .../portalsdk/analytics/xmlobj/DataColumnList.java | 5 +- .../portalsdk/analytics/xmlobj/DataColumnType.java | 4 +- .../portalsdk/analytics/xmlobj/DataSourceList.java | 5 +- .../portalsdk/analytics/xmlobj/DataSourceType.java | 4 +- .../analytics/xmlobj/DataminingOptions.java | 4 +- .../portalsdk/analytics/xmlobj/FormFieldList.java | 5 +- .../portalsdk/analytics/xmlobj/FormFieldType.java | 4 +- .../portalsdk/analytics/xmlobj/FormatList.java | 5 +- .../portalsdk/analytics/xmlobj/FormatType.java | 4 +- .../analytics/xmlobj/JavascriptItemType.java | 4 +- .../portalsdk/analytics/xmlobj/JavascriptList.java | 5 +- .../onap/portalsdk/analytics/xmlobj/Marker.java | 4 +- .../portalsdk/analytics/xmlobj/ObjectFactory.java | 4 +- .../analytics/xmlobj/PDFAdditionalOptions.java | 4 +- .../analytics/xmlobj/PredefinedValueList.java | 5 +- .../onap/portalsdk/analytics/xmlobj/ReportMap.java | 5 +- .../onap/portalsdk/analytics/xmlobj/Reports.java | 4 +- .../portalsdk/analytics/xmlobj/SemaphoreList.java | 5 +- .../portalsdk/analytics/xmlobj/SemaphoreType.java | 4 +- .../portalapp/controller/core/AdminController.java | 14 +- .../controller/core/AngularAdminController.java | 16 +- .../controller/core/BootstrapSampleController.java | 8 +- .../controller/core/CacheAdminController.java | 50 +- .../controller/core/FavoritesController.java | 59 +- .../controller/core/FnMenuController.java | 25 +- .../controller/core/FuncMenuController.java | 129 +- .../controller/core/LogoutController.java | 67 +- .../controller/core/ManifestController.java | 15 +- .../controller/core/MenuListController.java | 32 +- .../controller/core/PostSearchController.java | 44 +- .../controller/core/ProfileController.java | 77 +- .../controller/core/ProfileSearchController.java | 18 +- .../portalapp/controller/core/RoleController.java | 84 +- .../core/RoleFunctionListController.java | 115 +- .../controller/core/RoleListController.java | 80 +- .../controller/core/SDKLoginController.java | 17 +- .../controller/core/SingleSignOnController.java | 49 +- .../controller/core/UsageListController.java | 17 +- .../controller/core/UserProfileController.java | 11 +- .../controller/core/WelcomeController.java | 8 +- .../sample/AngularSinglePageController.java | 4 +- .../controller/sample/BroadcastController.java | 4 +- .../controller/sample/BroadcastListController.java | 4 +- .../controller/sample/CallflowController.java | 4 +- .../sample/CamundaCockpitController.java | 4 +- .../sample/CollaborateListController.java | 4 +- .../controller/sample/CollaborationController.java | 4 +- .../controller/sample/DS2SampleController.java | 4 +- .../controller/sample/ElasticSearchController.java | 4 +- .../controller/sample/ElementModelController.java | 4 +- .../controller/sample/LeafletMapContoller.java | 4 +- .../controller/sample/NetMapController.java | 4 +- .../controller/sample/PostDroolsController.java | 4 +- .../sample/ReportDashboardController.java | 4 +- .../controller/sample/SamplePageController.java | 4 +- .../main/java/org/onap/portalapp/model/Result.java | 4 +- .../java/org/onap/portalapp/scheduler/LogJob.java | 4 +- .../org/onap/portalapp/scheduler/LogRegistry.java | 4 +- .../portalapp/service/IAdminAuthExtension.java | 4 +- .../service/OnBoardingApiServiceImpl.java | 4 +- .../onap/portalapp/util/CustomLoggingFilter.java | 4 +- .../org/onap/portalapp/conf/ExternalAppConfig.java | 11 +- .../portalapp/conf/ExternalAppInitializer.java | 4 +- .../portalapp/conf/HibernateMappingLocations.java | 4 +- .../portalapp/lm/FusionLicenseManagerImpl.java | 24 +- .../onap/portalapp/lm/LicenseableClassImpl.java | 16 +- .../onap/portalapp/login/LoginStrategyImpl.java | 13 +- .../org/onap/portalapp/scheduler/Register.java | 22 +- .../onap/portalapp/scheduler/RegistryAdapter.java | 17 +- .../onap/portalapp/service/AdminAuthExtension.java | 14 +- .../java/org/onap/portalsdk/core/FusionObject.java | 57 +- .../onap/portalsdk/core/auth/LoginStrategy.java | 43 +- .../org/onap/portalsdk/core/command/LoginBean.java | 325 ++--- .../portalsdk/core/command/PostDroolsBean.java | 22 +- .../portalsdk/core/command/PostSearchBean.java | 650 +++++---- .../onap/portalsdk/core/command/UserRowBean.java | 63 +- .../portalsdk/core/command/support/SearchBase.java | 418 +++--- .../core/command/support/SearchResult.java | 69 +- .../org/onap/portalsdk/core/conf/AppConfig.java | 73 +- .../onap/portalsdk/core/conf/AppInitializer.java | 19 +- .../org/onap/portalsdk/core/conf/Configurable.java | 22 +- .../core/conf/HibernateConfiguration.java | 45 +- .../core/conf/HibernateMappingLocatable.java | 17 +- .../core/controller/FusionBaseController.java | 102 +- .../core/controller/RestrictedBaseController.java | 17 +- .../RestrictedRESTfulBaseController.java | 17 +- .../controller/UnRestrictedBaseController.java | 12 +- .../org/onap/portalsdk/core/dao/AbstractDao.java | 74 +- .../org/onap/portalsdk/core/dao/ProfileDao.java | 5 +- .../onap/portalsdk/core/dao/ProfileDaoImpl.java | 21 +- .../core/dao/hibernate/ModelOperationsCommon.java | 149 +- .../onap/portalsdk/core/dao/support/FusionDao.java | 18 +- .../java/org/onap/portalsdk/core/domain/App.java | 7 +- .../org/onap/portalsdk/core/domain/AuditLog.java | 115 +- .../portalsdk/core/domain/BroadcastMessage.java | 191 ++- .../org/onap/portalsdk/core/domain/DomainVo.java | 17 +- .../org/onap/portalsdk/core/domain/FnMenu.java | 81 +- .../org/onap/portalsdk/core/domain/FusionVo.java | 9 +- .../org/onap/portalsdk/core/domain/LoginBean.java | 325 ++--- .../org/onap/portalsdk/core/domain/Lookup.java | 86 +- .../org/onap/portalsdk/core/domain/LuCountry.java | 66 +- .../org/onap/portalsdk/core/domain/LuState.java | 60 +- .../org/onap/portalsdk/core/domain/LuTimeZone.java | 68 +- .../java/org/onap/portalsdk/core/domain/Menu.java | 187 ++- .../org/onap/portalsdk/core/domain/MenuData.java | 75 +- .../org/onap/portalsdk/core/domain/Profile.java | 16 +- .../java/org/onap/portalsdk/core/domain/Role.java | 259 ++-- .../onap/portalsdk/core/domain/RoleFunction.java | 67 +- .../onap/portalsdk/core/domain/UrlsAccessible.java | 83 +- .../portalsdk/core/domain/UrlsAccessibleKey.java | 115 +- .../java/org/onap/portalsdk/core/domain/User.java | 714 +++++----- .../org/onap/portalsdk/core/domain/UserApp.java | 58 +- .../org/onap/portalsdk/core/domain/UserAppId.java | 20 +- .../core/domain/sessionmgt/TimeoutVO.java | 37 +- .../portalsdk/core/domain/support/Attribute.java | 27 +- .../core/domain/support/CollaborateList.java | 40 +- .../portalsdk/core/domain/support/Container.java | 321 ++--- .../onap/portalsdk/core/domain/support/Domain.java | 187 +-- .../portalsdk/core/domain/support/DomainVo.java | 269 ++-- .../portalsdk/core/domain/support/Element.java | 121 +- .../core/domain/support/ElementDetails.java | 52 +- .../core/domain/support/FusionCommand.java | 21 +- .../onap/portalsdk/core/domain/support/Layout.java | 1490 ++++++++------------ .../portalsdk/core/domain/support/NameValueId.java | 101 +- .../portalsdk/core/domain/support/Position.java | 10 +- .../onap/portalsdk/core/domain/support/Size.java | 12 +- .../portalsdk/core/drools/DroolsRuleService.java | 7 +- .../core/drools/DroolsRuleServiceImpl.java | 18 +- .../core/exception/FusionExceptionResolver.java | 23 +- .../core/exception/SessionExpiredException.java | 14 +- .../exception/UrlAccessRestrictedException.java | 14 +- .../core/exception/support/FusionException.java | 7 +- .../exception/support/FusionRuntimeException.java | 17 +- .../core/interceptor/ResourceInterceptor.java | 33 +- .../interceptor/SessionTimeoutInterceptor.java | 27 +- .../core/interfaces/SecurityInterface.java | 4 +- .../core/listener/ApplicationContextListener.java | 17 +- .../listener/CollaborateListBindingListener.java | 13 +- .../core/listener/UserSessionListener.java | 54 +- .../portalsdk/core/lm/FusionLicenseManager.java | 11 +- .../core/lm/FusionLicenseManagerUtils.java | 30 +- .../onap/portalsdk/core/lm/LicenseableClass.java | 36 +- .../portalsdk/core/logging/aspect/AuditLog.java | 9 +- .../core/logging/aspect/EELFLoggerAdvice.java | 22 +- .../core/logging/aspect/EELFLoggerAspect.java | 49 +- .../portalsdk/core/logging/aspect/MetricsLog.java | 9 +- .../core/logging/format/AlarmSeverityEnum.java | 10 +- .../core/logging/format/AppMessagesEnum.java | 391 ++--- .../core/logging/format/AuditLogFormatter.java | 81 +- .../core/logging/format/ErrorCodesEnum.java | 96 +- .../core/logging/format/ErrorSeverityEnum.java | 9 +- .../core/logging/format/ErrorTypeEnum.java | 11 +- .../core/logging/logic/EELFLoggerDelegate.java | 71 +- .../org/onap/portalsdk/core/menu/MenuBuilder.java | 168 ++- .../onap/portalsdk/core/menu/MenuProperties.java | 152 +- .../core/objectcache/AbstractCacheManager.java | 58 +- .../core/objectcache/jcs/JCSCacheEventHandler.java | 76 +- .../core/objectcache/jcs/JCSCacheManager.java | 43 +- .../objectcache/support/FusionCacheManager.java | 23 +- .../core/onboarding/client/AppContextManager.java | 29 +- .../core/onboarding/session/TestClass.java | 42 - .../portalsdk/core/onboarding/sso/TestClass.java | 42 - .../portalsdk/core/onboarding/ueb/Consumer.java | 71 +- .../core/onboarding/ueb/FunctionalMenu.java | 9 +- .../onap/portalsdk/core/onboarding/ueb/Helper.java | 30 +- .../portalsdk/core/onboarding/ueb/Publisher.java | 29 +- .../core/onboarding/ueb/PublisherList.java | 26 +- .../core/onboarding/ueb/TopicManager.java | 31 +- .../core/onboarding/ueb/UebException.java | 31 +- .../portalsdk/core/onboarding/ueb/UebManager.java | 66 +- .../onap/portalsdk/core/onboarding/ueb/UebMsg.java | 13 +- .../portalsdk/core/onboarding/ueb/UebMsgTypes.java | 4 +- .../onboarding/ueb/WaitingRequestersQueueList.java | 14 +- .../core/restful/client/HttpStatusAndResponse.java | 4 +- .../core/restful/client/PortalRestClientBase.java | 69 +- .../restful/client/SharedContextRestClient.java | 155 +- .../portalsdk/core/scheduler/CoreRegister.java | 43 +- .../portalsdk/core/scheduler/CronRegistry.java | 75 +- .../portalsdk/core/scheduler/Registerable.java | 8 +- .../core/service/AccessConfiguration.java | 4 +- .../onap/portalsdk/core/service/AppService.java | 11 +- .../portalsdk/core/service/AppServiceImpl.java | 37 +- .../onap/portalsdk/core/service/AuditService.java | 10 +- .../portalsdk/core/service/AuditServiceImpl.java | 27 +- .../portalsdk/core/service/BroadcastService.java | 20 +- .../core/service/BroadcastServiceImpl.java | 388 ++--- .../core/service/CentralAccessCondition.java | 23 +- .../portalsdk/core/service/DataAccessService.java | 111 +- .../core/service/DataAccessServiceImpl.java | 154 +- .../portalsdk/core/service/ElementLinkService.java | 119 +- .../portalsdk/core/service/ElementMapService.java | 331 ++--- .../onap/portalsdk/core/service/FnMenuService.java | 4 +- .../portalsdk/core/service/FnMenuServiceImpl.java | 10 +- .../core/service/FunctionalMenuListService.java | 6 +- .../FunctionalMenuListServiceCentralizedImpl.java | 6 +- .../service/FunctionalMenuListServiceImpl.java | 10 +- .../onap/portalsdk/core/service/LdapService.java | 12 +- .../portalsdk/core/service/LdapServiceImpl.java | 384 +++-- .../core/service/LocalAccessCondition.java | 16 +- .../onap/portalsdk/core/service/LoginService.java | 28 +- .../core/service/LoginServiceCentralizedImpl.java | 81 +- .../portalsdk/core/service/LoginServiceImpl.java | 262 ++-- .../portalsdk/core/service/PostDroolsService.java | 10 +- .../core/service/PostDroolsServiceImpl.java | 93 +- .../portalsdk/core/service/PostSearchService.java | 4 +- .../core/service/PostSearchServiceImpl.java | 4 +- .../portalsdk/core/service/ProfileService.java | 32 +- .../service/ProfileServiceCentralizedImpl.java | 50 +- .../portalsdk/core/service/ProfileServiceImpl.java | 31 +- .../core/service/RestApiRequestBuilder.java | 41 +- .../onap/portalsdk/core/service/RoleService.java | 107 +- .../core/service/RoleServiceCentralizedAccess.java | 79 +- .../portalsdk/core/service/RoleServiceImpl.java | 50 +- .../onap/portalsdk/core/service/UrlAccessImpl.java | 9 +- .../portalsdk/core/service/UrlAccessService.java | 8 +- .../portalsdk/core/service/UserProfileService.java | 9 +- .../core/service/UserProfileServiceImpl.java | 77 +- .../onap/portalsdk/core/service/UserService.java | 9 +- .../core/service/UserServiceCentalizedImpl.java | 13 +- .../portalsdk/core/service/UserServiceImpl.java | 10 +- .../core/service/WebServiceCallService.java | 9 +- .../core/service/WebServiceCallServiceImpl.java | 152 +- .../core/service/support/FusionService.java | 7 +- .../core/service/support/ServiceLocator.java | 5 +- .../core/service/support/ServiceLocatorImpl.java | 110 +- .../org/onap/portalsdk/core/util/CacheManager.java | 37 +- .../onap/portalsdk/core/util/EncDecUtilTest.java | 141 +- .../org/onap/portalsdk/core/util/JSONUtil.java | 19 +- .../onap/portalsdk/core/util/SystemProperties.java | 173 +-- .../org/onap/portalsdk/core/util/UsageUtils.java | 94 +- .../org/onap/portalsdk/core/util/YamlUtils.java | 46 +- .../core/web/socket/PeerBroadcastSocket.java | 26 +- .../portalsdk/core/web/socket/WebRTCSocket.java | 192 ++- .../onap/portalsdk/core/web/support/AppUtils.java | 278 ++-- .../core/web/support/ControllerProperties.java | 38 +- .../core/web/support/FeedbackMessage.java | 88 +- .../portalsdk/core/web/support/JsonMessage.java | 32 +- .../portalsdk/core/web/support/MessagesList.java | 105 +- .../onap/portalsdk/core/web/support/UserUtils.java | 64 +- .../portalsdk/MockApplicationContextTestSuite.java | 4 +- .../portalsdk/MockHibernateMappingLocations.java | 4 +- .../onboarding/crossapi/IPortalRestAPIService.java | 4 +- .../onboarding/crossapi/IPortalUebAPIService.java | 4 +- .../onboarding/crossapi/PortalAPIResponse.java | 10 +- .../onboarding/crossapi/PortalRestAPIProxy.java | 59 +- .../crossapi/SessionCommunicationService.java | 18 +- .../onboarding/exception/CipherUtilException.java | 4 +- .../onboarding/exception/PortalAPIException.java | 4 +- .../listener/PortalTimeoutBindingListener.java | 8 +- .../onboarding/listener/PortalTimeoutHandler.java | 48 +- .../onboarding/listener/UserContextListener.java | 8 +- .../onboarding/listener/UserSessionListener.java | 8 +- .../core/onboarding/rest/FavoritesClient.java | 4 +- .../core/onboarding/rest/FunctionalMenuClient.java | 4 +- .../core/onboarding/rest/RestWebServiceClient.java | 29 +- .../portalsdk/core/onboarding/util/CipherUtil.java | 10 +- .../core/onboarding/util/PortalApiConstants.java | 4 +- .../core/onboarding/util/PortalApiProperties.java | 4 +- .../portalsdk/core/onboarding/util/SSOFilter.java | 21 +- .../portalsdk/core/onboarding/util/SSOUtil.java | 6 +- .../portalsdk/core/restful/domain/EcompRole.java | 5 +- .../portalsdk/core/restful/domain/EcompUser.java | 16 +- .../core/restful/domain/PortalTimeoutVO.java | 27 +- .../core/restful/domain/SharedContext.java | 19 +- .../controller/NotebookController.java | 19 +- .../controller/NotebookTestController.java | 20 +- .../controller/RNoteBookController.java | 74 +- .../controller/RNoteBookFEController.java | 89 +- .../domain/RNoteBookCredentials.java | 5 +- .../exception/RNotebookIntegrationException.java | 18 +- .../service/RNoteBookIntegrationService.java | 9 +- .../service/RNoteBookIntegrationServiceImpl.java | 117 +- .../workflow/controllers/WorkflowController.java | 79 +- .../onap/portalsdk/workflow/dao/WorkflowDAO.java | 4 +- .../portalsdk/workflow/dao/WorkflowDAOImpl.java | 129 +- .../workflow/domain/WorkflowSchedule.java | 48 +- .../onap/portalsdk/workflow/models/Workflow.java | 4 +- .../portalsdk/workflow/models/WorkflowLite.java | 4 +- .../workflow/scheduler/WorkFlowScheduleJob.java | 19 +- .../scheduler/WorkFlowScheduleRegistry.java | 33 +- .../services/WorkflowScheduleExecutor.java | 92 +- .../workflow/services/WorkflowScheduleService.java | 4 +- .../services/WorkflowScheduleServiceImpl.java | 93 +- .../workflow/services/WorkflowService.java | 4 +- .../workflow/services/WorkflowServiceImpl.java | 18 +- 468 files changed, 8317 insertions(+), 9701 deletions(-) delete mode 100644 ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/session/TestClass.java delete mode 100644 ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/sso/TestClass.java diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/AntBuild.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/AntBuild.java index aee59fc5..e303749f 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/AntBuild.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/AntBuild.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -42,7 +42,6 @@ import java.net.URL; import java.util.Iterator; import java.util.Map; import java.util.jar.Attributes; -import java.util.jar.JarFile; import java.util.jar.Manifest; /** diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/RaptorObject.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/RaptorObject.java index 8a54e8bc..fcf2fed8 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/RaptorObject.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/RaptorObject.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/config/ConfigLoader.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/config/ConfigLoader.java index af8d3803..c200c443 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/config/ConfigLoader.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/config/ConfigLoader.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,12 +37,16 @@ */ package org.onap.portalsdk.analytics.config; -import java.io.*; -import java.util.*; -import javax.servlet.*; +import java.io.BufferedReader; +import java.io.IOException; +import java.io.StringReader; +import java.util.Properties; -import org.onap.portalsdk.analytics.controller.*; -import org.onap.portalsdk.analytics.util.*; +import javax.servlet.ServletContext; + +import org.onap.portalsdk.analytics.controller.Action; +import org.onap.portalsdk.analytics.controller.ActionMapping; +import org.onap.portalsdk.analytics.util.Log; public class ConfigLoader { // public static final String RAPTOR_ACTION_MAP = diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/Action.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/Action.java index 2ab3be26..4bd11e09 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/Action.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/Action.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,9 +37,7 @@ */ package org.onap.portalsdk.analytics.controller; -import java.util.*; - -import org.onap.portalsdk.analytics.system.*; +import java.util.StringTokenizer; public class Action extends org.onap.portalsdk.analytics.RaptorObject { private String action = null; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/ActionHandler.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/ActionHandler.java index 0d5ef418..f8f06294 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/ActionHandler.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/ActionHandler.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/ActionMapping.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/ActionMapping.java index f6eae35b..663c4bdb 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/ActionMapping.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/ActionMapping.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,7 +37,7 @@ */ package org.onap.portalsdk.analytics.controller; -import java.util.*; +import java.util.HashMap; public class ActionMapping extends HashMap { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/Controller.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/Controller.java index 09f5186a..eb6b469b 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/Controller.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/Controller.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/ErrorHandler.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/ErrorHandler.java index e08c21fb..8e3fd8ee 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/ErrorHandler.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/ErrorHandler.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -40,15 +40,19 @@ package org.onap.portalsdk.analytics.controller; import java.io.PrintWriter; import java.io.StringWriter; import java.io.Writer; -import java.util.*; -import javax.servlet.http.*; +import java.util.ArrayList; -import org.onap.portalsdk.analytics.error.*; +import javax.servlet.http.HttpServletRequest; +import javax.servlet.http.HttpSession; + +import org.onap.portalsdk.analytics.error.RaptorException; +import org.onap.portalsdk.analytics.error.ReportSQLException; import org.onap.portalsdk.analytics.model.definition.ReportDefinition; import org.onap.portalsdk.analytics.model.runtime.ErrorJSONRuntime; import org.onap.portalsdk.analytics.model.runtime.ReportRuntime; -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; +import org.onap.portalsdk.analytics.system.AppUtils; +import org.onap.portalsdk.analytics.system.Globals; +import org.onap.portalsdk.analytics.util.AppConstants; import org.onap.portalsdk.core.logging.format.AlarmSeverityEnum; import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardProcessor.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardProcessor.java index 11a58e73..1496b9fa 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardProcessor.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardProcessor.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequence.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequence.java index 7463598e..63328d52 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequence.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequence.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,12 +37,10 @@ */ package org.onap.portalsdk.analytics.controller; -import java.util.*; +import java.util.Vector; -import org.onap.portalsdk.analytics.model.base.*; -import org.onap.portalsdk.analytics.model.definition.*; -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; +import org.onap.portalsdk.analytics.model.definition.ReportDefinition; +import org.onap.portalsdk.analytics.util.AppConstants; public class WizardSequence extends Vector { // private String currentStep = AppConstants.WS_DEFINITION; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceCrossTab.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceCrossTab.java index 641b0f60..d47cfaef 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceCrossTab.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceCrossTab.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,10 +37,8 @@ */ package org.onap.portalsdk.analytics.controller; -import java.util.*; - -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; +import org.onap.portalsdk.analytics.system.Globals; +import org.onap.portalsdk.analytics.util.AppConstants; public class WizardSequenceCrossTab extends WizardSequence { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceDashboard.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceDashboard.java index 6d27eab1..099c88b0 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceDashboard.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceDashboard.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,10 +37,8 @@ */ package org.onap.portalsdk.analytics.controller; -import java.util.*; - -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; +import org.onap.portalsdk.analytics.system.Globals; +import org.onap.portalsdk.analytics.util.AppConstants; public class WizardSequenceDashboard extends WizardSequence { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceLinear.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceLinear.java index f1dfa580..dd32bfb4 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceLinear.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceLinear.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,10 +37,8 @@ */ package org.onap.portalsdk.analytics.controller; -import java.util.*; - -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; +import org.onap.portalsdk.analytics.system.Globals; +import org.onap.portalsdk.analytics.util.AppConstants; public class WizardSequenceLinear extends WizardSequence { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceSQLBasedCrossTab.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceSQLBasedCrossTab.java index db10147d..6846f2ca 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceSQLBasedCrossTab.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceSQLBasedCrossTab.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,10 +37,8 @@ */ package org.onap.portalsdk.analytics.controller; -import java.util.*; - -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; +import org.onap.portalsdk.analytics.system.Globals; +import org.onap.portalsdk.analytics.util.AppConstants; public class WizardSequenceSQLBasedCrossTab extends WizardSequence { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceSQLBasedHive.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceSQLBasedHive.java index 2243257d..08cdc20c 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceSQLBasedHive.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceSQLBasedHive.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,10 +37,8 @@ */ package org.onap.portalsdk.analytics.controller; -import java.util.*; - -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; +import org.onap.portalsdk.analytics.system.Globals; +import org.onap.portalsdk.analytics.util.AppConstants; public class WizardSequenceSQLBasedHive extends WizardSequence { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceSQLBasedLinear.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceSQLBasedLinear.java index 4f30d312..e0735ca5 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceSQLBasedLinear.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceSQLBasedLinear.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,10 +37,8 @@ */ package org.onap.portalsdk.analytics.controller; -import java.util.*; - -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; +import org.onap.portalsdk.analytics.system.Globals; +import org.onap.portalsdk.analytics.util.AppConstants; public class WizardSequenceSQLBasedLinear extends WizardSequence { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceSQLBasedLinearDatamining.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceSQLBasedLinearDatamining.java index 2feea9a4..103b7378 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceSQLBasedLinearDatamining.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/controller/WizardSequenceSQLBasedLinearDatamining.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,10 +37,8 @@ */ package org.onap.portalsdk.analytics.controller; -import java.util.*; - -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; +import org.onap.portalsdk.analytics.system.Globals; +import org.onap.portalsdk.analytics.util.AppConstants; public class WizardSequenceSQLBasedLinearDatamining extends WizardSequence { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/RaptorException.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/RaptorException.java index 4d192c25..e6f467e7 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/RaptorException.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/RaptorException.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/RaptorRuntimeException.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/RaptorRuntimeException.java index 111d045a..d45133ae 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/RaptorRuntimeException.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/RaptorRuntimeException.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/RaptorSchedularException.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/RaptorSchedularException.java index fe8c9b31..c5850086 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/RaptorSchedularException.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/RaptorSchedularException.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/ReportSQLException.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/ReportSQLException.java index 7475df48..ced28547 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/ReportSQLException.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/ReportSQLException.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/UserAccessException.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/UserAccessException.java index 7cae7f0b..9c0484db 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/UserAccessException.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/UserAccessException.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/UserDefinedException.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/UserDefinedException.java index 7675d8db..a2bdb7e2 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/UserDefinedException.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/UserDefinedException.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/ValidationException.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/ValidationException.java index 6dd7e601..1c872391 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/ValidationException.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/error/ValidationException.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/line/Line.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/line/Line.java index 31bfa81b..3a7de5d8 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/line/Line.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/line/Line.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/line/LineCollection.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/line/LineCollection.java index cead8219..bacd9152 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/line/LineCollection.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/line/LineCollection.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/line/LineInfo.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/line/LineInfo.java index e19fe349..5b9a0558 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/line/LineInfo.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/line/LineInfo.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/ColorProperties.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/ColorProperties.java index d620fbd7..02b24533 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/ColorProperties.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/ColorProperties.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/GMapProperties.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/GMapProperties.java index 412cc813..0058277e 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/GMapProperties.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/GMapProperties.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,9 +37,6 @@ */ package org.onap.portalsdk.analytics.gmap.map; -import java.io.InputStream; -import java.util.Properties; - import org.onap.portalsdk.analytics.system.Globals; public class GMapProperties { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/GeoCoordinate.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/GeoCoordinate.java index a7d7d984..e40e8077 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/GeoCoordinate.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/GeoCoordinate.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/MapConstant.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/MapConstant.java index d56194c6..f0b71aec 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/MapConstant.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/MapConstant.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/NovaMap.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/NovaMap.java index 6938273f..38db8eaf 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/NovaMap.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/NovaMap.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/layer/SwingLayer.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/layer/SwingLayer.java index df3623be..ccc159b2 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/layer/SwingLayer.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/map/layer/SwingLayer.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -41,7 +41,6 @@ import java.awt.Color; import java.awt.Font; import java.awt.FontMetrics; import java.awt.Graphics2D; -import java.awt.Point; import java.awt.Rectangle; import java.awt.Stroke; import java.awt.geom.Point2D; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/node/Node.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/node/Node.java index 6188cee1..82d811c1 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/node/Node.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/node/Node.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/node/NodeCollection.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/node/NodeCollection.java index c54b268a..46830624 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/node/NodeCollection.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/node/NodeCollection.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/node/NodeInfo.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/node/NodeInfo.java index 0ed7b842..7d646f39 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/node/NodeInfo.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/node/NodeInfo.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/utils/MapUtils.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/utils/MapUtils.java index 277dac0f..84f79c0b 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/utils/MapUtils.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/utils/MapUtils.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,14 +37,7 @@ */ package org.onap.portalsdk.analytics.gmap.utils; -import java.io.ObjectOutputStream; import java.text.SimpleDateFormat; -import java.util.Calendar; -import java.util.HashMap; -import java.util.Locale; -import java.util.Map; - -import javax.servlet.http.HttpServletRequest; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/utils/SwingWorker.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/utils/SwingWorker.java index eeac444c..999a7232 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/utils/SwingWorker.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/utils/SwingWorker.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/DataCache.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/DataCache.java index e5677b7a..269b91f1 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/DataCache.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/DataCache.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,17 +37,25 @@ */ package org.onap.portalsdk.analytics.model; -import java.util.*; +import java.util.HashMap; +import java.util.Iterator; +import java.util.Vector; import javax.servlet.http.HttpServletRequest; import org.onap.portalsdk.analytics.error.RaptorException; import org.onap.portalsdk.analytics.error.ReportSQLException; -import org.onap.portalsdk.analytics.model.base.*; -import org.onap.portalsdk.analytics.model.definition.*; -import org.onap.portalsdk.analytics.model.runtime.*; -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; +import org.onap.portalsdk.analytics.model.base.IdNameValue; +import org.onap.portalsdk.analytics.model.definition.DBColumnInfo; +import org.onap.portalsdk.analytics.model.definition.TableJoin; +import org.onap.portalsdk.analytics.model.definition.TableSource; +import org.onap.portalsdk.analytics.model.runtime.LookupDBInfo; +import org.onap.portalsdk.analytics.system.AppUtils; +import org.onap.portalsdk.analytics.system.ConnectionUtils; +import org.onap.portalsdk.analytics.system.DbUtils; +import org.onap.portalsdk.analytics.system.Globals; +import org.onap.portalsdk.analytics.util.AppConstants; +import org.onap.portalsdk.analytics.util.DataSet; public class DataCache extends org.onap.portalsdk.analytics.RaptorObject { private static Vector dataViewActions = null; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/ReportHandler.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/ReportHandler.java index 1d173784..c81ac0cd 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/ReportHandler.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/ReportHandler.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/ReportLoader.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/ReportLoader.java index fa30fc32..c772d308 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/ReportLoader.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/ReportLoader.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/SearchHandler.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/SearchHandler.java index 5d71d147..21c260bd 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/SearchHandler.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/SearchHandler.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -61,16 +61,28 @@ */ package org.onap.portalsdk.analytics.model; -import java.io.*; -import java.sql.*; -import java.util.*; -import javax.servlet.http.*; +import java.io.BufferedWriter; +import java.io.FileWriter; +import java.io.IOException; +import java.io.PrintWriter; +import java.io.Writer; +import java.util.Iterator; -import org.onap.portalsdk.analytics.controller.*; +import javax.servlet.http.HttpServletRequest; + +import org.onap.portalsdk.analytics.controller.ErrorHandler; import org.onap.portalsdk.analytics.error.RaptorException; -import org.onap.portalsdk.analytics.model.search.*; -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; +import org.onap.portalsdk.analytics.model.search.ReportSearchResult; +import org.onap.portalsdk.analytics.model.search.ReportSearchResultJSON; +import org.onap.portalsdk.analytics.model.search.SearchResultColumn; +import org.onap.portalsdk.analytics.model.search.SearchResultField; +import org.onap.portalsdk.analytics.model.search.SearchResultRow; +import org.onap.portalsdk.analytics.system.AppUtils; +import org.onap.portalsdk.analytics.system.DbUtils; +import org.onap.portalsdk.analytics.system.Globals; +import org.onap.portalsdk.analytics.util.AppConstants; +import org.onap.portalsdk.analytics.util.DataSet; +import org.onap.portalsdk.analytics.util.HtmlStripper; public class SearchHandler extends org.onap.portalsdk.analytics.RaptorObject { private static final String HTML_FORM = "forma"; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/ChartSeqComparator.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/ChartSeqComparator.java index 7e6246ce..40de5973 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/ChartSeqComparator.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/ChartSeqComparator.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/IdNameColLookup.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/IdNameColLookup.java index aef09763..11ea3f66 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/IdNameColLookup.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/IdNameColLookup.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,8 +37,6 @@ */ package org.onap.portalsdk.analytics.model.base; -import java.util.*; - public class IdNameColLookup extends IdNameLookup { private String colId = null; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/IdNameList.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/IdNameList.java index 3e88a8c1..b53d956c 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/IdNameList.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/IdNameList.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,10 +37,10 @@ */ package org.onap.portalsdk.analytics.model.base; -import java.util.*; +import java.util.Vector; import org.onap.portalsdk.analytics.error.RaptorException; -import org.onap.portalsdk.analytics.system.*; +import org.onap.portalsdk.analytics.system.Globals; public class IdNameList extends Vector { protected int pageNo = -1; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/IdNameLookup.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/IdNameLookup.java index 69179e33..b8eb401d 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/IdNameLookup.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/IdNameLookup.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,13 +37,7 @@ */ package org.onap.portalsdk.analytics.model.base; -import java.util.*; - import org.onap.portalsdk.analytics.error.RaptorException; -import org.onap.portalsdk.analytics.model.*; -import org.onap.portalsdk.analytics.model.runtime.*; -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; public class IdNameLookup extends IdNameSql { private String dbTableName = null; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/IdNameSql.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/IdNameSql.java index ec063a80..d76faf53 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/IdNameSql.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/IdNameSql.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/IdNameValue.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/IdNameValue.java index 2e1dfb13..ff52efa2 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/IdNameValue.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/IdNameValue.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/NameComparator.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/NameComparator.java index ed0c3975..3b8efe36 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/NameComparator.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/NameComparator.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -39,8 +39,6 @@ package org.onap.portalsdk.analytics.model.base; import java.util.Comparator; -import org.onap.portalsdk.analytics.model.base.IdNameValue; - public class NameComparator implements Comparator { public int compare(Object o1, Object o2) { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/OrderBySeqComparator.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/OrderBySeqComparator.java index 3ec14321..28d74c2a 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/OrderBySeqComparator.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/OrderBySeqComparator.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/OrderSeqComparator.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/OrderSeqComparator.java index 66aa2a22..dd9d5015 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/OrderSeqComparator.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/OrderSeqComparator.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/ReportSecurity.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/ReportSecurity.java index a7ef8592..a9abd558 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/ReportSecurity.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/ReportSecurity.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/ReportUserRole.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/ReportUserRole.java index 2d6bd6d4..60be0520 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/ReportUserRole.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/ReportUserRole.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,24 +37,12 @@ */ package org.onap.portalsdk.analytics.model.base; -import java.io.*; -import java.sql.*; -import java.util.*; +import java.io.Serializable; import javax.persistence.Entity; import javax.persistence.GeneratedValue; import javax.persistence.GenerationType; import javax.persistence.Id; -import javax.servlet.http.HttpServletRequest; -import javax.servlet.http.HttpSession; - -import org.onap.portalsdk.analytics.controller.ActionHandler; -import org.onap.portalsdk.analytics.error.*; -import org.onap.portalsdk.analytics.model.base.*; -import org.onap.portalsdk.analytics.model.definition.*; -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; -import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate; @Entity public class ReportUserRole extends org.onap.portalsdk.analytics.RaptorObject implements Serializable { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/ReportWrapper.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/ReportWrapper.java index 7dcf1afc..a17e411a 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/ReportWrapper.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/base/ReportWrapper.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/DBColumnInfo.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/DBColumnInfo.java index 6d02a1d5..181e83a1 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/DBColumnInfo.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/DBColumnInfo.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/DrillDownParamDef.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/DrillDownParamDef.java index b024b487..85fe1b49 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/DrillDownParamDef.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/DrillDownParamDef.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/Marker.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/Marker.java index 8cea0b56..8fd1f390 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/Marker.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/Marker.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportDefinition.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportDefinition.java index 9e8a6c94..0f7ffac9 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportDefinition.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportDefinition.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportLogEntry.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportLogEntry.java index 3704e38c..b2005314 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportLogEntry.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportLogEntry.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportMap.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportMap.java index 8a294e99..7b25daaa 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportMap.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportMap.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -38,13 +38,9 @@ package org.onap.portalsdk.analytics.model.definition; import java.util.ArrayList; -import java.util.HashMap; import java.util.List; import org.onap.portalsdk.analytics.RaptorObject; -import org.onap.portalsdk.analytics.view.DataRow; -import org.onap.portalsdk.analytics.view.DataValue; -import org.onap.portalsdk.analytics.view.ReportData; public class ReportMap extends RaptorObject { String markerColor = ""; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportSchedule.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportSchedule.java index 23cf79f5..e9a4df1f 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportSchedule.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/ReportSchedule.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/SecurityEntry.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/SecurityEntry.java index bd4d1549..8be6a410 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/SecurityEntry.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/SecurityEntry.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,7 +37,7 @@ */ package org.onap.portalsdk.analytics.model.definition; -import org.onap.portalsdk.analytics.model.base.*; +import org.onap.portalsdk.analytics.model.base.IdNameValue; public class SecurityEntry extends IdNameValue { private boolean readOnly = true; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/TableJoin.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/TableJoin.java index 6032d5a1..bc2b8d16 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/TableJoin.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/TableJoin.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/TableSource.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/TableSource.java index 4ca177e8..be15b71a 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/TableSource.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/TableSource.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/ColumnEditJSON.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/ColumnEditJSON.java index d3478d77..6daa4b41 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/ColumnEditJSON.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/ColumnEditJSON.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/ColumnJSON.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/ColumnJSON.java index 97347037..38fcba4f 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/ColumnJSON.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/ColumnJSON.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/DefinitionJSON.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/DefinitionJSON.java index 351192b5..c95c71bc 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/DefinitionJSON.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/DefinitionJSON.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/ElementJSON.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/ElementJSON.java index a0bee600..53b362ff 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/ElementJSON.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/ElementJSON.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,11 +37,6 @@ */ package org.onap.portalsdk.analytics.model.definition.wizard; -import java.util.ArrayList; -import java.util.Map; - -import org.onap.portalsdk.analytics.view.ColumnHeader; - public interface ElementJSON { // To be defined by child class diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/FormEditJSON.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/FormEditJSON.java index 3d2dc41a..c69edc0b 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/FormEditJSON.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/FormEditJSON.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/IdNameBooleanJSON.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/IdNameBooleanJSON.java index e18302cc..0c7e8982 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/IdNameBooleanJSON.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/IdNameBooleanJSON.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/ImportJSON.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/ImportJSON.java index 66bbb7e7..cc398b85 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/ImportJSON.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/ImportJSON.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,8 +37,6 @@ */ package org.onap.portalsdk.analytics.model.definition.wizard; -import java.util.List; - public class ImportJSON implements WizardJSON { private String tabId; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/ListJSON.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/ListJSON.java index 4a842958..f3e2449c 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/ListJSON.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/ListJSON.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -38,9 +38,6 @@ package org.onap.portalsdk.analytics.model.definition.wizard; import java.util.ArrayList; -import java.util.Map; - -import org.onap.portalsdk.analytics.view.ColumnHeader; public class ListJSON { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/MessageJSON.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/MessageJSON.java index c5891b2e..799cd6fa 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/MessageJSON.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/MessageJSON.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,21 +37,6 @@ */ package org.onap.portalsdk.analytics.model.definition.wizard; -import java.util.ArrayList; -import java.util.Calendar; -import java.util.Map; - -import javax.xml.bind.annotation.XmlAttribute; -import javax.xml.bind.annotation.XmlElement; - -import org.json.JSONObject; -import org.onap.portalsdk.analytics.model.base.IdNameValue; -import org.onap.portalsdk.analytics.view.ColumnHeader; -import org.onap.portalsdk.analytics.view.DataValue; -import org.onap.portalsdk.analytics.xmlobj.ColFilterList; -import org.onap.portalsdk.analytics.xmlobj.DataColumnList; -import org.onap.portalsdk.analytics.xmlobj.DataColumnType; - public class MessageJSON { private String message; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/NameBooleanJSON.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/NameBooleanJSON.java index f74f9671..e18fbaca 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/NameBooleanJSON.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/NameBooleanJSON.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/QueryJSON.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/QueryJSON.java index d2df77c0..5edb16c1 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/QueryJSON.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/QueryJSON.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,12 +37,6 @@ */ package org.onap.portalsdk.analytics.model.definition.wizard; -import java.util.ArrayList; -import java.util.Map; - -import org.onap.portalsdk.analytics.model.definition.wizard.WizardJSON; -import org.onap.portalsdk.analytics.view.ColumnHeader; - public class QueryJSON implements WizardJSON { private String query; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/QueryResultJSON.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/QueryResultJSON.java index 794e9813..ebc23003 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/QueryResultJSON.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/QueryResultJSON.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -40,8 +40,6 @@ package org.onap.portalsdk.analytics.model.definition.wizard; import java.util.ArrayList; import java.util.Map; -import org.onap.portalsdk.analytics.view.ColumnHeader; - public class QueryResultJSON { private String query; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/RaptorError.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/RaptorError.java index b04f4d45..589b5e53 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/RaptorError.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/RaptorError.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/RaptorResponse.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/RaptorResponse.java index d14f4d1a..0ddac587 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/RaptorResponse.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/RaptorResponse.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/SearchFieldJSON.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/SearchFieldJSON.java index 948188cd..78223d5c 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/SearchFieldJSON.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/SearchFieldJSON.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/WizardJSON.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/WizardJSON.java index 0781f3f5..70958bf6 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/WizardJSON.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/definition/wizard/WizardJSON.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/pdf/PageEvent.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/pdf/PageEvent.java index 91bdb09a..296df6df 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/pdf/PageEvent.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/pdf/PageEvent.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/pdf/PdfBean.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/pdf/PdfBean.java index ccfd06ca..290f3354 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/pdf/PdfBean.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/pdf/PdfBean.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/pdf/PdfReportHandler.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/pdf/PdfReportHandler.java index f4c2b8a6..90c5e61c 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/pdf/PdfReportHandler.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/pdf/PdfReportHandler.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/BarChartOptions.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/BarChartOptions.java index 7879be48..08ab369d 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/BarChartOptions.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/BarChartOptions.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/CategoryAxisJSON.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/CategoryAxisJSON.java index f529aa1b..1095979e 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/CategoryAxisJSON.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/CategoryAxisJSON.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ChartD3Helper.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ChartD3Helper.java index 4660b4f7..1a8da8d0 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ChartD3Helper.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ChartD3Helper.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ChartJSON.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ChartJSON.java index 194d84e5..62cab08d 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ChartJSON.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ChartJSON.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -38,9 +38,6 @@ package org.onap.portalsdk.analytics.model.runtime; import java.util.ArrayList; -import java.util.Map; - -import org.onap.portalsdk.analytics.view.ColumnHeader; class Row { private String displayValue; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ChartJSONHelper.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ChartJSONHelper.java index eedaa6bd..59ae4996 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ChartJSONHelper.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ChartJSONHelper.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ChartWebRuntime.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ChartWebRuntime.java index e023b8c0..3329528d 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ChartWebRuntime.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ChartWebRuntime.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -53,13 +53,10 @@ import javax.servlet.http.HttpSession; import org.onap.portalsdk.analytics.error.RaptorException; import org.onap.portalsdk.analytics.model.ReportHandler; -import org.onap.portalsdk.analytics.model.runtime.ReportRuntime; import org.onap.portalsdk.analytics.system.AppUtils; import org.onap.portalsdk.analytics.util.AppConstants; import org.onap.portalsdk.analytics.view.ReportData; import org.onap.portalsdk.core.web.support.UserUtils; -import org.springframework.web.context.request.RequestContextHolder; -import org.springframework.web.context.request.ServletRequestAttributes; public class ChartWebRuntime implements Serializable { @@ -95,7 +92,7 @@ public class ChartWebRuntime implements Serializable { private String drilldown_index = "0"; public List getRolesCommaSeperated(HttpServletRequest request) { - HashMap roles = UserUtils.getRoles(request); + Map roles = UserUtils.getRoles(request); List roleList = null; StringBuffer roleBuf = new StringBuffer(""); int count = 0; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/CommonChartOptions.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/CommonChartOptions.java index 35429211..90dd0a5b 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/CommonChartOptions.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/CommonChartOptions.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ErrorJSONRuntime.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ErrorJSONRuntime.java index dd1f68d3..441c5f24 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ErrorJSONRuntime.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ErrorJSONRuntime.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,21 +37,6 @@ */ package org.onap.portalsdk.analytics.model.runtime; -import java.util.ArrayList; -import java.util.Calendar; -import java.util.Map; - -import javax.xml.bind.annotation.XmlAttribute; -import javax.xml.bind.annotation.XmlElement; - -import org.json.JSONObject; -import org.onap.portalsdk.analytics.model.base.IdNameValue; -import org.onap.portalsdk.analytics.view.ColumnHeader; -import org.onap.portalsdk.analytics.view.DataValue; -import org.onap.portalsdk.analytics.xmlobj.ColFilterList; -import org.onap.portalsdk.analytics.xmlobj.DataColumnList; -import org.onap.portalsdk.analytics.xmlobj.DataColumnType; - public class ErrorJSONRuntime { private String errormessage; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/FlexTimeSeriesChartOptions.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/FlexTimeSeriesChartOptions.java index d0329c91..073e63d9 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/FlexTimeSeriesChartOptions.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/FlexTimeSeriesChartOptions.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/FormField.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/FormField.java index f38bceae..b8c681a8 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/FormField.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/FormField.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -62,20 +62,28 @@ package org.onap.portalsdk.analytics.model.runtime; import java.io.Serializable; import java.io.UnsupportedEncodingException; import java.text.SimpleDateFormat; -import java.util.*; +import java.util.Calendar; +import java.util.HashMap; +import java.util.Iterator; +import java.util.List; +import java.util.Map; import java.util.Map.Entry; +import java.util.Set; import java.util.regex.Matcher; import java.util.regex.Pattern; -import javax.swing.text.html.HTMLDocument.HTMLReader.HiddenAction; - -import org.onap.portalsdk.analytics.error.RaptorException; import org.onap.portalsdk.analytics.error.RaptorRuntimeException; import org.onap.portalsdk.analytics.error.UserDefinedException; -import org.onap.portalsdk.analytics.model.base.*; -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; -import org.onap.portalsdk.analytics.xmlobj.*; +import org.onap.portalsdk.analytics.model.base.IdNameList; +import org.onap.portalsdk.analytics.model.base.IdNameLookup; +import org.onap.portalsdk.analytics.model.base.IdNameSql; +import org.onap.portalsdk.analytics.model.base.IdNameValue; +import org.onap.portalsdk.analytics.system.AppUtils; +import org.onap.portalsdk.analytics.system.ConnectionUtils; +import org.onap.portalsdk.analytics.system.Globals; +import org.onap.portalsdk.analytics.util.DataSet; +import org.onap.portalsdk.analytics.util.Utils; +import org.onap.portalsdk.analytics.xmlobj.JavascriptItemType; public class FormField extends org.onap.portalsdk.analytics.RaptorObject implements Serializable { private static final String HTML_FORM = "formd"; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/FormatProcessor.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/FormatProcessor.java index 4633b255..06785529 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/FormatProcessor.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/FormatProcessor.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,13 +37,19 @@ */ package org.onap.portalsdk.analytics.model.runtime; -import java.util.*; - -import org.onap.portalsdk.analytics.*; -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; -import org.onap.portalsdk.analytics.view.*; -import org.onap.portalsdk.analytics.xmlobj.*; +import java.util.HashMap; +import java.util.Iterator; + +import org.onap.portalsdk.analytics.RaptorObject; +import org.onap.portalsdk.analytics.system.DbUtils; +import org.onap.portalsdk.analytics.system.Globals; +import org.onap.portalsdk.analytics.util.AppConstants; +import org.onap.portalsdk.analytics.util.DataSet; +import org.onap.portalsdk.analytics.view.DataRow; +import org.onap.portalsdk.analytics.view.DataValue; +import org.onap.portalsdk.analytics.view.HtmlFormatter; +import org.onap.portalsdk.analytics.xmlobj.FormatType; +import org.onap.portalsdk.analytics.xmlobj.SemaphoreType; public class FormatProcessor extends RaptorObject { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/Item.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/Item.java index 90b90340..95294003 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/Item.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/Item.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/LookupDBInfo.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/LookupDBInfo.java index 65e4ba1f..3ab58d59 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/LookupDBInfo.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/LookupDBInfo.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/RangeAxisJSON.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/RangeAxisJSON.java index 719a2c89..5a7db495 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/RangeAxisJSON.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/RangeAxisJSON.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportFormFields.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportFormFields.java index 056c518b..0693a1c7 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportFormFields.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportFormFields.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,16 +37,26 @@ */ package org.onap.portalsdk.analytics.model.runtime; -import java.util.*; -import javax.servlet.http.*; +import java.util.Calendar; +import java.util.Collections; +import java.util.Iterator; +import java.util.List; +import java.util.Vector; + +import javax.servlet.http.HttpServletRequest; import org.onap.portalsdk.analytics.error.RaptorException; -import org.onap.portalsdk.analytics.model.*; -import org.onap.portalsdk.analytics.model.base.*; -import org.onap.portalsdk.analytics.model.definition.*; -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; -import org.onap.portalsdk.analytics.xmlobj.*; +import org.onap.portalsdk.analytics.model.DataCache; +import org.onap.portalsdk.analytics.model.base.ReportWrapper; +import org.onap.portalsdk.analytics.system.AppUtils; +import org.onap.portalsdk.analytics.system.ConnectionUtils; +import org.onap.portalsdk.analytics.system.Globals; +import org.onap.portalsdk.analytics.util.AppConstants; +import org.onap.portalsdk.analytics.util.DataSet; +import org.onap.portalsdk.analytics.util.Utils; +import org.onap.portalsdk.analytics.xmlobj.ColFilterType; +import org.onap.portalsdk.analytics.xmlobj.DataColumnType; +import org.onap.portalsdk.analytics.xmlobj.FormFieldType; public class ReportFormFields extends Vector { private int nextElemIdx = 0; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportJSONRuntime.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportJSONRuntime.java index 8c245625..7c8f9424 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportJSONRuntime.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportJSONRuntime.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -41,16 +41,8 @@ import java.util.ArrayList; import java.util.Calendar; import java.util.Map; -import javax.xml.bind.annotation.XmlAttribute; -import javax.xml.bind.annotation.XmlElement; - -import org.json.JSONObject; import org.onap.portalsdk.analytics.model.base.IdNameValue; import org.onap.portalsdk.analytics.view.ColumnHeader; -import org.onap.portalsdk.analytics.view.DataValue; -import org.onap.portalsdk.analytics.xmlobj.ColFilterList; -import org.onap.portalsdk.analytics.xmlobj.DataColumnList; -import org.onap.portalsdk.analytics.xmlobj.DataColumnType; /*class MetaColumn { private String tableId; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportParamDateValueParser.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportParamDateValueParser.java index 8eb6c06d..206eab0f 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportParamDateValueParser.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportParamDateValueParser.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,16 +37,14 @@ */ package org.onap.portalsdk.analytics.model.runtime; -import java.text.DateFormat; import java.text.ParseException; import java.text.SimpleDateFormat; -import java.util.*; -import javax.servlet.http.*; +import java.util.Date; +import java.util.GregorianCalendar; -import org.onap.portalsdk.analytics.model.base.*; import org.onap.portalsdk.analytics.system.Globals; -import org.onap.portalsdk.analytics.util.*; -import org.onap.portalsdk.analytics.xmlobj.*; +import org.onap.portalsdk.analytics.util.AppConstants; +import org.onap.portalsdk.analytics.util.Utils; public class ReportParamDateValueParser { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportParamValues.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportParamValues.java index d0a3f613..d8a8c84b 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportParamValues.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportParamValues.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportParamValuesForPDFExcel.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportParamValuesForPDFExcel.java index 20e0e4dc..d5911cbb 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportParamValuesForPDFExcel.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportParamValuesForPDFExcel.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportRuntime.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportRuntime.java index 3be0b8cd..2b01821e 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportRuntime.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/ReportRuntime.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/TimeSeriesChartOptions.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/TimeSeriesChartOptions.java index 3702cb38..b1284648 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/TimeSeriesChartOptions.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/TimeSeriesChartOptions.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/VisualManager.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/VisualManager.java index 521dced8..7036b254 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/VisualManager.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/runtime/VisualManager.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,11 +37,10 @@ */ package org.onap.portalsdk.analytics.model.runtime; -import java.util.*; +import java.util.HashMap; -import org.onap.portalsdk.analytics.*; -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; +import org.onap.portalsdk.analytics.RaptorObject; +import org.onap.portalsdk.analytics.util.AppConstants; public class VisualManager extends RaptorObject { private HashMap hiddenCols = new HashMap(); diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/ReportSearchResult.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/ReportSearchResult.java index a686d8aa..ee2a13ab 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/ReportSearchResult.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/ReportSearchResult.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,10 +37,9 @@ */ package org.onap.portalsdk.analytics.model.search; -import java.util.*; - -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; +import org.onap.portalsdk.analytics.system.AppUtils; +import org.onap.portalsdk.analytics.system.Globals; +import org.onap.portalsdk.analytics.util.AppConstants; public class ReportSearchResult extends SearchResult { private static final String HTML_FORM = "forma"; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/ReportSearchResultJSON.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/ReportSearchResultJSON.java index 2174383c..90c24cf5 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/ReportSearchResultJSON.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/ReportSearchResultJSON.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,13 +37,15 @@ */ package org.onap.portalsdk.analytics.model.search; -import java.util.*; +import java.util.ArrayList; import javax.servlet.http.HttpServletRequest; import org.onap.portalsdk.analytics.error.RaptorException; -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; +import org.onap.portalsdk.analytics.system.AppUtils; +import org.onap.portalsdk.analytics.system.Globals; +import org.onap.portalsdk.analytics.util.AppConstants; +import org.onap.portalsdk.analytics.util.DataSet; import com.fasterxml.jackson.databind.ObjectMapper; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResult.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResult.java index 680e8696..034516e1 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResult.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResult.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,13 +37,14 @@ */ package org.onap.portalsdk.analytics.model.search; -import java.util.*; +import java.util.ArrayList; import javax.servlet.http.HttpServletRequest; import org.onap.portalsdk.analytics.error.RaptorException; -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; +import org.onap.portalsdk.analytics.system.AppUtils; +import org.onap.portalsdk.analytics.system.Globals; +import org.onap.portalsdk.analytics.util.DataSet; public class SearchResult{ private int pageNo = -1; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultColumn.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultColumn.java index d39ad4a9..45e6a6a8 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultColumn.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultColumn.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,8 +37,6 @@ */ package org.onap.portalsdk.analytics.model.search; -import org.onap.portalsdk.analytics.util.*; - public class SearchResultColumn extends org.onap.portalsdk.analytics.RaptorObject { private String columnId = ""; private String columnTitle = ""; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultField.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultField.java index 4b6dfdef..6cbd9c84 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultField.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultField.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,7 +37,7 @@ */ package org.onap.portalsdk.analytics.model.search; -import org.onap.portalsdk.analytics.util.*; +import org.onap.portalsdk.analytics.util.AppConstants; public class SearchResultField extends org.onap.portalsdk.analytics.RaptorObject { private String columnId; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultJSON.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultJSON.java index eb2cbb9d..9a31a1e2 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultJSON.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultJSON.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,13 +37,7 @@ */ package org.onap.portalsdk.analytics.model.search; -import java.util.*; - -import javax.servlet.http.HttpServletRequest; - -import org.onap.portalsdk.analytics.error.RaptorException; -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; +import java.util.ArrayList; public class SearchResultJSON{ diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultRow.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultRow.java index f725857b..b0674e9d 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultRow.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/search/SearchResultRow.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,7 +37,7 @@ */ package org.onap.portalsdk.analytics.model.search; -import java.util.*; +import java.util.ArrayList; class ColumnContent { String columnId; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/scheduler/SchedulerUtil.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/scheduler/SchedulerUtil.java index 56328b31..88dc98ad 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/scheduler/SchedulerUtil.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/scheduler/SchedulerUtil.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,10 +37,8 @@ */ package org.onap.portalsdk.analytics.scheduler; -import java.io.ByteArrayInputStream; import java.io.IOException; import java.io.InputStream; -import java.io.OutputStream; import java.math.BigDecimal; import java.sql.Connection; import java.sql.PreparedStatement; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/scheduler/SendEmail.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/scheduler/SendEmail.java index 57d80054..6b561539 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/scheduler/SendEmail.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/scheduler/SendEmail.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/scheduler/SendNotifications.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/scheduler/SendNotifications.java index 246e97b9..90ba1ed3 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/scheduler/SendNotifications.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/scheduler/SendNotifications.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -43,7 +43,6 @@ import java.sql.ResultSet; import java.sql.SQLException; import java.sql.Statement; import java.text.SimpleDateFormat; -import java.util.Calendar; import java.util.Date; import java.util.UUID; @@ -51,7 +50,6 @@ import org.onap.portalsdk.analytics.error.RaptorException; import org.onap.portalsdk.analytics.error.ReportSQLException; import org.onap.portalsdk.analytics.scheduler.SchedulerUtil.Executor; import org.onap.portalsdk.analytics.system.Globals; -import org.onap.portalsdk.analytics.util.Log; public class SendNotifications { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/AppUtils.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/AppUtils.java index ed1cc6e7..96bc609f 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/AppUtils.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/AppUtils.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -39,12 +39,14 @@ package org.onap.portalsdk.analytics.system; import java.io.File; import java.text.SimpleDateFormat; -import java.util.*; +import java.util.Date; +import java.util.Vector; -import javax.servlet.http.*; +import javax.servlet.http.HttpServletRequest; import org.onap.portalsdk.analytics.error.RaptorException; -import org.onap.portalsdk.analytics.util.*; +import org.onap.portalsdk.analytics.util.AppConstants; +import org.onap.portalsdk.analytics.util.HtmlStripper; public class AppUtils /* implements IAppUtils */{ private static String baseURL = null; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/ConnectionUtils.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/ConnectionUtils.java index 79bbaaa5..179d4643 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/ConnectionUtils.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/ConnectionUtils.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/DbUtils.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/DbUtils.java index 68269bc9..2a88e802 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/DbUtils.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/DbUtils.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -39,7 +39,6 @@ package org.onap.portalsdk.analytics.system; import java.sql.CallableStatement; import java.sql.Connection; -import java.sql.DriverManager; import java.sql.ResultSet; import java.sql.SQLException; import java.sql.Statement; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/ExecuteQuery.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/ExecuteQuery.java index 54631d47..c8e97035 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/ExecuteQuery.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/ExecuteQuery.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,7 +37,6 @@ */ package org.onap.portalsdk.analytics.system; -import java.sql.Connection; import java.sql.ResultSet; import java.sql.SQLException; import java.sql.Statement; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/Globals.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/Globals.java index a394b30f..7252243b 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/Globals.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/Globals.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/IAppUtils.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/IAppUtils.java index ba967e8b..073da098 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/IAppUtils.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/IAppUtils.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,12 +37,12 @@ */ package org.onap.portalsdk.analytics.system; -import java.util.*; -import javax.servlet.*; -import javax.servlet.http.*; +import java.util.Vector; + +import javax.servlet.ServletContext; +import javax.servlet.http.HttpServletRequest; import org.onap.portalsdk.analytics.error.RaptorException; -import org.onap.portalsdk.analytics.error.ReportSQLException; public interface IAppUtils { void initializeAppUtils(ServletContext servletContext); diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/IDbUtils.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/IDbUtils.java index 6d5daeaf..ade78eff 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/IDbUtils.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/IDbUtils.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,11 +37,10 @@ */ package org.onap.portalsdk.analytics.system; -import java.sql.*; -import java.util.*; -import javax.servlet.*; +import java.sql.Connection; + +import javax.servlet.ServletContext; -import org.onap.portalsdk.analytics.error.RaptorRuntimeException; import org.onap.portalsdk.analytics.error.ReportSQLException; public interface IDbUtils { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/RDbUtils.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/RDbUtils.java index 8f624a31..e15e9c80 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/RDbUtils.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/RDbUtils.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,8 +37,9 @@ */ package org.onap.portalsdk.analytics.system; -import java.sql.*; -import javax.servlet.*; +import java.sql.Connection; + +import javax.servlet.ServletContext; import org.onap.portalsdk.analytics.error.ReportSQLException; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/RemDbUtils.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/RemDbUtils.java index cab90879..da6ee7f7 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/RemDbUtils.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/RemDbUtils.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/AntBuild.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/AntBuild.java index 6451a961..e9a03eec 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/AntBuild.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/AntBuild.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/AppUtils.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/AppUtils.java index e3bd0f7e..aa670afc 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/AppUtils.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/AppUtils.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/DbUtils.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/DbUtils.java index b33995b2..6fd7eb68 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/DbUtils.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/DbUtils.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,17 +37,14 @@ */ package org.onap.portalsdk.analytics.system.fusion; -import java.sql.*; -import java.util.*; +import java.sql.Connection; -import javax.servlet.*; +import javax.servlet.ServletContext; -import org.onap.portalsdk.analytics.config.*; -import org.onap.portalsdk.analytics.system.*; +import org.onap.portalsdk.analytics.system.IDbUtils; import org.onap.portalsdk.analytics.system.fusion.adapter.FusionAdapter; import org.onap.portalsdk.analytics.system.fusion.adapter.RaptorAdapter; import org.onap.portalsdk.analytics.system.fusion.adapter.SpringContext; -import org.onap.portalsdk.analytics.util.*; import org.springframework.beans.factory.annotation.Autowired; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/RemoteDbUtils.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/RemoteDbUtils.java index a6abfb7d..0134fa7c 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/RemoteDbUtils.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/RemoteDbUtils.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -38,19 +38,12 @@ package org.onap.portalsdk.analytics.system.fusion; import java.sql.Connection; -import java.sql.ResultSet; -import java.sql.SQLException; -import java.sql.Statement; import javax.servlet.ServletContext; -import org.onap.portalsdk.analytics.error.ReportSQLException; import org.onap.portalsdk.analytics.system.RDbUtils; import org.onap.portalsdk.analytics.system.fusion.adapter.RaptorAdapter; import org.onap.portalsdk.analytics.system.fusion.adapter.SpringContext; -import org.onap.portalsdk.analytics.util.DataSet; -import org.onap.portalsdk.analytics.util.Log; -import org.springframework.beans.factory.annotation.Autowired; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/AdapterSessionFactoryContainer.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/AdapterSessionFactoryContainer.java index e95b0ec6..f242fea3 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/AdapterSessionFactoryContainer.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/AdapterSessionFactoryContainer.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,7 +37,7 @@ */ package org.onap.portalsdk.analytics.system.fusion.adapter; -import java.util.*; +import java.util.LinkedHashMap; public class AdapterSessionFactoryContainer { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/DateUtils.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/DateUtils.java index d5939764..ede3793d 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/DateUtils.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/DateUtils.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/FusionAdapter.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/FusionAdapter.java index c4732207..3ac51bbe 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/FusionAdapter.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/FusionAdapter.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,24 +37,15 @@ */ package org.onap.portalsdk.analytics.system.fusion.adapter; -import java.sql.*; -import java.util.*; +import java.sql.Connection; +import java.util.Map; -import javax.naming.Context; -import javax.naming.InitialContext; -import javax.servlet.*; +import javax.servlet.ServletContext; -import com.mchange.v2.c3p0.ComboPooledDataSource; - -import org.hibernate.SessionFactory; -import org.hibernate.engine.jdbc.connections.spi.ConnectionProvider; -import org.hibernate.engine.spi.SessionFactoryImplementor; -import org.hibernate.engine.spi.SessionImplementor; import org.onap.portalsdk.core.FusionObject; -import org.onap.portalsdk.core.service.DataAccessService; -import org.onap.portalsdk.core.util.SystemProperties; import org.springframework.beans.factory.annotation.Autowired; -import org.springframework.context.annotation.Configuration; + +import com.mchange.v2.c3p0.ComboPooledDataSource; public class FusionAdapter implements FusionObject { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/IdName.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/IdName.java index ac068614..ecfe4519 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/IdName.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/IdName.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/Item.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/Item.java index 97e8a219..86d41d57 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/Item.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/Item.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/Lookup.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/Lookup.java index a2952242..ff5fc276 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/Lookup.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/Lookup.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -38,7 +38,7 @@ package org.onap.portalsdk.analytics.system.fusion.adapter; -import java.io.*; +import java.io.Serializable; import org.onap.portalsdk.core.domain.FusionVo; import org.onap.portalsdk.core.domain.support.NameValueId; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/RaptorAdapter.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/RaptorAdapter.java index 9e7a6134..968bdd64 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/RaptorAdapter.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/RaptorAdapter.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/SpringContext.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/SpringContext.java index d6d6c966..b8b62062 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/SpringContext.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/SpringContext.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/controller/FileServletController.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/controller/FileServletController.java index d3d095b3..1d1fdd84 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/controller/FileServletController.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/controller/FileServletController.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/domain/CR_Report.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/domain/CR_Report.java index e30d9cad..53451b21 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/domain/CR_Report.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/domain/CR_Report.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -38,7 +38,7 @@ package org.onap.portalsdk.analytics.system.fusion.domain; -import java.util.*; +import java.util.Date; import org.onap.portalsdk.core.domain.User; import org.onap.portalsdk.core.domain.support.DomainVo;; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/domain/QuickLink.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/domain/QuickLink.java index 32f03f32..91a09b8a 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/domain/QuickLink.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/domain/QuickLink.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/domain/RaptorSearch.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/domain/RaptorSearch.java index a9a9aa3c..8bc4a190 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/domain/RaptorSearch.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/domain/RaptorSearch.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/domain/ReportInfo.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/domain/ReportInfo.java index 02d49eca..cd276a18 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/domain/ReportInfo.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/domain/ReportInfo.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/service/RaptorService.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/service/RaptorService.java index 675b0606..458f92e2 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/service/RaptorService.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/service/RaptorService.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,7 +37,8 @@ */ package org.onap.portalsdk.analytics.system.fusion.service; -import java.util.*; +import java.util.List; +import java.util.Map; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/service/RaptorServiceImpl.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/service/RaptorServiceImpl.java index f7bb1327..edae78ae 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/service/RaptorServiceImpl.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/service/RaptorServiceImpl.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,33 +37,13 @@ */ package org.onap.portalsdk.analytics.system.fusion.service; -import java.io.BufferedInputStream; -import java.io.BufferedOutputStream; -import java.io.FileOutputStream; -import java.io.IOException; -import java.io.InputStream; -import java.io.OutputStream; -import java.math.BigDecimal; -import java.util.Date; -import java.util.HashMap; import java.util.List; import java.util.Map; -import java.util.Set; -import javax.sql.DataSource; - -import org.hibernate.Query; -import org.hibernate.Session; import org.onap.portalsdk.analytics.system.fusion.domain.CR_Report; -import org.onap.portalsdk.core.domain.Role; import org.onap.portalsdk.core.service.DataAccessService; import org.onap.portalsdk.core.service.support.FusionService; -import org.onap.portalsdk.core.util.SystemProperties; -import org.onap.portalsdk.core.web.support.UserUtils; import org.springframework.context.ApplicationContext; -import org.springframework.jdbc.core.namedparam.NamedParameterJdbcTemplate; -import org.springframework.orm.hibernate3.SessionFactoryUtils; -import org.springframework.web.multipart.MultipartFile; public class RaptorServiceImpl extends FusionService implements RaptorService { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/web/RaptorController.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/web/RaptorController.java index 668431d5..960fa0ca 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/web/RaptorController.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/web/RaptorController.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/web/RaptorControllerAsync.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/web/RaptorControllerAsync.java index 03a0c6cc..8165801c 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/web/RaptorControllerAsync.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/web/RaptorControllerAsync.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/web/ReportsSearchListController.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/web/ReportsSearchListController.java index 489ca232..5c890f5c 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/web/ReportsSearchListController.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/web/ReportsSearchListController.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -38,14 +38,11 @@ package org.onap.portalsdk.analytics.system.fusion.web; -import java.util.*; +import javax.servlet.http.HttpServletRequest; +import javax.servlet.http.HttpServletResponse; -import javax.servlet.http.*; - -import org.onap.portalsdk.analytics.system.fusion.domain.CR_Report; import org.onap.portalsdk.analytics.system.fusion.service.RaptorService; -import org.springframework.web.bind.*; -import org.springframework.web.servlet.*; +import org.springframework.web.servlet.ModelAndView; public class ReportsSearchListController { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/AppConstants.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/AppConstants.java index ea94153e..6f21f6af 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/AppConstants.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/AppConstants.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -39,7 +39,7 @@ package org.onap.portalsdk.analytics.util; import java.awt.Color; -import org.onap.portalsdk.analytics.model.base.*; +import org.onap.portalsdk.analytics.model.base.IdNameList; /**
* This class is part of RAPTOR (Rapid Application Programming Tool for OLAP Reporting)
diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/DataSet.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/DataSet.java index 306c7834..0a238b5d 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/DataSet.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/DataSet.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -38,10 +38,10 @@ package org.onap.portalsdk.analytics.util; import java.io.Serializable; -import java.sql.*; -import java.util.*; - -import org.onap.portalsdk.analytics.system.Globals; +import java.sql.ResultSet; +import java.sql.ResultSetMetaData; +import java.sql.SQLException; +import java.util.Vector; public class DataSet extends Vector implements Serializable { private Vector columnNames = null; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/ExcelColorDef.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/ExcelColorDef.java index eb87537c..17f01818 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/ExcelColorDef.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/ExcelColorDef.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/HtmlStripper.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/HtmlStripper.java index 00b65671..e67e5503 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/HtmlStripper.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/HtmlStripper.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,8 +37,6 @@ */ package org.onap.portalsdk.analytics.util; -import java.io.*; - import org.onap.portalsdk.analytics.RaptorObject; public class HtmlStripper extends RaptorObject// this function can be accessed publicly diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/Log.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/Log.java index ba12485d..7da88827 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/Log.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/Log.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/RemDbInfo.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/RemDbInfo.java index c2a51f4d..82892137 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/RemDbInfo.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/RemDbInfo.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/SQLCorrector.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/SQLCorrector.java index 325ecf14..423c57c3 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/SQLCorrector.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/SQLCorrector.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/Scheduler.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/Scheduler.java index a075ed4b..92e3cfad 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/Scheduler.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/Scheduler.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -38,12 +38,12 @@ package org.onap.portalsdk.analytics.util; import java.sql.SQLException; -import java.util.*; +import java.util.Timer; +import java.util.TimerTask; -import org.onap.portalsdk.analytics.error.ReportSQLException; import org.onap.portalsdk.analytics.scheduler.SendNotifications; -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; +import org.onap.portalsdk.analytics.system.AppUtils; +import org.onap.portalsdk.analytics.system.Globals; public class Scheduler extends TimerTask { private Timer timer = new Timer(true); diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/Utils.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/Utils.java index 91fca2c7..1b0ad5cb 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/Utils.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/Utils.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,17 +37,23 @@ */ package org.onap.portalsdk.analytics.util; -import java.util.*; -import java.util.regex.Pattern; import java.io.File; -import java.text.*; +import java.text.ParseException; +import java.text.SimpleDateFormat; +import java.util.ArrayList; +import java.util.Date; +import java.util.Iterator; +import java.util.List; +import java.util.Vector; +import java.util.regex.Pattern; import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpSession; import org.onap.portalsdk.analytics.error.RaptorException; -import org.onap.portalsdk.analytics.model.base.*; -import org.onap.portalsdk.analytics.system.*; +import org.onap.portalsdk.analytics.model.base.IdNameValue; +import org.onap.portalsdk.analytics.system.AppUtils; +import org.onap.portalsdk.analytics.system.Globals; import org.onap.portalsdk.analytics.system.fusion.adapter.Item; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/XSSFilter.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/XSSFilter.java index 7d986c25..4e150de7 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/XSSFilter.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/XSSFilter.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/jar/ExtractJar.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/jar/ExtractJar.java index d3f443b8..42818642 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/jar/ExtractJar.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/jar/ExtractJar.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/upgrade/SystemUpgrade.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/upgrade/SystemUpgrade.java index d8a6635e..9c2255b4 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/upgrade/SystemUpgrade.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/util/upgrade/SystemUpgrade.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,21 +37,19 @@ */ package org.onap.portalsdk.analytics.util.upgrade; -import java.io.*; -import java.sql.*; -import java.util.*; -import javax.servlet.http.*; +import java.sql.Connection; +import java.util.Iterator; +import java.util.StringTokenizer; -import org.onap.portalsdk.analytics.controller.*; -import org.onap.portalsdk.analytics.error.*; -import org.onap.portalsdk.analytics.model.*; -import org.onap.portalsdk.analytics.model.base.*; -import org.onap.portalsdk.analytics.model.definition.*; -import org.onap.portalsdk.analytics.model.runtime.*; -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; -import org.onap.portalsdk.analytics.view.*; -import org.onap.portalsdk.analytics.xmlobj.*; +import javax.servlet.http.HttpServletRequest; + +import org.onap.portalsdk.analytics.model.ReportLoader; +import org.onap.portalsdk.analytics.model.base.ReportWrapper; +import org.onap.portalsdk.analytics.model.definition.ReportDefinition; +import org.onap.portalsdk.analytics.system.AppUtils; +import org.onap.portalsdk.analytics.system.DbUtils; +import org.onap.portalsdk.analytics.util.DataSet; +import org.onap.portalsdk.analytics.xmlobj.DataColumnType; public class SystemUpgrade extends org.onap.portalsdk.analytics.RaptorObject { private static final String upgradeFromVersion = "1.x"; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ColumnHeader.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ColumnHeader.java index ef78c5fb..0abd35ca 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ColumnHeader.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ColumnHeader.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,8 +37,6 @@ */ package org.onap.portalsdk.analytics.view; -import org.onap.portalsdk.analytics.util.*; - public class ColumnHeader extends org.onap.portalsdk.analytics.RaptorObject { private String columnTitle = ""; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ColumnHeaderRow.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ColumnHeaderRow.java index f3ecbea2..8be2a68d 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ColumnHeaderRow.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ColumnHeaderRow.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,9 +37,7 @@ */ package org.onap.portalsdk.analytics.view; -import java.util.*; - -import org.onap.portalsdk.analytics.util.*; +import java.util.Vector; public class ColumnHeaderRow extends Vector { private String rowHeight = ""; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ColumnVisual.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ColumnVisual.java index 10494636..9ce62ef4 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ColumnVisual.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ColumnVisual.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/CrossTabColumnValues.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/CrossTabColumnValues.java index 4cc5bc9d..9614dccd 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/CrossTabColumnValues.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/CrossTabColumnValues.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,11 +37,11 @@ */ package org.onap.portalsdk.analytics.view; -import java.util.*; +import java.util.Vector; -import org.onap.portalsdk.analytics.error.*; -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; +import org.onap.portalsdk.analytics.error.RaptorException; +import org.onap.portalsdk.analytics.system.ConnectionUtils; +import org.onap.portalsdk.analytics.util.DataSet; public class CrossTabColumnValues extends org.onap.portalsdk.analytics.RaptorObject { private String colId = null; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/CrossTabOrderManager.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/CrossTabOrderManager.java index 4f5d8bf8..c480ca6d 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/CrossTabOrderManager.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/CrossTabOrderManager.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,16 +37,16 @@ */ package org.onap.portalsdk.analytics.view; -import java.util.*; +import java.util.Iterator; +import java.util.Vector; import javax.servlet.http.HttpServletRequest; import org.onap.portalsdk.analytics.RaptorObject; -import org.onap.portalsdk.analytics.error.*; -import org.onap.portalsdk.analytics.model.runtime.*; -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; -import org.onap.portalsdk.analytics.xmlobj.*; +import org.onap.portalsdk.analytics.error.RaptorException; +import org.onap.portalsdk.analytics.model.runtime.ReportRuntime; +import org.onap.portalsdk.analytics.util.AppConstants; +import org.onap.portalsdk.analytics.xmlobj.DataColumnType; public class CrossTabOrderManager extends RaptorObject { private Vector colHeaderValues = null; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/CrossTabTotalValue.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/CrossTabTotalValue.java index 4a450912..6633a8d5 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/CrossTabTotalValue.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/CrossTabTotalValue.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,7 +37,7 @@ */ package org.onap.portalsdk.analytics.view; -import java.util.*; +import java.util.Vector; public class CrossTabTotalValue extends org.onap.portalsdk.analytics.RaptorObject { private Vector headerValues = null; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/DataRow.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/DataRow.java index 105ecd8f..cd4a0a76 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/DataRow.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/DataRow.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,7 +37,8 @@ */ package org.onap.portalsdk.analytics.view; -import java.util.*; +import java.util.ArrayList; +import java.util.Vector; public class DataRow/* extends Vector*/ { diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/DataValue.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/DataValue.java index 5c83877e..e95e2de0 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/DataValue.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/DataValue.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,8 +37,6 @@ */ package org.onap.portalsdk.analytics.view; -import org.onap.portalsdk.analytics.util.*; - public class DataValue extends org.onap.portalsdk.analytics.RaptorObject { private String displayValue = ""; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/HtmlFormatter.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/HtmlFormatter.java index 9569049a..d00ac80c 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/HtmlFormatter.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/HtmlFormatter.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ReportColumnHeaderRows.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ReportColumnHeaderRows.java index fd8a1354..c6a18d39 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ReportColumnHeaderRows.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ReportColumnHeaderRows.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,7 +37,7 @@ */ package org.onap.portalsdk.analytics.view; -import java.util.*; +import java.util.Vector; public class ReportColumnHeaderRows extends Vector { private int nextElemIdx = 0; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ReportData.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ReportData.java index a46456ec..b11cfd29 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ReportData.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ReportData.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -38,12 +38,15 @@ package org.onap.portalsdk.analytics.view; import java.io.Serializable; -import java.util.*; - -import org.onap.portalsdk.analytics.model.runtime.*; -import org.onap.portalsdk.analytics.system.*; -import org.onap.portalsdk.analytics.util.*; -import org.onap.portalsdk.analytics.xmlobj.*; +import java.util.Iterator; +import java.util.List; +import java.util.Vector; + +import org.onap.portalsdk.analytics.model.runtime.FormatProcessor; +import org.onap.portalsdk.analytics.model.runtime.VisualManager; +import org.onap.portalsdk.analytics.system.AppUtils; +import org.onap.portalsdk.analytics.util.AppConstants; +import org.onap.portalsdk.analytics.util.Utils; public class ReportData extends org.onap.portalsdk.analytics.RaptorObject implements Serializable { // private static final boolean sortData = true; // sort cross-tab data by diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ReportDataRows.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ReportDataRows.java index 39cc9925..2d25a525 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ReportDataRows.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ReportDataRows.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,7 +37,7 @@ */ package org.onap.portalsdk.analytics.view; -import java.util.*; +import java.util.Vector; public class ReportDataRows extends Vector { private int nextElemIdx = 0; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ReportRowHeaderCols.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ReportRowHeaderCols.java index 82ae0f7d..bfb46ed6 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ReportRowHeaderCols.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/ReportRowHeaderCols.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,7 +37,7 @@ */ package org.onap.portalsdk.analytics.view; -import java.util.*; +import java.util.Vector; public class ReportRowHeaderCols extends Vector { private int nextElemIdx = 0; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/RowHeader.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/RowHeader.java index d7de647c..aa68044b 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/RowHeader.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/RowHeader.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,8 +37,6 @@ */ package org.onap.portalsdk.analytics.view; -import org.onap.portalsdk.analytics.util.*; - public class RowHeader extends org.onap.portalsdk.analytics.RaptorObject { private String rowTitle = ""; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/RowHeaderCol.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/RowHeaderCol.java index 31233e42..e4342633 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/RowHeaderCol.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/view/RowHeaderCol.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,9 +37,7 @@ */ package org.onap.portalsdk.analytics.view; -import java.util.*; - -import org.onap.portalsdk.analytics.util.*; +import java.util.Vector; public class RowHeaderCol extends Vector { private String columnWidth = ""; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ChartAdditionalOptions.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ChartAdditionalOptions.java index f18314c8..df41df67 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ChartAdditionalOptions.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ChartAdditionalOptions.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ChartDrillFormfield.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ChartDrillFormfield.java index e0b3d9cc..e6dea37a 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ChartDrillFormfield.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ChartDrillFormfield.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ChartDrillOptions.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ChartDrillOptions.java index c1090a06..f6f1485b 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ChartDrillOptions.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ChartDrillOptions.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -47,6 +47,7 @@ package org.onap.portalsdk.analytics.xmlobj; import java.util.ArrayList; import java.util.List; + import javax.xml.bind.annotation.XmlAccessType; import javax.xml.bind.annotation.XmlAccessorType; import javax.xml.bind.annotation.XmlElement; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ColFilterList.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ColFilterList.java index b05f17d8..46536361 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ColFilterList.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ColFilterList.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -47,6 +47,7 @@ package org.onap.portalsdk.analytics.xmlobj; import java.util.ArrayList; import java.util.List; + import javax.xml.bind.annotation.XmlAccessType; import javax.xml.bind.annotation.XmlAccessorType; import javax.xml.bind.annotation.XmlType; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ColFilterType.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ColFilterType.java index 47b4c46f..22a95e94 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ColFilterType.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ColFilterType.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/CustomReportType.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/CustomReportType.java index 465c63be..b2cf9b38 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/CustomReportType.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/CustomReportType.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DashboardEditorList.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DashboardEditorList.java index 36c39a7f..9ae8a25f 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DashboardEditorList.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DashboardEditorList.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -47,6 +47,7 @@ package org.onap.portalsdk.analytics.xmlobj; import java.util.ArrayList; import java.util.List; + import javax.xml.bind.annotation.XmlAccessType; import javax.xml.bind.annotation.XmlAccessorType; import javax.xml.bind.annotation.XmlType; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DashboardEditorReport.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DashboardEditorReport.java index 2442d0bb..d2c2b48c 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DashboardEditorReport.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DashboardEditorReport.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DashboardReports.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DashboardReports.java index 3ab80e93..c9f9aea3 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DashboardReports.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DashboardReports.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -47,6 +47,7 @@ package org.onap.portalsdk.analytics.xmlobj; import java.util.ArrayList; import java.util.List; + import javax.xml.bind.annotation.XmlAccessType; import javax.xml.bind.annotation.XmlAccessorType; import javax.xml.bind.annotation.XmlType; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DashboardReportsNew.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DashboardReportsNew.java index db0a25e1..1ff4a7c7 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DashboardReportsNew.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DashboardReportsNew.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -47,6 +47,7 @@ package org.onap.portalsdk.analytics.xmlobj; import java.util.ArrayList; import java.util.List; + import javax.xml.bind.annotation.XmlAccessType; import javax.xml.bind.annotation.XmlAccessorType; import javax.xml.bind.annotation.XmlType; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DataColumnList.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DataColumnList.java index 554c6b87..4ff4cedf 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DataColumnList.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DataColumnList.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -47,6 +47,7 @@ package org.onap.portalsdk.analytics.xmlobj; import java.util.ArrayList; import java.util.List; + import javax.xml.bind.annotation.XmlAccessType; import javax.xml.bind.annotation.XmlAccessorType; import javax.xml.bind.annotation.XmlElement; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DataColumnType.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DataColumnType.java index 10433d31..8da2a985 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DataColumnType.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DataColumnType.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DataSourceList.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DataSourceList.java index 5d863ccc..19018bbb 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DataSourceList.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DataSourceList.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -47,6 +47,7 @@ package org.onap.portalsdk.analytics.xmlobj; import java.util.ArrayList; import java.util.List; + import javax.xml.bind.annotation.XmlAccessType; import javax.xml.bind.annotation.XmlAccessorType; import javax.xml.bind.annotation.XmlType; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DataSourceType.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DataSourceType.java index 6156353b..82e288a8 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DataSourceType.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DataSourceType.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DataminingOptions.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DataminingOptions.java index 61a474c6..469e4d4c 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DataminingOptions.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/DataminingOptions.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/FormFieldList.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/FormFieldList.java index a329888b..5e6d7875 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/FormFieldList.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/FormFieldList.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -47,6 +47,7 @@ package org.onap.portalsdk.analytics.xmlobj; import java.util.ArrayList; import java.util.List; + import javax.xml.bind.annotation.XmlAccessType; import javax.xml.bind.annotation.XmlAccessorType; import javax.xml.bind.annotation.XmlType; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/FormFieldType.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/FormFieldType.java index f998f8c5..fc0e5493 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/FormFieldType.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/FormFieldType.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/FormatList.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/FormatList.java index 110e0392..a01529ed 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/FormatList.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/FormatList.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -47,6 +47,7 @@ package org.onap.portalsdk.analytics.xmlobj; import java.util.ArrayList; import java.util.List; + import javax.xml.bind.annotation.XmlAccessType; import javax.xml.bind.annotation.XmlAccessorType; import javax.xml.bind.annotation.XmlElement; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/FormatType.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/FormatType.java index bc21f9c1..e94d4d52 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/FormatType.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/FormatType.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/JavascriptItemType.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/JavascriptItemType.java index d0697a74..7a1c3243 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/JavascriptItemType.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/JavascriptItemType.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/JavascriptList.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/JavascriptList.java index 876a78ae..69ed5138 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/JavascriptList.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/JavascriptList.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -47,6 +47,7 @@ package org.onap.portalsdk.analytics.xmlobj; import java.util.ArrayList; import java.util.List; + import javax.xml.bind.annotation.XmlAccessType; import javax.xml.bind.annotation.XmlAccessorType; import javax.xml.bind.annotation.XmlType; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/Marker.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/Marker.java index 7eaca274..94083c1d 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/Marker.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/Marker.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ObjectFactory.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ObjectFactory.java index ce79171e..e2d8b699 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ObjectFactory.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ObjectFactory.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/PDFAdditionalOptions.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/PDFAdditionalOptions.java index f12cbada..4aaa00e8 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/PDFAdditionalOptions.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/PDFAdditionalOptions.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/PredefinedValueList.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/PredefinedValueList.java index 2136c219..9e3ad692 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/PredefinedValueList.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/PredefinedValueList.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -47,6 +47,7 @@ package org.onap.portalsdk.analytics.xmlobj; import java.util.ArrayList; import java.util.List; + import javax.xml.bind.annotation.XmlAccessType; import javax.xml.bind.annotation.XmlAccessorType; import javax.xml.bind.annotation.XmlType; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ReportMap.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ReportMap.java index b222acc0..260d6d1c 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ReportMap.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/ReportMap.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -47,6 +47,7 @@ package org.onap.portalsdk.analytics.xmlobj; import java.util.ArrayList; import java.util.List; + import javax.xml.bind.annotation.XmlAccessType; import javax.xml.bind.annotation.XmlAccessorType; import javax.xml.bind.annotation.XmlType; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/Reports.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/Reports.java index 305dd8f7..ee275827 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/Reports.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/Reports.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/SemaphoreList.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/SemaphoreList.java index 3fdbd65e..9b5e733f 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/SemaphoreList.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/SemaphoreList.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -47,6 +47,7 @@ package org.onap.portalsdk.analytics.xmlobj; import java.util.ArrayList; import java.util.List; + import javax.xml.bind.annotation.XmlAccessType; import javax.xml.bind.annotation.XmlAccessorType; import javax.xml.bind.annotation.XmlType; diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/SemaphoreType.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/SemaphoreType.java index de48436e..b97aefb8 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/SemaphoreType.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/xmlobj/SemaphoreType.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/AdminController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/AdminController.java index a1383fb0..ea1d3e8b 100644 --- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/AdminController.java +++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/AdminController.java @@ -7,7 +7,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -20,7 +20,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -41,8 +41,6 @@ package org.onap.portalapp.controller.core; import java.util.HashMap; import java.util.Map; -import javax.servlet.http.HttpServletRequest; - import org.onap.portalsdk.core.controller.RestrictedBaseController; import org.springframework.stereotype.Controller; import org.springframework.web.bind.annotation.RequestMapping; @@ -55,14 +53,14 @@ public class AdminController { public class AngularSinglePageController extends RestrictedBaseController { @RequestMapping(value = { "/admin" }, method = RequestMethod.GET) - public ModelAndView view(HttpServletRequest request) { - Map model = new HashMap(); + public ModelAndView view() { + Map model = new HashMap<>(); return new ModelAndView("admin", "model", model); } @RequestMapping(value = { "/admin2" }, method = RequestMethod.GET) - public ModelAndView adminView(HttpServletRequest request) { - Map model = new HashMap(); + public ModelAndView adminView() { + Map model = new HashMap<>(); return new ModelAndView("admin2", "model", model); } diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/AngularAdminController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/AngularAdminController.java index 71729c0d..61b57a35 100644 --- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/AngularAdminController.java +++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/AngularAdminController.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -40,8 +40,6 @@ package org.onap.portalapp.controller.core; import java.util.HashMap; import java.util.Map; -import javax.servlet.http.HttpServletRequest; - import org.onap.portalsdk.core.controller.RestrictedBaseController; import org.springframework.stereotype.Controller; import org.springframework.web.bind.annotation.RequestMapping; @@ -53,16 +51,14 @@ import org.springframework.web.servlet.ModelAndView; public class AngularAdminController extends RestrictedBaseController{ @RequestMapping(value = {"/userProfile" }, method = RequestMethod.GET) - public ModelAndView view(HttpServletRequest request) { - Map model = new HashMap(); - + public ModelAndView view() { + Map model = new HashMap<>(); return new ModelAndView("user_profile_list","model", model); } @RequestMapping(value = {"/admin" }, method = RequestMethod.GET) - public ModelAndView adminView(HttpServletRequest request) { - Map model = new HashMap(); - + public ModelAndView adminView() { + Map model = new HashMap<>(); return new ModelAndView(getViewName(),"model", model); } diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/BootstrapSampleController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/BootstrapSampleController.java index 12602235..61b37d0c 100644 --- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/BootstrapSampleController.java +++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/BootstrapSampleController.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,8 +37,6 @@ */ package org.onap.portalapp.controller.core; -import javax.servlet.http.HttpServletRequest; - import org.onap.portalsdk.core.controller.RestrictedBaseController; import org.springframework.stereotype.Controller; import org.springframework.web.bind.annotation.RequestMapping; @@ -54,7 +52,7 @@ import org.springframework.web.servlet.ModelAndView; @RequestMapping("/") public class BootstrapSampleController extends RestrictedBaseController { @RequestMapping(value = { "/bootstrap_sample" }, method = RequestMethod.GET) - public ModelAndView welcome(HttpServletRequest request) { + public ModelAndView welcome() { final String defaultViewName = null; return new ModelAndView(defaultViewName); } diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/CacheAdminController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/CacheAdminController.java index 79866f6c..c3f8cfc3 100644 --- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/CacheAdminController.java +++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/CacheAdminController.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -37,6 +37,7 @@ */ package org.onap.portalapp.controller.core; +import java.io.IOException; import java.io.PrintWriter; import java.util.HashMap; import java.util.LinkedList; @@ -47,6 +48,7 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; import org.apache.jcs.JCS; +import org.apache.jcs.access.exception.CacheException; import org.apache.jcs.admin.CacheRegionInfo; import org.apache.jcs.admin.JCSAdminBean; import org.apache.jcs.engine.behavior.ICacheElement; @@ -73,16 +75,14 @@ public class CacheAdminController extends RestrictedBaseController { private JCSAdminBean jcsAdminBean = new JCSAdminBean(); @RequestMapping(value = { "/jcs_admin" }, method = RequestMethod.GET) - public ModelAndView cacheAdmin(HttpServletRequest request) { - Map model = new HashMap(); - + public ModelAndView cacheAdmin() { + Map model = new HashMap<>(); model.put("model", getRegions()); - return new ModelAndView(getViewName(), model); } @RequestMapping(value = { "/get_regions" }, method = RequestMethod.GET) - public void getRegions(HttpServletRequest request, HttpServletResponse response) { + public void getRegions(HttpServletResponse response) { try { JsonMessage msg = new JsonMessage(getRegions().toString()); JSONObject j = new JSONObject(msg); @@ -93,41 +93,37 @@ public class CacheAdminController extends RestrictedBaseController { } @RequestMapping(value = { "/jcs_admin/clearRegion" }, method = RequestMethod.GET) - public void clearRegion(HttpServletRequest request, HttpServletResponse response) throws Exception { - String cacheName = (String) request.getParameter("cacheName"); + public void clearRegion(HttpServletRequest request, HttpServletResponse response) throws IOException { + String cacheName = request.getParameter("cacheName"); clearCacheRegion(cacheName); - response.setContentType("application/json"); PrintWriter out = response.getWriter(); out.write(getRegions().toString()); } @RequestMapping(value = { "/jcs_admin/clearAll" }, method = RequestMethod.GET) - public void clearAll(HttpServletRequest request, HttpServletResponse response) throws Exception { + public void clearAll(HttpServletResponse response) throws IOException { clearAllRegions(); - response.setContentType("application/json"); PrintWriter out = response.getWriter(); out.write(getRegions().toString()); } @RequestMapping(value = { "/jcs_admin/clearItem" }, method = RequestMethod.GET) - public void clearItem(HttpServletRequest request, HttpServletResponse response) throws Exception { - String keyName = (String) request.getParameter("keyName"); - String cacheName = (String) request.getParameter("cacheName"); + public void clearItem(HttpServletRequest request, HttpServletResponse response) throws IOException { + String keyName = request.getParameter("keyName"); + String cacheName = request.getParameter("cacheName"); clearCacheRegionItem(cacheName, keyName); - response.setContentType("application/json"); PrintWriter out = response.getWriter(); out.write(getRegions().toString()); } @RequestMapping(value = { "/jcs_admin/showItemDetails" }, method = RequestMethod.GET) - public void showItemDetails(HttpServletRequest request, HttpServletResponse response) throws Exception { - String cacheName = (String) request.getParameter("cacheName"); - String keyName = (String) request.getParameter("keyName"); + public void showItemDetails(HttpServletRequest request, HttpServletResponse response) throws IOException { + String cacheName = request.getParameter("cacheName"); + String keyName = request.getParameter("keyName"); String details = null; - try { details = getItemDetails(cacheName, keyName); } catch (Exception e) { @@ -136,14 +132,13 @@ public class CacheAdminController extends RestrictedBaseController { } JSONObject j = new JSONObject(details); response.setContentType("application/json"); - // response.setContentType("text/plain"); PrintWriter out = response.getWriter(); out.write(j.toString()); } @RequestMapping(value = { "/jcs_admin/showRegionDetails" }, method = RequestMethod.GET) - public void showRegionDetails(HttpServletRequest request, HttpServletResponse response) throws Exception { - String cacheName = (String) request.getParameter("cacheName"); + public void showRegionDetails(HttpServletRequest request, HttpServletResponse response) { + String cacheName = request.getParameter("cacheName"); ObjectMapper mapper = new ObjectMapper(); try { String details = getRegionStats(cacheName); @@ -190,21 +185,18 @@ public class CacheAdminController extends RestrictedBaseController { return ja; } - private String getRegionStats(String cacheName) throws Exception { - String stats = ""; - + private String getRegionStats(String cacheName) throws CacheException { JCS cache = JCS.getInstance(cacheName); - stats = cache.getStats(); - + String stats = cache.getStats(); return stats; } private String getItemDetails(String cacheName, String keyName) throws Exception { - String details = ""; JCS cache = JCS.getInstance(cacheName); ICacheElement element = cache.getCacheElement(keyName); + String details = ""; if (element != null) { ObjectMapper mapper = new ObjectMapper(); mapper.disable(SerializationFeature.FAIL_ON_EMPTY_BEANS); diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/FavoritesController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/FavoritesController.java index 016c3b87..da26fe69 100644 --- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/FavoritesController.java +++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/FavoritesController.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -75,26 +75,25 @@ public class FavoritesController extends RestrictedBaseController { private AppService appService; /** - * Makes the REST API call to Portal Back-end and retrieves Favorite menu - * items for the currently logged in user. + * Makes the REST API call to Portal Back-end and retrieves Favorite menu items + * for the currently logged in user. * * @param request * @param response */ @RequestMapping(value = { "/get_favorites" }, method = RequestMethod.GET) public void getFavorites(HttpServletRequest request, HttpServletResponse response) { - String appName = ""; - String requestId = ""; - String appUserName = ""; - String decryptedPwd = ""; - + String appName = ""; + String requestId = ""; + String appUserName = ""; + String decryptedPwd = null; + try { HttpSession session = request.getSession(); User user = (User) session.getAttribute(SystemProperties.getProperty(SystemProperties.USER_ATTRIBUTE_NAME)); if (user == null || user.getId() == null) { - logger.info(EELFLoggerDelegate.errorLogger, - ("Http request did not contain user info, cannot retrieve favorites.")); - + logger.error(EELFLoggerDelegate.errorLogger, + "Http request did not contain user info, cannot retrieve favorites."); response.setContentType("application/json"); JSONArray jsonResponse = new JSONArray(); JSONObject error = new JSONObject(); @@ -102,35 +101,37 @@ public class FavoritesController extends RestrictedBaseController { jsonResponse.put(error); response.getWriter().write(jsonResponse.toString()); } else { - logger.info(EELFLoggerDelegate.errorLogger, + logger.debug(EELFLoggerDelegate.debugLogger, "Retrieving Favorites for the user '" + MDC.get(SystemProperties.MDC_LOGIN_ID) + "'."); - + App app = appService.getDefaultApp(); - if (app!=null) { - appName = app.getName(); + if (app != null) { + appName = app.getName(); appUserName = app.getUsername(); - try{ - decryptedPwd = CipherUtil.decrypt(app.getAppPassword(), SystemProperties.getProperty(SystemProperties.Decryption_Key)); - } catch(Exception e) { - logger.error(EELFLoggerDelegate.errorLogger, "Exception occurred in WebServiceCallServiceImpl.get while decrypting the password. Details: " + e.getMessage()); + try { + decryptedPwd = CipherUtil.decrypt(app.getAppPassword(), + SystemProperties.getProperty(SystemProperties.Decryption_Key)); + } catch (Exception e) { + logger.error(EELFLoggerDelegate.errorLogger, + "FavoritesController.getFavorites failed while decrypting password", e); } } else { - logger.warn(EELFLoggerDelegate.errorLogger, "Unable to locate the app information from the database."); - appName = SystemProperties.SDK_NAME; + logger.error(EELFLoggerDelegate.errorLogger, + "Unable to locate the app information from the database."); + appName = SystemProperties.SDK_NAME; } requestId = MDC.get(MDC_KEY_REQUEST_ID); - - String jsonResponse = FavoritesClient.getFavorites(MDC.get(SystemProperties.MDC_LOGIN_ID), appName, requestId, appUserName, decryptedPwd); - - logger.debug(EELFLoggerDelegate.debugLogger, "FavoritesMenu response: " + jsonResponse); - + + String jsonResponse = FavoritesClient.getFavorites(MDC.get(SystemProperties.MDC_LOGIN_ID), appName, + requestId, appUserName, decryptedPwd); + + logger.debug(EELFLoggerDelegate.debugLogger, "FavoritesMenu response: {}", jsonResponse); response.setContentType("application/json"); response.getWriter().write(jsonResponse); } } catch (Exception e) { logger.error(EELFLoggerDelegate.errorLogger, - "Exception occurred in FavoritesController.getFavorites while performing get_favorites. Details: " - + e.getMessage(), AlarmSeverityEnum.MINOR); + "FavoritesController.getFavorites failed", e); } } } diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/FnMenuController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/FnMenuController.java index e364fd45..dfc735b1 100644 --- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/FnMenuController.java +++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/FnMenuController.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -68,7 +68,6 @@ import com.fasterxml.jackson.databind.ObjectMapper; /** * A controller for Admin to add/edit/delete menu items from FN_MENU. */ - @Controller @RequestMapping("/") public class FnMenuController extends RestrictedBaseController { @@ -91,7 +90,6 @@ public class FnMenuController extends RestrictedBaseController { } catch (Exception e) { logger.error(EELFLoggerDelegate.errorLogger, "getParentListFailed", e); response.setCharacterEncoding("UTF-8"); - request.setCharacterEncoding("UTF-8"); PrintWriter out = response.getWriter(); out.write(e.getMessage()); } @@ -105,7 +103,6 @@ public class FnMenuController extends RestrictedBaseController { } catch (Exception e) { logger.error(EELFLoggerDelegate.errorLogger, "getFunctionCDList", e); response.setCharacterEncoding("UTF-8"); - request.setCharacterEncoding("UTF-8"); PrintWriter out = response.getWriter(); out.write(e.getMessage()); } @@ -114,10 +111,10 @@ public class FnMenuController extends RestrictedBaseController { @RequestMapping(value = { "/admin_fn_menu" }, method = RequestMethod.GET) public void getFnMenuList(HttpServletRequest request, HttpServletResponse response) { - Map model = new HashMap(); + Map model = new HashMap<>(); ObjectMapper mapper = new ObjectMapper(); List temp = null; - List> childItemList = new ArrayList>(); + List> childItemList = new ArrayList<>(); List parentList = new ArrayList<>(); try { @@ -142,20 +139,10 @@ public class FnMenuController extends RestrictedBaseController { parentData.setSeparator(menu.isSeparator()); parentData.setImageSrc(menu.getImageSrc()); parentList.add(parentData); - List tempList = new ArrayList(); - // int countChildAction = 0; - /* - * for(Object o:menu.getChildMenus()){ Menu m = (Menu)o; Menu - * data = new Menu(); data.setId(m.getId()); - * data.setLabel(m.getLabel()); data.setAction(m.getAction()); - * data.setImageSrc(m.getImageSrc()); tempList.add(data); } - */ + List tempList = new ArrayList<>(); childItemList.add(tempList); } model.put("fnMenuItems", parentList); - // JsonMessage msg = new - // JsonMessage(mapper.writeValueAsString(parentList),mapper.writeValueAsString(childItemList),"none"); - JsonMessage msg = new JsonMessage(mapper.writeValueAsString(model)); JSONObject j = new JSONObject(msg); response.getWriter().write(j.toString()); @@ -234,10 +221,12 @@ public class FnMenuController extends RestrictedBaseController { } + @Override public String getViewName() { return viewName; } + @Override public void setViewName(String viewName) { this.viewName = viewName; } diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/FuncMenuController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/FuncMenuController.java index aef83c49..3ad49860 100644 --- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/FuncMenuController.java +++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/FuncMenuController.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -74,26 +74,29 @@ import org.springframework.web.bind.annotation.RequestMethod; @RequestMapping("/") @org.springframework.context.annotation.Configuration @EnableAspectJAutoProxy -public class FuncMenuController extends RestrictedBaseController{ - +public class FuncMenuController extends RestrictedBaseController { + private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(FuncMenuController.class); @Autowired private AppService appService; @AuditLog - @RequestMapping(value = {"/get_functional_menu" }, method = RequestMethod.GET) + @RequestMapping(value = { "/get_functional_menu" }, method = RequestMethod.GET) public void functionalMenu(HttpServletRequest request, HttpServletResponse response) { - - User user = UserUtils.getUserSession(request); - //JSONArray validMenu = new JSONArray("[{\"menuId\":140,\"column\":1,\"text\":\"RT SDK Menu\",\"parentMenuId\":139,\"url\":\"http://www.cnn.com\"},{\"menuId\":139,\"column\":1,\"text\":\"RT Menu\",\"parentMenuId\":11,\"url\":\"\"},{\"menuId\":11,\"column\":1,\"text\":\"Product Design\",\"parentMenuId\":1,\"url\":\"\"},{\"menuId\":1,\"column\":1,\"text\":\"Design\",\"url\":\"\"}]"); - + + User user = UserUtils.getUserSession(request); + try { - if ( user != null ) { - String useRestForFunctionalMenu = PortalApiProperties.getProperty(PortalApiConstants.USE_REST_FOR_FUNCTIONAL_MENU); - String funcMenuJsonString = ""; - if (useRestForFunctionalMenu==null || useRestForFunctionalMenu=="" || useRestForFunctionalMenu.equalsIgnoreCase("false")) { - logger.info(EELFLoggerDelegate.errorLogger, "Making use of UEB communication and Requesting functional menu for user " + user.getOrgUserId()); + if (user != null) { + String useRestForFunctionalMenu = PortalApiProperties + .getProperty(PortalApiConstants.USE_REST_FOR_FUNCTIONAL_MENU); + String funcMenuJsonString; + if (useRestForFunctionalMenu == null || "".equals(useRestForFunctionalMenu) + || "false".equalsIgnoreCase(useRestForFunctionalMenu)) { + logger.debug(EELFLoggerDelegate.debugLogger, + "Making use of UEB communication and Requesting functional menu for user " + + user.getOrgUserId()); funcMenuJsonString = getFunctionalMenu(user.getOrgUserId()); } else { funcMenuJsonString = getFunctionalMenuViaREST(user.getOrgUserId()); @@ -101,93 +104,95 @@ public class FuncMenuController extends RestrictedBaseController{ response.setContentType("application/json"); response.getWriter().write(funcMenuJsonString); } else { - logger.info(EELFLoggerDelegate.errorLogger, "Http request did not contain user info, cannot retrieve functional menu"); - response.setContentType("application/json"); - JSONArray jsonResponse = new JSONArray(); - JSONObject error = new JSONObject(); - error.put("error","Http request did not contain user info, cannot retrieve functional menu"); + logger.error(EELFLoggerDelegate.errorLogger, + "Http request did not contain user info, cannot retrieve functional menu"); + response.setContentType("application/json"); + JSONArray jsonResponse = new JSONArray(); + JSONObject error = new JSONObject(); + error.put("error", "Http request did not contain user info, cannot retrieve functional menu"); jsonResponse.put(error); response.getWriter().write(jsonResponse.toString()); - } - } catch (Exception e) { + } + } catch (Exception e) { + logger.error(EELFLoggerDelegate.errorLogger, "functionalMenu failed", e); response.setCharacterEncoding("UTF-8"); - response.setContentType("application/json"); - JSONArray jsonResponse = new JSONArray(); - JSONObject error = new JSONObject(); + response.setContentType("application/json"); + JSONArray jsonResponse = new JSONArray(); + JSONObject error = new JSONObject(); try { - if ( null == e.getMessage() ) { - error.put("error","No menu data"); + if (null == e.getMessage()) { + error.put("error", "No menu data"); } else { - error.put("error",e.getMessage()); + error.put("error", e.getMessage()); } jsonResponse.put(error); response.getWriter().write(jsonResponse.toString()); - logger.error(EELFLoggerDelegate.errorLogger, "Error getting functional_menu: " + e.getMessage(),AlarmSeverityEnum.MAJOR); } catch (IOException e1) { - e1.printStackTrace(); + logger.error(EELFLoggerDelegate.errorLogger, "Error getting functional_menu", e1); } } - + } - - //-------------------------------------------------------------------------- + + // -------------------------------------------------------------------------- // Makes a synchronous call to ECOMP Portal to get the JSON file that - // contains the contents of the functional menu. The JSON file will be + // contains the contents of the functional menu. The JSON file will be // in the payload of the returned UEB message. - //-------------------------------------------------------------------------- - private String getFunctionalMenu(String userId) throws UebException - { + // -------------------------------------------------------------------------- + private String getFunctionalMenu(String userId) throws UebException { String returnString = null; - UebMsg funcMenuUebMsg = null; UebMsg msg = new UebMsg(); msg.putMsgType(UebMsgTypes.UEB_MSG_TYPE_GET_FUNC_MENU); msg.putUserId(userId); - funcMenuUebMsg = UebManager.getInstance().requestReply(msg); + UebMsg funcMenuUebMsg = UebManager.getInstance().requestReply(msg); if (funcMenuUebMsg != null) { if (funcMenuUebMsg.getPayload().startsWith("Error:")) { - logger.error(EELFLoggerDelegate.errorLogger, "getFunctionalMenu received an error in UEB msg = " + funcMenuUebMsg.getPayload()); + logger.error(EELFLoggerDelegate.errorLogger, + "getFunctionalMenu received an error in UEB msg = " + funcMenuUebMsg.getPayload()); } else { returnString = funcMenuUebMsg.getPayload(); } } - + logger.debug(EELFLoggerDelegate.debugLogger, "FunctionalMenu response: " + returnString); - - return returnString; + return returnString; } - + private String getFunctionalMenuViaREST(String userId) { - String appName = ""; - String requestId = ""; - String appUserName = ""; - String decryptedPwd = ""; - - logger.info(EELFLoggerDelegate.debugLogger, "Making use of REST API communication and Requesting functional menu for user " + userId); - + String appName; + String requestId; + String appUserName = ""; + String decryptedPwd = null; + + logger.debug(EELFLoggerDelegate.debugLogger, + "Making use of REST API communication and Requesting functional menu for user " + userId); + App app = appService.getDefaultApp(); - if (app!=null) { - appName = app.getName(); + if (app != null) { + appName = app.getName(); appUserName = app.getUsername(); - try{ - decryptedPwd = CipherUtil.decrypt(app.getAppPassword(), SystemProperties.getProperty(SystemProperties.Decryption_Key)); - } catch(Exception e) { - logger.error(EELFLoggerDelegate.errorLogger, "Exception occurred in WebServiceCallServiceImpl.get while decrypting the password. Details: " + e.toString()); + try { + decryptedPwd = CipherUtil.decrypt(app.getAppPassword(), + SystemProperties.getProperty(SystemProperties.Decryption_Key)); + } catch (Exception e) { + logger.error(EELFLoggerDelegate.errorLogger, + "getFunctionalMenuViaREST failed while decrypting the password", e); } } else { - logger.warn(EELFLoggerDelegate.errorLogger, "Unable to locate the app information from the database."); - appName = SystemProperties.SDK_NAME; + logger.error(EELFLoggerDelegate.errorLogger, "Unable to locate the app information from the database."); + appName = SystemProperties.SDK_NAME; } requestId = MDC.get(MDC_KEY_REQUEST_ID); - + String fnMenu = null; try { fnMenu = FunctionalMenuClient.getFunctionalMenu(userId, appName, requestId, appUserName, decryptedPwd); - }catch(Exception ex) { + } catch (Exception ex) { + logger.error(EELFLoggerDelegate.errorLogger, "getFunctionalMenuViaREST failed", ex); fnMenu = "Failed to get functional menu: " + ex.toString(); } - + logger.debug(EELFLoggerDelegate.debugLogger, "FunctionalMenu response: {}", fnMenu); - return fnMenu; } } \ No newline at end of file diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/LogoutController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/LogoutController.java index 4fc7e188..548ad986 100644 --- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/LogoutController.java +++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/LogoutController.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -38,11 +38,9 @@ package org.onap.portalapp.controller.core; import javax.servlet.http.HttpServletRequest; -import javax.servlet.http.HttpServletResponse; import org.onap.portalsdk.core.controller.UnRestrictedBaseController; import org.onap.portalsdk.core.domain.User; -import org.onap.portalsdk.core.logging.format.AlarmSeverityEnum; import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate; import org.onap.portalsdk.core.onboarding.util.PortalApiConstants; import org.onap.portalsdk.core.onboarding.util.PortalApiProperties; @@ -56,67 +54,61 @@ import org.springframework.web.servlet.ModelAndView; @Controller @RequestMapping("/") -public class LogoutController extends UnRestrictedBaseController{ +public class LogoutController extends UnRestrictedBaseController { private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(LogoutController.class); private User user; - + /** + * + * invalidates the current application session, then redirects to portal logout + * * @param request - * @param response * @return modelView - * - * globalLogout will invalid the current application session, then redirects to portal logout */ - @RequestMapping(value = {"/logout.htm" }, method = RequestMethod.GET) - public ModelAndView globalLogout(HttpServletRequest request, HttpServletResponse response) { + @RequestMapping(value = { "/logout.htm" }, method = RequestMethod.GET) + public ModelAndView globalLogout(HttpServletRequest request) { ModelAndView modelView = null; - try{ + try { chatRoomLogout(request); request.getSession().invalidate(); - String portalUrl = PortalApiProperties.getProperty(PortalApiConstants.ECOMP_REDIRECT_URL); + String portalUrl = PortalApiProperties.getProperty(PortalApiConstants.ECOMP_REDIRECT_URL); String portalDomain = portalUrl.substring(0, portalUrl.lastIndexOf('/')); - String redirectUrl = portalDomain+"/logout.htm"; - modelView = new ModelAndView("redirect:"+redirectUrl); - }catch(Exception e){ - logger.error(EELFLoggerDelegate.errorLogger, "Logout Error: " + e.getMessage(),AlarmSeverityEnum.MAJOR); + String redirectUrl = portalDomain + "/logout.htm"; + modelView = new ModelAndView("redirect:" + redirectUrl); + } catch (Exception e) { + logger.error(EELFLoggerDelegate.errorLogger, "Logout failed", e); } return modelView; } /** + * + * invalidates the current session (application logout) and redirects user to + * Portal. + * * @param request - * @param response * @return modelView - * - * appLogout is a function that will invalid the current session (application logout) and redirects user to Portal. */ - @RequestMapping(value = {"/app_logout.htm" }, method = RequestMethod.GET) - public ModelAndView appLogout(HttpServletRequest request, HttpServletResponse response) { + @RequestMapping(value = { "/app_logout.htm" }, method = RequestMethod.GET) + public ModelAndView appLogout(HttpServletRequest request) { ModelAndView modelView = null; - try{ + try { chatRoomLogout(request); - modelView = new ModelAndView("redirect:"+PortalApiProperties.getProperty(PortalApiConstants.ECOMP_REDIRECT_URL)); - UserUtils.clearUserSession(request); + modelView = new ModelAndView( + "redirect:" + PortalApiProperties.getProperty(PortalApiConstants.ECOMP_REDIRECT_URL)); + UserUtils.clearUserSession(request); request.getSession().invalidate(); - }catch(Exception e){ - logger.error(EELFLoggerDelegate.errorLogger, "Application Logout Error: " + e.getMessage(),AlarmSeverityEnum.MAJOR); + } catch (Exception e) { + logger.error(EELFLoggerDelegate.errorLogger, "Application Logout failed", e); } return modelView; } - - public void chatRoomLogout(HttpServletRequest request){ - request = ((ServletRequestAttributes)RequestContextHolder.currentRequestAttributes()).getRequest(); + public void chatRoomLogout(HttpServletRequest request) { + request = ((ServletRequestAttributes) RequestContextHolder.currentRequestAttributes()).getRequest(); setUser(UserUtils.getUserSession(request)); - // if(getUser()!=null){ - // Long login_IdLong = getUser().getId(); - // String name = getUser().getFirstName(); - // String login_IdStr = Long.toString(login_IdLong); - // } - //UserListName.getInstance().delUserName(name); - //UserListID.getInstance().delUserName(login_IdStr); } public User getUser() { @@ -127,5 +119,4 @@ public class LogoutController extends UnRestrictedBaseController{ this.user = user; } - } diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/ManifestController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/ManifestController.java index 885ab994..b7236490 100644 --- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/ManifestController.java +++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/ManifestController.java @@ -6,7 +6,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the “License”); + * under the Apache License, Version 2.0 (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * @@ -19,7 +19,7 @@ * limitations under the License. * * Unless otherwise specified, all documentation contained herein is licensed - * under the Creative Commons License, Attribution 4.0 Intl. (the “License”); + * under the Creative Commons License, Attribution 4.0 Intl. (the "License"); * you may not use this documentation except in compliance with the License. * You may obtain a copy of the License at * @@ -68,15 +68,15 @@ public class ManifestController extends RestrictedBaseController { private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(ManifestController.class); + /** Path to resource on classpath */ + private static final String MANIFEST_RESOURCE_PATH = "/META-INF/MANIFEST.MF"; + /** * Required to obtain the webapp manifest. */ @Autowired private ServletContext context; - /** Path to resource on classpath */ - private final String MANIFEST_RESOURCE_PATH = "/META-INF/MANIFEST.MF"; - /** * Gets the content of the webapp manifest file META-INF/MANIFEST.MF. * @@ -96,7 +96,6 @@ public class ManifestController extends RestrictedBaseController { /** * Gets the webapp manifest contents as a JSON object. * - * @param request * @return A map of key-value pairs. On success: * * 
@@ -114,13 +113,13 @@ public class ManifestController extends RestrictedBaseController {
 	 */
 	@RequestMapping(value = { "/manifest" }, method = RequestMethod.GET, produces = "application/json")
 	@ResponseBody
-	public Map getManifest(HttpServletRequest request) {
+	public Map getManifest() {
 		try {
 			Attributes attributes = getWebappManifest();
 			return attributes;
 		} catch (Exception ex) {
 			logger.error(EELFLoggerDelegate.errorLogger, "getManifest failed", ex);
-			Map response = new HashMap();
+			Map response = new HashMap<>();
 			response.put("error", "failed to get manifest: " + ex.toString());
 			return response;
 		}
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/MenuListController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/MenuListController.java
index 2300cf46..af580cb7 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/MenuListController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/MenuListController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -92,15 +92,14 @@ public class MenuListController extends RestrictedBaseController {
 		logger.debug(EELFLoggerDelegate.debugLogger, "getMenu begins");
 		try {
 			ObjectMapper mapper = new ObjectMapper();
-			Set menuResult = null;
 			HttpSession session = request.getSession();
 			List> childItemList = (List>) session
 					.getAttribute(SystemProperties.LEFT_MENU_CHILDREND);
 			List parentList = (List) session.getAttribute(SystemProperties.LEFT_MENU_PARENT);
-			if (parentList == null || childItemList == null || parentList.size() == 0 || childItemList.size() == 0) {
-				childItemList = new ArrayList>();
-				parentList = new ArrayList();
-				menuResult = (Set) session
+			if (parentList == null || childItemList == null || parentList.isEmpty() || childItemList.isEmpty()) {
+				childItemList = new ArrayList<>();
+				parentList = new ArrayList<>();
+				Set menuResult = (Set) session
 						.getAttribute(SystemProperties.getProperty(SystemProperties.APPLICATION_MENU_ATTRIBUTE_NAME));
 				fnMenuService.setMenuDataStructure(childItemList, parentList, menuResult);
 				logger.debug(EELFLoggerDelegate.debugLogger, "storing leftmenu items into session");
@@ -157,15 +156,15 @@ public class MenuListController extends RestrictedBaseController {
 	public Map getLeftMenuJSP(HttpServletRequest request) {
 		logger.debug(EELFLoggerDelegate.debugLogger, "getLeftMenuJSP begins");
 		ObjectMapper mapper = new ObjectMapper();
-		Map model = new HashMap();
+		Map model = new HashMap<>();
 		try {
 			HttpSession session = request.getSession();
 			List> childItemList = (List>) session
 					.getAttribute(SystemProperties.LEFT_MENU_CHILDREND);
 			List parentList = (List) session.getAttribute(SystemProperties.LEFT_MENU_PARENT);
 			if (parentList == null || childItemList == null) {
-				childItemList = new ArrayList>();
-				parentList = new ArrayList();
+				childItemList = new ArrayList<>();
+				parentList = new ArrayList<>();
 				Set menuResult = (Set) session
 						.getAttribute(SystemProperties.getProperty(SystemProperties.APPLICATION_MENU_ATTRIBUTE_NAME));
 				fnMenuService.setMenuDataStructure(childItemList, parentList, menuResult);
@@ -203,7 +202,7 @@ public class MenuListController extends RestrictedBaseController {
 			List sharedContextRes = sharedContextRestClient.getUserContext(contextId);
 			logger.debug(EELFLoggerDelegate.debugLogger, "getUserInfo: Shared Context Response is {}",
 					sharedContextRes);
-			Map model = new HashMap();
+			Map model = new HashMap<>();
 			for (SharedContext sharedContext : sharedContextRes) {
 				model.put(sharedContext.getCkey(), sharedContext.getCvalue());
 			}
@@ -223,7 +222,6 @@ public class MenuListController extends RestrictedBaseController {
 	 */
 	@RequestMapping(value = { "/get_topMenuInfo" }, method = RequestMethod.GET)
 	public void getTopMenu(HttpServletRequest request, HttpServletResponse response) {
-		@SuppressWarnings("unused")
 		boolean isAppCentralized = false;
 		HttpSession session = request.getSession();
 		try {
@@ -231,7 +229,7 @@ public class MenuListController extends RestrictedBaseController {
 			String firstName = (String) session.getAttribute(SystemProperties.FIRST_NAME);
 			String lastName = (String) session.getAttribute(SystemProperties.LAST_NAME);
 			User user = (User) session.getAttribute(SystemProperties.getProperty(SystemProperties.USER_ATTRIBUTE_NAME));
-			Map map = new HashMap();
+			Map map = new HashMap<>();
 			String redirectUrl = PortalApiProperties.getProperty(PortalApiConstants.ECOMP_REDIRECT_URL);
 			String portalDomain = redirectUrl.substring(0, redirectUrl.lastIndexOf('/'));
 			String portalUrl = portalDomain + "/process_csp";
@@ -244,10 +242,10 @@ public class MenuListController extends RestrictedBaseController {
 			map.put("lastName", lastName);
 			map.put("userid", user.getOrgUserId());
 			map.put("email", user.getEmail());
-			map.put("getAccessUrl", getAccessUrl); 
+			map.put("getAccessUrl", getAccessUrl);
 			String roleAccessCentralized = PortalApiProperties.getProperty(PortalApiConstants.ROLE_ACCESS_CENTRALIZED);
 			if (roleAccessCentralized != null && "remote".equals(roleAccessCentralized))
-			isAppCentralized = true;
+				isAppCentralized = true;
 			map.put("isAppCentralized", Boolean.toString(isAppCentralized));
 			JSONObject j = new JSONObject(map);
 			response.setContentType("application/json");
@@ -263,9 +261,9 @@ public class MenuListController extends RestrictedBaseController {
 		String pageToURL = null;
 		try {
 			String pageTo = request.getParameter("page");
-			if (pageTo.equals("contact"))
+			if ("contact".equals(pageTo))
 				pageToURL = SystemProperties.getProperty(SystemProperties.CONTACT_US_LINK);
-			else if (pageTo.equals("access")) {
+			else if ("access".equals(pageTo)) {
 				String redirectUrl = PortalApiProperties.getProperty(PortalApiConstants.ECOMP_REDIRECT_URL);
 				String portalDomain = redirectUrl.substring(0, redirectUrl.lastIndexOf('/'));
 				pageToURL = portalDomain + "/get_access";
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/PostSearchController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/PostSearchController.java
index d1ced9b5..59df7e9a 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/PostSearchController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/PostSearchController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,6 +37,7 @@
  */
 package org.onap.portalapp.controller.core;
 
+import java.io.IOException;
 import java.io.PrintWriter;
 import java.util.ArrayList;
 import java.util.HashMap;
@@ -44,6 +45,7 @@ import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
 
+import javax.naming.NamingException;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 
@@ -89,10 +91,8 @@ public class PostSearchController extends RestrictedBaseController {
 	private ProfileService profileService;
 
 	@RequestMapping(value = { "/post_search" }, method = RequestMethod.GET)
-	public ModelAndView welcome(HttpServletRequest request,
-			@ModelAttribute("postSearchBean") PostSearchBean postSearchBean) {
-		Map model = new HashMap();
-
+	public ModelAndView welcome(@ModelAttribute("postSearchBean") PostSearchBean postSearchBean) {
+		Map model = new HashMap<>();
 		ObjectMapper mapper = new ObjectMapper();
 		try {
 			postSearchBean = new PostSearchBean();
@@ -101,17 +101,16 @@ public class PostSearchController extends RestrictedBaseController {
 			model.put("existingUsers", mapper.writeValueAsString(getExistingUsers()));
 			model.put("sortByList", mapper.writeValueAsString(getSortByList()));
 		} catch (Exception ex) {
-			logger.error(EELFLoggerDelegate.errorLogger, "welcome: failed to write JSON" + ex.getMessage());
+			logger.error(EELFLoggerDelegate.errorLogger, "welcome: failed to write JSON", ex);
 		}
 
 		return new ModelAndView(getViewName(), model);
 	}
 
 	@RequestMapping(value = { "/post_search_sample" }, method = RequestMethod.GET)
-	public void getPostSearchProfile(HttpServletRequest request, HttpServletResponse response,
+	public void getPostSearchProfile(HttpServletResponse response,
 			@ModelAttribute("postSearchBean") PostSearchBean postSearchBean) {
-		Map model = new HashMap();
-
+		Map model = new HashMap<>();
 		ObjectMapper mapper = new ObjectMapper();
 		try {
 			postSearchBean = new PostSearchBean();
@@ -123,13 +122,12 @@ public class PostSearchController extends RestrictedBaseController {
 			JSONObject j = new JSONObject(msg);
 			response.getWriter().write(j.toString());
 		} catch (Exception ex) {
-			logger.error(EELFLoggerDelegate.errorLogger, "getPostSearchProfile: failed to write JSON" + ex.getMessage());
+			logger.error(EELFLoggerDelegate.errorLogger, "getPostSearchProfile: failed to write JSON", ex);
 		}
-
 	}
 
 	@SuppressWarnings({ "unchecked", "rawtypes" })
-	private HashMap getExistingUsers() throws Exception {
+	private HashMap getExistingUsers() throws IOException {
 		HashMap existingUsers = new HashMap();
 
 		// get the list of user ids in the system
@@ -149,7 +147,7 @@ public class PostSearchController extends RestrictedBaseController {
 	}
 
 	@RequestMapping(value = { "/post_search/search" }, method = RequestMethod.POST)
-	public ModelAndView search(HttpServletRequest request, HttpServletResponse response) throws Exception {
+	public ModelAndView search(HttpServletRequest request, HttpServletResponse response) {
 		try {
 			ObjectMapper mapper = new ObjectMapper();
 			mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
@@ -169,7 +167,7 @@ public class PostSearchController extends RestrictedBaseController {
 
 			out.write(j.toString());
 		} catch (Exception ex) {
-			logger.error(EELFLoggerDelegate.errorLogger, "search: failed to send search result" + ex.getMessage());
+			logger.error(EELFLoggerDelegate.errorLogger, "search: failed to send search result", ex);
 		}
 
 		return null;
@@ -191,7 +189,7 @@ public class PostSearchController extends RestrictedBaseController {
 	} // getSortByList
 
 	private SearchResult loadSearchResultData(HttpServletRequest request, PostSearchBean searchCriteria)
-			throws Exception {
+			throws NamingException {
 		return ldapService.searchPost(searchCriteria.getUser(), searchCriteria.getSortBy1(),
 				searchCriteria.getSortBy2(), searchCriteria.getSortBy3(), searchCriteria.getPageNo(),
 				searchCriteria.getNewDataSize(), UserUtils.getUserSession(request).getId().intValue());
@@ -205,13 +203,14 @@ public class PostSearchController extends RestrictedBaseController {
 		JsonNode root = mapper.readTree(request.getReader());
 		PostSearchBean postSearch = mapper.readValue(root.get("postSearchBean").toString(), PostSearchBean.class);
 		String errorMsg = "{}";
-		try{
+		try {
 			postSearchService.process(request, postSearch);
 			postSearch.setSearchResult(loadSearchResultData(request, postSearch));
-		}catch(Exception e){
-			errorMsg=e.getMessage();
-			logger.error(EELFLoggerDelegate.errorLogger,"Exception occurred while performing PostSearchController.process. Details:", e);
-		}	
+		} catch (Exception e) {
+			errorMsg = e.getMessage();
+			logger.error(EELFLoggerDelegate.errorLogger,
+					"Exception occurred while performing PostSearchController.process. Details:", e);
+		}
 		logger.info(EELFLoggerDelegate.auditLogger, "Import new user from webphone ");
 		response.setCharacterEncoding("UTF-8");
 		response.setContentType("application / json");
@@ -220,10 +219,9 @@ public class PostSearchController extends RestrictedBaseController {
 		PrintWriter out = response.getWriter();
 		String postSearchString = mapper.writeValueAsString(postSearch);
 		JSONObject j = new JSONObject("{postSearchBean: " + postSearchString + ",existingUsers: "
-				+ mapper.writeValueAsString(getExistingUsers()) + ",errorMsg:"+errorMsg+"}");
+				+ mapper.writeValueAsString(getExistingUsers()) + ",errorMsg:" + errorMsg + "}");
 
 		out.write(j.toString());
-
 		return null;
 	}
 }
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/ProfileController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/ProfileController.java
index e1f70c2a..c83e926e 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/ProfileController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/ProfileController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -39,7 +39,6 @@ package org.onap.portalapp.controller.core;
 
 import java.io.IOException;
 import java.io.PrintWriter;
-import java.io.UnsupportedEncodingException;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -77,31 +76,30 @@ public class ProfileController extends RestrictedBaseController {
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(ProfileController.class);
 
 	@Autowired
-	UserProfileService service;
+	private UserProfileService service;
 	
 	@Autowired
-	UserService userService;
+	private UserService userService;
 	
 	@Autowired
-	RoleService roleService;
+	private RoleService roleService;
 
 	private String viewName;
 	
 	@RequestMapping(value = { "/profile" }, method = RequestMethod.GET)
-	public ModelAndView profile(HttpServletRequest request, HttpServletResponse response) throws Exception{
+	public ModelAndView profile(HttpServletRequest request) throws IOException {
 		Map model = new HashMap();
 		ObjectMapper mapper = new ObjectMapper();
 		User user = UserUtils.getUserSession(request);
 
-		User profile = null;
-		Long profileId = null;
-
+		User profile;
+		Long profileId;
 		if (request.getRequestURI().indexOf("self_profile.htm") > -1) {
 			profile = UserUtils.getUserSession(request);
 			profileId = profile.getId();
 		} else {
 			profileId = Long.parseLong(request.getParameter("profile_id"));
-			profile = (User) userService.getUser(String.valueOf(profileId));
+			profile = userService.getUser(String.valueOf(profileId));
 		}
 
 		try {
@@ -118,15 +116,13 @@ public class ProfileController extends RestrictedBaseController {
 	}
 
 	@RequestMapping(value = { "/self_profile" }, method = RequestMethod.GET)
-	public ModelAndView self_profile(HttpServletRequest request) throws Exception{
-		Map model = new HashMap();
+	public ModelAndView selfProfile(HttpServletRequest request) throws Exception{
+		Map model = new HashMap<>();
 		ObjectMapper mapper = new ObjectMapper();
 
-		User profile = null;
 		Long profileId = null;
 		User user = UserUtils.getUserSession(request);
-
-		profile = UserUtils.getUserSession(request);
+		User profile = UserUtils.getUserSession(request);
 		try {
 			model.put("stateList", mapper.writeValueAsString(getStates()));
 			model.put("countries", mapper.writeValueAsString(getCountries()));
@@ -135,21 +131,19 @@ public class ProfileController extends RestrictedBaseController {
 			model.put("profile", mapper.writeValueAsString(profile));
 			model.put("profileId", mapper.writeValueAsString(profileId));
 		} catch (Exception e) {
-			logger.error(EELFLoggerDelegate.errorLogger, "self_profile: failed to write JSON" + e.getMessage());
+			logger.error(EELFLoggerDelegate.errorLogger, "self_profile: failed to write JSON", e);
 		}
 		return new ModelAndView("profile", "model", model);
 	}
 
 	@RequestMapping(value = { "/get_self_profile" }, method = RequestMethod.GET)
-	public void getSelfProfile(HttpServletRequest request, HttpServletResponse response) throws Exception{
+	public void getSelfProfile(HttpServletRequest request, HttpServletResponse response) {
 		Map model = new HashMap();
 		ObjectMapper mapper = new ObjectMapper();
 		User user = UserUtils.getUserSession(request);
 
-		User profile = null;
 		Long profileId = null;
-
-		profile = (User) UserUtils.getUserSession(request);	
+		User profile = UserUtils.getUserSession(request);	
 		try {
 			model.put("stateList", mapper.writeValueAsString(getStates()));
 			model.put("countries", mapper.writeValueAsString(getCountries()));
@@ -161,26 +155,25 @@ public class ProfileController extends RestrictedBaseController {
 			JSONObject j = new JSONObject(msg);
 			response.getWriter().write(j.toString());
 		} catch (Exception e) {
-			logger.error(EELFLoggerDelegate.errorLogger, "getSelfProfile: failed to write JSON" + e.getMessage());
+			logger.error(EELFLoggerDelegate.errorLogger, "getSelfProfile: failed to write JSON", e);
 		}
 
 	}
 
 	@RequestMapping(value = { "/get_profile" }, method = RequestMethod.GET)
-	public void GetUser(HttpServletRequest request, HttpServletResponse response) {
-		Map model = new HashMap();
+	public void getUser(HttpServletRequest request, HttpServletResponse response) {
+		Map model = new HashMap<>();
 		User user = UserUtils.getUserSession(request);
 		ObjectMapper mapper = new ObjectMapper();
 		try {
-			User profile = null;
-			Long profileId = null;
+			User profile;
+			Long profileId;
 			if (request.getRequestURI().indexOf("self_profile.htm") > -1) {
 				profile = UserUtils.getUserSession(request);
 				profileId = profile.getId();
 			} else {
 				profileId = Long.parseLong(request.getParameter("profile_id"));
-				profile = (User) userService.getUser(String.valueOf(profileId));
-				
+				profile = userService.getUser(String.valueOf(profileId));				
 			}
 			model.put("stateList", mapper.writeValueAsString(getStates()));
 			model.put("countries", mapper.writeValueAsString(getCountries()));
@@ -193,7 +186,7 @@ public class ProfileController extends RestrictedBaseController {
 			response.getWriter().write(j.toString());
 
 		} catch (Exception e) {
-			logger.error(EELFLoggerDelegate.errorLogger, "GetUser: failed to write JSON" + e.getMessage());
+			logger.error(EELFLoggerDelegate.errorLogger, "getUser: failed to write JSON", e);
 		}
 	}
 
@@ -213,7 +206,6 @@ public class ProfileController extends RestrictedBaseController {
 			Long profileId = Long.parseLong(request.getParameter("profile_id"));
 
 			User domainUser = (User) userService.getUser(String.valueOf(profileId));
-			// user.setRoles(domainUser.getRoles());
 			user.setPseudoRoles(domainUser.getPseudoRoles());
 			user.setUserApps(domainUser.getUserApps());
 			if (!selectedCountry.equals("")) {
@@ -226,13 +218,14 @@ public class ProfileController extends RestrictedBaseController {
 				user.setTimeZoneId(Long.parseLong(selectedTimeZone));
 			}
 			service.saveUser(user);
-			logger.info(EELFLoggerDelegate.auditLogger, "Save user's profile for user " + profileId);
+			logger.info(EELFLoggerDelegate.auditLogger, "Save profile for user {}", profileId);
 			response.setCharacterEncoding("UTF-8");
 			response.setContentType("application / json");
 			PrintWriter out = response.getWriter();
 			out.write("" + profileId);
 			return null;
 		} catch (Exception e) {
+			logger.error(EELFLoggerDelegate.errorLogger, "saveProfile failed", e);
 			response.setCharacterEncoding("UTF-8");			
 			try {
 				PrintWriter 	out = response.getWriter();
@@ -245,7 +238,7 @@ public class ProfileController extends RestrictedBaseController {
 	}
 
 	@RequestMapping(value = { "/profile/removeRole" }, method = RequestMethod.POST)
-	public ModelAndView removeRole(HttpServletRequest request, HttpServletResponse response) throws Exception {
+	public ModelAndView removeRole(HttpServletRequest request, HttpServletResponse response) throws IOException {
 
 		logger.info(EELFLoggerDelegate.debugLogger, "ProfileController.save");
 		try {
@@ -257,7 +250,7 @@ public class ProfileController extends RestrictedBaseController {
 
 			 String profileId = request.getParameter("profile_id");
 
-			User domainUser = (User) userService.getUser(profileId);
+			User domainUser = userService.getUser(profileId);
 
 			domainUser.removeRole(role.getId());
 
@@ -275,7 +268,7 @@ public class ProfileController extends RestrictedBaseController {
 
 			PrintWriter out = response.getWriter();
 
-			Map model = new HashMap();
+			Map model = new HashMap<>();
 			model.put("profile", mapper.writeValueAsString(domainUser));
 			JSONObject j = new JSONObject(mapper.writeValueAsString(domainUser));
 
@@ -283,18 +276,16 @@ public class ProfileController extends RestrictedBaseController {
 
 			return null;
 		} catch (Exception e) {
-			logger.error(EELFLoggerDelegate.errorLogger, "removeRole" + e.getMessage());
+			logger.error(EELFLoggerDelegate.errorLogger, "removeRole failed", e);
 			response.setCharacterEncoding("UTF-8");
-			request.setCharacterEncoding("UTF-8");
 			PrintWriter out = response.getWriter();
 			out.write(e.getMessage());
 			return null;
 		}
-
 	}
 
 	@RequestMapping(value = { "/profile/addNewRole" }, method = RequestMethod.POST)
-	public ModelAndView addNewRole(HttpServletRequest request, HttpServletResponse response) throws Exception {
+	public ModelAndView addNewRole(HttpServletRequest request, HttpServletResponse response) throws IOException {
 
 		logger.info(EELFLoggerDelegate.debugLogger, "ProfileController.save" );
 		try {
@@ -304,7 +295,7 @@ public class ProfileController extends RestrictedBaseController {
 			JsonNode root = mapper.readTree(request.getReader());
 			Role role = mapper.readValue(root.get("role").toString(), Role.class);
 			String profileId = request.getParameter("profile_id");
-			User domainUser = (User) userService.getUser(profileId);
+			User domainUser = userService.getUser(profileId);
 			domainUser.addRole(role);
 			service.saveUser(domainUser);
 			/*If removing roles on the current logged in user, we need to update the user value in session*/
@@ -319,7 +310,7 @@ public class ProfileController extends RestrictedBaseController {
 			request.setCharacterEncoding("UTF-8");
 
 			PrintWriter out = response.getWriter();
-			Map model = new HashMap();
+			Map model = new HashMap<>();
 			model.put("profile", mapper.writeValueAsString(domainUser));
 			JSONObject j = new JSONObject(mapper.writeValueAsString(domainUser));
 
@@ -327,7 +318,7 @@ public class ProfileController extends RestrictedBaseController {
 
 			return null;
 		} catch (Exception e) {
-			logger.error(EELFLoggerDelegate.errorLogger, "addNewRole" + e.getMessage());
+			logger.error(EELFLoggerDelegate.errorLogger, "addNewRole failed", e);
 			response.setCharacterEncoding("UTF-8");
 			request.setCharacterEncoding("UTF-8");
 			PrintWriter out = response.getWriter();
@@ -337,10 +328,12 @@ public class ProfileController extends RestrictedBaseController {
 
 	}
 
+	@Override
 	public String getViewName() {
 		return viewName;
 	}
 
+	@Override
 	public void setViewName(String viewName) {
 		this.viewName = viewName;
 	}
@@ -361,7 +354,7 @@ public class ProfileController extends RestrictedBaseController {
 	}
 
 	@SuppressWarnings("rawtypes")
-	public List getAvailableRoles(String requestedLoginId) throws Exception {
+	public List getAvailableRoles(String requestedLoginId) throws IOException {
 		return roleService.getAvailableRoles(requestedLoginId);
 	}
 
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/ProfileSearchController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/ProfileSearchController.java
index 3f933af8..2459e598 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/ProfileSearchController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/ProfileSearchController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -77,14 +77,14 @@ public class ProfileSearchController extends RestrictedBaseController {
 	private UserProfileService service;
 	
 	@Autowired
-	UserService userService;
+	private UserService userService;
 	
 	@Autowired
 	private FnMenuService fnMenuService;
 
 	@RequestMapping(value = { "/profile_search" }, method = RequestMethod.GET)
 	public ModelAndView profileSearch(HttpServletRequest request) {
-		Map model = new HashMap();
+		Map model = new HashMap<>();
 		ObjectMapper mapper = new ObjectMapper();
 		List profileList = null;
 		logger.info(EELFLoggerDelegate.applicationLogger, "Initiating ProfileSearch in ProfileSearchController");
@@ -116,7 +116,7 @@ public class ProfileSearchController extends RestrictedBaseController {
 
 	@RequestMapping(value = { "/get_user_pagination" }, method = RequestMethod.GET)
 	public void getUserPagination(HttpServletRequest request, HttpServletResponse response) {
-		Map model = new HashMap();
+		Map model = new HashMap<>();
 		ObjectMapper mapper = new ObjectMapper();
 		logger.info(EELFLoggerDelegate.applicationLogger, "Initiating get_user_pagination in ProfileSearchController");
 		int pageNum = Integer.parseInt(request.getParameter("pageNum"));
@@ -141,9 +141,9 @@ public class ProfileSearchController extends RestrictedBaseController {
 	@SuppressWarnings("unchecked")
 	private Map setDashboardData(HttpServletRequest request) throws Exception {
 		ObjectMapper mapper = new ObjectMapper();
-		Map model = new HashMap();
-		List> childItemList = new ArrayList>();
-		List parentList = new ArrayList();
+		Map model = new HashMap<>();
+		List> childItemList = new ArrayList<>();
+		List parentList = new ArrayList<>();
 		logger.info(EELFLoggerDelegate.applicationLogger, "Initiating setDashboardData in ProfileSearchController");
 		HttpSession session = request.getSession();
 		try {
@@ -164,7 +164,7 @@ public class ProfileSearchController extends RestrictedBaseController {
 			logger.info(EELFLoggerDelegate.applicationLogger,
 					"Initiating toggleProfileActive in ProfileSearchController");
 			String userId = request.getParameter("profile_id");
-			User user = (User) userService.getUser(userId);
+			User user = userService.getUser(userId);
 			user.setActive(!user.getActive());
 			service.saveUser(user);
 			logger.info(EELFLoggerDelegate.auditLogger,
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/RoleController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/RoleController.java
index 56cea604..b1377007 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/RoleController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/RoleController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -82,17 +82,19 @@ public class RoleController extends RestrictedBaseController {
 	private String viewName;
 
 	@RequestMapping(value = { "/role" }, method = RequestMethod.GET)
-	public ModelAndView role(HttpServletRequest request) throws Exception {
-		Map model = new HashMap();
+	public ModelAndView role(HttpServletRequest request) throws IOException {
+		Map model = new HashMap<>();
 		ObjectMapper mapper = new ObjectMapper();
 		User user = UserUtils.getUserSession(request);
 
-
-		Role role = roleService.getRole(user.getOrgUserId(),new Long(ServletRequestUtils.getIntParameter(request, "role_id", 0)));
+		Role role = roleService.getRole(user.getOrgUserId(),
+				new Long(ServletRequestUtils.getIntParameter(request, "role_id", 0)));
 		logger.info("role_id" + role.getId());
 		try {
-			model.put("availableRoleFunctions", mapper.writeValueAsString(roleService.getRoleFunctions(user.getOrgUserId())));
-			model.put("availableRoles", mapper.writeValueAsString(roleService.getAvailableChildRoles(user.getOrgUserId(),role.getId())));
+			model.put("availableRoleFunctions",
+					mapper.writeValueAsString(roleService.getRoleFunctions(user.getOrgUserId())));
+			model.put("availableRoles",
+					mapper.writeValueAsString(roleService.getAvailableChildRoles(user.getOrgUserId(), role.getId())));
 			model.put("role", mapper.writeValueAsString(role));
 		} catch (Exception e) {
 			logger.error("role: failed", e);
@@ -102,16 +104,19 @@ public class RoleController extends RestrictedBaseController {
 	}
 
 	@RequestMapping(value = { "/get_role" }, method = RequestMethod.GET)
-	public void getRole(HttpServletRequest request, HttpServletResponse response) throws Exception {
-		Map model = new HashMap();
+	public void getRole(HttpServletRequest request, HttpServletResponse response) throws IOException {
+		Map model = new HashMap<>();
 		ObjectMapper mapper = new ObjectMapper();
 		User user = UserUtils.getUserSession(request);
 
-		Role role = roleService.getRole(user.getOrgUserId(),new Long(ServletRequestUtils.getIntParameter(request, "role_id", 0)));
+		Role role = roleService.getRole(user.getOrgUserId(),
+				new Long(ServletRequestUtils.getIntParameter(request, "role_id", 0)));
 		logger.info(EELFLoggerDelegate.applicationLogger, "role_id" + role.getId());
 		try {
-			model.put("availableRoleFunctions", mapper.writeValueAsString(roleService.getRoleFunctions(user.getOrgUserId())));
-			model.put("availableRoles", mapper.writeValueAsString(roleService.getAvailableChildRoles(user.getOrgUserId(),role.getId())));
+			model.put("availableRoleFunctions",
+					mapper.writeValueAsString(roleService.getRoleFunctions(user.getOrgUserId())));
+			model.put("availableRoles",
+					mapper.writeValueAsString(roleService.getAvailableChildRoles(user.getOrgUserId(), role.getId())));
 			model.put("role", mapper.writeValueAsString(role));
 
 			JsonMessage msg = new JsonMessage(mapper.writeValueAsString(model));
@@ -149,11 +154,10 @@ public class RoleController extends RestrictedBaseController {
 			List roleFunctions = mapper.readValue(root.get("roleFunctions").toString(),
 					TypeFactory.defaultInstance().constructCollectionType(List.class, RoleFunction.class));
 
-			Role domainRole = null;
+			Role domainRole;
 			if (role.getId() != null) {
 				doAuditLog("saveRole: updating existing role {}", role.getId());
-				domainRole = roleService.getRole(user.getOrgUserId(),role.getId());
-
+				domainRole = roleService.getRole(user.getOrgUserId(), role.getId());
 				domainRole.setName(role.getName());
 				domainRole.setPriority(role.getPriority());
 			} else {
@@ -167,23 +171,19 @@ public class RoleController extends RestrictedBaseController {
 				domainRole = new Role();
 				domainRole.setName(role.getName());
 				domainRole.setPriority(role.getPriority());
-				if(role.getChildRoles() != null && role.getChildRoles().size() > 0 ){
-//				if (role.getChildRoles().size() > 0 ) {
+				if (role.getChildRoles() != null && role.getChildRoles().size() > 0) {
 					for (Object childRole : childRoles) {
 						domainRole.addChildRole((Role) childRole);
 					}
-//				}
 				}
-				if(role.getRoleFunctions() != null && role.getRoleFunctions().size() > 0){
-//				if (role.getRoleFunctions().size() > 0) {
+				if (role.getRoleFunctions() != null && role.getRoleFunctions().size() > 0) {
 					for (Object roleFunction : roleFunctions) {
 						domainRole.addRoleFunction((RoleFunction) roleFunction);
 					}
-//				}
 				}
 			}
 
-			roleService.saveRole(user.getOrgUserId(),domainRole);
+			roleService.saveRole(user.getOrgUserId(), domainRole);
 
 			String responseString = mapper.writeValueAsString(domainRole);
 			j = new JSONObject("{role: " + responseString + "}");
@@ -201,7 +201,7 @@ public class RoleController extends RestrictedBaseController {
 	}
 
 	@RequestMapping(value = { "/role/removeRoleFunction" }, method = RequestMethod.POST)
-	public ModelAndView removeRoleFunction(HttpServletRequest request, HttpServletResponse response) throws Exception {
+	public ModelAndView removeRoleFunction(HttpServletRequest request, HttpServletResponse response) throws IOException {
 		User user = UserUtils.getUserSession(request);
 		logger.info(EELFLoggerDelegate.applicationLogger, "RoleController.removeRoleFunction");
 		try {
@@ -211,13 +211,14 @@ public class RoleController extends RestrictedBaseController {
 			JsonNode root = mapper.readTree(request.getReader());
 			RoleFunction roleFunction = mapper.readValue(root.get("roleFunction").toString(), RoleFunction.class);
 
-			Role domainRole = roleService.getRole(user.getOrgUserId(),new Long(ServletRequestUtils.getIntParameter(request, "role_id", 0)));
+			Role domainRole = roleService.getRole(user.getOrgUserId(),
+					new Long(ServletRequestUtils.getIntParameter(request, "role_id", 0)));
 			doAuditLog("Remove role function {} from role {}", roleFunction.getCode(),
 					ServletRequestUtils.getIntParameter(request, "role_id", 0));
 
 			domainRole.removeRoleFunction(roleFunction.getCode());
 
-			roleService.saveRole(user.getOrgUserId(),domainRole);
+			roleService.saveRole(user.getOrgUserId(), domainRole);
 
 			response.setCharacterEncoding("UTF-8");
 			response.setContentType("application/json");
@@ -237,7 +238,7 @@ public class RoleController extends RestrictedBaseController {
 	}
 
 	@RequestMapping(value = { "/role/addRoleFunction" }, method = RequestMethod.POST)
-	public ModelAndView addRoleFunction(HttpServletRequest request, HttpServletResponse response) throws Exception {
+	public ModelAndView addRoleFunction(HttpServletRequest request, HttpServletResponse response) throws IOException {
 		User user = UserUtils.getUserSession(request);
 		logger.info(EELFLoggerDelegate.applicationLogger, "RoleController.removeRoleFunction");
 		try {
@@ -247,11 +248,12 @@ public class RoleController extends RestrictedBaseController {
 			JsonNode root = mapper.readTree(request.getReader());
 			RoleFunction roleFunction = mapper.readValue(root.get("roleFunction").toString(), RoleFunction.class);
 
-			Role domainRole = roleService.getRole(user.getOrgUserId(),new Long(ServletRequestUtils.getIntParameter(request, "role_id", 0)));
+			Role domainRole = roleService.getRole(user.getOrgUserId(),
+					new Long(ServletRequestUtils.getIntParameter(request, "role_id", 0)));
 
 			domainRole.addRoleFunction(roleFunction);
 
-			roleService.saveRole(user.getOrgUserId(),domainRole);
+			roleService.saveRole(user.getOrgUserId(), domainRole);
 			doAuditLog("Add role function {} to role {}", roleFunction.getCode(),
 					ServletRequestUtils.getIntParameter(request, "role_id", 0));
 
@@ -273,7 +275,7 @@ public class RoleController extends RestrictedBaseController {
 	}
 
 	@RequestMapping(value = { "/role/removeChildRole" }, method = RequestMethod.POST)
-	public ModelAndView removeChildRole(HttpServletRequest request, HttpServletResponse response) throws Exception {
+	public ModelAndView removeChildRole(HttpServletRequest request, HttpServletResponse response) throws IOException {
 		User user = UserUtils.getUserSession(request);
 		logger.info(EELFLoggerDelegate.applicationLogger, "RoleController.removeChileRole");
 		try {
@@ -282,13 +284,14 @@ public class RoleController extends RestrictedBaseController {
 			JsonNode root = mapper.readTree(request.getReader());
 			Role childRole = mapper.readValue(root.get("childRole").toString(), Role.class);
 
-			Role domainRole = roleService.getRole(user.getOrgUserId(),new Long(ServletRequestUtils.getIntParameter(request, "role_id", 0)));
+			Role domainRole = roleService.getRole(user.getOrgUserId(),
+					new Long(ServletRequestUtils.getIntParameter(request, "role_id", 0)));
 
 			domainRole.removeChildRole(childRole.getId());
 			doAuditLog("remove child role {} from role {}", childRole.getId(),
 					ServletRequestUtils.getIntParameter(request, "role_id", 0));
 
-			roleService.saveRole(user.getOrgUserId(),domainRole);
+			roleService.saveRole(user.getOrgUserId(), domainRole);
 
 			response.setCharacterEncoding("UTF-8");
 			response.setContentType("application/json");
@@ -308,7 +311,7 @@ public class RoleController extends RestrictedBaseController {
 	}
 
 	@RequestMapping(value = { "/role/addChildRole" }, method = RequestMethod.POST)
-	public ModelAndView addChildRole(HttpServletRequest request, HttpServletResponse response) throws Exception {
+	public ModelAndView addChildRole(HttpServletRequest request, HttpServletResponse response) throws IOException {
 		User user = UserUtils.getUserSession(request);
 		logger.info(EELFLoggerDelegate.applicationLogger, "RoleController.addChileRole");
 		try {
@@ -317,13 +320,13 @@ public class RoleController extends RestrictedBaseController {
 			mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
 			JsonNode root = mapper.readTree(request.getReader());
 			Role childRole = mapper.readValue(root.get("childRole").toString(), Role.class);
-			long role_id = new Long(ServletRequestUtils.getIntParameter(request, "role_id", 0));
+			Long role_id = new Long(ServletRequestUtils.getIntParameter(request, "role_id", 0));
 
-			Role domainRole = roleService.getRole(user.getOrgUserId(),role_id );
+			Role domainRole = roleService.getRole(user.getOrgUserId(), role_id);
 
 			domainRole.addChildRole(childRole);
 
-			roleService.saveRole(user.getOrgUserId(),domainRole);
+			roleService.saveRole(user.getOrgUserId(), domainRole);
 			doAuditLog("Add child role {} to role {}", childRole.getId(),
 					ServletRequestUtils.getIntParameter(request, "role_id", 0));
 
@@ -345,8 +348,8 @@ public class RoleController extends RestrictedBaseController {
 	}
 
 	/**
-	 * Sets context with begin and end timestamps at current date & time, writes
-	 * the specified message and parameters to the audit log, then removes the
+	 * Sets context with begin and end timestamps at current date & time, writes the
+	 * specified message and parameters to the audit log, then removes the
 	 * timestamps from context.
 	 * 
 	 * @param message
@@ -362,11 +365,14 @@ public class RoleController extends RestrictedBaseController {
 		MDC.remove(SystemProperties.AUDITLOG_END_TIMESTAMP);
 	}
 
+	@Override
 	public String getViewName() {
 		return viewName;
 	}
 
+	@Override
 	public void setViewName(String viewName) {
 		this.viewName = viewName;
 	}
-}
\ No newline at end of file
+	
+}
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/RoleFunctionListController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/RoleFunctionListController.java
index e1e3e132..ccdab9f0 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/RoleFunctionListController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/RoleFunctionListController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,6 +37,7 @@
  */
 package org.onap.portalapp.controller.core;
 
+import java.io.IOException;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -64,138 +65,136 @@ import com.fasterxml.jackson.databind.ObjectMapper;
 @Controller
 @RequestMapping("/")
 public class RoleFunctionListController extends RestrictedBaseController {
-	
+
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(RoleFunctionListController.class);
 
 	@Autowired
 	private RoleService service;
-	
+
 	private String viewName;
 
-	@RequestMapping(value = {"/role_function_list" }, method = RequestMethod.GET)
+	@RequestMapping(value = { "/role_function_list" }, method = RequestMethod.GET)
 	public ModelAndView welcome(HttpServletRequest request) {
-		Map model = new HashMap();
+		Map model = new HashMap<>();
 		ObjectMapper mapper = new ObjectMapper();
 		User user = UserUtils.getUserSession(request);
-
-		
 		try {
-			model.put("availableRoleFunctions", mapper.writeValueAsString(service.getRoleFunctions(user.getOrgUserId())));
+			model.put("availableRoleFunctions",
+					mapper.writeValueAsString(service.getRoleFunctions(user.getOrgUserId())));
 		} catch (Exception e) {
 			logger.error(EELFLoggerDelegate.errorLogger, "welcome failed", e);
 		}
-		
-		return new ModelAndView(getViewName(),model);		
+		return new ModelAndView(getViewName(), model);
 	}
-	
-	@RequestMapping(value = {"/get_role_functions" }, method = RequestMethod.GET)
-	public void getRoleFunctionList(HttpServletRequest request,HttpServletResponse response) {
-		Map model = new HashMap();
-		ObjectMapper mapper = new ObjectMapper();	
+
+	@RequestMapping(value = { "/get_role_functions" }, method = RequestMethod.GET)
+	public void getRoleFunctionList(HttpServletRequest request, HttpServletResponse response) {
+		Map model = new HashMap<>();
+		ObjectMapper mapper = new ObjectMapper();
 		User user = UserUtils.getUserSession(request);
 		try {
-			model.put("availableRoleFunctions", mapper.writeValueAsString(service.getRoleFunctions(user.getOrgUserId())));
+			model.put("availableRoleFunctions",
+					mapper.writeValueAsString(service.getRoleFunctions(user.getOrgUserId())));
 			JsonMessage msg = new JsonMessage(mapper.writeValueAsString(model));
 			JSONObject j = new JSONObject(msg);
-			response.getWriter().write(j.toString());	
+			response.getWriter().write(j.toString());
 		} catch (Exception e) {
 			logger.error(EELFLoggerDelegate.errorLogger, "getROleFunctionList failed", e);
 		}
-		
 	}
-	
-	@RequestMapping(value = {"/role_function_list/saveRoleFunction" }, method = RequestMethod.POST)
-	public void saveRoleFunction(HttpServletRequest request, 
-			HttpServletResponse response, @RequestBody String roleFunc) throws Exception {
+
+	@RequestMapping(value = { "/role_function_list/saveRoleFunction" }, method = RequestMethod.POST)
+	public void saveRoleFunction(HttpServletRequest request, HttpServletResponse response, @RequestBody String roleFunc)
+			throws IOException {
 		ObjectMapper mapper = new ObjectMapper();
 		User user = UserUtils.getUserSession(request);
 
 		String restCallStatus = "";
 		try {
 			String data = roleFunc;
-			RoleFunction availableRoleFunction = mapper.readValue(data, RoleFunction.class);		
+			RoleFunction availableRoleFunction = mapper.readValue(data, RoleFunction.class);
 			String code = availableRoleFunction.getCode();
-			RoleFunction domainRoleFunction = service.getRoleFunction(user.getOrgUserId(),code);
+			RoleFunction domainRoleFunction = service.getRoleFunction(user.getOrgUserId(), code);
 			domainRoleFunction.setName(availableRoleFunction.getName());
-			domainRoleFunction.setCode(code); 
-			restCallStatus="success";
-			service.saveRoleFunction(user.getOrgUserId(),domainRoleFunction);
+			domainRoleFunction.setCode(code);
+			restCallStatus = "success";
+			service.saveRoleFunction(user.getOrgUserId(), domainRoleFunction);
 		} catch (Exception e) {
-			restCallStatus="fail";
 			logger.error(EELFLoggerDelegate.errorLogger, "saveRoleFunction failed", e);
-			throw new Exception("failed  while Saving RoleFunction");
+			throw new IOException(e);
 		}
 		JsonMessage msg = new JsonMessage(mapper.writeValueAsString(restCallStatus));
 		JSONObject j = new JSONObject(msg);
 		response.getWriter().write(j.toString());
 	}
-	
-	@RequestMapping(value = {"/role_function_list/addRoleFunction" }, method = RequestMethod.POST)
-	public void addRoleFunction(HttpServletRequest request, 
-			HttpServletResponse response, @RequestBody String roleFunc) throws Exception {
+
+	@RequestMapping(value = { "/role_function_list/addRoleFunction" }, method = RequestMethod.POST)
+	public void addRoleFunction(HttpServletRequest request, HttpServletResponse response, @RequestBody String roleFunc)
+			throws IOException {
 		ObjectMapper mapper = new ObjectMapper();
 		User user = UserUtils.getUserSession(request);
 
 		String restCallStatus = "";
-		boolean canSave=true;
+		boolean canSave = true;
 		try {
 			String data = roleFunc;
-			RoleFunction availableRoleFunction = mapper.readValue(data, RoleFunction.class);		
-		    String code = availableRoleFunction.getCode();
+			RoleFunction availableRoleFunction = mapper.readValue(data, RoleFunction.class);
+			String code = availableRoleFunction.getCode();
 			List currentRoleFunction = service.getRoleFunctions(user.getOrgUserId());
-			restCallStatus="success";
-			for(RoleFunction roleF:currentRoleFunction){
-				if(roleF.getCode().equals(code)){
-					restCallStatus="code exists";
-					canSave=false;
+			restCallStatus = "success";
+			for (RoleFunction roleF : currentRoleFunction) {
+				if (roleF.getCode().equals(code)) {
+					restCallStatus = "code exists";
+					canSave = false;
 					break;
 				}
 			}
-			if(canSave)
-				service.saveRoleFunction(user.getOrgUserId(),availableRoleFunction);
+			if (canSave)
+				service.saveRoleFunction(user.getOrgUserId(), availableRoleFunction);
 		} catch (Exception e) {
-			restCallStatus="fail";
 			logger.error(EELFLoggerDelegate.errorLogger, "addRoleFunction failed", e);
-			throw new Exception(e.getMessage());
+			throw new IOException(e);
 		}
 		JsonMessage msg = new JsonMessage(mapper.writeValueAsString(restCallStatus));
 		JSONObject j = new JSONObject(msg);
 		response.getWriter().write(j.toString());
 	}
 
-	@RequestMapping(value = {"/role_function_list/removeRoleFunction" }, method = RequestMethod.POST)
-	public void removeRoleFunction(HttpServletRequest request, 
-			HttpServletResponse response, @RequestBody String roleFunc) throws Exception {
+	@RequestMapping(value = { "/role_function_list/removeRoleFunction" }, method = RequestMethod.POST)
+	public void removeRoleFunction(HttpServletRequest request, HttpServletResponse response,
+			@RequestBody String roleFunc) throws IOException {
 		ObjectMapper mapper = new ObjectMapper();
 		User user = UserUtils.getUserSession(request);
 
 		String restCallStatus = "";
 		try {
 			String data = roleFunc;
-		
+
 			RoleFunction availableRoleFunction = mapper.readValue(data, RoleFunction.class);
 
-			RoleFunction domainRoleFunction = service.getRoleFunction(user.getOrgUserId(),availableRoleFunction.getCode());
-			
-			service.deleteRoleFunction(user.getOrgUserId(),domainRoleFunction);
+			RoleFunction domainRoleFunction = service.getRoleFunction(user.getOrgUserId(),
+					availableRoleFunction.getCode());
+
+			service.deleteRoleFunction(user.getOrgUserId(), domainRoleFunction);
 			logger.info(EELFLoggerDelegate.auditLogger, "Remove role function " + domainRoleFunction.getName());
-			restCallStatus="success";
+			restCallStatus = "success";
 		} catch (Exception e) {
-			restCallStatus="fail";
 			logger.error(EELFLoggerDelegate.errorLogger, "removeRoleFunction failed", e);
-			throw new Exception(e.getMessage());
+			throw new IOException(e);
 		}
 		JsonMessage msg = new JsonMessage(mapper.writeValueAsString(restCallStatus));
 		JSONObject j = new JSONObject(msg);
 		response.getWriter().write(j.toString());
 	}
 
+	@Override
 	public String getViewName() {
 		return viewName;
 	}
+
+	@Override
 	public void setViewName(String viewName) {
 		this.viewName = viewName;
 	}
-	
-	
+
 }
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/RoleListController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/RoleListController.java
index 13310b07..e7682809 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/RoleListController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/RoleListController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,6 +37,7 @@
  */
 package org.onap.portalapp.controller.core;
 
+import java.io.IOException;
 import java.io.PrintWriter;
 import java.util.HashMap;
 import java.util.Map;
@@ -70,61 +71,52 @@ public class RoleListController extends RestrictedBaseController {
 
 	@Autowired
 	private RoleService service;
-	
+
 	private String viewName;
-	
-	@RequestMapping(value = {"/role_list" }, method = RequestMethod.GET)
+
+	@RequestMapping(value = { "/role_list" }, method = RequestMethod.GET)
 	public ModelAndView getRoleList(HttpServletRequest request) {
-		Map model = new HashMap();
-		ObjectMapper mapper = new ObjectMapper();	
+		Map model = new HashMap<>();
+		ObjectMapper mapper = new ObjectMapper();
 		User user = UserUtils.getUserSession(request);
-
-		
 		try {
 			model.put("availableRoles", mapper.writeValueAsString(service.getAvailableRoles(user.getOrgUserId())));
 		} catch (Exception e) {
 			logger.error(EELFLoggerDelegate.errorLogger, "getRoleList failed", e);
 		}
-	
-		return new ModelAndView(getViewName(),model);
+		return new ModelAndView(getViewName(), model);
 	}
-	
-	@RequestMapping(value = {"/get_roles" }, method = RequestMethod.GET)
+
+	@RequestMapping(value = { "/get_roles" }, method = RequestMethod.GET)
 	public void getRoles(HttpServletRequest request, HttpServletResponse response) {
-		Map model = new HashMap();
+		Map model = new HashMap<>();
 		ObjectMapper mapper = new ObjectMapper();
 		User user = UserUtils.getUserSession(request);
-
-		
 		try {
 			model.put("availableRoles", mapper.writeValueAsString(service.getAvailableRoles(user.getOrgUserId())));
 			JsonMessage msg = new JsonMessage(mapper.writeValueAsString(model));
 			JSONObject j = new JSONObject(msg);
-			response.getWriter().write(j.toString());	
+			response.getWriter().write(j.toString());
 		} catch (Exception e) {
 			logger.error(EELFLoggerDelegate.errorLogger, "getRoles failed", e);
 		}
 	}
-	
-	
-	@RequestMapping(value = {"/role_list/toggleRole" }, method = RequestMethod.POST)
-	public ModelAndView toggleRole(HttpServletRequest request, 
-			HttpServletResponse response) throws Exception {
-		User user = UserUtils.getUserSession(request);
-
 
+	@RequestMapping(value = { "/role_list/toggleRole" }, method = RequestMethod.POST)
+	public ModelAndView toggleRole(HttpServletRequest request, HttpServletResponse response) throws IOException {
+		User user = UserUtils.getUserSession(request);
 		try {
 			ObjectMapper mapper = new ObjectMapper();
 			mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
 			JsonNode root = mapper.readTree(request.getReader());
 			Role role = mapper.readValue(root.get("role").toString(), Role.class);
 
-			Role domainRole = service.getRole(user.getOrgUserId(),role.getId());
-			//role. toggle active ind
+			Role domainRole = service.getRole(user.getOrgUserId(), role.getId());
+			// role. toggle active ind
 			boolean active = domainRole.getActive();
 			domainRole.setActive(!active);
-			
-			service.saveRole(user.getOrgUserId(),domainRole);
+
+			service.saveRole(user.getOrgUserId(), domainRole);
 			logger.info(EELFLoggerDelegate.auditLogger, "Toggle active status for role " + domainRole.getId());
 
 			response.setCharacterEncoding("UTF-8");
@@ -133,38 +125,35 @@ public class RoleListController extends RestrictedBaseController {
 
 			PrintWriter out = response.getWriter();
 			String responseString = mapper.writeValueAsString(service.getAvailableRoles(user.getOrgUserId()));
-			JSONObject j = new JSONObject("{availableRoles: "+responseString+"}");
-			
+			JSONObject j = new JSONObject("{availableRoles: " + responseString + "}");
+
 			out.write(j.toString());
-			
+
 			return null;
 		} catch (Exception e) {
 			logger.error(EELFLoggerDelegate.errorLogger, "toggleRole failed", e);
 			response.setCharacterEncoding("UTF-8");
-			request.setCharacterEncoding("UTF-8");
 			PrintWriter out = response.getWriter();
 			out.write(e.getMessage());
 			return null;
 		}
 
 	}
-	
-	@RequestMapping(value = {"/role_list/removeRole" }, method = RequestMethod.POST)
-	public ModelAndView removeRole(HttpServletRequest request, 
-			HttpServletResponse response) throws Exception {
+
+	@RequestMapping(value = { "/role_list/removeRole" }, method = RequestMethod.POST)
+	public ModelAndView removeRole(HttpServletRequest request, HttpServletResponse response) throws IOException {
 		User user = UserUtils.getUserSession(request);
 
 		try {
-
 			ObjectMapper mapper = new ObjectMapper();
 			mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
 			JsonNode root = mapper.readTree(request.getReader());
 			Role role = mapper.readValue(root.get("role").toString(), Role.class);
 
-			Role domainRole = service.getRole(user.getOrgUserId(),role.getId());
-						
-			service.deleteDependcyRoleRecord(user.getOrgUserId(),role.getId());
-			service.deleteRole(user.getOrgUserId(),domainRole);
+			Role domainRole = service.getRole(user.getOrgUserId(), role.getId());
+
+			service.deleteDependcyRoleRecord(user.getOrgUserId(), role.getId());
+			service.deleteRole(user.getOrgUserId(), domainRole);
 			logger.info(EELFLoggerDelegate.auditLogger, "Remove role " + domainRole.getId());
 
 			response.setCharacterEncoding("UTF-8");
@@ -172,11 +161,11 @@ public class RoleListController extends RestrictedBaseController {
 			request.setCharacterEncoding("UTF-8");
 
 			PrintWriter out = response.getWriter();
-			
+
 			String responseString = mapper.writeValueAsString(service.getAvailableRoles(user.getOrgUserId()));
-			JSONObject j = new JSONObject("{availableRoles: "+responseString+"}");
+			JSONObject j = new JSONObject("{availableRoles: " + responseString + "}");
 			out.write(j.toString());
-			
+
 			return null;
 		} catch (Exception e) {
 			logger.error(EELFLoggerDelegate.errorLogger, "removeRole failed", e);
@@ -189,9 +178,12 @@ public class RoleListController extends RestrictedBaseController {
 
 	}
 
+	@Override
 	public String getViewName() {
 		return viewName;
 	}
+
+	@Override
 	public void setViewName(String viewName) {
 		this.viewName = viewName;
 	}
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/SDKLoginController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/SDKLoginController.java
index fe24f3c3..0cfc6cd8 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/SDKLoginController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/SDKLoginController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,6 +37,7 @@
  */
 package org.onap.portalapp.controller.core;
 
+import java.io.IOException;
 import java.util.HashMap;
 import java.util.Map;
 
@@ -68,19 +69,19 @@ public class SDKLoginController extends UnRestrictedBaseController {
 	private String viewName;
 
 	@RequestMapping(value = { "/login.htm" }, method = RequestMethod.GET)
-	public ModelAndView login(HttpServletRequest request) {
-		Map model = new HashMap();
+	public ModelAndView login() {
+		Map model = new HashMap<>();
 		return new ModelAndView("login", "model", model);
 	}
 
 	@RequestMapping(value = { "/login_external.htm" }, method = RequestMethod.GET)
-	public ModelAndView externalLogin(HttpServletRequest request) {
-		Map model = new HashMap();
+	public ModelAndView externalLogin() {
+		Map model = new HashMap<>();
 		return new ModelAndView("login_external", "model", model);
 	}
 
 	@RequestMapping(value = { "/login_external" }, method = RequestMethod.POST)
-	public ModelAndView doexternalLogin(HttpServletRequest request, HttpServletResponse response) throws Exception {
+	public ModelAndView doexternalLogin(HttpServletRequest request, HttpServletResponse response) throws IOException {
 		return loginStrategy.doExternalLogin(request, response);
 	}
 
@@ -98,10 +99,12 @@ public class SDKLoginController extends UnRestrictedBaseController {
 		PortalTimeoutHandler.sessionCreated(jSessionId, jSessionId, AppUtils.getSession(request));
 	}
 
+	@Override
 	public String getViewName() {
 		return viewName;
 	}
 
+	@Override
 	public void setViewName(String viewName) {
 		this.viewName = viewName;
 	}
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/SingleSignOnController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/SingleSignOnController.java
index 80fd67d9..17630643 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/SingleSignOnController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/SingleSignOnController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -81,6 +81,9 @@ public class SingleSignOnController extends UnRestrictedBaseController {
 	@Autowired
 	private LoginStrategy loginStrategy;
 
+	@Autowired
+	private RoleService roleService;
+
 	private String viewName;
 	private String welcomeView;
 
@@ -91,13 +94,10 @@ public class SingleSignOnController extends UnRestrictedBaseController {
 	public void setWelcomeView(String welcomeView) {
 		this.welcomeView = welcomeView;
 	}
-	
-	@Autowired
-	RoleService roleService;
 
 	/**
-	 * Handles requests directed to the single sign-on page by the session
-	 * timeout interceptor.
+	 * Handles requests directed to the single sign-on page by the session timeout
+	 * interceptor.
 	 * 
 	 * @param request
 	 * @return Redirect to an appropriate address
@@ -106,8 +106,8 @@ public class SingleSignOnController extends UnRestrictedBaseController {
 	@RequestMapping(value = { "/single_signon.htm" }, method = RequestMethod.GET)
 	public ModelAndView singleSignOnLogin(HttpServletRequest request) throws Exception {
 
-		Map model = new HashMap();
-		HashMap additionalParamsMap = new HashMap();
+		Map model = new HashMap<>();
+		HashMap additionalParamsMap = new HashMap<>();
 		LoginBean commandBean = new LoginBean();
 
 		// SessionTimeoutInterceptor sets these parameters
@@ -115,8 +115,7 @@ public class SingleSignOnController extends UnRestrictedBaseController {
 		String redirectToPortal = request.getParameter("redirectToPortal");
 
 		if (isLoginCookieExist(request) && redirectToPortal == null) {
-			HttpSession session = null;
-			session = AppUtils.getSession(request);
+			HttpSession session = AppUtils.getSession(request);
 			User user = UserUtils.getUserSession(request);
 			if (session == null || user == null) {
 
@@ -126,7 +125,7 @@ public class SingleSignOnController extends UnRestrictedBaseController {
 				commandBean = getLoginService().findUser(commandBean,
 						(String) request.getAttribute(MenuProperties.MENU_PROPERTIES_FILENAME_KEY),
 						additionalParamsMap);
-				List roleFunctionList=  roleService.getRoleFunctions(userId);
+				List roleFunctionList = roleService.getRoleFunctions(userId);
 				if (commandBean.getUser() == null) {
 					String loginErrorMessage = (commandBean.getLoginErrorMessage() != null)
 							? commandBean.getLoginErrorMessage()
@@ -165,19 +164,17 @@ public class SingleSignOnController extends UnRestrictedBaseController {
 
 		} else {
 			/*
-			 * Login cookie not found, or redirect-to-portal parameter was
-			 * found.
+			 * Login cookie not found, or redirect-to-portal parameter was found.
 			 * 
-			 * Redirect the user to the portal with a suitable return URL. The
-			 * forwardURL parameter that arrives as a parameter is a partial
-			 * (not absolute) request path for a page in the application. The
-			 * challenge here is to compute the correct absolute path for the
-			 * original request so the portal can redirect the user back to the
-			 * right place. If the application sits behind WebJunction, or if
-			 * separate FE-BE hosts are used, then the URL yielded by the
-			 * request has a host name that is not reachable by the user.
+			 * Redirect the user to the portal with a suitable return URL. The forwardURL
+			 * parameter that arrives as a parameter is a partial (not absolute) request
+			 * path for a page in the application. The challenge here is to compute the
+			 * correct absolute path for the original request so the portal can redirect the
+			 * user back to the right place. If the application sits behind WebJunction, or
+			 * if separate FE-BE hosts are used, then the URL yielded by the request has a
+			 * host name that is not reachable by the user.
 			 */
-			String returnToAppUrl = null;
+			String returnToAppUrl;
 			if (SystemProperties.containsProperty(SystemProperties.APP_BASE_URL)) {
 				// New feature as of 1610, release 3.3.3:
 				// application can publish a base URL in system.properties
@@ -191,7 +188,7 @@ public class SingleSignOnController extends UnRestrictedBaseController {
 				// This is the controller for the single_signon.htm page, so the
 				// replace
 				// should always find the specified token.
-				returnToAppUrl = ((HttpServletRequest) request).getRequestURL().toString().replace("single_signon.htm",
+				returnToAppUrl = request.getRequestURL().toString().replace("single_signon.htm",
 						forwardURL);
 				logger.debug(EELFLoggerDelegate.debugLogger, "singleSignOnLogin: computed redirectURL {}",
 						returnToAppUrl);
@@ -217,7 +214,7 @@ public class SingleSignOnController extends UnRestrictedBaseController {
 
 	public boolean isLoginCookieExist(HttpServletRequest request) {
 		Cookie ep = WebUtils.getCookie(request, LoginStrategy.EP_SERVICE);
-		return (ep != null);
+		return ep != null;
 	}
 
 	public String getPortalJSessionId(HttpServletRequest request) {
@@ -229,10 +226,12 @@ public class SingleSignOnController extends UnRestrictedBaseController {
 		return request.getSession().getId();
 	}
 
+	@Override
 	public String getViewName() {
 		return viewName;
 	}
 
+	@Override
 	public void setViewName(String viewName) {
 		this.viewName = viewName;
 	}
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/UsageListController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/UsageListController.java
index 13a59f12..df017288 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/UsageListController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/UsageListController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,9 +37,10 @@
  */
 package org.onap.portalapp.controller.core;
 
+import java.io.IOException;
 import java.io.PrintWriter;
-import java.util.ArrayList;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 
 import javax.servlet.http.HttpServletRequest;
@@ -67,7 +68,7 @@ public class UsageListController extends RestrictedBaseController {
 	@SuppressWarnings({ "unchecked", "rawtypes" })
 	@RequestMapping(value = { "/usage_list" }, method = RequestMethod.GET)
 	public ModelAndView usageList(HttpServletRequest request) {
-		Map model = new HashMap();
+		Map model = new HashMap<>();
 
 		HttpSession httpSession = request.getSession();
 		HashMap activeUsers = (HashMap) httpSession.getServletContext().getAttribute("activeUsers");
@@ -75,7 +76,7 @@ public class UsageListController extends RestrictedBaseController {
 			activeUsers.put(httpSession.getId(), httpSession);
 			httpSession.getServletContext().setAttribute("activeUsers", activeUsers);
 		}
-		ArrayList rows = UsageUtils.getActiveUsers(activeUsers);
+		List rows = UsageUtils.getActiveUsers(activeUsers);
 		JSONArray ja = new JSONArray();
 		try {
 			for (UserRowBean userRowBean : rows) {
@@ -112,7 +113,7 @@ public class UsageListController extends RestrictedBaseController {
 			activeUsers.put(httpSession.getId(), httpSession);
 			httpSession.getServletContext().setAttribute("activeUsers", activeUsers);
 		}
-		ArrayList rows = UsageUtils.getActiveUsers(activeUsers);
+		List rows = UsageUtils.getActiveUsers(activeUsers);
 		JSONArray ja = new JSONArray();
 		try {
 			for (UserRowBean userRowBean : rows) {
@@ -146,14 +147,14 @@ public class UsageListController extends RestrictedBaseController {
 
 	@SuppressWarnings("rawtypes")
 	@RequestMapping(value = { "/usage_list/removeSession" }, method = RequestMethod.GET)
-	public void removeSession(HttpServletRequest request, HttpServletResponse response) throws Exception {
+	public void removeSession(HttpServletRequest request, HttpServletResponse response) throws IOException {
 		HashMap activeUsers = (HashMap) request.getSession().getServletContext().getAttribute("activeUsers");
 		UserRowBean data = new UserRowBean();
 		data.setSessionId(request.getParameter("deleteSessionId"));
 		UsageUtils.getActiveUsersAfterDelete(activeUsers, data);
 
 		HttpSession httpSession = request.getSession();
-		ArrayList rows = UsageUtils.getActiveUsers(activeUsers);
+		List rows = UsageUtils.getActiveUsers(activeUsers);
 		JSONArray ja = new JSONArray();
 		try {
 			for (UserRowBean userRowBean : rows) {
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/UserProfileController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/UserProfileController.java
index 99493266..f32fdda5 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/UserProfileController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/UserProfileController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,12 +37,11 @@
  */
 package org.onap.portalapp.controller.core;
 
+import java.io.IOException;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
-import javax.servlet.http.HttpServletRequest;
-
 import org.onap.portalsdk.core.controller.RestrictedBaseController;
 import org.onap.portalsdk.core.domain.Profile;
 import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
@@ -70,8 +69,8 @@ public class UserProfileController extends RestrictedBaseController {
 	private ProfileService service;
 
 	@RequestMapping(value = { "/user_profile" }, method = RequestMethod.GET)
-	public ModelAndView userProfile(HttpServletRequest request) throws Exception {
-		Map model = new HashMap();
+	public ModelAndView userProfile() throws IOException {
+		Map model = new HashMap<>();
 		ObjectMapper mapper = new ObjectMapper();
 		List profileList = service.findAll();
 		try {
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/WelcomeController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/WelcomeController.java
index 77a9b20e..a063969a 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/WelcomeController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/WelcomeController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,8 +37,6 @@
  */
 package org.onap.portalapp.controller.core;
 
-import javax.servlet.http.HttpServletRequest;
-
 import org.onap.portalsdk.core.controller.RestrictedBaseController;
 import org.springframework.stereotype.Controller;
 import org.springframework.web.bind.annotation.RequestMapping;
@@ -54,7 +52,7 @@ import org.springframework.web.servlet.ModelAndView;
 @RequestMapping("/")
 public class WelcomeController extends RestrictedBaseController {
 	@RequestMapping(value = { "/welcome" }, method = RequestMethod.GET)
-	public ModelAndView welcome(HttpServletRequest request) {
+	public ModelAndView welcome() {
 		final String defaultViewName = null;
 		return new ModelAndView(defaultViewName);
 	}
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/AngularSinglePageController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/AngularSinglePageController.java
index 2caabf21..e038a044 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/AngularSinglePageController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/AngularSinglePageController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/BroadcastController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/BroadcastController.java
index 5182a398..316f35cd 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/BroadcastController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/BroadcastController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/BroadcastListController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/BroadcastListController.java
index d567c008..fa1bcbeb 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/BroadcastListController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/BroadcastListController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/CallflowController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/CallflowController.java
index 27a3003c..36528495 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/CallflowController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/CallflowController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/CamundaCockpitController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/CamundaCockpitController.java
index a1ab6a52..cc83041c 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/CamundaCockpitController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/CamundaCockpitController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/CollaborateListController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/CollaborateListController.java
index 3dad8312..ebf31e65 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/CollaborateListController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/CollaborateListController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/CollaborationController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/CollaborationController.java
index 4a358555..204bdf7e 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/CollaborationController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/CollaborationController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/DS2SampleController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/DS2SampleController.java
index 02547c35..f01c8a9e 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/DS2SampleController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/DS2SampleController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/ElasticSearchController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/ElasticSearchController.java
index 758d8ab3..a53887e2 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/ElasticSearchController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/ElasticSearchController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/ElementModelController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/ElementModelController.java
index a6afd2d6..34e4db7d 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/ElementModelController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/ElementModelController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/LeafletMapContoller.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/LeafletMapContoller.java
index a22be15e..5ccfd3af 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/LeafletMapContoller.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/LeafletMapContoller.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/NetMapController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/NetMapController.java
index 3b758207..d3277a71 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/NetMapController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/NetMapController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/PostDroolsController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/PostDroolsController.java
index aea008ab..41b783cf 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/PostDroolsController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/PostDroolsController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/ReportDashboardController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/ReportDashboardController.java
index 7245d027..3782751e 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/ReportDashboardController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/ReportDashboardController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/SamplePageController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/SamplePageController.java
index 41ac23b9..99a938d5 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/SamplePageController.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/SamplePageController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/model/Result.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/model/Result.java
index c59479bb..ea9dd951 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/model/Result.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/model/Result.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/scheduler/LogJob.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/scheduler/LogJob.java
index 3f560312..1a28eeae 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/scheduler/LogJob.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/scheduler/LogJob.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/scheduler/LogRegistry.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/scheduler/LogRegistry.java
index 1e0bdc2d..ad52c1c6 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/scheduler/LogRegistry.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/scheduler/LogRegistry.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/service/IAdminAuthExtension.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/service/IAdminAuthExtension.java
index fbdd8aa4..7ea8ac2d 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/service/IAdminAuthExtension.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/service/IAdminAuthExtension.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/service/OnBoardingApiServiceImpl.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/service/OnBoardingApiServiceImpl.java
index 3aa7de59..9c77441d 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/service/OnBoardingApiServiceImpl.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/service/OnBoardingApiServiceImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/util/CustomLoggingFilter.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/util/CustomLoggingFilter.java
index e47f7342..ccabb12c 100644
--- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/util/CustomLoggingFilter.java
+++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/util/CustomLoggingFilter.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/conf/ExternalAppConfig.java b/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/conf/ExternalAppConfig.java
index 2c46672f..6f3e8f28 100644
--- a/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/conf/ExternalAppConfig.java
+++ b/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/conf/ExternalAppConfig.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -87,6 +87,7 @@ public class ExternalAppConfig extends AppConfig implements Configurable {
 	/**
 	 * @see org.onap.portalsdk.core.conf.AppConfig#viewResolver()
 	 */
+	@Override
 	public ViewResolver viewResolver() {
 		return super.viewResolver();
 	}
@@ -96,6 +97,7 @@ public class ExternalAppConfig extends AppConfig implements Configurable {
 	 * 
 	 * @param registry
 	 */
+	@Override
 	public void addResourceHandlers(ResourceHandlerRegistry registry) {
 		super.addResourceHandlers(registry);
 	}
@@ -103,6 +105,7 @@ public class ExternalAppConfig extends AppConfig implements Configurable {
 	/**
 	 * @see org.onap.portalsdk.core.conf.AppConfig#dataAccessService()
 	 */
+	@Override
 	public DataAccessService dataAccessService() {
 		// Echo the JDBC URL to assist developers when starting the app.
 		System.out.println("ExternalAppConfig: " + SystemProperties.DB_CONNECTIONURL + " is "
@@ -116,8 +119,9 @@ public class ExternalAppConfig extends AppConfig implements Configurable {
 	 * 
 	 * @return List of String, size 1
 	 */
+	@Override
 	public List addTileDefinitions() {
-		List definitions = new ArrayList();
+		List definitions = new ArrayList<>();
 		definitions.add("/WEB-INF/defs/definitions.xml");
 		return definitions;
 	}
@@ -173,7 +177,6 @@ public class ExternalAppConfig extends AppConfig implements Configurable {
 
 	@Bean
 	public LoginStrategy loginStrategy() {
-
 		return new LoginStrategyImpl();
 	}
 }
diff --git a/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/conf/ExternalAppInitializer.java b/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/conf/ExternalAppInitializer.java
index 1665443e..c8fbc434 100644
--- a/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/conf/ExternalAppInitializer.java
+++ b/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/conf/ExternalAppInitializer.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/conf/HibernateMappingLocations.java b/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/conf/HibernateMappingLocations.java
index d336aa4f..0c91ff0a 100644
--- a/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/conf/HibernateMappingLocations.java
+++ b/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/conf/HibernateMappingLocations.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/lm/FusionLicenseManagerImpl.java b/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/lm/FusionLicenseManagerImpl.java
index 31c02a9a..66208e19 100644
--- a/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/lm/FusionLicenseManagerImpl.java
+++ b/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/lm/FusionLicenseManagerImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -55,22 +55,22 @@ public class FusionLicenseManagerImpl implements FusionLicenseManager {
 
 	@Override
 	public void initKeyStoreParam() {
-		
+		// a dummy stub for the interface
 	}
-	
+
 	@Override
 	public void initCipherParam() {
-		
+		// a dummy stub for the interface
 	}
 
-	@Override	
+	@Override
 	public void initLicenseParam() {
-		
+		// a dummy stub for the interface
 	}
 
 	@Override
 	public void doInitWork() {
-		
+		// a dummy stub for the interface
 	}
 
 	@Override
@@ -85,9 +85,9 @@ public class FusionLicenseManagerImpl implements FusionLicenseManager {
 
 	@Override
 	public void generateLicense(Map clientInfoMap, List ipAddressList) throws Exception {
-		
+		// a dummy stub for the interface
 	}
-	
+
 	@Override
 	public String nvl(String s) {
 		return null;
@@ -98,9 +98,9 @@ public class FusionLicenseManagerImpl implements FusionLicenseManager {
 		return null;
 	}
 
-	@Override	
+	@Override
 	public void setExpiredDate(Date expiredDate) {
-		
+		// a dummy stub for the interface
 	}
 
 }
diff --git a/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/lm/LicenseableClassImpl.java b/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/lm/LicenseableClassImpl.java
index 08aca3b8..074814dc 100644
--- a/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/lm/LicenseableClassImpl.java
+++ b/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/lm/LicenseableClassImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -45,36 +45,42 @@ import org.onap.portalsdk.core.lm.LicenseableClass;
 /*
  *  Please note that this class is not being used; its a dummy stub to have a qualifying bean for the interface.
  */
-
 public class LicenseableClassImpl implements LicenseableClass {
-		  
+
+	@Override
 	public String getApplicationName() {
 		return "";
 	}
 
+	@Override
 	public InputStream getPublicKeystoreAsInputStream() throws FileNotFoundException {
 	  return null;
 	}
 
+	@Override
 	public String getAlias() {
 		return "";
 	}
 
+	@Override
 	public String getKeyPasswd() {
 		return "";
 	}
 
+	@Override
 	public String getPublicKeystorePassword() {
 		return "";
 	}
 
+	@Override
 	public String getCipherParamPassword() {
 		return "";
 	}
 
+	@Override
 	@SuppressWarnings("rawtypes")
 	public Class getClassToLicense() {
 		return this.getClass();
 	}
-}
 
+}
diff --git a/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/login/LoginStrategyImpl.java b/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/login/LoginStrategyImpl.java
index 61f2cb4d..729cfd1f 100644
--- a/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/login/LoginStrategyImpl.java
+++ b/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/login/LoginStrategyImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -44,6 +44,7 @@ import javax.servlet.http.HttpServletResponse;
 
 import org.onap.portalsdk.core.auth.LoginStrategy;
 import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
+import org.onap.portalsdk.core.onboarding.exception.CipherUtilException;
 import org.onap.portalsdk.core.onboarding.exception.PortalAPIException;
 import org.onap.portalsdk.core.onboarding.util.CipherUtil;
 import org.onap.portalsdk.core.util.SystemProperties;
@@ -91,16 +92,16 @@ public class LoginStrategyImpl extends LoginStrategy {
 	 * @param request
 	 *            HttpServletRequest
 	 * @return User ID
-	 * @throws Exception
-	 *             On any failure
+	 * @throws CipherUtilException
+	 *             On any failure to decrypt
 	 */
-	private String getUserIdFromCookie(HttpServletRequest request) throws Exception {
+	private String getUserIdFromCookie(HttpServletRequest request) throws CipherUtilException {
 		String userId = "";
 		Cookie userIdCookie = getCookie(request, USER_ID);
 		if (userIdCookie != null) {
 			final String cookieValue = userIdCookie.getValue();
 			if (!SystemProperties.containsProperty(SystemProperties.Decryption_Key))
-				throw new Exception("Failed to find property " + SystemProperties.Decryption_Key);
+				throw new IllegalStateException("Failed to find property " + SystemProperties.Decryption_Key);
 			final String decryptionKey = SystemProperties.getProperty(SystemProperties.Decryption_Key);
 			userId = CipherUtil.decrypt(cookieValue, decryptionKey);
 			logger.debug(EELFLoggerDelegate.debugLogger, "getUserIdFromCookie: decrypted as {}", userId);
diff --git a/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/scheduler/Register.java b/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/scheduler/Register.java
index 56f498a2..d1a2c51a 100644
--- a/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/scheduler/Register.java
+++ b/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/scheduler/Register.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -40,7 +40,6 @@ package org.onap.portalapp.scheduler;
 import java.util.ArrayList;
 import java.util.List;
 
-import org.onap.portalapp.scheduler.LogRegistry;
 import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
 import org.onap.portalsdk.core.scheduler.Registerable;
 import org.onap.portalsdk.core.util.SystemProperties;
@@ -55,8 +54,8 @@ public class Register implements Registerable {
 
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(Register.class);
 
-	private List scheduleTriggers = new ArrayList();
-	Trigger trigger[] = new Trigger[1];
+	private List scheduleTriggers = new ArrayList<>();
+	Trigger[] trigger = new Trigger[1];
 
 	@Autowired
 	private LogRegistry logRegistry;
@@ -68,15 +67,12 @@ public class Register implements Registerable {
 
 	@Override
 	public void registerTriggers() {
-		// if the property value is not available; the cron will not be added
-		// and can be ignored. its safe to ignore the exceptions
-		try {
-			if (SystemProperties.getProperty(SystemProperties.LOG_CRON) != null)
-				getScheduleTriggers().add(logRegistry.getTrigger());
-		} catch (IllegalStateException ies) {
-			logger.info(EELFLoggerDelegate.debugLogger, ("Log Cron not available"));
+		// if the property value is not available; the cron will not be added.
+		if (SystemProperties.containsProperty(SystemProperties.LOG_CRON)) {
+			logger.debug(EELFLoggerDelegate.debugLogger,
+					"Adding log registry for cron property {}", SystemProperties.getProperty(SystemProperties.LOG_CRON));
+			getScheduleTriggers().add(logRegistry.getTrigger());
 		}
-
 	}
 
 	public List getScheduleTriggers() {
diff --git a/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/scheduler/RegistryAdapter.java b/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/scheduler/RegistryAdapter.java
index 158dfcbd..9f8f7279 100644
--- a/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/scheduler/RegistryAdapter.java
+++ b/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/scheduler/RegistryAdapter.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -59,20 +59,15 @@ public class RegistryAdapter {
 
 	private SchedulerFactoryBean schedulerBean;
 
-	Trigger trigger[] = new Trigger[1];
+	Trigger [] trigger = new Trigger[1];
 
 	public Trigger[] getTriggers() {
-
 		registry.registerTriggers();
-
-		List allTriggers = new ArrayList();
-
+		List allTriggers = new ArrayList<>();
 		List coreTriggers = addCoreTriggers();
 		final Trigger[] extTriggerArray = registry.getTriggers();
-
 		allTriggers.addAll(Arrays.asList(extTriggerArray));
 		allTriggers.addAll(coreTriggers);
-
 		return allTriggers.toArray(trigger);
 	}
 
@@ -83,8 +78,8 @@ public class RegistryAdapter {
 		return triggers;
 	}
 
-	public void setSchedulerBean(SchedulerFactoryBean _schedulerBean) {
-		schedulerBean = _schedulerBean;
+	public void setSchedulerBean(final SchedulerFactoryBean schedulerBean) {
+		this.schedulerBean = schedulerBean;
 	}
 
 	public SchedulerFactoryBean getSchedulerBean() {
diff --git a/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/service/AdminAuthExtension.java b/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/service/AdminAuthExtension.java
index b4a5fe59..076e6fd7 100644
--- a/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/service/AdminAuthExtension.java
+++ b/ecomp-sdk/epsdk-app-os/src/main/java/org/onap/portalapp/service/AdminAuthExtension.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -39,7 +39,6 @@ package org.onap.portalapp.service;
 
 import java.util.Set;
 
-import org.onap.portalapp.service.IAdminAuthExtension;
 import org.onap.portalsdk.core.domain.Role;
 import org.onap.portalsdk.core.domain.User;
 import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
@@ -56,16 +55,19 @@ public class AdminAuthExtension implements IAdminAuthExtension {
 
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(AdminAuthExtension.class);
 
+	@Override
 	public void saveUserExtension(User user) {
-		logger.debug("saveUserExtension");
+		logger.debug(EELFLoggerDelegate.debugLogger, "saveUserExtension");
 	}
 
+	@Override
 	public void editUserExtension(User user) {
-		logger.debug("editUserExtension");
+		logger.debug(EELFLoggerDelegate.debugLogger, "editUserExtension");
 	}
 
+	@Override
 	public void saveUserRoleExtension(Set roles, User user) {
-		logger.debug("saveUserRoleExtension");
+		logger.debug(EELFLoggerDelegate.debugLogger, "saveUserRoleExtension");
 	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/FusionObject.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/FusionObject.java
index d44fb7e6..17e20f54 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/FusionObject.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/FusionObject.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -47,16 +47,19 @@ package org.onap.portalsdk.core;
  * of each package in FUSION. This allows all top-level support classes to have
  * some commonality for easier maintenance.
  * 

- *
- * 

- * Copyright: Copyright (c) 2007
- * 

- *
- * @version 1.1
  */
 public interface FusionObject {
 
+	/**
+	 * Inner class provides static constants to any class that implements the
+	 * interface.
+	 */
 	public class Parameters {
+
+		private Parameters() {
+			// Static content only
+		}
+
 		// HashMap parameters passed to the Service and Dao tiers
 		public static final String PARAM_USERID = "userId";
 		public static final String PARAM_HTTP_REQUEST = "request";
@@ -67,46 +70,39 @@ public interface FusionObject {
 	}
 
 	/**
-	 * 

-	 * Title: FusionObject.Utilities
-	 * 

-	 *
-	 * 

-	 * Description: Inner class that has some utility functions available for
-	 * any class that implements it.
-	 * 

-	 *
-	 * 

-	 * Copyright: Copyright (c) 2007
-	 * 

-	 *
-	 * @version 1.1
+	 * Inner class provides static utility functions to any class that implements
+	 * the interface.
 	 */
 	public class Utilities {
+
+		private Utilities() {
+			// Static content only
+		}
+
 		/**
 		 * nvl - replaces a string value with an empty string if null.
 		 *
 		 * @param s
 		 *            String - the string value that needs to be checked
-		 * @return String - returns the original string value if not null.
-		 *         Otherwise an empty string ("") is returned.
+		 * @return String - returns the original string value if not null. Otherwise an
+		 *         empty string ("") is returned.
 		 */
 		public static String nvl(String s) {
-			return (s == null) ? "" : s;
+			return s == null ? "" : s;
 		}
 
 		/**
-		 * nvl - replaces a string value with a default value if null.
+		 * nvl - replaces a string value with a default value if null or empty.
 		 *
 		 * @param s
 		 *            String - the string value that needs to be checked
 		 * @param sDefault
 		 *            String - the default value
-		 * @return String - returns the original string value if not null.
+		 * @return String - returns the original string value if not null nor empty.
 		 *         Otherwise the default value is returned.
 		 */
 		public static String nvl(String s, String sDefault) {
-			return nvl(s).equals("") ? sDefault : s;
+			return "".equals(nvl(s)) ? sDefault : s;
 		}
 
 		/**
@@ -118,10 +114,7 @@ public interface FusionObject {
 		 *         sequence "null" (ignoring case); otherwise false.
 		 */
 		public static boolean isNull(String a) {
-			if ((a == null) || (a.length() == 0) || a.equalsIgnoreCase("null"))
-				return true;
-			else
-				return false;
+			return a == null || a.length() == 0 || a.equalsIgnoreCase("null");
 		}
 
 	}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/auth/LoginStrategy.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/auth/LoginStrategy.java
index 7fe4f632..baebac2f 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/auth/LoginStrategy.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/auth/LoginStrategy.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,6 +37,7 @@
  */
 package org.onap.portalsdk.core.auth;
 
+import java.io.IOException;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -71,65 +72,45 @@ public abstract class LoginStrategy {
 
 	@Autowired
 	private LoginService loginService;
-	
+
 	@Autowired
-	RoleService roleService;
+	private RoleService roleService;
 
 	public abstract ModelAndView doLogin(HttpServletRequest request, HttpServletResponse response) throws Exception;
 
 	public abstract String getUserId(HttpServletRequest request) throws PortalAPIException;
 
-	public ModelAndView doExternalLogin(HttpServletRequest request, HttpServletResponse response) throws Exception {
-		
+	public ModelAndView doExternalLogin(HttpServletRequest request, HttpServletResponse response) throws IOException {
+
 		invalidateExistingSession(request);
 
-		Map model = new HashMap();
 		LoginBean commandBean = new LoginBean();
 		String loginId = request.getParameter("loginId");
 		String password = request.getParameter("password");
 		commandBean.setLoginId(loginId);
 		commandBean.setLoginPwd(password);
-		HashMap additionalParamsMap = new HashMap();
-
-		// Get the client device type and pass it into LoginService for audit
-		// logging.
-		/**
-		 * ClientDeviceType clientDevice = (ClientDeviceType)request.getAttribut
-		 * (SystemProperties.getProperty(SystemProperties.CLIENT_DEVICE_ATTRIBUTE_NAME));
-		 * additionalParamsMap.put(Parameters.PARAM_CLIENT_DEVICE,
-		 * clientDevice);
-		 **/
 		commandBean = loginService.findUser(commandBean,
-				(String) request.getAttribute(MenuProperties.MENU_PROPERTIES_FILENAME_KEY), additionalParamsMap);
-		List roleFunctionList=  roleService.getRoleFunctions(loginId);
-
-		
+				(String) request.getAttribute(MenuProperties.MENU_PROPERTIES_FILENAME_KEY), new HashMap());
+		List roleFunctionList = roleService.getRoleFunctions(loginId);
 
 		if (commandBean.getUser() == null) {
 			String loginErrorMessage = (commandBean.getLoginErrorMessage() != null) ? commandBean.getLoginErrorMessage()
 					: "login.error.external.invalid";
+			Map model = new HashMap<>();
 			model.put("error", loginErrorMessage);
-
-			String[] errorCodes = new String[1];
-			errorCodes[0] = loginErrorMessage;
-
 			return new ModelAndView("login_external", "model", model);
-
 		} else {
 			// store the currently logged in user's information in the session
 			UserUtils.setUserSession(request, commandBean.getUser(), commandBean.getMenu(),
 					commandBean.getBusinessDirectMenu(),
 					SystemProperties.getProperty(SystemProperties.LOGIN_METHOD_BACKDOOR), roleFunctionList);
 			initateSessionMgtHandler(request);
-
 			// user has been authenticated, now take them to the welcome page
-			// return new ModelAndView("redirect:/profile_search");
 			return new ModelAndView("redirect:welcome.htm");
-
 		}
 	}
-	
-	protected void invalidateExistingSession(HttpServletRequest request){
+
+	protected void invalidateExistingSession(HttpServletRequest request) {
 		request.getSession().invalidate();
 	}
 
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/LoginBean.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/LoginBean.java
index 0f156bce..dc6806a8 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/LoginBean.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/LoginBean.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -44,163 +44,170 @@ import org.onap.portalsdk.core.domain.support.FusionCommand;
 
 public class LoginBean extends FusionCommand {
 
-    private String loginId;
-    private String loginPwd;
-    private String hrid;
-    private String userid;
-    private String siteAccess;
-    private String loginErrorMessage;
-
-    private User user;
-    @SuppressWarnings("rawtypes")
-    private Set  menu;
-    @SuppressWarnings("rawtypes")
-    private Set  businessDirectMenu;
-
-    /**
-     * getLoginId
-     *
-     * @return String
-     */
-    public String getLoginId() {
-        return loginId;
-    }
-
-    /**
-     * getLoginPwd
-     *
-     * @return String
-     */
-    public String getLoginPwd() {
-        return loginPwd;
-    }
-
-    /**
-     * getMenu
-     *
-     * @return Set
-     */
-    @SuppressWarnings("rawtypes")
-    public Set getMenu() {
-        return menu;
-    }
-
-    /**
-     * getUser
-     *
-     * @return User
-     */
-    public User getUser() {
-        return user;
-    }
-
-    /**
-     * getHrid
-     *
-     * @return String
-     */
-    public String getHrid() {
-        return hrid;
-    }
-
-    /**
-     * getSiteAccess
-     *
-     * @return String
-     */
-    public String getSiteAccess() {
-        return siteAccess;
-    }
-
-    /**
-     * getBusinessDirectMenu
-     *
-     * @return Set
-     */
-    @SuppressWarnings("rawtypes")
-    public Set getBusinessDirectMenu() {
-        return businessDirectMenu;
-    }
-
-    /**
-     * getLoginErrorMessage
-     *
-     * @return String
-     */
-    public String getLoginErrorMessage() {
-        return loginErrorMessage;
-    }
-
-    /**
-     * setLoginId
-     *
-     * @param loginId String
-     */
-    public void setLoginId(String loginId) {
-        this.loginId = loginId;
-    }
-
-    /**
-     * setLoginPwd
-     *
-     * @param loginPwd String
-     */
-    public void setLoginPwd(String loginPwd) {
-        this.loginPwd = loginPwd;
-    }
-
-    @SuppressWarnings("rawtypes")
-    public void setMenu(Set menu) {
-        this.menu = menu;
-    }
-
-    /**
-     * setUser
-     *
-     * @param user User
-     */
-    public void setUser(User user) {
-        this.user = user;
-    }
-
-    /**
-     * setHrid
-     *
-     * @param hrid String
-     */
-    public void setHrid(String hrid) {
-        this.hrid = hrid;
-    }
-
-    /**
-     * setSiteAccess
-     *
-     * @param siteAccess String
-     */
-    public void setSiteAccess(String siteAccess) {
-        this.siteAccess = siteAccess;
-    }
-
-    /**
-     * setBusinessDirectMenu
-     *
-     * @param businessDirectMenu Set
-     */
-    @SuppressWarnings("rawtypes")
-    public void setBusinessDirectMenu(Set businessDirectMenu) {
-        this.businessDirectMenu = businessDirectMenu;
-    }
-
-    /**
-     * setLoginErrorMessage
-     *
-     * @param loginErrorMessage String
-     */
-    public void setLoginErrorMessage(String loginErrorMessage) {
-        this.loginErrorMessage = loginErrorMessage;
-    }
-
-    public String getUserid() {
+	private String loginId;
+	private String loginPwd;
+	private String hrid;
+	private String userid;
+	private String siteAccess;
+	private String loginErrorMessage;
+
+	private User user;
+	@SuppressWarnings("rawtypes")
+	private Set menu;
+	@SuppressWarnings("rawtypes")
+	private Set businessDirectMenu;
+
+	/**
+	 * getLoginId
+	 *
+	 * @return String
+	 */
+	public String getLoginId() {
+		return loginId;
+	}
+
+	/**
+	 * getLoginPwd
+	 *
+	 * @return String
+	 */
+	public String getLoginPwd() {
+		return loginPwd;
+	}
+
+	/**
+	 * getMenu
+	 *
+	 * @return Set
+	 */
+	@SuppressWarnings("rawtypes")
+	public Set getMenu() {
+		return menu;
+	}
+
+	/**
+	 * getUser
+	 *
+	 * @return User
+	 */
+	public User getUser() {
+		return user;
+	}
+
+	/**
+	 * getHrid
+	 *
+	 * @return String
+	 */
+	public String getHrid() {
+		return hrid;
+	}
+
+	/**
+	 * getSiteAccess
+	 *
+	 * @return String
+	 */
+	public String getSiteAccess() {
+		return siteAccess;
+	}
+
+	/**
+	 * getBusinessDirectMenu
+	 *
+	 * @return Set
+	 */
+	@SuppressWarnings("rawtypes")
+	public Set getBusinessDirectMenu() {
+		return businessDirectMenu;
+	}
+
+	/**
+	 * getLoginErrorMessage
+	 *
+	 * @return String
+	 */
+	public String getLoginErrorMessage() {
+		return loginErrorMessage;
+	}
+
+	/**
+	 * setLoginId
+	 *
+	 * @param loginId
+	 *            String
+	 */
+	public void setLoginId(String loginId) {
+		this.loginId = loginId;
+	}
+
+	/**
+	 * setLoginPwd
+	 *
+	 * @param loginPwd
+	 *            String
+	 */
+	public void setLoginPwd(String loginPwd) {
+		this.loginPwd = loginPwd;
+	}
+
+	@SuppressWarnings("rawtypes")
+	public void setMenu(Set menu) {
+		this.menu = menu;
+	}
+
+	/**
+	 * setUser
+	 *
+	 * @param user
+	 *            User
+	 */
+	public void setUser(User user) {
+		this.user = user;
+	}
+
+	/**
+	 * setHrid
+	 *
+	 * @param hrid
+	 *            String
+	 */
+	public void setHrid(String hrid) {
+		this.hrid = hrid;
+	}
+
+	/**
+	 * setSiteAccess
+	 *
+	 * @param siteAccess
+	 *            String
+	 */
+	public void setSiteAccess(String siteAccess) {
+		this.siteAccess = siteAccess;
+	}
+
+	/**
+	 * setBusinessDirectMenu
+	 *
+	 * @param businessDirectMenu
+	 *            Set
+	 */
+	@SuppressWarnings("rawtypes")
+	public void setBusinessDirectMenu(Set businessDirectMenu) {
+		this.businessDirectMenu = businessDirectMenu;
+	}
+
+	/**
+	 * setLoginErrorMessage
+	 *
+	 * @param loginErrorMessage
+	 *            String
+	 */
+	public void setLoginErrorMessage(String loginErrorMessage) {
+		this.loginErrorMessage = loginErrorMessage;
+	}
+
+	public String getUserid() {
 		return userid;
 	}
 
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/PostDroolsBean.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/PostDroolsBean.java
index 89052495..005ecd5e 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/PostDroolsBean.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/PostDroolsBean.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -42,28 +42,32 @@ import com.fasterxml.jackson.databind.annotation.JsonSerialize;
 @JsonSerialize
 public class PostDroolsBean {
 
-    private String droolsFile;
-    private String className;
-    private String selectedRules;
-    
+	private String droolsFile;
+	private String className;
+	private String selectedRules;
+
 	public String getDroolsFile() {
 		return droolsFile;
 	}
+
 	public void setDroolsFile(String droolsFile) {
 		this.droolsFile = droolsFile;
 	}
+
 	public String getSelectedRules() {
 		return selectedRules;
 	}
+
 	public void setSelectedRules(String selectedRules) {
 		this.selectedRules = selectedRules;
 	}
+
 	public String getClassName() {
 		return className;
 	}
+
 	public void setClassName(String className) {
 		this.className = className;
-	} 
+	}
 
-   
-}	
+}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/PostSearchBean.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/PostSearchBean.java
index 3b32364e..b18cfc93 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/PostSearchBean.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/PostSearchBean.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -47,271 +47,347 @@ import com.fasterxml.jackson.databind.annotation.JsonSerialize;
 @JsonSerialize
 public class PostSearchBean extends SearchBase {
 
-    private User     user     = null;
-    private User     userOrig = null;
-    private String[] selected;
-    private String[] postHrid;
-    private String[] postOrgUserId;
-    private String[] postFirstName;
-    private String[] postLastName;
-    private String[] postOrgCode;
-    private String[] postPhone;
-    private String[] postEmail;
-    private String[] postAddress1;
-    private String[] postAddress2;
-    private String[] postCity;
-    private String[] postState;
-    private String[] postZipCode;
-    private String[] postLocationClli;
-    private String[] postBusinessCountryCode;
-    private String[] postBusinessCountryName;
-    private String[] postDepartment;
-    private String[] postDepartmentName;
-    private String[] postBusinessUnit;
-    private String[] postBusinessUnitName;
-    private String[] postJobTitle;
-    private String[] postOrgManagerUserId;
-    private String[] postCommandChain;
-    private String[] postCompanyCode;
-    private String[] postCompany;
-    private String[] postCostCenter;
-    private String[] postSiloStatus;
-    private String[] postFinancialLocCode;
-
-
-    @SuppressWarnings("rawtypes")
-    public PostSearchBean() {
-      this(null);
-    } // PostSearchBean
-
-    @SuppressWarnings("rawtypes")
-    public PostSearchBean(List items) {
-      super(items);
-
-      user     = new User();
-      userOrig = new User();
-
-      setSortBy1("");
-      setSortBy1Orig("");
-
-      //setSortByList(...);
-    }	// PostSearchBean
-
-
-    public String getFirstName()                      { return user.getFirstName(); }
-    public String getLastName()                       { return user.getLastName(); }
-    public String getHrid()                           { return user.getHrid(); }
-    public String getOrgUserId()                          { return user.getOrgUserId(); }
-    public String getOrgCode()                        { return user.getOrgCode(); }
-    public String getEmail()                          { return user.getEmail(); }
-    public String getOrgManagerUserId()                  { return user.getOrgManagerUserId(); }
-    
-    public String getFirstNameOrig()                  { return user.getFirstName(); }
-    public String getLastNameOrig()                   { return user.getLastName(); }
-    public String getHridOrig()                       { return user.getHrid(); }
-    public String getOrgUserIdOrig()                      { return user.getOrgUserId(); }
-    public String getOrgCodeOrig()                    { return user.getOrgCode(); }
-    public String getEmailOrig()                      { return user.getEmail(); }
-    public String getOrgManagerUserIdOrig()              { return user.getOrgManagerUserId(); }
-    
-    
-    public User getUser()                             { return user; }
-
-    public String[] getPostEmail() {
-        return postEmail;
-    }
-
-    public String[] getPostFirstName() {
-        return postFirstName;
-    }
-
-    public String[] getPostHrid() {
-        return postHrid;
-    }
-
-    public String[] getPostLastName() {
-        return postLastName;
-    }
-
-    public String[] getPostOrgCode() {
-        return postOrgCode;
-    }
-
-    public String[] getPostPhone() {
-        return postPhone;
-    }
-
-    public String[] getPostOrgUserId() {
-        return postOrgUserId;
-    }
-
-    public String[] getSelected() {
-        return selected;
-    }
-
-    public String[] getPostAddress1() {
-        return postAddress1;
-    }
-
-    public String[] getPostBusinessCountryCode() {
-        return postBusinessCountryCode;
-    }
-
-    public String[] getPostCity() {
-        return postCity;
-    }
-
-    public String[] getPostCommandChain() {
-        return postCommandChain;
-    }
-
-    public String[] getPostCompany() {
-        return postCompany;
-    }
-
-    public String[] getPostCompanyCode() {
-        return postCompanyCode;
-    }
-
-    public String[] getPostDepartment() {
-        return postDepartment;
-    }
-
-    public String[] getPostDepartmentName() {
-        return postDepartmentName;
-    }
-
-    public String[] getPostBusinessCountryName() {
-        return postBusinessCountryName;
-    }
-
-    public String[] getPostJobTitle() {
-        return postJobTitle;
-    }
-
-    public String[] getPostLocationClli() {
-        return postLocationClli;
-    }
-
-    public String[] getPostOrgManagerUserId() {
-        return postOrgManagerUserId;
-    }
-
-    public String[] getPostState() {
-        return postState;
-    }
-
-    public String[] getPostZipCode() {
-        return postZipCode;
-    }
-
-    public void setFirstName(String value)            { user.setFirstName(value); }
-    public void setLastName(String value)             { user.setLastName(value); }
-    public void setHrid(String value)                 { user.setHrid(value); }
-    public void setOrgUserId(String value)                { user.setOrgUserId(value); }
-    public void setOrgCode(String value)              { user.setOrgCode(value); }
-    public void setEmail(String value)                { user.setEmail(value); }
-    public void setOrgManagerUserId(String value)        { user.setOrgManagerUserId(value); }
-    
-    public void setFirstNameOrig(String value)        { userOrig.setFirstName(value); }
-    public void setLastNameOrig(String value)         { userOrig.setLastName(value); }
-    public void setHridOrig(String value)             { userOrig.setHrid(value); }
-    public void setOrgUserIdOrig(String value)            { userOrig.setOrgUserId(value); }
-    public void setOrgCodeOrig(String value)          { userOrig.setOrgCode(value); }
-    public void setEmailOrig(String value)            { userOrig.setEmail(value); }
-    public void setOrgManagerUserIdOrig(String value)    { userOrig.setOrgManagerUserId(value); }
-    
-    public void setUser(User value)                   { this.user = value; }
-
-    public void setPostEmail(String[] postEmail) {
-        this.postEmail = postEmail;
-    }
-
-    public void setPostFirstName(String[] postFirstName) {
-        this.postFirstName = postFirstName;
-    }
-
-    public void setPostHrid(String[] postHrid) {
-        this.postHrid = postHrid;
-    }
-
-    public void setPostLastName(String[] postLastName) {
-        this.postLastName = postLastName;
-    }
-
-    public void setPostOrgCode(String[] postOrgCode) {
-        this.postOrgCode = postOrgCode;
-    }
-
-    public void setPostPhone(String[] postPhone) {
-        this.postPhone = postPhone;
-    }
-
-    public void setPostOrgUserId(String[] postOrgUserId) {
-        this.postOrgUserId = postOrgUserId;
-    }
-
-    public void setSelected(String[] selected) {
-        this.selected = selected;
-    }
-
-    public void setPostAddress1(String[] postAddress1) {
-        this.postAddress1 = postAddress1;
-    }
-
-    public void setPostBusinessCountryCode(String[] postBusinessCountryCode) {
-        this.postBusinessCountryCode = postBusinessCountryCode;
-    }
-
-    public void setPostCity(String[] postCity) {
-        this.postCity = postCity;
-    }
-
-    public void setPostCommandChain(String[] postCommandChain) {
-        this.postCommandChain = postCommandChain;
-    }
-
-    public void setPostCompany(String[] postCompany) {
-        this.postCompany = postCompany;
-    }
-
-    public void setPostCompanyCode(String[] postCompanyCode) {
-        this.postCompanyCode = postCompanyCode;
-    }
-
-    public void setPostDepartment(String[] postDepartment) {
-        this.postDepartment = postDepartment;
-    }
-
-    public void setPostDepartmentName(String[] postDepartmentName) {
-        this.postDepartmentName = postDepartmentName;
-    }
-
-    public void setPostBusinessCountryName(String[] postBusinessCountryName) {
-        this.postBusinessCountryName = postBusinessCountryName;
-    }
-
-    public void setPostJobTitle(String[] postJobTitle) {
-        this.postJobTitle = postJobTitle;
-    }
-
-    public void setPostLocationClli(String[] postLocationClli) {
-        this.postLocationClli = postLocationClli;
-    }
-
-    public void setPostOrgManagerUserId(String[] postOrgManagerUserId) {
-        this.postOrgManagerUserId = postOrgManagerUserId;
-    }
-
-    public void setPostState(String[] postState) {
-        this.postState = postState;
-    }
-
-    public void setPostZipCode(String[] postZipCode) {
-        this.postZipCode = postZipCode;
-    }
-    
-    public String[] getPostAddress2() {
+	private User user = null;
+	private User userOrig = null;
+	private String[] selected;
+	private String[] postHrid;
+	private String[] postOrgUserId;
+	private String[] postFirstName;
+	private String[] postLastName;
+	private String[] postOrgCode;
+	private String[] postPhone;
+	private String[] postEmail;
+	private String[] postAddress1;
+	private String[] postAddress2;
+	private String[] postCity;
+	private String[] postState;
+	private String[] postZipCode;
+	private String[] postLocationClli;
+	private String[] postBusinessCountryCode;
+	private String[] postBusinessCountryName;
+	private String[] postDepartment;
+	private String[] postDepartmentName;
+	private String[] postBusinessUnit;
+	private String[] postBusinessUnitName;
+	private String[] postJobTitle;
+	private String[] postOrgManagerUserId;
+	private String[] postCommandChain;
+	private String[] postCompanyCode;
+	private String[] postCompany;
+	private String[] postCostCenter;
+	private String[] postSiloStatus;
+	private String[] postFinancialLocCode;
+
+	public PostSearchBean() {
+		this(null);
+	}
+
+	@SuppressWarnings("rawtypes")
+	public PostSearchBean(List items) {
+		super(items);
+		user = new User();
+		userOrig = new User();
+		setSortBy1("");
+		setSortBy1Orig("");
+	}
+
+	public String getFirstName() {
+		return user.getFirstName();
+	}
+
+	public String getLastName() {
+		return user.getLastName();
+	}
+
+	public String getHrid() {
+		return user.getHrid();
+	}
+
+	public String getOrgUserId() {
+		return user.getOrgUserId();
+	}
+
+	public String getOrgCode() {
+		return user.getOrgCode();
+	}
+
+	public String getEmail() {
+		return user.getEmail();
+	}
+
+	public String getOrgManagerUserId() {
+		return user.getOrgManagerUserId();
+	}
+
+	public String getFirstNameOrig() {
+		return user.getFirstName();
+	}
+
+	public String getLastNameOrig() {
+		return user.getLastName();
+	}
+
+	public String getHridOrig() {
+		return user.getHrid();
+	}
+
+	public String getOrgUserIdOrig() {
+		return user.getOrgUserId();
+	}
+
+	public String getOrgCodeOrig() {
+		return user.getOrgCode();
+	}
+
+	public String getEmailOrig() {
+		return user.getEmail();
+	}
+
+	public String getOrgManagerUserIdOrig() {
+		return user.getOrgManagerUserId();
+	}
+
+	public User getUser() {
+		return user;
+	}
+
+	public String[] getPostEmail() {
+		return postEmail;
+	}
+
+	public String[] getPostFirstName() {
+		return postFirstName;
+	}
+
+	public String[] getPostHrid() {
+		return postHrid;
+	}
+
+	public String[] getPostLastName() {
+		return postLastName;
+	}
+
+	public String[] getPostOrgCode() {
+		return postOrgCode;
+	}
+
+	public String[] getPostPhone() {
+		return postPhone;
+	}
+
+	public String[] getPostOrgUserId() {
+		return postOrgUserId;
+	}
+
+	public String[] getSelected() {
+		return selected;
+	}
+
+	public String[] getPostAddress1() {
+		return postAddress1;
+	}
+
+	public String[] getPostBusinessCountryCode() {
+		return postBusinessCountryCode;
+	}
+
+	public String[] getPostCity() {
+		return postCity;
+	}
+
+	public String[] getPostCommandChain() {
+		return postCommandChain;
+	}
+
+	public String[] getPostCompany() {
+		return postCompany;
+	}
+
+	public String[] getPostCompanyCode() {
+		return postCompanyCode;
+	}
+
+	public String[] getPostDepartment() {
+		return postDepartment;
+	}
+
+	public String[] getPostDepartmentName() {
+		return postDepartmentName;
+	}
+
+	public String[] getPostBusinessCountryName() {
+		return postBusinessCountryName;
+	}
+
+	public String[] getPostJobTitle() {
+		return postJobTitle;
+	}
+
+	public String[] getPostLocationClli() {
+		return postLocationClli;
+	}
+
+	public String[] getPostOrgManagerUserId() {
+		return postOrgManagerUserId;
+	}
+
+	public String[] getPostState() {
+		return postState;
+	}
+
+	public String[] getPostZipCode() {
+		return postZipCode;
+	}
+
+	public void setFirstName(String value) {
+		user.setFirstName(value);
+	}
+
+	public void setLastName(String value) {
+		user.setLastName(value);
+	}
+
+	public void setHrid(String value) {
+		user.setHrid(value);
+	}
+
+	public void setOrgUserId(String value) {
+		user.setOrgUserId(value);
+	}
+
+	public void setOrgCode(String value) {
+		user.setOrgCode(value);
+	}
+
+	public void setEmail(String value) {
+		user.setEmail(value);
+	}
+
+	public void setOrgManagerUserId(String value) {
+		user.setOrgManagerUserId(value);
+	}
+
+	public void setFirstNameOrig(String value) {
+		userOrig.setFirstName(value);
+	}
+
+	public void setLastNameOrig(String value) {
+		userOrig.setLastName(value);
+	}
+
+	public void setHridOrig(String value) {
+		userOrig.setHrid(value);
+	}
+
+	public void setOrgUserIdOrig(String value) {
+		userOrig.setOrgUserId(value);
+	}
+
+	public void setOrgCodeOrig(String value) {
+		userOrig.setOrgCode(value);
+	}
+
+	public void setEmailOrig(String value) {
+		userOrig.setEmail(value);
+	}
+
+	public void setOrgManagerUserIdOrig(String value) {
+		userOrig.setOrgManagerUserId(value);
+	}
+
+	public void setUser(User value) {
+		this.user = value;
+	}
+
+	public void setPostEmail(String[] postEmail) {
+		this.postEmail = postEmail;
+	}
+
+	public void setPostFirstName(String[] postFirstName) {
+		this.postFirstName = postFirstName;
+	}
+
+	public void setPostHrid(String[] postHrid) {
+		this.postHrid = postHrid;
+	}
+
+	public void setPostLastName(String[] postLastName) {
+		this.postLastName = postLastName;
+	}
+
+	public void setPostOrgCode(String[] postOrgCode) {
+		this.postOrgCode = postOrgCode;
+	}
+
+	public void setPostPhone(String[] postPhone) {
+		this.postPhone = postPhone;
+	}
+
+	public void setPostOrgUserId(String[] postOrgUserId) {
+		this.postOrgUserId = postOrgUserId;
+	}
+
+	public void setSelected(String[] selected) {
+		this.selected = selected;
+	}
+
+	public void setPostAddress1(String[] postAddress1) {
+		this.postAddress1 = postAddress1;
+	}
+
+	public void setPostBusinessCountryCode(String[] postBusinessCountryCode) {
+		this.postBusinessCountryCode = postBusinessCountryCode;
+	}
+
+	public void setPostCity(String[] postCity) {
+		this.postCity = postCity;
+	}
+
+	public void setPostCommandChain(String[] postCommandChain) {
+		this.postCommandChain = postCommandChain;
+	}
+
+	public void setPostCompany(String[] postCompany) {
+		this.postCompany = postCompany;
+	}
+
+	public void setPostCompanyCode(String[] postCompanyCode) {
+		this.postCompanyCode = postCompanyCode;
+	}
+
+	public void setPostDepartment(String[] postDepartment) {
+		this.postDepartment = postDepartment;
+	}
+
+	public void setPostDepartmentName(String[] postDepartmentName) {
+		this.postDepartmentName = postDepartmentName;
+	}
+
+	public void setPostBusinessCountryName(String[] postBusinessCountryName) {
+		this.postBusinessCountryName = postBusinessCountryName;
+	}
+
+	public void setPostJobTitle(String[] postJobTitle) {
+		this.postJobTitle = postJobTitle;
+	}
+
+	public void setPostLocationClli(String[] postLocationClli) {
+		this.postLocationClli = postLocationClli;
+	}
+
+	public void setPostOrgManagerUserId(String[] postOrgManagerUserId) {
+		this.postOrgManagerUserId = postOrgManagerUserId;
+	}
+
+	public void setPostState(String[] postState) {
+		this.postState = postState;
+	}
+
+	public void setPostZipCode(String[] postZipCode) {
+		this.postZipCode = postZipCode;
+	}
+
+	public String[] getPostAddress2() {
 		return postAddress2;
 	}
 
@@ -367,27 +443,25 @@ public class PostSearchBean extends SearchBase {
 		this.postFinancialLocCode = postFinancialLocCode;
 	}
 
+	@Override
 	public void resetSearch() {
-          super.resetSearch();
-          setUser(new User());
-	} // resetSearch
-
+		super.resetSearch();
+		setUser(new User());
+	}
 
+	@Override
 	public boolean isCriteriaUpdated() {
-          if(user==null&&userOrig==null)
-            return false;
-          else if(user==null||userOrig==null)
-            return true;
-          else
-            return (! (
-                Utilities.nvl(user.getFirstName()).equals(Utilities.nvl(userOrig.getFirstName()))&&
-                Utilities.nvl(user.getLastName()).equals(Utilities.nvl(userOrig.getLastName()))&&
-                //Utilities.nvl(user.getHrid()).equals(Utilities.nvl(userOrig.getHrid()))&&
-                Utilities.nvl(user.getOrgUserId()).equals(Utilities.nvl(userOrig.getOrgUserId()))&&
-                Utilities.nvl(user.getOrgCode()).equals(Utilities.nvl(userOrig.getOrgCode()))&&
-                Utilities.nvl(user.getEmail()).equals(Utilities.nvl(userOrig.getEmail()))&&
-                Utilities.nvl(user.getOrgManagerUserId()).equals(Utilities.nvl(userOrig.getOrgManagerUserId()))&&
-                true));
-       } // isCriteriaUpdated
-
-}	// PostSearchBean
+		if (user == null && userOrig == null)
+			return false;
+		else if (user == null || userOrig == null)
+			return true;
+		else
+			return !(Utilities.nvl(user.getFirstName()).equals(Utilities.nvl(userOrig.getFirstName()))
+					&& Utilities.nvl(user.getLastName()).equals(Utilities.nvl(userOrig.getLastName()))
+					&& Utilities.nvl(user.getOrgUserId()).equals(Utilities.nvl(userOrig.getOrgUserId()))
+					&& Utilities.nvl(user.getOrgCode()).equals(Utilities.nvl(userOrig.getOrgCode()))
+					&& Utilities.nvl(user.getEmail()).equals(Utilities.nvl(userOrig.getEmail()))
+					&& Utilities.nvl(user.getOrgManagerUserId()).equals(Utilities.nvl(userOrig.getOrgManagerUserId())));
+	}
+
+}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/UserRowBean.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/UserRowBean.java
index 49854e6b..8c768102 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/UserRowBean.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/UserRowBean.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -41,63 +41,50 @@ import org.onap.portalsdk.core.domain.User;
 
 public class UserRowBean extends User {
 
-	/**
-	 * 
-	 */
 	private static final long serialVersionUID = -2724597119083972190L;
-    private String  sessionId;
-    private String  lastAccess;
-    private String  remaining;
-    private String 	loginTime;
-    private String 	LastLoginTime;
-
-    
-    public String getLastAccess(){
-        return this.lastAccess;
-    }
-
-    
-    public void setLastAccess(String lastAccess){
-        this.lastAccess = lastAccess;
-    }
-
+	private String sessionId;
+	private String lastAccess;
+	private String remaining;
+	private String loginTime;
+	private String lastLoginTime;
+
+	public String getLastAccess() {
+		return this.lastAccess;
+	}
 
-    public String getRemaining(){
-        return this.remaining;
-    }
+	public void setLastAccess(final String lastAccess) {
+		this.lastAccess = lastAccess;
+	}
 
-    
-    public void setRemaining(String remaining){
-        this.remaining = remaining;
-    }
+	public String getRemaining() {
+		return this.remaining;
+	}
 
+	public void setRemaining(final String remaining) {
+		this.remaining = remaining;
+	}
 
 	public String getSessionId() {
 		return sessionId;
 	}
 
-
-	public void setSessionId(String sessionId) {
+	public void setSessionId(final String sessionId) {
 		this.sessionId = sessionId;
 	}
 
-
 	public String getLoginTime() {
 		return loginTime;
 	}
 
-
-	public void setLoginTime(String loginTime) {
+	public void setLoginTime(final String loginTime) {
 		this.loginTime = loginTime;
 	}
 
-
 	public String getLastLoginTime() {
-		return LastLoginTime;
+		return lastLoginTime;
 	}
 
-
-	public void setLastLoginTime(String lastLoginTime) {
-		LastLoginTime = lastLoginTime;
+	public void setLastLoginTime(final String lastLoginTime) {
+		this.lastLoginTime = lastLoginTime;
 	}
 }
\ No newline at end of file
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/support/SearchBase.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/support/SearchBase.java
index c053d95b..dcd14b91 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/support/SearchBase.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/support/SearchBase.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,252 +37,240 @@
  */
 package org.onap.portalsdk.core.command.support;
 
-import java.util.*;
+import java.util.List;
 
 import org.onap.portalsdk.core.domain.support.FusionCommand;
 
 public abstract class SearchBase extends FusionCommand {
 
-    public static String SORT_BY_MODIFIER_DESC = "D";
-    public static String SORT_BY_MODIFIER_ASC  = "A";
-    public static String SORT_BY_MODIFIER_DESC_IMAGE_NAME = "sort_desc.gif";
-    public static String SORT_BY_MODIFIER_ASC_IMAGE_NAME  = "sort_asc.gif";
+	public static final String SORT_BY_MODIFIER_DESC = "D";
+	public static final String SORT_BY_MODIFIER_ASC = "A";
+	public static final String SORT_BY_MODIFIER_DESC_IMAGE_NAME = "sort_desc.gif";
+	public static final String SORT_BY_MODIFIER_ASC_IMAGE_NAME = "sort_asc.gif";
 
+	private String sortBy1 = null;
+	private String sortBy2 = null;
+	private String sortBy3 = null;
 
-    private String sortBy1 = null;
-    private String sortBy2 = null;
-    private String sortBy3 = null;
+	private String sortBy1Orig = null;
+	private String sortBy2Orig = null;
+	private String sortBy3Orig = null;
 
-    private String sortBy1Orig = null;
-    private String sortBy2Orig = null;
-    private String sortBy3Orig = null;
+	private String sortByModifier1 = null;
+	private String sortByModifier2 = null;
+	private String sortByModifier3 = null;
 
-    private String sortByModifier1 = null;
-    private String sortByModifier2 = null;
-    private String sortByModifier3 = null;
+	private String sortByModifier1Orig = null;
+	private String sortByModifier2Orig = null;
+	private String sortByModifier3Orig = null;
 
-    private String sortByModifier1Orig = null;
-    private String sortByModifier2Orig = null;
-    private String sortByModifier3Orig = null;
+	private String accessType = "WRITE";
 
-    private String accessType = "WRITE"; //null;
+	private String submitAction = "";
+	private String masterId = "";
+	private String detailId = "";
 
-    private String submitAction = "";
-    private String masterId = "";
-    private String detailId = "";
+	private String showResult = "Y";
 
-    private String showResult = "Y";
+	private SearchResult searchResult = null;
 
-    private SearchResult searchResult = null;
-    private boolean sortingUpdated;
+	@SuppressWarnings("rawtypes")
+	public SearchBase(List items) {
+		searchResult = (items == null) ? (new SearchResult()) : (new SearchResult(items));
+	} // SearchBase
 
-    @SuppressWarnings("rawtypes")
-    public SearchBase(List items) {
-        searchResult = (items == null) ? (new SearchResult()) : (new SearchResult(items));
-    } // SearchBase
+	public String getSortBy1() {
+		return sortBy1;
+	}
 
+	public String getSortBy2() {
+		return sortBy2;
+	}
 
-    public String getSortBy1() {
-        return sortBy1;
-    }
+	public String getSortBy3() {
+		return sortBy3;
+	}
 
-    public String getSortBy2() {
-        return sortBy2;
-    }
+	public String getSortBy1Orig() {
+		return sortBy1;
+	}
 
-    public String getSortBy3() {
-        return sortBy3;
-    }
+	public String getSortBy2Orig() {
+		return sortBy2;
+	}
 
-    public String getSortBy1Orig() {
-        return sortBy1;
-    }
+	public String getSortBy3Orig() {
+		return sortBy3;
+	}
 
-    public String getSortBy2Orig() {
-        return sortBy2;
-    }
+	public String getAccessType() {
+		return accessType;
+	}
 
-    public String getSortBy3Orig() {
-        return sortBy3;
-    }
+	public String getSubmitAction() {
+		return submitAction;
+	}
 
-    public String getAccessType() {
-        return accessType;
-    }
+	public String getMasterId() {
+		return masterId;
+	}
 
-    public String getSubmitAction() {
-        return submitAction;
-    }
+	public String getDetailId() {
+		return detailId;
+	}
 
-    public String getMasterId() {
-        return masterId;
-    }
+	public String getShowResult() {
+		return showResult;
+	}
 
-    public String getDetailId() {
-        return detailId;
-    }
+	public SearchResult getSearchResult() {
+		return searchResult;
+	}
 
-    public String getShowResult() {
-        return showResult;
-    }
+	public String getSortByModifier1() {
+		return sortByModifier1;
+	}
 
-    //public ArrayList getSortByList()      { return sortByList; }
+	public String getSortByModifier1Orig() {
+		return sortByModifier1;
+	}
 
-    public SearchResult getSearchResult() {
-        return searchResult;
-    }
+	public String getSortByModifier2() {
+		return sortByModifier2;
+	}
 
-    public String getSortByModifier1() {
-        return sortByModifier1;
-    }
+	public String getSortByModifier2Orig() {
+		return sortByModifier2;
+	}
 
-    public String getSortByModifier1Orig() {
-        return sortByModifier1;
-    }
+	public String getSortByModifier3() {
+		return sortByModifier3;
+	}
 
-    public String getSortByModifier2() {
-        return sortByModifier2;
-    }
+	public String getSortByModifier3Orig() {
+		return sortByModifier3;
+	}
 
-    public String getSortByModifier2Orig() {
-        return sortByModifier2;
-    }
+	public int getPageNo() {
+		return (isCriteriaUpdated() || isSortingUpdated()) ? 0 : getSearchResult().getPageNo();
+	}
 
-    public String getSortByModifier3() {
-        return sortByModifier3;
-    }
+	public int getPageSize() {
+		return getSearchResult().getPageSize();
+	}
 
-    public String getSortByModifier3Orig() {
-        return sortByModifier3;
-    }
+	public int getDataSize() {
+		return getSearchResult().getDataSize();
+	}
 
-    public int getPageNo() {
-        return (isCriteriaUpdated() || isSortingUpdated()) ? 0 : getSearchResult().getPageNo();
-    }
-
-    public int getPageSize() {
-        return getSearchResult().getPageSize();
-    }
-
-    public int getDataSize() {
-        return getSearchResult().getDataSize();
-    }
-
-    public int getNewDataSize() {
-        return isCriteriaUpdated() ? -1 : getDataSize();
-    }
-
-
-    public void setSortBy1(String sortBy1) {
-        this.sortBy1 = sortBy1;
-    }
-
-    public void setSortBy2(String sortBy2) {
-        this.sortBy2 = sortBy2;
-    }
-
-    public void setSortBy3(String sortBy3) {
-        this.sortBy3 = sortBy3;
-    }
-
-    public void setSortBy1Orig(String sortBy1Orig) {
-        this.sortBy1Orig = sortBy1Orig;
-    }
-
-    public void setSortBy2Orig(String sortBy2Orig) {
-        this.sortBy2Orig = sortBy2Orig;
-    }
-
-    public void setSortBy3Orig(String sortBy3Orig) {
-        this.sortBy3Orig = sortBy3Orig;
-    }
-
-    public void setAccessType(String accessType) {
-        this.accessType = accessType;
-    }
-
-    public void setSubmitAction(String submitAction) {
-        this.submitAction = submitAction;
-    }
-
-    public void setMasterId(String masterId) {
-        this.masterId = masterId;
-    }
-
-    public void setDetailId(String detailId) {
-        this.detailId = detailId;
-    }
-
-    public void setShowResult(String showResult) {
-        this.showResult = showResult;
-    }
-
-    public void setSearchResult(SearchResult searchResult) {
-        this.searchResult = searchResult;
-    }
-
-    public void setSortByModifier1(String sortByModifier1) {
-        this.sortByModifier1 = sortByModifier1;
-    }
-
-    public void setSortByModifier1Orig(String sortByModifier1Orig) {
-        this.sortByModifier1Orig = sortByModifier1Orig;
-    }
-
-    public void setSortByModifier2(String sortByModifier2) {
-        this.sortByModifier2 = sortByModifier2;
-    }
-
-    public void setSortByModifier2Orig(String sortByModifier2Orig) {
-        this.sortByModifier2Orig = sortByModifier2Orig;
-    }
-
-    public void setSortByModifier3(String sortByModifier3) {
-        this.sortByModifier3 = sortByModifier3;
-    }
-
-    public void setSortByModifier3Orig(String sortByModifier3Orig) {
-        this.sortByModifier3Orig = sortByModifier3Orig;
-    }
-
-    public void setSortingUpdated(boolean sortingUpdated) {
-        this.sortingUpdated = sortingUpdated;
-    }
-
-    public void setPageNo(int pageNo) {
-        getSearchResult().setPageNo(pageNo);
-    }
-
-    public void setPageSize(int pageSize) {
-        getSearchResult().setPageSize(pageSize);
-    }
-
-    public void setDataSize(int dataSize) {
-        getSearchResult().setDataSize(dataSize);
-    }
-
-
-    public void resetSearch() {
-        setSortBy1(null);
-        setSortBy2(null);
-        setSortBy3(null);
-        setSortByModifier1(SearchBase.SORT_BY_MODIFIER_ASC);
-        setSortByModifier2(SearchBase.SORT_BY_MODIFIER_ASC);
-        setSortByModifier3(SearchBase.SORT_BY_MODIFIER_ASC);
-        setPageNo(0);
-        setDataSize( -1);
-    } // resetSearch
-
-
-    public abstract boolean isCriteriaUpdated();
-
-    public boolean isSortingUpdated() {
-        return (!(Utilities.nvl(sortBy1).equals(Utilities.nvl(sortBy1Orig)) &&
-                  Utilities.nvl(sortBy2).equals(Utilities.nvl(sortBy2Orig)) &&
-                  Utilities.nvl(sortBy3).equals(Utilities.nvl(sortBy3Orig)) &&
-                  Utilities.nvl(sortByModifier1).equals(Utilities.nvl(sortByModifier1Orig)) &&
-                  Utilities.nvl(sortByModifier2).equals(Utilities.nvl(sortByModifier2Orig)) &&
-                  Utilities.nvl(sortByModifier3).equals(Utilities.nvl(sortByModifier3Orig))));
-    } // isSortingUpdated
-
-} // SearchBase
+	public int getNewDataSize() {
+		return isCriteriaUpdated() ? -1 : getDataSize();
+	}
+
+	public void setSortBy1(String sortBy1) {
+		this.sortBy1 = sortBy1;
+	}
+
+	public void setSortBy2(String sortBy2) {
+		this.sortBy2 = sortBy2;
+	}
+
+	public void setSortBy3(String sortBy3) {
+		this.sortBy3 = sortBy3;
+	}
+
+	public void setSortBy1Orig(String sortBy1Orig) {
+		this.sortBy1Orig = sortBy1Orig;
+	}
+
+	public void setSortBy2Orig(String sortBy2Orig) {
+		this.sortBy2Orig = sortBy2Orig;
+	}
+
+	public void setSortBy3Orig(String sortBy3Orig) {
+		this.sortBy3Orig = sortBy3Orig;
+	}
+
+	public void setAccessType(String accessType) {
+		this.accessType = accessType;
+	}
+
+	public void setSubmitAction(String submitAction) {
+		this.submitAction = submitAction;
+	}
+
+	public void setMasterId(String masterId) {
+		this.masterId = masterId;
+	}
+
+	public void setDetailId(String detailId) {
+		this.detailId = detailId;
+	}
+
+	public void setShowResult(String showResult) {
+		this.showResult = showResult;
+	}
+
+	public void setSearchResult(SearchResult searchResult) {
+		this.searchResult = searchResult;
+	}
+
+	public void setSortByModifier1(String sortByModifier1) {
+		this.sortByModifier1 = sortByModifier1;
+	}
+
+	public void setSortByModifier1Orig(String sortByModifier1Orig) {
+		this.sortByModifier1Orig = sortByModifier1Orig;
+	}
+
+	public void setSortByModifier2(String sortByModifier2) {
+		this.sortByModifier2 = sortByModifier2;
+	}
+
+	public void setSortByModifier2Orig(String sortByModifier2Orig) {
+		this.sortByModifier2Orig = sortByModifier2Orig;
+	}
+
+	public void setSortByModifier3(String sortByModifier3) {
+		this.sortByModifier3 = sortByModifier3;
+	}
+
+	public void setSortByModifier3Orig(String sortByModifier3Orig) {
+		this.sortByModifier3Orig = sortByModifier3Orig;
+	}
+
+	public void setPageNo(int pageNo) {
+		getSearchResult().setPageNo(pageNo);
+	}
+
+	public void setPageSize(int pageSize) {
+		getSearchResult().setPageSize(pageSize);
+	}
+
+	public void setDataSize(int dataSize) {
+		getSearchResult().setDataSize(dataSize);
+	}
+
+	public void resetSearch() {
+		setSortBy1(null);
+		setSortBy2(null);
+		setSortBy3(null);
+		setSortByModifier1(SearchBase.SORT_BY_MODIFIER_ASC);
+		setSortByModifier2(SearchBase.SORT_BY_MODIFIER_ASC);
+		setSortByModifier3(SearchBase.SORT_BY_MODIFIER_ASC);
+		setPageNo(0);
+		setDataSize(-1);
+	}
+
+	public abstract boolean isCriteriaUpdated();
+
+	public boolean isSortingUpdated() {
+		return !(Utilities.nvl(sortBy1).equals(Utilities.nvl(sortBy1Orig))
+				&& Utilities.nvl(sortBy2).equals(Utilities.nvl(sortBy2Orig))
+				&& Utilities.nvl(sortBy3).equals(Utilities.nvl(sortBy3Orig))
+				&& Utilities.nvl(sortByModifier1).equals(Utilities.nvl(sortByModifier1Orig))
+				&& Utilities.nvl(sortByModifier2).equals(Utilities.nvl(sortByModifier2Orig))
+				&& Utilities.nvl(sortByModifier3).equals(Utilities.nvl(sortByModifier3Orig)));
+	}
+
+}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/support/SearchResult.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/support/SearchResult.java
index d1c1f315..35985c9f 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/support/SearchResult.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/command/support/SearchResult.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,49 +37,62 @@
  */
 package org.onap.portalsdk.core.command.support;
 
-import java.util.*;
+import java.util.ArrayList;
+import java.util.List;
 
 @SuppressWarnings("rawtypes")
 public class SearchResult extends ArrayList implements java.io.Serializable {
-	/**
-	 * 
-	 */
+
 	private static final long serialVersionUID = -451947878984459011L;
-	private int pageNo   = 0;
+	private int pageNo = 0;
 	private int pageSize = 50;
 	private int dataSize = -1;
 
-	private String accessType   = null;
-
-	//private boolean empty = true;	// Overrides collections [isEmpty] with searchResult present/not present logic
-
+	private String accessType = null;
 
-	public SearchResult() {}
+	public SearchResult() {
+		super();
+	}
 
 	@SuppressWarnings("unchecked")
 	public SearchResult(List items) {
 		super(items);
-	}	// SearchResult
+	}
+
+	public int getPageNo() {
+		return pageNo;
+	}
+
+	public int getPageSize() {
+		return pageSize;
+	}
 
-	/*public SearchResult(boolean empty) {
-		this();
-		this.empty = empty;
-	}	// SearchResult*/
+	public int getDataSize() {
+		return dataSize;
+	}
 
+	public int getSize() {
+		return size();
+	} // for Struts bean property access
 
-	public int getPageNo()   { return pageNo; }
-	public int getPageSize() { return pageSize; }
-	public int getDataSize() { return dataSize; }
+	public String getAccessType() {
+		return accessType;
+	}
 
-	public int     getSize() { return size(); }	// for Struts bean property access
-	//public boolean isEmpty() { return empty; }
+	public void setPageNo(int pageNo) {
+		this.pageNo = pageNo;
+	}
 
-	public String getAccessType() { return accessType; }
+	public void setPageSize(int pageSize) {
+		this.dataSize = pageSize;
+	}
 
-	public void setPageNo(int pageNo)     { this.pageNo=pageNo; }
-	public void setPageSize(int pageSize) { this.dataSize=pageSize; }
-	public void setDataSize(int dataSize) { this.dataSize=dataSize; }
+	public void setDataSize(int dataSize) {
+		this.dataSize = dataSize;
+	}
 
-	public void setAccessType(String accessType) { this.accessType = accessType; }
+	public void setAccessType(String accessType) {
+		this.accessType = accessType;
+	}
 
-}	// SearchResult
+}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/conf/AppConfig.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/conf/AppConfig.java
index 26624359..60888b6d 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/conf/AppConfig.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/conf/AppConfig.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -51,17 +51,12 @@ import org.onap.portalsdk.core.menu.MenuBuilder;
 import org.onap.portalsdk.core.onboarding.util.CipherUtil;
 import org.onap.portalsdk.core.service.DataAccessService;
 import org.onap.portalsdk.core.service.DataAccessServiceImpl;
-import org.onap.portalsdk.core.service.LocalAccessCondition;
-import org.onap.portalsdk.core.service.RestApiRequestBuilder;
 import org.onap.portalsdk.core.util.SystemProperties;
 import org.onap.portalsdk.core.web.support.AppUtils;
 import org.onap.portalsdk.core.web.support.UserUtils;
-import org.springframework.beans.BeansException;
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.ApplicationContext;
 import org.springframework.context.ApplicationContextAware;
 import org.springframework.context.annotation.Bean;
-import org.springframework.context.annotation.Conditional;
 import org.springframework.web.servlet.ViewResolver;
 import org.springframework.web.servlet.config.annotation.InterceptorRegistry;
 import org.springframework.web.servlet.config.annotation.ResourceHandlerRegistry;
@@ -83,7 +78,9 @@ public class AppConfig extends WebMvcConfigurerAdapter implements Configurable,
 
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(AppConfig.class);
 
-	private final List tileDefinitions = new ArrayList();
+	private final List tileDefinitions = new ArrayList<>();
+	private String[] excludeUrlPathsForSessionTimeout = {};
+
 	protected ApplicationContext appApplicationContext = null;
 
 	public AppConfig() {
@@ -94,12 +91,13 @@ public class AppConfig extends WebMvcConfigurerAdapter implements Configurable,
 
 	/**
 	 * Creates and returns a new instance of a secondary (order=2)
-	 * {@link ViewResolver} that finds files by adding prefix "/WEB-INF/jsp/"
-	 * and suffix ".jsp" to the base view name.
+	 * {@link ViewResolver} that finds files by adding prefix "/WEB-INF/jsp/" and
+	 * suffix ".jsp" to the base view name.
 	 * 
 	 * @return New instance of {@link ViewResolver}.
 	 */
 	@Bean
+	@Override
 	public ViewResolver viewResolver() {
 		InternalResourceViewResolver viewResolver = new InternalResourceViewResolver();
 		viewResolver.setViewClass(JstlView.class);
@@ -110,21 +108,20 @@ public class AppConfig extends WebMvcConfigurerAdapter implements Configurable,
 	}
 
 	/**
-	 * Loads all the default logging fields into the global MDC context and
-	 * marks each log file type that logging has been started.
+	 * Loads all the default logging fields into the global MDC context and marks
+	 * each log file type that logging has been started.
 	 */
 	private void initGlobalLocalContext() {
 		logger.init();
 	}
 
-	/*
+	/**
 	 * Any requests from the url pattern /static/**, Spring will look for the
-	 * resources from the /static/ Same as  in xml
+	 * resources from the /static/ Same as
+	 *  in xml
 	 */
 	@Override
 	public void addResourceHandlers(ResourceHandlerRegistry registry) {
-		// registry.addResourceHandler("/static/**").addResourceLocations("/static/");
 		registry.addResourceHandler("/**").addResourceLocations("/");
 	}
 
@@ -134,6 +131,7 @@ public class AppConfig extends WebMvcConfigurerAdapter implements Configurable,
 	 * @return New instance of {@link DataAccessService}.
 	 */
 	@Bean
+	@Override
 	public DataAccessService dataAccessService() {
 		return new DataAccessServiceImpl();
 	}
@@ -157,15 +155,14 @@ public class AppConfig extends WebMvcConfigurerAdapter implements Configurable,
 	public MenuBuilder menuBuilder() {
 		return new MenuBuilder();
 	}
-	
+
 	/**
 	 * Creates and returns a new instance of a {@link UserUtils} class.
 	 * 
 	 * @return New instance of {@link UserUtils}.
 	 */
 	@Bean
-	public UserUtils userUtil()
-	{
+	public UserUtils userUtil() {
 		return new UserUtils();
 	}
 
@@ -213,7 +210,7 @@ public class AppConfig extends WebMvcConfigurerAdapter implements Configurable,
 			String password = SystemProperties.getProperty(SystemProperties.DB_PASSWORD);
 			if (SystemProperties.containsProperty(SystemProperties.DB_ENCRYPT_FLAG)) {
 				String encryptFlag = SystemProperties.getProperty(SystemProperties.DB_ENCRYPT_FLAG);
-				if (encryptFlag != null && encryptFlag.equalsIgnoreCase("true")) {
+				if (encryptFlag != null && "true".equalsIgnoreCase(encryptFlag)) {
 					password = CipherUtil.decrypt(password);
 				}
 			}
@@ -227,14 +224,12 @@ public class AppConfig extends WebMvcConfigurerAdapter implements Configurable,
 			dataSource.setTestConnectionOnCheckout(getConnectionOnCheckout());
 			dataSource.setPreferredTestQuery(getPreferredTestQuery());
 		} catch (Exception e) {
+			// Show details
 			logger.error(EELFLoggerDelegate.errorLogger,
-					"Error initializing database, verify database settings in properties file: "
-							+ UserUtils.getStackTrace(e),
-					AlarmSeverityEnum.CRITICAL);
+					"Error initializing database, verify database settings in properties file", e);
+			// Include alarm in log 
 			logger.error(EELFLoggerDelegate.debugLogger,
-					"Error initializing database, verify database settings in properties file: "
-							+ UserUtils.getStackTrace(e),
-					AlarmSeverityEnum.CRITICAL);
+					"Error initializing database", AlarmSeverityEnum.CRITICAL);
 			// Raise an alarm that opening a connection to the database failed.
 			logger.logEcompError(AppMessagesEnum.BeDaoSystemError);
 			throw e;
@@ -243,9 +238,8 @@ public class AppConfig extends WebMvcConfigurerAdapter implements Configurable,
 	}
 
 	/**
-	 * Gets the value of the property
-	 * {@link SystemProperties#PREFERRED_TEST_QUERY}; defaults to "Select 1" if
-	 * the property is not defined.
+	 * Gets the value of the property {@link SystemProperties#PREFERRED_TEST_QUERY};
+	 * defaults to "Select 1" if the property is not defined.
 	 * 
 	 * @return String value that is a SQL query
 	 */
@@ -266,8 +260,8 @@ public class AppConfig extends WebMvcConfigurerAdapter implements Configurable,
 
 	/**
 	 * Gets the value of the property
-	 * {@link SystemProperties#TEST_CONNECTION_ON_CHECKOUT}; defaults to true if
-	 * the property is not defined.
+	 * {@link SystemProperties#TEST_CONNECTION_ON_CHECKOUT}; defaults to true if the
+	 * property is not defined.
 	 * 
 	 * @return Boolean value
 	 */
@@ -288,8 +282,8 @@ public class AppConfig extends WebMvcConfigurerAdapter implements Configurable,
 	}
 
 	/*
-	 * TODO: Check whether it is appropriate to extend the list of tile
-	 * definitions at every invocation.
+	 * TODO: Check whether it is appropriate to extend the list of tile definitions
+	 * at every invocation.
 	 */
 	protected String[] tileDefinitions() {
 		tileDefinitions.add("/WEB-INF/fusion/defs/definitions.xml");
@@ -304,8 +298,9 @@ public class AppConfig extends WebMvcConfigurerAdapter implements Configurable,
 	 * 
 	 * @return An empty list.
 	 */
+	@Override
 	public List addTileDefinitions() {
-		return new ArrayList();
+		return new ArrayList<>();
 	}
 
 	/**
@@ -324,9 +319,8 @@ public class AppConfig extends WebMvcConfigurerAdapter implements Configurable,
 	}
 
 	/**
-	 * Adds new instances of the following interceptors to the specified
-	 * interceptor registry: {@link SessionTimeoutInterceptor},
-	 * {@link ResourceInterceptor}
+	 * Adds new instances of the following interceptors to the specified interceptor
+	 * registry: {@link SessionTimeoutInterceptor}, {@link ResourceInterceptor}
 	 */
 	@Override
 	public void addInterceptors(InterceptorRegistry registry) {
@@ -345,8 +339,6 @@ public class AppConfig extends WebMvcConfigurerAdapter implements Configurable,
 		return new ResourceInterceptor();
 	}
 
-	private String[] excludeUrlPathsForSessionTimeout = {};
-
 	/**
 	 * Gets the array of Strings that are paths excluded for session timeout.
 	 * 
@@ -374,9 +366,8 @@ public class AppConfig extends WebMvcConfigurerAdapter implements Configurable,
 	 * (org.springframework.context.ApplicationContext)
 	 */
 	@Override
-	public void setApplicationContext(ApplicationContext applicationContext) throws BeansException {
+	public void setApplicationContext(ApplicationContext applicationContext) {
 		appApplicationContext = applicationContext;
-
 	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/conf/AppInitializer.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/conf/AppInitializer.java
index 0865b987..d2690c8d 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/conf/AppInitializer.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/conf/AppInitializer.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -46,34 +46,29 @@ import org.springframework.web.servlet.support.AbstractAnnotationConfigDispatche
 public abstract class AppInitializer extends AbstractAnnotationConfigDispatcherServletInitializer {
 
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(AppInitializer.class);
-	
-	private final String activeProfile = "src";
+
+	private static final String activeProfile = "src";
 
 	@Override
 	protected WebApplicationContext createServletApplicationContext() {
 		WebApplicationContext context = super.createServletApplicationContext();
-
 		try {
-
 			((ConfigurableEnvironment) context.getEnvironment()).setActiveProfiles(activeProfile);
 		} catch (Exception e) {
-
-			logger.error(EELFLoggerDelegate.errorLogger, "Unable to set the active profile" + e.getMessage(),AlarmSeverityEnum.MAJOR);
+			logger.error(EELFLoggerDelegate.errorLogger, "Unable to set the active profile" + e.getMessage(),
+					AlarmSeverityEnum.MAJOR);
 			throw e;
-
 		}
-
 		return context;
 	}
 
 	@Override
 	protected Class[] getRootConfigClasses() {
-		return null;
+		return new Class[0];
 	}
 
 	@Override
 	protected Class[] getServletConfigClasses() {
-
 		return new Class[] { AppConfig.class };
 	}
 
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/conf/Configurable.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/conf/Configurable.java
index d890e609..647315d5 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/conf/Configurable.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/conf/Configurable.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -44,13 +44,13 @@ import org.springframework.web.servlet.ViewResolver;
 import org.springframework.web.servlet.config.annotation.ResourceHandlerRegistry;
 
 public interface Configurable {
-	
-	    public ViewResolver viewResolver();
-	   
-	    public void addResourceHandlers(ResourceHandlerRegistry registry) ;
-	   
-	    public DataAccessService dataAccessService();
-	   
-	    public List addTileDefinitions();	    
-	    
+
+	public ViewResolver viewResolver();
+
+	public void addResourceHandlers(ResourceHandlerRegistry registry);
+
+	public DataAccessService dataAccessService();
+
+	public List addTileDefinitions();
+
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/conf/HibernateConfiguration.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/conf/HibernateConfiguration.java
index 54512865..4c142a2c 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/conf/HibernateConfiguration.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/conf/HibernateConfiguration.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -48,7 +48,6 @@ import java.util.Properties;
 import javax.sql.DataSource;
 
 import org.hibernate.SessionFactory;
-import org.onap.portalsdk.core.logging.format.AlarmSeverityEnum;
 import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
 import org.onap.portalsdk.core.util.SystemProperties;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -83,7 +82,8 @@ public class HibernateConfiguration {
 	}
 
 	/**
-	 * Builds a properties object with Hibernate properties in te system.properties file.
+	 * Builds a properties object with Hibernate properties in te system.properties
+	 * file.
 	 * 
 	 * @return Properties object
 	 */
@@ -107,27 +107,18 @@ public class HibernateConfiguration {
 			String sql = "SELECT schema_id,datasource_type,connection_url,user_name,password,driver_class,min_pool_size,max_pool_size,idle_connection_test_period FROM schema_info";
 			rs = stmt.executeQuery(sql);
 			while (rs.next()) {
-				ComboPooledDataSource dataSource = new ComboPooledDataSource();
-				dataSource.setDriverClass(rs.getString("driver_class"));
-				dataSource.setJdbcUrl(rs.getString("connection_url"));
-				dataSource.setUser(rs.getString("user_name"));
-				dataSource.setPassword(rs.getString("password"));
-				dataSource.setMinPoolSize(rs.getInt("min_pool_size"));
-				dataSource.setMaxPoolSize(rs.getInt("max_pool_size"));
-				dataSource.setIdleConnectionTestPeriod(rs.getInt("idle_connection_test_period"));
-				dataSourceMap.put(rs.getString("schema_id"), dataSource);
+				ComboPooledDataSource pool = new ComboPooledDataSource();
+				pool.setDriverClass(rs.getString("driver_class"));
+				pool.setJdbcUrl(rs.getString("connection_url"));
+				pool.setUser(rs.getString("user_name"));
+				pool.setPassword(rs.getString("password"));
+				pool.setMinPoolSize(rs.getInt("min_pool_size"));
+				pool.setMaxPoolSize(rs.getInt("max_pool_size"));
+				pool.setIdleConnectionTestPeriod(rs.getInt("idle_connection_test_period"));
+				dataSourceMap.put(rs.getString("schema_id"), pool);
 			}
-			rs.close();
-			rs = null;
-			stmt.close();
-			stmt = null;
-			conn.close();
-			conn = null;
 		} catch (Exception e) {
-			logger.error(EELFLoggerDelegate.errorLogger,
-					"Error initializing database, verify database settings in properties file: " + e.getMessage(),
-					AlarmSeverityEnum.CRITICAL);
-			e.printStackTrace();
+			logger.error(EELFLoggerDelegate.errorLogger, "dataSourceMap failed", e);
 			dataSourceMap = null;
 			throw e;
 		} finally {
@@ -139,15 +130,9 @@ public class HibernateConfiguration {
 				if (conn != null)
 					conn.close();
 			} catch (SQLException se2) {
-			}
-			try {
-				if (conn != null)
-					conn.close();
-			} catch (SQLException se) {
-				se.printStackTrace();
+				logger.warn(EELFLoggerDelegate.errorLogger, "dataSourceMap failed to close", se2);
 			}
 		}
-
 		return dataSourceMap;
 	}
 
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/conf/HibernateMappingLocatable.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/conf/HibernateMappingLocatable.java
index 743d4b76..11effb62 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/conf/HibernateMappingLocatable.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/conf/HibernateMappingLocatable.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -43,19 +43,20 @@ import org.springframework.core.io.Resource;
  * Defines methods used by developers to supply Hibernate configuration.
  */
 public interface HibernateMappingLocatable {
-	
+
 	/**
 	 * Gets Hibernate mapping locations.
 	 * 
-	 * @return Array of Resource objects (usually ClassPathResource that's a
-	 *         file) which contain Hibernate mapping information.
+	 * @return Array of Resource objects (usually ClassPathResource that's a file)
+	 *         which contain Hibernate mapping information.
 	 */
-	public Resource [] getMappingLocations();
+	public Resource[] getMappingLocations();
 
 	/**
 	 * Gets package names.
 	 * 
-	 * @return Array of Java package names to scan for classes with Hibernate annotations.
+	 * @return Array of Java package names to scan for classes with Hibernate
+	 *         annotations.
 	 */
-	public String [] getPackagesToScan();
+	public String[] getPackagesToScan();
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/controller/FusionBaseController.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/controller/FusionBaseController.java
index 48c145b3..980feaec 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/controller/FusionBaseController.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/controller/FusionBaseController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -63,77 +63,70 @@ import org.springframework.web.bind.annotation.ModelAttribute;
 import com.fasterxml.jackson.databind.ObjectMapper;
 
 @Controller
-public abstract class FusionBaseController implements SecurityInterface{
-	
+public abstract class FusionBaseController implements SecurityInterface {
+
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(FusionBaseController.class);
-	
-	@Override
-	public boolean isAccessible() {
-		return true;
-	}
-	
-	public boolean isRESTfulCall(){
-		return true;
-	}
+
 	@Autowired
 	private FnMenuService fnMenuService;
-	
+
 	@Autowired
-	private MenuBuilder  menuBuilder;
-	   
+	private MenuBuilder menuBuilder;
+
 	@Autowired
-	private DataAccessService  dataAccessService;
-	
+	private DataAccessService dataAccessService;
+
 	@Autowired
-	AppService appService;
-	
+	private AppService appService;
+
 	@SuppressWarnings({ "unchecked", "rawtypes" })
 	@ModelAttribute("menu")
 	public Map getMenu(HttpServletRequest request) {
 		HttpSession session = null;
-		Map model = new HashMap();	 
+		Map model = new HashMap<>();
 		try {
-			try {
-				String appName	= appService.getDefaultAppName();
-				if (appName==null || appName=="") {
-					appName		= SystemProperties.SDK_NAME;
-				}
-		        logger.setRequestBasedDefaultsIntoGlobalLoggingContext(request, appName);
-            } catch (Exception e) {
-            }
-			
+			String appName = appService.getDefaultAppName();
+			if (appName == null || appName == "")
+				appName = SystemProperties.SDK_NAME;
+			logger.setRequestBasedDefaultsIntoGlobalLoggingContext(request, appName);
+
 			session = request.getSession();
 			User user = UserUtils.getUserSession(request);
-			if(session!=null && user!=null){
-				Set menuResult = (Set) session.getAttribute(SystemProperties.getProperty(SystemProperties.APPLICATION_MENU_ATTRIBUTE_NAME));
-				if(menuResult==null){
-					 Set appMenu = getMenuBuilder().getMenu(SystemProperties.getProperty(SystemProperties.APPLICATION_MENU_SET_NAME),dataAccessService);
-					 session.setAttribute(SystemProperties.getProperty(SystemProperties.APPLICATION_MENU_ATTRIBUTE_NAME),    MenuBuilder.filterMenu(appMenu, request));
-					 menuResult = (Set) session.getAttribute(SystemProperties.getProperty(SystemProperties.APPLICATION_MENU_ATTRIBUTE_NAME));
+			if (session != null && user != null) {
+				Set menuResult = (Set) session
+						.getAttribute(SystemProperties.getProperty(SystemProperties.APPLICATION_MENU_ATTRIBUTE_NAME));
+				if (menuResult == null) {
+					Set appMenu = getMenuBuilder().getMenu(
+							SystemProperties.getProperty(SystemProperties.APPLICATION_MENU_SET_NAME),
+							dataAccessService);
+					session.setAttribute(SystemProperties.getProperty(SystemProperties.APPLICATION_MENU_ATTRIBUTE_NAME),
+							MenuBuilder.filterMenu(appMenu, request));
+					menuResult = (Set) session.getAttribute(
+							SystemProperties.getProperty(SystemProperties.APPLICATION_MENU_ATTRIBUTE_NAME));
 				}
-				model = setMenu(menuResult);				
+				model = setMenu(menuResult);
 			}
 		} catch (Exception e) {
-			logger.error(EELFLoggerDelegate.errorLogger, e.getMessage());
+			logger.error(EELFLoggerDelegate.errorLogger, "getMenu failed", e);
 		}
 		return model;
 	}
-	
-	public Map setMenu(Set menuResult) throws Exception{
+
+	public Map setMenu(Set menuResult) throws Exception {
 		ObjectMapper mapper = new ObjectMapper();
-		List> childItemList = new ArrayList>();;
-		List parentList = new ArrayList();;
-		Map model = new HashMap();
-		try{
-			fnMenuService.setMenuDataStructure(childItemList, parentList, menuResult);		
-		}catch(Exception e){
-			logger.error(EELFLoggerDelegate.errorLogger, e.getMessage());
-		}		
+		List> childItemList = new ArrayList<>();
+		List parentList = new ArrayList<>();
+		try {
+			fnMenuService.setMenuDataStructure(childItemList, parentList, menuResult);
+		} catch (Exception e) {
+			logger.error(EELFLoggerDelegate.errorLogger, "setMenu failed", e);
+		}
+		Map model = new HashMap<>();
 		model.put("childItemList", mapper.writeValueAsString(childItemList));
 		model.put("parentList", mapper.writeValueAsString(parentList));
 		return model;
 	}
-	
+
 	public MenuBuilder getMenuBuilder() {
 		return menuBuilder;
 	}
@@ -149,5 +142,14 @@ public abstract class FusionBaseController implements SecurityInterface{
 	public void setDataAccessService(DataAccessService dataAccessService) {
 		this.dataAccessService = dataAccessService;
 	}
-	
+
+	@Override
+	public boolean isAccessible() {
+		return true;
+	}
+
+	public boolean isRESTfulCall() {
+		return true;
+	}
+
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/controller/RestrictedBaseController.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/controller/RestrictedBaseController.java
index 1659dc32..5fdac61b 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/controller/RestrictedBaseController.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/controller/RestrictedBaseController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,32 +37,35 @@
  */
 package org.onap.portalsdk.core.controller;
 
-public class RestrictedBaseController extends FusionBaseController{
-	
+public class RestrictedBaseController extends FusionBaseController {
+
 	protected String viewName;
 	private String exceptionView;
+
 	@Override
 	public boolean isAccessible() {
 		return false;
 	}
+
 	@Override
-	public boolean isRESTfulCall(){
+	public boolean isRESTfulCall() {
 		return false;
 	}
+
 	protected String getViewName() {
 		return viewName;
 	}
+
 	protected void setViewName(String viewName) {
 		this.viewName = viewName;
 	}
 
 	public String getExceptionView() {
-        return (exceptionView == null) ? "runtime_error_handler" : exceptionView;
+		return (exceptionView == null) ? "runtime_error_handler" : exceptionView;
 	}
 
 	public void setExceptionView(String exceptionView) {
 		this.exceptionView = exceptionView;
 	}
-	
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/controller/RestrictedRESTfulBaseController.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/controller/RestrictedRESTfulBaseController.java
index 1dfffaa0..5a33c752 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/controller/RestrictedRESTfulBaseController.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/controller/RestrictedRESTfulBaseController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,32 +37,35 @@
  */
 package org.onap.portalsdk.core.controller;
 
-public class RestrictedRESTfulBaseController extends FusionBaseController{
-	
+public class RestrictedRESTfulBaseController extends FusionBaseController {
+
 	protected String viewName;
 	private String exceptionView;
+
 	@Override
 	public boolean isAccessible() {
 		return false;
 	}
+
 	@Override
-	public boolean isRESTfulCall(){
+	public boolean isRESTfulCall() {
 		return true;
 	}
+
 	protected String getViewName() {
 		return viewName;
 	}
+
 	protected void setViewName(String viewName) {
 		this.viewName = viewName;
 	}
 
 	public String getExceptionView() {
-        return (exceptionView == null) ? "runtime_error_handler" : exceptionView;
+		return (exceptionView == null) ? "runtime_error_handler" : exceptionView;
 	}
 
 	public void setExceptionView(String exceptionView) {
 		this.exceptionView = exceptionView;
 	}
-	
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/controller/UnRestrictedBaseController.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/controller/UnRestrictedBaseController.java
index 81f0c54d..b78f7bfb 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/controller/UnRestrictedBaseController.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/controller/UnRestrictedBaseController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,17 +37,19 @@
  */
 package org.onap.portalsdk.core.controller;
 
-public class UnRestrictedBaseController extends FusionBaseController{
+public class UnRestrictedBaseController extends FusionBaseController {
 	protected String viewName;
-	
+
 	@Override
 	public boolean isAccessible() {
 		return true;
 	}
+
 	@Override
-	public boolean isRESTfulCall(){
+	public boolean isRESTfulCall() {
 		return false;
 	}
+
 	protected String getViewName() {
 		return viewName;
 	}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/dao/AbstractDao.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/dao/AbstractDao.java
index c1d063a9..e70468c6 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/dao/AbstractDao.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/dao/AbstractDao.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -36,6 +36,7 @@
  * ECOMP is a trademark and service mark of AT&T Intellectual Property.
  */
 package org.onap.portalsdk.core.dao;
+
 import java.io.Serializable;
 import java.lang.reflect.ParameterizedType;
 
@@ -43,38 +44,39 @@ import org.hibernate.Criteria;
 import org.hibernate.Session;
 import org.hibernate.SessionFactory;
 import org.springframework.beans.factory.annotation.Autowired;
- 
-public abstract class AbstractDao {
-     
-    private final Class persistentClass;
-     
-    @SuppressWarnings("unchecked")
-    public AbstractDao(){
-        this.persistentClass =(Class) ((ParameterizedType) this.getClass().getGenericSuperclass()).getActualTypeArguments()[1];
-    }
-     
-    @Autowired
-    private SessionFactory sessionFactory;
- 
-    protected Session getSession(){
-        return sessionFactory.getCurrentSession();
-    }
- 
-    @SuppressWarnings("unchecked")
-    public T getByKey(PK key) {
-        return (T) getSession().get(persistentClass, key);
-    }
- 
-    public void persist(T entity) {
-        getSession().persist(entity);
-    }
- 
-    public void delete(T entity) {
-        getSession().delete(entity);
-    }
-     
-    protected Criteria createEntityCriteria(){
-        return getSession().createCriteria(persistentClass);
-    }
- 
+
+public abstract class AbstractDao {
+
+	private final Class persistentClass;
+
+	@Autowired
+	private SessionFactory sessionFactory;
+
+	@SuppressWarnings("unchecked")
+	public AbstractDao() {
+		this.persistentClass = (Class) ((ParameterizedType) this.getClass().getGenericSuperclass())
+				.getActualTypeArguments()[1];
+	}
+
+	protected Session getSession() {
+		return sessionFactory.getCurrentSession();
+	}
+
+	@SuppressWarnings("unchecked")
+	public T getByKey(K key) {
+		return (T) getSession().get(persistentClass, key);
+	}
+
+	public void persist(T entity) {
+		getSession().persist(entity);
+	}
+
+	public void delete(T entity) {
+		getSession().delete(entity);
+	}
+
+	protected Criteria createEntityCriteria() {
+		return getSession().createCriteria(persistentClass);
+	}
+
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/dao/ProfileDao.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/dao/ProfileDao.java
index bb93ac36..a34737c8 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/dao/ProfileDao.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/dao/ProfileDao.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -43,5 +43,6 @@ import org.onap.portalsdk.core.domain.Profile;
 
 public interface ProfileDao {
 	List findAll();
+
 	Profile getProfile(int id);
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/dao/ProfileDaoImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/dao/ProfileDaoImpl.java
index ee6c32d3..471aed01 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/dao/ProfileDaoImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/dao/ProfileDaoImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -41,29 +41,24 @@ import java.util.List;
 
 import org.hibernate.Criteria;
 import org.hibernate.criterion.Restrictions;
-import org.onap.portalsdk.core.dao.AbstractDao;
 import org.onap.portalsdk.core.domain.Profile;
 import org.springframework.stereotype.Repository;
 
 @Repository("profileDao")
-public class ProfileDaoImpl extends AbstractDao implements ProfileDao{
+public class ProfileDaoImpl extends AbstractDao implements ProfileDao {
 
-	
+	@Override
+	@SuppressWarnings("unchecked")
 	public List findAll() {
 		Criteria crit = getSession().createCriteria(Profile.class);
-		@SuppressWarnings("unchecked")
-		List p = crit.list();
-		
-		return p;
+		return crit.list();
 	}
 
-	
+	@Override
 	public Profile getProfile(int id) {
 		Criteria crit = getSession().createCriteria(Profile.class);
 		crit.add(Restrictions.eq("id", id));
-		Profile profile = (Profile) crit.uniqueResult();
-		
-		return profile;
+		return (Profile) crit.uniqueResult();
 	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/dao/hibernate/ModelOperationsCommon.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/dao/hibernate/ModelOperationsCommon.java
index 2c3fa5da..f1fcd889 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/dao/hibernate/ModelOperationsCommon.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/dao/hibernate/ModelOperationsCommon.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -67,7 +67,6 @@ public abstract class ModelOperationsCommon extends FusionDao {
 
 	@SuppressWarnings({ "rawtypes", "unchecked" })
 	public List _getList(Class domainClass, String filterClause, Integer fromIndex, Integer toIndex, String orderBy) {
-		List list = null;
 		String className = domainClass.getName();
 
 		Session session = getSessionFactory().getCurrentSession();
@@ -76,19 +75,15 @@ public abstract class ModelOperationsCommon extends FusionDao {
 				+ ((fromIndex != null) ? " from rows " + fromIndex.toString() + " to " + toIndex.toString() : "")
 				+ "...");
 
-
-		if (filterClause != null && filterClause.length() > 0) {
+		if (filterClause != null && filterClause.length() > 0)
 			logger.info(EELFLoggerDelegate.debugLogger, "Filtering " + className + " by: " + filterClause);
 
-		}
-
-		list = session.createQuery("from " + className + Utilities.nvl(filterClause, "")
+		List list = session.createQuery("from " + className + Utilities.nvl(filterClause, "")
 				+ ((orderBy != null) ? " order by " + orderBy : "")).list();
 		list = (fromIndex != null) ? list.subList(fromIndex.intValue() - 1, toIndex.intValue()) : list;
 
-		if (orderBy == null && list != null) {
+		if (orderBy == null && list != null)
 			Collections.sort(list);
-		}
 
 		return list;
 	}
@@ -121,9 +116,8 @@ public abstract class ModelOperationsCommon extends FusionDao {
 
 		if (fetchModeMap != null) {
 			Iterator itr = fetchModeMap.keySet().iterator();
-			String key = null;
 			while (itr.hasNext()) {
-				key = itr.next();
+				String key = itr.next();
 				criteria.setFetchMode(key, fetchModeMap.get(key));
 			}
 
@@ -133,21 +127,20 @@ public abstract class ModelOperationsCommon extends FusionDao {
 
 	@SuppressWarnings("rawtypes")
 	public DomainVo _get(Class domainClass, Serializable id) {
-		DomainVo vo = null;
 
 		Session session = getSessionFactory().getCurrentSession();
 
-		logger.info(EELFLoggerDelegate.debugLogger, "Getting " + domainClass.getName() + " record for id - " + id.toString());
+		logger.info(EELFLoggerDelegate.debugLogger,
+				"Getting " + domainClass.getName() + " record for id - " + id.toString());
 
-
-		vo = (DomainVo) session.get(domainClass, id);
+		DomainVo vo = (DomainVo) session.get(domainClass, id);
 
 		if (vo == null) {
 			try {
 				vo = (DomainVo) domainClass.newInstance();
 			} catch (Exception e) {
-				logger.error(EELFLoggerDelegate.errorLogger, "Failed while instantiating a class of " + domainClass.getName() + e.getMessage());
-
+				logger.error(EELFLoggerDelegate.errorLogger,
+						"Failed while instantiating a class of " + domainClass.getName(), e);
 			}
 		}
 
@@ -156,7 +149,7 @@ public abstract class ModelOperationsCommon extends FusionDao {
 
 	@SuppressWarnings("rawtypes")
 	public List _getLookupList(String dbTable, String dbValueCol, String dbLabelCol, String dbFilter, String dbOrderBy,
-			HashMap additionalParams) {
+			Map additionalParams) {
 		logger.info(EELFLoggerDelegate.debugLogger, "Retrieving " + dbTable + " lookup list...");
 
 		List list = null;
@@ -164,7 +157,7 @@ public abstract class ModelOperationsCommon extends FusionDao {
 
 		Session session = getSessionFactory().getCurrentSession();
 
-		// default the orderBy if null;
+		// default the orderBy if null
 		if (Utilities.nvl(dbOrderBy).length() == 0) {
 			dbOrderByCol = dbLabelCol;
 			dbOrderBy = dbLabelCol;
@@ -174,8 +167,7 @@ public abstract class ModelOperationsCommon extends FusionDao {
 			}
 		}
 
-		StringBuffer sql = new StringBuffer();
-
+		StringBuilder sql = new StringBuilder();
 		sql.append("select distinct ").append(dbLabelCol).append(" as lab, ").append(dbValueCol).append(" as val, ")
 				.append(dbOrderByCol).append(" as sortOrder ").append("from ").append(dbTable).append(" ")
 				.append((Utilities.nvl(dbFilter).length() == 0) ? "" : (" where " + dbFilter)).append(" order by ")
@@ -185,19 +177,23 @@ public abstract class ModelOperationsCommon extends FusionDao {
 			list = session.createSQLQuery(sql.toString()).addEntity(Lookup.class).list();
 		} catch (Exception e) {
 			list = null;
-			logger.info(EELFLoggerDelegate.debugLogger, "The results for the lookup list query [" + sql + "] were empty.");
+			logger.error(EELFLoggerDelegate.errorLogger, "_getLookupList failed on SQL: [" + sql + "]", e);
 		}
 
 		return list;
 	} // getLookupList
 
-	/* This method is used to execute SQL queries */
+	/**
+	 * This method is used to execute SQL queries
+	 */
 	@SuppressWarnings("rawtypes")
 	protected final List _executeSQLQuery(String sql, Class domainClass) {
 		return _executeSQLQuery(sql, domainClass, null, null);
 	}
 
-	/* This method is used to execute SQL queries with paging */
+	/**
+	 * This method is used to execute SQL queries with paging
+	 */
 	@SuppressWarnings("rawtypes")
 	protected final List _executeSQLQuery(String sql, Class domainClass, Integer fromIndex, Integer toIndex) {
 		Session session = getSessionFactory().getCurrentSession();
@@ -213,13 +209,17 @@ public abstract class ModelOperationsCommon extends FusionDao {
 		return query.list();
 	}
 
-	/* This method is used to execute HQL queries */
+	/**
+	 * This method is used to execute HQL queries
+	 */
 	@SuppressWarnings("rawtypes")
 	protected final List _executeQuery(String sql) {
 		return _executeQuery(sql, null, null);
 	}
 
-	/* This method is used to execute HQL queries with paging */
+	/**
+	 * This method is used to execute HQL queries with paging
+	 */
 	@SuppressWarnings("rawtypes")
 	protected final List _executeQuery(String sql, Integer fromIndex, Integer toIndex) {
 		Session session = getSessionFactory().getCurrentSession();
@@ -235,22 +235,22 @@ public abstract class ModelOperationsCommon extends FusionDao {
 		return query.list();
 	}
 
-	/*
+	/**
 	 * This method can be used to execute both HQL or SQL named queries. The
-	 * distinction will come in the hbm.xml mapping file defining the named
-	 * query. Named HQL queries use the  tag while named SQL queries use
-	 * the  tag.
+	 * distinction will come in the hbm.xml mapping file defining the named query.
+	 * Named HQL queries use the  tag while named SQL queries use the
+	 *  tag.
 	 */
 	@SuppressWarnings("rawtypes")
 	protected final List _executeNamedQuery(String queryName, Map params) {
 		return _executeNamedQuery(queryName, params, null, null);
 	}
 
-	/*
-	 * This method can be used to execute both HQL or SQL named queries with
-	 * paging. The distinction will come in the hbm.xml mapping file defining
-	 * the named query. Named HQL queries use the  tag while named SQL
-	 * queries use the  tag.
+	/**
+	 * This method can be used to execute both HQL or SQL named queries with paging.
+	 * The distinction will come in the hbm.xml mapping file defining the named
+	 * query. Named HQL queries use the  tag while named SQL queries use the
+	 *  tag.
 	 */
 	@SuppressWarnings("rawtypes")
 	protected final List _executeNamedQuery(String queryName, Map params, Integer fromIndex, Integer toIndex) {
@@ -266,37 +266,32 @@ public abstract class ModelOperationsCommon extends FusionDao {
 	}
 
 	// RAPTOR ZK
-	/*
-	 * This method can be used to execute both HQL or SQL named queries with
-	 * paging. The distinction will come in the hbm.xml mapping file defining
-	 * the named query. Named HQL queries use the  tag while named SQL
-	 * queries use the  tag.
+
+	/**
+	 * This method can be used to execute both HQL or SQL named queries with paging.
+	 * The distinction will come in the hbm.xml mapping file defining the named
+	 * query. Named HQL queries use the  tag while named SQL queries use the
+	 *  tag.
 	 */
 	@SuppressWarnings("rawtypes")
 	protected final List _executeNamedCountQuery(Class entity, String queryName, String whereClause, Map params) {
 		Session session = getSessionFactory().getCurrentSession();
 		Query query = session.getNamedQuery(queryName);
 		String queryStr = query.getQueryString();
-		StringBuffer modifiedSql = new StringBuffer(" select count(*) as countRows from (" + queryStr + " ) al ");
+		StringBuilder modifiedSql = new StringBuilder("select count(*) as countRows from (" + queryStr + " ) al ");
 		if (whereClause != null && whereClause.length() > 0)
 			modifiedSql.append("where " + whereClause);
-		// SQLQuery sqlQuery = session.createSQLQuery(" select count(*) as
-		// {reportSearch.countRows} from ("+ modifiedSql.toString()+")");
 		SQLQuery sqlQuery = session.createSQLQuery(modifiedSql.toString());
 		bindQueryParameters(sqlQuery, params);
 		sqlQuery.addScalar("countRows", LongType.INSTANCE);
-		// sqlQuery.addEntity("reportSearch", entity);
-		// sqlQuery.setResultTransformer(new
-		// AliasToBeanResultTransformer(SearchCount.class));
 		return sqlQuery.list();
-
 	}
 
-	/*
-	 * This method can be used to execute both HQL or SQL named queries with
-	 * paging. The distinction will come in the hbm.xml mapping file defining
-	 * the named query. Named HQL queries use the  tag while named SQL
-	 * queries use the  tag. It is modified to test ZK filter.
+	/**
+	 * This method can be used to execute both HQL or SQL named queries with paging.
+	 * The distinction will come in the hbm.xml mapping file defining the named
+	 * query. Named HQL queries use the  tag while named SQL queries use the
+	 *  tag. It is modified to test ZK filter.
 	 */
 	@SuppressWarnings("rawtypes")
 	protected final List _executeNamedQuery(Class entity, String queryName, String whereClause, Map params,
@@ -305,12 +300,13 @@ public abstract class ModelOperationsCommon extends FusionDao {
 		Query query = session.getNamedQuery(queryName);
 		bindQueryParameters(query, params);
 		String queryStr = query.getQueryString();
-		StringBuffer modifiedSql = new StringBuffer(" select * from (" + queryStr + " ) al ");
+		StringBuilder modifiedSql = new StringBuilder(" select * from (" + queryStr + " ) al ");
 		if (whereClause != null && whereClause.length() > 0)
 			modifiedSql.append("where " + whereClause);
 
 		SQLQuery sqlQuery = session.createSQLQuery(modifiedSql.toString());
 		bindQueryParameters(sqlQuery, params);
+		// why is reportSearch hardcoded here?
 		sqlQuery.addEntity("reportSearch", entity);
 
 		if (fromIndex != null && toIndex != null) {
@@ -321,11 +317,11 @@ public abstract class ModelOperationsCommon extends FusionDao {
 		return sqlQuery.list();
 	}
 
-	/*
-	 * This method can be used to execute both HQL or SQL named queries with
-	 * paging. The distinction will come in the hbm.xml mapping file defining
-	 * the named query. Named HQL queries use the  tag while named SQL
-	 * queries use the  tag.
+	/**
+	 * x This method can be used to execute both HQL or SQL named queries with
+	 * paging. The distinction will come in the hbm.xml mapping file defining the
+	 * named query. Named HQL queries use the  tag while named SQL queries
+	 * use the  tag.
 	 */
 	@SuppressWarnings("rawtypes")
 	protected final List _executeNamedQueryWithOrderBy(Class entity, String queryName, Map params, String _orderBy,
@@ -346,7 +342,6 @@ public abstract class ModelOperationsCommon extends FusionDao {
 		return sqlQuery.list();
 	}
 
-	// Where Clause
 	@SuppressWarnings("rawtypes")
 	protected final List _executeNamedQueryWithOrderBy(Class entity, String queryName, String whereClause, Map params,
 			String _orderBy, boolean asc, Integer fromIndex, Integer toIndex) {
@@ -355,10 +350,7 @@ public abstract class ModelOperationsCommon extends FusionDao {
 		bindQueryParameters(query, params);
 		String queryStr = query.getQueryString();
 		queryStr = String.format(queryStr, _orderBy, asc ? "ASC" : "DESC");
-		// StringBuffer modifiedSql = new StringBuffer(queryStr );
-		StringBuffer modifiedSql = new StringBuffer(" select * from (" + queryStr + " ) al ");
-		// modifiedSql.insert(queryStr.lastIndexOf("order by"), " " +
-		// whereClause + " ");
+		StringBuilder modifiedSql = new StringBuilder(" select * from (" + queryStr + " ) al ");
 		if (whereClause != null && whereClause.length() > 0)
 			modifiedSql.append("where " + whereClause);
 		SQLQuery sqlQuery = session.createSQLQuery(modifiedSql.toString());
@@ -375,7 +367,7 @@ public abstract class ModelOperationsCommon extends FusionDao {
 	// RAPTOR ZK END
 
 	/* Processes custom Insert/Update/Delete SQL statements */
-	protected final int _executeUpdateQuery(String sql) throws Exception {
+	protected final int _executeUpdateQuery(String sql) {
 		Session session = getSessionFactory().getCurrentSession();
 		Query query = session.createSQLQuery(sql);
 		return query.executeUpdate();
@@ -383,7 +375,7 @@ public abstract class ModelOperationsCommon extends FusionDao {
 
 	/* Processes Insert/Update/Delete Named SQL statements */
 	@SuppressWarnings("rawtypes")
-	protected final int _executeNamedUpdateQuery(String queryName, Map params) throws Exception {
+	protected final int _executeNamedUpdateQuery(String queryName, Map params) {
 		Session session = getSessionFactory().getCurrentSession();
 		Query query = session.getNamedQuery(queryName);
 		bindQueryParameters(query, params);
@@ -391,7 +383,7 @@ public abstract class ModelOperationsCommon extends FusionDao {
 	}
 
 	protected final void _update(DomainVo vo, Integer userId) {
-		_update(vo, ((userId != null) ? userId.intValue() : 0));
+		_update(vo, (userId != null) ? userId.intValue() : 0);
 	}
 
 	protected final void _update(DomainVo vo, int userId) {
@@ -427,16 +419,10 @@ public abstract class ModelOperationsCommon extends FusionDao {
 
 	@SuppressWarnings("rawtypes")
 	protected final int _remove(Class domainClass, String whereClause) {
-		int rowsAffected = 0;
-
 		Session session = getSessionFactory().getCurrentSession();
-
-		StringBuffer sql = new StringBuffer("delete from ");
-
+		StringBuilder sql = new StringBuilder("delete from ");
 		sql.append(domainClass.getName()).append(" where ").append(whereClause);
-
-		rowsAffected = session.createQuery(sql.toString()).executeUpdate();
-
+		int rowsAffected = session.createQuery(sql.toString()).executeUpdate();
 		return rowsAffected;
 	}
 
@@ -452,17 +438,14 @@ public abstract class ModelOperationsCommon extends FusionDao {
 				Map.Entry entry = (Map.Entry) i.next();
 
 				Object parameterValue = entry.getValue();
-
 				if (!(parameterValue instanceof Collection) && !(parameterValue instanceof Object[])) {
 					query.setParameter((String) entry.getKey(), parameterValue);
+				} else if (parameterValue instanceof Collection) {
+					query.setParameterList((String) entry.getKey(), (Collection) parameterValue);
+				} else if (parameterValue instanceof Object[]) {
+					query.setParameterList((String) entry.getKey(), (Object[]) parameterValue);
 				} else {
-					if (parameterValue instanceof Collection) {
-						query.setParameterList((String) entry.getKey(), (Collection) parameterValue);
-					} else {
-						if (parameterValue instanceof Object[]) {
-							query.setParameterList((String) entry.getKey(), (Object[]) parameterValue);
-						}
-					}
+					logger.warn("bindQueryParameters: unimplemented case for {}", parameterValue);
 				}
 			}
 		}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/dao/support/FusionDao.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/dao/support/FusionDao.java
index a3ff27fd..3ff2e47a 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/dao/support/FusionDao.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/dao/support/FusionDao.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -41,13 +41,13 @@ import org.hibernate.SessionFactory;
 import org.onap.portalsdk.core.FusionObject;
 
 public class FusionDao implements FusionObject {
-    private SessionFactory sessionFactory;
+	private SessionFactory sessionFactory;
 
-    public void setSessionFactory(SessionFactory sessionFactory) {
-        this.sessionFactory = sessionFactory;
-    }
+	public void setSessionFactory(SessionFactory sessionFactory) {
+		this.sessionFactory = sessionFactory;
+	}
 
-    public SessionFactory getSessionFactory() {
-        return this.sessionFactory;
-    }
+	public SessionFactory getSessionFactory() {
+		return this.sessionFactory;
+	}
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/App.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/App.java
index dfc4ae3c..0fa94a10 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/App.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/App.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -58,7 +58,7 @@ public class App extends DomainVo {
 	private String alternateUrl; // app_alternate_url
 	private String restEndpoint; // app_rest_endpoint
 	private String mlAppName; // ml_app_name
-	private String mlAppAdminId; // ml_app_admin_id;
+	private String mlAppAdminId; // ml_app_admin_id
 	private String motsId; // mots_id
 	private String appPassword; // app_password
 	private String open;
@@ -216,6 +216,7 @@ public class App extends DomainVo {
 	/**
 	 * Answers true if the objects have the same ID.
 	 */
+	@Override
 	public int compareTo(Object obj) {
 		Long c1 = getId();
 		Long c2 = ((App) obj).getId();
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/AuditLog.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/AuditLog.java
index 7cebc1af..b9f49519 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/AuditLog.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/AuditLog.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -47,61 +47,60 @@ public class AuditLog extends DomainVo {
 	 * 
 	 */
 	private static final long serialVersionUID = 1L;
-	public static final String  CD_ACTIVITY_LOGIN  = "login";
-    public static final String  CD_ACTIVITY_LOGOUT = "logout";
-    public static final String  CD_ACTIVITY_MOBILE_LOGIN  = "mobile_login";
-    public static final String  CD_ACTIVITY_MOBILE_LOGOUT = "mobile_logout";
-    
-    /*-------Profile activities -----------*/
-    public static final String  CD_ACTIVITY_ROLE_ADD = "add_role";
-    public static final String  CD_ACTIVITY_ROLE_REMOVE = "remove_role";
-    public static final String  CD_ACTIVITY_CHILD_ROLE_ADD = "add_child_role";
-    public static final String  CD_ACTIVITY_CHILD_ROLE_REMOVE = "remove_child_role";
-    public static final String  CD_ACTIVITY_ROLE_ADD_FUNCTION = "add_role_function";
-    public static final String  CD_ACTIVITY_ROLE_REMOVE_FUNCTION = "remove_role_function";
-    public static final String  CD_ACTIVITY_USER_ROLE_ADD = "add_user_role";
-    public static final String  CD_ACTIVITY_USER_ROLE_REMOVE = "remove_user_role";
-    
-    /*Audit activities*/
-    public static final String  CD_ACTIVITY_FUNCTIONAL_ACCESS = "functional_access";
-    public static final String  CD_ACTIVITY_TAB_ACCESS = "tab_access";
-    public static final String  CD_ACTIVITY_APP_ACCESS = "app_access";
-    public static final String  CD_ACTIVITY_LEFT_MENU_ACCESS = "left_menu_access";  
-    
-    
-    private String       activityCode;
-    private String 		 affectedRecordId;
-    private String       comments;
-    private Date    	auditDate;
-    private Long 		userId;
-    
-    public AuditLog() {
-      setCreated(new Date());
-    }
-   
-    public String getActivityCode() {
-        return activityCode;
-    }
-
-    public String getComments() {
-        return comments;
-    }
-
-    public String getAffectedRecordId() {
-        return affectedRecordId;
-    }
-
-    public void setActivityCode(String activityCode) {
-        this.activityCode = activityCode;
-    }
-
-    public void setComments(String comments) {
-        this.comments = comments;
-    }
-
-    public void setAffectedRecordId(String affectedRecordId) {
-        this.affectedRecordId = affectedRecordId;
-    }
+	public static final String CD_ACTIVITY_LOGIN = "login";
+	public static final String CD_ACTIVITY_LOGOUT = "logout";
+	public static final String CD_ACTIVITY_MOBILE_LOGIN = "mobile_login";
+	public static final String CD_ACTIVITY_MOBILE_LOGOUT = "mobile_logout";
+
+	/*-------Profile activities -----------*/
+	public static final String CD_ACTIVITY_ROLE_ADD = "add_role";
+	public static final String CD_ACTIVITY_ROLE_REMOVE = "remove_role";
+	public static final String CD_ACTIVITY_CHILD_ROLE_ADD = "add_child_role";
+	public static final String CD_ACTIVITY_CHILD_ROLE_REMOVE = "remove_child_role";
+	public static final String CD_ACTIVITY_ROLE_ADD_FUNCTION = "add_role_function";
+	public static final String CD_ACTIVITY_ROLE_REMOVE_FUNCTION = "remove_role_function";
+	public static final String CD_ACTIVITY_USER_ROLE_ADD = "add_user_role";
+	public static final String CD_ACTIVITY_USER_ROLE_REMOVE = "remove_user_role";
+
+	/* Audit activities */
+	public static final String CD_ACTIVITY_FUNCTIONAL_ACCESS = "functional_access";
+	public static final String CD_ACTIVITY_TAB_ACCESS = "tab_access";
+	public static final String CD_ACTIVITY_APP_ACCESS = "app_access";
+	public static final String CD_ACTIVITY_LEFT_MENU_ACCESS = "left_menu_access";
+
+	private String activityCode;
+	private String affectedRecordId;
+	private String comments;
+	private Date auditDate;
+	private Long userId;
+
+	public AuditLog() {
+		setCreated(new Date());
+	}
+
+	public String getActivityCode() {
+		return activityCode;
+	}
+
+	public String getComments() {
+		return comments;
+	}
+
+	public String getAffectedRecordId() {
+		return affectedRecordId;
+	}
+
+	public void setActivityCode(String activityCode) {
+		this.activityCode = activityCode;
+	}
+
+	public void setComments(String comments) {
+		this.comments = comments;
+	}
+
+	public void setAffectedRecordId(String affectedRecordId) {
+		this.affectedRecordId = affectedRecordId;
+	}
 
 	public Date getAuditDate() {
 		return auditDate;
@@ -118,7 +117,5 @@ public class AuditLog extends DomainVo {
 	public void setUserId(Long userId) {
 		this.userId = userId;
 	}
-    
-    
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/BroadcastMessage.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/BroadcastMessage.java
index d75a030a..01d6caed 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/BroadcastMessage.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/BroadcastMessage.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,106 +37,99 @@
  */
 package org.onap.portalsdk.core.domain;
 
-import java.util.*;
+import java.util.Date;
 
 import org.onap.portalsdk.core.domain.support.DomainVo;
 
 public class BroadcastMessage extends DomainVo {
-	
-	/**
-	 * 
-	 */
-	
-  private static final long serialVersionUID = 1L;
-  public BroadcastMessage() {
-  }
-
-  public static final String ID_MESSAGE_LOCATION_LOGIN   = "10";
-  public static final String ID_MESSAGE_LOCATION_WELCOME = "20";
-
-  private String  messageText;
-  private Integer locationId;
-  private Date    startDate;
-  private Date    endDate;
-  private Integer sortOrder;
-  private Boolean active;
-  private String siteCd;
-
-  public Boolean getActive() {
-      return active;
-  }
-
-  public Date getEndDate() {
-      return endDate;
-  }
-
-  public Integer getLocationId() {
-      return locationId;
-  }
-
-  public String getMessageText() {
-      return messageText;
-  }
-
-  public Integer getSortOrder() {
-      return sortOrder;
-  }
-
-  public Date getStartDate() {
-      return startDate;
-  }
-
-    public String getSiteCd() {
-        return siteCd;
-    }
-
-
-    public void setActive(Boolean active) {
-      this.active = active;
-  }
-
-  public void setEndDate(Date endDate) {
-      this.endDate = endDate;
-  }
-
-  public void setLocationId(Integer locationId) {
-      this.locationId = locationId;
-  }
-
-  public void setMessageText(String messageText) {
-      this.messageText = messageText;
-  }
-
-  public void setSortOrder(Integer sortOrder) {
-      this.sortOrder = sortOrder;
-  }
-
-  public void setStartDate(Date startDate) {
-      this.startDate = startDate;
-  }
-
-  public void setSiteCd(String siteCd) {
-      this.siteCd = siteCd;
-  }
-
-
-  public int compareTo(Object obj){
-    Integer c1 = getLocationId();
-    Integer c2 = ((BroadcastMessage)obj).getLocationId();
-
-    if (c1.compareTo(c2) == 0) {
-      c1 = getSortOrder();
-      c2 = ((BroadcastMessage)obj).getSortOrder();
-
-      if (c1.compareTo(c2) == 0) {
-        Long c3 = getId();
-        Long c4 = ((BroadcastMessage)obj).getId();
-
-        return c3.compareTo(c4);
-      }
-    }
-
-    return c1.compareTo(c2);
-  }
+
+	private static final long serialVersionUID = 1L;
+
+	public static final String ID_MESSAGE_LOCATION_LOGIN = "10";
+	public static final String ID_MESSAGE_LOCATION_WELCOME = "20";
+
+	private String messageText;
+	private Integer locationId;
+	private Date startDate;
+	private Date endDate;
+	private Integer sortOrder;
+	private Boolean active;
+	private String siteCd;
+
+	public Boolean getActive() {
+		return active;
+	}
+
+	public Date getEndDate() {
+		return endDate;
+	}
+
+	public Integer getLocationId() {
+		return locationId;
+	}
+
+	public String getMessageText() {
+		return messageText;
+	}
+
+	public Integer getSortOrder() {
+		return sortOrder;
+	}
+
+	public Date getStartDate() {
+		return startDate;
+	}
+
+	public String getSiteCd() {
+		return siteCd;
+	}
+
+	public void setActive(Boolean active) {
+		this.active = active;
+	}
+
+	public void setEndDate(Date endDate) {
+		this.endDate = endDate;
+	}
+
+	public void setLocationId(Integer locationId) {
+		this.locationId = locationId;
+	}
+
+	public void setMessageText(String messageText) {
+		this.messageText = messageText;
+	}
+
+	public void setSortOrder(Integer sortOrder) {
+		this.sortOrder = sortOrder;
+	}
+
+	public void setStartDate(Date startDate) {
+		this.startDate = startDate;
+	}
+
+	public void setSiteCd(String siteCd) {
+		this.siteCd = siteCd;
+	}
+
+	@Override
+	public int compareTo(Object obj) {
+		Integer c1 = getLocationId();
+		Integer c2 = ((BroadcastMessage) obj).getLocationId();
+
+		if (c1.compareTo(c2) == 0) {
+			c1 = getSortOrder();
+			c2 = ((BroadcastMessage) obj).getSortOrder();
+
+			if (c1.compareTo(c2) == 0) {
+				Long c3 = getId();
+				Long c4 = ((BroadcastMessage) obj).getId();
+
+				return c3.compareTo(c4);
+			}
+		}
+
+		return c1.compareTo(c2);
+	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/DomainVo.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/DomainVo.java
index 355f36cb..2818bf04 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/DomainVo.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/DomainVo.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -48,7 +48,7 @@ import java.util.Set;
 
 /* Super class from which all data objects descend 
  *
- * Per Sunder T on 3 June 2016:
+ * @deprecated per Sunder T on 3 June 2016:
  * 
  * Yes, we need to get rid of domain.DomainVO and fold all the references to the support.DomainVO.
  */
@@ -56,9 +56,6 @@ import java.util.Set;
 @Deprecated
 public class DomainVo extends FusionVo implements Serializable, Cloneable, Comparable {
 
-	/**
-	 * 
-	 */
 	private static final long serialVersionUID = 1L;
 	protected Long id;
 	protected Date created;
@@ -71,9 +68,6 @@ public class DomainVo extends FusionVo implements Serializable, Cloneable, Compa
 
 	Set auditTrail = null;
 
-	public DomainVo() {
-	}
-
 	public void setId(Long i) {
 		id = i;
 	}
@@ -147,10 +141,6 @@ public class DomainVo extends FusionVo implements Serializable, Cloneable, Compa
 		getAuditTrail().add(auditLog);
 	}
 
-	public Object clone() throws CloneNotSupportedException {
-		return super.clone();
-	}
-
 	public Object copy() {
 		return copy(false);
 	}
@@ -185,6 +175,7 @@ public class DomainVo extends FusionVo implements Serializable, Cloneable, Compa
 		return newVo;
 	}
 
+	@Override
 	public int compareTo(Object obj) {
 		Long c1 = getId();
 		Long c2 = ((DomainVo) obj).getId();
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/FnMenu.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/FnMenu.java
index f4ed41e4..894c35f1 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/FnMenu.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/FnMenu.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,123 +37,148 @@
  */
 package org.onap.portalsdk.core.domain;
 
-
 import org.onap.portalsdk.core.domain.support.DomainVo;
 
 /**
- * 
RoleFunction.java

+ * 

+ * RoleFunction.java
+ * 

  *
- * 
Represents a role function data object.

+ * 

+ * Represents a role function data object.
+ * 

  *
  * @version 1.0
  */
 public class FnMenu extends DomainVo {
-	/**
-	 * 
-	 */
+
 	private static final long serialVersionUID = 1L;
-    public FnMenu() {}
-
-    private Integer menuId;
-    private String	label;
-    private Integer parentId;
-    private String	action;
-    private String	functionCd;
-    private Integer sortOrder;
-    private String	servlet;
-    private String	queryString;
-    private String	externalUrl;
-    private String	target;
-    private String	active;
-    private String	separator;
-    private String	imageSrc;
-    private String	menuSetCode;
-    
+
+	private Integer menuId;
+	private String label;
+	private Integer parentId;
+	private String action;
+	private String functionCd;
+	private Integer sortOrder;
+	private String servlet;
+	private String queryString;
+	private String externalUrl;
+	private String target;
+	private String active;
+	private String separator;
+	private String imageSrc;
+	private String menuSetCode;
+
 	public Integer getMenuId() {
 		return menuId;
 	}
+
 	public void setMenuId(Integer menuId) {
 		this.menuId = menuId;
 	}
+
 	public String getLabel() {
 		return label;
 	}
+
 	public void setLabel(String label) {
 		this.label = label;
 	}
+
 	public Integer getParentId() {
 		return parentId;
 	}
+
 	public void setParentId(Integer parentId) {
 		this.parentId = parentId;
 	}
+
 	public String getAction() {
 		return action;
 	}
+
 	public void setAction(String action) {
 		this.action = action;
 	}
+
 	public String getFunctionCd() {
 		return functionCd;
 	}
+
 	public void setFunctionCd(String functionCd) {
 		this.functionCd = functionCd;
 	}
+
 	public Integer getSortOrder() {
 		return sortOrder;
 	}
+
 	public void setSortOrder(Integer sortOrder) {
 		this.sortOrder = sortOrder;
 	}
+
 	public String getServlet() {
 		return servlet;
 	}
+
 	public void setServlet(String servlet) {
 		this.servlet = servlet;
 	}
+
 	public String getQueryString() {
 		return queryString;
 	}
+
 	public void setQueryString(String queryString) {
 		this.queryString = queryString;
 	}
+
 	public String getExternalUrl() {
 		return externalUrl;
 	}
+
 	public void setExternalUrl(String externalUrl) {
 		this.externalUrl = externalUrl;
 	}
+
 	public String getTarget() {
 		return target;
 	}
+
 	public void setTarget(String target) {
 		this.target = target;
 	}
+
 	public String getActive() {
 		return active;
 	}
+
 	public void setActive(String active) {
 		this.active = active;
 	}
+
 	public String getSeparator() {
 		return separator;
 	}
+
 	public void setSeparator(String separator) {
 		this.separator = separator;
 	}
+
 	public String getImageSrc() {
 		return imageSrc;
 	}
+
 	public void setImageSrc(String imageSrc) {
 		this.imageSrc = imageSrc;
 	}
+
 	public String getMenuSetCode() {
 		return menuSetCode;
 	}
+
 	public void setMenuSetCode(String menuSetCode) {
 		this.menuSetCode = menuSetCode;
 	}
-    
-    
-   
+
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/FusionVo.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/FusionVo.java
index bf2321ba..ac25ae10 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/FusionVo.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/FusionVo.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -40,6 +40,7 @@ package org.onap.portalsdk.core.domain;
 import org.onap.portalsdk.core.FusionObject;
 
 public class FusionVo implements FusionObject {
-    public FusionVo() {
-    }
+	public FusionVo() {
+		// No-argument constructor
+	}
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/LoginBean.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/LoginBean.java
index 742f26b6..f6675a01 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/LoginBean.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/LoginBean.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -44,162 +44,169 @@ import org.onap.portalsdk.core.domain.support.FusionCommand;
 @SuppressWarnings("rawtypes")
 public class LoginBean extends FusionCommand {
 
-    private String loginId;
-    private String loginPwd;
-    private String hrid;
-    private String orgUserId;
-    private String siteAccess;
-    private String loginErrorMessage;
-
-    private User user;
-    private Set  menu;
-    private Set  businessDirectMenu;
-
-    /**
-     * getLoginId
-     *
-     * @return String
-     */
-    public String getLoginId() {
-        return loginId;
-    }
-
-    /**
-     * getLoginPwd
-     *
-     * @return String
-     */
-    public String getLoginPwd() {
-        return loginPwd;
-    }
-
-    /**
-     * getMenu
-     *
-     * @return Set
-     */
-    public Set getMenu() {
-        return menu;
-    }
-
-    /**
-     * getUser
-     *
-     * @return User
-     */
-    public User getUser() {
-        return user;
-    }
-
-    /**
-     * getHrid
-     *
-     * @return String
-     */
-    public String getHrid() {
-        return hrid;
-    }
-
-    /**
-     * getSiteAccess
-     *
-     * @return String
-     */
-    public String getSiteAccess() {
-        return siteAccess;
-    }
-
-    /**
-     * getBusinessDirectMenu
-     *
-     * @return Set
-     */
-    public Set getBusinessDirectMenu() {
-        return businessDirectMenu;
-    }
-
-    /**
-     * getLoginErrorMessage
-     *
-     * @return String
-     */
-    public String getLoginErrorMessage() {
-        return loginErrorMessage;
-    }
-
-    public String getOrgUserId() {
-        return orgUserId;
-    }
-
-    /**
-     * setLoginId
-     *
-     * @param loginId String
-     */
-    public void setLoginId(String loginId) {
-        this.loginId = loginId;
-    }
-
-    /**
-     * setLoginPwd
-     *
-     * @param loginPwd String
-     */
-    public void setLoginPwd(String loginPwd) {
-        this.loginPwd = loginPwd;
-    }
-
-    public void setMenu(Set menu) {
-        this.menu = menu;
-    }
-
-    /**
-     * setUser
-     *
-     * @param user User
-     */
-    public void setUser(User user) {
-        this.user = user;
-    }
-
-    /**
-     * setHrid
-     *
-     * @param hrid String
-     */
-    public void setHrid(String hrid) {
-        this.hrid = hrid;
-    }
-
-    /**
-     * setSiteAccess
-     *
-     * @param siteAccess String
-     */
-    public void setSiteAccess(String siteAccess) {
-        this.siteAccess = siteAccess;
-    }
-
-    /**
-     * setBusinessDirectMenu
-     *
-     * @param businessDirectMenu Set
-     */
-    public void setBusinessDirectMenu(Set businessDirectMenu) {
-        this.businessDirectMenu = businessDirectMenu;
-    }
-
-    /**
-     * setLoginErrorMessage
-     *
-     * @param loginErrorMessage String
-     */
-    public void setLoginErrorMessage(String loginErrorMessage) {
-        this.loginErrorMessage = loginErrorMessage;
-    }
-
-    public void setOrgUserId(String orgUserId) {
-        this.orgUserId = orgUserId;
-    }
+	private String loginId;
+	private String loginPwd;
+	private String hrid;
+	private String orgUserId;
+	private String siteAccess;
+	private String loginErrorMessage;
+
+	private User user;
+	private Set menu;
+	private Set businessDirectMenu;
+
+	/**
+	 * getLoginId
+	 *
+	 * @return String
+	 */
+	public String getLoginId() {
+		return loginId;
+	}
+
+	/**
+	 * getLoginPwd
+	 *
+	 * @return String
+	 */
+	public String getLoginPwd() {
+		return loginPwd;
+	}
+
+	/**
+	 * getMenu
+	 *
+	 * @return Set
+	 */
+	public Set getMenu() {
+		return menu;
+	}
+
+	/**
+	 * getUser
+	 *
+	 * @return User
+	 */
+	public User getUser() {
+		return user;
+	}
+
+	/**
+	 * getHrid
+	 *
+	 * @return String
+	 */
+	public String getHrid() {
+		return hrid;
+	}
+
+	/**
+	 * getSiteAccess
+	 *
+	 * @return String
+	 */
+	public String getSiteAccess() {
+		return siteAccess;
+	}
+
+	/**
+	 * getBusinessDirectMenu
+	 *
+	 * @return Set
+	 */
+	public Set getBusinessDirectMenu() {
+		return businessDirectMenu;
+	}
+
+	/**
+	 * getLoginErrorMessage
+	 *
+	 * @return String
+	 */
+	public String getLoginErrorMessage() {
+		return loginErrorMessage;
+	}
+
+	public String getOrgUserId() {
+		return orgUserId;
+	}
+
+	/**
+	 * setLoginId
+	 *
+	 * @param loginId
+	 *            String
+	 */
+	public void setLoginId(String loginId) {
+		this.loginId = loginId;
+	}
+
+	/**
+	 * setLoginPwd
+	 *
+	 * @param loginPwd
+	 *            String
+	 */
+	public void setLoginPwd(String loginPwd) {
+		this.loginPwd = loginPwd;
+	}
+
+	public void setMenu(Set menu) {
+		this.menu = menu;
+	}
+
+	/**
+	 * setUser
+	 *
+	 * @param user
+	 *            User
+	 */
+	public void setUser(User user) {
+		this.user = user;
+	}
+
+	/**
+	 * setHrid
+	 *
+	 * @param hrid
+	 *            String
+	 */
+	public void setHrid(String hrid) {
+		this.hrid = hrid;
+	}
+
+	/**
+	 * setSiteAccess
+	 *
+	 * @param siteAccess
+	 *            String
+	 */
+	public void setSiteAccess(String siteAccess) {
+		this.siteAccess = siteAccess;
+	}
+
+	/**
+	 * setBusinessDirectMenu
+	 *
+	 * @param businessDirectMenu
+	 *            Set
+	 */
+	public void setBusinessDirectMenu(Set businessDirectMenu) {
+		this.businessDirectMenu = businessDirectMenu;
+	}
+
+	/**
+	 * setLoginErrorMessage
+	 *
+	 * @param loginErrorMessage
+	 *            String
+	 */
+	public void setLoginErrorMessage(String loginErrorMessage) {
+		this.loginErrorMessage = loginErrorMessage;
+	}
+
+	public void setOrgUserId(String orgUserId) {
+		this.orgUserId = orgUserId;
+	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/Lookup.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/Lookup.java
index 6248de85..cf7163ca 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/Lookup.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/Lookup.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -44,56 +44,56 @@ import org.onap.portalsdk.core.domain.support.NameValueId;
 
 public class Lookup extends FusionVo implements Serializable {
 
-	/**
-	 * 
-	 */
 	private static final long serialVersionUID = 1L;
-    private NameValueId nameValueId = new NameValueId();
+	private NameValueId nameValueId = new NameValueId();
 
-    public Lookup() {}
+	public Lookup() {
+		super();
+	}
 
-    public Lookup(String label, String value) {
-      this();
-      setLabel(label);
-      setValue(value);
-    }
+	public Lookup(String label, String value) {
+		this();
+		setLabel(label);
+		setValue(value);
+	}
 
-    public String getValue() {
-      return getNameValueId().getVal();
-    }
+	public String getValue() {
+		return getNameValueId().getVal();
+	}
 
-    public String getLabel() {
-      return getNameValueId().getLab();
-    }
+	public String getLabel() {
+		return getNameValueId().getLab();
+	}
 
-    public void setValue(String value) {
-      getNameValueId().setVal(value);
-    }
+	public void setValue(String value) {
+		getNameValueId().setVal(value);
+	}
 
-    public void setLabel(String label) {
-      getNameValueId().setLab(label);
-    }
+	public void setLabel(String label) {
+		getNameValueId().setLab(label);
+	}
 
-    public NameValueId getNameValueId() {
-        return nameValueId;
-    }
+	public NameValueId getNameValueId() {
+		return nameValueId;
+	}
 
-    public void setNameValueId(NameValueId nameValueId) {
-        this.nameValueId = nameValueId;
-    }
+	public void setNameValueId(NameValueId nameValueId) {
+		this.nameValueId = nameValueId;
+	}
 
-    // required by ZK for to set the selectedItems of Listboxes (used heavily for -style drop-downs)
+	@Override
+	public int hashCode() {
+		return Objects.hash(getValue(), getLabel());
+	}
+
+	@Override
+	public boolean equals(Object obj) {
+		if (obj == null || !(obj instanceof Lookup))
+			return false;
+		Lookup lookup = (Lookup) obj;
+		return Objects.equals(lookup.getValue(), getValue()) && Objects.equals(lookup.getLabel(), getLabel());
+	}
 
-    @Override
-    public boolean equals( Object obj ) {
-      if (obj == null || !(obj instanceof Lookup))
-    	  	return false;  
-      Lookup lookup = (Lookup)obj;
-      return Objects.equals(lookup.getValue(), getValue()) && Objects.equals(lookup.getLabel(), getLabel());
-    }
-    
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/LuCountry.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/LuCountry.java
index 2aa8a7db..c3f1c6ed 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/LuCountry.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/LuCountry.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,43 +37,39 @@
  */
 package org.onap.portalsdk.core.domain;
 
-
-import org.onap.portalsdk.core.domain.support.*;
-
-
 /**
- * 
luCountry.java

  *
- * 
Represents a country data object.

+ * 

+ * Represents a country data object.
+ * 

  *
  * @version 1.0
  */
 public class LuCountry extends DomainVo {
 
-	/**
-	 * 
-	 */
 	private static final long serialVersionUID = 1L;
-    LuCountry() {}
+	private String abbr;
+	private String country;
+	private String fullName;
+	private String webphoneCountryLabel;
 
-    public String getCountry() {
-        return country;
-    }
-
-    public String getAbbr() {
-        return abbr;
-    }
+	public String getCountry() {
+		return country;
+	}
 
-    public void setCountry(String country) {
-        this.country = country;
-    }
+	public String getAbbr() {
+		return abbr;
+	}
 
-    public void setAbbr(String abbr) {
-        this.abbr = abbr;
-    }
+	public void setCountry(String country) {
+		this.country = country;
+	}
 
+	public void setAbbr(String abbr) {
+		this.abbr = abbr;
+	}
 
-    public String getFullName() {
+	public String getFullName() {
 		return fullName;
 	}
 
@@ -89,17 +85,11 @@ public class LuCountry extends DomainVo {
 		this.webphoneCountryLabel = webphoneCountryLabel;
 	}
 
-	public int compareTo(Object obj){
-      String c1 = getCountry();
-      String c2 = ((LuCountry)obj).getCountry();
-
-      return c1.compareTo(c2);
-    }
-
-
-    private String abbr;
-    private String country;
-    private String fullName;
-    private String webphoneCountryLabel;
+	@Override
+	public int compareTo(Object obj) {
+		String c1 = getCountry();
+		String c2 = ((LuCountry) obj).getCountry();
+		return c1.compareTo(c2);
+	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/LuState.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/LuState.java
index 23b1ec99..d82eab65 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/LuState.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/LuState.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,52 +37,42 @@
  */
 package org.onap.portalsdk.core.domain;
 
-
-import org.onap.portalsdk.core.domain.support.*;
-
-
 /**
- * 
State.java

- *
- * 
Represents a state data object.

+ * 

+ * Represents a state data object.
+ * 

  *
  * @version 1.0
  */
 public class LuState extends DomainVo {
 
-	/**
-	 * 
-	 */
 	private static final long serialVersionUID = 1L;
-	
-    LuState() {}
-
-    public String getState() {
-        return state;
-    }
-
-    public String getAbbr() {
-        return abbr;
-    }
 
-    public void setState(String state) {
-        this.state = state;
-    }
+	private String abbr;
+	private String state;
 
-    public void setAbbr(String abbr) {
-        this.abbr = abbr;
-    }
+	public String getState() {
+		return state;
+	}
 
+	public String getAbbr() {
+		return abbr;
+	}
 
-    public int compareTo(Object obj){
-      String c1 = getState();
-      String c2 = ((LuState)obj).getState();
+	public void setState(String state) {
+		this.state = state;
+	}
 
-      return c1.compareTo(c2);
-    }
+	public void setAbbr(String abbr) {
+		this.abbr = abbr;
+	}
 
+	@Override
+	public int compareTo(Object obj) {
+		String c1 = getState();
+		String c2 = ((LuState) obj).getState();
 
-    private String abbr;
-    private String state;
+		return c1.compareTo(c2);
+	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/LuTimeZone.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/LuTimeZone.java
index ad17754a..f1494627 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/LuTimeZone.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/LuTimeZone.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,44 +37,41 @@
  */
 package org.onap.portalsdk.core.domain;
 
-
-import org.onap.portalsdk.core.domain.support.*;
-
-
 /**
- * 
LuTimeZone.java

+ * 

+ * LuTimeZone.java
+ * 

  *
- * 
Represents a LuTimeZone data object.

+ * 

+ * Represents a LuTimeZone data object.
+ * 

  *
  * @version 1.0
  */
 public class LuTimeZone extends DomainVo {
 
-	/**
-	 * 
-	 */
 	private static final long serialVersionUID = 1L;
-	
-    LuTimeZone() {}
+	private String name;
+	private Long timezoneId;
+	private String value;
 
-    public String getName() {
-        return name;
-    }
-
-    public String getValue() {
-        return value;
-    }
+	public String getName() {
+		return name;
+	}
 
-    public void setName(String name) {
-        this.name = name;
-    }
+	public String getValue() {
+		return value;
+	}
 
-    public void setValue(String value) {
-        this.value = value;
-    }
+	public void setName(String name) {
+		this.name = name;
+	}
 
+	public void setValue(String value) {
+		this.value = value;
+	}
 
-    public Long getTimezoneId() {
+	public Long getTimezoneId() {
 		return timezoneId;
 	}
 
@@ -82,16 +79,11 @@ public class LuTimeZone extends DomainVo {
 		this.timezoneId = timezoneId;
 	}
 
-	public int compareTo(Object obj){
-      Long c1 = getId();
-      Long c2 = ((LuTimeZone)obj).getId();
-
-      return c1.compareTo(c2);
-    }
-
-
-    private String name;
-    private Long timezoneId;
-    private String value;
+	@Override
+	public int compareTo(Object obj) {
+		Long c1 = getId();
+		Long c2 = ((LuTimeZone) obj).getId();
+		return c1.compareTo(c2);
+	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/Menu.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/Menu.java
index 9f3f83e2..a13f17a4 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/Menu.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/Menu.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,114 +37,124 @@
  */
 package org.onap.portalsdk.core.domain;
 
-
 import org.onap.portalsdk.core.domain.support.DomainVo;
 
 public class Menu extends DomainVo {
-	
-	/**
-	 * 
-	 */
+
 	private static final long serialVersionUID = 1L;
-    public Menu() {}
 
-    public String getAction() {
-        return action;
-    }
+	private String menuLevel;
+	private String label;
+	private Long parentId;
+	private String action;
+	private String functionCd;
+	private Short sortOrder;
+	private String servlet;
+	private String queryString;
+	private String externalUrl;
+	private String target;
+	private boolean active;
+	private String menuSetCode;
+	private boolean separator;
+	private String imageSrc;
+
+	public String getAction() {
+		return action;
+	}
 
-    public boolean isActive() {
-        return active;
-    }
+	public boolean isActive() {
+		return active;
+	}
 
-    public String getExternalUrl() {
-        return externalUrl;
-    }
+	public String getExternalUrl() {
+		return externalUrl;
+	}
 
-    public String getFunctionCd() {
-        return functionCd;
-    }
+	public String getFunctionCd() {
+		return functionCd;
+	}
 
-    public String getLabel() {
-        return label;
-    }
+	public String getLabel() {
+		return label;
+	}
 
-    public String getMenuLevel() {
-        return menuLevel;
-    }
+	public String getMenuLevel() {
+		return menuLevel;
+	}
 
-    public Long getParentId() {
-        return parentId;
-    }
+	public Long getParentId() {
+		return parentId;
+	}
 
-    public String getQueryString() {
-        return queryString;
-    }
+	public String getQueryString() {
+		return queryString;
+	}
 
-    public String getServlet() {
-        return servlet;
-    }
+	public String getServlet() {
+		return servlet;
+	}
 
-    public Short getSortOrder() {
-        return sortOrder;
-    }
+	public Short getSortOrder() {
+		return sortOrder;
+	}
 
-    public String getTarget() {
-        return target;
-    }
+	public String getTarget() {
+		return target;
+	}
 
-    public String getMenuSetCode() {
-        return menuSetCode;
-    }
+	public String getMenuSetCode() {
+		return menuSetCode;
+	}
 
-    public void setAction(String action) {
-        this.action = action;
-    }
+	public void setAction(String action) {
+		this.action = action;
+	}
 
-    public void setActive(boolean active) {
-        this.active = active;
-    }
+	public void setActive(boolean active) {
+		this.active = active;
+	}
 
-    public void setExternalUrl(String externalUrl) {
-        this.externalUrl = externalUrl;
-    }
+	public void setExternalUrl(String externalUrl) {
+		this.externalUrl = externalUrl;
+	}
 
-    public void setFunctionCd(String functionCd) {
-        this.functionCd = functionCd;
-    }
+	public void setFunctionCd(String functionCd) {
+		this.functionCd = functionCd;
+	}
 
-    public void setLabel(String label) {
-        this.label = label;
-    }
+	public void setLabel(String label) {
+		this.label = label;
+	}
 
-    public void setMenuLevel(String menuLevel) {
-        this.menuLevel = menuLevel;
-    }
+	public void setMenuLevel(String menuLevel) {
+		this.menuLevel = menuLevel;
+	}
 
-    public void setParentId(Long parentId) {
-        this.parentId = parentId;
-    }
+	public void setParentId(Long parentId) {
+		this.parentId = parentId;
+	}
 
-    public void setQueryString(String queryString) {
-        this.queryString = queryString;
-    }
+	public void setQueryString(String queryString) {
+		this.queryString = queryString;
+	}
 
-    public void setServlet(String servlet) {
-        this.servlet = servlet;
-    }
+	public void setServlet(String servlet) {
+		this.servlet = servlet;
+	}
 
-    public void setSortOrder(Short sortOrder) {
-        this.sortOrder = sortOrder;
-    }
+	public void setSortOrder(Short sortOrder) {
+		this.sortOrder = sortOrder;
+	}
 
-    public void setTarget(String target) {
-        this.target = target;
-    }
+	public void setTarget(String target) {
+		this.target = target;
+	}
 
-    public void setMenuSetCode(String menuSetCode) {
-        this.menuSetCode = menuSetCode;
-    }
+	public void setMenuSetCode(String menuSetCode) {
+		this.menuSetCode = menuSetCode;
+	}
 
-    public boolean isSeparator() {
+	public boolean isSeparator() {
 		return separator;
 	}
 
@@ -160,19 +170,4 @@ public class Menu extends DomainVo {
 		this.imageSrc = imageSrc;
 	}
 
-	private String  menuLevel;
-    private String  label;
-    private Long    parentId;
-	private String  action;
-    private String  functionCd;
-    private Short   sortOrder;
-    private String  servlet;
-    private String  queryString;
-    private String  externalUrl;
-    private String  target;
-    private boolean active;
-    private String  menuSetCode;
-    private boolean separator;
-    private String  imageSrc;
-
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/MenuData.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/MenuData.java
index 8967b4f4..be8264a6 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/MenuData.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/MenuData.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,54 +37,51 @@
  */
 package org.onap.portalsdk.core.domain;
 
-import java.util.*;
+import java.util.Set;
+import java.util.TreeSet;
 
 public class MenuData extends Menu {
 
-	/**
-	 * 
-	 */
-  private static final long serialVersionUID = 1L;
-  private MenuData parentMenu;
-  private Set      childMenus = new TreeSet();
+	private static final long serialVersionUID = 1L;
+	private MenuData parentMenu;
+	private Set childMenus = new TreeSet();
 
-  public MenuData() {}
+	public MenuData() {
+	}
 
-  public Set getChildMenus() {
-      return childMenus;
-  }
+	public Set getChildMenus() {
+		return childMenus;
+	}
 
-  public MenuData getParentMenu() {
-      return parentMenu;
-  }
+	public void setChildMenus(Set childMenus) {
+		this.childMenus = childMenus;
+	}
 
-  public void setChildMenus(Set childMenus) {
-      this.childMenus = childMenus;
-  }
+	public MenuData getParentMenu() {
+		return parentMenu;
+	}
 
-  public void setParentMenu(MenuData parentMenu) {
-      this.parentMenu = parentMenu;
-  }
+	public void setParentMenu(MenuData parentMenu) {
+		this.parentMenu = parentMenu;
+	}
 
-  public int compareTo(Object obj){
+	public String getActiveAsString() {
+		return String.valueOf(isActive());
+	}
 
-    Short c1 = getSortOrder();
-    Short c2 = ((MenuData)obj).getSortOrder();
-    
-    return (c1 == null || c2 == null) ? 1 : ((c1.compareTo(c2) == 0) ? 1 : c1.compareTo(c2));
-  }
-  
-  public String getActiveAsString(){
-	  return String.valueOf(isActive());
-  }
+	public String getParentIdAsString() {
+		return String.valueOf(getParentId());
+	}
 
-  public String getParentIdAsString(){
-	  return String.valueOf(getParentId());
-  }
-
-  public String getSeparatorAsString(){
-	  return String.valueOf(isSeparator());
-  }
+	public String getSeparatorAsString() {
+		return String.valueOf(isSeparator());
+	}
 
+	@Override
+	public int compareTo(Object obj) {
+		Short c1 = getSortOrder();
+		Short c2 = ((MenuData) obj).getSortOrder();
+		return (c1 == null || c2 == null) ? 1 : ((c1.compareTo(c2) == 0) ? 1 : c1.compareTo(c2));
+	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/Profile.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/Profile.java
index 02d1c838..9df131de 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/Profile.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/Profile.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -36,9 +36,10 @@
  * ECOMP is a trademark and service mark of AT&T Intellectual Property.
  */
 package org.onap.portalsdk.core.domain;
+
 import org.onap.portalsdk.core.domain.support.DomainVo;
 
-public class Profile extends DomainVo{
+public class Profile extends DomainVo {
 
 	private static final long serialVersionUID = 3409056457412656883L;
 
@@ -49,19 +50,17 @@ public class Profile extends DomainVo{
 	private String orgManagerUserId;
 	private String active_yn;
 	private String orgUserId;
-    public Profile() {}
-
 
+	@Override
 	public Long getId() {
 		return id;
 	}
 
-
+	@Override
 	public void setId(Long id) {
 		this.id = id;
 	}
 
-
 	public String getFirst_name() {
 		return first_name;
 	}
@@ -109,6 +108,5 @@ public class Profile extends DomainVo{
 	public void setOrgUserId(String orgUserId) {
 		this.orgUserId = orgUserId;
 	}
-	
-	
+
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/Role.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/Role.java
index b2cdce05..2d772943 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/Role.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/Role.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,7 +37,6 @@
  */
 package org.onap.portalsdk.core.domain;
 
-
 import java.util.Iterator;
 import java.util.Set;
 import java.util.TreeSet;
@@ -47,146 +46,140 @@ import org.onap.portalsdk.core.domain.support.DomainVo;
 import com.fasterxml.jackson.annotation.JsonIgnore;
 
 /**
- * 
Role.java

- * 
Represents a role data object.

+ * 

+ * Role.java
+ * 

+ * 

+ * Represents a role data object.
+ * 

  *
  * @version 1.0
  */
 public class Role extends DomainVo {
 
-	/**
-	 * 
-	 */
 	private static final long serialVersionUID = 1L;
-    private String  name;
-    private boolean active;
-    private Integer priority;
-
-    private Set     roleFunctions = new TreeSet();
-    
-    private Set     childRoles    = new TreeSet();
-    @JsonIgnore
-    private Set     parentRoles    = new TreeSet();
-
-    public Role() {}
-
-    public String getName() {
-        return name;
-    }
-
-    public boolean getActive() {
-        return active;
-    }
-
-    public Set getRoleFunctions() {
-        return roleFunctions;
-    }
-
-    public Integer getPriority() {
-        return priority;
-    }
-
-    public Set getChildRoles() {
-        return childRoles;
-    }
-
-    public Set getParentRoles() {
-        return parentRoles;
-    }
-
-    public void setName(String name) {
-        this.name = name;
-    }
-
-    public void setActive(boolean active) {
-        this.active = active;
-    }
-
-    public void setRoleFunctions(Set roleFunctions) {
-        this.roleFunctions = roleFunctions;
-    }
-
-    public void setPriority(Integer priority) {
-        this.priority = priority;
-    }
-
-    
-    public void setChildRoles(Set childRoles) {
-        this.childRoles = childRoles;
-    }
-
-    public void setParentRoles(Set parentRoles) {
-        this.parentRoles = parentRoles;
-    }
-    
-    @SuppressWarnings("unchecked")
-    public void addRoleFunction(RoleFunction roleFunction) {
-        this.roleFunctions.add(roleFunction);
-    }
-
-    @SuppressWarnings("unchecked")
-    public void addChildRole(Role role) {
-        this.childRoles.add(role);
-    }
-
-    @SuppressWarnings("unchecked")
-    public void addParentRole(Role role) {
-        this.parentRoles.add(role);
-    }
-
-    public String getEditUrl() {
-        return "/role.htm?role_id=" + getId();    	
-    }
-    
+	private String name;
+	private boolean active;
+	private Integer priority;
+
+	private Set roleFunctions = new TreeSet();
+	private Set childRoles = new TreeSet();
+	@JsonIgnore
+	private Set parentRoles = new TreeSet();
+
+	public String getName() {
+		return name;
+	}
+
+	public boolean getActive() {
+		return active;
+	}
+
+	public Set getRoleFunctions() {
+		return roleFunctions;
+	}
+
+	public Integer getPriority() {
+		return priority;
+	}
+
+	public Set getChildRoles() {
+		return childRoles;
+	}
+
+	public Set getParentRoles() {
+		return parentRoles;
+	}
+
+	public void setName(String name) {
+		this.name = name;
+	}
+
+	public void setActive(boolean active) {
+		this.active = active;
+	}
+
+	public void setRoleFunctions(Set roleFunctions) {
+		this.roleFunctions = roleFunctions;
+	}
+
+	public void setPriority(Integer priority) {
+		this.priority = priority;
+	}
+
+	public void setChildRoles(Set childRoles) {
+		this.childRoles = childRoles;
+	}
+
+	public void setParentRoles(Set parentRoles) {
+		this.parentRoles = parentRoles;
+	}
+
+	@SuppressWarnings("unchecked")
+	public void addRoleFunction(RoleFunction roleFunction) {
+		this.roleFunctions.add(roleFunction);
+	}
+
+	@SuppressWarnings("unchecked")
+	public void addChildRole(Role role) {
+		this.childRoles.add(role);
+	}
+
+	@SuppressWarnings("unchecked")
+	public void addParentRole(Role role) {
+		this.parentRoles.add(role);
+	}
+
+	public String getEditUrl() {
+		return "/role.htm?role_id=" + getId();
+	}
+
 	public String getToggleActiveImage() {
-		return "/static/fusion/images/" + (getActive() ? "active.png" : "inactive.png" );
+		return "/static/fusion/images/" + (getActive() ? "active.png" : "inactive.png");
 	}
 
 	public String getToggleActiveAltText() {
 		return getActive() ? "Click to Deactivate Role" : "Click to Activate Role";
 	}
-    
-    public void removeChildRole(Long roleId) {
-      Iterator i = this.childRoles.iterator();
-
-      while (i.hasNext()) {
-        Role childRole = (Role)i.next();
-        if (childRole.getId().equals(roleId)) {
-          this.childRoles.remove(childRole);
-          break;
-        }
-      }
-    }
-
-    public void removeParentRole(Long roleId) {
-        Iterator i = this.parentRoles.iterator();
-
-        while (i.hasNext()) {
-          Role parentRole = (Role)i.next();
-          if (parentRole.getId().equals(roleId)) {
-            this.parentRoles.remove(parentRole);
-            break;
-          }
-        }
-      }
-
-    public void removeRoleFunction(String roleFunctionCd) {
-      Iterator i = this.roleFunctions.iterator();
-
-      while (i.hasNext()) {
-        RoleFunction roleFunction = (RoleFunction)i.next();
-        if (roleFunction.getCode().equals(roleFunctionCd)) {
-          this.roleFunctions.remove(roleFunction);
-          break;
-        }
-      }
-    }
-
-    public int compareTo(Object obj){
-      String c1 = getName();
-      String c2 = ((Role)obj).getName();
-
-      return (c1 == null || c2 == null) ? 1 : c1.compareTo(c2);
-    }
-    
+
+	public void removeChildRole(Long roleId) {
+		Iterator i = this.childRoles.iterator();
+		while (i.hasNext()) {
+			Role childRole = (Role) i.next();
+			if (childRole.getId().equals(roleId)) {
+				this.childRoles.remove(childRole);
+				break;
+			}
+		}
+	}
+
+	public void removeParentRole(Long roleId) {
+		Iterator i = this.parentRoles.iterator();
+		while (i.hasNext()) {
+			Role parentRole = (Role) i.next();
+			if (parentRole.getId().equals(roleId)) {
+				this.parentRoles.remove(parentRole);
+				break;
+			}
+		}
+	}
+
+	public void removeRoleFunction(String roleFunctionCd) {
+		Iterator i = this.roleFunctions.iterator();
+		while (i.hasNext()) {
+			RoleFunction roleFunction = (RoleFunction) i.next();
+			if (roleFunction.getCode().equals(roleFunctionCd)) {
+				this.roleFunctions.remove(roleFunction);
+				break;
+			}
+		}
+	}
+
+	@Override
+	public int compareTo(Object obj) {
+		String c1 = getName();
+		String c2 = ((Role) obj).getName();
+		return (c1 == null || c2 == null) ? 1 : c1.compareTo(c2);
+	}
+
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/RoleFunction.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/RoleFunction.java
index 448cc232..1114bca0 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/RoleFunction.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/RoleFunction.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,53 +37,50 @@
  */
 package org.onap.portalsdk.core.domain;
 
-
 import org.onap.portalsdk.core.domain.support.DomainVo;
 
 /**
- * 
RoleFunction.java

+ * 

+ * RoleFunction.java
+ * 

  *
- * 
Represents a role function data object.

+ * 

+ * Represents a role function data object.
+ * 

  *
  * @version 1.0
  */
 public class RoleFunction extends DomainVo {
-	
-	/**
-	 * 
-	 */
-	private static final long serialVersionUID = 1L;
-    public RoleFunction() {}
 
-    public String getName() {
-        return name;
-    }
+	private static final long serialVersionUID = 1L;
+	private String code;
+	private String name;
 
-    public String getCode() {
-        return code;
-    }
+	public String getName() {
+		return name;
+	}
 
-    public void setName(String name) {
-        this.name = name;
-    }
+	public String getCode() {
+		return code;
+	}
 
-    public void setCode(String code) {
-        this.code = code;
-    }
+	public void setName(String name) {
+		this.name = name;
+	}
 
-    public String getEditUrl() {
-      return "/role_function.htm?role_function_id=" + getCode();    	
-    }
-    
-    public int compareTo(Object obj){
-      String c1 = getName();
-      String c2 = ((RoleFunction)obj).getName();
+	public void setCode(String code) {
+		this.code = code;
+	}
 
-      return (c1 == null || c2 == null) ? 1 : c1.compareTo(c2);
-    }
+	public String getEditUrl() {
+		return "/role_function.htm?role_function_id=" + getCode();
+	}
 
-    private String code;
-    private String name;
-    private String editUrl;
+	@Override
+	public int compareTo(Object obj) {
+		String c1 = getName();
+		String c2 = ((RoleFunction) obj).getName();
+		return (c1 == null || c2 == null) ? 1 : c1.compareTo(c2);
+	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/UrlsAccessible.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/UrlsAccessible.java
index f7237ed5..55fe3624 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/UrlsAccessible.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/UrlsAccessible.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -42,55 +42,54 @@ import java.util.Objects;
 
 public class UrlsAccessible extends FusionVo implements Serializable {
 
-	/**
-	 * 
-	 */
 	private static final long serialVersionUID = 1L;
-    private UrlsAccessibleKey urlsAccessibleKey = new UrlsAccessibleKey();
+	private UrlsAccessibleKey urlsAccessibleKey = new UrlsAccessibleKey();
 
-    public UrlsAccessible() {}
+	public UrlsAccessible() {
+		super();
+	}
 
-    public UrlsAccessible(String url, String functionCd) {
-      this();
-      setUrl(url);
-      setFunctionCd(functionCd);
-    }
+	public UrlsAccessible(String url, String functionCd) {
+		this();
+		setUrl(url);
+		setFunctionCd(functionCd);
+	}
 
-    public String getUrl() {
-      return getUrlsAccessibleKey().getUrl();
-    }
+	public String getUrl() {
+		return getUrlsAccessibleKey().getUrl();
+	}
 
-    public String getFunctionCd() {
-      return getUrlsAccessibleKey().getFunctionCd();
-    }
+	public String getFunctionCd() {
+		return getUrlsAccessibleKey().getFunctionCd();
+	}
 
-    public void setUrl(String url) {
-    	getUrlsAccessibleKey().setUrl(url);
-    }
+	public void setUrl(String url) {
+		getUrlsAccessibleKey().setUrl(url);
+	}
 
-    public void setFunctionCd(String functionCd) {
-    	getUrlsAccessibleKey().setFunctionCd(functionCd);
-    }
+	public void setFunctionCd(String functionCd) {
+		getUrlsAccessibleKey().setFunctionCd(functionCd);
+	}
 
-    public UrlsAccessibleKey getUrlsAccessibleKey() {
-        return urlsAccessibleKey;
-    }
+	public UrlsAccessibleKey getUrlsAccessibleKey() {
+		return urlsAccessibleKey;
+	}
 
-    public void setUrlsAccessibleKey(UrlsAccessibleKey urlsAccessibleKey) {
-        this.urlsAccessibleKey = urlsAccessibleKey;
-    }
+	public void setUrlsAccessibleKey(UrlsAccessibleKey urlsAccessibleKey) {
+		this.urlsAccessibleKey = urlsAccessibleKey;
+	}
 
-    @Override
-    public int hashCode() {
-    		return Objects.hash(getUrl(), getFunctionCd());
-    }
+	@Override
+	public int hashCode() {
+		return Objects.hash(getUrl(), getFunctionCd());
+	}
+
+	@Override
+	public boolean equals(Object obj) {
+		if (obj == null || !(obj instanceof UrlsAccessible))
+			return false;
+		UrlsAccessible ua = (UrlsAccessible) obj;
+		return Objects.equals(ua.getUrl(), getUrl()) && Objects.equals(ua.getFunctionCd(), getFunctionCd());
+	}
 
-    @Override
-    public boolean equals( Object obj ) {
-      if (obj == null || !(obj instanceof UrlsAccessible))
-    	  	return false;  
-      UrlsAccessible ua = (UrlsAccessible)obj;
-      return Objects.equals(ua.getUrl(), getUrl()) && Objects.equals(ua.getFunctionCd(), getFunctionCd());
-    }
-   
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/UrlsAccessibleKey.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/UrlsAccessibleKey.java
index e7bdc5a6..59732b27 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/UrlsAccessibleKey.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/UrlsAccessibleKey.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,72 +37,57 @@
  */
 package org.onap.portalsdk.core.domain;
 
-import java.io.*;
-
+import java.io.Serializable;
 
 public class UrlsAccessibleKey implements Serializable {
 
-	/**
-	 * 
-	 */
 	private static final long serialVersionUID = 1L;
-    private String url;
-    private String functionCd;
-
-    public UrlsAccessibleKey() {
-    }
-
-    public UrlsAccessibleKey(String url, String functionCd) {
-      setUrl(url);
-      setFunctionCd(functionCd);
-    }
-
-
-    public String getUrl() {
-        return url;
-    }
-
-
-    public String getFunctionCd() {
-        return functionCd;
-    }
-
-
-    public void setUrl(String url) {
-        this.url = url;
-    }
-
-
-    public void setFunctionCd(String functionCd) {
-        this.functionCd = functionCd;
-    }
-
-
-    public boolean equals(Object o) {
-      if (this == o) {
-        return true;
-      }
-
-      if (o == null) {
-        return false;
-      }
-
-      if (!(o instanceof UrlsAccessibleKey)) {
-        return false;
-      }
-
-      final UrlsAccessibleKey key = (UrlsAccessibleKey)o;
-
-      if (getFunctionCd().equals(key.getFunctionCd()) & getUrl().equals(key.getUrl())) {
-        return true;
-      }
-
-      return false;
-    }
-
-
-    public int hashCode() {
-      return getUrl().hashCode() + getFunctionCd().hashCode();
-    }
+	private String url;
+	private String functionCd;
+
+	public UrlsAccessibleKey() {
+		super();
+	}
+
+	public UrlsAccessibleKey(String url, String functionCd) {
+		setUrl(url);
+		setFunctionCd(functionCd);
+	}
+
+	public String getUrl() {
+		return url;
+	}
+
+	public String getFunctionCd() {
+		return functionCd;
+	}
+
+	public void setUrl(String url) {
+		this.url = url;
+	}
+
+	public void setFunctionCd(String functionCd) {
+		this.functionCd = functionCd;
+	}
+
+	@Override
+	public boolean equals(Object o) {
+		if (this == o) 
+			return true;
+		if (o == null) 
+			return false;
+		if (!(o instanceof UrlsAccessibleKey)) 
+			return false;
+		final UrlsAccessibleKey key = (UrlsAccessibleKey) o;
+		if (getFunctionCd().equals(key.getFunctionCd()) && getUrl().equals(key.getUrl()))
+			return true;
+
+		return false;
+	}
+
+	@Override
+	public int hashCode() {
+		return getUrl().hashCode() + getFunctionCd().hashCode();
+	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/User.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/User.java
index a72f1d6a..6d823817 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/User.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/User.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,7 +37,6 @@
  */
 package org.onap.portalsdk.core.domain;
 
-
 import java.util.Date;
 import java.util.Iterator;
 import java.util.Set;
@@ -47,374 +46,370 @@ import java.util.TreeSet;
 import org.onap.portalsdk.core.domain.support.DomainVo;
 
 /**
- * 
User.java

+ * 

+ * User.java
+ * 

  *
- * 
Represents a user data object.

+ * 

+ * Represents a user data object.
+ * 

  *
  * @version 1.0
  */
 public class User extends DomainVo {
-    
-	/**
-	 * 
-	 */
+
 	private static final long serialVersionUID = 1L;
-    private Long   orgId;
-    private Long   managerId;
-    private String firstName;
-    private String middleInitial;
-    private String lastName;
-    private String phone;
-    private String fax;
-    private String cellular;
-    private String email;
-    private Long   addressId;
-    private String alertMethodCd;
-    private String hrid;
-    private String orgUserId;
-    private String orgCode;
-    private String address1;
-    private String address2;
-    private String city;
-    private String state;
-    private String zipCode;
-    private String country;
-    private String orgManagerUserId;
-    private String locationClli;
-    private String businessCountryCode;
-    private String businessCountryName;
-    private String businessUnit;
-    private String businessUnitName;
-    private String department;
-    private String departmentName;
-    private String companyCode;
-    private String company;
-    private String zipCodeSuffix;
-    private String jobTitle;
-    private String commandChain;
-    private String siloStatus;
-    private String costCenter;
-    private String financialLocCode;
-    
-    
-  
-    private String loginId;
-    private String loginPwd;
-    private Date   lastLoginDate;
-    private boolean active;
-    private boolean internal;
-    private Long    selectedProfileId;
-    private Long timeZoneId;
-    private boolean online;
-    private String chatId;
-    
-    private Set     userApps       = new TreeSet();
-    
-    private Set     pseudoRoles = new TreeSet();
-
-
-    public User() {}
-
-    public Long getAddressId() {
-        return addressId;
-    }
-
-    public String getAlertMethodCd() {
-        return alertMethodCd;
-    }
-
-    public String getCellular() {
-        return cellular;
-    }
-
-    public String getEmail() {
-        return email;
-    }
-
-    public String getFax() {
-        return fax;
-    }
-
-    public String getFirstName() {
-        return firstName;
-    }
-
-    public String getHrid() {
-        return hrid;
-    }
-
-    public Date getLastLoginDate() {
-        return lastLoginDate;
-    }
-
-    public String getLastName() {
-        return lastName;
-    }
-
-    public String getFullName() {
-        return getFirstName() + " " + getLastName();	
-    }
-    
-    public String getLoginId() {
-        return loginId;
-    }
-
-    public String getLoginPwd() {
-        return loginPwd;
-    }
-
-    public Long getManagerId() {
-        return managerId;
-    }
-
-    public String getMiddleInitial() {
-        return middleInitial;
-    }
-
-    public String getOrgCode() {
-        return orgCode;
-    }
-
-    public Long getOrgId() {
-        return orgId;
-    }
-
-    public String getPhone() {
-        return phone;
-    }
-
-    public String getOrgUserId() {
-        return orgUserId;
-    }
-
-    public boolean getActive() {
-        return active;
-    }
-
-    public boolean getInternal() {
-        return internal;
-    }
-
-    public String getAddress1() {
-        return address1;
-    }
-
-    public String getAddress2() {
-        return address2;
-    }
-
-    public String getCity() {
-        return city;
-    }
+	private Long orgId;
+	private Long managerId;
+	private String firstName;
+	private String middleInitial;
+	private String lastName;
+	private String phone;
+	private String fax;
+	private String cellular;
+	private String email;
+	private Long addressId;
+	private String alertMethodCd;
+	private String hrid;
+	private String orgUserId;
+	private String orgCode;
+	private String address1;
+	private String address2;
+	private String city;
+	private String state;
+	private String zipCode;
+	private String country;
+	private String orgManagerUserId;
+	private String locationClli;
+	private String businessCountryCode;
+	private String businessCountryName;
+	private String businessUnit;
+	private String businessUnitName;
+	private String department;
+	private String departmentName;
+	private String companyCode;
+	private String company;
+	private String zipCodeSuffix;
+	private String jobTitle;
+	private String commandChain;
+	private String siloStatus;
+	private String costCenter;
+	private String financialLocCode;
+
+	private String loginId;
+	private String loginPwd;
+	private Date lastLoginDate;
+	private boolean active;
+	private boolean internal;
+	private Long selectedProfileId;
+	private Long timeZoneId;
+	private boolean online;
+	private String chatId;
+
+	private Set userApps = new TreeSet();
+
+	private Set pseudoRoles = new TreeSet();
+
+	public Long getAddressId() {
+		return addressId;
+	}
+
+	public String getAlertMethodCd() {
+		return alertMethodCd;
+	}
+
+	public String getCellular() {
+		return cellular;
+	}
+
+	public String getEmail() {
+		return email;
+	}
+
+	public String getFax() {
+		return fax;
+	}
+
+	public String getFirstName() {
+		return firstName;
+	}
+
+	public String getHrid() {
+		return hrid;
+	}
+
+	public Date getLastLoginDate() {
+		return lastLoginDate;
+	}
+
+	public String getLastName() {
+		return lastName;
+	}
+
+	public String getFullName() {
+		return getFirstName() + " " + getLastName();
+	}
+
+	public String getLoginId() {
+		return loginId;
+	}
+
+	public String getLoginPwd() {
+		return loginPwd;
+	}
+
+	public Long getManagerId() {
+		return managerId;
+	}
+
+	public String getMiddleInitial() {
+		return middleInitial;
+	}
 
-    public String getCountry() {
-        return country;
-    }
+	public String getOrgCode() {
+		return orgCode;
+	}
 
-    public String getState() {
-        return state;
-    }
+	public Long getOrgId() {
+		return orgId;
+	}
 
-    public String getZipCode() {
-        return zipCode;
-    }
+	public String getPhone() {
+		return phone;
+	}
 
-    public String getBusinessCountryCode() {
-        return businessCountryCode;
-    }
+	public String getOrgUserId() {
+		return orgUserId;
+	}
 
-    public String getCommandChain() {
-        return commandChain;
-    }
+	public boolean getActive() {
+		return active;
+	}
 
-    public String getCompany() {
-        return company;
-    }
+	public boolean getInternal() {
+		return internal;
+	}
 
-    public String getCompanyCode() {
-        return companyCode;
-    }
+	public String getAddress1() {
+		return address1;
+	}
 
-    public String getDepartment() {
-        return department;
-    }
+	public String getAddress2() {
+		return address2;
+	}
 
-    public String getJobTitle() {
-        return jobTitle;
-    }
+	public String getCity() {
+		return city;
+	}
+
+	public String getCountry() {
+		return country;
+	}
+
+	public String getState() {
+		return state;
+	}
+
+	public String getZipCode() {
+		return zipCode;
+	}
+
+	public String getBusinessCountryCode() {
+		return businessCountryCode;
+	}
+
+	public String getCommandChain() {
+		return commandChain;
+	}
+
+	public String getCompany() {
+		return company;
+	}
+
+	public String getCompanyCode() {
+		return companyCode;
+	}
+
+	public String getDepartment() {
+		return department;
+	}
+
+	public String getJobTitle() {
+		return jobTitle;
+	}
+
+	public String getLocationClli() {
+		return locationClli;
+	}
 
-    public String getLocationClli() {
-        return locationClli;
-    }
+	public String getOrgManagerUserId() {
+		return orgManagerUserId;
+	}
 
-    public String getOrgManagerUserId() {
-        return orgManagerUserId;
-    }
+	public String getZipCodeSuffix() {
+		return zipCodeSuffix;
+	}
 
-    public String getZipCodeSuffix() {
-        return zipCodeSuffix;
-    }
+	public String getBusinessCountryName() {
+		return businessCountryName;
+	}
 
-    public String getBusinessCountryName() {
-        return businessCountryName;
-    }
+	public Set getPseudoRoles() {
+		return pseudoRoles;
+	}
 
-    public Set getPseudoRoles() {
-        return pseudoRoles;
-    }
+	public Long getSelectedProfileId() {
+		return selectedProfileId;
+	}
 
-    public Long getSelectedProfileId() {
-        return selectedProfileId;
-    }
+	public void setAddressId(Long addressId) {
+		this.addressId = addressId;
+	}
 
-    public void setAddressId(Long addressId) {
-        this.addressId = addressId;
-    }
+	public void setAlertMethodCd(String alertMethodCd) {
+		this.alertMethodCd = alertMethodCd;
+	}
 
-    public void setAlertMethodCd(String alertMethodCd) {
-        this.alertMethodCd = alertMethodCd;
-    }
+	public void setCellular(String cellular) {
+		this.cellular = cellular;
+	}
 
-    public void setCellular(String cellular) {
-        this.cellular = cellular;
-    }
+	public void setEmail(String email) {
+		this.email = email;
+	}
 
-    public void setEmail(String email) {
-        this.email = email;
-    }
+	public void setFax(String fax) {
+		this.fax = fax;
+	}
 
-    public void setFax(String fax) {
-        this.fax = fax;
-    }
+	public void setFirstName(String firstName) {
+		this.firstName = firstName;
+	}
 
-    public void setFirstName(String firstName) {
-        this.firstName = firstName;
-    }
+	public void setHrid(String hrid) {
+		this.hrid = hrid;
+	}
 
-    public void setHrid(String hrid) {
-        this.hrid = hrid;
-    }
+	public void setLastLoginDate(Date lastLoginDate) {
+		this.lastLoginDate = lastLoginDate;
+	}
 
-    public void setLastLoginDate(Date lastLoginDate) {
-        this.lastLoginDate = lastLoginDate;
-    }
+	public void setLastName(String lastName) {
+		this.lastName = lastName;
+	}
 
-    public void setLastName(String lastName) {
-        this.lastName = lastName;
-    }
+	public void setLoginId(String loginId) {
+		this.loginId = loginId;
+	}
 
-    public void setLoginId(String loginId) {
-        this.loginId = loginId;
-    }
+	public void setLoginPwd(String loginPwd) {
+		this.loginPwd = loginPwd;
+	}
 
-    public void setLoginPwd(String loginPwd) {
-        this.loginPwd = loginPwd;
-    }
+	public void setManagerId(Long managerId) {
+		this.managerId = managerId;
+	}
 
-    public void setManagerId(Long managerId) {
-        this.managerId = managerId;
-    }
+	public void setMiddleInitial(String middleInitial) {
+		this.middleInitial = middleInitial;
+	}
 
-    public void setMiddleInitial(String middleInitial) {
-        this.middleInitial = middleInitial;
-    }
+	public void setOrgCode(String orgCode) {
+		this.orgCode = orgCode;
+	}
 
-    public void setOrgCode(String orgCode) {
-        this.orgCode = orgCode;
-    }
+	public void setOrgId(Long orgId) {
+		this.orgId = orgId;
+	}
 
-    public void setOrgId(Long orgId) {
-        this.orgId = orgId;
-    }
+	public void setPhone(String phone) {
+		this.phone = phone;
+	}
 
-    public void setPhone(String phone) {
-        this.phone = phone;
-    }
+	public void setOrgUserId(String orgUserId) {
+		this.orgUserId = orgUserId;
+	}
 
-    public void setOrgUserId(String orgUserId) {
-        this.orgUserId = orgUserId;
-    }
+	public void setActive(boolean active) {
+		this.active = active;
+	}
 
-    public void setActive(boolean active) {
-        this.active = active;
-    }
+	public void setInternal(boolean internal) {
+		this.internal = internal;
+	}
 
-    public void setInternal(boolean internal) {
-        this.internal = internal;
-    }
+	public void setAddress1(String address1) {
+		this.address1 = address1;
+	}
 
-    public void setAddress1(String address1) {
-        this.address1 = address1;
-    }
+	public void setAddress2(String address2) {
+		this.address2 = address2;
+	}
 
-    public void setAddress2(String address2) {
-        this.address2 = address2;
-    }
+	public void setCity(String city) {
+		this.city = city;
+	}
 
-    public void setCity(String city) {
-        this.city = city;
-    }
+	public void setCountry(String country) {
+		this.country = country;
+	}
 
-    public void setCountry(String country) {
-        this.country = country;
-    }
+	public void setState(String state) {
+		this.state = state;
+	}
 
-    public void setState(String state) {
-        this.state = state;
-    }
+	public void setZipCode(String zipCode) {
+		this.zipCode = zipCode;
+	}
 
-    public void setZipCode(String zipCode) {
-        this.zipCode = zipCode;
-    }
+	public void setBusinessCountryCode(String businessCountryCode) {
+		this.businessCountryCode = businessCountryCode;
+	}
 
-    public void setBusinessCountryCode(String businessCountryCode) {
-        this.businessCountryCode = businessCountryCode;
-    }
+	public void setCommandChain(String commandChain) {
+		this.commandChain = commandChain;
+	}
 
-    public void setCommandChain(String commandChain) {
-        this.commandChain = commandChain;
-    }
+	public void setCompany(String company) {
+		this.company = company;
+	}
 
-    public void setCompany(String company) {
-        this.company = company;
-    }
+	public void setCompanyCode(String companyCode) {
+		this.companyCode = companyCode;
+	}
 
-    public void setCompanyCode(String companyCode) {
-        this.companyCode = companyCode;
-    }
+	public void setDepartment(String department) {
+		this.department = department;
+	}
 
-    public void setDepartment(String department) {
-        this.department = department;
-    }
+	public void setJobTitle(String jobTitle) {
+		this.jobTitle = jobTitle;
+	}
 
-    public void setJobTitle(String jobTitle) {
-        this.jobTitle = jobTitle;
-    }
+	public void setLocationClli(String locationClli) {
+		this.locationClli = locationClli;
+	}
 
-    public void setLocationClli(String locationClli) {
-        this.locationClli = locationClli;
-    }
+	public void setOrgManagerUserId(String orgManagerUserId) {
+		this.orgManagerUserId = orgManagerUserId;
+	}
 
-    public void setOrgManagerUserId(String orgManagerUserId) {
-        this.orgManagerUserId = orgManagerUserId;
-    }
+	public void setZipCodeSuffix(String zipCodeSuffix) {
+		this.zipCodeSuffix = zipCodeSuffix;
+	}
 
-    public void setZipCodeSuffix(String zipCodeSuffix) {
-        this.zipCodeSuffix = zipCodeSuffix;
-    }
+	public void setBusinessCountryName(String businessCountryName) {
+		this.businessCountryName = businessCountryName;
+	}
 
-    public void setBusinessCountryName(String businessCountryName) {
-        this.businessCountryName = businessCountryName;
-    }
+	public void setPseudoRoles(Set pseudoRoles) {
+		this.pseudoRoles = pseudoRoles;
+	}
 
-    public void setPseudoRoles(Set pseudoRoles) {
-        this.pseudoRoles = pseudoRoles;
-    }
+	public void setSelectedProfileId(Long selectedProfileId) {
+		this.selectedProfileId = selectedProfileId;
+	}
 
-    public void setSelectedProfileId(Long selectedProfileId) {
-        this.selectedProfileId = selectedProfileId;
-    }
-    
 	public Long getTimeZoneId() {
 		return timeZoneId;
 	}
@@ -454,7 +449,7 @@ public class User extends DomainVo {
 	public void setFinancialLocCode(String financialLocCode) {
 		this.financialLocCode = financialLocCode;
 	}
-	
+
 	public String getBusinessUnitName() {
 		return businessUnitName;
 	}
@@ -471,15 +466,6 @@ public class User extends DomainVo {
 		this.departmentName = departmentName;
 	}
 
-	public int compareTo(Object obj){
-      User user = (User)obj;
-
-      String c1 = getLastName() + getFirstName() + getMiddleInitial();
-      String c2 = user.getLastName() + user.getFirstName() + user.getMiddleInitial();
-
-      return c1.compareTo(c2);
-    }
-
 	public boolean isOnline() {
 		return online;
 	}
@@ -503,28 +489,27 @@ public class User extends DomainVo {
 	public void setUserApps(Set userApps) {
 		this.userApps = userApps;
 	}
-	
+
 	@SuppressWarnings("unchecked")
 	public void addAppRoles(App app, SortedSet roles) {
-		if(roles!=null){
-			//add all
-			Set     userApps       = new TreeSet();
+		if (roles != null) {
+			// add all
+			Set newUserApps = new TreeSet();
 			Iterator itr = roles.iterator();
-			while(itr.hasNext()){
+			while (itr.hasNext()) {
 				Role role = (Role) itr.next();
 				UserApp userApp = new UserApp();
 				userApp.setUserId(this.id);
 				userApp.setApp(app);
 				userApp.setRole(role);
-				userApps.add(userApp);
+				newUserApps.add(userApp);
 			}
-			setUserApps(userApps);
+			setUserApps(newUserApps);
 		} else {
-			//remove all
+			// remove all
 			this.userApps.clear();
 		}
 
-		
 	}
 
 	@SuppressWarnings("unchecked")
@@ -532,13 +517,11 @@ public class User extends DomainVo {
 		SortedSet roles = new TreeSet();
 		Set apps = getUserApps();
 		Iterator appsItr = apps.iterator();
-		UserApp userApp = null;
-		//getting default app
-		while(appsItr.hasNext()){
-			UserApp tempUserApp = (UserApp)appsItr.next();
-			if(tempUserApp.getApp().getId().equals(app.getId())){
-				userApp = tempUserApp;
-				roles.add(userApp.getRole());
+		// getting default app
+		while (appsItr.hasNext()) {
+			UserApp tempUserApp = (UserApp) appsItr.next();
+			if (tempUserApp.getApp().getId().equals(app.getId())) {
+				roles.add(tempUserApp.getRole());
 			}
 		}
 		return roles;
@@ -550,53 +533,62 @@ public class User extends DomainVo {
 		app.setName("Default");
 		return getAppRoles(app);
 	}
-	
-	public UserApp getDefaultUserApp(){
+
+	public UserApp getDefaultUserApp() {
 		Set apps = getUserApps();
 		Iterator appsItr = apps.iterator();
 		UserApp userApp = null;
-		//getting default app
-		while(appsItr.hasNext()){
-			UserApp tempApp = (UserApp)appsItr.next();
-			if(tempApp.equals(new Long(1))){
+		// getting default app
+		while (appsItr.hasNext()) {
+			UserApp tempApp = (UserApp) appsItr.next();
+			if (tempApp.getApp().getId().equals(new Long(1))) {
 				userApp = tempApp;
 				break;
 			}
 		}
 		return userApp;
 	}
-	
+
 	public void setRoles(SortedSet roles) {
 		App app = new App();
 		app.setId(new Long(1));
 		app.setName("Default");
-		addAppRoles(app,roles);
+		addAppRoles(app, roles);
 	}
-	
+
 	public void removeRole(Long roleId) {
 		Set apps = getUserApps();
 		Iterator appsItr = apps.iterator();
-			//getting default app
-			while(appsItr.hasNext()){
-				UserApp tempUserApp = (UserApp)appsItr.next();
-				if(tempUserApp.getRole().getId().equals(roleId)){
-					appsItr.remove();
-				}
+		// getting default app
+		while (appsItr.hasNext()) {
+			UserApp tempUserApp = (UserApp) appsItr.next();
+			if (tempUserApp.getRole().getId().equals(roleId)) {
+				appsItr.remove();
 			}
-		
+		}
+
 	}
-	
+
 	@SuppressWarnings("unchecked")
-	public void addRole(Role role){
-		if(role!=null){
+	public void addRole(Role role) {
+		if (role != null) {
 			SortedSet roles = getRoles();
-			if(roles==null){
+			if (roles == null) {
 				roles = new TreeSet();
-			}		
+			}
 			roles.add(role);
-	        setRoles(roles);
+			setRoles(roles);
 		}
+	}
+
+	@Override
+	public int compareTo(Object obj) {
+		User user = (User) obj;
+
+		String c1 = getLastName() + getFirstName() + getMiddleInitial();
+		String c2 = user.getLastName() + user.getFirstName() + user.getMiddleInitial();
 
+		return c1.compareTo(c2);
 	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/UserApp.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/UserApp.java
index 74f7dd75..edaf0013 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/UserApp.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/UserApp.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,29 +37,16 @@
  */
 package org.onap.portalsdk.core.domain;
 
-import java.util.Set;
-import java.util.TreeSet;
 
-// Generated Aug 27, 2014 5:51:36 PM by Hibernate Tools 3.4.0.CR1
-
-/**
- * FnUserRole generated by hbm2java
- */
 @SuppressWarnings("rawtypes")
 public class UserApp implements java.io.Serializable, Comparable {
 
-	/**
-	 * 
-	 */
 	private static final long serialVersionUID = 1L;
 	private Long userId;
 	private App app;
 	private Role role;
 	private Short priority;
 
-	public UserApp() {
-	}
-
 	public Long getUserId() {
 		return userId;
 	}
@@ -83,7 +70,7 @@ public class UserApp implements java.io.Serializable, Comparable {
 	public void setRole(Role role) {
 		this.role = role;
 	}
-	
+
 	public Short getPriority() {
 		return this.priority;
 	}
@@ -92,10 +79,11 @@ public class UserApp implements java.io.Serializable, Comparable {
 		this.priority = priority;
 	}
 
+	@Override
 	public boolean equals(Object other) {
-		if ((this == other))
+		if (this == other)
 			return true;
-		if ((other == null))
+		if (other == null)
 			return false;
 		if (!(other instanceof UserApp))
 			return false;
@@ -104,26 +92,32 @@ public class UserApp implements java.io.Serializable, Comparable {
 		return (this.getUserId().equals(castOther.getUserId()))
 				&& (this.getApp().getId().equals(castOther.getApp().getId()))
 				&& (this.getRole().getId().equals(castOther.getRole().getId()))
-				&& ((this.priority==null && castOther.getPriority()==null) || this.getPriority().equals(castOther.getPriority()));
+				&& ((this.priority == null && castOther.getPriority() == null)
+						|| this.getPriority().equals(castOther.getPriority()));
 	}
 
+	@Override
 	public int hashCode() {
 		int result = 17;
-
-		result = 37 * result + (int) (this.getUserId()==null ? 0 : this.getUserId().intValue());
-		result = 37 * result + (int) (this.getApp().getId()==null ? 0 : this.getApp().getId().intValue());
-		result = 37 * result + (int) (this.getRole().getId()==null ? 0 : this.getRole().getId().intValue());
-		result = 37 * result + (int) (this.priority==null ? 0 : this.priority);
+		result = 37 * result + (int) (this.getUserId() == null ? 0 : this.getUserId().intValue());
+		result = 37 * result + (int) (this.getApp().getId() == null ? 0 : this.getApp().getId().intValue());
+		result = 37 * result + (int) (this.getRole().getId() == null ? 0 : this.getRole().getId().intValue());
+		result = 37 * result + (int) (this.priority == null ? 0 : this.priority);
 		return result;
 	}
 
-    public int compareTo(Object other){
-    	UserApp castOther = (UserApp) other;
-
-        Long c1 = (this.getUserId()==null ? 0 : this.getUserId()) + (this.getApp()==null||this.getApp().getId()==null ? 0 : this.getApp().getId()) + (this.getRole()==null||this.getRole().getId()==null ? 0 : this.getRole().getId()) + (this.priority==null ? 0 : this.priority);
-        Long c2 = (castOther.getUserId()==null ? 0 : castOther.getUserId()) + (castOther.getApp()==null||castOther.getApp().getId()==null ? 0 : castOther.getApp().getId()) + (castOther.getRole()==null||castOther.getRole().getId()==null ? 0 : castOther.getRole().getId()) + (castOther.priority==null ? 0 : castOther.priority);
-
-        return c1.compareTo(c2);
-    }
+	@Override
+	public int compareTo(Object other) {
+		UserApp castOther = (UserApp) other;
+		Long c1 = (this.getUserId() == null ? 0 : this.getUserId())
+				+ (this.getApp() == null || this.getApp().getId() == null ? 0 : this.getApp().getId())
+				+ (this.getRole() == null || this.getRole().getId() == null ? 0 : this.getRole().getId())
+				+ (this.priority == null ? 0 : this.priority);
+		Long c2 = (castOther.getUserId() == null ? 0 : castOther.getUserId())
+				+ (castOther.getApp() == null || castOther.getApp().getId() == null ? 0 : castOther.getApp().getId())
+				+ (castOther.getRole() == null || castOther.getRole().getId() == null ? 0 : castOther.getRole().getId())
+				+ (castOther.priority == null ? 0 : castOther.priority);
+		return c1.compareTo(c2);
+	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/UserAppId.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/UserAppId.java
index a9ec9760..d1fac039 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/UserAppId.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/UserAppId.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -80,26 +80,26 @@ public class UserAppId implements java.io.Serializable {
 		this.role = role;
 	}
 
+	@Override
 	public boolean equals(Object other) {
-		if ((this == other))
+		if (this == other)
 			return true;
-		if ((other == null))
+		if (other == null)
 			return false;
 		if (!(other instanceof UserAppId))
 			return false;
 		UserAppId castOther = (UserAppId) other;
 
-		return (this.getUserId() == castOther.getUserId())
-				&& (this.getApp().getId() == castOther.getApp().getId())
+		return (this.getUserId() == castOther.getUserId()) && (this.getApp().getId() == castOther.getApp().getId())
 				&& (this.getRole().getId() == castOther.getRole().getId());
 	}
 
+	@Override
 	public int hashCode() {
 		int result = 17;
-
-		result = 37 * result + (int) (this.getUserId()==null ? 0 : this.getUserId().intValue());
-		result = 37 * result + (int) (this.getApp().getId()==null ? 0 : this.getApp().getId().intValue());
-		result = 37 * result + (int) (this.getRole().getId()==null ? 0 : this.getRole().getId().intValue());
+		result = 37 * result + (int) (this.getUserId() == null ? 0 : this.getUserId().intValue());
+		result = 37 * result + (int) (this.getApp().getId() == null ? 0 : this.getApp().getId().intValue());
+		result = 37 * result + (int) (this.getRole().getId() == null ? 0 : this.getRole().getId().intValue());
 		return result;
 	}
 
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/sessionmgt/TimeoutVO.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/sessionmgt/TimeoutVO.java
index cf296175..22b8b80a 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/sessionmgt/TimeoutVO.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/sessionmgt/TimeoutVO.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,19 +37,19 @@
  */
 package org.onap.portalsdk.core.domain.sessionmgt;
 
-public class  TimeoutVO implements Comparable{
-	
+public class TimeoutVO implements Comparable {
+
 	private String jSessionId;
 	private Long sessionTimOutMilliSec;
-	
-	public TimeoutVO(){
-		
+
+	public TimeoutVO() {
+		super();
 	}
-	
+
 	public TimeoutVO(String _jSessionId, Long _sessionTimOutMilliSec) {
 		setjSessionId(_jSessionId);
 		setSessionTimOutMilliSec(_sessionTimOutMilliSec);
-				
+
 	}
 
 	public String getjSessionId() {
@@ -68,14 +68,21 @@ public class  TimeoutVO implements Comparable{
 		this.sessionTimOutMilliSec = sessionTimOutMilliSec;
 	}
 
+	@Override
+	public boolean equals(Object other) {
+		if (this == other)
+			return true;
+		if (other == null)
+			return false;
+		if (!(other instanceof TimeoutVO))
+			return false;
+		TimeoutVO castOther = (TimeoutVO) other;
+		return this.getSessionTimOutMilliSec() == castOther.getSessionTimOutMilliSec();
+	}
+
 	@Override
 	public int compareTo(TimeoutVO o) {
 		return sessionTimOutMilliSec.compareTo(o.sessionTimOutMilliSec);
 	}
-	
-	
-	
-	
-	
-	
+
 }
\ No newline at end of file
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Attribute.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Attribute.java
index e78589f8..948d78a0 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Attribute.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Attribute.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -38,43 +38,50 @@
 package org.onap.portalsdk.core.domain.support;
 
 public class Attribute {
-	public double width;
-	public double top;
-	public double left;
-	public String name;
-	public double height;
-	
+	private double width;
+	private double top;
+	private double left;
+	private String name;
+	private double height;
+
 	public double getWidth() {
 		return width;
 	}
+
 	public void setWidth(double width) {
 		this.width = width;
 	}
+
 	public double getTop() {
 		return top;
 	}
+
 	public void setTop(double top) {
 		this.top = top;
 	}
+
 	public double getLeft() {
 		return left;
 	}
+
 	public void setLeft(double left) {
 		this.left = left;
 	}
+
 	public String getName() {
 		return name;
 	}
+
 	public void setName(String name) {
 		this.name = name;
 	}
+
 	public double getHeight() {
 		return height;
 	}
+
 	public void setHeight(double height) {
 		this.height = height;
 	}
 
-	
-	
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/CollaborateList.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/CollaborateList.java
index 2f0c5d50..32828b78 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/CollaborateList.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/CollaborateList.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -39,36 +39,34 @@ package org.onap.portalsdk.core.domain.support;
 
 import java.io.Serializable;
 import java.util.HashSet;
+import java.util.Set;
+
+public class CollaborateList implements Serializable {
 
-public class CollaborateList implements  Serializable {
-	
 	private static final long serialVersionUID = -4104440747626736243L;
-	private HashSet userNameList = new HashSet();
+	private HashSet userNameList = new HashSet<>();
 	private static CollaborateList userListData = new CollaborateList();
-	private CollaborateList(){}
 
-	public static CollaborateList getInstance(){
+	private CollaborateList() {
+	}
+
+	public static CollaborateList getInstance() {
 		return userListData;
 	}
-	
-	public HashSet getAllUserName(){
+
+	public Set getAllUserName() {
 		return userNameList;
 	}
-	
-	public static void addUserName(String name){
-		final HashSet allUserName = CollaborateList.getInstance().getAllUserName();
-		if(allUserName.contains(name)){
-			//System.out.println("cannot add this user");
-		}else{
+
+	public static void addUserName(String name) {
+		final Set allUserName = CollaborateList.getInstance().getAllUserName();
+		if (!allUserName.contains(name))
 			allUserName.add(name);
-		}
 	}
-	
-	public static void delUserName(String name){
-		final HashSet allUserName = CollaborateList.getInstance().getAllUserName();
+
+	public static void delUserName(String name) {
+		final Set allUserName = CollaborateList.getInstance().getAllUserName();
 		allUserName.remove((String) name);
 	}
-	
-
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Container.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Container.java
index cdbf6611..ed065b4a 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Container.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Container.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -40,56 +40,64 @@ package org.onap.portalsdk.core.domain.support;
 import java.util.List;
 import java.util.Map;
 
+import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
+
 public class Container {
-	
+
+	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(Container.class);
+
 	String id;
-	
-	public String name;
-	
+
+	String name;
+
 	Size size;
-	
+
 	Position p;
-	
-	public Map containerRowCol;
-	
-	public Map elementRowCol;
-	
+
+	Map containerRowCol;
+
+	Map elementRowCol;
+
 	int numOfRows;
-	
+
 	int numOfCols;
-	
+
 	double sum = 0;
-	
+
 	double interEleWd;
-	
+
 	double interEleH;
-	
+
 	double interEleToContainerWd;
-	
+
 	double interEleToContainerH;
-	
+
 	double interEleToInnerContainerWd;
-	
+
 	double interEleToInnerContainerH;
-	
-	public double top;
-	
-	public double left;
-	
-	public double height;
-	
-	public double width;
-	
-	public String visibilityType;
-	
-	
-
-
-
-	public Container(String id, String name, int numOfRows, int numOfCols, double interEleWd, double interEleH, 
-					 double interEleToContainerWd, double interEleToContainerH, double interEleToInnerContainerWd, 
-					 double interEleToInnerContainerH) {
-		
+
+	double top;
+
+	double left;
+
+	double height;
+
+	double width;
+
+	String visibilityType;
+
+	List innerCList;
+
+	List elementList;
+
+	public Container() {
+
+	}
+
+	public Container(String id, String name, int numOfRows, int numOfCols, double interEleWd, double interEleH,
+			double interEleToContainerWd, double interEleToContainerH, double interEleToInnerContainerWd,
+			double interEleToInnerContainerH) {
+
 		this.id = id;
 		this.name = name;
 		this.numOfRows = numOfRows;
@@ -100,27 +108,13 @@ public class Container {
 		this.interEleToContainerH = interEleToContainerH;
 		this.interEleToInnerContainerWd = interEleToInnerContainerWd;
 		this.interEleToInnerContainerH = interEleToInnerContainerH;
-		
-	}
-	
-	
-	public List innerCList; 
-	
-	public List elementList; 
-	
-	public Container() {
-		
+
 	}
-	
-	
-	
+
 	public Map getContainerRowCol() {
 		return containerRowCol;
 	}
 
-	
-	
-	
 	public Map getElementRowCol() {
 		return elementRowCol;
 	}
@@ -133,16 +127,14 @@ public class Container {
 		this.name = name;
 	}
 
-
-	public void setInnerContainer(Map innerCon) {
+	public void setInnerContainer(Map innerCon) {
 		containerRowCol = innerCon;
 	}
-	
-	public void setElements(Map innerE) {
+
+	public void setElements(Map innerE) {
 		elementRowCol = innerE;
 	}
-	
-	
+
 	public Position getP() {
 		return p;
 	}
@@ -151,33 +143,26 @@ public class Container {
 		this.p = p;
 	}
 
-	
 	public void setTop(double top) {
 		this.top = top;
 	}
 
-
 	public void setLeft(double left) {
 		this.left = left;
 	}
 
-
 	public void setHeight(double height) {
 		this.height = height;
 	}
 
-
 	public void setWidth(double width) {
 		this.width = width;
 	}
 
-	
 	public void setInnerCList(List innerCList) {
 		this.innerCList = innerCList;
 	}
 
-
-
 	public void setElementList(List elementList) {
 		this.elementList = elementList;
 	}
@@ -187,103 +172,92 @@ public class Container {
 	}
 
 	public Size computeSize() {
+		logger.debug("computeSize: name is {}", getName());
 		Size size = new Size();
 		double width = 0;
 		double height = 0;
-	//	System.out.println("Inside computesize");
-		for (int i = 0; i0; chk--) {
-									if (containerRowCol.containsKey(String.valueOf(k)+ String.valueOf(chk-1))) {
-										if (containerRowCol.get(String.valueOf(k)+ String.valueOf(chk-1)).computeSize().getWidth() 
-										    + containerRowCol.get(String.valueOf(k)+ String.valueOf(chk-1)).getP().getX() > p.x) {
-											ysum+= containerRowCol.get(String.valueOf(k)+ String.valueOf(chk-1)).computeSize().getHeight();
-											break;
-										}
+					for (int k = 0; k < i; k++) {
+						if (containerRowCol != null
+								&& containerRowCol.containsKey(String.valueOf(k) + String.valueOf(j)))
+							ysum += containerRowCol.get(String.valueOf(k) + String.valueOf(j)).computeSize()
+									.getHeight();
+						else if (elementRowCol != null
+								&& elementRowCol.containsKey(String.valueOf(k) + String.valueOf(j)))
+							ysum += elementRowCol.get(String.valueOf(k) + String.valueOf(j)).computeSize().getHeight();
+						else if (containerRowCol != null) {
+							for (int chk = j; chk > 0; chk--) {
+								if (containerRowCol.containsKey(String.valueOf(k) + String.valueOf(chk - 1))) {
+									if (containerRowCol.get(String.valueOf(k) + String.valueOf(chk - 1)).computeSize()
+											.getWidth()
+											+ containerRowCol.get(String.valueOf(k) + String.valueOf(chk - 1)).getP()
+													.getX() > p.x) {
+										ysum += containerRowCol.get(String.valueOf(k) + String.valueOf(chk - 1))
+												.computeSize().getHeight();
+										break;
 									}
 								}
+							}
 						}
-						
+
 					}
 					if (this.getName().equals("Broadworks complex") || this.getName().equals("Application Servers")
-							|| this.getName().equals("Call Session Control") || this.getName().equals("GMLC Provider") || this.getName().equals("Neo") || this.getName().equals("Support")) {
-						p.y = this.getP().getY()+ysum+i*interEleH+interEleToInnerContainerH+1;
+							|| this.getName().equals("Call Session Control") || this.getName().equals("GMLC Provider")
+							|| this.getName().equals("Neo") || this.getName().equals("Support")) {
+						p.y = this.getP().getY() + ysum + i * interEleH + interEleToInnerContainerH + 1;
 					} else {
-					//	System.out.println("element name "+e.getName()+" this.getP().getY() "+this.getP().getY()
-					//			+" ysum " +ysum+" i*interEleH "+i*interEleH+" interEleToContainerH " +interEleToContainerH);
 						if (e.getName().equals("")) {
-							p.y = this.getP().getY()+ysum+i*interEleH+(interEleToContainerH);
-							//System.out.println("test element name "+this.getName()+" Container height "+this.computeSize().getHeight()+" this.getP().getY() "+this.getP().getY()
-							//		+" ysum " +ysum+" i*interEleH "+i*interEleH+" interEleToContainerH-3 " +interEleToContainerH+" p.y "+p.y);
-						}else
-							p.y = this.getP().getY()+ysum+i*interEleH+interEleToContainerH;
-						//	System.out.println(e.getName()+"My contain this.getP().getY() "+this.getP().getY()
-						//			+"elements Y "+p.y);
+							p.y = this.getP().getY() + ysum + i * interEleH + (interEleToContainerH);
+						} else
+							p.y = this.getP().getY() + ysum + i * interEleH + interEleToContainerH;
 					}
-					xsum+= e.computeSize().getWidth();
-					e.setP(p); 
-					//System.out.println("my element name "+e.getName()+" e.getP().getX() "+e.getP().getX());
-					//System.out.println();
-				}	
+					xsum += e.computeSize().getWidth();
+					e.setP(p);
+				}
 			}
 			xsum = 0;
 		}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Domain.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Domain.java
index b4adaf95..2ef50419 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Domain.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Domain.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,32 +37,18 @@
  */
 package org.onap.portalsdk.core.domain.support;
 
-import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
 
 public class Domain {
-	// Unique identifier of the domain 
+	// Unique identifier of the domain
 	String id;
-	// List cList;
-	
-	public String name;
-	Size size; 
+	String name;
+	Size size;
 	Position p;
-	
-	//Attribute1 at;
-	
-	public Position getP() {
-		return p;
-	}
-
-	public void setP(Position p) {
-		this.p = p;
-	}
-
-	//Horizontal space between a pair of containers
+	// Horizontal space between a pair of containers
 	double interContWd = 1.0;
-	//Vertical space between a pair of containers
+	// Vertical space between a pair of containers
 	double interContH;
 	double domainToLayoutWd;
 	double domainToContH;
@@ -70,7 +56,15 @@ public class Domain {
 	int numOfRowsofContainer;
 	int numOfColsofContainer;
 	boolean indexChanged;
-	Map containerRowCol;
+	Map containerRowCol;
+	double top;
+	double left;
+	double height;
+	double width;
+	List containerList;
+	double newXafterColl;
+	double YafterColl;
+
 	public Domain(String id, String name, double interContWd, double interContH, double domainToLayoutWd,
 			double domainToLayoutH, double domainToContH, int numOfRowsofContainer, int numOfColsofContainer) {
 		this.id = id;
@@ -82,26 +76,16 @@ public class Domain {
 		this.domainToContH = domainToContH;
 		this.numOfRowsofContainer = numOfRowsofContainer;
 		this.numOfColsofContainer = numOfColsofContainer;
-	//	at = new Attribute1();
 	}
-	
-	
-	
-
-	public double top;
-	
-	public double left;
-	
-	public double height;
-	
-	public double width;
-	
-	public List containerList; 
-	
-	public double newXafterColl;
-	
-	public double YafterColl;
-	
+
+	public Position getP() {
+		return p;
+	}
+
+	public void setP(Position p) {
+		this.p = p;
+	}
+
 	public void setNewXafterColl(double newXafterColl) {
 		this.newXafterColl = newXafterColl;
 	}
@@ -109,7 +93,7 @@ public class Domain {
 	public double getNewXafterColl() {
 		return newXafterColl;
 	}
-	
+
 	public double getYafterColl() {
 		return YafterColl;
 	}
@@ -121,7 +105,7 @@ public class Domain {
 	public void setDomainToLayoutWd(double domainToLayoutWd) {
 		this.domainToLayoutWd = domainToLayoutWd;
 	}
-	
+
 	public double getDomainToLayoutWd() {
 		return domainToLayoutWd;
 	}
@@ -166,38 +150,18 @@ public class Domain {
 		return name;
 	}
 
-	public void setContainers(Map containerRowCol) {
+	public void setContainers(Map containerRowCol) {
 		this.containerRowCol = containerRowCol;
 	}
-	
+
 	public Map getContainerRowCol() {
 		return containerRowCol;
 	}
 
-	
-	/* public Attribute1 getAt() {
-		return at;
-	}
-
-	public void setAt(Attribute1 at) {
-		this.at = at;
-	}*/
-
 	public void setContainerList(List containerList) {
-	//	new ArrayList();
 		this.containerList = containerList;
 	}
 
-	
-	
-/*	public boolean isCollapsed() {
-		return collapsed;
-	}
-
-	public void setCollapsed(boolean collapsed) {
-		this.collapsed = collapsed;
-	}*/
-
 	public boolean isIndexChanged() {
 		return indexChanged;
 	}
@@ -206,72 +170,63 @@ public class Domain {
 		this.indexChanged = indexChanged;
 	}
 
-	//Compute the size of any domain 
+	// Compute the size of any domain
 	public Size computeSize() {
 		size = new Size();
 		size.setHeight(5);
-		double width = 0;
+		double myWidth = 0;
 		for (int i = 0; i < numOfRowsofContainer; i++) {
-		      if (containerRowCol!=null && containerRowCol.containsKey(String.valueOf(i)+String.valueOf(numOfColsofContainer-1))) {
-		    	  for (int j = 0; j < numOfColsofContainer; j++) {
-		    		  width+=containerRowCol.get(String.valueOf(i)+String.valueOf(j)).computeSize().getWidth();
-		    	  }
-		    	  break;
-		      }
-		
+			if (containerRowCol != null
+					&& containerRowCol.containsKey(String.valueOf(i) + String.valueOf(numOfColsofContainer - 1))) {
+				for (int j = 0; j < numOfColsofContainer; j++) {
+					myWidth += containerRowCol.get(String.valueOf(i) + String.valueOf(j)).computeSize().getWidth();
+				}
+				break;
+			}
+
 		}
-		width+=(numOfColsofContainer-1)*interContWd;
-		if (this.getName().equals("VNI")) 
-			size.setWidth(width-4);
+		myWidth += (numOfColsofContainer - 1) * interContWd;
+		if (this.getName().equals("VNI"))
+			size.setWidth(myWidth - 4);
 		else
-			size.setWidth(width);
+			size.setWidth(myWidth);
 		return size;
 	}
 
 	public void computeConatinerPositions() {
-	
+
 		double xsum = 0;
-		double ysum = 0;
-		for (int i=0; i< numOfRowsofContainer; i++){
-				for (int j=0; j0 && containerRowCol.containsKey(String.valueOf(k)+ String.valueOf(j-1)) &&
-									!containerRowCol.get(String.valueOf(i)+ String.valueOf(j)).getName().equals("AIC - Alpharetta")) {
-								ysum+= containerRowCol.get(String.valueOf(k)+ String.valueOf(j-1)).computeSize().getHeight();
-							}
+		for (int i = 0; i < numOfRowsofContainer; i++) {
+			for (int j = 0; j < numOfColsofContainer; j++) {
+				if (containerRowCol != null && containerRowCol.containsKey(String.valueOf(i) + String.valueOf(j))) {
+					Container c = containerRowCol.get(String.valueOf(i) + String.valueOf(j));
+					Position p = new Position();
+					if (this.getName().equals("VNI")) {
+						p.x = j * (interContWd - 2) + xsum + domainToLayoutWd;
+					} else
+						p.x = j * interContWd + xsum + domainToLayoutWd;
+					double ysum = 0;
+					for (int k = 0; k < i; k++) {
+						if (containerRowCol.containsKey(String.valueOf(k) + String.valueOf(j)))
+							ysum += containerRowCol.get(String.valueOf(k) + String.valueOf(j)).computeSize()
+									.getHeight();
+
+						else if (j > 0 && containerRowCol.containsKey(String.valueOf(k) + String.valueOf(j - 1))
+								&& !containerRowCol.get(String.valueOf(i) + String.valueOf(j)).getName()
+										.equals("AIC - Alpharetta")) {
+							ysum += containerRowCol.get(String.valueOf(k) + String.valueOf(j - 1)).computeSize()
+									.getHeight();
 						}
-						//System.out.println("C name "+c.getName()+" ysum "+ysum+" domainToLayoutH "+domainToLayoutH+" this.computeSize().getHeight() "+
-						//		this.computeSize().getHeight()+" domainToContH "+domainToContH+" interContH "+interContH);
-						p.y = domainToLayoutH+ysum+this.computeSize().getHeight()+ 
-							  domainToContH+i*interContH;
-		               
-						c.setP(p);
-		                xsum+= c.computeSize().getWidth();
-		                
-					}	
+					}
+					p.y = domainToLayoutH + ysum + this.computeSize().getHeight() + domainToContH + i * interContH;
+					c.setP(p);
+					xsum += c.computeSize().getWidth();
 				}
-				xsum = 0;
-				
+			}
+			xsum = 0;
+
 		}
 
 	}
 
 }
-
-
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/DomainVo.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/DomainVo.java
index 57718ed4..ba4a1f34 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/DomainVo.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/DomainVo.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -46,139 +46,150 @@ import java.util.Date;
 import java.util.Set;
 
 import org.onap.portalsdk.core.domain.FusionVo;
-
+import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
 
 /* Super class from which all data objects descend */
 public class DomainVo extends FusionVo implements Serializable, Cloneable, Comparable {
 
-    protected Long id;
-    protected Date created;
-    protected Date modified;
-    protected Long createdId;
-    protected Long modifiedId;
-    protected Long rowNum;
-
-    protected Serializable auditUserId;
-
-    Set auditTrail = null;
-
-    public DomainVo() {}
-
-
-    public void setId(Long i) {
-        id = i;
-    }
-
-    public void setCreated(Date created) {
-        this.created = created;
-    }
-
-    public void setModified(Date modified) {
-        this.modified = modified;
-    }
-
-    public void setCreatedId(Long createdId) {
-        this.createdId = createdId;
-    }
-
-    public void setModifiedId(Long modifiedId) {
-        this.modifiedId = modifiedId;
-    }
-
-    public void setAuditUserId(Serializable auditUserId) {
-        this.auditUserId = auditUserId;
-    }
-
-    public void setRowNum(Long rowNum) {
-        this.rowNum = rowNum;
-    }
-
-    public void setAuditTrail(Set auditTrail) {
-        this.auditTrail = auditTrail;
-    }
-
-    public Long getId() {
-        return id;
-    }
-
-    public Date getCreated() {
-        return created;
-    }
-
-    public Date getModified() {
-        return modified;
-    }
-
-    public Long getCreatedId() {
-        return createdId;
-    }
-
-    public Long getModifiedId() {
-        return modifiedId;
-    }
-
-    public Serializable getAuditUserId() {
-        return auditUserId;
-    }
-
-    public Long getRowNum() {
-        return rowNum;
-    }
-
-    public Set getAuditTrail() {
-        return auditTrail;
-    }
-
-
+	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(DomainVo.class);
+
+	private static final long serialVersionUID = 1L;
+	protected Long id;
+	protected Date created;
+	protected Date modified;
+	protected Long createdId;
+	protected Long modifiedId;
+	protected Long rowNum;
+	protected Serializable auditUserId;
+	protected Set auditTrail = null;
+
+	public DomainVo() {
+		super();
+	}
+
+	public void setId(Long i) {
+		id = i;
+	}
+
+	public void setCreated(Date created) {
+		this.created = created;
+	}
+
+	public void setModified(Date modified) {
+		this.modified = modified;
+	}
+
+	public void setCreatedId(Long createdId) {
+		this.createdId = createdId;
+	}
+
+	public void setModifiedId(Long modifiedId) {
+		this.modifiedId = modifiedId;
+	}
+
+	public void setAuditUserId(Serializable auditUserId) {
+		this.auditUserId = auditUserId;
+	}
+
+	public void setRowNum(Long rowNum) {
+		this.rowNum = rowNum;
+	}
+
+	public void setAuditTrail(Set auditTrail) {
+		this.auditTrail = auditTrail;
+	}
+
+	public Long getId() {
+		return id;
+	}
+
+	public Date getCreated() {
+		return created;
+	}
+
+	public Date getModified() {
+		return modified;
+	}
+
+	public Long getCreatedId() {
+		return createdId;
+	}
+
+	public Long getModifiedId() {
+		return modifiedId;
+	}
+
+	public Serializable getAuditUserId() {
+		return auditUserId;
+	}
+
+	public Long getRowNum() {
+		return rowNum;
+	}
+
+	public Set getAuditTrail() {
+		return auditTrail;
+	}
+
+	public Object copy() {
+		return copy(false);
+	}
+
+	public Object copy(boolean isIdNull) {
+		// let's create a "copy" of the object using serialization
+		ByteArrayOutputStream baos = null;
+		ByteArrayInputStream bais = null;
+		ObjectOutputStream oos = null;
+		ObjectInputStream ois = null;
+
+		DomainVo newVo = null;
+		try {
+			baos = new ByteArrayOutputStream();
+			oos = new ObjectOutputStream(baos);
+			oos.writeObject(this);
+
+			bais = new ByteArrayInputStream(baos.toByteArray());
+			ois = new ObjectInputStream(bais);
+			newVo = (DomainVo) ois.readObject();
+
+			if (isIdNull) {
+				newVo.setId(null);
+			}
+
+		} catch (Exception e) {
+			logger.error(EELFLoggerDelegate.errorLogger, "copy failed", e);
+		}
+
+		return newVo;
+	}
+	
+	@Override
     public Object clone() throws CloneNotSupportedException {
       return super.clone();
     }
-
-
-    public Object copy() {
-      return copy(false);
-    }
-
-
-    public Object copy(boolean isIdNull) {
-       // let's create a "copy" of the object using serialization
-       ByteArrayOutputStream baos = null;
-       ByteArrayInputStream  bais = null;
-       ObjectOutputStream     oos = null;
-       ObjectInputStream      ois = null;
-
-       DomainVo newVo = null;
-
-       try {
-
-         baos = new ByteArrayOutputStream();
-         oos  = new ObjectOutputStream(baos);
-         oos.writeObject(this);
-
-         bais  = new ByteArrayInputStream(baos.toByteArray());
-         ois   =  new ObjectInputStream(bais);
-         newVo = (DomainVo)ois.readObject();
-
-         if (isIdNull) {
-           newVo.setId(null);
-         }
-
-       }
-       catch (Exception e) {
-         e.printStackTrace();
-       }
-
-       return newVo;
-     }
-
-
-
-    public int compareTo(Object obj){
-      Long c1 = getId();
-      Long c2 = ((DomainVo)obj).getId();
-
-      return (c1 == null || c2 == null) ? 1 : c1.compareTo(c2);
-    }
-
+    
+    @Override
+	public boolean equals(Object other) {
+		if (this == other)
+			return true;
+		if (other == null)
+			return false;
+		if (!(other instanceof DomainVo))
+			return false;
+		DomainVo castOther = (DomainVo) other;
+		return this.getId() == castOther.getId()
+				&& this.getCreated().equals(castOther.getCreated())
+				&& this.getCreatedId() == castOther.getCreatedId()
+				&& this.getModified().equals(castOther.getModified())
+				&& this.getModifiedId() == castOther.getModifiedId()
+		;
+	}
+
+	@Override
+	public int compareTo(Object obj) {
+		Long c1 = getId();
+		Long c2 = ((DomainVo) obj).getId();
+		return (c1 == null || c2 == null) ? 1 : c1.compareTo(c2);
+	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Element.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Element.java
index 85147e48..1bf6a150 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Element.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Element.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,32 +37,45 @@
  */
 package org.onap.portalsdk.core.domain.support;
 
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-
 public class Element {
-	
-	public String id;
-	public String name;
-	
-    public double top;
-	
-	public double left;
-	
-	public double height;
-	
-	public String imgFileName;
-	
-	public String borderType;
-	
-	public String bgColor;
-	
-	public ElementDetails details;
-		
-	//public List details;
-	
-	
+
+	String id;
+	String name;
+
+	double top;
+
+	double left;
+
+	double height;
+
+	double width;
+
+	String imgFileName;
+
+	String borderType;
+
+	String bgColor;
+
+	ElementDetails details;
+
+	Position p;
+
+	public Element(String id, String name) {
+		this.id = id;
+		this.name = name;
+	}
+
+	public Element(String id, String name, String imgFilename, String bgColor, String borderType,
+			ElementDetails details) {
+		this.id = id;
+		this.name = name;
+		this.imgFileName = imgFilename;
+		this.bgColor = bgColor;
+		this.borderType = borderType;
+		this.details = details;
+
+	}
+
 	public void setBgColor(String bgColor) {
 		this.bgColor = bgColor;
 	}
@@ -87,15 +100,10 @@ public class Element {
 		this.width = width;
 	}
 
-
-	public double width;
-	
-	
 	public String getId() {
 		return id;
 	}
-	
-		
+
 	public String getName() {
 		return name;
 	}
@@ -103,10 +111,7 @@ public class Element {
 	public void setName(String name) {
 		this.name = name;
 	}
-	
 
-	Position p;
-	
 	public Position getP() {
 		return p;
 	}
@@ -115,34 +120,6 @@ public class Element {
 		this.p = p;
 	}
 
-	
-	
-	public Element(String id, String name, String imgPath, String bgColor, String logical_group, String display_longname, 
-					String description, String primary_function, String key_interfaces, String location, String vendor, String vendor_shortname) {
-		this.id = id;
-		this.name = name;
-		this.imgFileName = imgPath;
-		this.bgColor = bgColor;
-		
-		
-	}
-	
-	public Element(String id, String name) {
-		this.id = id;
-		this.name = name;
-	}
-	
-	public Element(String id, String name, String imgFilename, String bgColor, String borderType, ElementDetails details) {
-		this.id = id;
-		this.name = name;
-		this.imgFileName = imgFilename;
-		this.bgColor = bgColor; 
-		this.borderType = borderType; 
-		this.details = details;
-		
-	}
-	
-	
 	public void setBorderType(String borderType) {
 		this.borderType = borderType;
 	}
@@ -154,29 +131,23 @@ public class Element {
 	public void setImgFileName(String imgFileName) {
 		this.imgFileName = imgFileName;
 	}
-	
+
 	public String getBorderType() {
 		return borderType;
 	}
-	
-	
-	
+
 	public ElementDetails getDetails() {
 		return details;
 	}
 
-	
-	
 	public void setDetails(ElementDetails details) {
 		this.details = details;
 	}
 
 	public Size computeSize() {
-		Size size= new Size();
-		size.setWidth(0.5*7.0);
-		size.setHeight(0.5*3.0);
-	//	size.setWidth(0.5*10.0);
-	//	size.setHeight(0.5*6.0);
+		Size size = new Size();
+		size.setWidth(0.5 * 7.0);
+		size.setHeight(0.5 * 3.0);
 		return size;
 	}
 
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/ElementDetails.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/ElementDetails.java
index 58c8d416..73ccd5d6 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/ElementDetails.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/ElementDetails.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,37 +37,23 @@
  */
 package org.onap.portalsdk.core.domain.support;
 
-import java.util.HashMap;
-import java.util.Map;
-
 public class ElementDetails {
-	public String logical_group;
-	public String display_longname;
-	public String description;
-	public String primary_function;
-	public String network_function;
-	public String key_interfaces;
-	public String location;
-	public String vendor;
-	public String vendor_shortname;
-	public String enclosingContainer;
 	
+	String logical_group;
+	String display_longname;
+	String description;
+	String primary_function;
+	String network_function;
+	String key_interfaces;
+	String location;
+	String vendor;
+	String vendor_shortname;
+	String enclosingContainer;
 
-//	public Map details1;
+	public ElementDetails(String logical_group, String display_longname, String description, String primary_function,
+			String network_function, String key_interfaces, String location, String vendor, String vendor_shortname,
+			String enclosingContainer) {
 
-//	public ElementDetails(Map details) {
-		
-	//	this.details = new HashMap();
-	//	this.details1 = details;
-//	}
-	
-	
-	
-	
-	
-	public ElementDetails(String logical_group, String display_longname, String description, String primary_function, String network_function,
-			String key_interfaces, String location, String vendor, String vendor_shortname, String enclosingContainer) {
-		
 		this.logical_group = logical_group;
 		this.display_longname = display_longname;
 		this.description = description;
@@ -80,10 +66,12 @@ public class ElementDetails {
 		this.enclosingContainer = enclosingContainer;
 	}
 
+	public String getLogical_group() {
+		return logical_group;
+	}
+	
 	public void setLogical_group(String logical_group) {
 		this.logical_group = logical_group;
 	}
-	
-	
-	
+
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/FusionCommand.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/FusionCommand.java
index 08736f0d..3ee8f642 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/FusionCommand.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/FusionCommand.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -41,17 +41,14 @@ import org.onap.portalsdk.core.FusionObject;
 
 public class FusionCommand implements FusionObject {
 
-  private String task;
+	private String task;
 
-  public FusionCommand() {
-  }
+	public String getTask() {
+		return task;
+	}
 
-    public String getTask() {
-        return task;
-    }
-
-    public void setTask(String task) {
-        this.task = task;
-    }
+	public void setTask(String task) {
+		this.task = task;
+	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Layout.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Layout.java
index 957bb9af..09c8372d 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Layout.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Layout.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -39,36 +39,43 @@ package org.onap.portalsdk.core.domain.support;
 
 import java.util.ArrayList;
 import java.util.HashMap;
-import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
-import java.util.Set;
 import java.util.TreeMap;
 
 public class Layout {
-	//width of the screen 
-//	double width; 
-	//height of the screen;
-//	double height;	
-	// Total number of domains present on the screen and assume that
-	
-	public Map domainRowCol;          
-		
-	Map originalDomainRowCol;  
-
-	//Horizontal space between a pair of domains
+
+	Map domainRowCol;
+
+	Map originalDomainRowCol;
+
+	// Horizontal space between a pair of domains
 	double interDomainWd;
-		//Vertical space between a pair of domains
+	// Vertical space between a pair of domains
 	double interDomainH;
-		//Computing the co-ordinates of any domain
+	// Computing the co-ordinates of any domain
 	int numberofRowsofDomains;
-	
+
 	int numberofColsofDomains;
-	
+
 	Map collapsedDomains;
-	
+
 	List collapsedDomainsNewList;
-	
+
+	public Layout(Map domainRowCol, double interDomainWd, double interDomainH,
+			int numberofRowsofDomains, int numberofColsofDomains) {
+
+		this.domainRowCol = domainRowCol;
+		this.interDomainWd = interDomainWd;
+		this.interDomainH = interDomainH;
+		this.numberofRowsofDomains = numberofRowsofDomains;
+		this.numberofColsofDomains = numberofColsofDomains;
+		this.collapsedDomains = new HashMap<>();
+		this.originalDomainRowCol = new TreeMap<>();
+		// nline
+		this.collapsedDomainsNewList = new ArrayList<>();
+	}
+
 	public List getCollapsedDomainsNewList() {
 		return collapsedDomainsNewList;
 	}
@@ -93,20 +100,6 @@ public class Layout {
 		this.numberofColsofDomains = numberofColsofDomains;
 	}
 
-	public Layout(Map domainRowCol, double interDomainWd, double interDomainH, 
-				  int numberofRowsofDomains, int numberofColsofDomains) {
-		
-		this.domainRowCol = domainRowCol;
-		this.interDomainWd = interDomainWd;
-		this.interDomainH = interDomainH;
-		this.numberofRowsofDomains = numberofRowsofDomains;
-		this.numberofColsofDomains = numberofColsofDomains;
-		this.collapsedDomains = new HashMap();
-		this.originalDomainRowCol = new TreeMap();
-		//nline
-		this.collapsedDomainsNewList = new ArrayList();
-	}
-	
 	public Map getDomainRowCol() {
 		return domainRowCol;
 	}
@@ -114,60 +107,54 @@ public class Layout {
 	public void setDomainRowCol(Map domainRowCol) {
 		this.domainRowCol = domainRowCol;
 	}
-	
-	
+
 	public void computeDomainPositions() {
 		double xsum = 0;
 		double domainTolayout = 10.6;
-		for (int i=0; i< numberofRowsofDomains; i++){
-			for (int j=0; j 0)
-						p.x+= accountForPlusSpaceBefore(d);
-					xsum+=d.computeSize().getWidth();
-					double ysum=0;
-					for (int k=0; k enclosedContainers = d.getContainerRowCol();
+					Map enclosedContainers = d.getContainerRowCol();
 					for (Map.Entry entry : enclosedContainers.entrySet()) {
 						if (entry.getKey().equals("00")) {
 							double containerX = entry.getValue().getP().getX();
 							p.x = containerX;
-							double ysum=0;
-							for (int k=0; k updatedRC = new HashMap();
-		
+
+		if (domainsToCollapse == null || domainsToCollapse.isEmpty())
+			return null;
+
+		Map updatedRC = new HashMap<>();
+
 		for (Map.Entry copyEntry : domainRowCol.entrySet()) {
 			updatedRC.put(copyEntry.getKey(), copyEntry.getValue());
-			// System.out.println("copyEntry.getKey() "+copyEntry.getKey()+ " copyEntry.getValue() "+copyEntry.getValue());
 		}
-		
-		Map updatedRCSorted = new TreeMap(updatedRC);
-		
-		Map collapsedDomainMap =  getCollapsedDomains();
-		
+
+		Map updatedRCSorted = new TreeMap<>(updatedRC);
+
+		Map collapsedDomainMap = getCollapsedDomains();
+
 		List collapsedDomainNewL = getCollapsedDomainsNewList();
-		
-		
+
 		if (collapsedDomainNewL.size() == 0) {
 			for (Map.Entry copyEntry : domainRowCol.entrySet()) {
 				originalDomainRowCol.put(copyEntry.getKey(), copyEntry.getValue());
-			//	System.out.println("copyEntry.getKey() "+copyEntry.getKey()+ " copyEntry.getValue() "+copyEntry.getValue());
 			}
 		}
-			
-		
-		Map updatedRCSortedTrunc = new TreeMap();
-	
-			int colToDelete = 0;
-			for (Map.Entry entry : updatedRCSorted.entrySet()) {
-				if (entry.getValue().getName().equals(domainsToCollapse)) {
-					if (entry.getValue().isIndexChanged()) {
-						collapsedDomainMap.put("0"+String.valueOf(Integer.parseInt(entry.getKey())+1), entry.getValue());
-						
-					}
-					//Domain toRemove = entry.getValue();
-					else {
-						collapsedDomainMap.put(entry.getKey(),entry.getValue());
-					}
-					
-					collapsedDomainNewL.add(entry.getValue());
-					setNumberofColsofDomains(getNumberofColsofDomains()-1);
-					updatedRC.remove(entry.getKey());
-					colToDelete = Character.getNumericValue(entry.getKey().toCharArray()[1]);
-					break;
-				}
-			}
-			
-			
-			for (Map.Entry copyEntry : updatedRCSorted.entrySet()) {
-				updatedRCSortedTrunc.put(copyEntry.getKey(), copyEntry.getValue());
-				//System.out.println("copyEntry.getKey() "+copyEntry.getKey()+ " copyEntry.getValue() "+copyEntry.getValue());
-			}
-			
-			for (Map.Entry rmv : updatedRCSorted.entrySet()) {
-				if (Character.getNumericValue(rmv.getKey().toCharArray()[1]) <= colToDelete) {
-					updatedRCSortedTrunc.remove(rmv.getKey());
+
+		Map updatedRCSortedTrunc = new TreeMap<>();
+
+		int colToDelete = 0;
+		for (Map.Entry entry : updatedRCSorted.entrySet()) {
+			if (entry.getValue().getName().equals(domainsToCollapse)) {
+				if (entry.getValue().isIndexChanged()) {
+					collapsedDomainMap.put("0" + String.valueOf(Integer.parseInt(entry.getKey()) + 1),
+							entry.getValue());
+
+				} else {
+					collapsedDomainMap.put(entry.getKey(), entry.getValue());
 				}
+
+				collapsedDomainNewL.add(entry.getValue());
+				setNumberofColsofDomains(getNumberofColsofDomains() - 1);
+				updatedRC.remove(entry.getKey());
+				colToDelete = Character.getNumericValue(entry.getKey().toCharArray()[1]);
+				break;
 			}
-			
-			
-		/*	for (Map.Entry entry : updatedRCSortedTrunc.entrySet()) {
-				System.out.println("Sorted key: "+entry.getKey()+" Sorted value: "+entry.getValue().getName());
-			}*/
-			
-			for (Map.Entry updateOthers : updatedRCSortedTrunc.entrySet()) {
-						char update[] = updateOthers.getKey().toCharArray();
-						int charToupdate = Character.getNumericValue(update[1]);
-						--charToupdate;
-						String resultRowCol = String.valueOf(update[0])+String.valueOf(charToupdate);
-						updateOthers.getValue().setIndexChanged(true);
-						updatedRC.put(resultRowCol, updateOthers.getValue());
-						updatedRC.remove(updateOthers.getKey());
-			
+		}
+
+		for (Map.Entry copyEntry : updatedRCSorted.entrySet()) {
+			updatedRCSortedTrunc.put(copyEntry.getKey(), copyEntry.getValue());
+		}
+
+		for (Map.Entry rmv : updatedRCSorted.entrySet()) {
+			if (Character.getNumericValue(rmv.getKey().toCharArray()[1]) <= colToDelete) {
+				updatedRCSortedTrunc.remove(rmv.getKey());
 			}
+		}
+
+		for (Map.Entry updateOthers : updatedRCSortedTrunc.entrySet()) {
+			char update[] = updateOthers.getKey().toCharArray();
+			int charToupdate = Character.getNumericValue(update[1]);
+			--charToupdate;
+			String resultRowCol = String.valueOf(update[0]) + String.valueOf(charToupdate);
+			updateOthers.getValue().setIndexChanged(true);
+			updatedRC.put(resultRowCol, updateOthers.getValue());
+			updatedRC.remove(updateOthers.getKey());
+
+		}
 		setDomainRowCol(updatedRC);
-		
-		/*	for (Map.Entry entry : updatedRC.entrySet()) {
-			System.out.println("Sorted key: "+entry.getKey()+" Sorted value: "+entry.getValue().getName());
-		}*/
-		
+
 		double currDistFromLftM = 11.0;
-		int orgColofCollapsedd = -1;
-		int orgColofDisplayedd = -1;
-		for (Map.Entry cd : updatedRC.entrySet()) {
-			/*for (Domain pl :  collapsedDomainNewL) {
-				for (Map.Entry colCheck : originalDomainRowCol.entrySet()) {
-					if (colCheck.getValue().getName().equals(pl.getName())) {
-						orgColofCollapsedd = Character.getNumericValue(colCheck.getKey().toCharArray()[1]);
-						break;		
-					}
-				}
-				
-				for (Map.Entry colCheckk : originalDomainRowCol.entrySet()) {
-					if (colCheckk.getValue().getName().equals(cd.getValue().getName())) {
-						orgColofDisplayedd = Character.getNumericValue(colCheckk.getKey().toCharArray()[1]);
-						break;		
-					}
-				}
-				
-				if (orgColofCollapsedd < orgColofDisplayedd) {
-					currDistFromLftM+= 3;
-				}
-			}*/
+		for (Map.Entry cd : updatedRC.entrySet()) {
 			Domain d = cd.getValue();
 			double accountPlus = accountForPlusSpaceBefore(d);
-		//	currDistFromLftM+= accountForPlusSpaceBefore(d);
-			d.setDomainToLayoutWd(currDistFromLftM+accountPlus);
+			d.setDomainToLayoutWd(currDistFromLftM + accountPlus);
 			d.computeConatinerPositions();
 			for (Map.Entry entry1 : d.getContainerRowCol().entrySet()) {
 				Container c = entry1.getValue();
@@ -296,420 +245,331 @@ public class Layout {
 					for (Map.Entry entryInner : c.getContainerRowCol().entrySet()) {
 						Container inner = entryInner.getValue();
 						inner.computeElementPositions();
-					}	
+					}
 				}
 			}
-			currDistFromLftM += d.computeSize().getWidth()+2;
-		
+			currDistFromLftM += d.computeSize().getWidth() + 2;
 		}
-		
-		
-		
-		
-		//nline
+
+		// nline
 		// Insert method invocation
 		updatePlusPosition(collapsedDomainNewL, updatedRC);
-		
-		//order changed
+
+		// order changed
 		setCollapsedDomains(collapsedDomainMap);
 		setCollapsedDomainsNewList(collapsedDomainNewL);
-		
-		
+
 		computeDomainPositionsModified();
 		return this;
-   } 
-	
-	
-	
+	}
+
 	public Layout collapseDomainNew(String domainsToCollapse) {
-		
-		   if(domainsToCollapse == null || domainsToCollapse.isEmpty())
-			   return null;
-			   
-			Map updatedRC = new HashMap();
-			
+
+		if (domainsToCollapse == null || domainsToCollapse.isEmpty())
+			return null;
+
+		Map updatedRC = new HashMap<>();
+
+		for (Map.Entry copyEntry : domainRowCol.entrySet()) {
+			updatedRC.put(copyEntry.getKey(), copyEntry.getValue());
+		}
+
+		Map updatedRCSorted = new TreeMap<>(updatedRC);
+
+		Map collapsedDomainMap = getCollapsedDomains();
+
+		List collapsedDomainNewL = getCollapsedDomainsNewList();
+
+		if (collapsedDomainNewL.isEmpty()) {
 			for (Map.Entry copyEntry : domainRowCol.entrySet()) {
-				updatedRC.put(copyEntry.getKey(), copyEntry.getValue());
-				//System.out.println("copyEntry.getKey() "+copyEntry.getKey()+ " copyEntry.getValue() "+copyEntry.getValue());
+				originalDomainRowCol.put(copyEntry.getKey(), copyEntry.getValue());
 			}
-			
-			Map updatedRCSorted = new TreeMap(updatedRC);
-			
-			Map collapsedDomainMap =  getCollapsedDomains();
-			
-			List collapsedDomainNewL = getCollapsedDomainsNewList();
-			
-			
-			if (collapsedDomainNewL.size() == 0) {
-				for (Map.Entry copyEntry : domainRowCol.entrySet()) {
-					originalDomainRowCol.put(copyEntry.getKey(), copyEntry.getValue());
-				//	System.out.println("copyEntry.getKey() "+copyEntry.getKey()+ " copyEntry.getValue() "+copyEntry.getValue());
+		}
+
+		Map updatedRCSortedTrunc = new TreeMap<>();
+
+		int colToDelete = 0;
+		for (Map.Entry entry : updatedRCSorted.entrySet()) {
+			if (entry.getValue().getName().equals(domainsToCollapse)) {
+				if (entry.getValue().isIndexChanged()) {
+					collapsedDomainMap.put("0" + String.valueOf(Integer.parseInt(entry.getKey()) + 1),
+							entry.getValue());
+
+				} else {
+					collapsedDomainMap.put(entry.getKey(), entry.getValue());
 				}
+
+				collapsedDomainNewL.add(entry.getValue());
+				setNumberofColsofDomains(getNumberofColsofDomains() - 1);
+				updatedRC.remove(entry.getKey());
+				colToDelete = Character.getNumericValue(entry.getKey().toCharArray()[1]);
+				break;
 			}
-				
-			
-			Map updatedRCSortedTrunc = new TreeMap();
-		
-				int colToDelete = 0;
-				for (Map.Entry entry : updatedRCSorted.entrySet()) {
-					if (entry.getValue().getName().equals(domainsToCollapse)) {
-						if (entry.getValue().isIndexChanged()) {
-							collapsedDomainMap.put("0"+String.valueOf(Integer.parseInt(entry.getKey())+1), entry.getValue());
-							
-						}
-						//Domain toRemove = entry.getValue();
-						else {
-							collapsedDomainMap.put(entry.getKey(),entry.getValue());
-						}
-						
-						collapsedDomainNewL.add(entry.getValue());
-						setNumberofColsofDomains(getNumberofColsofDomains()-1);
-						updatedRC.remove(entry.getKey());
-						colToDelete = Character.getNumericValue(entry.getKey().toCharArray()[1]);
-						break;
-					}
-				}
-				
-				
-				for (Map.Entry copyEntry : updatedRCSorted.entrySet()) {
-					updatedRCSortedTrunc.put(copyEntry.getKey(), copyEntry.getValue());
-					//System.out.println("copyEntry.getKey() "+copyEntry.getKey()+ " copyEntry.getValue() "+copyEntry.getValue());
-				}
-				
-				for (Map.Entry rmv : updatedRCSorted.entrySet()) {
-					if (Character.getNumericValue(rmv.getKey().toCharArray()[1]) <= colToDelete) {
-						updatedRCSortedTrunc.remove(rmv.getKey());
-					}
-				}
-				
-				
-			/*	for (Map.Entry entry : updatedRCSortedTrunc.entrySet()) {
-					System.out.println("Sorted key: "+entry.getKey()+" Sorted value: "+entry.getValue().getName());
-				}*/
-				
-				for (Map.Entry updateOthers : updatedRCSortedTrunc.entrySet()) {
-							char update[] = updateOthers.getKey().toCharArray();
-							int charToupdate = Character.getNumericValue(update[1]);
-							--charToupdate;
-							String resultRowCol = String.valueOf(update[0])+String.valueOf(charToupdate);
-							updateOthers.getValue().setIndexChanged(true);
-							updatedRC.put(resultRowCol, updateOthers.getValue());
-							updatedRC.remove(updateOthers.getKey());
-				
-				}
-			setDomainRowCol(updatedRC);
-			
-			double currDistFromLftM = 11.0;
-			
-			boolean isDisplayed;
-			for (Map.Entry orgEntry : originalDomainRowCol.entrySet()) {
-				isDisplayed = false;
-				for (Map.Entry cd : updatedRC.entrySet()) {
-					if (cd.getValue().getName().equals(orgEntry.getValue().getName())) {
-						Domain d = cd.getValue();
-						d.setDomainToLayoutWd(currDistFromLftM);
-						d.computeConatinerPositions();
-						for (Map.Entry entry1 : d.getContainerRowCol().entrySet()) {
-							Container c = entry1.getValue();
-							c.computeSize();
-							c.computeElementPositions();
-							if (c.getContainerRowCol() != null) {
-								for (Map.Entry entryInner : c.getContainerRowCol().entrySet()) {
-									Container inner = entryInner.getValue();
-									inner.computeElementPositions();
-								}	
+		}
+
+		for (Map.Entry copyEntry : updatedRCSorted.entrySet()) {
+			updatedRCSortedTrunc.put(copyEntry.getKey(), copyEntry.getValue());
+		}
+
+		for (Map.Entry rmv : updatedRCSorted.entrySet()) {
+			if (Character.getNumericValue(rmv.getKey().toCharArray()[1]) <= colToDelete) {
+				updatedRCSortedTrunc.remove(rmv.getKey());
+			}
+		}
+
+		for (Map.Entry updateOthers : updatedRCSortedTrunc.entrySet()) {
+			char[] update = updateOthers.getKey().toCharArray();
+			int charToupdate = Character.getNumericValue(update[1]);
+			--charToupdate;
+			String resultRowCol = String.valueOf(update[0]) + String.valueOf(charToupdate);
+			updateOthers.getValue().setIndexChanged(true);
+			updatedRC.put(resultRowCol, updateOthers.getValue());
+			updatedRC.remove(updateOthers.getKey());
+
+		}
+		setDomainRowCol(updatedRC);
+
+		double currDistFromLftM = 11.0;
+
+		boolean isDisplayed;
+		for (Map.Entry orgEntry : originalDomainRowCol.entrySet()) {
+			isDisplayed = false;
+			for (Map.Entry cd : updatedRC.entrySet()) {
+				if (cd.getValue().getName().equals(orgEntry.getValue().getName())) {
+					Domain d = cd.getValue();
+					d.setDomainToLayoutWd(currDistFromLftM);
+					d.computeConatinerPositions();
+					for (Map.Entry entry1 : d.getContainerRowCol().entrySet()) {
+						Container c = entry1.getValue();
+						c.computeSize();
+						c.computeElementPositions();
+						if (c.getContainerRowCol() != null) {
+							for (Map.Entry entryInner : c.getContainerRowCol().entrySet()) {
+								Container inner = entryInner.getValue();
+								inner.computeElementPositions();
 							}
 						}
-						currDistFromLftM += d.computeSize().getWidth()+1;
-						isDisplayed = true;
-						break;
 					}
-				}
-			
-				if (!isDisplayed) {
-					Domain myCollapsed = orgEntry.getValue(); 
-					myCollapsed.setNewXafterColl(currDistFromLftM);
-					myCollapsed.setYafterColl(myCollapsed.getP().getY());
-					currDistFromLftM += 4;
+					currDistFromLftM += d.computeSize().getWidth() + 1;
+					isDisplayed = true;
+					break;
 				}
 			}
-			
-			setCollapsedDomains(collapsedDomainMap);
-			setCollapsedDomainsNewList(collapsedDomainNewL);
-			
-			
-			computeDomainPositionsModified();
-			return this;
-	
+
+			if (!isDisplayed) {
+				Domain myCollapsed = orgEntry.getValue();
+				myCollapsed.setNewXafterColl(currDistFromLftM);
+				myCollapsed.setYafterColl(myCollapsed.getP().getY());
+				currDistFromLftM += 4;
+			}
+		}
+
+		setCollapsedDomains(collapsedDomainMap);
+		setCollapsedDomainsNewList(collapsedDomainNewL);
+
+		computeDomainPositionsModified();
+		return this;
+
 	}
-	
-	
+
 	public Layout collapseDomain(String domainsToCollapse) {
-		
-		Map updatedRC = new HashMap();
-		
+
+		Map updatedRC = new HashMap<>();
+
 		for (Map.Entry copyEntry : domainRowCol.entrySet()) {
 			updatedRC.put(copyEntry.getKey(), copyEntry.getValue());
-			//System.out.println("copyEntry.getKey() "+copyEntry.getKey()+ " copyEntry.getValue() "+copyEntry.getValue());
 		}
-		
-		Map updatedRCSorted = new TreeMap(updatedRC);
-		
-		Map collapsedDomainMap =  getCollapsedDomains();
-		
+
+		Map updatedRCSorted = new TreeMap<>(updatedRC);
+
+		Map collapsedDomainMap = getCollapsedDomains();
+
 		if (collapsedDomainMap.size() == 0) {
 			for (Map.Entry copyEntry : domainRowCol.entrySet()) {
 				originalDomainRowCol.put(copyEntry.getKey(), copyEntry.getValue());
-			//	System.out.println("copyEntry.getKey() "+copyEntry.getKey()+ " copyEntry.getValue() "+copyEntry.getValue());
 			}
 		}
-			
-		
-	//	List collapsedDomainsList =  getCollapsedDomains();
-	
-	/*	for (Map.Entry entry : updatedRCSorted.entrySet()) {
-			System.out.println("Sorted Key: "+entry.getKey());
-		}*/
-		
+
 		double prevDomXCordinate = 0.0;
-		Map updatedRCSortedTrunc = new TreeMap();
-	//	for (String dToCollapse : domainsToCollapse) {
-			int colToDelete = 0;
-			for (Map.Entry entry : updatedRCSorted.entrySet()) {
-				if (entry.getValue().getName().equals(domainsToCollapse)) {
-					if (entry.getValue().isIndexChanged())
-						collapsedDomainMap.put("0"+String.valueOf(Integer.parseInt(entry.getKey())+1), entry.getValue());
-					//Domain toRemove = entry.getValue();
-					else
-						collapsedDomainMap.put(entry.getKey(),entry.getValue());
-					prevDomXCordinate = entry.getValue().getP().getX();
-					entry.getValue().getP().setX(prevDomXCordinate-2);
-				//	toRemove.setCollapsed(true);
-					setNumberofColsofDomains(getNumberofColsofDomains()-1);
-					updatedRC.remove(entry.getKey());
-					colToDelete = Character.getNumericValue(entry.getKey().toCharArray()[1]);
-				//	collapsedDomainList.put(entry.getKey(),entry.getValue());
-					break;
-				}
-			}
-			
-		/*	for (Map.Entry entry : updatedRC.entrySet()) {
-				System.out.println("Sorted key: "+entry.getKey()+" Sorted value: "+entry.getValue().getName());
-			}*/
-			
-			setCollapsedDomains(collapsedDomainMap);
-			
-			for (Map.Entry copyEntry : updatedRCSorted.entrySet()) {
-				updatedRCSortedTrunc.put(copyEntry.getKey(), copyEntry.getValue());
-				//System.out.println("copyEntry.getKey() "+copyEntry.getKey()+ " copyEntry.getValue() "+copyEntry.getValue());
+		Map updatedRCSortedTrunc = new TreeMap<>();
+		int colToDelete = 0;
+		for (Map.Entry entry : updatedRCSorted.entrySet()) {
+			if (entry.getValue().getName().equals(domainsToCollapse)) {
+				if (entry.getValue().isIndexChanged())
+					collapsedDomainMap.put("0" + String.valueOf(Integer.parseInt(entry.getKey()) + 1),
+							entry.getValue());
+				else
+					collapsedDomainMap.put(entry.getKey(), entry.getValue());
+				prevDomXCordinate = entry.getValue().getP().getX();
+				entry.getValue().getP().setX(prevDomXCordinate - 2);
+				setNumberofColsofDomains(getNumberofColsofDomains() - 1);
+				updatedRC.remove(entry.getKey());
+				colToDelete = Character.getNumericValue(entry.getKey().toCharArray()[1]);
+				break;
 			}
-			
-			for (Map.Entry rmv : updatedRCSorted.entrySet()) {
-				if (Character.getNumericValue(rmv.getKey().toCharArray()[1]) <= colToDelete) {
-					updatedRCSortedTrunc.remove(rmv.getKey());
-				}
-			}
-			
-			
-		/*	for (Map.Entry entry : updatedRCSortedTrunc.entrySet()) {
-				System.out.println("Sorted key: "+entry.getKey()+" Sorted value: "+entry.getValue().getName());
-			}*/
-			
-			for (Map.Entry updateOthers : updatedRCSortedTrunc.entrySet()) {
-			//	if (!updateOthers.getValue().getName().equals(dToCollapse)) {
-				//	if ((int)updateOthers.getKey().toCharArray()[1] > colToDelete) {
-						char update[] = updateOthers.getKey().toCharArray();
-						int charToupdate = Character.getNumericValue(update[1]);
-						--charToupdate;
-						String resultRowCol = String.valueOf(update[0])+String.valueOf(charToupdate);
-					//	update[1] = (char)charToupdate; 
-					//	updatedRC.put(String.valueOf(update), updateOthers.getValue());
-						updateOthers.getValue().setIndexChanged(true);
-						updatedRC.put(resultRowCol, updateOthers.getValue());
-						updatedRC.remove(updateOthers.getKey());
-				//	}
-			//	}
+		}
+
+		setCollapsedDomains(collapsedDomainMap);
+
+		for (Map.Entry copyEntry : updatedRCSorted.entrySet()) {
+			updatedRCSortedTrunc.put(copyEntry.getKey(), copyEntry.getValue());
+		}
+
+		for (Map.Entry rmv : updatedRCSorted.entrySet()) {
+			if (Character.getNumericValue(rmv.getKey().toCharArray()[1]) <= colToDelete) {
+				updatedRCSortedTrunc.remove(rmv.getKey());
 			}
-		
-	//	}
+		}
+
+		for (Map.Entry updateOthers : updatedRCSortedTrunc.entrySet()) {
+			char update[] = updateOthers.getKey().toCharArray();
+			int charToupdate = Character.getNumericValue(update[1]);
+			--charToupdate;
+			String resultRowCol = String.valueOf(update[0]) + String.valueOf(charToupdate);
+			updateOthers.getValue().setIndexChanged(true);
+			updatedRC.put(resultRowCol, updateOthers.getValue());
+			updatedRC.remove(updateOthers.getKey());
+
+		}
+
 		setDomainRowCol(updatedRC);
-		
-		
-		
+
 		for (Map.Entry entry : updatedRCSortedTrunc.entrySet()) {
 			Domain d = entry.getValue();
-		//	if (d.getName().equals("Datacenter with AIC") || d.getName().equals("VNI")) {
-			//	d.setDomainToLayoutWd(d.getDomainToLayoutWd()-33);
-				if (collapsedDomains.size() == 2 && collapsedDomains.containsKey("00") && collapsedDomains.containsKey("01") && domainsToCollapse.equals("RAN")) {
-					if (d.getName().equals("USP"))
-						d.setDomainToLayoutWd(prevDomXCordinate);
-					else if (d.getName().equals("VNI"))
-						d.setDomainToLayoutWd(prevDomXCordinate+8);
-					else
-						d.setDomainToLayoutWd(prevDomXCordinate+10);
-					//System.out.println("Inside RAN EPC");
-				} 
-				else if (domainsToCollapse.equals("RAN") && !d.getName().equals("EPC") && collapsedDomains.size() < 3)
-					d.setDomainToLayoutWd(prevDomXCordinate+11);
-				else if (domainsToCollapse.equals("RAN") && collapsedDomains.size() == 3 && collapsedDomains.containsKey("01") && collapsedDomains.containsKey("04")) {
-					if (d.getName().equals("USP"))
-						d.setDomainToLayoutWd(prevDomXCordinate);
-					else
-						d.setDomainToLayoutWd(prevDomXCordinate+10);
-				}
-					
-				else if (collapsedDomains.containsKey("00") && collapsedDomains.size() == 3 && collapsedDomains.containsKey("01") && collapsedDomains.containsKey("02")) {
-					//System.out.println("Inside test");
-					if (d.getName().equals("VNI"))
-						d.setDomainToLayoutWd(prevDomXCordinate+10);
-					else
-						d.setDomainToLayoutWd(prevDomXCordinate);
-					
-				}
-				
-				else if (collapsedDomains.containsKey("00") && collapsedDomains.size() == 3 && collapsedDomains.containsKey("01") && collapsedDomains.containsKey("03")) {
-					//System.out.println("Inside test");
-					if (d.getName().equals("VNI"))
-						d.setDomainToLayoutWd(prevDomXCordinate+10);
-					else
-						d.setDomainToLayoutWd(prevDomXCordinate);
-					
-				}
-				
-				
-				
-				else {
+			if (collapsedDomains.size() == 2 && collapsedDomains.containsKey("00") && collapsedDomains.containsKey("01")
+					&& domainsToCollapse.equals("RAN")) {
+				if (d.getName().equals("USP"))
 					d.setDomainToLayoutWd(prevDomXCordinate);
-				}
-				d.computeConatinerPositions();
-				prevDomXCordinate = d.getP().getX();
-				for (Map.Entry entry1 : d.getContainerRowCol().entrySet()) {
-					Container c = entry1.getValue();
-					c.computeSize();
-					c.computeElementPositions();
-					if (c.getContainerRowCol() != null) {
-						for (Map.Entry entryInner : c.getContainerRowCol().entrySet()) {
-							Container inner = entryInner.getValue();
-							inner.computeElementPositions();
-						}	
+				else if (d.getName().equals("VNI"))
+					d.setDomainToLayoutWd(prevDomXCordinate + 8);
+				else
+					d.setDomainToLayoutWd(prevDomXCordinate + 10);
+			} else if (domainsToCollapse.equals("RAN") && !d.getName().equals("EPC") && collapsedDomains.size() < 3)
+				d.setDomainToLayoutWd(prevDomXCordinate + 11);
+			else if (domainsToCollapse.equals("RAN") && collapsedDomains.size() == 3
+					&& collapsedDomains.containsKey("01") && collapsedDomains.containsKey("04")) {
+				if (d.getName().equals("USP"))
+					d.setDomainToLayoutWd(prevDomXCordinate);
+				else
+					d.setDomainToLayoutWd(prevDomXCordinate + 10);
+			}
+
+			else if (collapsedDomains.containsKey("00") && collapsedDomains.size() == 3
+					&& collapsedDomains.containsKey("01") && collapsedDomains.containsKey("02")) {
+				if (d.getName().equals("VNI"))
+					d.setDomainToLayoutWd(prevDomXCordinate + 10);
+				else
+					d.setDomainToLayoutWd(prevDomXCordinate);
+
+			}
+
+			else if (collapsedDomains.containsKey("00") && collapsedDomains.size() == 3
+					&& collapsedDomains.containsKey("01") && collapsedDomains.containsKey("03")) {
+				if (d.getName().equals("VNI"))
+					d.setDomainToLayoutWd(prevDomXCordinate + 10);
+				else
+					d.setDomainToLayoutWd(prevDomXCordinate);
+
+			}
+
+			else {
+				d.setDomainToLayoutWd(prevDomXCordinate);
+			}
+			d.computeConatinerPositions();
+			prevDomXCordinate = d.getP().getX();
+			for (Map.Entry entry1 : d.getContainerRowCol().entrySet()) {
+				Container c = entry1.getValue();
+				c.computeSize();
+				c.computeElementPositions();
+				if (c.getContainerRowCol() != null) {
+					for (Map.Entry entryInner : c.getContainerRowCol().entrySet()) {
+						Container inner = entryInner.getValue();
+						inner.computeElementPositions();
 					}
 				}
-		//	}
-		//	System.out.println("Sorted key: "+entry.getKey()+" Sorted value: "+entry.getValue().getName());
-		} 
-	//	setNumberofColsofDomains(getNumberofColsofDomains()-1);
+			}
+		}
 		computeDomainPositions();
 		return this;
-	/*	CoordinateMain cm = new CoordinateMain();
-		try {
-			cm.convertToYAML(this);
-		} catch (Exception e) {
-			
-		}*/
-		
-	} 
-	
+
+	}
+
 	public Layout uncollapseDomainModified(String domainToUnCollapse) {
-		 Map currentDomainsSorted = new TreeMap(domainRowCol);
-		 Map updateDomains = new TreeMap();
-		 Map collapsedDomainList =  getCollapsedDomains();
-		 Map collapsedDomainListSorted =  new TreeMap(collapsedDomainList);
-	
-		 List domainstoUpd = new ArrayList();
-		 
-		 int colToUnCollapse = 99;
-		 
-		 Domain domainToInsert = null;
-		 
-		 if (collapsedDomains.size() == 0) {
-			 for (Map.Entry unindexDomain : originalDomainRowCol.entrySet()) {
-				 Domain dm = unindexDomain.getValue();
-				 dm.setIndexChanged(false);
-			 }
-		 }
-		 
-		 
-		 for (Map.Entry entry : collapsedDomainListSorted.entrySet()) {
-			 if (entry.getValue().getName().equals(domainToUnCollapse)) {
-				 colToUnCollapse  = Character.getNumericValue(entry.getKey().toCharArray()[1]);
-				 domainToInsert = entry.getValue(); 
-				 collapsedDomainList.remove(entry.getKey());
-				 break;
-			 }
-		 }
-		 
-		 domainstoUpd.add(domainToInsert);
-		 
-		 //for (Map.Entry e : originalDomainRowCol.entrySet())
-		 //   System.out.println("Original key value"+e.getKey()+":"+e.getValue().getName());
-		 
-		 int lastKeyCol = -1;
-		 for (Map.Entry entry : originalDomainRowCol.entrySet()) {
-			 int currcol  = Character.getNumericValue(entry.getKey().toCharArray()[1]);
-			 if (currcol < colToUnCollapse) {
-				 for (Map.Entry currDomainsEntry : currentDomainsSorted.entrySet()) {
-					 if (currDomainsEntry.getValue().getName().equals(entry.getValue().getName())) {
-						 updateDomains.put(currDomainsEntry.getKey(), currDomainsEntry.getValue());
-						 lastKeyCol = Character.getNumericValue(currDomainsEntry.getKey().toCharArray()[1]);
-						 break;
-					 }
-				 }	 
+		Map currentDomainsSorted = new TreeMap<>(domainRowCol);
+		Map updateDomains = new TreeMap<>();
+		Map collapsedDomainList = getCollapsedDomains();
+		Map collapsedDomainListSorted = new TreeMap<>(collapsedDomainList);
+
+		List domainstoUpd = new ArrayList<>();
+
+		int colToUnCollapse = 99;
+
+		Domain domainToInsert = null;
+
+		if (collapsedDomains.size() == 0) {
+			for (Map.Entry unindexDomain : originalDomainRowCol.entrySet()) {
+				Domain dm = unindexDomain.getValue();
+				dm.setIndexChanged(false);
+			}
+		}
+
+		for (Map.Entry entry : collapsedDomainListSorted.entrySet()) {
+			if (entry.getValue().getName().equals(domainToUnCollapse)) {
+				colToUnCollapse = Character.getNumericValue(entry.getKey().toCharArray()[1]);
+				domainToInsert = entry.getValue();
+				collapsedDomainList.remove(entry.getKey());
+				break;
+			}
+		}
+
+		domainstoUpd.add(domainToInsert);
+
+		int lastKeyCol = -1;
+		for (Map.Entry entry : originalDomainRowCol.entrySet()) {
+			int currcol = Character.getNumericValue(entry.getKey().toCharArray()[1]);
+			if (currcol < colToUnCollapse) {
+				for (Map.Entry currDomainsEntry : currentDomainsSorted.entrySet()) {
+					if (currDomainsEntry.getValue().getName().equals(entry.getValue().getName())) {
+						updateDomains.put(currDomainsEntry.getKey(), currDomainsEntry.getValue());
+						lastKeyCol = Character.getNumericValue(currDomainsEntry.getKey().toCharArray()[1]);
+						break;
+					}
+				}
 			} else {
-				String newKey = "0"+String.valueOf(lastKeyCol+1);
+				String newKey = "0" + String.valueOf(lastKeyCol + 1);
 				if (currcol == colToUnCollapse) {
 					updateDomains.put(newKey, domainToInsert);
 					++lastKeyCol;
 				} else {
 					for (Map.Entry currDomainsEnt : currentDomainsSorted.entrySet()) {
-						 if (currDomainsEnt.getValue().getName().equals(entry.getValue().getName())) {
-							 updateDomains.put(newKey, currDomainsEnt.getValue());
-							 domainstoUpd.add(currDomainsEnt.getValue());
-							 ++lastKeyCol;
-							 // lastKeyCol = Character.getNumericValue(currDomainsEntry.getKey().toCharArray()[1]);
-							 break;
-						 }
-					 }
+						if (currDomainsEnt.getValue().getName().equals(entry.getValue().getName())) {
+							updateDomains.put(newKey, currDomainsEnt.getValue());
+							domainstoUpd.add(currDomainsEnt.getValue());
+							++lastKeyCol;
+							break;
+						}
+					}
 				}
-				
+
 			}
-		 }
-		 
-		 setNumberofColsofDomains(getNumberofColsofDomains()+1);
-		 setDomainRowCol(updateDomains);
-		 setCollapsedDomains(collapsedDomainList);
-		 
-		 //for (Map.Entry e : updateDomains.entrySet())
-		 //    System.out.println("me Updatedomains key value"+e.getKey()+":"+e.getValue().getName());
-		 
-		// for (int i = 1; i < domainstoUpd.size(); i++) {
-		 for (int i = 0; i < domainstoUpd.size(); i++) {
+		}
+
+		setNumberofColsofDomains(getNumberofColsofDomains() + 1);
+		setDomainRowCol(updateDomains);
+		setCollapsedDomains(collapsedDomainList);
+
+		for (int i = 0; i < domainstoUpd.size(); i++) {
 			Domain d = domainstoUpd.get(i);
 			double newX = 0.0;
-			if (i+1 < domainstoUpd.size()) 
-			//	newX = domainstoUpd.get(i-1).getP().getX()+domainstoUpd.get(i-1).computeSize().getWidth()+5;
-				newX = domainstoUpd.get(i+1).getP().getX();
-				//d.setDomainToLayoutWd(domainstoUpd.get(i+1).getP().getX());
+			if (i + 1 < domainstoUpd.size())
+				newX = domainstoUpd.get(i + 1).getP().getX();
 			else
-				newX = domainstoUpd.get(i).getP().getX()+32;
-				//	d.setDomainToLayoutWd(domainstoUpd.get(i).getP().getX()+38);
-		/*	if (i > 0) {
-				if (d.getWidth() < domainstoUpd.get(i-1).getWidth())
-					newX+= domainstoUpd.get(i-1).getWidth() - d.getWidth();
-				else if (d.getWidth() > domainstoUpd.get(i-1).getWidth())
-					newX-= d.getWidth() -  domainstoUpd.get(i-1).getWidth() ;
-			} else {
-				if (d.getWidth() < domainInserted.getWidth())
-					newX+= domainInserted.getWidth() - d.getWidth();
-				else if (d.getWidth() > domainInserted.getWidth())
-					newX-= d.getWidth() - domainInserted.getWidth() ;
-			}*/
+				newX = domainstoUpd.get(i).getP().getX() + 32;
+
 			if (d.getName().equals("Datacenter with AIC"))
-				newX+= 2;
+				newX += 2;
 			d.setDomainToLayoutWd(newX);
-			/*	if (i == 0)
-				d.setDomainToLayoutWd(domainInserted.getP().getX()+domainInserted.getWidth());
-			else 
-				d.setDomainToLayoutWd(domainstoUpd.get(i-1).getP().getX()+domainstoUpd.get(i-1).getWidth());*/
+
 			d.computeConatinerPositions();
 			for (Map.Entry entry1 : d.getContainerRowCol().entrySet()) {
 				Container c = entry1.getValue();
@@ -719,108 +579,62 @@ public class Layout {
 					for (Map.Entry entryInner : c.getContainerRowCol().entrySet()) {
 						Container inner = entryInner.getValue();
 						inner.computeElementPositions();
-					}	
+					}
 				}
 			}
-			//	}
-			//	System.out.println("Sorted key: "+entry.getKey()+" Sorted value: "+entry.getValue().getName());
-		} 
-		 
-		 computeDomainPositions();
-		 return this;
-	
+
+		}
+
+		computeDomainPositions();
+		return this;
+
 	}
-	
-	
-	
+
 	public Layout uncollapseDomain(String domainToCollapse) {
-		 Map currentDomainsSorted = new TreeMap(domainRowCol);
-		 Map updateDomains = new TreeMap();
-		 Map collapsedDomainList =  getCollapsedDomains();
-		 Map collapsedDomainListSorted =  new TreeMap(collapsedDomainList);
-		 
-		 List domainstoUpd = new ArrayList();
-	/*	 for (Map.Entry entry : collapsedDomainListSorted.entrySet()) {
-			 if (entry.getValue().getName().equals("domainToCollapse")) {
-				 if (currentDomainsSorted != null) {
-					 if (!currentDomainsSorted.containsKey(entry.getKey())) {
-						  updateDomains.put(entry.getKey(), entry.getValue());
-						  collapsedDomainList.remove(entry.getKey());
-						  break;
-					 } else {
-						 int colToUnCollapse  = Character.getNumericValue(entry.getKey().toCharArray()[1]);
-						 for (Map.Entry curr : currentDomainsSorted.entrySet()) {
-							 if (Character.getNumericValue(curr.getKey().toCharArray()[1]) < colToUnCollapse) {
-								updateDomains.put(curr.getKey(),curr.getValue());
-							 } else {
-								 updateDomains.put(curr.getKey()+1,curr.getValue());
-								 
-							 }
-						 }
-						 updateDomains.put(entry.getKey(), entry.getValue()); 
-					 }
-				 }
-				 
-				 
-			 }
-		 }*/
-		 
-		 Domain domainInserted = null;
-		 for (Map.Entry entry : collapsedDomainListSorted.entrySet()) {
-			 if (entry.getValue().getName().equals(domainToCollapse)) {
-				 domainInserted = entry.getValue();
-				 if (currentDomainsSorted != null) {
-					 int colToUnCollapse  = Character.getNumericValue(entry.getKey().toCharArray()[1]);
-					 for (Map.Entry curr : currentDomainsSorted.entrySet()) {
-						 if (Character.getNumericValue(curr.getKey().toCharArray()[1]) < colToUnCollapse) {
-							updateDomains.put(curr.getKey(),curr.getValue());
-						 } else {
-							 updateDomains.put("0"+String.valueOf(Integer.parseInt(curr.getKey())+1),curr.getValue());
-							 domainstoUpd.add(curr.getValue());
-						 }
-					 }
-				 }	 
-				 updateDomains.put(entry.getKey(), entry.getValue()); 
-				 collapsedDomainList.remove(entry.getKey());
-				 break;
-				 
-			 }
-		 }
-		 setNumberofColsofDomains(getNumberofColsofDomains()+1);
-		 setDomainRowCol(updateDomains);
-		 setCollapsedDomains(collapsedDomainList);
-		 
-		 //for (Map.Entry e : updateDomains.entrySet())
-		 //    System.out.println("Updatedomains key value"+e.getKey()+":"+e.getValue().getName());
-		 
-		 
-		 for (int i = 0; i < domainstoUpd.size(); i++) {
+		Map currentDomainsSorted = new TreeMap<>(domainRowCol);
+		Map updateDomains = new TreeMap();
+		Map collapsedDomainList = getCollapsedDomains();
+		Map collapsedDomainListSorted = new TreeMap(collapsedDomainList);
+
+		List domainstoUpd = new ArrayList<>();
+		for (Map.Entry entry : collapsedDomainListSorted.entrySet()) {
+			if (entry.getValue().getName().equals(domainToCollapse)) {
+				Domain domainInserted = entry.getValue();
+				if (currentDomainsSorted != null) {
+					int colToUnCollapse = Character.getNumericValue(entry.getKey().toCharArray()[1]);
+					for (Map.Entry curr : currentDomainsSorted.entrySet()) {
+						if (Character.getNumericValue(curr.getKey().toCharArray()[1]) < colToUnCollapse) {
+							updateDomains.put(curr.getKey(), curr.getValue());
+						} else {
+							updateDomains.put("0" + String.valueOf(Integer.parseInt(curr.getKey()) + 1),
+									curr.getValue());
+							domainstoUpd.add(curr.getValue());
+						}
+					}
+				}
+				updateDomains.put(entry.getKey(), entry.getValue());
+				collapsedDomainList.remove(entry.getKey());
+				break;
+
+			}
+		}
+		setNumberofColsofDomains(getNumberofColsofDomains() + 1);
+		setDomainRowCol(updateDomains);
+		setCollapsedDomains(collapsedDomainList);
+
+		for (int i = 0; i < domainstoUpd.size(); i++) {
 			Domain d = domainstoUpd.get(i);
 			double newX = 0.0;
-			if (i+1 < domainstoUpd.size()) 
-				newX = domainstoUpd.get(i+1).getP().getX();
-				//d.setDomainToLayoutWd(domainstoUpd.get(i+1).getP().getX());
+			if (i + 1 < domainstoUpd.size())
+				newX = domainstoUpd.get(i + 1).getP().getX();
+			// d.setDomainToLayoutWd(domainstoUpd.get(i+1).getP().getX());
 			else
-				newX = domainstoUpd.get(i).getP().getX()+38;
-				//	d.setDomainToLayoutWd(domainstoUpd.get(i).getP().getX()+38);
-		/*	if (i > 0) {
-				if (d.getWidth() < domainstoUpd.get(i-1).getWidth())
-					newX+= domainstoUpd.get(i-1).getWidth() - d.getWidth();
-				else if (d.getWidth() > domainstoUpd.get(i-1).getWidth())
-					newX-= d.getWidth() -  domainstoUpd.get(i-1).getWidth() ;
-			} else {
-				if (d.getWidth() < domainInserted.getWidth())
-					newX+= domainInserted.getWidth() - d.getWidth();
-				else if (d.getWidth() > domainInserted.getWidth())
-					newX-= d.getWidth() - domainInserted.getWidth() ;
-			}*/
+				newX = domainstoUpd.get(i).getP().getX() + 38;
+
 			if (d.getName().equals("Datacenter with AIC"))
-				newX+= 5;
+				newX += 5;
 			d.setDomainToLayoutWd(newX);
-			/*	if (i == 0)
-				d.setDomainToLayoutWd(domainInserted.getP().getX()+domainInserted.getWidth());
-			else 
-				d.setDomainToLayoutWd(domainstoUpd.get(i-1).getP().getX()+domainstoUpd.get(i-1).getWidth());*/
+
 			d.computeConatinerPositions();
 			for (Map.Entry entry1 : d.getContainerRowCol().entrySet()) {
 				Container c = entry1.getValue();
@@ -830,102 +644,88 @@ public class Layout {
 					for (Map.Entry entryInner : c.getContainerRowCol().entrySet()) {
 						Container inner = entryInner.getValue();
 						inner.computeElementPositions();
-					}	
+					}
 				}
 			}
-			//	}
-			//	System.out.println("Sorted key: "+entry.getKey()+" Sorted value: "+entry.getValue().getName());
-		} 
-		 
-		 computeDomainPositions();
-		 return this;
+		}
+
+		computeDomainPositions();
+		return this;
 	}
 
 	public Layout uncollapseDomainNew(String domainToUnCollapse) {
-		 Map currentDomainsSorted = new TreeMap(domainRowCol);
-		 Map updateDomains = new TreeMap();
-		 Map collapsedDomainList =  getCollapsedDomains();
-		 Map collapsedDomainListSorted =  new TreeMap(collapsedDomainList);
-	
-		 List domainstoUpd = new ArrayList();
-		 
-		 //nline
-		 List collapsedDomainNewLL = getCollapsedDomainsNewList();
-		 
-		 int colToUnCollapse = 99;
-		 
-		 Domain domainToInsert = null;
-		 
-		 //nline
-		 //	 if (collapsedDomains.size() == 0) {
-		 if (collapsedDomainNewLL.size() == 0) {
-			 for (Map.Entry unindexDomain : originalDomainRowCol.entrySet()) {
-				 Domain dm = unindexDomain.getValue();
-				 dm.setIndexChanged(false);
-			 }
-		 }
-		 
-		 
-		 for (Map.Entry entry : originalDomainRowCol.entrySet()) {
-			 if (entry.getValue().getName().equals(domainToUnCollapse)) {
-				 colToUnCollapse  = Character.getNumericValue(entry.getKey().toCharArray()[1]);
-				 domainToInsert = entry.getValue(); 
-				 collapsedDomainList.remove(entry.getKey());
-				 //nline
-				 collapsedDomainNewLL.remove(entry.getValue());
-				 break;
-			 }
-		 }
-		 
-		 domainstoUpd.add(domainToInsert);
-		 
-		// for (Map.Entry e : originalDomainRowCol.entrySet())
-		//     System.out.println("Original key value"+e.getKey()+":"+e.getValue().getName());
-		 
-		 int lastKeyCol = -1;
-		 for (Map.Entry entry : originalDomainRowCol.entrySet()) {
-			 int currcol  = Character.getNumericValue(entry.getKey().toCharArray()[1]);
-			 if (currcol < colToUnCollapse) {
-				 for (Map.Entry currDomainsEntry : currentDomainsSorted.entrySet()) {
-					 if (currDomainsEntry.getValue().getName().equals(entry.getValue().getName())) {
-						 updateDomains.put(currDomainsEntry.getKey(), currDomainsEntry.getValue());
-						 lastKeyCol = Character.getNumericValue(currDomainsEntry.getKey().toCharArray()[1]);
-						 break;
-					 }
-				 }	 
+		Map currentDomainsSorted = new TreeMap(domainRowCol);
+		Map updateDomains = new TreeMap();
+		Map collapsedDomainList = getCollapsedDomains();
+
+		List domainstoUpd = new ArrayList<>();
+
+		// nline
+		List collapsedDomainNewLL = getCollapsedDomainsNewList();
+
+		int colToUnCollapse = 99;
+
+		Domain domainToInsert = null;
+
+		// nline
+		if (collapsedDomainNewLL.isEmpty()) {
+			for (Map.Entry unindexDomain : originalDomainRowCol.entrySet()) {
+				Domain dm = unindexDomain.getValue();
+				dm.setIndexChanged(false);
+			}
+		}
+
+		for (Map.Entry entry : originalDomainRowCol.entrySet()) {
+			if (entry.getValue().getName().equals(domainToUnCollapse)) {
+				colToUnCollapse = Character.getNumericValue(entry.getKey().toCharArray()[1]);
+				domainToInsert = entry.getValue();
+				collapsedDomainList.remove(entry.getKey());
+				// nline
+				collapsedDomainNewLL.remove(entry.getValue());
+				break;
+			}
+		}
+
+		domainstoUpd.add(domainToInsert);
+
+		int lastKeyCol = -1;
+		for (Map.Entry entry : originalDomainRowCol.entrySet()) {
+			int currcol = Character.getNumericValue(entry.getKey().toCharArray()[1]);
+			if (currcol < colToUnCollapse) {
+				for (Map.Entry currDomainsEntry : currentDomainsSorted.entrySet()) {
+					if (currDomainsEntry.getValue().getName().equals(entry.getValue().getName())) {
+						updateDomains.put(currDomainsEntry.getKey(), currDomainsEntry.getValue());
+						lastKeyCol = Character.getNumericValue(currDomainsEntry.getKey().toCharArray()[1]);
+						break;
+					}
+				}
 			} else {
-				String newKey = "0"+String.valueOf(lastKeyCol+1);
+				String newKey = "0" + String.valueOf(lastKeyCol + 1);
 				if (currcol == colToUnCollapse) {
 					updateDomains.put(newKey, domainToInsert);
 					++lastKeyCol;
 				} else {
 					for (Map.Entry currDomainsEnt : currentDomainsSorted.entrySet()) {
-						 if (currDomainsEnt.getValue().getName().equals(entry.getValue().getName())) {
-							 updateDomains.put(newKey, currDomainsEnt.getValue());
-							 domainstoUpd.add(currDomainsEnt.getValue());
-							 ++lastKeyCol;
-							 // lastKeyCol = Character.getNumericValue(currDomainsEntry.getKey().toCharArray()[1]);
-							 break;
-						 }
-					 }
+						if (currDomainsEnt.getValue().getName().equals(entry.getValue().getName())) {
+							updateDomains.put(newKey, currDomainsEnt.getValue());
+							domainstoUpd.add(currDomainsEnt.getValue());
+							++lastKeyCol;
+							break;
+						}
+					}
 				}
-				
+
 			}
-		 }
-		 
-		setNumberofColsofDomains(getNumberofColsofDomains()+1);
+		}
+
+		setNumberofColsofDomains(getNumberofColsofDomains() + 1);
 		setDomainRowCol(updateDomains);
-		 
-		//for (Map.Entry e : updateDomains.entrySet())
-		//	System.out.println("me Updatedomains key value"+e.getKey()+":"+e.getValue().getName());
-		 
-		
-		 
+
 		double currDistFromLftMargin = 11.0;
-		for (Map.Entry cd : updateDomains.entrySet()) {
+		for (Map.Entry cd : updateDomains.entrySet()) {
 			Domain d = cd.getValue();
 			double accountPlus = accountForPlusSpaceBefore(d);
-			d.setDomainToLayoutWd(currDistFromLftMargin+accountPlus);
+			d.setDomainToLayoutWd(currDistFromLftMargin + accountPlus);
 			d.computeConatinerPositions();
 			for (Map.Entry entry1 : d.getContainerRowCol().entrySet()) {
 				Container c = entry1.getValue();
@@ -935,119 +735,105 @@ public class Layout {
 					for (Map.Entry entryInner : c.getContainerRowCol().entrySet()) {
 						Container inner = entryInner.getValue();
 						inner.computeElementPositions();
-					}	
+					}
 				}
 			}
-			currDistFromLftMargin += d.computeSize().getWidth()+2;
-		
+			currDistFromLftMargin += d.computeSize().getWidth() + 2;
+
 		}
-		
-		 //nline
+
+		// nline
 		updatePlusPosition(collapsedDomainNewLL, updateDomains);
-		
-		 //order changed
+
+		// order changed
 		setCollapsedDomains(collapsedDomainList);
-		 
-		 //nline
+
+		// nline
 		setCollapsedDomainsNewList(collapsedDomainNewLL);
-		
-		
+
 		computeDomainPositionsModified();
 		return this;
-		
-	}	
-		
+
+	}
+
 	public Layout uncollapseDomainNew1(String domainToUnCollapse) {
-		
-		 if(domainToUnCollapse == null || domainToUnCollapse.isEmpty())
-			   return null;
-		 
-		 Map currentDomainsSorted = new TreeMap(domainRowCol);
-		 Map updateDomains = new TreeMap();
-		 Map collapsedDomainList =  getCollapsedDomains();
-		 Map collapsedDomainListSorted =  new TreeMap(collapsedDomainList);
-	
-		 List domainstoUpd = new ArrayList();
-		 
-		 //nline
-		 List collapsedDomainNewLL = getCollapsedDomainsNewList();
-		 
-		 int colToUnCollapse = 99;
-		 
-		 Domain domainToInsert = null;
-		 
-		 //nline
-		 //	 if (collapsedDomains.size() == 0) {
-		 if (collapsedDomainNewLL.size() == 0) {
-			 for (Map.Entry unindexDomain : originalDomainRowCol.entrySet()) {
-				 Domain dm = unindexDomain.getValue();
-				 dm.setIndexChanged(false);
-			 }
-		 }
-		 
-		 
-		 for (Map.Entry entry : originalDomainRowCol.entrySet()) {
-			 if (entry.getValue().getName().equals(domainToUnCollapse)) {
-				 colToUnCollapse  = Character.getNumericValue(entry.getKey().toCharArray()[1]);
-				 domainToInsert = entry.getValue(); 
-				 collapsedDomainList.remove(entry.getKey());
-				 //nline
-				 collapsedDomainNewLL.remove(entry.getValue());
-				 break;
-			 }
-		 }
-		 
-		 domainstoUpd.add(domainToInsert);
-		 
-		 //for (Map.Entry e : originalDomainRowCol.entrySet())
-		 //    System.out.println("Original key value"+e.getKey()+":"+e.getValue().getName());
-		 
-		 int lastKeyCol = -1;
-		 for (Map.Entry entry : originalDomainRowCol.entrySet()) {
-			 int currcol  = Character.getNumericValue(entry.getKey().toCharArray()[1]);
-			 if (currcol < colToUnCollapse) {
-				 for (Map.Entry currDomainsEntry : currentDomainsSorted.entrySet()) {
-					 if (currDomainsEntry.getValue().getName().equals(entry.getValue().getName())) {
-						 updateDomains.put(currDomainsEntry.getKey(), currDomainsEntry.getValue());
-						 lastKeyCol = Character.getNumericValue(currDomainsEntry.getKey().toCharArray()[1]);
-						 break;
-					 }
-				 }	 
+
+		if (domainToUnCollapse == null || domainToUnCollapse.isEmpty())
+			return null;
+
+		Map currentDomainsSorted = new TreeMap(domainRowCol);
+		Map updateDomains = new TreeMap();
+		Map collapsedDomainList = getCollapsedDomains();
+
+		List domainstoUpd = new ArrayList<>();
+
+		// nline
+		List collapsedDomainNewLL = getCollapsedDomainsNewList();
+
+		int colToUnCollapse = 99;
+
+		Domain domainToInsert = null;
+
+		// nline
+		if (collapsedDomainNewLL.isEmpty()) {
+			for (Map.Entry unindexDomain : originalDomainRowCol.entrySet()) {
+				Domain dm = unindexDomain.getValue();
+				dm.setIndexChanged(false);
+			}
+		}
+
+		for (Map.Entry entry : originalDomainRowCol.entrySet()) {
+			if (entry.getValue().getName().equals(domainToUnCollapse)) {
+				colToUnCollapse = Character.getNumericValue(entry.getKey().toCharArray()[1]);
+				domainToInsert = entry.getValue();
+				collapsedDomainList.remove(entry.getKey());
+				// nline
+				collapsedDomainNewLL.remove(entry.getValue());
+				break;
+			}
+		}
+
+		domainstoUpd.add(domainToInsert);
+
+		int lastKeyCol = -1;
+		for (Map.Entry entry : originalDomainRowCol.entrySet()) {
+			int currcol = Character.getNumericValue(entry.getKey().toCharArray()[1]);
+			if (currcol < colToUnCollapse) {
+				for (Map.Entry currDomainsEntry : currentDomainsSorted.entrySet()) {
+					if (currDomainsEntry.getValue().getName().equals(entry.getValue().getName())) {
+						updateDomains.put(currDomainsEntry.getKey(), currDomainsEntry.getValue());
+						lastKeyCol = Character.getNumericValue(currDomainsEntry.getKey().toCharArray()[1]);
+						break;
+					}
+				}
 			} else {
-				String newKey = "0"+String.valueOf(lastKeyCol+1);
+				String newKey = "0" + String.valueOf(lastKeyCol + 1);
 				if (currcol == colToUnCollapse) {
 					updateDomains.put(newKey, domainToInsert);
 					++lastKeyCol;
 				} else {
 					for (Map.Entry currDomainsEnt : currentDomainsSorted.entrySet()) {
-						 if (currDomainsEnt.getValue().getName().equals(entry.getValue().getName())) {
-							 updateDomains.put(newKey, currDomainsEnt.getValue());
-							 domainstoUpd.add(currDomainsEnt.getValue());
-							 ++lastKeyCol;
-							 // lastKeyCol = Character.getNumericValue(currDomainsEntry.getKey().toCharArray()[1]);
-							 break;
-						 }
-					 }
+						if (currDomainsEnt.getValue().getName().equals(entry.getValue().getName())) {
+							updateDomains.put(newKey, currDomainsEnt.getValue());
+							domainstoUpd.add(currDomainsEnt.getValue());
+							++lastKeyCol;
+							break;
+						}
+					}
 				}
-				
+
 			}
-		 }
-		 
-		setNumberofColsofDomains(getNumberofColsofDomains()+1);
+		}
+
+		setNumberofColsofDomains(getNumberofColsofDomains() + 1);
 		setDomainRowCol(updateDomains);
-		 
-		//for (Map.Entry e : updateDomains.entrySet())
-		//	System.out.println("me Updatedomains key value"+e.getKey()+":"+e.getValue().getName());
-		 
-		
-		 
-		
+
 		double currDistFromLftM = 11.0;
-		
+
 		boolean isDisplayed;
-		for (Map.Entry orgEntry : originalDomainRowCol.entrySet()) {
+		for (Map.Entry orgEntry : originalDomainRowCol.entrySet()) {
 			isDisplayed = false;
-			for (Map.Entry cd : updateDomains.entrySet()) {
+			for (Map.Entry cd : updateDomains.entrySet()) {
 				if (cd.getValue().getName().equals(orgEntry.getValue().getName())) {
 					Domain d = cd.getValue();
 					d.setDomainToLayoutWd(currDistFromLftM);
@@ -1060,168 +846,112 @@ public class Layout {
 							for (Map.Entry entryInner : c.getContainerRowCol().entrySet()) {
 								Container inner = entryInner.getValue();
 								inner.computeElementPositions();
-							}	
+							}
 						}
 					}
-					currDistFromLftM += d.computeSize().getWidth()+1;
+					currDistFromLftM += d.computeSize().getWidth() + 1;
 					isDisplayed = true;
 					break;
 				}
 			}
-		
+
 			if (!isDisplayed) {
-				Domain myCollapsed = orgEntry.getValue(); 
+				Domain myCollapsed = orgEntry.getValue();
 				myCollapsed.setNewXafterColl(currDistFromLftM);
 				currDistFromLftM += 4;
 			}
 		}
-		
-	//	plus.setNewXafterColl(distOfCollFrmLft+1.5);
-		
-		//order changed
+
+		// order changed
 		setCollapsedDomains(collapsedDomainList);
-		 
-		 //nline
+
+		// nline
 		setCollapsedDomainsNewList(collapsedDomainNewLL);
-		
-		
+
 		computeDomainPositionsModified();
 		return this;
-		
-	}	
-	
-	
-	
-	
-	
-	
-	
-	
-	
-	
-	
-	
-	
-	
+
+	}
+
 	private void updatePlusPosition(List collapsedDNewL, Map displayedDomainMap) {
-		List copyCollapseList = new ArrayList(); 
-		
+		List copyCollapseList = new ArrayList<>();
+
 		for (Domain copyCollapse : collapsedDNewL) {
 			copyCollapseList.add(copyCollapse);
 		}
-		
-		//double distOfCollFrmLft = 0.0;
+
 		int orgColofCollapsed = -1;
 		int orgColofDisplayed = -1;
 		int orgColofDisplayedOtherPlus = -1;
-		int orgColofInterDomainPlus = -1;
-		List dsplyList = new ArrayList();
-		
+
 		for (Domain plus : collapsedDNewL) {
 			double distOfCollFrmLft = 0.0;
 			for (Map.Entry colCheck : originalDomainRowCol.entrySet()) {
 				if (colCheck.getValue().getName().equals(plus.getName())) {
 					orgColofCollapsed = Character.getNumericValue(colCheck.getKey().toCharArray()[1]);
-					break;		
+					break;
 				}
 			}
 			for (Map.Entry displayedEntry : displayedDomainMap.entrySet()) {
-				
+
 				for (Map.Entry colCheck1 : originalDomainRowCol.entrySet()) {
 					if (colCheck1.getValue().getName().equals(displayedEntry.getValue().getName())) {
 						orgColofDisplayed = Character.getNumericValue(colCheck1.getKey().toCharArray()[1]);
-						break;		
+						break;
 					}
 				}
 				if (orgColofDisplayed < orgColofCollapsed) {
-					distOfCollFrmLft+= displayedEntry.getValue().computeSize().getWidth();
-					
-					
-				/*	if (dsplyList.size() > 0) {
-						Domain lastAdded = dsplyList.get(dsplyList.size()-1);
-						int orgColofLastAdded = -1;
-						for (Map.Entry colCh : originalDomainRowCol.entrySet()) {
-							if (colCh.getValue().getName().equals(lastAdded.getName())) {
-								orgColofLastAdded = Character.getNumericValue(colCh.getKey().toCharArray()[1]);
-								break;		
-							}
-						}
-						if (Math.abs(orgColofDisplayed - orgColofLastAdded) == 1) {
-							boolean adjDomainsWithPlus = false;
-							for (Domain colp : copyCollapseList) {
-								if (!colp.getName().equals(plus.getName())) {
-									for (Map.Entry colCk2 : originalDomainRowCol.entrySet()) {
-										if (colCk2.getValue().getName().equals(colp.getName())) {
-											orgColofInterDomainPlus = Character.getNumericValue(colCk2.getKey().toCharArray()[1]);
-											break;		
-										}
-									}
-									if (orgColofInterDomainPlus > orgColofLastAdded && orgColofInterDomainPlus < orgColofDisplayed) {
-										adjDomainsWithPlus = true;
-										break;
-									}
-								}
-							}
-							if (!adjDomainsWithPlus)
-								distOfCollFrmLft+=interDomainWd;
-						} 
-					}
-					dsplyList.add(displayedEntry.getValue()); */
-					
-				
-				
+					distOfCollFrmLft += displayedEntry.getValue().computeSize().getWidth();
 				}
-				
+
 			}
-			
+
 			for (Domain collp : copyCollapseList) {
 				if (!collp.getName().equals(plus.getName())) {
 					for (Map.Entry colCheck2 : originalDomainRowCol.entrySet()) {
 						if (colCheck2.getValue().getName().equals(collp.getName())) {
 							orgColofDisplayedOtherPlus = Character.getNumericValue(colCheck2.getKey().toCharArray()[1]);
-							break;		
+							break;
 						}
 					}
 					if (orgColofDisplayedOtherPlus < orgColofCollapsed) {
-						distOfCollFrmLft+=3.0;
+						distOfCollFrmLft += 3.0;
 					}
 				}
 			}
-			
-			plus.setNewXafterColl(distOfCollFrmLft+1.5);
-			
-		
+
+			plus.setNewXafterColl(distOfCollFrmLft + 1.5);
+
 		}
 	}
-	
 
 	private double accountForPlusSpaceBefore(Domain d) {
-		
+
 		int orgColofCollapsed = 0;
-		int orgColofDisplayed = 0; 
+		int orgColofDisplayed = 0;
 		double distFromLftM = 0.0;
-		
+
 		for (Map.Entry colCheckk : originalDomainRowCol.entrySet()) {
 			if (colCheckk.getValue().getName().equals(d.getName())) {
 				orgColofDisplayed = Character.getNumericValue(colCheckk.getKey().toCharArray()[1]);
-				break;		
+				break;
 			}
 		}
-		
-		for (Domain collapsed :  getCollapsedDomainsNewList()) {
+
+		for (Domain collapsed : getCollapsedDomainsNewList()) {
 			for (Map.Entry colCheck : originalDomainRowCol.entrySet()) {
 				if (colCheck.getValue().getName().equals(collapsed.getName())) {
 					orgColofCollapsed = Character.getNumericValue(colCheck.getKey().toCharArray()[1]);
-					break;		
+					break;
 				}
 			}
-			
+
 			if (orgColofCollapsed < orgColofDisplayed) {
-				distFromLftM+= 2;
+				distFromLftM += 2;
 			}
 		}
 		return distFromLftM;
-	
+
 	}
-	
+
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/NameValueId.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/NameValueId.java
index cc05ea3f..eef7c27a 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/NameValueId.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/NameValueId.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -39,74 +39,67 @@ package org.onap.portalsdk.core.domain.support;
 
 import java.io.Serializable;
 
-
 public class NameValueId implements Serializable {
 
-	/**
-	 * 
-	 */
 	private static final long serialVersionUID = 1L;
-    private String lab;
-    private String val;
-
-    public NameValueId() {
-    }
-
-    public NameValueId(String value, String label) {
-      setVal(value);
-      setLab(label);
-    }
-
-
-    public String getLab() {
-        return lab;
-    }
-
-
-    public String getVal() {
-        return val;
-    }
+	private String lab;
+	private String val;
 
+	public NameValueId() {
+		// No-arg constructor
+	}
 
-    public void setLab(String label) {
-        this.lab = label;
-    }
+	public NameValueId(String value, String label) {
+		setVal(value);
+		setLab(label);
+	}
 
+	public String getLab() {
+		return lab;
+	}
 
-    public void setVal(String value) {
-        this.val = value;
-    }
+	public String getVal() {
+		return val;
+	}
 
+	public void setLab(String label) {
+		this.lab = label;
+	}
 
-    public boolean equals(Object o) {
-      if (this == o) {
-        return true;
-      }
+	public void setVal(String value) {
+		this.val = value;
+	}
 
-      if (o == null) {
-        return false;
-      }
+	@Override
+	public boolean equals(Object o) {
+		if (this == o) {
+			return true;
+		}
 
-      if (!(o instanceof NameValueId)) {
-        return false;
-      }
+		if (o == null) {
+			return false;
+		}
 
-      final NameValueId nameValueId = (NameValueId)o;
+		if (!(o instanceof NameValueId)) {
+			return false;
+		}
 
-      if (!getVal().equals(nameValueId.getVal())) {
-        return false;
-      }
+		final NameValueId nameValueId = (NameValueId) o;
 
-      if (!getLab().equals(nameValueId.getLab())) {
-        return false;
-      }
+		if (!getVal().equals(nameValueId.getVal())) {
+			return false;
+		}
 
-      return true;
-    }
+		if (!getLab().equals(nameValueId.getLab())) {
+			return false;
+		}
 
+		return true;
+	}
 
-    public int hashCode() {
-      return getVal().hashCode();
-    }
+	@Override
+	public int hashCode() {
+		return getVal().hashCode();
+	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Position.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Position.java
index 29771e97..e0946d0b 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Position.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Position.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -40,19 +40,21 @@ package org.onap.portalsdk.core.domain.support;
 public class Position {
 	double x;
 	double y;
-	
+
 	public double getX() {
 		return x;
 	}
+
 	public void setX(double x) {
 		this.x = x;
 	}
+
 	public double getY() {
 		return y;
 	}
+
 	public void setY(double y) {
 		this.y = y;
 	}
 
-	
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Size.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Size.java
index bbaaeac3..6fcd178e 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Size.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/domain/support/Size.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -40,19 +40,21 @@ package org.onap.portalsdk.core.domain.support;
 public class Size {
 	private double width;
 	private double height;
-	
+
 	public double getWidth() {
 		return width;
 	}
+
 	public void setWidth(double width) {
 		this.width = width;
 	}
+
 	public double getHeight() {
 		return height;
 	}
+
 	public void setHeight(double height) {
 		this.height = height;
 	}
-	
-	
+
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/drools/DroolsRuleService.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/drools/DroolsRuleService.java
index 3f05af1b..1be2a7e8 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/drools/DroolsRuleService.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/drools/DroolsRuleService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -38,8 +38,9 @@
 package org.onap.portalsdk.core.drools;
 
 public interface DroolsRuleService {
-	
+
 	public void init(String... params);
+
 	public String getResultsString();
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/drools/DroolsRuleServiceImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/drools/DroolsRuleServiceImpl.java
index 85187b4c..78de0b47 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/drools/DroolsRuleServiceImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/drools/DroolsRuleServiceImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,27 +37,20 @@
  */
 package org.onap.portalsdk.core.drools;
 
-
 /**
  * 
  * This is POC test class to execute sample rules
  */
-public class DroolsRuleServiceImpl implements DroolsRuleService{
-	
-	
+public class DroolsRuleServiceImpl implements DroolsRuleService {
+
 	private String state;
 	private String resultsString;
 
-	public DroolsRuleServiceImpl() {
-		
-	}
-	
+	@Override
 	public void init(String... params) {
 		this.state = params[0];
 	}
 
-	
-
 	public String getState() {
 		return state;
 	}
@@ -66,6 +59,7 @@ public class DroolsRuleServiceImpl implements DroolsRuleService{
 		return "Drools POC Test";
 	}
 
+	@Override
 	public String getResultsString() {
 		return resultsString;
 	}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/exception/FusionExceptionResolver.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/exception/FusionExceptionResolver.java
index e376f318..1e605176 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/exception/FusionExceptionResolver.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/exception/FusionExceptionResolver.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -44,25 +44,30 @@ import org.springframework.web.servlet.ModelAndView;
 @ControllerAdvice
 public class FusionExceptionResolver {
 
+	private final String error = "error";
+	private final String errMsg = "errMsg";
+
 	@ExceptionHandler(UrlAccessRestrictedException.class)
 	public ModelAndView handleUrlAccessException(UrlAccessRestrictedException ex) {
-		ModelAndView model = new ModelAndView("error");
-		model.addObject("errMsg", ex.getMessage());
+		ModelAndView model = new ModelAndView(error);
+		model.addObject(errMsg, ex.getMessage());
 		return model;
 
 	}
+
 	@ExceptionHandler(SessionExpiredException.class)
 	public ModelAndView handleSessionException(SessionExpiredException ex) {
-		ModelAndView model = new ModelAndView("error");
-		model.addObject("errMsg", ex.getMessage());
+		ModelAndView model = new ModelAndView(error);
+		model.addObject(errMsg, ex.getMessage());
 		return model;
 	}
+
 	@ExceptionHandler(Exception.class)
 	public ModelAndView handleAllException(Exception ex) {
-		ModelAndView model = new ModelAndView("error");
-		model.addObject("errMsg", ex.getMessage());
+		ModelAndView model = new ModelAndView(error);
+		model.addObject(errMsg, ex.getMessage());
 		return model;
 
 	}
-	
+
 }
\ No newline at end of file
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/exception/SessionExpiredException.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/exception/SessionExpiredException.java
index 7d2f28ef..51521d0b 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/exception/SessionExpiredException.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/exception/SessionExpiredException.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -40,14 +40,14 @@ package org.onap.portalsdk.core.exception;
 import org.onap.portalsdk.core.exception.support.FusionRuntimeException;
 
 public class SessionExpiredException extends FusionRuntimeException {
-	
+
 	/**
 	 * 
 	 */
 	private static final long serialVersionUID = 1L;
-    public static final String MESSAGE = "Your session has expired. Please login again.";
+	public static final String MESSAGE = "Your session has expired. Please login again.";
 
-    public SessionExpiredException() {
-      super(MESSAGE);
-    }
+	public SessionExpiredException() {
+		super(MESSAGE);
+	}
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/exception/UrlAccessRestrictedException.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/exception/UrlAccessRestrictedException.java
index 67bf87b0..46e785c6 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/exception/UrlAccessRestrictedException.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/exception/UrlAccessRestrictedException.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -40,14 +40,14 @@ package org.onap.portalsdk.core.exception;
 import org.onap.portalsdk.core.exception.support.FusionRuntimeException;
 
 public class UrlAccessRestrictedException extends FusionRuntimeException {
-	
+
 	/**
 	 * 
 	 */
 	private static final long serialVersionUID = 1L;
-    public static final String MESSAGE = "Authorization Denied";
+	public static final String MESSAGE = "Authorization Denied";
 
-    public UrlAccessRestrictedException() {
-      super(MESSAGE);
-    }
+	public UrlAccessRestrictedException() {
+		super(MESSAGE);
+	}
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/exception/support/FusionException.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/exception/support/FusionException.java
index 012b9474..f3b27047 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/exception/support/FusionException.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/exception/support/FusionException.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -39,4 +39,5 @@ package org.onap.portalsdk.core.exception.support;
 
 import org.onap.portalsdk.core.FusionObject;
 
-public interface FusionException extends FusionObject {}
+public interface FusionException extends FusionObject {
+}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/exception/support/FusionRuntimeException.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/exception/support/FusionRuntimeException.java
index ea0e7a13..c5f6554b 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/exception/support/FusionRuntimeException.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/exception/support/FusionRuntimeException.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -42,12 +42,13 @@ public class FusionRuntimeException extends RuntimeException implements FusionEx
 	 * 
 	 */
 	private static final long serialVersionUID = 1L;
-    public FusionRuntimeException() {
-      this("");
-    }
 
-    public FusionRuntimeException(String message) {
-      super(message);
-    }
+	public FusionRuntimeException() {
+		this("");
+	}
+
+	public FusionRuntimeException(String message) {
+		super(message);
+	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/interceptor/ResourceInterceptor.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/interceptor/ResourceInterceptor.java
index a0b88dc7..4b4d721c 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/interceptor/ResourceInterceptor.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/interceptor/ResourceInterceptor.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -79,8 +79,8 @@ public class ResourceInterceptor extends HandlerInterceptorAdapter {
 	private AbstractCacheManager cacheManager;
 
 	@Autowired
-	UrlAccessService urlAccessService;
-	
+	private UrlAccessService urlAccessService;
+
 	@Override
 	public boolean preHandle(HttpServletRequest request, HttpServletResponse response, Object handler)
 			throws Exception {
@@ -98,19 +98,20 @@ public class ResourceInterceptor extends HandlerInterceptorAdapter {
 					try {
 						if (!webServiceCallService.verifyRESTCredential(secretKey, request.getHeader("username"),
 								request.getHeader("password"))) {
-							logger.error(EELFLoggerDelegate.errorLogger, "Error accesing RESTful service. Un-authorized",AlarmSeverityEnum.MINOR);
+							logger.error(EELFLoggerDelegate.errorLogger,
+									"Error accesing RESTful service. Un-authorized", AlarmSeverityEnum.MINOR);
 							throw new UrlAccessRestrictedException();
 						}
 					} catch (Exception e) {
-						logger.error(EELFLoggerDelegate.errorLogger, "Error authenticating RESTful service :" + e,AlarmSeverityEnum.MINOR);
-						//throw new UrlAccessRestrictedException();
-						 HttpSession httpSession = request.getSession();
-						    ((HttpServletResponse) response).setStatus(HttpURLConnection.HTTP_UNAUTHORIZED);
-						    return false;
+						logger.error(EELFLoggerDelegate.errorLogger, "Error authenticating RESTful service :" + e,
+								AlarmSeverityEnum.MINOR);
+						response.setStatus(HttpURLConnection.HTTP_UNAUTHORIZED);
+						return false;
 					}
 				}
 				if (!urlAccessService.isUrlAccessible(request, url)) {
-					logger.error(EELFLoggerDelegate.errorLogger, "Error accesing URL. Un-authorized",AlarmSeverityEnum.MINOR);
+					logger.error(EELFLoggerDelegate.errorLogger, "Error accesing URL. Un-authorized",
+							AlarmSeverityEnum.MINOR);
 					throw new UrlAccessRestrictedException();
 				}
 			}
@@ -130,7 +131,7 @@ public class ResourceInterceptor extends HandlerInterceptorAdapter {
 	 */
 	protected void handleSessionUpdates(HttpServletRequest request) {
 
-		App app = null;
+		App app;
 		Object appObj = getCacheManager().getObject(APP_METADATA);
 		if (appObj == null) {
 			app = findApp();
@@ -141,12 +142,12 @@ public class ResourceInterceptor extends HandlerInterceptorAdapter {
 		}
 
 		String ecompRestURL = PortalApiProperties.getProperty(PortalApiConstants.ECOMP_REST_URL);
-		String decreptedPwd = "";
+		String decreptedPwd = null;
 		try {
 			decreptedPwd = CipherUtil.decrypt(app.getAppPassword(),
 					SystemProperties.getProperty(SystemProperties.Decryption_Key));
 		} catch (Exception e) {
-			logger.error(EELFLoggerDelegate.errorLogger, "Could not decrypt Password" + e.getMessage(),AlarmSeverityEnum.MINOR);
+			logger.error(EELFLoggerDelegate.errorLogger, "handleSessionUpdates failed to decrypt password", e);
 		}
 
 		PortalTimeoutHandler.handleSessionUpdatesNative(request, app.getUsername(), decreptedPwd,
@@ -155,10 +156,10 @@ public class ResourceInterceptor extends HandlerInterceptorAdapter {
 
 	public App findApp() {
 		List list = null;
-		StringBuffer criteria = new StringBuffer();
+		StringBuilder criteria = new StringBuilder();
 		criteria.append(" where id = 1");
 		list = getDataAccessService().getList(App.class, criteria.toString(), null, null);
-		return (list == null || list.size() == 0) ? null : (App) list.get(0);
+		return (list == null || list.isEmpty()) ? null : (App) list.get(0);
 	}
 
 	public DataAccessService getDataAccessService() {
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/interceptor/SessionTimeoutInterceptor.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/interceptor/SessionTimeoutInterceptor.java
index 2b0f0007..809266d4 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/interceptor/SessionTimeoutInterceptor.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/interceptor/SessionTimeoutInterceptor.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -56,14 +56,12 @@ import org.springframework.web.servlet.handler.HandlerInterceptorAdapter;
 public class SessionTimeoutInterceptor extends HandlerInterceptorAdapter {
 
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(SessionTimeoutInterceptor.class);
-
-	public SessionTimeoutInterceptor() {
-	}
-
+	
 	/**
-	 * Checks all requests for valid session information. If not found,
-	 * redirects to a controller that will establish a valid session.
+	 * Checks all requests for valid session information. If not found, redirects to
+	 * a controller that will establish a valid session.
 	 */
+	@Override
 	public boolean preHandle(HttpServletRequest request, HttpServletResponse response, Object handler)
 			throws Exception {
 		if (handler instanceof HandlerMethod) {
@@ -83,7 +81,7 @@ public class SessionTimeoutInterceptor extends HandlerInterceptorAdapter {
 						throw new Exception("preHandle: user not found in session");
 					} else {
 						// session binding listener will add this value to the
-						// map, and with session replication the listener will 
+						// map, and with session replication the listener will
 						// fire in all tomcat instances
 						session.setAttribute(CollaborateListBindingListener.SESSION_ATTR_NAME,
 								new CollaborateListBindingListener(user.getOrgUserId()));
@@ -96,22 +94,25 @@ public class SessionTimeoutInterceptor extends HandlerInterceptorAdapter {
 					final String singleSignonPrefix = "/single_signon.htm?";
 					if (ex instanceof SessionExpiredException) {
 						// Session is expired; send to portal.
-						// Redirect to an absolute path in the webapp; e.g., "/context/single_signon.htm"
-						final String redirectUrl = request.getContextPath() + singleSignonPrefix + "redirectToPortal=Yes&" + forwardUrlParm;
+						// Redirect to an absolute path in the webapp; e.g.,
+						// "/context/single_signon.htm"
+						final String redirectUrl = request.getContextPath() + singleSignonPrefix
+								+ "redirectToPortal=Yes&" + forwardUrlParm;
 						logger.debug(EELFLoggerDelegate.debugLogger, "preHandle: session is expired, redirecting to {}",
 								redirectUrl);
 						response.sendRedirect(redirectUrl);
 						return false;
 					} else {
 						// Other issue; do not send to portal.
-						// Redirect to an absolute path in the webapp; e.g., "/context/single_signon.htm"
+						// Redirect to an absolute path in the webapp; e.g.,
+						// "/context/single_signon.htm"
 						final String redirectUrl = request.getContextPath() + singleSignonPrefix + forwardUrlParm;
 						logger.debug(EELFLoggerDelegate.debugLogger, "preHandle: took exception {}, redirecting to {}",
 								ex.getMessage(), redirectUrl);
 						response.sendRedirect(redirectUrl);
 						return false;
 					}
-				} 
+				}
 			}
 		}
 
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/interfaces/SecurityInterface.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/interfaces/SecurityInterface.java
index f6bf974f..0e03b03c 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/interfaces/SecurityInterface.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/interfaces/SecurityInterface.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/listener/ApplicationContextListener.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/listener/ApplicationContextListener.java
index 4d266be4..89e9382f 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/listener/ApplicationContextListener.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/listener/ApplicationContextListener.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -40,7 +40,6 @@ package org.onap.portalsdk.core.listener;
 import javax.servlet.ServletContext;
 import javax.servlet.annotation.WebListener;
 
-import org.onap.portalsdk.core.lm.FusionLicenseManager;
 import org.onap.portalsdk.core.lm.FusionLicenseManagerUtils;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.ApplicationListener;
@@ -52,14 +51,12 @@ import org.springframework.stereotype.Component;
 public class ApplicationContextListener implements ApplicationListener {
 
 	@Autowired
-	ServletContext context;
+	private ServletContext context;
 	@Autowired
-	FusionLicenseManager lm;
-	@Autowired
-	FusionLicenseManagerUtils fusionLicenseManagerUtils;
-	
-	
-	public void onApplicationEvent(ContextRefreshedEvent contextRefreshedEvent ) {
+	private FusionLicenseManagerUtils fusionLicenseManagerUtils;
+
+	@Override
+	public void onApplicationEvent(ContextRefreshedEvent contextRefreshedEvent) {
 		int licenseStatus = fusionLicenseManagerUtils.verifyLicense(context);
 		context.setAttribute("licenseVerification", licenseStatus);
 	}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/listener/CollaborateListBindingListener.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/listener/CollaborateListBindingListener.java
index 5dcd438c..4f368eff 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/listener/CollaborateListBindingListener.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/listener/CollaborateListBindingListener.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -50,20 +50,19 @@ public class CollaborateListBindingListener implements HttpSessionBindingListene
 	private String userName;
 	public static final String SESSION_ATTR_NAME = "CollaborateListSessionAttrName";
 
-	public CollaborateListBindingListener(String _userName) {
-		userName = _userName;
+	public CollaborateListBindingListener(final String userName) {
+		this.userName = userName;
 	}
 
 	@Override
 	public void valueBound(HttpSessionBindingEvent event) {
-		final CollaborateListBindingListener value = ((CollaborateListBindingListener) event.getValue());
+		final CollaborateListBindingListener value = (CollaborateListBindingListener) event.getValue();
 		CollaborateList.addUserName(value.getUserName());
-
 	}
 
 	@Override
 	public void valueUnbound(HttpSessionBindingEvent event) {
-		final CollaborateListBindingListener value = ((CollaborateListBindingListener) event.getValue());
+		final CollaborateListBindingListener value = (CollaborateListBindingListener) event.getValue();
 		if (value != null)
 			CollaborateList.delUserName(value.getUserName());
 	}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/listener/UserSessionListener.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/listener/UserSessionListener.java
index 19b1f0f2..5e6b5dba 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/listener/UserSessionListener.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/listener/UserSessionListener.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -45,36 +45,26 @@ import javax.servlet.http.HttpSessionListener;
 import org.onap.portalsdk.core.logging.format.AlarmSeverityEnum;
 import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
 
-
 @WebListener
-public class UserSessionListener implements HttpSessionListener{
-	
+public class UserSessionListener implements HttpSessionListener {
+
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(UserSessionListener.class);
-	
-    public void sessionCreated(HttpSessionEvent event){
-    	
-    }
-     
-    /**
-     * Removes sessions from the context scoped HashMap when they expire
-     * or are invalidated.
-     */
-    public void sessionDestroyed(HttpSessionEvent event){
-    	try {
-	        HttpSession    session = event.getSession();
-	        session.removeAttribute(CollaborateListBindingListener.SESSION_ATTR_NAME);
-	        
-	       // Object user = session.getAttribute(SystemProperties.getProperty("user.attribute.name"));
-	        
-	        //if( user != null)
-	       // {
-	        	session.removeAttribute(CollaborateListBindingListener.SESSION_ATTR_NAME);
-			    //CollaborateList.getInstance().delUserName(user.getOrgUserId());
-	       // }
-		   
-    	}
-    	catch(Exception e) {
-    		logger.error(EELFLoggerDelegate.errorLogger, "sessionDestroyed" + e.getMessage(),AlarmSeverityEnum.MINOR);
-    	}
-    }
+
+	@Override
+	public void sessionCreated(HttpSessionEvent event) {
+		logger.trace(EELFLoggerDelegate.debugLogger, "sessionCreated");
+	}
+
+	/**
+	 * Removes sessions from the context scoped HashMap when they expire or are
+	 * invalidated.
+	 */
+	public void sessionDestroyed(HttpSessionEvent event) {
+		try {
+			HttpSession session = event.getSession();
+			session.removeAttribute(CollaborateListBindingListener.SESSION_ATTR_NAME);
+		} catch (Exception e) {
+			logger.error(EELFLoggerDelegate.errorLogger, "sessionDestroyed" + e.getMessage(), AlarmSeverityEnum.MINOR);
+		}
+	}
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/lm/FusionLicenseManager.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/lm/FusionLicenseManager.java
index 7f1f2273..1943c390 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/lm/FusionLicenseManager.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/lm/FusionLicenseManager.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -43,11 +43,8 @@ import java.util.Map;
 
 import javax.servlet.ServletContext;
 
-//import de.schlichtherle.license.LicenseContent;
-
 public interface FusionLicenseManager {
-	
-	
+
 	public static final int DEVELOPER_LICENSE = 0;
 	public static final int EXPIRED_LICENSE = 1;
 	public static final int VALID_LICENSE = 2;
@@ -66,8 +63,6 @@ public interface FusionLicenseManager {
 
 	public int verifyLicense(ServletContext context);
 
-	//public LicenseContent createLicenseContent(Map clientInfoMap, List ipAddressList);
-
 	public void generateLicense(Map clientInfoMap, List ipAddressList) throws Exception;
 
 	public String nvl(String s);
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/lm/FusionLicenseManagerUtils.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/lm/FusionLicenseManagerUtils.java
index c52abf44..9fb576f5 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/lm/FusionLicenseManagerUtils.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/lm/FusionLicenseManagerUtils.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -50,42 +50,30 @@ import org.springframework.web.servlet.support.RequestContextUtils;
 
 @Component
 public class FusionLicenseManagerUtils {
-	
+
 	@Autowired
 	private FusionLicenseManager licenseManager;
 
 	@Autowired
 	private SystemProperties sysProps;
-	static {
-	}
-		
+
 	public int verifyLicense(ServletContext context) {
-		if(sysProps == null) {
+		if (sysProps == null) {
 			try {
 				sysProps = new SystemProperties();
 				sysProps.setServletContext(context);
-//				sysProps.load();
-//				licenseManager = new FusionLicenseManagerImpl(new LicenseableClassImpl());
 				System.out.println(licenseManager);
 				licenseManager.installLicense();
-			}
-			catch(Exception ex) {
+			} catch (Exception ex) {
 				ex.printStackTrace();
 			}
 		}
-		
-		
-		
-//		WebApplicationContext ctx =RequestContextUtils.getWebApplicationContext(request);
-//		int flag = ((FusionLicenseManager)ctx.getBean("fusionLicenseManager")).verifyLicense(request);
-//		logger.debug("****************FLAG ******************** " + flag);
-//		return flag;
-//		return 2;
+
 		return licenseManager.verifyLicense(context);
 	}
 
 	public static Date getLicenseExpiryDate(HttpServletRequest request) {
-		WebApplicationContext ctx =RequestContextUtils.getWebApplicationContext(request);
-		return ((FusionLicenseManager)ctx.getBean("fusionLicenseManager")).getExpiredDate();
+		WebApplicationContext ctx = RequestContextUtils.getWebApplicationContext(request);
+		return ((FusionLicenseManager) ctx.getBean("fusionLicenseManager")).getExpiredDate();
 	}
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/lm/LicenseableClass.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/lm/LicenseableClass.java
index cd49f5a5..4d14a359 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/lm/LicenseableClass.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/lm/LicenseableClass.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,20 +37,26 @@
  */
 package org.onap.portalsdk.core.lm;
 
-import java.io.*;
+import java.io.FileNotFoundException;
+import java.io.InputStream;
 
 /**
- * created by Alvin Alexander of http://devdaily.com.
- * modified by Sundar Ramalingam
+ * created by Alvin Alexander of http://devdaily.com. modified by Sundar
+ * Ramalingam
  */
-public interface LicenseableClass
-{
-  public String getApplicationName();
-  public InputStream getPublicKeystoreAsInputStream() throws FileNotFoundException;
-  public String getAlias();
-  public String getPublicKeystorePassword();
-  public String getKeyPasswd();
-  public String getCipherParamPassword();
-  public Class getClassToLicense();
-  
+public interface LicenseableClass {
+	public String getApplicationName();
+
+	public InputStream getPublicKeystoreAsInputStream() throws FileNotFoundException;
+
+	public String getAlias();
+
+	public String getPublicKeystorePassword();
+
+	public String getKeyPasswd();
+
+	public String getCipherParamPassword();
+
+	public Class getClassToLicense();
+
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/aspect/AuditLog.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/aspect/AuditLog.java
index 93075937..6a5ce910 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/aspect/AuditLog.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/aspect/AuditLog.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -42,9 +42,8 @@ import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
-
-@Target({ElementType.METHOD, ElementType.TYPE})
+@Target({ ElementType.METHOD, ElementType.TYPE })
 @Retention(RetentionPolicy.RUNTIME)
 public @interface AuditLog {
-    String value() default "";
+	String value() default "";
 }
\ No newline at end of file
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/aspect/EELFLoggerAdvice.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/aspect/EELFLoggerAdvice.java
index 269d4b9c..779a24fc 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/aspect/EELFLoggerAdvice.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/aspect/EELFLoggerAdvice.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -105,16 +105,14 @@ public class EELFLoggerAdvice {
 			MDC.put(SystemProperties.TARGET_SERVICE_NAME, methodName);
 			if (securityEventType != null) {
 				MDC.put(className + methodName + SystemProperties.AUDITLOG_BEGIN_TIMESTAMP, getCurrentDateTimeUTC());
-				HttpServletRequest req = null;
 				if (args[0] != null && args[0] instanceof HttpServletRequest) {
-					req = (HttpServletRequest) args[0];
+					HttpServletRequest req = (HttpServletRequest) args[0];
 					logger.setRequestBasedDefaultsIntoGlobalLoggingContext(req, appName);
 				}
 			}
-			logger.debug(EELFLoggerDelegate.debugLogger, (methodName + " was invoked."));
+			logger.debug(EELFLoggerDelegate.debugLogger, "{} was invoked.", methodName);
 		} catch (Exception e) {
-			adviceLogger.error(EELFLoggerDelegate.errorLogger,
-					"Exception occurred in EELFLoggerAdvice.before() method. Details: " + e.getMessage());
+			adviceLogger.error(EELFLoggerDelegate.errorLogger, "before failed", e);
 		}
 
 		return new Object[] { "" };
@@ -197,8 +195,7 @@ public class EELFLoggerAdvice {
 			MDC.remove(SystemProperties.TARGET_ENTITY);
 			MDC.remove(SystemProperties.TARGET_SERVICE_NAME);
 		} catch (Exception e) {
-			adviceLogger.error(EELFLoggerDelegate.errorLogger,
-					"Exception occurred in EELFLoggerAdvice.after() method. Details: " + e.getMessage());
+			adviceLogger.error(EELFLoggerDelegate.errorLogger, "after failed", e);
 		}
 	}
 
@@ -212,7 +209,6 @@ public class EELFLoggerAdvice {
 	private void logSecurityMessage(EELFLoggerDelegate logger, SecurityEventTypeEnum securityEventType, String result,
 			String restMethod) {
 		StringBuilder additionalInfoAppender = new StringBuilder();
-		String auditMessage = "";
 
 		additionalInfoAppender.append(String.format("%s request was received.", restMethod));
 
@@ -224,7 +220,7 @@ public class EELFLoggerAdvice {
 			additionalInfoAppender.append(" Request-URL:" + MDC.get(SystemProperties.FULL_URL));
 		}
 
-		auditMessage = AuditLogFormatter.getInstance().createMessage(MDC.get(SystemProperties.PROTOCOL),
+		String auditMessage = AuditLogFormatter.getInstance().createMessage(MDC.get(SystemProperties.PROTOCOL),
 				securityEventType.name(), MDC.get(SystemProperties.MDC_LOGIN_ID), additionalInfoAppender.toString());
 
 		logger.info(EELFLoggerDelegate.auditLogger, auditMessage);
@@ -243,9 +239,7 @@ public class EELFLoggerAdvice {
 				String timeDifference = String.format("%d ms", endDate.getTime() - beginDate.getTime());
 				MDC.put(SystemProperties.MDC_TIMER, timeDifference);
 			} catch (Exception e) {
-				adviceLogger.error(EELFLoggerDelegate.errorLogger,
-						"Exception occurred in EELFLoggerAdvice.calculateDateTimeDifference() method. Details: "
-								+ e.getMessage());
+				adviceLogger.error(EELFLoggerDelegate.errorLogger, "calculateDateTimeDifference failed", e);
 			}
 		}
 	}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/aspect/EELFLoggerAspect.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/aspect/EELFLoggerAspect.java
index 8c958924..3ffd0894 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/aspect/EELFLoggerAspect.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/aspect/EELFLoggerAspect.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -44,20 +44,21 @@ import org.aspectj.lang.annotation.Pointcut;
 import org.onap.portalsdk.core.util.SystemProperties.SecurityEventTypeEnum;
 import org.springframework.beans.factory.annotation.Autowired;
 
-
 @Aspect
 @org.springframework.context.annotation.Configuration
 public class EELFLoggerAspect {
-	
+
 	@Autowired
-	EELFLoggerAdvice advice;
-			
+	private EELFLoggerAdvice advice;
+
 	/*
 	 * Point-cut expression to handle all INCOMING_REST_MESSAGES
 	 */
 	@Pointcut("execution(public * org.onap.portalsdk.core.controller.*.*(..))")
-	public void incomingAuditMessages() {}
-	
+	public void incomingAuditMessages() {
+		// Nothing is logged on incoming message
+	}
+
 	@Around("incomingAuditMessages() && @annotation(auditLog)")
 	public Object logAuditMethodAround(ProceedingJoinPoint joinPoint, AuditLog auditLog) throws Throwable {
 		return this.logAroundMethod(joinPoint, SecurityEventTypeEnum.INCOMING_REST_MESSAGE);
@@ -67,40 +68,44 @@ public class EELFLoggerAspect {
 	public Object logAuditMethodClassAround(ProceedingJoinPoint joinPoint, AuditLog auditLog) throws Throwable {
 		return this.logAroundMethod(joinPoint, SecurityEventTypeEnum.INCOMING_REST_MESSAGE);
 	}
-	
+
 	/*
 	 * Point cut expression to capture metrics logging
 	 */
 	@Pointcut("execution(public * *(..))")
-    public void publicMethod() {}
-	
+	public void publicMethod() {
+		// By default do nothing
+	}
+
 	@Around("publicMethod() && @within(metricsLog)")
 	public Object logMetricsClassAround(ProceedingJoinPoint joinPoint, MetricsLog metricsLog) throws Throwable {
 		return this.logAroundMethod(joinPoint, null);
 	}
-	
+
 	@Around("publicMethod() && @annotation(metricsLog)")
 	public Object logMetricsMethodAround(ProceedingJoinPoint joinPoint, MetricsLog metricsLog) throws Throwable {
 		return this.logAroundMethod(joinPoint, null);
 	}
-	
-	private Object logAroundMethod(ProceedingJoinPoint joinPoint, SecurityEventTypeEnum securityEventType) throws Throwable {
-		//Before
-		Object[] passOnArgs = new Object[] {joinPoint.getSignature().getDeclaringType().getName(),joinPoint.getSignature().getName()};
+
+	private Object logAroundMethod(ProceedingJoinPoint joinPoint, SecurityEventTypeEnum securityEventType)
+			throws Throwable {
+		// Before
+		Object[] passOnArgs = new Object[] { joinPoint.getSignature().getDeclaringType().getName(),
+				joinPoint.getSignature().getName() };
 		Object[] returnArgs = advice.before(securityEventType, joinPoint.getArgs(), passOnArgs);
-		
-		//Execute the actual method
+
+		// Execute the actual method
 		Object result = null;
 		String restStatus = "COMPLETE";
 		try {
 			result = joinPoint.proceed();
-		} catch(Exception e) {
+		} catch (Exception e) {
 			restStatus = "ERROR";
 		}
-		
-		//After
+
+		// After
 		advice.after(securityEventType, restStatus, joinPoint.getArgs(), returnArgs, passOnArgs);
-		
+
 		return result;
 	}
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/aspect/MetricsLog.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/aspect/MetricsLog.java
index 7d552774..3e089aeb 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/aspect/MetricsLog.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/aspect/MetricsLog.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -42,9 +42,8 @@ import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
-
-@Target({ElementType.METHOD, ElementType.TYPE})
+@Target({ ElementType.METHOD, ElementType.TYPE })
 @Retention(RetentionPolicy.RUNTIME)
 public @interface MetricsLog {
-    String value() default "";
+	String value() default "";
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/AlarmSeverityEnum.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/AlarmSeverityEnum.java
index f2481e34..5e202475 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/AlarmSeverityEnum.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/AlarmSeverityEnum.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -38,9 +38,5 @@
 package org.onap.portalsdk.core.logging.format;
 
 public enum AlarmSeverityEnum {
-	CRITICAL, 
-	MAJOR, 
-	MINOR, 
-	INFORMATIONAL, 
-	NONE,
+	CRITICAL, MAJOR, MINOR, INFORMATIONAL, NONE,
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/AppMessagesEnum.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/AppMessagesEnum.java
index 84790f6b..569f9392 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/AppMessagesEnum.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/AppMessagesEnum.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -39,164 +39,213 @@ package org.onap.portalsdk.core.logging.format;
 
 public enum AppMessagesEnum {
 	/*
-	100-199 Security/Permission Related 
-										- Authentication problems (from external client, to external server)
-										- Certification errors
-										- 
-											
-	200-299 Availability/Timeout Related
-										- connectivity error
-										- connection timeout
-										
-	300-399 Data Access/Integrity Related
-										- Data in graph in invalid(E.g. no creator is found for service) 
-										- Artifact is missing in ES, but exists in graph.
-										 
-	400-499 Schema Interface Type/Validation
-										- received Pay-load checksum is invalid
-										- received JSON is not valid
-							  
-	500-599 Business/Flow Processing Related  
-										-  check out to service is not allowed
-										-  Roll-back is done
-										-  failed to generate heat file
-										  
-
-	600-899 Reserved - do not use
-
-	900-999 Unknown Errors 
-										- Unexpected exception
-										*/
-	
-	BeUebAuthenticationError(ErrorCodesEnum.BEUEBAUTHENTICATIONERROR_ONE_ARGUMENT, ErrorTypeEnum.AUTHENTICATION_PROBLEM, AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR,
-								"ERR100E", "An Authentication failure occurred during access to UEB server", "Details: {0}.", "Please check UEB server list and keys configured under Portal.Properties file."),
-	
-	BeRestApiAuthenticationError(ErrorCodesEnum.BERESTAPIAUTHENTICATIONERROR, ErrorTypeEnum.AUTHENTICATION_PROBLEM, AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR,
-								"ERR101E", "Rejected an incoming REST API request due to invalid credentials", "", "Please check application credentials defined in Database or properties files."),
-	
-	InternalAuthenticationInfo(ErrorCodesEnum.INTERNALAUTHENTICATIONINFO_ONE_ARGUMENT, ErrorTypeEnum.AUTHENTICATION_PROBLEM, AlarmSeverityEnum.INFORMATIONAL, ErrorSeverityEnum.INFO,
-								"ERR199I", "Internal authentication problem", "Details: {0}.", "Please check the logs for more information."),
-	
-	InternalAuthenticationWarning(ErrorCodesEnum.INTERNALAUTHENTICATIONWARNING_ONE_ARGUMENT, ErrorTypeEnum.AUTHENTICATION_PROBLEM, AlarmSeverityEnum.MINOR, ErrorSeverityEnum.WARN,
-								"ERR199W", "Internal authentication problem", "Details: {0}.", "Please check the logs for more information."),
-	
-	InternalAuthenticationError(ErrorCodesEnum.INTERNALAUTHENTICATIONERROR_ONE_ARGUMENT, ErrorTypeEnum.AUTHENTICATION_PROBLEM, AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR,
-								"ERR199E", "Internal authentication problem", "Details: {0}.", "Please check the logs for more information."),
-	
-	InternalAuthenticationFatal(ErrorCodesEnum.INTERNALAUTHENTICATIONFATAL_ONE_ARGUMENT, ErrorTypeEnum.AUTHENTICATION_PROBLEM, AlarmSeverityEnum.CRITICAL, ErrorSeverityEnum.FATAL,
-								"ERR199F", "Internal authentication problem", "Details: {0}.", "Please check the logs for more information."),
-	
-	BeHealthCheckError(ErrorCodesEnum.BeHEALTHCHECKERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.CRITICAL, ErrorSeverityEnum.ERROR,
-								"ERR200E", "ECOMP-PORTAL Back-end probably lost connectivity to either one of the following components: MySQL DB, UEB Cluster", "", "Please check the logs for more information."),
-
-	BeHealthCheckMySqlError(ErrorCodesEnum.BEHEALTHCHECKMYSQLERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.CRITICAL, ErrorSeverityEnum.ERROR,
-								"ERR201E", "ECOMP-PORTAL Back-end probably lost connectivity to MySQL DB", "", "Check connectivity to MYSQL is configured correctly under system.properties file."),
-
-	BeHealthCheckUebClusterError(ErrorCodesEnum.BEHEALTHCHECKUEBCLUSTERERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.CRITICAL, ErrorSeverityEnum.ERROR,
-								"ERR203E", "ECOMP-PORTAL Back-end probably lost connectivity to UEB Cluster", "", "Check connectivity to UEB cluster which is configured under portal.properties file."),
-	
-	FeHealthCheckError(ErrorCodesEnum.FEHEALTHCHECKERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.CRITICAL, ErrorSeverityEnum.ERROR,
-								"ERR204E", "Unable to connect to a valid ECOMP-PORTAL Back-end Server.", "", "Please check connectivity from this FE instance towards BE or BE Load Balancer."),
-	
-	BeHealthCheckRecovery(ErrorCodesEnum.BEHEALTHCHECKRECOVERY, ErrorTypeEnum.RECOVERY, AlarmSeverityEnum.INFORMATIONAL, ErrorSeverityEnum.INFO,
-								"ERR205I", "ECOMP-PORTAL Back-end Recovery to either one of the following components: MySQL DB, UEB Cluster", "", "Please check logs for more specific information about the problem."),
-	
-	BeHealthCheckMySqlRecovery(ErrorCodesEnum.BEHEALTHCHECKMYSQLRECOVERY, ErrorTypeEnum.RECOVERY, AlarmSeverityEnum.INFORMATIONAL, ErrorSeverityEnum.INFO,
-								"ERR206I", "ECOMP-PORTAL Back-end connection recovery to MySQL DB", "", "Please check logs for more specific information about the problem."),
-	
-	BeHealthCheckUebClusterRecovery(ErrorCodesEnum.BEHEALTHCHECKUEBCLUSTERRECOVERY, ErrorTypeEnum.RECOVERY, AlarmSeverityEnum.INFORMATIONAL, ErrorSeverityEnum.INFO,
-								"ERR208I", "ECOMP-PORTAL Back-end connection recovery to UEB Cluster", "", "Please check logs for more specific information about the problem."),
-	
-	FeHealthCheckRecovery(ErrorCodesEnum.FEHEALTHCHECKRECOVERY, ErrorTypeEnum.RECOVERY, AlarmSeverityEnum.INFORMATIONAL, ErrorSeverityEnum.INFO,
-								"ERR209I", "Connectivity to ECOMP-PORTAL Front-end Server is recovered", "", "Please check logs for more specific information about the problem."),
-    
-	BeUebConnectionError(ErrorCodesEnum.BEUEBCONNECTIONERROR_ONE_ARGUMENT, ErrorTypeEnum.CONNECTION_PROBLEM, AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR,
-    							"ERR210E", "ECOMP-PORTAL Back-end probably lost connectivity to UEB Cluster", "Details: {0}.", "Please check UEB server list and keys configured under Portal.Properties file."),
-    
-    BeUebUnkownHostError(ErrorCodesEnum.BEUEBUNKOWNHOSTERROR_ONE_ARGUMENT, ErrorTypeEnum.CONNECTION_PROBLEM, AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR,
-    							"ERR211E", "ECOMP-PORTAL Back-end probably lost connectivity to UEB Cluster", "Cannot reach host: {0}.", "Please check UEB server list and keys configured under Portal.Properties file."),
-	
-    BeUebRegisterOnboardingAppError(ErrorCodesEnum.BEUEBREGISTERONBOARDINGAPPERROR, ErrorTypeEnum.CONNECTION_PROBLEM, AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR,
-    							"ERR212E", "Failed to register the On-boarding application with UEB Communication server", "Details: {0}.", "Please check UEB server list and keys configured under Portal.Properties file."),
-    
-    BeHttpConnectionError(ErrorCodesEnum.BEHTTPCONNECTIONERROR_ONE_ARGUMENT, ErrorTypeEnum.CONNECTION_PROBLEM, AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR,
-								"ERR213E", "It could be that communication to an external application might resulted an exception or failed to reach the external application", 
-								"Details: {0}.", "Please check logs for more information."),
-    
-    InternalConnectionInfo(ErrorCodesEnum.INTERNALCONNECTIONINFO_ONE_ARGUMENT, ErrorTypeEnum.CONNECTION_PROBLEM, AlarmSeverityEnum.INFORMATIONAL, ErrorSeverityEnum.INFO,
-								"ERR299I", "Internal Connection problem", "Details: {0}.", "Please check logs for more information."),
-    
-	InternalConnectionWarning(ErrorCodesEnum.INTERNALCONNECTIONWARNING_ONE_ARGUMENT, ErrorTypeEnum.CONNECTION_PROBLEM, AlarmSeverityEnum.MINOR, ErrorSeverityEnum.WARN,
-								"ERR299W", "Internal Connection problem", "Details: {0}.", "Please check logs for more information."),
-    
-    InternalConnectionError(ErrorCodesEnum.INTERNALCONNECTIONERROR_ONE_ARGUMENT, ErrorTypeEnum.CONNECTION_PROBLEM, AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR,
-    							"ERR299E", "Internal Connection problem", "Details: {0}.", "Please check logs for more information."),
-    
-    InternalConnectionFatal(ErrorCodesEnum.INTERNALCONNECTIONFATAL_ONE_ARGUMENT, ErrorTypeEnum.CONNECTION_PROBLEM, AlarmSeverityEnum.CRITICAL, ErrorSeverityEnum.FATAL,
-    							"ERR299F", "Internal Connection problem", "Details: {0}.", "Please check logs for more information."),
-    
-    BeUebObjectNotFoundError(ErrorCodesEnum.BEUEBOBJECTNOTFOUNDERROR_ONE_ARGUMENT, ErrorTypeEnum.DATA_ERROR, AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR,
-    							"ERR303E", "Error occurred during access to U-EB Server.", "Data not found: {0}.", "An error occurred during access to UEB Server, {1} failed to either register or unregister to/from UEB topic."),
-    
-    BeUserMissingError(ErrorCodesEnum.BEUSERMISSINGERROR_ONE_ARGUMENT, ErrorTypeEnum.DATA_ERROR, AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR,
-    							"ERR310E", "User is not found", "", "User {0} must be added to the corresponding application with proper user roles."),
-    
-    BeUserInactiveWarning(ErrorCodesEnum.BEUSERINACTIVEWARNING_ONE_ARGUMENT, ErrorTypeEnum.DATA_ERROR, AlarmSeverityEnum.MINOR, ErrorSeverityEnum.WARN,
-    							"ERR313W", "User is found but in-active", "", "User {0} must be added to the corresponding application with proper user roles."),
-    
-    BeUserAdminPrivilegesInfo(ErrorCodesEnum.BEUSERADMINPRIVILEGESINFO_ONE_ARGUMENT, ErrorTypeEnum.DATA_ERROR, AlarmSeverityEnum.MINOR, ErrorSeverityEnum.WARN,
-    							"ERR314W", "User is found but don't have administrative privileges", "", "User {0} should be given administrator role for the corresponding application to perform the necessary actions."),
-    
-    BeInvalidJsonInput(ErrorCodesEnum.BEINVALIDJSONINPUT, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR,
-    							"ERR405E", "Failed to convert JSON input to object", "", "Please check logs for more information."),
-    
-    BeIncorrectHttpStatusError(ErrorCodesEnum.BEINCORRECTHTTPSTATUSERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR,
-    							"ERR407E", "Communication to an external application is resulted in with Incorrect Http response code", "", "Please check logs for more information."),
-    
-    BeInitializationError(ErrorCodesEnum.BEINITIALIZATIONERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.CRITICAL, ErrorSeverityEnum.ERROR,
-    							"ERR500E", "ECOMP-PORTAL Back-end was not initialized properly", "", "Please check logs for more information."),
-    
-    BeUebSystemError(ErrorCodesEnum.BEUEBSYSTEMERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR,
-    							"ERR502E", "Error occurred during access to U-EB Server", "Details: {0}.", "An error occurred in {1} distribution mechanism. Please check the logs for more information."),
-    
-    BeDaoSystemError(ErrorCodesEnum.BEDAOSYSTEMERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.CRITICAL, ErrorSeverityEnum.ERROR,
-    							"ERR505E", "Performing DDL or DML operations on database might have failed", "", "Please check MySQL DB health or look at the logs for more details."),
-    
-    BeSystemError(ErrorCodesEnum.BESYSTEMERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.CRITICAL, ErrorSeverityEnum.ERROR,
-    							"ERR506E", "Unexpected error during operation", "", "Please check logs for more information."),
-    
-    BeExecuteRollbackError(ErrorCodesEnum.BEEXECUTEROLLBACKERROR, ErrorTypeEnum.DATA_ERROR, AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR,
-    							"ERR507E", "Roll-back operation towards database has failed", "", "Please check MYSQL DB health or look at the logs for more details."),
-    
-    FeHttpLoggingError(ErrorCodesEnum.FEHTTPLOGGINGERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.MINOR, ErrorSeverityEnum.ERROR,
-    							"ERR517E", "Error when logging FE HTTP request/response", "", "Please check MYSQL DB health or look at the logs for more details."),
-    
-	FePortalServletError(ErrorCodesEnum.FEPORTALSERVLETERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR,
-								"ERR518E", "Error when trying to access FE Portal page.", "", "Please check logs for more information."),
-	
-    BeDaoCloseSessionError(ErrorCodesEnum.BEDAOCLOSESESSIONERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR,
-    							"ERR519E", "Close local session operation with database failed", "", "Please check MYSQL DB health or look at the logs form more details."),
-    
-    BeRestApiGeneralError(ErrorCodesEnum.BERESTAPIGENERALERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.CRITICAL, ErrorSeverityEnum.ERROR,
-    							"ERR900E", "Unexpected error during ECOMP-PORTAL Back-end REST API execution", "", "Please check error log for more information."),
-    
-    FeHealthCheckGeneralError(ErrorCodesEnum.FEHEALTHCHECKGENERALERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.CRITICAL, ErrorSeverityEnum.ERROR,
-    							"ERR901E", "General error during FE Health Check", "", "Please check error log for more information."),
-    
-    InternalUnexpectedInfo(ErrorCodesEnum.INTERNALUNEXPECTEDINFO_ONE_ARGUMENT, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.INFORMATIONAL, ErrorSeverityEnum.INFO,
-    							"ERR999I", "Unexpected error", "Details: {0}.", "Please check logs for more information."),
-    
-    InternalUnexpectedWarning(ErrorCodesEnum.INTERNALUNEXPECTEDWARNING_ONE_ARGUMENT, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.MINOR, ErrorSeverityEnum.WARN,
-    							"ERR999W", "Unexpected error", "Details: {0}.", "Please check logs for more information."),
-    
-    InternalUnexpectedError(ErrorCodesEnum.INTERNALUNEXPECTEDERROR_ONE_ARGUMENT, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR,
-    							"ERR999E", "Unexpected error", "Details: {0}.", "Please check logs for more information."),
-    
-    InternalUnexpectedFatal(ErrorCodesEnum.INTERNALUNEXPECTEDFATAL_ONE_ARGUMENT, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.CRITICAL, ErrorSeverityEnum.FATAL,
-    							"ERR999F", "Unexpected error", "Details: {0}.", "Please check logs for more information."),
-	
+	 * 100-199 Security/Permission Related - Authentication problems (from external
+	 * client, to external server) - Certification errors -
+	 * 
+	 * 200-299 Availability/Timeout Related - connectivity error - connection
+	 * timeout
+	 * 
+	 * 300-399 Data Access/Integrity Related - Data in graph in invalid(E.g. no
+	 * creator is found for service) - Artifact is missing in ES, but exists in
+	 * graph.
+	 * 
+	 * 400-499 Schema Interface Type/Validation - received Pay-load checksum is
+	 * invalid - received JSON is not valid
+	 * 
+	 * 500-599 Business/Flow Processing Related - check out to service is not
+	 * allowed - Roll-back is done - failed to generate heat file
+	 * 
+	 * 
+	 * 600-899 Reserved - do not use
+	 * 
+	 * 900-999 Unknown Errors - Unexpected exception
+	 */
+
+	BeUebAuthenticationError(ErrorCodesEnum.BEUEBAUTHENTICATIONERROR_ONE_ARGUMENT, ErrorTypeEnum.AUTHENTICATION_PROBLEM,
+			AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR, "ERR100E",
+			"An Authentication failure occurred during access to UEB server", "Details: {0}.",
+			"Please check UEB server list and keys configured under Portal.Properties file."),
+
+	BeRestApiAuthenticationError(ErrorCodesEnum.BERESTAPIAUTHENTICATIONERROR, ErrorTypeEnum.AUTHENTICATION_PROBLEM,
+			AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR, "ERR101E",
+			"Rejected an incoming REST API request due to invalid credentials", "",
+			"Please check application credentials defined in Database or properties files."),
+
+	InternalAuthenticationInfo(ErrorCodesEnum.INTERNALAUTHENTICATIONINFO_ONE_ARGUMENT,
+			ErrorTypeEnum.AUTHENTICATION_PROBLEM, AlarmSeverityEnum.INFORMATIONAL, ErrorSeverityEnum.INFO, "ERR199I",
+			"Internal authentication problem", "Details: {0}.", "Please check the logs for more information."),
+
+	InternalAuthenticationWarning(ErrorCodesEnum.INTERNALAUTHENTICATIONWARNING_ONE_ARGUMENT,
+			ErrorTypeEnum.AUTHENTICATION_PROBLEM, AlarmSeverityEnum.MINOR, ErrorSeverityEnum.WARN, "ERR199W",
+			"Internal authentication problem", "Details: {0}.", "Please check the logs for more information."),
+
+	InternalAuthenticationError(ErrorCodesEnum.INTERNALAUTHENTICATIONERROR_ONE_ARGUMENT,
+			ErrorTypeEnum.AUTHENTICATION_PROBLEM, AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR, "ERR199E",
+			"Internal authentication problem", "Details: {0}.", "Please check the logs for more information."),
+
+	InternalAuthenticationFatal(ErrorCodesEnum.INTERNALAUTHENTICATIONFATAL_ONE_ARGUMENT,
+			ErrorTypeEnum.AUTHENTICATION_PROBLEM, AlarmSeverityEnum.CRITICAL, ErrorSeverityEnum.FATAL, "ERR199F",
+			"Internal authentication problem", "Details: {0}.", "Please check the logs for more information."),
+
+	BeHealthCheckError(ErrorCodesEnum.BeHEALTHCHECKERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.CRITICAL,
+			ErrorSeverityEnum.ERROR, "ERR200E",
+			"ECOMP-PORTAL Back-end probably lost connectivity to either one of the following components: MySQL DB, UEB Cluster",
+			"", "Please check the logs for more information."),
+
+	BeHealthCheckMySqlError(ErrorCodesEnum.BEHEALTHCHECKMYSQLERROR, ErrorTypeEnum.SYSTEM_ERROR,
+			AlarmSeverityEnum.CRITICAL, ErrorSeverityEnum.ERROR, "ERR201E",
+			"ECOMP-PORTAL Back-end probably lost connectivity to MySQL DB", "",
+			"Check connectivity to MYSQL is configured correctly under system.properties file."),
+
+	BeHealthCheckUebClusterError(ErrorCodesEnum.BEHEALTHCHECKUEBCLUSTERERROR, ErrorTypeEnum.SYSTEM_ERROR,
+			AlarmSeverityEnum.CRITICAL, ErrorSeverityEnum.ERROR, "ERR203E",
+			"ECOMP-PORTAL Back-end probably lost connectivity to UEB Cluster", "",
+			"Check connectivity to UEB cluster which is configured under portal.properties file."),
+
+	FeHealthCheckError(ErrorCodesEnum.FEHEALTHCHECKERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.CRITICAL,
+			ErrorSeverityEnum.ERROR, "ERR204E", "Unable to connect to a valid ECOMP-PORTAL Back-end Server.", "",
+			"Please check connectivity from this FE instance towards BE or BE Load Balancer."),
+
+	BeHealthCheckRecovery(ErrorCodesEnum.BEHEALTHCHECKRECOVERY, ErrorTypeEnum.RECOVERY, AlarmSeverityEnum.INFORMATIONAL,
+			ErrorSeverityEnum.INFO, "ERR205I",
+			"ECOMP-PORTAL Back-end Recovery to either one of the following components: MySQL DB, UEB Cluster", "",
+			"Please check logs for more specific information about the problem."),
+
+	BeHealthCheckMySqlRecovery(ErrorCodesEnum.BEHEALTHCHECKMYSQLRECOVERY, ErrorTypeEnum.RECOVERY,
+			AlarmSeverityEnum.INFORMATIONAL, ErrorSeverityEnum.INFO, "ERR206I",
+			"ECOMP-PORTAL Back-end connection recovery to MySQL DB", "",
+			"Please check logs for more specific information about the problem."),
+
+	BeHealthCheckUebClusterRecovery(ErrorCodesEnum.BEHEALTHCHECKUEBCLUSTERRECOVERY, ErrorTypeEnum.RECOVERY,
+			AlarmSeverityEnum.INFORMATIONAL, ErrorSeverityEnum.INFO, "ERR208I",
+			"ECOMP-PORTAL Back-end connection recovery to UEB Cluster", "",
+			"Please check logs for more specific information about the problem."),
+
+	FeHealthCheckRecovery(ErrorCodesEnum.FEHEALTHCHECKRECOVERY, ErrorTypeEnum.RECOVERY, AlarmSeverityEnum.INFORMATIONAL,
+			ErrorSeverityEnum.INFO, "ERR209I", "Connectivity to ECOMP-PORTAL Front-end Server is recovered", "",
+			"Please check logs for more specific information about the problem."),
+
+	BeUebConnectionError(ErrorCodesEnum.BEUEBCONNECTIONERROR_ONE_ARGUMENT, ErrorTypeEnum.CONNECTION_PROBLEM,
+			AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR, "ERR210E",
+			"ECOMP-PORTAL Back-end probably lost connectivity to UEB Cluster", "Details: {0}.",
+			"Please check UEB server list and keys configured under Portal.Properties file."),
+
+	BeUebUnkownHostError(ErrorCodesEnum.BEUEBUNKOWNHOSTERROR_ONE_ARGUMENT, ErrorTypeEnum.CONNECTION_PROBLEM,
+			AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR, "ERR211E",
+			"ECOMP-PORTAL Back-end probably lost connectivity to UEB Cluster", "Cannot reach host: {0}.",
+			"Please check UEB server list and keys configured under Portal.Properties file."),
+
+	BeUebRegisterOnboardingAppError(ErrorCodesEnum.BEUEBREGISTERONBOARDINGAPPERROR, ErrorTypeEnum.CONNECTION_PROBLEM,
+			AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR, "ERR212E",
+			"Failed to register the On-boarding application with UEB Communication server", "Details: {0}.",
+			"Please check UEB server list and keys configured under Portal.Properties file."),
+
+	BeHttpConnectionError(ErrorCodesEnum.BEHTTPCONNECTIONERROR_ONE_ARGUMENT, ErrorTypeEnum.CONNECTION_PROBLEM,
+			AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR, "ERR213E",
+			"It could be that communication to an external application might resulted an exception or failed to reach the external application",
+			"Details: {0}.", "Please check logs for more information."),
+
+	InternalConnectionInfo(ErrorCodesEnum.INTERNALCONNECTIONINFO_ONE_ARGUMENT, ErrorTypeEnum.CONNECTION_PROBLEM,
+			AlarmSeverityEnum.INFORMATIONAL, ErrorSeverityEnum.INFO, "ERR299I", "Internal Connection problem",
+			"Details: {0}.", "Please check logs for more information."),
+
+	InternalConnectionWarning(ErrorCodesEnum.INTERNALCONNECTIONWARNING_ONE_ARGUMENT, ErrorTypeEnum.CONNECTION_PROBLEM,
+			AlarmSeverityEnum.MINOR, ErrorSeverityEnum.WARN, "ERR299W", "Internal Connection problem", "Details: {0}.",
+			"Please check logs for more information."),
+
+	InternalConnectionError(ErrorCodesEnum.INTERNALCONNECTIONERROR_ONE_ARGUMENT, ErrorTypeEnum.CONNECTION_PROBLEM,
+			AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR, "ERR299E", "Internal Connection problem", "Details: {0}.",
+			"Please check logs for more information."),
+
+	InternalConnectionFatal(ErrorCodesEnum.INTERNALCONNECTIONFATAL_ONE_ARGUMENT, ErrorTypeEnum.CONNECTION_PROBLEM,
+			AlarmSeverityEnum.CRITICAL, ErrorSeverityEnum.FATAL, "ERR299F", "Internal Connection problem",
+			"Details: {0}.", "Please check logs for more information."),
+
+	BeUebObjectNotFoundError(ErrorCodesEnum.BEUEBOBJECTNOTFOUNDERROR_ONE_ARGUMENT, ErrorTypeEnum.DATA_ERROR,
+			AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR, "ERR303E", "Error occurred during access to U-EB Server.",
+			"Data not found: {0}.",
+			"An error occurred during access to UEB Server, {1} failed to either register or unregister to/from UEB topic."),
+
+	BeUserMissingError(ErrorCodesEnum.BEUSERMISSINGERROR_ONE_ARGUMENT, ErrorTypeEnum.DATA_ERROR,
+			AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR, "ERR310E", "User is not found", "",
+			"User {0} must be added to the corresponding application with proper user roles."),
+
+	BeUserInactiveWarning(ErrorCodesEnum.BEUSERINACTIVEWARNING_ONE_ARGUMENT, ErrorTypeEnum.DATA_ERROR,
+			AlarmSeverityEnum.MINOR, ErrorSeverityEnum.WARN, "ERR313W", "User is found but in-active", "",
+			"User {0} must be added to the corresponding application with proper user roles."),
+
+	BeUserAdminPrivilegesInfo(ErrorCodesEnum.BEUSERADMINPRIVILEGESINFO_ONE_ARGUMENT, ErrorTypeEnum.DATA_ERROR,
+			AlarmSeverityEnum.MINOR, ErrorSeverityEnum.WARN, "ERR314W",
+			"User is found but don't have administrative privileges", "",
+			"User {0} should be given administrator role for the corresponding application to perform the necessary actions."),
+
+	BeInvalidJsonInput(ErrorCodesEnum.BEINVALIDJSONINPUT, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.MAJOR,
+			ErrorSeverityEnum.ERROR, "ERR405E", "Failed to convert JSON input to object", "",
+			"Please check logs for more information."),
+
+	BeIncorrectHttpStatusError(ErrorCodesEnum.BEINCORRECTHTTPSTATUSERROR, ErrorTypeEnum.SYSTEM_ERROR,
+			AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR, "ERR407E",
+			"Communication to an external application is resulted in with Incorrect Http response code", "",
+			"Please check logs for more information."),
+
+	BeInitializationError(ErrorCodesEnum.BEINITIALIZATIONERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.CRITICAL,
+			ErrorSeverityEnum.ERROR, "ERR500E", "ECOMP-PORTAL Back-end was not initialized properly", "",
+			"Please check logs for more information."),
+
+	BeUebSystemError(ErrorCodesEnum.BEUEBSYSTEMERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.MAJOR,
+			ErrorSeverityEnum.ERROR, "ERR502E", "Error occurred during access to U-EB Server", "Details: {0}.",
+			"An error occurred in {1} distribution mechanism. Please check the logs for more information."),
+
+	BeDaoSystemError(ErrorCodesEnum.BEDAOSYSTEMERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.CRITICAL,
+			ErrorSeverityEnum.ERROR, "ERR505E", "Performing DDL or DML operations on database might have failed", "",
+			"Please check MySQL DB health or look at the logs for more details."),
+
+	BeSystemError(ErrorCodesEnum.BESYSTEMERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.CRITICAL,
+			ErrorSeverityEnum.ERROR, "ERR506E", "Unexpected error during operation", "",
+			"Please check logs for more information."),
+
+	BeExecuteRollbackError(ErrorCodesEnum.BEEXECUTEROLLBACKERROR, ErrorTypeEnum.DATA_ERROR, AlarmSeverityEnum.MAJOR,
+			ErrorSeverityEnum.ERROR, "ERR507E", "Roll-back operation towards database has failed", "",
+			"Please check MYSQL DB health or look at the logs for more details."),
+
+	FeHttpLoggingError(ErrorCodesEnum.FEHTTPLOGGINGERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.MINOR,
+			ErrorSeverityEnum.ERROR, "ERR517E", "Error when logging FE HTTP request/response", "",
+			"Please check MYSQL DB health or look at the logs for more details."),
+
+	FePortalServletError(ErrorCodesEnum.FEPORTALSERVLETERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.MAJOR,
+			ErrorSeverityEnum.ERROR, "ERR518E", "Error when trying to access FE Portal page.", "",
+			"Please check logs for more information."),
+
+	BeDaoCloseSessionError(ErrorCodesEnum.BEDAOCLOSESESSIONERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.MAJOR,
+			ErrorSeverityEnum.ERROR, "ERR519E", "Close local session operation with database failed", "",
+			"Please check MYSQL DB health or look at the logs form more details."),
+
+	BeRestApiGeneralError(ErrorCodesEnum.BERESTAPIGENERALERROR, ErrorTypeEnum.SYSTEM_ERROR, AlarmSeverityEnum.CRITICAL,
+			ErrorSeverityEnum.ERROR, "ERR900E", "Unexpected error during ECOMP-PORTAL Back-end REST API execution", "",
+			"Please check error log for more information."),
+
+	FeHealthCheckGeneralError(ErrorCodesEnum.FEHEALTHCHECKGENERALERROR, ErrorTypeEnum.SYSTEM_ERROR,
+			AlarmSeverityEnum.CRITICAL, ErrorSeverityEnum.ERROR, "ERR901E", "General error during FE Health Check", "",
+			"Please check error log for more information."),
+
+	InternalUnexpectedInfo(ErrorCodesEnum.INTERNALUNEXPECTEDINFO_ONE_ARGUMENT, ErrorTypeEnum.SYSTEM_ERROR,
+			AlarmSeverityEnum.INFORMATIONAL, ErrorSeverityEnum.INFO, "ERR999I", "Unexpected error", "Details: {0}.",
+			"Please check logs for more information."),
+
+	InternalUnexpectedWarning(ErrorCodesEnum.INTERNALUNEXPECTEDWARNING_ONE_ARGUMENT, ErrorTypeEnum.SYSTEM_ERROR,
+			AlarmSeverityEnum.MINOR, ErrorSeverityEnum.WARN, "ERR999W", "Unexpected error", "Details: {0}.",
+			"Please check logs for more information."),
+
+	InternalUnexpectedError(ErrorCodesEnum.INTERNALUNEXPECTEDERROR_ONE_ARGUMENT, ErrorTypeEnum.SYSTEM_ERROR,
+			AlarmSeverityEnum.MAJOR, ErrorSeverityEnum.ERROR, "ERR999E", "Unexpected error", "Details: {0}.",
+			"Please check logs for more information."),
+
+	InternalUnexpectedFatal(ErrorCodesEnum.INTERNALUNEXPECTEDFATAL_ONE_ARGUMENT, ErrorTypeEnum.SYSTEM_ERROR,
+			AlarmSeverityEnum.CRITICAL, ErrorSeverityEnum.FATAL, "ERR999F", "Unexpected error", "Details: {0}.",
+			"Please check logs for more information."),
+
 	;
-	
+
 	ErrorTypeEnum eType;
 	AlarmSeverityEnum alarmSeverity;
 	ErrorCodesEnum messageCode;
@@ -205,9 +254,10 @@ public enum AppMessagesEnum {
 	String errorDescription;
 	String details;
 	String resolution;
-	
-	AppMessagesEnum(ErrorCodesEnum messageCode, ErrorTypeEnum eType, AlarmSeverityEnum alarmSeverity, ErrorSeverityEnum errorSeverity, String errorCode, String errorDescription, 
-						String details, String resolution) {
+
+	AppMessagesEnum(ErrorCodesEnum messageCode, ErrorTypeEnum eType, AlarmSeverityEnum alarmSeverity,
+			ErrorSeverityEnum errorSeverity, String errorCode, String errorDescription, String details,
+			String resolution) {
 		this.messageCode = messageCode;
 		this.eType = eType;
 		this.alarmSeverity = alarmSeverity;
@@ -217,30 +267,31 @@ public enum AppMessagesEnum {
 		this.details = details;
 		this.resolution = resolution;
 	}
-	
+
 	public String getDetails() {
 		return this.details;
 	}
-	
+
 	public String getResolution() {
 		return this.resolution;
 	}
+
 	public String getErrorCode() {
 		return this.errorCode;
 	}
-	
+
 	public String getErrorDescription() {
 		return this.errorDescription;
 	}
-	
+
 	public ErrorSeverityEnum getErrorSeverity() {
 		return this.errorSeverity;
 	}
-	
+
 	public void setErrorSeverity(ErrorSeverityEnum errorSeverity) {
 		this.errorSeverity = errorSeverity;
 	}
-	
+
 	public ErrorCodesEnum getMessageCode() {
 		return messageCode;
 	}
@@ -248,7 +299,7 @@ public enum AppMessagesEnum {
 	public void setMessageCode(ErrorCodesEnum messageCode) {
 		this.messageCode = messageCode;
 	}
-	
+
 	public AlarmSeverityEnum getAlarmSeverity() {
 		return alarmSeverity;
 	}
@@ -256,7 +307,7 @@ public enum AppMessagesEnum {
 	public void setAlarmSeverity(AlarmSeverityEnum alarmSeverity) {
 		this.alarmSeverity = alarmSeverity;
 	}
-	
+
 	public ErrorTypeEnum getErrorType() {
 		return eType;
 	}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/AuditLogFormatter.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/AuditLogFormatter.java
index 4ea932a3..d7a80ee5 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/AuditLogFormatter.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/AuditLogFormatter.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -43,51 +43,47 @@ import java.util.Map;
 import org.onap.portalsdk.core.util.SystemProperties;
 
 public class AuditLogFormatter {
-	//Singleton
+	// Singleton
 	private static AuditLogFormatter instance = new AuditLogFormatter();
-	
+
 	public static AuditLogFormatter getInstance() {
-		
+
 		return instance;
 	}
-	
-	public String createMessage(String protocol,String set, 
-			String loginId, String message) {
-	
-	Object[] securityMessageArgs = prepareFormatArgs(
-			protocol,
-			set,
-			loginId,
-			message );
-	
+
+	public String createMessage(String protocol, String set, String loginId, String message) {
+
+		Object[] securityMessageArgs = prepareFormatArgs(protocol, set, loginId, message);
+
 		return MessageFormat.format(SystemProperties.SECURITY_LOG_TEMPLATE, securityMessageArgs);
 	}
-	
+
 	/**
-	 * A method for normalizing the security log field - returns 
-	 * the @Param defaultValue in case the entry is null or empty.
-	 * If the @param entry is not empty, a single quotation is added to it.
+	 * A method for normalizing the security log field - returns the @Param
+	 * defaultValue in case the entry is null or empty. If the @param entry is not
+	 * empty, a single quotation is added to it.
 	 * 
-	 * @param entry the entry
-	 * @param defaultValue The default value in case the entry is empty
+	 * @param entry
+	 *            the entry
+	 * @param defaultValue
+	 *            The default value in case the entry is empty
 	 * @return String (formatted)
 	 */
 	private String formatEntry(Object entry, String defaultValue) {
-		return  (entry!=null && !entry.toString().isEmpty()) ? addSingleQuotes(entry.toString()): defaultValue;		
+		return (entry != null && !entry.toString().isEmpty()) ? addSingleQuotes(entry.toString()) : defaultValue;
 
 	}
-	
+
 	private String addSingleQuotes(String s) {
-		if (null!=s && !s.isEmpty()) {
-			s =  SystemProperties.SINGLE_QUOTE+s+SystemProperties.SINGLE_QUOTE;
+		if (null != s && !s.isEmpty()) {
+			s = SystemProperties.SINGLE_QUOTE + s + SystemProperties.SINGLE_QUOTE;
 		}
 		return s;
 	}
-	
-	
+
 	/**
-	 * This method prepares an Object array of arguments that would be passed
-	 * to the MessageFormat.format() method, to format the security log.
+	 * This method prepares an Object array of arguments that would be passed to the
+	 * MessageFormat.format() method, to format the security log.
 	 * 
 	 * @param protocol
 	 * @param set
@@ -97,28 +93,19 @@ public class AuditLogFormatter {
 	 * @param message
 	 * @return
 	 */
-	private Object[] prepareFormatArgs(String protocol,String set, 
-			String loginId, String message) {
-		
-		Object[] messageFormatArgs = {
-				formatEntry(protocol, SystemProperties.NA),
-				formatEntry(set, SystemProperties.NA),
-				formatEntry(loginId, SystemProperties.UNKNOWN),
-				message
-				};
+	private Object[] prepareFormatArgs(String protocol, String set, String loginId, String message) {
+
+		Object[] messageFormatArgs = { formatEntry(protocol, SystemProperties.NA),
+				formatEntry(set, SystemProperties.NA), formatEntry(loginId, SystemProperties.UNKNOWN), message };
 		return messageFormatArgs;
 	}
 
-
 	public String createMessage(Map logArgsMap) {
-				
-		Object[] securityMessageArgs = prepareFormatArgs(
-				logArgsMap.get(SystemProperties.PROTOCOL),
-				logArgsMap.get(SystemProperties.SECURIRY_EVENT_TYPE),
-				logArgsMap.get(SystemProperties.LOGIN_ID),
-				logArgsMap.get(SystemProperties.ADDITIONAL_INFO) 
-			);
-		
+
+		Object[] securityMessageArgs = prepareFormatArgs(logArgsMap.get(SystemProperties.PROTOCOL),
+				logArgsMap.get(SystemProperties.SECURIRY_EVENT_TYPE), logArgsMap.get(SystemProperties.LOGIN_ID),
+				logArgsMap.get(SystemProperties.ADDITIONAL_INFO));
+
 		return MessageFormat.format(SystemProperties.SECURITY_LOG_TEMPLATE, securityMessageArgs);
 	}
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/ErrorCodesEnum.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/ErrorCodesEnum.java
index 6dc7e99d..9ae1fbf0 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/ErrorCodesEnum.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/ErrorCodesEnum.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -41,67 +41,37 @@ import com.att.eelf.i18n.EELFResolvableErrorEnum;
 //import com.att.eelf.i18n.EELFResourceManager;
 
 public enum ErrorCodesEnum implements EELFResolvableErrorEnum {
-	BERESTAPIAUTHENTICATIONERROR,
-	BEHTTPCONNECTIONERROR_ONE_ARGUMENT,
-	BEUEBAUTHENTICATIONERROR_ONE_ARGUMENT,
-	
-	INTERNALAUTHENTICATIONINFO_ONE_ARGUMENT,
-	INTERNALAUTHENTICATIONWARNING_ONE_ARGUMENT,
-	INTERNALAUTHENTICATIONERROR_ONE_ARGUMENT,
-	INTERNALAUTHENTICATIONFATAL_ONE_ARGUMENT,
-	
-	BEHEALTHCHECKRECOVERY,
-	BEHEALTHCHECKMYSQLRECOVERY,
-	BEHEALTHCHECKUEBCLUSTERRECOVERY,
-	FEHEALTHCHECKRECOVERY,
-	BeHEALTHCHECKERROR,
-	
-	BEHEALTHCHECKMYSQLERROR,
-	BEHEALTHCHECKUEBCLUSTERERROR,
-	FEHEALTHCHECKERROR,
-	BEUEBCONNECTIONERROR_ONE_ARGUMENT,
-	BEUEBUNKOWNHOSTERROR_ONE_ARGUMENT,
-	BEUEBREGISTERONBOARDINGAPPERROR,
-	
-	INTERNALCONNECTIONINFO_ONE_ARGUMENT,
-	INTERNALCONNECTIONWARNING_ONE_ARGUMENT,
-	INTERNALCONNECTIONERROR_ONE_ARGUMENT,
-	INTERNALCONNECTIONFATAL_ONE_ARGUMENT,
-	
-	BEUEBOBJECTNOTFOUNDERROR_ONE_ARGUMENT,
-	BEUSERMISSINGERROR_ONE_ARGUMENT,
-	
-	BEUSERINACTIVEWARNING_ONE_ARGUMENT,
-	BEUSERADMINPRIVILEGESINFO_ONE_ARGUMENT,
-	
-	BEINVALIDJSONINPUT,
-	BEINCORRECTHTTPSTATUSERROR,
-		
-	BEINITIALIZATIONERROR,
-	BEUEBSYSTEMERROR,
-	BEDAOSYSTEMERROR,
-	BESYSTEMERROR,
-	BEEXECUTEROLLBACKERROR,
-	
-	FEHTTPLOGGINGERROR,
-	FEPORTALSERVLETERROR,
-	BEDAOCLOSESESSIONERROR,
-	
-	BERESTAPIGENERALERROR,
-	FEHEALTHCHECKGENERALERROR,
-	
-	INTERNALUNEXPECTEDINFO_ONE_ARGUMENT,
-	INTERNALUNEXPECTEDWARNING_ONE_ARGUMENT,
-	INTERNALUNEXPECTEDERROR_ONE_ARGUMENT,
-	INTERNALUNEXPECTEDFATAL_ONE_ARGUMENT,
-	
+	BERESTAPIAUTHENTICATIONERROR, BEHTTPCONNECTIONERROR_ONE_ARGUMENT, BEUEBAUTHENTICATIONERROR_ONE_ARGUMENT,
+
+	INTERNALAUTHENTICATIONINFO_ONE_ARGUMENT, INTERNALAUTHENTICATIONWARNING_ONE_ARGUMENT, INTERNALAUTHENTICATIONERROR_ONE_ARGUMENT, INTERNALAUTHENTICATIONFATAL_ONE_ARGUMENT,
+
+	BEHEALTHCHECKRECOVERY, BEHEALTHCHECKMYSQLRECOVERY, BEHEALTHCHECKUEBCLUSTERRECOVERY, FEHEALTHCHECKRECOVERY, BeHEALTHCHECKERROR,
+
+	BEHEALTHCHECKMYSQLERROR, BEHEALTHCHECKUEBCLUSTERERROR, FEHEALTHCHECKERROR, BEUEBCONNECTIONERROR_ONE_ARGUMENT, BEUEBUNKOWNHOSTERROR_ONE_ARGUMENT, BEUEBREGISTERONBOARDINGAPPERROR,
+
+	INTERNALCONNECTIONINFO_ONE_ARGUMENT, INTERNALCONNECTIONWARNING_ONE_ARGUMENT, INTERNALCONNECTIONERROR_ONE_ARGUMENT, INTERNALCONNECTIONFATAL_ONE_ARGUMENT,
+
+	BEUEBOBJECTNOTFOUNDERROR_ONE_ARGUMENT, BEUSERMISSINGERROR_ONE_ARGUMENT,
+
+	BEUSERINACTIVEWARNING_ONE_ARGUMENT, BEUSERADMINPRIVILEGESINFO_ONE_ARGUMENT,
+
+	BEINVALIDJSONINPUT, BEINCORRECTHTTPSTATUSERROR,
+
+	BEINITIALIZATIONERROR, BEUEBSYSTEMERROR, BEDAOSYSTEMERROR, BESYSTEMERROR, BEEXECUTEROLLBACKERROR,
+
+	FEHTTPLOGGINGERROR, FEPORTALSERVLETERROR, BEDAOCLOSESESSIONERROR,
+
+	BERESTAPIGENERALERROR, FEHEALTHCHECKGENERALERROR,
+
+	INTERNALUNEXPECTEDINFO_ONE_ARGUMENT, INTERNALUNEXPECTEDWARNING_ONE_ARGUMENT, INTERNALUNEXPECTEDERROR_ONE_ARGUMENT, INTERNALUNEXPECTEDFATAL_ONE_ARGUMENT,
+
 	;
-	
+
 	/**
-     * Static initializer to ensure the resource bundles for this class are loaded...
-     * Here this application loads messages from three bundles
-     */
-    //static {
-    //    EELFResourceManager.loadMessageBundle("com/att/fusion/core/logging/format/ApplicationCodes");
-    //}
+	 * Static initializer to ensure the resource bundles for this class are
+	 * loaded... Here this application loads messages from three bundles
+	 */
+	// static {
+	// EELFResourceManager.loadMessageBundle("com/att/fusion/core/logging/format/ApplicationCodes");
+	// }
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/ErrorSeverityEnum.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/ErrorSeverityEnum.java
index 468a2b9a..83f4c1a5 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/ErrorSeverityEnum.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/ErrorSeverityEnum.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -38,8 +38,5 @@
 package org.onap.portalsdk.core.logging.format;
 
 public enum ErrorSeverityEnum {
-	INFO, 
-	WARN, 
-	ERROR, 
-	FATAL,
+	INFO, WARN, ERROR, FATAL,
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/ErrorTypeEnum.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/ErrorTypeEnum.java
index 77477ca1..4f9962b4 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/ErrorTypeEnum.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/format/ErrorTypeEnum.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -38,10 +38,5 @@
 package org.onap.portalsdk.core.logging.format;
 
 public enum ErrorTypeEnum {
-	RECOVERY, 
-	CONFIG_ERROR, 
-	SYSTEM_ERROR, 
-	DATA_ERROR, 
-	CONNECTION_PROBLEM, 
-	AUTHENTICATION_PROBLEM
+	RECOVERY, CONFIG_ERROR, SYSTEM_ERROR, DATA_ERROR, CONNECTION_PROBLEM, AUTHENTICATION_PROBLEM
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/logic/EELFLoggerDelegate.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/logic/EELFLoggerDelegate.java
index 2eef3793..1d3ac743 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/logic/EELFLoggerDelegate.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/logging/logic/EELFLoggerDelegate.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -67,17 +67,18 @@ import com.att.eelf.configuration.SLF4jWrapper;
 
 public class EELFLoggerDelegate extends SLF4jWrapper implements EELFLogger {
 
-	public static EELFLogger errorLogger = EELFManager.getInstance().getErrorLogger();
-	public static EELFLogger applicationLogger = EELFManager.getInstance().getApplicationLogger();
-	public static EELFLogger auditLogger = EELFManager.getInstance().getAuditLogger();
-	public static EELFLogger metricsLogger = EELFManager.getInstance().getMetricsLogger();
-	public static EELFLogger debugLogger = EELFManager.getInstance().getDebugLogger();
+	public static final EELFLogger errorLogger = EELFManager.getInstance().getErrorLogger();
+	public static final EELFLogger applicationLogger = EELFManager.getInstance().getApplicationLogger();
+	public static final EELFLogger auditLogger = EELFManager.getInstance().getAuditLogger();
+	public static final EELFLogger metricsLogger = EELFManager.getInstance().getMetricsLogger();
+	public static final EELFLogger debugLogger = EELFManager.getInstance().getDebugLogger();
+
 	private String className;
-	private static ConcurrentMap classMap = new ConcurrentHashMap();
+	private static ConcurrentMap classMap = new ConcurrentHashMap<>();
 
-	public EELFLoggerDelegate(String _className) {
-		super(_className);
-		className = _className;
+	public EELFLoggerDelegate(final String className) {
+		super(className);
+		this.className = className;
 	}
 
 	/**
@@ -93,17 +94,17 @@ public class EELFLoggerDelegate extends SLF4jWrapper implements EELFLogger {
 	}
 
 	/**
-	 * Gets a logger for the specified class name. If the logger does not
-	 * already exist in the map, this creates a new logger.
+	 * Gets a logger for the specified class name. If the logger does not already
+	 * exist in the map, this creates a new logger.
 	 * 
 	 * @param className
 	 *            If null or empty, uses EELFLoggerDelegate as the class name.
 	 * @return Instance of EELFLoggerDelegate
 	 */
-	public static EELFLoggerDelegate getLogger(String className) {
-		if (className == null || className == "")
-			className = EELFLoggerDelegate.class.getName();
-		EELFLoggerDelegate delegate = classMap.get(className);
+	public static EELFLoggerDelegate getLogger(final String className) {
+		String classNameNeverNull = className == null || "".equals(className) ? EELFLoggerDelegate.class.getName()
+				: className;
+		EELFLoggerDelegate delegate = classMap.get(classNameNeverNull);
 		if (delegate == null) {
 			delegate = new EELFLoggerDelegate(className);
 			classMap.put(className, delegate);
@@ -355,9 +356,9 @@ public class EELFLoggerDelegate extends SLF4jWrapper implements EELFLogger {
 	}
 
 	/**
-	 * Logs a standard message identified by the specified enum, using the
-	 * specified parameters, at error level. Alarm and error severity are taken
-	 * from the specified enum argument.
+	 * Logs a standard message identified by the specified enum, using the specified
+	 * parameters, at error level. Alarm and error severity are taken from the
+	 * specified enum argument.
 	 * 
 	 * @param epMessageEnum
 	 * @param param
@@ -381,7 +382,7 @@ public class EELFLoggerDelegate extends SLF4jWrapper implements EELFLogger {
 				errorLogger.error(resolution);
 			}
 		} catch (Exception e) {
-			errorLogger.error("Failed to log the error code. Details: " + UserUtils.getStackTrace(e));
+			errorLogger.error("logEcompError failed", e);
 		} finally {
 			MDC.remove("ErrorCode");
 			MDC.remove("ErrorDescription");
@@ -419,6 +420,7 @@ public class EELFLoggerDelegate extends SLF4jWrapper implements EELFLogger {
 			MDC.put(MDC_SERVER_IP_ADDRESS, InetAddress.getLocalHost().getHostAddress());
 			MDC.put(MDC_INSTANCE_UUID, SystemProperties.getProperty(SystemProperties.INSTANCE_UUID));
 		} catch (Exception e) {
+			errorLogger.error("setGlobalLoggingContext failed", e);
 		}
 	}
 
@@ -435,9 +437,9 @@ public class EELFLoggerDelegate extends SLF4jWrapper implements EELFLogger {
 	}
 
 	/**
-	 * Loads the RequestId/TransactionId into the MDC which it should be
-	 * receiving with an each incoming REST API request. Also, configures few
-	 * other request based logging fields into the MDC context.
+	 * Loads the RequestId/TransactionId into the MDC which it should be receiving
+	 * with an each incoming REST API request. Also, configures few other request
+	 * based logging fields into the MDC context.
 	 * 
 	 * @param req
 	 * @param appName
@@ -453,19 +455,17 @@ public class EELFLoggerDelegate extends SLF4jWrapper implements EELFLogger {
 			MDC.put(MDC_KEY_REQUEST_ID, requestId);
 
 			// Load user agent into MDC context, if available.
-			String accessingClient = "Unknown";
-			accessingClient = req.getHeader(SystemProperties.USERAGENT_NAME);
-			if (accessingClient != null && accessingClient != "" && (accessingClient.contains("Mozilla")
+			String accessingClient = req.getHeader(SystemProperties.USERAGENT_NAME);
+			if (accessingClient != null && !"".equals(accessingClient) && (accessingClient.contains("Mozilla")
 					|| accessingClient.contains("Chrome") || accessingClient.contains("Safari"))) {
 				accessingClient = appName + "_FE";
 			}
 			MDC.put(SystemProperties.PARTNER_NAME, accessingClient);
 
 			// Protocol, Rest URL & Rest Path
-			String restURL = "";
 			MDC.put(SystemProperties.FULL_URL, SystemProperties.UNKNOWN);
 			MDC.put(SystemProperties.PROTOCOL, SystemProperties.HTTP);
-			restURL = UserUtils.getFullURL(req);
+			String restURL = UserUtils.getFullURL(req);
 			if (restURL != null && restURL != "") {
 				MDC.put(SystemProperties.FULL_URL, restURL);
 				if (restURL.toLowerCase().contains("https")) {
@@ -478,8 +478,7 @@ public class EELFLoggerDelegate extends SLF4jWrapper implements EELFLogger {
 
 			// Client IPAddress i.e. IPAddress of the remote host who is making
 			// this request.
-			String clientIPAddress = "";
-			clientIPAddress = req.getHeader("X-FORWARDED-FOR");
+			String clientIPAddress = req.getHeader("X-FORWARDED-FOR");
 			if (clientIPAddress == null) {
 				clientIPAddress = req.getRemoteAddr();
 			}
@@ -487,12 +486,12 @@ public class EELFLoggerDelegate extends SLF4jWrapper implements EELFLogger {
 
 			// Load loginId into MDC context.
 			MDC.put(SystemProperties.MDC_LOGIN_ID, "Unknown");
-			
+
 			String loginId = "";
-				User user = UserUtils.getUserSession(req);
-				if (user != null) {
-					loginId = user.getLoginId();
-				}
+			User user = UserUtils.getUserSession(req);
+			if (user != null) {
+				loginId = user.getLoginId();
+			}
 
 			if (loginId != null && loginId != "") {
 				MDC.put(SystemProperties.MDC_LOGIN_ID, loginId);
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/menu/MenuBuilder.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/menu/MenuBuilder.java
index ac1e9396..9bd8f44d 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/menu/MenuBuilder.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/menu/MenuBuilder.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -54,128 +54,118 @@ import org.springframework.beans.factory.annotation.Autowired;
 @SuppressWarnings("rawtypes")
 public class MenuBuilder implements FusionObject {
 
-    @Autowired
-	private DataAccessService  dataAccessService;
+	@Autowired
+	private DataAccessService dataAccessService;
 
-    public MenuBuilder() {
-    }
+	@SuppressWarnings("unchecked")
+	public Set getMenu(String menuSetName, DataAccessService dataAccessService) {
 
-    @SuppressWarnings("unchecked")
-    public Set getMenu(String menuSetName, DataAccessService dataAccessService) {
+		Set menu = null;
 
-        Set      menu = null;
-        MenuData root = null;
+		HashMap params = new HashMap();
 
-        HashMap params = new HashMap();
+		params.put("menu_set_cd", menuSetName);
 
-        params.put("menu_set_cd", menuSetName);
+		// execute a query of the latest configuration of the FN_MENU table for the
+		// given menu_set_cd.
+		List menuItems = dataAccessService
+				.executeNamedQuery(SystemProperties.getProperty(SystemProperties.MENU_QUERY_NAME), params, null);
 
-        // execute a query of the latest configuration of the FN_MENU table for the given menu_set_cd.
-        List menuItems = dataAccessService.executeNamedQuery(SystemProperties.getProperty(SystemProperties.MENU_QUERY_NAME), params, null);
+		Iterator i = menuItems.iterator();
+		if (i.hasNext()) {
+			MenuData root = (MenuData) i.next();
+			menu = root.getChildMenus();
+		}
 
-        Iterator i = menuItems.iterator();
-        if (i.hasNext()) {
-            root = (MenuData)i.next();
-            menu = root.getChildMenus();
-        }
-
-        return menu;
-    }
-    
-    @SuppressWarnings("unchecked")
-    public Set getMenu(String menuSetName) {
+		return menu;
+	}
 
-        Set      menu = null;
-        MenuData root = null;
+	@SuppressWarnings("unchecked")
+	public Set getMenu(String menuSetName) {
 
-        HashMap params = new HashMap();
+		Set menu = null;
 
-        params.put("menu_set_cd", menuSetName);
+		HashMap params = new HashMap();
 
-        // execute a query of the latest configuration of the FN_MENU table for the given menu_set_cd.
-        List menuItems = getDataAccessService().executeNamedQuery(SystemProperties.getProperty(SystemProperties.MENU_QUERY_NAME), params, null);
+		params.put("menu_set_cd", menuSetName);
 
-        Iterator i = menuItems.iterator();
-        if (i.hasNext()) {
-            root = (MenuData)i.next();
-            menu = root.getChildMenus();
-        }
+		// execute a query of the latest configuration of the FN_MENU table for the
+		// given menu_set_cd.
+		List menuItems = getDataAccessService()
+				.executeNamedQuery(SystemProperties.getProperty(SystemProperties.MENU_QUERY_NAME), params, null);
 
-        return menu;
-    }
+		Iterator i = menuItems.iterator();
+		if (i.hasNext()) {
+			MenuData root = (MenuData) i.next();
+			menu = root.getChildMenus();
+		}
 
-    public static Set filterMenu(Set menus, HttpServletRequest request) {
-        Iterator j = menus.iterator();
+		return menu;
+	}
 
-        while (j.hasNext()) {
-      	  MenuData menuItem = (MenuData)j.next();
+	public static Set filterMenu(Set menus, HttpServletRequest request) {
+		Iterator j = menus.iterator();
 
-      	  if (!UserUtils.isAccessible(request, menuItem.getFunctionCd())) { 
-      	    // remove the menu if the user doesn't have access to it
-      	    j.remove();	
-      	  }
-      	  else { 
-       	    // if an accessible menu has a child menu, let's filter that recursively
+		while (j.hasNext()) {
+			MenuData menuItem = (MenuData) j.next();
 
-      	    Set childMenus = menuItem.getChildMenus();
-      	    if (childMenus != null && childMenus.size() > 0) {
-      		  filterMenu(childMenus, request);            	  
-      	    }
+			if (!UserUtils.isAccessible(request, menuItem.getFunctionCd())) {
+				// remove the menu if the user doesn't have access to it
+				j.remove();
+			} else {
+				// if an accessible menu has a child menu, let's filter that recursively
 
-      	  }
-        }
+				Set childMenus = menuItem.getChildMenus();
+				if (childMenus != null && ! childMenus.isEmpty()) {
+					filterMenu(childMenus, request);
+				}
 
-        return menus;
-    }
+			}
+		}
 
-    
-    public static String getUrlHtml(MenuData menuData) {
-      String html = "";
+		return menus;
+	}
 
-      if (menuData.getExternalUrl() != null && menuData.getExternalUrl().length() > 0) {
-        html = menuData.getExternalUrl();
-      }
-      else if (menuData.getServlet() != null && menuData.getServlet().length() > 0) {
-        html = "/" + menuData.getServlet();
-      }
-      else if (menuData.getAction() != null && menuData.getAction().length() > 0) {
-        html = "/" + menuData.getAction();
-      }
+	public static String getUrlHtml(MenuData menuData) {
+		String html = "";
 
-      return html;
-    }
+		if (menuData.getExternalUrl() != null && menuData.getExternalUrl().length() > 0) {
+			html = menuData.getExternalUrl();
+		} else if (menuData.getServlet() != null && menuData.getServlet().length() > 0) {
+			html = "/" + menuData.getServlet();
+		} else if (menuData.getAction() != null && menuData.getAction().length() > 0) {
+			html = "/" + menuData.getAction();
+		}
 
+		return html;
+	}
 
-    public static String getTargetHtml(MenuData menuData) {
-      String html = "";
+	public static String getTargetHtml(MenuData menuData) {
+		String html = "";
 
-      if (menuData.getTarget() != null && menuData.getTarget().length() > 0) {
-        html = "target=\"" + menuData.getTarget() + "\"";
-      }
+		if (menuData.getTarget() != null && menuData.getTarget().length() > 0) {
+			html = "target=\"" + menuData.getTarget() + "\"";
+		}
 
-      return html;
-    }
+		return html;
+	}
 
+	public static String getQueryStringHtml(MenuData menuData) {
+		String html = "";
 
-    public static String getQueryStringHtml(MenuData menuData) {
-      String html = "";
+		if (menuData.getQueryString() != null && menuData.getQueryString().length() > 0) {
+			html = "?" + menuData.getQueryString();
+		}
 
-      if (menuData.getQueryString() != null && menuData.getQueryString().length() > 0) {
-        html = "?" + menuData.getQueryString();
-      }
+		return html;
+	}
 
-      return html;
-    }
-    
-    public DataAccessService getDataAccessService() {
+	public DataAccessService getDataAccessService() {
 		return dataAccessService;
 	}
 
-
 	public void setDataAccessService(DataAccessService dataAccessService) {
 		this.dataAccessService = dataAccessService;
 	}
 
 }
-
-
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/menu/MenuProperties.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/menu/MenuProperties.java
index 18f3f83e..67ea3bf6 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/menu/MenuProperties.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/menu/MenuProperties.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -45,88 +45,82 @@ import javax.servlet.ServletContext;
 
 import org.onap.portalsdk.core.util.SystemProperties;
 
-
 /*
   MenuProperties contains a list of constants used during the creation,
   privilege screening, and rendering of the application menu.
 */
 public class MenuProperties {
-  private MenuProperties() {
-    // cannot instantiate
-  }
-
-  @SuppressWarnings("rawtypes")
-  private static HashMap menuProperties = new HashMap();
-
-  // keys used to reference values in the menu.properties file
-  public static final String WIDTH         	        = "width";
-  public static final String LEFT_POSITION 	        = "left_position";
-  public static final String TOP_POSITION  	        = "top_position";
-  public static final String FONT_COLOR    	        = "font_color";
-  public static final String MOUSEOVER_FONT_COLOR       = "mouseover_font_color";
-  public static final String BACKGROUND_COLOR           = "background_color";
-  public static final String MOUSEOVER_BACKGROUND_COLOR = "mouseover_background_color";
-  public static final String BORDER_COLOR               = "border_color";
-  public static final String SEPARATOR_COLOR            = "separator_color";
-  public static final String IMAGE_SRC                  = "image_src";
-  public static final String IMAGE_SRC_LEFT             = "image_src_left";
-  public static final String IMAGE_SRC_OVER             = "image_src_over";
-  public static final String IMAGE_SRC_LEFT_OVER        = "image_src_left_over";
-  public static final String EVALUATE_UPON_TREE_SHOW    = "evaluate_upon_tree_show";
-  public static final String EVALUATE_UPON_TREE_HIDE    = "evaluate_upon_tree_hide";
-  public static final String TOP_IS_PERMANENT           = "top_is_permanent";
-  public static final String TOP_IS_HORIZONTAL          = "top_is_horizontal";
-  public static final String TREE_IS_HORIZONTAL         = "tree_is_horizontal";
-  public static final String POSITION_UNDER             = "position_under";
-  public static final String TOP_MORE_IMAGES_VISIBLE    = "top_more_images_visible";
-  public static final String TREE_MORE_IMAGES_VISIBLE   = "tree_more_images_visible";
-  public static final String RIGHT_TO_LEFT              = "right_to_left";
-  public static final String DISPLAY_ON_CLICK           = "display_on_click";
-  public static final String TOP_IS_VARIABLE_WIDTH      = "top_is_variable_width";
-  public static final String TREE_IS_VARIABLE_WIDTH     = "tree_is_variable_width";
-  public static final String TOP_KEEP_IN_WINDOW_X       = "top_keep_in_window_x";
-  public static final String TOP_KEEP_IN_WINDOW_Y       = "top_keep_in_window_y";
-  public static final String MENU_ID_ADMIN  	        = "menu_id_admin";
-  public static final String MENU_ID_LOGOUT 	        = "menu_id_logout";
-  public static final String MENU_FRAME 		= "menu_frame";
-  public static final String MAIN_FRAME 		= "main_frame";
-  public static final String NESTED_MAIN_FRAME		= "nested_main_frame";
-  public static final String ROLE_FUNCTIONS_TAG         = "role_functions_tag";
-
-  public static final String MAX_DISPLAYABLE_ADMIN_MENU_SORT_ORDER = "max_displayable_admin_menu_sort_order";
-  public static final String MENU_PROPERTIES_FILENAME_KEY          = "menu_properties_filename";
-  public static final String DEFAULT_SERVLET_NAME                  = "dispatcher";
-  public static final String DEFAULT_TARGET                        = "_self";
-
-  public static final String TOP_MENU_CLASS        = "top_menu_class";
-  public static final String TOP_MENU_LINK_CLASS   = "top_menu_link_class";
-
-  public static final String ON_MOUSE_OUT_TRAILER  = "on_mouse_out_trailer";
-  public static final String ON_MOUSE_OVER_TRAILER = "on_mouse_over_trailer";
-  public static final String ON_CLICK_TRAILER	   = "on_click_trailer";
-
-  public static final String MENU_ID_PREFIX	   = "menu_id_prefix";
-
-
-  @SuppressWarnings("unchecked")
-  public static void loadFromFile(ServletContext servletContext, String filename, String menuSetName) throws IOException {
-    Properties    p = new Properties();
-
-    if (filename == null) {
-      filename = SystemProperties.getProperty(SystemProperties.APPLICATION_MENU_PROPERTIES_NAME);
-    }
-
-    p.load(servletContext.getResourceAsStream(SystemProperties.getProperty(SystemProperties.MENU_PROPERTIES_FILE_LOCATION) + filename));
-    menuProperties.put(menuSetName, p);
-   } // loadMenuProperties
-
-  public static String getProperty(String key) {
-    return getProperty(key, SystemProperties.getProperty(SystemProperties.APPLICATION_MENU_SET_NAME));
-  }
 
-  public static String getProperty(String key, String menuSetName) {
-    Properties p = (Properties)menuProperties.get(menuSetName);
-    return p.getProperty(key);
-  }
+	// keys used to reference values in the menu.properties file
+	public static final String WIDTH = "width";
+	public static final String LEFT_POSITION = "left_position";
+	public static final String TOP_POSITION = "top_position";
+	public static final String FONT_COLOR = "font_color";
+	public static final String MOUSEOVER_FONT_COLOR = "mouseover_font_color";
+	public static final String BACKGROUND_COLOR = "background_color";
+	public static final String MOUSEOVER_BACKGROUND_COLOR = "mouseover_background_color";
+	public static final String BORDER_COLOR = "border_color";
+	public static final String SEPARATOR_COLOR = "separator_color";
+	public static final String IMAGE_SRC = "image_src";
+	public static final String IMAGE_SRC_LEFT = "image_src_left";
+	public static final String IMAGE_SRC_OVER = "image_src_over";
+	public static final String IMAGE_SRC_LEFT_OVER = "image_src_left_over";
+	public static final String EVALUATE_UPON_TREE_SHOW = "evaluate_upon_tree_show";
+	public static final String EVALUATE_UPON_TREE_HIDE = "evaluate_upon_tree_hide";
+	public static final String TOP_IS_PERMANENT = "top_is_permanent";
+	public static final String TOP_IS_HORIZONTAL = "top_is_horizontal";
+	public static final String TREE_IS_HORIZONTAL = "tree_is_horizontal";
+	public static final String POSITION_UNDER = "position_under";
+	public static final String TOP_MORE_IMAGES_VISIBLE = "top_more_images_visible";
+	public static final String TREE_MORE_IMAGES_VISIBLE = "tree_more_images_visible";
+	public static final String RIGHT_TO_LEFT = "right_to_left";
+	public static final String DISPLAY_ON_CLICK = "display_on_click";
+	public static final String TOP_IS_VARIABLE_WIDTH = "top_is_variable_width";
+	public static final String TREE_IS_VARIABLE_WIDTH = "tree_is_variable_width";
+	public static final String TOP_KEEP_IN_WINDOW_X = "top_keep_in_window_x";
+	public static final String TOP_KEEP_IN_WINDOW_Y = "top_keep_in_window_y";
+	public static final String MENU_ID_ADMIN = "menu_id_admin";
+	public static final String MENU_ID_LOGOUT = "menu_id_logout";
+	public static final String MENU_FRAME = "menu_frame";
+	public static final String MAIN_FRAME = "main_frame";
+	public static final String NESTED_MAIN_FRAME = "nested_main_frame";
+	public static final String ROLE_FUNCTIONS_TAG = "role_functions_tag";
+	public static final String MAX_DISPLAYABLE_ADMIN_MENU_SORT_ORDER = "max_displayable_admin_menu_sort_order";
+	public static final String MENU_PROPERTIES_FILENAME_KEY = "menu_properties_filename";
+	public static final String DEFAULT_SERVLET_NAME = "dispatcher";
+	public static final String DEFAULT_TARGET = "_self";
+	public static final String TOP_MENU_CLASS = "top_menu_class";
+	public static final String TOP_MENU_LINK_CLASS = "top_menu_link_class";
+	public static final String ON_MOUSE_OUT_TRAILER = "on_mouse_out_trailer";
+	public static final String ON_MOUSE_OVER_TRAILER = "on_mouse_over_trailer";
+	public static final String ON_CLICK_TRAILER = "on_click_trailer";
+	public static final String MENU_ID_PREFIX = "menu_id_prefix";
+
+	@SuppressWarnings("rawtypes")
+	private static HashMap menuProperties = new HashMap();
+
+	private MenuProperties() {
+		// cannot instantiate
+	}
+
+	@SuppressWarnings("unchecked")
+	public static void loadFromFile(ServletContext servletContext, String filename, String menuSetName)
+			throws IOException {
+		if (filename == null) 
+			filename = SystemProperties.getProperty(SystemProperties.APPLICATION_MENU_PROPERTIES_NAME);
+		Properties p = new Properties();
+		p.load(servletContext.getResourceAsStream(
+				SystemProperties.getProperty(SystemProperties.MENU_PROPERTIES_FILE_LOCATION) + filename));
+		menuProperties.put(menuSetName, p);
+	}
+
+	public static String getProperty(String key) {
+		return getProperty(key, SystemProperties.getProperty(SystemProperties.APPLICATION_MENU_SET_NAME));
+	}
+
+	public static String getProperty(String key, String menuSetName) {
+		Properties p = (Properties) menuProperties.get(menuSetName);
+		return p.getProperty(key);
+	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/objectcache/AbstractCacheManager.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/objectcache/AbstractCacheManager.java
index 8bbf34cd..16b763a1 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/objectcache/AbstractCacheManager.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/objectcache/AbstractCacheManager.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,42 +37,40 @@
  */
 package org.onap.portalsdk.core.objectcache;
 
-import java.io.*;
-
-import org.onap.portalsdk.core.objectcache.support.*;
+import java.io.IOException;
 
+import org.onap.portalsdk.core.objectcache.support.FusionCacheManager;
 
 public abstract class AbstractCacheManager implements FusionCacheManager {
-  public AbstractCacheManager() {
-    super();
-    // TODO Auto-generated constructor stub
-  }
 
-  public Object getObject(String key) {
-    // TODO Auto-generated method stub
-    return null;
-  }
+	public AbstractCacheManager() {
+		super();
+	}
 
-  public void putObject(String key, Object objectToCache) {
-    // TODO Auto-generated method stub
-  }
+	@Override
+	public Object getObject(String key) {
+		return null;
+	}
 
-  public boolean isObjectInCache(String key) {
-    // TODO Auto-generated method stub
-    return false;
-  }
+	@Override
+	public void putObject(String key, Object objectToCache) {
+	}
 
-  public void removeObject(String key) {
-    // TODO Auto-generated method stub
-  }
+	@Override
+	public boolean isObjectInCache(String key) {
+		return false;
+	}
 
-  public void clearCache() {
-    // TODO Auto-generated method stub
-  }
+	@Override
+	public void removeObject(String key) {
+	}
 
-  public void configure() throws IOException {
-    // TODO Auto-generated method stub
+	@Override
+	public void clearCache() {
+	}
 
-  }
-}
+	@Override
+	public void configure() throws IOException {
+	}
 
+}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/objectcache/jcs/JCSCacheEventHandler.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/objectcache/jcs/JCSCacheEventHandler.java
index 8660d9f9..71357f34 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/objectcache/jcs/JCSCacheEventHandler.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/objectcache/jcs/JCSCacheEventHandler.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -43,36 +43,46 @@ import org.apache.jcs.engine.control.event.behavior.IElementEventHandler;
 import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
 
 public class JCSCacheEventHandler implements IElementEventHandler, IElementEventConstants {
-	
-  private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(JCSCacheEventHandler.class);
-	
-  public JCSCacheEventHandler() {
-    super();
-  }
 
-  public void handleElementEvent(IElementEvent event) {
-    // Handle code for various event notifications on cached elements by JCS.
-    switch (event.getElementEvent()) {
-    case ELEMENT_EVENT_EXCEEDED_MAXLIFE_BACKGROUND:
-      logger.error(EELFLoggerDelegate.errorLogger, "Event ELEMENT_EVENT_EXCEEDED_MAXLIFE_BACKGROUND occurred for element " + event);
-      break;
-    case ELEMENT_EVENT_EXCEEDED_MAXLIFE_ONREQUEST:
-      logger.error(EELFLoggerDelegate.errorLogger, "Event ELEMENT_EVENT_EXCEEDED_MAXLIFE_ONREQUEST occurred for element " + event);
-      break;
-    case ELEMENT_EVENT_EXCEEDED_IDLETIME_BACKGROUND:
-      logger.error(EELFLoggerDelegate.errorLogger, "Event ELEMENT_EVENT_EXCEEDED_IDLETIME_BACKGROUND occurred for element " + event);
-      break;
-    case ELEMENT_EVENT_EXCEEDED_IDLETIME_ONREQUEST:
-      logger.error(EELFLoggerDelegate.errorLogger, "Event ELEMENT_EVENT_EXCEEDED_IDLETIME_ONREQUEST occurred for element " + event);
-      break;
-    case ELEMENT_EVENT_SPOOLED_DISK_AVAILABLE:
-      logger.error(EELFLoggerDelegate.errorLogger, "Event ELEMENT_EVENT_SPOOLED_DISK_AVAILABLE occurred for element " + event);
-      break;
-    case ELEMENT_EVENT_SPOOLED_DISK_NOT_AVAILABLE:
-      logger.error(EELFLoggerDelegate.errorLogger, "Event ELEMENT_EVENT_SPOOLED_DISK_NOT_AVAILABLE occurred for element " + event);
-      break;
-    case ELEMENT_EVENT_SPOOLED_NOT_ALLOWED:
-      logger.error(EELFLoggerDelegate.errorLogger, "Event ELEMENT_EVENT_SPOOLED_NOT_ALLOWED occurred for element " + event);
-    }
-  }
+	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(JCSCacheEventHandler.class);
+
+	public JCSCacheEventHandler() {
+		super();
+	}
+
+	@Override
+	public void handleElementEvent(IElementEvent event) {
+		// Handle code for various event notifications on cached elements by JCS.
+		switch (event.getElementEvent()) {
+		case ELEMENT_EVENT_EXCEEDED_MAXLIFE_BACKGROUND:
+			logger.error(EELFLoggerDelegate.errorLogger,
+					"Event ELEMENT_EVENT_EXCEEDED_MAXLIFE_BACKGROUND occurred for element " + event);
+			break;
+		case ELEMENT_EVENT_EXCEEDED_MAXLIFE_ONREQUEST:
+			logger.error(EELFLoggerDelegate.errorLogger,
+					"Event ELEMENT_EVENT_EXCEEDED_MAXLIFE_ONREQUEST occurred for element " + event);
+			break;
+		case ELEMENT_EVENT_EXCEEDED_IDLETIME_BACKGROUND:
+			logger.error(EELFLoggerDelegate.errorLogger,
+					"Event ELEMENT_EVENT_EXCEEDED_IDLETIME_BACKGROUND occurred for element " + event);
+			break;
+		case ELEMENT_EVENT_EXCEEDED_IDLETIME_ONREQUEST:
+			logger.error(EELFLoggerDelegate.errorLogger,
+					"Event ELEMENT_EVENT_EXCEEDED_IDLETIME_ONREQUEST occurred for element " + event);
+			break;
+		case ELEMENT_EVENT_SPOOLED_DISK_AVAILABLE:
+			logger.error(EELFLoggerDelegate.errorLogger,
+					"Event ELEMENT_EVENT_SPOOLED_DISK_AVAILABLE occurred for element " + event);
+			break;
+		case ELEMENT_EVENT_SPOOLED_DISK_NOT_AVAILABLE:
+			logger.error(EELFLoggerDelegate.errorLogger,
+					"Event ELEMENT_EVENT_SPOOLED_DISK_NOT_AVAILABLE occurred for element " + event);
+			break;
+		case ELEMENT_EVENT_SPOOLED_NOT_ALLOWED:
+			logger.error(EELFLoggerDelegate.errorLogger,
+					"Event ELEMENT_EVENT_SPOOLED_NOT_ALLOWED occurred for element " + event);
+		default:
+			logger.error(EELFLoggerDelegate.errorLogger, "handleElementEvent: unknown event " + event);
+		}
+	}
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/objectcache/jcs/JCSCacheManager.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/objectcache/jcs/JCSCacheManager.java
index f169754f..2fa5e856 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/objectcache/jcs/JCSCacheManager.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/objectcache/jcs/JCSCacheManager.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -39,8 +39,9 @@ package org.onap.portalsdk.core.objectcache.jcs;
 
 import java.io.IOException;
 import java.io.InputStream;
+import java.util.ArrayList;
+import java.util.List;
 import java.util.Properties;
-import java.util.Vector;
 
 import javax.annotation.PostConstruct;
 import javax.servlet.ServletContext;
@@ -60,19 +61,19 @@ public abstract class JCSCacheManager extends AbstractCacheManager implements Ca
 
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(JCSCacheManager.class);
 
-	public static String LOOKUP_OBJECT_CACHE_NAME = "lookUpObjectCache";
-	public static String JCS_CONFIG_FILE_PATH = "cache_config_file_path";
-	public static String CACHE_LOAD_ON_STARTUP = "cache_load_on_startup";
-	public static String CACHE_PROPERTY_VALUE_TRUE = "true";
-	public static String CACHE_CONTROL_SWITCH_ON = "1";
-	public static String CACHE_CONTROL_SWITCH_OFF = "0";
-	public static String CACHE_CONTROL_SWITCH = "cache_switch";
+	public static final String LOOKUP_OBJECT_CACHE_NAME = "lookUpObjectCache";
+	public static final String JCS_CONFIG_FILE_PATH = "cache_config_file_path";
+	public static final String CACHE_LOAD_ON_STARTUP = "cache_load_on_startup";
+	public static final String CACHE_PROPERTY_VALUE_TRUE = "true";
+	public static final String CACHE_CONTROL_SWITCH_ON = "1";
+	public static final String CACHE_CONTROL_SWITCH_OFF = "0";
+	public static final String CACHE_CONTROL_SWITCH = "cache_switch";
 
-	private static JCS lookUpCache;
+	private JCS lookUpCache;
 	private ServletContext servletContext;
 
 	private Properties cacheConfigProperties = null;
-	private final Vector jscManagedCacheList = new Vector();
+	private final ArrayList jscManagedCacheList = new ArrayList<>();
 
 	private DataAccessService dataAccessService;
 
@@ -81,6 +82,7 @@ public abstract class JCSCacheManager extends AbstractCacheManager implements Ca
 		jscManagedCacheList.add(LOOKUP_OBJECT_CACHE_NAME);
 	}
 
+	@Override
 	@PostConstruct
 	public void configure() throws IOException {
 		super.configure();
@@ -93,8 +95,8 @@ public abstract class JCSCacheManager extends AbstractCacheManager implements Ca
 		if (jcsConfigInputStream == null)
 			throw new IOException("configure: failed to open stream for config property " + JCS_CONFIG_FILE_PATH
 					+ " with name " + jcsConfigFilePath);
-		logger.debug(EELFLoggerDelegate.debugLogger,
-				"configure: loading cache properties from classpath resource {} ", jcsConfigFilePath);
+		logger.debug(EELFLoggerDelegate.debugLogger, "configure: loading cache properties from classpath resource {} ",
+				jcsConfigFilePath);
 		Properties p = new Properties();
 		p.load(jcsConfigInputStream);
 		jcsConfigInputStream.close();
@@ -126,6 +128,7 @@ public abstract class JCSCacheManager extends AbstractCacheManager implements Ca
 		}
 	}
 
+	@Override
 	public Object getObject(String key) {
 		if (CACHE_CONTROL_SWITCH_ON.equalsIgnoreCase(SystemProperties.getProperty(CACHE_CONTROL_SWITCH))) {
 			if (lookUpCache == null)
@@ -136,12 +139,12 @@ public abstract class JCSCacheManager extends AbstractCacheManager implements Ca
 			return null;
 	}
 
+	@Override
 	public void putObject(String key, Object objectToCache) {
 		try {
-			if (CACHE_CONTROL_SWITCH_ON.equalsIgnoreCase(SystemProperties.getProperty(CACHE_CONTROL_SWITCH))) {
-				if (lookUpCache != null) {
-					lookUpCache.put(key, objectToCache);
-				}
+			if (CACHE_CONTROL_SWITCH_ON.equalsIgnoreCase(SystemProperties.getProperty(CACHE_CONTROL_SWITCH))
+					&& lookUpCache != null) {
+				lookUpCache.put(key, objectToCache);
 			}
 		} catch (CacheException ce) {
 			logger.error(EELFLoggerDelegate.errorLogger, "putObject: failed to put the object with key " + key, ce);
@@ -158,6 +161,7 @@ public abstract class JCSCacheManager extends AbstractCacheManager implements Ca
 		}
 	}
 
+	@Override
 	public void clearCache() {
 		clearCache(LOOKUP_OBJECT_CACHE_NAME);
 	}
@@ -181,7 +185,7 @@ public abstract class JCSCacheManager extends AbstractCacheManager implements Ca
 		this.cacheConfigProperties = cacheConfigProperties;
 	}
 
-	public Vector getJscManagedCacheList() {
+	public List getJscManagedCacheList() {
 		return jscManagedCacheList;
 	}
 
@@ -197,6 +201,7 @@ public abstract class JCSCacheManager extends AbstractCacheManager implements Ca
 		return servletContext;
 	}
 
+	@Override
 	public void setServletContext(ServletContext servletContext) {
 		this.servletContext = servletContext;
 	}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/objectcache/support/FusionCacheManager.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/objectcache/support/FusionCacheManager.java
index e2a8ca14..af8b24b7 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/objectcache/support/FusionCacheManager.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/objectcache/support/FusionCacheManager.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,18 +37,21 @@
  */
 package org.onap.portalsdk.core.objectcache.support;
 
-import java.io.*;
+import java.io.IOException;
 
 import org.onap.portalsdk.core.FusionObject;
 
 public interface FusionCacheManager extends FusionObject {
 
-  Object  getObject(String key);
-  void    putObject(String key, Object objectToCache);
-  boolean isObjectInCache(String key);
+	Object getObject(String key);
 
-  void removeObject(String key);
-  void clearCache();
-  void configure() throws IOException;
-}
+	void putObject(String key, Object objectToCache);
+
+	boolean isObjectInCache(String key);
+
+	void removeObject(String key);
 
+	void clearCache();
+
+	void configure() throws IOException;
+}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/client/AppContextManager.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/client/AppContextManager.java
index a446c435..02452506 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/client/AppContextManager.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/client/AppContextManager.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -42,22 +42,21 @@ import org.springframework.context.ApplicationContextAware;
 import org.springframework.stereotype.Component;
 
 /**
- * 
- *
- * Use this class to get access to ApplicationContext for classes who were not created by Spring. 	
+ * Use this class to get access to ApplicationContext for classes that were not
+ * created by Spring.
  */
 
-
 @Component
-public class AppContextManager implements ApplicationContextAware{
-    private static ApplicationContext _appCtx;
+public class AppContextManager implements ApplicationContextAware {
+	
+	private static ApplicationContext appContext;
 
-    @Override
-    public void setApplicationContext(ApplicationContext ctx){
-         _appCtx = ctx;
-    }
+	@Override
+	public void setApplicationContext(final ApplicationContext ctx) {
+		this.appContext = ctx;
+	}
 
-    public static ApplicationContext getAppContext(){
-        return _appCtx;
-    } 
+	public static ApplicationContext getAppContext() {
+		return appContext;
+	}
 }
\ No newline at end of file
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/session/TestClass.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/session/TestClass.java
deleted file mode 100644
index ff21d641..00000000
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/session/TestClass.java
+++ /dev/null
@@ -1,42 +0,0 @@
-/*
- * ============LICENSE_START==========================================
- * ONAP Portal SDK
- * ===================================================================
- * Copyright © 2017 AT&T Intellectual Property. All rights reserved.
- * ===================================================================
- *
- * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
- * you may not use this software except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *             http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
- * you may not use this documentation except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *             https://creativecommons.org/licenses/by/4.0/
- *
- * Unless required by applicable law or agreed to in writing, documentation
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- * ============LICENSE_END============================================
- *
- * ECOMP is a trademark and service mark of AT&T Intellectual Property.
- */
-package org.onap.portalsdk.core.onboarding.session;
-
-public class TestClass {
-
-}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/sso/TestClass.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/sso/TestClass.java
deleted file mode 100644
index 0bf193eb..00000000
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/sso/TestClass.java
+++ /dev/null
@@ -1,42 +0,0 @@
-/*
- * ============LICENSE_START==========================================
- * ONAP Portal SDK
- * ===================================================================
- * Copyright © 2017 AT&T Intellectual Property. All rights reserved.
- * ===================================================================
- *
- * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
- * you may not use this software except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *             http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
- * you may not use this documentation except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *             https://creativecommons.org/licenses/by/4.0/
- *
- * Unless required by applicable law or agreed to in writing, documentation
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- * ============LICENSE_END============================================
- *
- * ECOMP is a trademark and service mark of AT&T Intellectual Property.
- */
-package org.onap.portalsdk.core.onboarding.sso;
-
-public class TestClass {
-
-}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/Consumer.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/Consumer.java
index 6f76d1aa..be8e71f8 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/Consumer.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/Consumer.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -39,9 +39,9 @@ package org.onap.portalsdk.core.onboarding.ueb;
 
 import java.io.IOException;
 import java.security.GeneralSecurityException;
-import java.util.LinkedList;
+import java.util.List;
+import java.util.Queue;
 import java.util.UUID;
-import java.util.concurrent.ConcurrentLinkedQueue;
 
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
@@ -60,14 +60,17 @@ public class Consumer implements Runnable {
 
 	private final Log logger = LogFactory.getLog(getClass());
 
-	private final LinkedList urlList = Helper.uebUrlList();
-	private final ConcurrentLinkedQueue queue;
+	private final List urlList = Helper.uebUrlList();
+	private final Queue queue;
 	private final WaitingRequestersQueueList waitingRequestersList;
-	private final String consumerKey, consumerSecret, topicName, consumerGroupName;
+	private final String consumerKey;
+	private final String consumerSecret;
+	private final String topicName;
+	private final String consumerGroupName;
 
 	/**
-	 * Accepts coordinates needed to subscribe to a UEB topic, as well as the
-	 * queues for passing along messages that arrive.
+	 * Accepts coordinates needed to subscribe to a UEB topic, as well as the queues
+	 * for passing along messages that arrive.
 	 * 
 	 * @param consumerKey
 	 *            UEB key used to subscribe to the topic
@@ -75,16 +78,18 @@ public class Consumer implements Runnable {
 	 *            UEB secret used to subscribe to the topic
 	 * @param topicName
 	 *            UEB topic name
+	 * @param consumerGroupName
+	 *            consumer group name
 	 * @param queue
-	 *            Queue to receive UEB messages. All inbound messages are
-	 *            enqueued here; ignored if null.
+	 *            Queue to receive UEB messages. All inbound messages are enqueued
+	 *            here; ignored if null.
 	 * @param waitingRequestersList
 	 *            Collection of queues to receive UEB messages that arrive in
-	 *            response to requests; i.e., emulating a synchronous request
-	 *            via pub/sub.
+	 *            response to requests; i.e., emulating a synchronous request via
+	 *            pub/sub.
 	 */
 	public Consumer(String consumerKey, String consumerSecret, String topicName, String consumerGroupName,
-			ConcurrentLinkedQueue queue, WaitingRequestersQueueList waitingRequestersList) {
+			Queue queue, WaitingRequestersQueueList waitingRequestersList) {
 		this.consumerKey = consumerKey;
 		this.consumerSecret = consumerSecret;
 		this.topicName = topicName;
@@ -98,28 +103,21 @@ public class Consumer implements Runnable {
 	 * Distributes messages appropriately as they arrive:
 	 * 
    
 	 * 
  • If the queue is not null, adds the message to the queue.
-	 * 
  • If the message's getMsgId() method returns non-null and the ID is
-	 * found in the collection of waiting requesters, adds the message in that
-	 * requester's queue.
+	 * 
  • If the message's getMsgId() method returns non-null and the ID is found
+	 * in the collection of waiting requesters, adds the message in that requester's
+	 * queue.
 	 * 

 	 * 
-	 * This is intended to be called in a long running thread as a listener for
-	 * any published messages on a topic. Typical async pub/sub model. We use a
-	 * filter of "0" to prevent collisions with P2P messages with unique filter
-	 * ids.
+	 * This is intended to be called in a long running thread as a listener for any
+	 * published messages on a topic. Typical async pub/sub model. We use a filter
+	 * of "0" to prevent collisions with P2P messages with unique filter ids.
 	 */
 	protected void consume() throws IOException, UebException, GeneralSecurityException {
 		final String id = UUID.randomUUID().toString();
 
-		CambriaConsumer cc = null;
-		cc = new CambriaClientBuilders.ConsumerBuilder()
-				.usingHosts(urlList)
-				.authenticatedBy(consumerKey, consumerSecret)
-				.onTopic (topicName)
-				.knownAs (consumerGroupName,id)
-				.waitAtServer (15*1000)
-				.receivingAtMost (1000)
-				.build();
+		CambriaConsumer cc = new CambriaClientBuilders.ConsumerBuilder().usingHosts(urlList)
+				.authenticatedBy(consumerKey, consumerSecret).onTopic(topicName).knownAs(consumerGroupName, id)
+				.waitAtServer(15 * 1000).receivingAtMost(1000).build();
 
 		while (true) {
 			for (String msg : cc.fetch()) {
@@ -133,17 +131,16 @@ public class Consumer implements Runnable {
 					// listener queue.
 					queue.add(uebMsg);
 					if (logger.isDebugEnabled())
-						logger.debug("Added msg to queue " + this.queue + " queue count = " + queue.size() + " msg :"
-								+ uebMsg.getPayload());
+						logger.debug("Added msg to queue " + this.queue + " msg :" + uebMsg.getPayload());
 				}
-				if (waitingRequestersList != null && uebMsg.getMsgId() != null) {
+				if (waitingRequestersList != null //
+						&& uebMsg.getMsgId() != null //
+						&& !(uebMsg.getMsgId()
+								.equals(PortalApiProperties.getProperty(PortalApiConstants.ECOMP_DEFAULT_MSG_ID)))) {
 					// If a msgId is present, this could be a synchronous
 					// reply. Here we add it to the waiting requester's
 					// queue if we find a requester waiting for this msgId.
-					if (!(uebMsg.getMsgId()
-							.equals(PortalApiProperties.getProperty(PortalApiConstants.ECOMP_DEFAULT_MSG_ID)))) {
-						waitingRequestersList.addMsg(uebMsg.getMsgId(), uebMsg);
-					}
+					waitingRequestersList.addMsg(uebMsg.getMsgId(), uebMsg);
 				}
 			}
 			if (Thread.interrupted()) {
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/FunctionalMenu.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/FunctionalMenu.java
index 29a3b567..6f9ffd4a 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/FunctionalMenu.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/FunctionalMenu.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -61,18 +61,17 @@ public class FunctionalMenu {
 	public static String get(String userId) throws UebException {
 		String returnString = null;
 		logger.info("Making use of UEB communication and Requesting functional menu for user " + userId);
-		UebMsg funcMenuUebMsg = null;
 		UebMsg msg = new UebMsg();
 		msg.putMsgType(UebMsgTypes.UEB_MSG_TYPE_GET_FUNC_MENU);
 		msg.putUserId(userId);
-		funcMenuUebMsg = UebManager.getInstance().requestReply(msg);
+		UebMsg funcMenuUebMsg = UebManager.getInstance().requestReply(msg);
 		if (funcMenuUebMsg != null) {
 			if (funcMenuUebMsg.getPayload().startsWith("Error:")) {
 				logger.error("getFunctionalMenu received an error in UEB msg = " + funcMenuUebMsg.getPayload());
 			} else {
 				returnString = funcMenuUebMsg.getPayload();
 			}
-		}		
+		}
 		return returnString;
 	}
 
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/Helper.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/Helper.java
index 02f64bd4..be1a686b 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/Helper.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/Helper.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -38,6 +38,7 @@
 package org.onap.portalsdk.core.onboarding.ueb;
 
 import java.util.LinkedList;
+import java.util.List;
 
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
@@ -45,7 +46,7 @@ import org.onap.portalsdk.core.onboarding.util.PortalApiConstants;
 import org.onap.portalsdk.core.onboarding.util.PortalApiProperties;
 
 /**
- * Provides utility methods. 
+ * Provides utility methods.
  */
 public class Helper {
 
@@ -57,17 +58,16 @@ public class Helper {
 	 * 
 	 * @return List of UEB server names
 	 */
-	public static LinkedList uebUrlList() {
-		LinkedList urlList = null;
-			String url = PortalApiProperties.getProperty(PortalApiConstants.UEB_URL_LIST);
-			if (url == null) {
-				logger.error("uebUrlList: failed to get property " + PortalApiConstants.UEB_URL_LIST);
-				return null;
-			}
-			urlList = new LinkedList();
-			for (String u : url.split(",")) {
-				urlList.add(u.trim());
-			}
+	public static List uebUrlList() {
+		String url = PortalApiProperties.getProperty(PortalApiConstants.UEB_URL_LIST);
+		if (url == null) {
+			logger.error("uebUrlList: failed to get property " + PortalApiConstants.UEB_URL_LIST);
+			return new LinkedList();
+		}
+		LinkedList 		urlList = new LinkedList<>();
+		for (String u : url.split(",")) {
+			urlList.add(u.trim());
+		}
 		return urlList;
 	}
 
@@ -75,7 +75,7 @@ public class Helper {
 		try {
 			Thread.sleep(milliseconds);
 		} catch (InterruptedException e) {
-			e.printStackTrace();
+			logger.warn("sleep was interrupted", e);
 		}
 	}
 
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/Publisher.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/Publisher.java
index 9536fee8..b73b0110 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/Publisher.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/Publisher.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -40,7 +40,7 @@ package org.onap.portalsdk.core.onboarding.ueb;
 import java.io.IOException;
 import java.net.MalformedURLException;
 import java.security.GeneralSecurityException;
-import java.util.LinkedList;
+import java.util.List;
 import java.util.concurrent.TimeUnit;
 
 import org.apache.commons.logging.Log;
@@ -56,13 +56,13 @@ import com.fasterxml.jackson.databind.ObjectWriter;
 /**
  * Provides a publisher that sends messages to a UEB topic.
  * 
- * Utilizes AT&T's UEB/Cambria subscriber/publisher messaging service. 
+ * Utilizes AT&T's UEB/Cambria subscriber/publisher messaging service.
  */
 public class Publisher {
 
 	private final Log logger = LogFactory.getLog(getClass());
 
-	protected final LinkedList urlList = Helper.uebUrlList();
+	protected final List urlList = Helper.uebUrlList();
 
 	private final String topicName;
 	private final String publisherKey;
@@ -86,11 +86,11 @@ public class Publisher {
 	}
 
 	/**
-	 * Creates a publisher, subscribes to the topic, sends the specified message
-	 * to the topic, then closes the publisher. This ensures that the single
-	 * message goes immediately. UEB is designed for high throughput and tries
-	 * to batch up multiple messages in each send, but this method wants the
-	 * single message to go immediately.
+	 * Creates a publisher, subscribes to the topic, sends the specified message to
+	 * the topic, then closes the publisher. This ensures that the single message
+	 * goes immediately. UEB is designed for high throughput and tries to batch up
+	 * multiple messages in each send, but this method wants the single message to
+	 * go immediately.
 	 * 
 	 * @param uebMsg
 	 *            Message object to send as the payload.
@@ -103,12 +103,9 @@ public class Publisher {
 
 		CambriaBatchingPublisher pub;
 		try {
-			pub = new CambriaClientBuilders.PublisherBuilder()
-					.authenticatedBy(publisherKey, publisherSecret).usingHosts(urlList).onTopic(topicName).build();
-		} catch (MalformedURLException e1) {
-			logger.error("pub.build Exception ", e1);
-			throw new UebException(PortalApiConstants.ECOMP_UEB_UNKNOWN_PUBLISH_ERROR, e1, topicName, null, msg);
-		} catch (GeneralSecurityException e1) {
+			pub = new CambriaClientBuilders.PublisherBuilder().authenticatedBy(publisherKey, publisherSecret)
+					.usingHosts(urlList).onTopic(topicName).build();
+		} catch (MalformedURLException | GeneralSecurityException e1) {
 			logger.error("pub.build Exception ", e1);
 			throw new UebException(PortalApiConstants.ECOMP_UEB_UNKNOWN_PUBLISH_ERROR, e1, topicName, null, msg);
 		}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/PublisherList.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/PublisherList.java
index 0556e045..d7dbb323 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/PublisherList.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/PublisherList.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -56,17 +56,16 @@ public class PublisherList {
 	private final Log logger = LogFactory.getLog(getClass());
 
 	private final Map map;
-	
+
 	public PublisherList() {
-		 map = new ConcurrentHashMap<>();
+		map = new ConcurrentHashMap<>();
 	}
-	
+
 	public void addPublisherToMap(String topicName, Publisher publisher) {
-		if (this.map.containsKey(topicName)) {
+		if (this.map.containsKey(topicName))
 			logger.error("Publisher already exists for " + topicName);
-		} else {
+		else
 			this.map.put(topicName, publisher);
-		}
 	}
 
 	public Publisher getPublisher(String topicName) {
@@ -77,14 +76,13 @@ public class PublisherList {
 		this.map.remove(topicName);
 	}
 
+	@Override
 	public String toString() {
-		StringBuffer sb = new StringBuffer();
+		StringBuilder sb = new StringBuilder();
 		sb.append("Map contains " + this.map.size() + " Publishers.");
-		for (Map.Entry entry : this.map.entrySet()) {
-			String key = entry.getKey().toString();
-			Publisher pub = entry.getValue();
-			sb.append("Entry msgId, " + key + " publisher" + pub);
-		}
+		for (Map.Entry entry : this.map.entrySet())
+			sb.append("Entry msgId, " + entry.getKey() + " publisher" + entry.getValue());
+
 		return sb.toString();
 	}
 
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/TopicManager.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/TopicManager.java
index a19e2de6..36f259e8 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/TopicManager.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/TopicManager.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -39,7 +39,7 @@ package org.onap.portalsdk.core.onboarding.ueb;
 
 import java.io.IOException;
 import java.security.GeneralSecurityException;
-import java.util.LinkedList;
+import java.util.List;
 
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
@@ -55,7 +55,7 @@ import com.att.nsa.cambria.client.CambriaTopicManager;
  * Provides methods to facilitate creating topics, and adding publishers and
  * subscribers to existing topics.
  * 
- * Utilizes UEB/Cambria subscriber/publisher messaging service. 
+ * Utilizes UEB/Cambria subscriber/publisher messaging service.
  */
 public class TopicManager {
 
@@ -78,25 +78,24 @@ public class TopicManager {
 	 */
 	public void createTopic(String key, String secret, String topicName, String topicDescription)
 			throws HttpException, CambriaApiException, IOException {
-		final LinkedList urlList = Helper.uebUrlList();
+		final List urlList = Helper.uebUrlList();
 		if (logger.isInfoEnabled()) {
 			logger.info("==> createTopic");
 			logger.info("topicName: " + topicName);
 			logger.info("topicDescription: " + topicDescription);
 		}
-		CambriaTopicManager tm =null;
+		CambriaTopicManager tm = null;
 		try {
 			tm = CambriaClientFactory.createTopicManager(null, urlList, key, secret);
 		} catch (GeneralSecurityException e) {
-			logger.error("pub.build Exception ", e);			
+			logger.error("pub.build Exception ", e);
 			throw new CambriaApiException(topicName);
 		}
 		tm.createTopic(topicName, topicDescription, 1, 1);
 	}
 
 	/**
-	 * Modifies the specified topic to accept a subscriber using the specified
-	 * key.
+	 * Modifies the specified topic to accept a subscriber using the specified key.
 	 * 
 	 * @param topicOwnerKey
 	 * @param topicOwnerSecret
@@ -109,10 +108,11 @@ public class TopicManager {
 	public void addSubscriber(String topicOwnerKey, String topicOwnerSecret, String subscriberKey, String topicName)
 			throws HttpException, CambriaApiException, IOException {
 		logger.info("==> addSubscriber to topic " + topicName);
-		final LinkedList urlList = Helper.uebUrlList();
+		final List urlList = Helper.uebUrlList();
 		CambriaTopicManager tm = null;
 		try {
-			tm = new CambriaClientBuilders.TopicManagerBuilder().usingHosts(urlList).authenticatedBy(topicOwnerKey, topicOwnerSecret).build();
+			tm = new CambriaClientBuilders.TopicManagerBuilder().usingHosts(urlList)
+					.authenticatedBy(topicOwnerKey, topicOwnerSecret).build();
 			tm.allowConsumer(topicName, subscriberKey);
 		} catch (Exception e) {
 			// TODO Auto-generated catch block
@@ -121,8 +121,7 @@ public class TopicManager {
 	}
 
 	/**
-	 * Modifies the specified topic to accept a publisher using the specified
-	 * key.
+	 * Modifies the specified topic to accept a publisher using the specified key.
 	 * 
 	 * @param topicOwnerKey
 	 * @param topicOwnerSecret
@@ -137,13 +136,13 @@ public class TopicManager {
 	public void addPublisher(String topicOwnerKey, String topicOwnerSecret, String publisherKey, String topicName)
 			throws HttpException, CambriaApiException, IOException {
 		logger.info("==> addPublisher to topic " + topicName);
-		final LinkedList urlList = Helper.uebUrlList();
-		CambriaTopicManager tm =null;
+		final List urlList = Helper.uebUrlList();
+		CambriaTopicManager tm = null;
 		try {
 			tm = CambriaClientFactory.createTopicManager(HttpClient.ConnectionType.HTTPS, urlList, topicOwnerKey,
 					topicOwnerSecret);
 		} catch (GeneralSecurityException e) {
-			logger.error("pub.build Exception ", e);			
+			logger.error("pub.build Exception ", e);
 			throw new CambriaApiException(topicName);
 		}
 		tm.allowProducer(topicName, publisherKey);
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/UebException.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/UebException.java
index 462345ee..61d67295 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/UebException.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/UebException.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -43,15 +43,20 @@ package org.onap.portalsdk.core.onboarding.ueb;
 public class UebException extends Exception {
 
 	private static final long serialVersionUID = 1L;
-	private String topicName = null;
-	private String msgId = null;
-	private String msg = null;
+	private final String topicName;
+	private final String msgId;
+	private final String msg;
+
+	public UebException(Throwable ex) {
+		this(null, ex);
+	}
+
+	public UebException(String msg, Throwable ex) {
+		this(null, ex, null, null, msg);
+	}
 
 	public UebException(String errorMsg, String topicName, String msgId, String msg) {
-		super(errorMsg);
-		this.topicName = topicName;
-		this.msgId = msgId;
-		this.msg = msg;
+		this(errorMsg, null, topicName, msgId, msg);
 	}
 
 	public UebException(String errorMsg, Throwable ex, String topicName, String msgId, String msg) {
@@ -61,14 +66,6 @@ public class UebException extends Exception {
 		this.msg = msg;
 	}
 
-	public UebException(String msg, Throwable ex) {
-		super(msg, ex);
-	}
-	
-	public UebException(Throwable ex) {
-		super(ex);
-	}
-
 	public String getUebMsg() {
 		return this.msg;
 	}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/UebManager.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/UebManager.java
index 1608add1..235746e5 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/UebManager.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/UebManager.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -39,8 +39,8 @@ package org.onap.portalsdk.core.onboarding.ueb;
 
 import java.io.IOException;
 import java.util.List;
+import java.util.Queue;
 import java.util.UUID;
-import java.util.concurrent.ConcurrentLinkedQueue;
 import java.util.concurrent.LinkedBlockingQueue;
 
 import org.apache.commons.logging.Log;
@@ -68,11 +68,9 @@ public class UebManager {
 
 	private Publisher appPublisher;
 	private Thread listenerThread;
-	private boolean bThisIsEcompPortalServer = false;
 
 	/**
-	 * Constructor initializes fields and validates values obtained from
-	 * properties.
+	 * Constructor initializes fields and validates values obtained from properties.
 	 * 
 	 * The picture below is a simplified view of the relationships among ECOMP
 	 * Portal and applications communicating via UEB:
@@ -115,11 +113,12 @@ public class UebManager {
 		if (appUebSecret == null || appUebSecret.length() == 0)
 			throw new UebException("Failed to get property " + PortalApiConstants.UEB_APP_SECRET, null, null, null);
 		List uebUrlList = Helper.uebUrlList();
-		if (uebUrlList == null || uebUrlList.size() == 0)
+		if (uebUrlList == null || uebUrlList.isEmpty())
 			throw new UebException("Failed to get property" + PortalApiConstants.UEB_URL_LIST, null, null, null);
 		// A bit of magic: if consumer group is a magic token, generate one.
-		consumerGroupName = (PortalApiConstants.UEB_APP_CONSUMER_GROUP_NAME_GENERATOR.equals(consGrp)
-				? UUID.randomUUID().toString() : consGrp);
+		consumerGroupName = PortalApiConstants.UEB_APP_CONSUMER_GROUP_NAME_GENERATOR.equals(consGrp)
+				? UUID.randomUUID().toString()
+				: consGrp;
 	}
 
 	/**
@@ -152,8 +151,9 @@ public class UebManager {
 	 * @param inboxQueue
 	 *            Queue supplied to the consumer. If not null, the consumer will
 	 *            enqueue every message it receives.
+	 * @throws UebException 
 	 */
-	public void initListener(ConcurrentLinkedQueue inboxQueue) throws UebException {
+	public void initListener(Queue inboxQueue) throws UebException {
 		waitingRequestersQueueList = new WaitingRequestersQueueList();
 		Consumer runnable = new Consumer(appUebKey, appUebSecret, inTopicName, consumerGroupName, inboxQueue,
 				waitingRequestersQueueList);
@@ -167,13 +167,13 @@ public class UebManager {
 
 		/*
 		 * ECOMP Portal manages a dynamic list of outbound topics and so the
-		 * outTopicName is initialized in this logic with the same value as the
-		 * inbound topic. The real outbound topics name will be added to the
-		 * publisher list for ECOMP Portal. For an SDK/App instance only one
-		 * publisher is needed, appPublisher.
+		 * outTopicName is initialized in this logic with the same value as the inbound
+		 * topic. The real outbound topics name will be added to the publisher list for
+		 * ECOMP Portal. For an SDK/App instance only one publisher is needed,
+		 * appPublisher.
 		 */
 		if (inTopicName.equalsIgnoreCase(outTopicName)) {
-			this.bThisIsEcompPortalServer = true;
+			// This is ECOMP POrtal server.1
 		} else {
 			appPublisher = new Publisher(appUebKey, appUebSecret, outTopicName);
 			Helper.sleep(400);
@@ -181,9 +181,9 @@ public class UebManager {
 	}
 
 	/**
-	 * Creates and adds a publisher to the list for the specified topic. This
-	 * should only be called by the ECOMP Portal App, other Apps have just one
-	 * publisher and use appPublisher
+	 * Creates and adds a publisher to the list for the specified topic. This should
+	 * only be called by the ECOMP Portal App, other Apps have just one publisher
+	 * and use appPublisher
 	 * 
 	 * @param topicName
 	 */
@@ -196,8 +196,8 @@ public class UebManager {
 	/**
 	 * Removes a publisher from the list for the specified topic.
 	 *
-	 * This should only be called by the ECOMP Portal App, other Apps have just
-	 * one publisher and use appPublisher
+	 * This should only be called by the ECOMP Portal App, other Apps have just one
+	 * publisher and use appPublisher
 	 * 
 	 * @param topicName
 	 */
@@ -207,8 +207,8 @@ public class UebManager {
 	}
 
 	/**
-	 * Adds the default ECOMP message ID to the message and sends the message to
-	 * the topic.
+	 * Adds the default ECOMP message ID to the message and sends the message to the
+	 * topic.
 	 * 
 	 * @param msg
 	 * @throws UebException
@@ -230,8 +230,7 @@ public class UebManager {
 	}
 
 	/**
-	 * Sends the message using the appropriate publisher for the specified
-	 * topic.
+	 * Sends the message using the appropriate publisher for the specified topic.
 	 * 
 	 * @param msg
 	 * @param topicName
@@ -246,8 +245,7 @@ public class UebManager {
 	}
 
 	/**
-	 * Publishes a reply using the appropriate publisher for the specified
-	 * topic.
+	 * Publishes a reply using the appropriate publisher for the specified topic.
 	 * 
 	 * @param msg
 	 * @param topicName
@@ -262,9 +260,9 @@ public class UebManager {
 	}
 
 	/**
-	 * Sends the specified message using the specified publisher, and waits for
-	 * a reply. Retransmits if no reply is received in 5 seconds; gives up after
-	 * 3 retries.
+	 * Sends the specified message using the specified publisher, and waits for a
+	 * reply. Retransmits if no reply is received in 5 seconds; gives up after 3
+	 * retries.
 	 * 
 	 * @param msg
 	 * @param publisher
@@ -281,10 +279,10 @@ public class UebManager {
 			msg.putMsgId(UUID.randomUUID().toString());
 
 			/*
-			 * Create a queue for this request, the consumer thread will insert
-			 * the reply on this queue
+			 * Create a queue for this request, the consumer thread will insert the reply on
+			 * this queue
 			 */
-			LinkedBlockingQueue replyQueue = new LinkedBlockingQueue();
+			LinkedBlockingQueue replyQueue = new LinkedBlockingQueue<>();
 			waitingRequestersQueueList.addQueueToMap(msg.getMsgId(), replyQueue);
 
 			/*
@@ -332,8 +330,8 @@ public class UebManager {
 	}
 
 	/**
-	 * Sends the specified message using the publisher appropriate for the
-	 * specified topic name, and waits for a reply.
+	 * Sends the specified message using the publisher appropriate for the specified
+	 * topic name, and waits for a reply.
 	 * 
 	 * @param msg
 	 * @param topicName
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/UebMsg.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/UebMsg.java
index b05fae68..a393823a 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/UebMsg.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/UebMsg.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -63,17 +63,16 @@ public class UebMsg {
 	private String sourceHostName;
 
 	/**
-	 * Creates a new object and populates the fields source IP, source topic,
-	 * time stamp, version, and message id.
+	 * Creates a new object and populates the fields source IP, source topic, time
+	 * stamp, version, and message id.
 	 */
 	public UebMsg() {
 		InetAddress ip;
 		try {
 			ip = InetAddress.getLocalHost();
-			// Do not attempt to get name, why wait on DNS every time?
-			// sourceHostName = ip.getHostName();
 			sourceIP = ip.getHostAddress();
 		} catch (UnknownHostException e) {
+			logger.warn("UebMsg::ctor failed", e);
 			sourceHostName = "unknown";
 			sourceIP = "unknown";
 		}
@@ -82,7 +81,7 @@ public class UebMsg {
 		this.version = "1.0";
 		this.msgId = PortalApiConstants.ECOMP_DEFAULT_MSG_ID;
 		this.payload = "empty payload content";
-		this.sourceTopicName = PortalApiProperties.getProperty(PortalApiConstants.UEB_APP_INBOUND_MAILBOX_NAME);		
+		this.sourceTopicName = PortalApiProperties.getProperty(PortalApiConstants.UEB_APP_INBOUND_MAILBOX_NAME);
 		if (this.sourceTopicName == null)
 			logger.error("Failed to get property " + PortalApiConstants.UEB_APP_INBOUND_MAILBOX_NAME);
 	}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/UebMsgTypes.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/UebMsgTypes.java
index ba94cdc9..da4f4f0e 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/UebMsgTypes.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/UebMsgTypes.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/WaitingRequestersQueueList.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/WaitingRequestersQueueList.java
index 768f1beb..5e2ee5d6 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/WaitingRequestersQueueList.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/onboarding/ueb/WaitingRequestersQueueList.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -52,6 +52,7 @@ import org.apache.commons.logging.LogFactory;
  * Primarily for the UebManager to track requests while it waits for responses.
  */
 public class WaitingRequestersQueueList {
+	
 	private final Log logger = LogFactory.getLog(getClass());
 
 	private final Map> map;
@@ -59,7 +60,7 @@ public class WaitingRequestersQueueList {
 	public WaitingRequestersQueueList() {
 		map = new ConcurrentHashMap<>();
 	}
-	
+
 	public void addQueueToMap(String msgId, LinkedBlockingQueue queue) {
 		this.map.put(msgId, queue);
 	}
@@ -77,13 +78,12 @@ public class WaitingRequestersQueueList {
 		this.map.remove(msgId);
 	}
 
+	@Override
 	public String toString() {
-		StringBuffer sb = new StringBuffer();
+		StringBuilder sb = new StringBuilder();
 		sb.append("Map contains " + this.map.size() + " Publishers.");
 		for (Map.Entry> entry : this.map.entrySet()) {
-			String key = entry.getKey().toString();
-			LinkedBlockingQueue queue = entry.getValue();
-			sb.append("Entry msgId, " + key + " queue " + queue);
+			sb.append("Entry msgId, " + entry.getKey() + " queue " + entry.getValue());
 		}
 		return sb.toString();
 	}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/restful/client/HttpStatusAndResponse.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/restful/client/HttpStatusAndResponse.java
index 7caba3d8..47a35d4f 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/restful/client/HttpStatusAndResponse.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/restful/client/HttpStatusAndResponse.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/restful/client/PortalRestClientBase.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/restful/client/PortalRestClientBase.java
index 5ccb715b..2c4da43d 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/restful/client/PortalRestClientBase.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/restful/client/PortalRestClientBase.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -39,13 +39,9 @@ package org.onap.portalsdk.core.restful.client;
 
 import java.io.IOException;
 import java.net.URI;
-import java.net.URISyntaxException;
-
-import javax.servlet.http.HttpServletResponse;
 
 import org.apache.http.Consts;
 import org.apache.http.HttpEntity;
-import org.apache.http.client.ClientProtocolException;
 import org.apache.http.client.methods.CloseableHttpResponse;
 import org.apache.http.client.methods.HttpGet;
 import org.apache.http.client.methods.HttpPost;
@@ -56,6 +52,7 @@ import org.apache.http.impl.client.HttpClients;
 import org.apache.http.util.EntityUtils;
 import org.onap.portalsdk.core.domain.App;
 import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
+import org.onap.portalsdk.core.onboarding.exception.CipherUtilException;
 import org.onap.portalsdk.core.onboarding.util.CipherUtil;
 import org.onap.portalsdk.core.onboarding.util.PortalApiConstants;
 import org.onap.portalsdk.core.onboarding.util.PortalApiProperties;
@@ -80,7 +77,7 @@ public class PortalRestClientBase {
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(PortalRestClientBase.class);
 
 	@Autowired
-	AppService appService;
+	private AppService appService;
 
 	/**
 	 * Constructs and sends a GET request for the URI, with REST application
@@ -89,47 +86,45 @@ public class PortalRestClientBase {
 	 * @param uri
 	 *            URI of the service
 	 * @return Result of the get; null if an error happens
-	 * @throws Exception 
+	 * @throws CipherUtilException
+	 *             If the app password cannot be decrypted
+	 * @throws IOException
+	 *             If the remote end cannot be contacted
 	 */
-	public HttpStatusAndResponse getRestWithCredentials(final URI uri) throws Exception  {
+	public HttpStatusAndResponse getRestWithCredentials(final URI uri) throws CipherUtilException, IOException {
 
 		String uebKey = PortalApiProperties.getProperty(PortalApiConstants.UEB_APP_KEY);
 		App app = appService.getDefaultApp();
 		if (uebKey == null || app == null || app.getUsername() == null || app.getAppPassword() == null)
-			throw new IllegalArgumentException("Missing one or more required properties and/or database entries");
+			throw new IllegalArgumentException(
+					"getRestWithCredentials: Missing one or more required properties and/or database entries");
 		String decryptedPassword = CipherUtil.decrypt(app.getAppPassword());
 		CloseableHttpClient httpClient = HttpClients.createDefault();
 		HttpGet httpGet = new HttpGet(uri);
 		httpGet.setHeader("uebkey", uebKey);
 		httpGet.setHeader("username", app.getUsername());
 		httpGet.setHeader("password", decryptedPassword);
-
 		String responseJson = null;
 		CloseableHttpResponse response = null;
+		logger.info(EELFLoggerDelegate.debugLogger, "getRestWithCredentials: URL {}", uri);
 		try {
-			logger.info(EELFLoggerDelegate.debugLogger, "GET from " + uri);
 			response = httpClient.execute(httpGet);
-			logger.info(EELFLoggerDelegate.debugLogger, "Status is " + response.getStatusLine());
-			if (response.getStatusLine().getStatusCode() != HttpServletResponse.SC_OK)
-			    logger.info(EELFLoggerDelegate.debugLogger, "Status is " + response.getStatusLine().toString());
+			logger.debug(EELFLoggerDelegate.debugLogger, "getRestWithCredentials: status " + response.getStatusLine());
 			HttpEntity entity = response.getEntity();
 			if (entity == null) {
-				logger.info(EELFLoggerDelegate.debugLogger, "Entity is null!");
+				logger.debug(EELFLoggerDelegate.debugLogger, "getRestWithCredentials: entity is null!");
 			} else {
 				// entity content length is never set.
 				// this naively tries to read everything.
 				responseJson = EntityUtils.toString(entity);
-				logger.info(EELFLoggerDelegate.debugLogger, responseJson);
+				logger.debug(EELFLoggerDelegate.debugLogger, "getRestWithCredentials: JSON {}", responseJson);
 				EntityUtils.consume(entity);
 			}
 		} finally {
 			if (response != null)
 				response.close();
-			if (httpClient != null)
-				httpClient.close();
 		}
-		if (response == null)
-			return null;
+		httpClient.close();
 		return new HttpStatusAndResponse(response.getStatusLine().getStatusCode(), responseJson);
 	}
 
@@ -142,49 +137,49 @@ public class PortalRestClientBase {
 	 * @param json
 	 *            Content to post
 	 * @return Result of the post; null if an error happens
-	 * @throws Exception
+	 * @throws CipherUtilException
+	 *             If the app password cannot be decrypted
+	 * @throws IOException
+	 *             If the remote end cannot be contacted
 	 */
-	public HttpStatusAndResponse postRestWithCredentials(final URI uri, final String json) throws Exception {
+	public HttpStatusAndResponse postRestWithCredentials(final URI uri, final String json)
+			throws CipherUtilException, IOException {
 
 		String uebKey = PortalApiProperties.getProperty(PortalApiConstants.UEB_APP_KEY);
 		App app = appService.getDefaultApp();
 		if (uebKey == null || app == null || app.getUsername() == null || app.getAppPassword() == null)
-			throw new Exception("Missing one or more required properties and/or database entries");
-
+			throw new IllegalArgumentException(
+					"postRestWithCredentials: missing one or more required properties and/or database entries");
+		String decryptedPassword = CipherUtil.decrypt(app.getAppPassword());
 		CloseableHttpClient httpClient = HttpClients.createDefault();
 		HttpPost httpPost = new HttpPost(uri);
 		httpPost.setHeader("uebkey", uebKey);
 		httpPost.setHeader("username", app.getUsername());
-		httpPost.setHeader("password", app.getAppPassword());
-
+		httpPost.setHeader("password", decryptedPassword);
 		StringEntity postEntity = new StringEntity(json, ContentType.create("application/json", Consts.UTF_8));
 		httpPost.setEntity(postEntity);
-
 		String responseJson = null;
 		CloseableHttpResponse response = null;
 		try {
-			logger.info(EELFLoggerDelegate.debugLogger, "POST to " + uri);
+			logger.debug(EELFLoggerDelegate.debugLogger, "postRestWithCredentials: POST to {}", uri);
 			response = httpClient.execute(httpPost);
-			logger.info(EELFLoggerDelegate.debugLogger, "Status is " + response.getStatusLine());
-			if (response.getStatusLine().getStatusCode() != HttpServletResponse.SC_OK)
-				throw new Exception("Status is " + response.getStatusLine().toString());
-
+			logger.debug(EELFLoggerDelegate.debugLogger, "postRestWithCredentials: status {} ",
+					response.getStatusLine());
 			HttpEntity entity = response.getEntity();
 			if (entity == null) {
-				logger.info(EELFLoggerDelegate.debugLogger, "Entity is null!");
+				logger.debug(EELFLoggerDelegate.debugLogger, "postRestWithCredentials: entity is null!");
 			} else {
 				// entity content length is never set.
 				// this naively tries to read everything.
 				responseJson = EntityUtils.toString(entity);
-				logger.info(EELFLoggerDelegate.debugLogger, responseJson);
+				logger.debug(EELFLoggerDelegate.debugLogger, "postRestWithCredentials: JSON {}", responseJson);
 				EntityUtils.consume(entity);
 			}
 		} finally {
 			if (response != null)
 				response.close();
-			if (httpClient != null)
-				httpClient.close();
 		}
+		httpClient.close();
 		return new HttpStatusAndResponse(response.getStatusLine().getStatusCode(), responseJson);
 	}
 
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/restful/client/SharedContextRestClient.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/restful/client/SharedContextRestClient.java
index 89ebbe5a..e58a1957 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/restful/client/SharedContextRestClient.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/restful/client/SharedContextRestClient.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,23 +37,23 @@
  */
 package org.onap.portalsdk.core.restful.client;
 
+import java.io.IOException;
 import java.net.URI;
+import java.net.URISyntaxException;
+import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
 
 import org.apache.http.client.utils.URIBuilder;
 import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
+import org.onap.portalsdk.core.onboarding.exception.CipherUtilException;
 import org.onap.portalsdk.core.onboarding.util.PortalApiConstants;
 import org.onap.portalsdk.core.onboarding.util.PortalApiProperties;
 import org.onap.portalsdk.core.restful.domain.SharedContext;
-import org.onap.portalsdk.core.util.SystemProperties;
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Component;
 
-import com.fasterxml.jackson.core.JsonParseException;
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.core.type.TypeReference;
-import com.fasterxml.jackson.databind.JsonMappingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 
 /**
@@ -82,13 +82,13 @@ public class SharedContextRestClient extends PortalRestClientBase {
 	 * Builds the URl for the shared context service using the portal.properties
 	 * value for the AUXAPI endpoint.
 	 * 
-	 * @throws Exception
-	 *             if the ECOMP_REST_URL property is not found 
+	 * @throws IllegalArgumentException
+	 *             if the ECOMP_REST_URL property is not found
 	 */
-	private String getSharedContextUrl() throws Exception {
+	private String getSharedContextUrl() throws IllegalArgumentException {
 		String restUrl = PortalApiProperties.getProperty(PortalApiConstants.ECOMP_REST_URL);
 		if (restUrl == null || restUrl.length() == 0)
-			throw new Exception("getSharedContextUrl: no property " + PortalApiConstants.ECOMP_REST_URL);
+			throw new IllegalArgumentException("getSharedContextUrl: no property " + PortalApiConstants.ECOMP_REST_URL);
 		String contextUrl = restUrl + (restUrl.endsWith("/") ? "" : "/") + "context/";
 		return contextUrl;
 	}
@@ -102,6 +102,7 @@ public class SharedContextRestClient extends PortalRestClientBase {
 	 *            Key for the shared-context entry; e.g., "lastName"
 	 * @return SharedContext object; null if not found.
 	 * @throws Exception
+	 *             If URI cannot be built, host cannot be reached, etc.
 	 */
 	public SharedContext getContextValue(String contextId, String key) throws Exception {
 		HttpStatusAndResponse hsr = getContext("get", contextId, key);
@@ -110,16 +111,8 @@ public class SharedContextRestClient extends PortalRestClientBase {
 			logger.error(EELFLoggerDelegate.applicationLogger, "getContextValue: unexpected null response");
 			return null;
 		}
-		SharedContext jsonObj = null;
-		try {
-			jsonObj = mapper.readValue(hsr.getResponse(), SharedContext.class);
-		} catch (JsonMappingException ex) {
-			logger.error(EELFLoggerDelegate.applicationLogger,
-					"getContextValue: failed to map response onto object" + ex.getMessage());
-		} catch (JsonParseException ex) {
-			logger.info(EELFLoggerDelegate.applicationLogger,
-					"getContextValue: failed to parse response" + ex.getMessage());
-		}
+		SharedContext jsonObj = mapper.readValue(hsr.getResponse(), SharedContext.class);
+		// Response means no data.
 		if (jsonObj != null && jsonObj.getResponse() != null)
 			return null;
 		return jsonObj;
@@ -130,37 +123,28 @@ public class SharedContextRestClient extends PortalRestClientBase {
 	 * 
 	 * @param contextId
 	 *            An Ecomp Portal session ID
-	 * @return List of SharedContext objects corresponding to the following
-	 *         keys: USER_FIRST_NAME, USER_LAST_NAME, USER_EMAIL and
-	 *         USER_ORGUSERID; empty if none were found; null if an error
-	 *         happens.
+	 * @return List of SharedContext objects corresponding to the following keys:
+	 *         USER_FIRST_NAME, USER_LAST_NAME, USER_EMAIL and USER_ORGUSERID; empty
+	 *         if none were found; null if an error happens.
 	 * @throws Exception
+	 *             If URI cannot be built, host cannot be reached, etc.
 	 */
 	public List getUserContext(String contextId) throws Exception {
 		HttpStatusAndResponse hsr = getContext("get_user", contextId, null);
 		logger.info(EELFLoggerDelegate.debugLogger, "getUserContext: resp is " + hsr);
 		if (hsr == null) {
 			logger.error(EELFLoggerDelegate.applicationLogger, "getUserContext: unexpected null response");
-			return null;
-		}
-		List jsonList = null;
-		try {
-			TypeReference> typeRef = new TypeReference>() {
-			};
-			jsonList = mapper.readValue(hsr.getResponse(), typeRef);
-		} catch (JsonMappingException ex) {
-			logger.error(EELFLoggerDelegate.applicationLogger,
-					"getUserContext: failed to map response onto object" + ex.getMessage());
-		} catch (JsonParseException ex) {
-			logger.error(EELFLoggerDelegate.applicationLogger,
-					"getUserContext: failed to parse response" + ex.getMessage());
+			return new ArrayList<>();
 		}
+		TypeReference> typeRef = new TypeReference>() {
+		};
+		List jsonList = mapper.readValue(hsr.getResponse(), typeRef);
 		return jsonList;
 	}
 
 	/**
-	 * Checks whether a shared-context entry exists for the specified context ID
-	 * and key.
+	 * Checks whether a shared-context entry exists for the specified context ID and
+	 * key.
 	 * 
 	 * @param contextId
 	 *            An Ecomp Portal session ID
@@ -168,6 +152,7 @@ public class SharedContextRestClient extends PortalRestClientBase {
 	 *            Key for the shared-context entry; e.g., "lastName"
 	 * @return True if the object exists, false otherwise; null on error.
 	 * @throws Exception
+	 *             If URI cannot be built, host cannot be reached, etc.
 	 */
 	public Boolean checkSharedContext(String contextId, String key) throws Exception {
 		HttpStatusAndResponse hsr = getContext("check", contextId, key);
@@ -176,20 +161,11 @@ public class SharedContextRestClient extends PortalRestClientBase {
 			logger.error(EELFLoggerDelegate.applicationLogger, "checkSharedContext: unexpected null response");
 			return null;
 		}
-		String response = null;
-		try {
-			SharedContext jsonObj = mapper.readValue(hsr.getResponse(), SharedContext.class);
-			response = jsonObj.getResponse();
-		} catch (JsonMappingException ex) {
-			logger.error(EELFLoggerDelegate.applicationLogger,
-					"checkSharedContext: failed to map response onto object" + ex.getMessage());
-		} catch (JsonParseException ex) {
-			logger.error(EELFLoggerDelegate.applicationLogger,
-					"checkSharedContext: failed to parse response" + ex.getMessage());
-		}
+		SharedContext jsonObj = mapper.readValue(hsr.getResponse(), SharedContext.class);
+		String response = jsonObj.getResponse();
 		if (response == null)
 			return null;
-		return ("exists".equals(response));
+		return "exists".equals(response);
 	}
 
 	/**
@@ -201,6 +177,7 @@ public class SharedContextRestClient extends PortalRestClientBase {
 	 *            Key for the shared-context entry; e.g., "lastName"
 	 * @return True if the entry was removed, false otherwise; null on error.
 	 * @throws Exception
+	 *             If URI cannot be built, host cannot be reached, etc.
 	 */
 	public Boolean removeSharedContext(String contextId, String key) throws Exception {
 		HttpStatusAndResponse hsr = getContext("remove", contextId, key);
@@ -209,20 +186,11 @@ public class SharedContextRestClient extends PortalRestClientBase {
 			logger.error(EELFLoggerDelegate.applicationLogger, "removeSharedContext: unexpected null response");
 			return null;
 		}
-		SharedContext jsonObj = null;
-		try {
-			jsonObj = mapper.readValue(hsr.getResponse(), SharedContext.class);
-		} catch (JsonMappingException ex) {
-			logger.error(EELFLoggerDelegate.applicationLogger,
-					"removeSharedContext: failed to map response onto object" + ex.getMessage());
-		} catch (JsonParseException ex) {
-			logger.error(EELFLoggerDelegate.applicationLogger,
-					"removeSharedContext: failed to parse response" + ex.getMessage());
-		}
+		SharedContext jsonObj = mapper.readValue(hsr.getResponse(), SharedContext.class);
 		if (jsonObj == null)
 			return null;
 		String response = jsonObj.getResponse();
-		return ("removed".equals(response));
+		return "removed".equals(response);
 	}
 
 	/**
@@ -231,9 +199,10 @@ public class SharedContextRestClient extends PortalRestClientBase {
 	 * 
 	 * @param contextId
 	 *            An Ecomp Portal session ID
-	 * @return Number of key-value pairs removed; -1 if not found or any
-	 *         problems occur.
+	 * @return Number of key-value pairs removed; -1 if not found or any problems
+	 *         occur.
 	 * @throws Exception
+	 *             If URI cannot be built, host cannot be reached, etc.
 	 */
 	public int clearSharedContext(String contextId) throws Exception {
 		HttpStatusAndResponse hsr = getContext("remove", contextId, null);
@@ -242,16 +211,7 @@ public class SharedContextRestClient extends PortalRestClientBase {
 			logger.error(EELFLoggerDelegate.applicationLogger, "clearSharedContext: unexpected null response");
 			return -1;
 		}
-		SharedContext jsonObj = null;
-		try {
-			jsonObj = mapper.readValue(hsr.getResponse(), SharedContext.class);
-		} catch (JsonMappingException ex) {
-			logger.error(EELFLoggerDelegate.applicationLogger,
-					"clearSharedContext: failed to map response onto object" + ex.getMessage());
-		} catch (JsonParseException ex) {
-			logger.error(EELFLoggerDelegate.applicationLogger,
-					"clearSharedContext: failed to parse response" + ex.getMessage());
-		}
+		SharedContext jsonObj = mapper.readValue(hsr.getResponse(), SharedContext.class);
 		if (jsonObj == null)
 			return -1;
 		String response = jsonObj.getResponse();
@@ -269,9 +229,10 @@ public class SharedContextRestClient extends PortalRestClientBase {
 	 *            Key for the shared-context entry; e.g., "lastName"
 	 * @param value
 	 *            Value for the entry
+	 * @return True if the object previously existed, false otherwise; null if any
+	 *         problem happened.
 	 * @throws Exception
-	 * @return True if the object previously existed, false otherwise; null if
-	 *         any problem happened.
+	 *             If URI cannot be built, host cannot be reached, etc.
 	 */
 	public Boolean setSharedContext(String contextId, String key, String value) throws Exception {
 		String body = buildContext(contextId, key, value);
@@ -281,33 +242,28 @@ public class SharedContextRestClient extends PortalRestClientBase {
 			logger.error(EELFLoggerDelegate.applicationLogger, "setSharedContext: unexpected null response");
 			return null;
 		}
-		SharedContext jsonObj = null;
-		try {
-			jsonObj = mapper.readValue(hsr.getResponse(), SharedContext.class);
-		} catch (JsonMappingException ex) {
-			logger.error(EELFLoggerDelegate.applicationLogger,
-					"setSharedContext: failed to map response onto object" + ex.getMessage());
-		} catch (JsonParseException ex) {
-			logger.error(EELFLoggerDelegate.applicationLogger,
-					"setSharedContext: failed to parse response" + ex.getMessage());
-		}
+		SharedContext jsonObj = mapper.readValue(hsr.getResponse(), SharedContext.class);
 		if (jsonObj == null)
 			return null;
 		String response = jsonObj.getResponse();
-		return ("replaced".equals(response));
+		return "replaced".equals(response);
 	}
 
 	/**
-	 * Builds the full URL with the specified parameters, then calls the method
-	 * that adds credentials and GETs.
+	 * Builds the full URL with the specified parameters, then calls the method that
+	 * adds credentials and GETs.
 	 * 
 	 * @param requestPath
 	 * @param contextId
 	 * @param contextKey
 	 * @return HttpStatusAndResponse object; may be null.
-	 * @throws Exception
+	 * @throws URISyntaxException
+	 * @throws IllegalArgumentException
+	 * @throws IOException
+	 * @throws CipherUtilException
 	 */
-	private HttpStatusAndResponse getContext(String requestPath, String contextId, String contextKey) throws Exception {
+	private HttpStatusAndResponse getContext(String requestPath, String contextId, String contextKey)
+			throws IllegalArgumentException, URISyntaxException, CipherUtilException, IOException {
 		URIBuilder uriBuilder = new URIBuilder(getSharedContextUrl() + requestPath);
 		uriBuilder.addParameter("context_id", contextId);
 		if (contextKey != null)
@@ -317,16 +273,19 @@ public class SharedContextRestClient extends PortalRestClientBase {
 	}
 
 	/**
-	 * Builds the full URL, then calls the method that adds credentials and
-	 * POSTs.
+	 * Builds the full URL, then calls the method that adds credentials and POSTs.
 	 * 
 	 * @param requestPath
 	 * @param contextId
 	 * @param contextKey
 	 * @return HttpStatusAndResponse object; may be null.
-	 * @throws Exception
+	 * @throws IOException
+	 * @throws CipherUtilException
+	 * @throws URISyntaxException
+	 * @throws IllegalArgumentException
 	 */
-	private HttpStatusAndResponse postContext(String requestPath, String json) throws Exception {
+	private HttpStatusAndResponse postContext(String requestPath, String json)
+			throws CipherUtilException, IOException, IllegalArgumentException, URISyntaxException {
 		URIBuilder uriBuilder = new URIBuilder(getSharedContextUrl() + requestPath);
 		URI uri = uriBuilder.build();
 		return postRestWithCredentials(uri, json);
@@ -344,8 +303,7 @@ public class SharedContextRestClient extends PortalRestClientBase {
 	 * @return JSON block
 	 */
 	private String buildContext(String cxid, String ckey, String cvalue) throws JsonProcessingException {
-		ObjectMapper mapper = new ObjectMapper();
-		HashMap stringMap = new HashMap();
+		HashMap stringMap = new HashMap<>();
 		stringMap.put("context_id", cxid);
 		stringMap.put("ckey", ckey);
 		stringMap.put("cvalue", cvalue);
@@ -355,9 +313,6 @@ public class SharedContextRestClient extends PortalRestClientBase {
 
 	// Simple test scaffold
 	public static void main(String[] args) throws Exception {
-		// ObjectMapper mapper = new ObjectMapper();
-		// SharedContext cxt = mapper.readValue("{ \"response\":\"foo\" }",
-		// SharedContext.class);
 		SharedContextRestClient client = new SharedContextRestClient();
 		SharedContext get = client.getContextValue("abc", "123");
 		System.out.println("Get yields " + get.toString());
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/scheduler/CoreRegister.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/scheduler/CoreRegister.java
index 68907d3d..d37b0d13 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/scheduler/CoreRegister.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/scheduler/CoreRegister.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -49,60 +49,35 @@ import org.springframework.context.annotation.DependsOn;
 import org.springframework.stereotype.Component;
 
 @Component
-@DependsOn({"systemProperties"})
+@DependsOn({ "systemProperties" })
 public class CoreRegister {
 
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(CoreRegister.class);
-	
-	Trigger trigger[] = new Trigger[1];
 
-	protected List scheduleTriggers = new ArrayList();
+	protected List scheduleTriggers = new ArrayList<>();
 
 	public void registerTriggers() {
 		// we can use this method to add any schedules to the core
-		
-		/*
-		try {
-			if(SystemProperties.getProperty(SystemProperties.SESSIONTIMEOUT_FEED_CRON) != null)
-				getScheduleTriggers().add(sessionMgtRegistry.getTrigger());
-			
-		} catch(IllegalStateException ies) {
-			logger.info("Session Timout Cron not available");
-		}
-		*/	
-		
 	}
 
-	protected void addTrigger(final String cron,	final CronTrigger cronRegistryTrigger) {
-		// if the property value is not available; the cron will not be added and can be ignored. its safe to ignore the exceptions
-		
+	protected void addTrigger(final String cron, final CronTrigger cronRegistryTrigger) {
+		// if the property value is not available; the cron will not be added and can be
+		// ignored. its safe to ignore the exceptions
 		try {
-			
-			if(SystemProperties.getProperty(cron) != null) {
+			if (SystemProperties.getProperty(cron) != null) {
 				getScheduleTriggers().add(cronRegistryTrigger);
 			}
-			
-		} catch(IllegalStateException ies) {
+		} catch (IllegalStateException ies) {
 			logger.error(EELFLoggerDelegate.errorLogger, "Log Cron not available", AlarmSeverityEnum.MAJOR);
 		}
 	}
-	
-	
-
 
 	public List getScheduleTriggers() {
 		return scheduleTriggers;
 	}
 
-
-
 	public void setScheduleTriggers(List scheduleTriggers) {
 		this.scheduleTriggers = scheduleTriggers;
 	}
-	
-	
-
-	
-	
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/scheduler/CronRegistry.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/scheduler/CronRegistry.java
index 3b1c7030..3e805f3e 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/scheduler/CronRegistry.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/scheduler/CronRegistry.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -49,94 +49,89 @@ import org.springframework.scheduling.quartz.QuartzJobBean;
 
 import com.mchange.v2.c3p0.ComboPooledDataSource;
 
-public abstract class CronRegistry {	
-	
+public abstract class CronRegistry {
+
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(CronRegistry.class);
-	
+
 	protected JobDetailFactoryBean jobDetailFactory;
 	protected CronTriggerFactoryBean cronTriggerFactory;
 
 	private ComboPooledDataSource dataSource;
-	
+
 	public CronRegistry() {
 		try {
-		jobDetailFactoryBean();
-		cronTriggerFactoryBean();
-		}
-		catch(Exception e) {
-			logger.error(EELFLoggerDelegate.debugLogger, e.getMessage());
+			jobDetailFactoryBean();
+			cronTriggerFactoryBean();
+		} catch (Exception e) {
+			logger.error(EELFLoggerDelegate.errorLogger, "CronRegistry::ctor 1 failed", e);
 		}
 	}
-	
-	//@Autowired
+
+	// @Autowired
 	public CronRegistry(ComboPooledDataSource dataSource) {
 		try {
-		this.dataSource = dataSource;
-		jobDetailFactoryBean();
-		cronTriggerFactoryBean();
-		}
-		catch(Exception e) {
-			logger.error(EELFLoggerDelegate.errorLogger, e.getMessage(),AlarmSeverityEnum.MAJOR);
+			this.dataSource = dataSource;
+			jobDetailFactoryBean();
+			cronTriggerFactoryBean();
+		} catch (Exception e) {
+			logger.error(EELFLoggerDelegate.errorLogger, e.getMessage(), AlarmSeverityEnum.MAJOR);
 		}
 	}
-	
-	//@Autowired
+
+	// @Autowired
 	public CronRegistry(Object... initializeObjects) {
 		try {
 			initializeObjects(initializeObjects);
 			jobDetailFactoryBean();
 			cronTriggerFactoryBean();
-		}
-		catch(Exception e) {
-			logger.info(EELFLoggerDelegate.errorLogger, e.getMessage());
+		} catch (Exception e) {
+			logger.error(EELFLoggerDelegate.errorLogger, "CronRegistry::ctor 3 failed", e);
 		}
 	}
-	
-	protected void initializeObjects(Object... initializeObjects) {	
+
+	protected void initializeObjects(Object... initializeObjects) {
 	}
-	
+
 	public abstract JobDetailFactoryBean jobDetailFactoryBean() throws ParseException;
-	
+
 	protected JobDetailFactoryBean jobDetailFactoryBean(String groupName, String jobName,
 			Class jobClass, Map map) {
-		
+
 		jobDetailFactory = new JobDetailFactoryBean();
 		jobDetailFactory.setJobClass(jobClass);
 		jobDetailFactory.setJobDataAsMap(map);
 		jobDetailFactory.setGroup(groupName);
 		jobDetailFactory.setName(jobName);
 		jobDetailFactory.afterPropertiesSet();
-	
+
 		return jobDetailFactory;
-	} 
-	
+	}
+
 	public abstract CronTriggerFactoryBean cronTriggerFactoryBean() throws ParseException;
-	
-	protected CronTriggerFactoryBean cronTriggerFactoryBean(String groupName, String triggerName, String cronExpression) throws ParseException {
+
+	protected CronTriggerFactoryBean cronTriggerFactoryBean(String groupName, String triggerName, String cronExpression)
+			throws ParseException {
 		cronTriggerFactory = new CronTriggerFactoryBean();
 		cronTriggerFactory.setJobDetail(jobDetailFactory.getObject());
 		cronTriggerFactory.setStartDelay(3000);
 		cronTriggerFactory.setName(triggerName);
 		cronTriggerFactory.setGroup(groupName);
 		logger.info(EELFLoggerDelegate.applicationLogger, triggerName + " Scheduled: " + cronExpression);
-		cronTriggerFactory.setCronExpression( cronExpression);  //"0 * * * * ? *"
+		cronTriggerFactory.setCronExpression(cronExpression); // "0 * * * * ? *"
 		cronTriggerFactory.afterPropertiesSet();
 		return cronTriggerFactory;
-	} 
-	
+	}
+
 	public CronTrigger getTrigger() {
 		return cronTriggerFactory.getObject();
 	}
 
-	
 	public void setDataSource(ComboPooledDataSource dataSource) {
 		this.dataSource = dataSource;
 	}
 
-
 	public ComboPooledDataSource getDataSource() {
 		return dataSource;
 	}
 
-	
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/scheduler/Registerable.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/scheduler/Registerable.java
index 33af9d1a..83480910 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/scheduler/Registerable.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/scheduler/Registerable.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -40,9 +40,9 @@ package org.onap.portalsdk.core.scheduler;
 import org.quartz.Trigger;
 
 public interface Registerable {
-	
+
 	public void registerTriggers();
-	
+
 	public Trigger[] getTriggers();
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/AccessConfiguration.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/AccessConfiguration.java
index d369199d..9feeb3a2 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/AccessConfiguration.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/AccessConfiguration.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/AppService.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/AppService.java
index 6ca1d013..07d8fec7 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/AppService.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/AppService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -68,10 +68,11 @@ public interface AppService {
 	 * FN_APP table.
 	 */
 	App getDefaultApp();
-	
+
 	/**
-	 * Fetches the application name once from database
-	 * and keep refers to the same name later on as required.
+	 * Fetches the application name once from database and keep refers to the same
+	 * name later on as required.
+	 * 
 	 * @return Default Application Name
 	 */
 	String getDefaultAppName();
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/AppServiceImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/AppServiceImpl.java
index 179b0864..e0f8fc24 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/AppServiceImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/AppServiceImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -47,19 +47,18 @@ import org.springframework.transaction.annotation.Transactional;
 
 @Service("appService")
 @Transactional
-public class AppServiceImpl implements AppService{
+public class AppServiceImpl implements AppService {
 
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(AppServiceImpl.class);
-	
+
 	@Autowired
-	private DataAccessService  dataAccessService;
+	private DataAccessService dataAccessService;
 
 	/**
-	 * Loads the appName once from database and
-	 * keep refers to it as required.
+	 * Loads the appName once from database and keep refers to it as required.
 	 */
 	private static String defaultAppName = "";
-	
+
 	@SuppressWarnings("unchecked")
 	@Override
 	public List getApps() {
@@ -68,16 +67,17 @@ public class AppServiceImpl implements AppService{
 
 	@Override
 	public App getApp(Long appId) {
-		return (App)getDataAccessService().getDomainObject(App.class, appId, null);
+		return (App) getDataAccessService().getDomainObject(App.class, appId, null);
 	}
 
 	@Override
 	public App getDefaultApp() {
 		return getApp(1L);
 	}
-	
+
 	/**
 	 * Gets the data access service.
+	 * 
 	 * @return DataAccessService
 	 */
 	public DataAccessService getDataAccessService() {
@@ -86,25 +86,28 @@ public class AppServiceImpl implements AppService{
 
 	/**
 	 * Sets the data access service.
+	 * 
 	 * @param dataAccessService
 	 */
 	public void setDataAccessService(DataAccessService dataAccessService) {
 		this.dataAccessService = dataAccessService;
 	}
-	
+
 	/**
-	 * Fetches the application name once from database
-	 * and keep refers to the same name later on as required.
+	 * Fetches the application name once from database and keep refers to the same
+	 * name later on as required.
+	 * 
 	 * @return Default Application Name
 	 */
 	@Override
 	public String getDefaultAppName() {
-		if (AppServiceImpl.defaultAppName==null || AppServiceImpl.defaultAppName=="") {
+		if (AppServiceImpl.defaultAppName == null || AppServiceImpl.defaultAppName == "") {
 			App app = getApp(1L);
-			if (app!=null) {
-				AppServiceImpl.defaultAppName		= app.getName();
+			if (app != null) {
+				AppServiceImpl.defaultAppName = app.getName();
 			} else {
-				logger.warn(EELFLoggerDelegate.errorLogger, ("Unable to locate the app information from the database."));
+				logger.warn(EELFLoggerDelegate.errorLogger,
+						"Unable to locate the app information from the database.");
 			}
 		}
 		return AppServiceImpl.defaultAppName;
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/AuditService.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/AuditService.java
index ec0c7ce7..40fc2f08 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/AuditService.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/AuditService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,7 +37,7 @@
  */
 package org.onap.portalsdk.core.service;
 
-import java.util.HashMap;
+import java.util.Map;
 
 import org.onap.portalsdk.core.domain.AuditLog;
 
@@ -49,7 +49,7 @@ public interface AuditService {
 	 * @param auditLog
 	 * @param additionalParams
 	 */
-	
+
 	@SuppressWarnings("rawtypes")
-    void logActivity(AuditLog auditLog, HashMap additionalParams);
+	void logActivity(AuditLog auditLog, Map additionalParams);
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/AuditServiceImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/AuditServiceImpl.java
index 77db3681..1bc81d9a 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/AuditServiceImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/AuditServiceImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,7 +37,7 @@
  */
 package org.onap.portalsdk.core.service;
 
-import java.util.HashMap;
+import java.util.Map;
 
 import org.onap.portalsdk.core.domain.AuditLog;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -47,15 +47,18 @@ import org.springframework.transaction.annotation.Transactional;
 @Service("auditService")
 @Transactional
 public class AuditServiceImpl implements AuditService {
-    public AuditServiceImpl() {}
-    
-    @Autowired
-	private DataAccessService  dataAccessService;
-    
-    @SuppressWarnings("rawtypes")
-    public void logActivity(AuditLog auditLog, HashMap additionalParams) {
+
+	@Autowired
+	private DataAccessService dataAccessService;
+
+	public AuditServiceImpl() {
+	}
+
+	@Override
+	@SuppressWarnings("rawtypes")
+	public void logActivity(AuditLog auditLog, Map additionalParams) {
 		getDataAccessService().saveDomainObject(auditLog, additionalParams);
-    }
+	}
 
 	public DataAccessService getDataAccessService() {
 		return dataAccessService;
@@ -64,5 +67,5 @@ public class AuditServiceImpl implements AuditService {
 	public void setDataAccessService(DataAccessService dataAccessService) {
 		this.dataAccessService = dataAccessService;
 	}
-    
+
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/BroadcastService.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/BroadcastService.java
index bef46450..3cbf6644 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/BroadcastService.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/BroadcastService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,7 +37,7 @@
  */
 package org.onap.portalsdk.core.service;
 
-import java.util.*;
+import java.util.Map;
 
 import javax.servlet.http.HttpServletRequest;
 
@@ -45,10 +45,16 @@ import org.onap.portalsdk.core.domain.BroadcastMessage;
 
 @SuppressWarnings("rawtypes")
 public interface BroadcastService {
-	HashMap getBcModel(HttpServletRequest request);
-    Hashtable getBroadcastMessages();
-    void      loadMessages();
-    BroadcastMessage getBroadcastMessage(HttpServletRequest request);
+	
+	Map getBcModel(HttpServletRequest request);
+
+	Map getBroadcastMessages();
+
+	void loadMessages();
+
+	BroadcastMessage getBroadcastMessage(HttpServletRequest request);
+
 	void saveBroadcastMessage(BroadcastMessage broadcastMessage);
+
 	void removeBroadcastMessage(BroadcastMessage broadcastMessage);
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/BroadcastServiceImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/BroadcastServiceImpl.java
index 19803d94..5d14ee47 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/BroadcastServiceImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/BroadcastServiceImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -42,6 +42,7 @@ import java.util.Collections;
 import java.util.HashMap;
 import java.util.Hashtable;
 import java.util.List;
+import java.util.Map;
 import java.util.Set;
 import java.util.TreeSet;
 
@@ -49,6 +50,7 @@ import javax.servlet.http.HttpServletRequest;
 
 import org.onap.portalsdk.core.domain.BroadcastMessage;
 import org.onap.portalsdk.core.domain.Lookup;
+import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
 import org.onap.portalsdk.core.service.support.FusionService;
 import org.onap.portalsdk.core.util.SystemProperties;
 import org.onap.portalsdk.core.web.support.AppUtils;
@@ -62,199 +64,201 @@ import org.springframework.web.bind.ServletRequestUtils;
 @Service("broadcastService")
 @Transactional
 public class BroadcastServiceImpl extends FusionService implements BroadcastService {
-  
-  public BroadcastServiceImpl() {
-  }
+
+	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(BroadcastServiceImpl.class);
 
 	@Autowired
-	private DataAccessService  dataAccessService;
-  private static Hashtable         broadcastMessages = new Hashtable();
-
-  @SuppressWarnings("unchecked")
-  public void loadMessages() {
-    List messageLocations = AppUtils.getLookupListNoCache("fn_lu_message_location", "message_location_id", "message_location_descr", "", "message_location_id");
-
-    for (int i=0; i < messageLocations.size(); i++) {
-      Lookup location   = (Lookup)messageLocations.get(i);
-      String locationId = location.getValue();
-
-      broadcastMessages.put(locationId, getPersistedBroadcastMessages(locationId));
-    }
-  }
-  
-  public HashMap getBcModel(HttpServletRequest request){
-		HashMap    bcModel = new HashMap();
-
-        List   items     = null;
-        int    messageId = ServletRequestUtils.getIntParameter(request, "message_id", 0);
-        String task      = ServletRequestUtils.getStringParameter(request, "task", "get");
-
-        // delete or toggle activation on the selected record (if applicable)
-        if (messageId != 0 && (task.equals("delete") || task.equals("toggleActive"))) {
-          BroadcastMessage message = (BroadcastMessage)getDataAccessService().getDomainObject(BroadcastMessage.class, new Long(messageId), null);
-
-          if (task.equals("delete")) {
-            getDataAccessService().deleteDomainObject(message, null);
-          }
-          else if (task.equals("toggleActive")) {
-            HashMap  additionalParams = new HashMap();
-            additionalParams.put(Parameters.PARAM_HTTP_REQUEST, request);
-
-            message.setActive(new Boolean(!message.getActive().booleanValue()));
-            getDataAccessService().saveDomainObject(message, additionalParams);
-          }
-          loadMessages();
-        }
-
-        items = getDataAccessService().getList(BroadcastMessage.class, null);
-        Collections.sort(items);
-        bcModel.put("messagesList", packageMessages(items));
-
-        List locations = AppUtils.getLookupList("fn_lu_message_location", "message_location_id", "message_location_descr", "", "message_location_id");
-        bcModel.put("messageLocations", locations);
-
-        if ("true".equals(SystemProperties.getProperty(SystemProperties.CLUSTERED))) {
-          List sites = AppUtils.getLookupList("fn_lu_broadcast_site", "broadcast_site_cd", "broadcast_site_descr", "", "broadcast_site_descr");
-          bcModel.put("broadcastSites", sites);
-        }
-        
-        return bcModel;
-  }
-  
-  @SuppressWarnings("unchecked")
-  private HashMap packageMessages(List messages) {
-      HashMap messagesList     = new HashMap();
-      Set     locationMessages = null;
-
-      Integer previousLocationId = null;
-
-      for (int i=0; i < messages.size(); i++) {
-        BroadcastMessage message = (BroadcastMessage)messages.get(i);
-
-        if (!message.getLocationId().equals(previousLocationId)) {
-          if (previousLocationId != null) {
-            messagesList.put(previousLocationId.toString(), locationMessages);
-          }
-
-          locationMessages = new TreeSet();
-          previousLocationId = message.getLocationId();
-        }
-
-        locationMessages.add(message);
-      }
-
-      if (previousLocationId != null) {
-        messagesList.put(previousLocationId.toString(), locationMessages);
-      }
-
-      return messagesList;
-    }
-
-
-  @SuppressWarnings("unchecked")
-  private List getPersistedBroadcastMessages(String locationId) {
-    HashMap params = new HashMap();
-
-    
-    
-    params.put("location_id", new Integer(locationId));
-    
-    Calendar calInstanceToday = Calendar.getInstance();
-    calInstanceToday.set(Calendar.HOUR, 0);
-    calInstanceToday.set(Calendar.MINUTE, 0);
-    calInstanceToday.set(Calendar.SECOND, 0);
-    params.put("today_date", calInstanceToday.getTime());
-  
-    return getDataAccessService().executeNamedQuery("broadcastMessages", params, null);
-  }
-
-  public Hashtable getBroadcastMessages() {
-    return broadcastMessages;
-  }
-
-  public static List getBroadcastMessages(String locationId) {
-    return (List)broadcastMessages.get(locationId);
-  }
-
-  public static String displayMessages(String locationId) {
-    return displayServerMessages(locationId, null);
-  }
-
-  public static String displayServerMessages(String locationId, String siteCd) {
-    StringBuffer html = new StringBuffer();
-
-    List messages = getBroadcastMessages(locationId);
-
-    for (int i=0; i < messages.size(); i++) {
-      BroadcastMessage message = (BroadcastMessage)messages.get(i);
-      
-      if ((message.getSiteCd() == null) || ((message.getSiteCd() != null) && message.getSiteCd().equals(siteCd))) {
-        html.append("
  • ")
-            .append(message.getMessageText());
-      }
-    }
-
-    if (html.length() > 0) {
-      html.insert(0, "
      ");
-      html.append("
    ");
-    }
-
-    return html.toString();
-  }
-
-  public static boolean hasMessages(String locationId) {
-    return hasServerMessages(locationId, null);
-  }
-
-  public static boolean hasServerMessages(String locationId, String siteCd) {
-    List messages = getBroadcastMessages(locationId);
-    boolean     messagesExist = !((messages == null) || messages.size() == 0);
-    if (!messagesExist)
-    		return false;
-
-    if (siteCd == null) {
-      return messagesExist;
-    }
-    else {
-      for (int i=0; i < messages.size(); i++) {
-        BroadcastMessage message = (BroadcastMessage)messages.get(i);
-         
-        if ((message.getSiteCd() == null) || message.getSiteCd().equals(siteCd)) {
-          return true;
-        }
-      }
-      return false;
-    }
-  }
-
-  public DataAccessService getDataAccessService() {
-	return dataAccessService;
-  }
-
-  public void setDataAccessService(DataAccessService dataAccessService) {
-	dataAccessService = dataAccessService;
-  }
-
-  public BroadcastMessage getBroadcastMessage(HttpServletRequest request) {
-      long messageId = ServletRequestUtils.getLongParameter(request, "message_id", 0);
-
-      BroadcastMessage message = new BroadcastMessage();
-      if(messageId!=0)
-    	  message = (BroadcastMessage)getDataAccessService().getDomainObject(BroadcastMessage.class, new Long(messageId), null);
-
-      if (message.getLocationId() == null) {
-        try {
-			message.setLocationId(new Integer(ServletRequestUtils.getStringParameter(request, "message_location_id")));
-		} catch (NumberFormatException e) {
-			e.printStackTrace();
-		} catch (ServletRequestBindingException e) {
-			e.printStackTrace();
+	private DataAccessService dataAccessService;
+
+	private static Hashtable broadcastMessages = new Hashtable();
+
+	public BroadcastServiceImpl() {
+		super();
+	}
+
+	@Override
+	@SuppressWarnings("unchecked")
+	public void loadMessages() {
+		List messageLocations = AppUtils.getLookupListNoCache("fn_lu_message_location", "message_location_id",
+				"message_location_descr", "", "message_location_id");
+
+		for (int i = 0; i < messageLocations.size(); i++) {
+			Lookup location = (Lookup) messageLocations.get(i);
+			String locationId = location.getValue();
+
+			broadcastMessages.put(locationId, getPersistedBroadcastMessages(locationId));
+		}
+	}
+
+	@Override
+	@SuppressWarnings("unchecked")
+	public Map getBcModel(HttpServletRequest request) {
+		HashMap bcModel = new HashMap();
+
+		int messageId = ServletRequestUtils.getIntParameter(request, "message_id", 0);
+		String task = ServletRequestUtils.getStringParameter(request, "task", "get");
+
+		// delete or toggle activation on the selected record (if applicable)
+		if (messageId != 0 && ("delete".equals(task) || "toggleActive".equals(task))) {
+			BroadcastMessage message = (BroadcastMessage) getDataAccessService().getDomainObject(BroadcastMessage.class,
+					new Long(messageId), null);
+
+			if ("delete".equals(task)) {
+				getDataAccessService().deleteDomainObject(message, null);
+			} else if ("toggleActive".equals(task)) {
+				HashMap additionalParams = new HashMap();
+				additionalParams.put(Parameters.PARAM_HTTP_REQUEST, request);
+
+				message.setActive(new Boolean(!message.getActive().booleanValue()));
+				getDataAccessService().saveDomainObject(message, additionalParams);
+			}
+			loadMessages();
+		}
+
+		List items = getDataAccessService().getList(BroadcastMessage.class, null);
+		Collections.sort(items);
+		bcModel.put("messagesList", packageMessages(items));
+
+		List locations = AppUtils.getLookupList("fn_lu_message_location", "message_location_id",
+				"message_location_descr", "", "message_location_id");
+		bcModel.put("messageLocations", locations);
+
+		if ("true".equals(SystemProperties.getProperty(SystemProperties.CLUSTERED))) {
+			List sites = AppUtils.getLookupList("fn_lu_broadcast_site", "broadcast_site_cd", "broadcast_site_descr", "",
+					"broadcast_site_descr");
+			bcModel.put("broadcastSites", sites);
 		}
-        message.setActive(Boolean.TRUE);
-      }
 
-      return message;
-    }
+		return bcModel;
+	}
+
+	@SuppressWarnings("unchecked")
+	private HashMap packageMessages(List messages) {
+		HashMap messagesList = new HashMap();
+		Set locationMessages = null;
+
+		Integer previousLocationId = null;
+
+		for (int i = 0; i < messages.size(); i++) {
+			BroadcastMessage message = (BroadcastMessage) messages.get(i);
+
+			if (!message.getLocationId().equals(previousLocationId)) {
+				if (previousLocationId != null) {
+					messagesList.put(previousLocationId.toString(), locationMessages);
+				}
+
+				locationMessages = new TreeSet();
+				previousLocationId = message.getLocationId();
+			}
+
+			locationMessages.add(message);
+		}
+
+		if (previousLocationId != null) {
+			messagesList.put(previousLocationId.toString(), locationMessages);
+		}
+
+		return messagesList;
+	}
+
+	@SuppressWarnings("unchecked")
+	private List getPersistedBroadcastMessages(String locationId) {
+		HashMap params = new HashMap();
+
+		params.put("location_id", new Integer(locationId));
+
+		Calendar calInstanceToday = Calendar.getInstance();
+		calInstanceToday.set(Calendar.HOUR, 0);
+		calInstanceToday.set(Calendar.MINUTE, 0);
+		calInstanceToday.set(Calendar.SECOND, 0);
+		params.put("today_date", calInstanceToday.getTime());
+
+		return getDataAccessService().executeNamedQuery("broadcastMessages", params, null);
+	}
+
+	@Override
+	public Map getBroadcastMessages() {
+		return broadcastMessages;
+	}
+
+	public static List getBroadcastMessages(String locationId) {
+		return (List) broadcastMessages.get(locationId);
+	}
+
+	public static String displayMessages(String locationId) {
+		return displayServerMessages(locationId, null);
+	}
+
+	public static String displayServerMessages(String locationId, String siteCd) {
+		StringBuilder html = new StringBuilder();
+		List messages = getBroadcastMessages(locationId);
+		for (int i = 0; i < messages.size(); i++) {
+			BroadcastMessage message = (BroadcastMessage) messages.get(i);
+			if ((message.getSiteCd() == null)
+					|| ((message.getSiteCd() != null) && message.getSiteCd().equals(siteCd))) {
+				html.append("
  • ").append(message.getMessageText());
+			}
+		}
+		if (html.length() > 0) {
+			html.insert(0, "
      ");
+			html.append("
    ");
+		}
+		return html.toString();
+	}
+
+	public static boolean hasMessages(String locationId) {
+		return hasServerMessages(locationId, null);
+	}
+
+	public static boolean hasServerMessages(String locationId, String siteCd) {
+		List messages = getBroadcastMessages(locationId);
+		boolean messagesExist = !((messages == null) || messages.isEmpty());
+		if (!messagesExist)
+			return false;
+
+		if (siteCd == null) {
+			return messagesExist;
+		} else {
+			for (int i = 0; i < messages.size(); i++) {
+				BroadcastMessage message = (BroadcastMessage) messages.get(i);
+
+				if ((message.getSiteCd() == null) || message.getSiteCd().equals(siteCd)) {
+					return true;
+				}
+			}
+			return false;
+		}
+	}
+
+	@Override
+	public BroadcastMessage getBroadcastMessage(HttpServletRequest request) {
+		long messageId = ServletRequestUtils.getLongParameter(request, "message_id", 0);
+
+		BroadcastMessage message = new BroadcastMessage();
+		if (messageId != 0)
+			message = (BroadcastMessage) getDataAccessService().getDomainObject(BroadcastMessage.class,
+					new Long(messageId), null);
+
+		if (message.getLocationId() == null) {
+			try {
+				message.setLocationId(
+						new Integer(ServletRequestUtils.getStringParameter(request, "message_location_id")));
+			} catch (NumberFormatException | ServletRequestBindingException e) {
+				logger.error(EELFLoggerDelegate.errorLogger, "getBroadcastMessage failed", e);
+			}
+			message.setActive(Boolean.TRUE);
+		}
+
+		return message;
+	}
+
+	public DataAccessService getDataAccessService() {
+		return dataAccessService;
+	}
+
+	public void setDataAccessService(final DataAccessService dataAccessService) {
+		this.dataAccessService = dataAccessService;
+	}
 
 	@Override
 	public void saveBroadcastMessage(BroadcastMessage broadcastMessage) {
@@ -265,5 +269,5 @@ public class BroadcastServiceImpl extends FusionService implements BroadcastServ
 	public void removeBroadcastMessage(BroadcastMessage broadcastMessage) {
 		dataAccessService.deleteDomainObject(broadcastMessage, null);
 	}
-  
+
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/CentralAccessCondition.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/CentralAccessCondition.java
index 65ee9460..e4b7a163 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/CentralAccessCondition.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/CentralAccessCondition.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -44,22 +44,21 @@ import org.springframework.context.annotation.ConditionContext;
 import org.springframework.core.type.AnnotatedTypeMetadata;
 
 public class CentralAccessCondition implements Condition {
-    
+
 	/**
 	 * returns true if the application is centralized
 	 */
 	@Override
 	public boolean matches(ConditionContext context, AnnotatedTypeMetadata metadata) {
 		boolean isRemote = false;
-		
-		if(PortalApiProperties.getProperty(PortalApiConstants.ROLE_ACCESS_CENTRALIZED) == null)
-		{
+
+		if (PortalApiProperties.getProperty(PortalApiConstants.ROLE_ACCESS_CENTRALIZED) == null) {
 			isRemote = false;
+		} else if (PortalApiProperties.getProperty(PortalApiConstants.ROLE_ACCESS_CENTRALIZED) != null
+				&& "remote".equals(PortalApiProperties.getProperty(PortalApiConstants.ROLE_ACCESS_CENTRALIZED))) {
+			isRemote = true;
 		}
-		else if(PortalApiProperties.getProperty(PortalApiConstants.ROLE_ACCESS_CENTRALIZED) != null &&  PortalApiProperties.getProperty(PortalApiConstants.ROLE_ACCESS_CENTRALIZED).equals("remote")){
-		 isRemote = true;
-	    } 
-		
-	 return isRemote;
-  }
+
+		return isRemote;
+	}
 }
\ No newline at end of file
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/DataAccessService.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/DataAccessService.java
index 737d6a6f..8eacefa9 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/DataAccessService.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/DataAccessService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,9 +37,7 @@
  */
 package org.onap.portalsdk.core.service;
 
-
 import java.io.Serializable;
-import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
@@ -52,47 +50,68 @@ import org.onap.portalsdk.core.domain.support.DomainVo;
 @SuppressWarnings("rawtypes")
 public interface DataAccessService {
 
-    // generic view, save, delete methods
-    DomainVo getDomainObject(Class domainClass, Serializable id, HashMap additionalParams);
-    void     deleteDomainObject(DomainVo domainObject, HashMap additionalParams);
-    void     deleteDomainObjects(Class domainClass, String whereClause, HashMap additionalParams);
-    void     saveDomainObject(DomainVo domainObject, HashMap additionalParams);
-
-    // generic get list method(s)
-    List getList(Class domainClass, HashMap additionalParams);
-    List getList(Class domainClass, String filter, String orderBy, HashMap additionalParams);
-    List getList(Class domainClass, String filter, int fromIndex, int toIndex, String orderBy, HashMap additionalParams);
-    List getList(Class domainClass, ProjectionList projectionsList , List restrictionsList , List orderByList);
-    public List getList(Class domainClass, ProjectionList projectionsList, List restrictionsList, List orderByList,HashMap fetchModeMap); 
-    
-    List getLookupList(String dbTable, String dbValueCol, String dbLabelCol, String dbFilter, String dbOrderBy, HashMap additionalParams);
-	
-    // generic native-SQL execution methods
-	List executeSQLQuery(String sql, Class domainClass, HashMap additionalParams);
-    List executeSQLQuery(String sql, Class domainClass, Integer fromIndex, Integer toIndex,HashMap additionalParams);
-
-    // generic HQL execution methods
-    List executeQuery(String hql, HashMap additionalParams);
-    List executeQuery(String hql, Integer fromIndex, Integer toIndex, HashMap additionalParams);
-
-    // generic named query execution methods
-    List executeNamedQuery(String queryName, Integer fromIndex, Integer toIndex, HashMap additionalParams);
-    List executeNamedQuery(String queryName, Map params, HashMap additionalParams);
-    List executeNamedQuery(String queryName, Map params, Integer fromIndex, Integer toIndex, HashMap additionalParams);
-
-    //with Where Clause for RAPTOR ZK
-    List executeNamedQueryWithOrderBy(Class entity, String queryName, Map params, String _orderBy, boolean asc, Integer fromIndex, Integer toIndex, HashMap additionalParams);
-    List executeNamedCountQuery(Class entity, String queryName, String whereClause, Map params);
-    List executeNamedQuery(Class entity, String queryName, String whereClause, Map params, Integer fromIndex, Integer toIndex, HashMap additionalParams);
-    List executeNamedQueryWithOrderBy(Class entity, String queryName, String whereClause, Map params, String _orderBy, boolean asc, Integer fromIndex, Integer toIndex, HashMap additionalParams);
-
-    // generic update query execution method
-    int executeUpdateQuery(String sql, HashMap additionalParams) throws RuntimeException;
-
-    // generic named update query execution method
-    int executeNamedUpdateQuery(String queryName, Map params, HashMap additionalParams) throws RuntimeException;
-    
-    // synchronizes the local updates with the database (and vice versa)
-    void synchronize(HashMap additionalParams);
+	// generic view, save, delete methods
+	DomainVo getDomainObject(Class domainClass, Serializable id, Map additionalParams);
+
+	void deleteDomainObject(DomainVo domainObject, Map additionalParams);
+
+	void deleteDomainObjects(Class domainClass, String whereClause, Map additionalParams);
+
+	void saveDomainObject(DomainVo domainObject, Map additionalParams);
+
+	// generic get list method(s)
+	List getList(Class domainClass, Map additionalParams);
+
+	List getList(Class domainClass, String filter, String orderBy, Map additionalParams);
+
+	List getList(Class domainClass, String filter, int fromIndex, int toIndex, String orderBy,
+			Map additionalParams);
+
+	List getList(Class domainClass, ProjectionList projectionsList, List restrictionsList,
+			List orderByList);
+
+	public List getList(Class domainClass, ProjectionList projectionsList, List restrictionsList,
+			List orderByList, Map fetchModeMap);
+
+	List getLookupList(String dbTable, String dbValueCol, String dbLabelCol, String dbFilter, String dbOrderBy,
+			Map additionalParams);
+
+	// generic native-SQL execution methods
+	List executeSQLQuery(String sql, Class domainClass, Map additionalParams);
+
+	List executeSQLQuery(String sql, Class domainClass, Integer fromIndex, Integer toIndex, Map additionalParams);
+
+	// generic HQL execution methods
+	List executeQuery(String hql, Map additionalParams);
+
+	List executeQuery(String hql, Integer fromIndex, Integer toIndex, Map additionalParams);
+
+	// generic named query execution methods
+	List executeNamedQuery(String queryName, Integer fromIndex, Integer toIndex, Map additionalParams);
+
+	List executeNamedQuery(String queryName, Map params, Map additionalParams);
+
+	List executeNamedQuery(String queryName, Map params, Integer fromIndex, Integer toIndex, Map additionalParams);
+
+	// with Where Clause for RAPTOR ZK
+	List executeNamedQueryWithOrderBy(Class entity, String queryName, Map params, String orderBy, boolean asc,
+			Integer fromIndex, Integer toIndex, Map additionalParams);
+
+	List executeNamedCountQuery(Class entity, String queryName, String whereClause, Map params);
+
+	List executeNamedQuery(Class entity, String queryName, String whereClause, Map params, Integer fromIndex,
+			Integer toIndex, Map additionalParams);
+
+	List executeNamedQueryWithOrderBy(Class entity, String queryName, String whereClause, Map params, String orderBy,
+			boolean asc, Integer fromIndex, Integer toIndex, Map additionalParams);
+
+	// generic update query execution method
+	int executeUpdateQuery(String sql, Map additionalParams);
+
+	// generic named update query execution method
+	int executeNamedUpdateQuery(String queryName, Map params, Map additionalParams);
+
+	// synchronizes the local updates with the database (and vice versa)
+	void synchronize(Map additionalParams);
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/DataAccessServiceImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/DataAccessServiceImpl.java
index e53260db..f34610cb 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/DataAccessServiceImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/DataAccessServiceImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -41,7 +41,6 @@ import java.io.Serializable;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.Date;
-import java.util.HashMap;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
@@ -75,66 +74,55 @@ public class DataAccessServiceImpl extends FusionService implements DataAccessSe
 	private SessionFactory sessionFactory;
 
 	@Override
-	public DomainVo getDomainObject(Class domainClass, Serializable id, HashMap additionalParams) {
-		DomainVo vo = null;
+	public DomainVo getDomainObject(Class domainClass, Serializable id, Map additionalParams) {
 		Session session = sessionFactory.getCurrentSession();
-		logger.info(EELFLoggerDelegate.debugLogger, "Getting " + domainClass.getName() + " record for id - " + id.toString());
-		vo = (DomainVo) session.get(domainClass, id);
-
+		logger.info(EELFLoggerDelegate.debugLogger,
+				"Getting " + domainClass.getName() + " record for id - " + id.toString());
+		DomainVo vo = (DomainVo) session.get(domainClass, id);
 		if (vo == null) {
 			try {
 				vo = (DomainVo) domainClass.newInstance();
 			} catch (Exception e) {
-				logger.error(EELFLoggerDelegate.errorLogger, "An error occured while instantiating a class of " + domainClass.getName() + e.getMessage());
+				logger.error(EELFLoggerDelegate.errorLogger,
+						"getDomainObject failed while instantiating class " + domainClass.getName(), e);
 			}
 		}
 		return vo;
 	}
 
 	@Override
-	public void deleteDomainObject(DomainVo domainObject, HashMap additionalParams) {
+	public void deleteDomainObject(DomainVo domainObject, Map additionalParams) {
 		Session session = sessionFactory.getCurrentSession();
 		session.delete(domainObject);
 	}
 
 	@Override
-	public void deleteDomainObjects(Class domainClass, String whereClause, HashMap additionalParams) {
-		int rowsAffected = 0;
+	public void deleteDomainObjects(Class domainClass, String whereClause, Map additionalParams) {
 		Session session = sessionFactory.getCurrentSession();
-
 		StringBuffer sql = new StringBuffer("delete from ");
-
 		sql.append(domainClass.getName()).append(" where ").append(whereClause);
-
-		rowsAffected = session.createQuery(sql.toString()).executeUpdate();
-		/* return rowsAffected; */
+		Query query = session.createQuery(sql.toString());
+		query.executeUpdate();
 	}
 
 	@Override
-	public void saveDomainObject(DomainVo vo, HashMap additionalParams) {
+	public void saveDomainObject(DomainVo vo, Map additionalParams) {
 		Integer userId = 1;
 		if (additionalParams != null) {
-			// look for a passed user id
-			// userId = (Integer)additionalParams.get(Parameters.PARAM_USERID);
 			Object uid = additionalParams.get(Parameters.PARAM_USERID);
 			if (uid instanceof Integer) {
 				userId = (Integer) uid;
 			} else if (uid instanceof Long) {
 				userId = ((Long) uid).intValue();
 			}
-			// if (userId == null) {
-			// look for a passed request to get the user id from
-			// userId = new
-			// Integer(UserUtils.getUserId((HttpServletRequest)additionalParams.get(Parameters.PARAM_HTTP_REQUEST)));
-			// }
 		}
 		_update(vo, userId);
 	}
 
 	/**
-	 * Creates or updates the specified virtual object. Uses the specified user
-	 * ID as the creator and modifier if a new object is created; uses ID only
-	 * as modifier if an object already exists.
+	 * Creates or updates the specified virtual object. Uses the specified user ID
+	 * as the creator and modifier if a new object is created; uses ID only as
+	 * modifier if an object already exists.
 	 * 
 	 * @param vo
 	 * @param userId
@@ -178,7 +166,6 @@ public class DataAccessServiceImpl extends FusionService implements DataAccessSe
 	 */
 	private List getListCommon(Class domainClass, String filterClause, Integer fromIndex, Integer toIndex,
 			String orderBy) {
-		List list = null;
 		String className = domainClass.getName();
 		Session session = sessionFactory.getCurrentSession();
 
@@ -187,13 +174,12 @@ public class DataAccessServiceImpl extends FusionService implements DataAccessSe
 					+ ((fromIndex != null) ? " from rows " + fromIndex.toString() + " to " + toIndex.toString() : "")
 					+ "...");
 			if (filterClause != null && filterClause.length() > 0)
-			    logger.info(EELFLoggerDelegate.debugLogger, "Filtering " + className + " by: " + filterClause);
+				logger.info(EELFLoggerDelegate.debugLogger, "Filtering " + className + " by: " + filterClause);
 		}
 
-		list = session.createQuery("from " + className + Utilities.nvl(filterClause, "")
+		List list = session.createQuery("from " + className + Utilities.nvl(filterClause, "")
 				+ ((orderBy != null) ? " order by " + orderBy : "")).list();
 		list = (fromIndex != null) ? list.subList(fromIndex.intValue() - 1, toIndex.intValue()) : list;
-
 		if (orderBy == null && list != null)
 			Collections.sort(list);
 
@@ -201,18 +187,18 @@ public class DataAccessServiceImpl extends FusionService implements DataAccessSe
 	}
 
 	@Override
-	public List getList(Class domainClass, HashMap additionalParams) {
+	public List getList(Class domainClass, Map additionalParams) {
 		return getListCommon(domainClass, null, null, null, null);
 	}
 
 	@Override
-	public List getList(Class domainClass, String filter, String orderBy, HashMap additionalParams) {
+	public List getList(Class domainClass, String filter, String orderBy, Map additionalParams) {
 		return getListCommon(domainClass, filter, null, null, orderBy);
 	}
 
 	@Override
 	public List getList(Class domainClass, String filter, int fromIndex, int toIndex, String orderBy,
-			HashMap additionalParams) {
+			Map additionalParams) {
 		return getListCommon(domainClass, filter, new Integer(fromIndex), new Integer(toIndex), orderBy);
 	}
 
@@ -237,36 +223,28 @@ public class DataAccessServiceImpl extends FusionService implements DataAccessSe
 			for (Order order : orderByList)
 				criteria.addOrder(order);
 		}
-		/*
-		 * if(fetchModeMap!=null){ Iterator itr =
-		 * fetchModeMap.keySet().iterator(); String key=null;
-		 * while(itr.hasNext()){ key = itr.next();
-		 * criteria.setFetchMode(key,fetchModeMap.get(key)); } }
-		 */
+
 		return criteria.list();
 	}
 
 	@Override
 	public List getLookupList(String dbTable, String dbValueCol, String dbLabelCol, String dbFilter, String dbOrderBy,
-			HashMap additionalParams) {
+			Map additionalParams) {
 		if (logger.isInfoEnabled())
-		    logger.info(EELFLoggerDelegate.debugLogger, "Retrieving " + dbTable + " lookup list...");
+			logger.info(EELFLoggerDelegate.debugLogger, "Retrieving " + dbTable + " lookup list...");
 		String dbOrderByCol = dbOrderBy;
 
 		Session session = sessionFactory.getCurrentSession();
 
-		// default the orderBy if null;
+		// default the orderBy if null
 		if (Utilities.nvl(dbOrderBy).length() == 0) {
 			dbOrderByCol = dbLabelCol;
 			dbOrderBy = dbLabelCol;
-		} else {
-			if (dbOrderBy.lastIndexOf(" ") > -1) {
-				dbOrderByCol = dbOrderBy.substring(0, dbOrderBy.lastIndexOf(" "));
-			}
+		} else if (dbOrderBy.lastIndexOf(" ") > -1) {
+			dbOrderByCol = dbOrderBy.substring(0, dbOrderBy.lastIndexOf(" "));
 		}
 
-		StringBuffer sql = new StringBuffer();
-
+		StringBuilder sql = new StringBuilder();
 		sql.append("select distinct ").append(dbLabelCol).append(" as lab, ").append(dbValueCol).append(" as val, ")
 				.append(dbOrderByCol).append(" as sortOrder ").append("from ").append(dbTable).append(" ")
 				.append((Utilities.nvl(dbFilter).length() == 0) ? "" : (" where " + dbFilter)).append(" order by ")
@@ -276,7 +254,7 @@ public class DataAccessServiceImpl extends FusionService implements DataAccessSe
 		try {
 			list = session.createSQLQuery(sql.toString()).addEntity(Lookup.class).list();
 		} catch (Exception e) {
-			logger.error(EELFLoggerDelegate.debugLogger, "Failed to create SQL lookup query for [" + sql + "]" + e.getMessage());
+			logger.error(EELFLoggerDelegate.errorLogger, "getLookupList failed on query query [" + sql + "]", e);
 		}
 		return list;
 	}
@@ -287,13 +265,13 @@ public class DataAccessServiceImpl extends FusionService implements DataAccessSe
 	 */
 
 	@Override
-	public List executeSQLQuery(String sql, Class domainClass, HashMap additionalParams) {
+	public List executeSQLQuery(String sql, Class domainClass, Map additionalParams) {
 		return executeSQLQuery(sql, domainClass, null, null, additionalParams);
 	}
 
 	@Override
 	public List executeSQLQuery(String sql, Class domainClass, Integer fromIndex, Integer toIndex,
-			HashMap additionalParams) {
+			Map additionalParams) {
 		Session session = sessionFactory.getCurrentSession();
 
 		SQLQuery query = session.createSQLQuery(sql).addEntity(domainClass.getName().toLowerCase(), domainClass);
@@ -308,12 +286,12 @@ public class DataAccessServiceImpl extends FusionService implements DataAccessSe
 	}
 
 	@Override
-	public List executeQuery(String sql, HashMap additionalParams) {
+	public List executeQuery(String sql, Map additionalParams) {
 		return executeQuery(sql, null, null, additionalParams);
 	}
 
 	@Override
-	public List executeQuery(String sql, Integer fromIndex, Integer toIndex, HashMap additionalParams) {
+	public List executeQuery(String sql, Integer fromIndex, Integer toIndex, Map additionalParams) {
 		Session session = sessionFactory.getCurrentSession();
 
 		Query query = session.createQuery(sql);
@@ -328,18 +306,18 @@ public class DataAccessServiceImpl extends FusionService implements DataAccessSe
 	}
 
 	@Override
-	public List executeNamedQuery(String queryName, Integer fromIndex, Integer toIndex, HashMap additionalParams) {
+	public List executeNamedQuery(String queryName, Integer fromIndex, Integer toIndex, Map additionalParams) {
 		return executeNamedQuery(queryName, null, fromIndex, toIndex, additionalParams);
 	}
 
 	@Override
-	public List executeNamedQuery(String queryName, Map params, HashMap additionalParams) {
+	public List executeNamedQuery(String queryName, Map params, Map additionalParams) {
 		return executeNamedQuery(queryName, params, null, null, additionalParams);
 	}
 
 	@Override
 	public List executeNamedQuery(String queryName, Map params, Integer fromIndex, Integer toIndex,
-			HashMap additionalParams) {
+			Map additionalParams) {
 		Session session = sessionFactory.getCurrentSession();
 		Query query = session.getNamedQuery(queryName);
 		bindQueryParameters(query, params);
@@ -364,15 +342,16 @@ public class DataAccessServiceImpl extends FusionService implements DataAccessSe
 		if (params != null) {
 			for (Iterator i = params.entrySet().iterator(); i.hasNext();) {
 				Map.Entry entry = (Map.Entry) i.next();
-
 				Object parameterValue = entry.getValue();
-
 				if (!(parameterValue instanceof Collection) && !(parameterValue instanceof Object[])) {
 					query.setParameter((String) entry.getKey(), parameterValue);
 				} else if (parameterValue instanceof Collection) {
 					query.setParameterList((String) entry.getKey(), (Collection) parameterValue);
 				} else if (parameterValue instanceof Object[]) {
 					query.setParameterList((String) entry.getKey(), (Object[]) parameterValue);
+				} else {
+					logger.error(EELFLoggerDelegate.errorLogger, "bindQueryParameters: no match for value {}",
+							parameterValue);
 				}
 			}
 		}
@@ -381,62 +360,55 @@ public class DataAccessServiceImpl extends FusionService implements DataAccessSe
 	// With Where Clause & RAPTOR's ZK
 
 	@Override
-	public List executeNamedQueryWithOrderBy(Class entity, String queryName, Map params, String _orderBy, boolean asc,
-			Integer fromIndex, Integer toIndex, HashMap additionalParams) {
-		// TODO Auto-generated method stub
-		logger.info(EELFLoggerDelegate.debugLogger, "Not implemented");
-		return null;
+	public List executeNamedQueryWithOrderBy(Class entity, String queryName, Map params, String orderBy, boolean asc,
+			Integer fromIndex, Integer toIndex, Map additionalParams) {
+		logger.error(EELFLoggerDelegate.errorLogger, "Not implemented");
+		throw new UnsupportedOperationException();
 	}
 
 	@Override
 	public List executeNamedCountQuery(Class entity, String queryName, String whereClause, Map params) {
-		// TODO Auto-generated method stub
-		logger.info(EELFLoggerDelegate.debugLogger, "Not implemented");
-		return null;
+		logger.error(EELFLoggerDelegate.errorLogger, "Not implemented");
+		throw new UnsupportedOperationException();
 	}
 
 	@Override
 	public List executeNamedQuery(Class entity, String queryName, String whereClause, Map params, Integer fromIndex,
-			Integer toIndex, HashMap additionalParams) {
-		// TODO Auto-generated method stub
-		logger.info(EELFLoggerDelegate.debugLogger, "Not implemented");
-		return null;
+			Integer toIndex, Map additionalParams) {
+		logger.error(EELFLoggerDelegate.errorLogger, "Not implemented");
+		throw new UnsupportedOperationException();
 	}
 
 	@Override
 	public List executeNamedQueryWithOrderBy(Class entity, String queryName, String whereClause, Map params,
-			String _orderBy, boolean asc, Integer fromIndex, Integer toIndex, HashMap additionalParams) {
-		// TODO Auto-generated method stub
-		logger.info(EELFLoggerDelegate.debugLogger, "Not implemented");
-		return null;
+			String orderBy, boolean asc, Integer fromIndex, Integer toIndex, Map additionalParams) {
+		logger.error(EELFLoggerDelegate.errorLogger, "Not implemented");
+		throw new UnsupportedOperationException();
 	}
 
 	@Override
 	public List getList(Class domainClass, ProjectionList projectionsList, List restrictionsList,
-			List orderByList, HashMap fetchModeMap) {
-		// TODO Auto-generated method stub
-		logger.info(EELFLoggerDelegate.debugLogger, "Not implemented");
-		return null;
+			List orderByList, Map fetchModeMap) {
+		logger.error(EELFLoggerDelegate.errorLogger, "Not implemented");
+		throw new UnsupportedOperationException();
 	}
 
 	@Override
-	public int executeUpdateQuery(String sql, HashMap additionalParams) throws RuntimeException {
-		// TODO Auto-generated method stub
-		logger.info(EELFLoggerDelegate.debugLogger, "Not implemented");
-		return 0;
+	public int executeUpdateQuery(String sql, Map additionalParams) {
+		logger.error(EELFLoggerDelegate.errorLogger, "Not implemented");
+		throw new UnsupportedOperationException();
 	}
 
 	@Override
-	public int executeNamedUpdateQuery(String queryName, Map params, HashMap additionalParams) throws RuntimeException {
-		// TODO Auto-generated method stub
-		logger.info(EELFLoggerDelegate.debugLogger, "Not implemented");
-		return 0;
+	public int executeNamedUpdateQuery(String queryName, Map params, Map additionalParams) {
+		logger.error(EELFLoggerDelegate.errorLogger, "Not implemented");
+		throw new UnsupportedOperationException();
 	}
 
 	@Override
-	public void synchronize(HashMap additionalParams) {
-		// TODO Auto-generated method stub
-		logger.info(EELFLoggerDelegate.debugLogger, "Not implemented");
+	public void synchronize(Map additionalParams) {
+		logger.error(EELFLoggerDelegate.errorLogger, "Not implemented");
+		throw new UnsupportedOperationException();
 	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/ElementLinkService.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/ElementLinkService.java
index d9c25377..e096d832 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/ElementLinkService.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/ElementLinkService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -44,22 +44,25 @@ import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
+import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
 import org.onap.portalsdk.core.util.SystemProperties;
 import org.onap.portalsdk.core.util.YamlUtils;
 
 public class ElementLinkService {
 
+	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(ElementLinkService.class);
+
 	/**
 	 * Builds renderable model of element links in the network map. Parses YAML
-	 * files with metadata and builds input for JoinJS to render in the browser
-	 * as SVG.
+	 * files with metadata and builds input for JoinJS to render in the browser as
+	 * SVG.
 	 *
 	 * @param args
 	 *            arg 0 - realPath; arg 1 - callFlowName; arg 2 - callFlowStep.
 	 * @return Renderable model of element links
-	 * @throws Exception
+	 * @throws IOException
 	 */
-	public String buildElementLinkYaml(String[] args) throws Exception {
+	public String buildElementLinkYaml(String[] args) throws IOException {
 		String relFilePath;
 		if (args[1].startsWith("custom"))
 			relFilePath = SystemProperties.getProperty("customCallFlow_path");
@@ -82,69 +85,26 @@ public class ElementLinkService {
 		return linkYaml;
 	}
 
-	/*
-	 * public String main2(String[] args) throws Exception {
-	 * 
-	 * String filePath = SystemProperties.getProperty("element_map_file_path") +
-	 * File.separator; String callFlowBusinessYml = ""; String callFlowStep =
-	 * "";
-	 * 
-	 * if (args != null && args.length > 0) {
-	 * 
-	 * if (args[0] != null) { callFlowBusinessYml = args[0] + "-Override.yml"; }
-	 * 
-	 * if (args[1] != null) { callFlowStep = args[1]; } }
-	 * 
-	 * ElementLinkService mapper = new ElementLinkService();
-	 * 
-	 * return mapper.createLinkFileAdditional(filePath, callFlowBusinessYml,
-	 * callFlowStep); }
-	 */
-
-	public static void main(String[] args) throws Exception {
-
-		String filePath = "\\D2Platform\\war\\WEB-INF\\resources\\trisim_files";
-		String callFlowBusinessYml = "call_flow_hc-origination-termination-to-volteue-3.3.16-Override.yml";
-
-		ElementLinkService mapper = new ElementLinkService();
-
-		// System.out.print(mapper.createLinkFile(filePath, networkToscaYml,
-		// networkToscaUeYml, networkLayoutYml, callFlowBusinessYml,"Step_1"));
-		System.out.print(mapper.createLinkFileAdditional(filePath, callFlowBusinessYml, "Step_2"));
-	}
-
 	@SuppressWarnings("unchecked")
 	protected String createLinkFile(String resourceFilePath, String callFLowBsFileName, String callFlowStep)
-			throws Exception {
-
+			throws IOException {
 		Map callFlowBs = YamlUtils.readYamlFile(resourceFilePath, callFLowBsFileName);
-
 		List> callSteps = (List>) callFlowBs.get("callSequenceSteps");
 		String callFlowName = (String) callFlowBs.get("shortName");
 		return addLinks(resourceFilePath, callFlowName, callSteps, callFlowStep);
-
 	}
 
 	@SuppressWarnings("unchecked")
 	protected String createLinkFileAdditional(String resourceFilePath, String callFLowBsFileName, String callFlowStep)
 			throws Exception {
-
-		// Map callFlowBs =
-		// YamlUtils.readYamlFile(resourceFilePath, callFLowBsFileName);
-
-		// return YamlUtils.returnYaml(callFlowBs);
-
 		Map callFlowBs;
-
 		try {
 			callFlowBs = YamlUtils.readYamlFile(resourceFilePath, callFLowBsFileName);
-
 			List> callSteps = (List>) callFlowBs.get("callSequenceSteps");
 			String callFlowName = (String) callFlowBs.get("shortName");
 			return addLinksAdditional(resourceFilePath, callFlowName, callSteps, callFlowStep);
-
 		} catch (Exception e) {
-
+			logger.error(EELFLoggerDelegate.errorLogger, "createLinkFileAdditional failed", e);
 			return "";
 		}
 
@@ -154,22 +114,18 @@ public class ElementLinkService {
 	protected String addLinks(String filePath, String callFlowName, List> callSteps,
 			String callFlowStep) throws IOException {
 
-		Map> checkDuplicateMap = new HashMap>();
+		Map> checkDuplicateMap = new HashMap<>();
 
 		for (Map callStep : callSteps) {
 
 			if (((String) callStep.get("name")).split(":")[0].trim().replace(" ", "_").equals(callFlowStep)) {
 
-				// String callFlowStepName = callFlowName + "_" +
-				// ((String)callStep.get("name")).split("-")[0].trim().replace("
-				// ", "_")+".yml";
-
-				List> links = new ArrayList>();
+				List> links = new ArrayList<>();
 
 				List> subSteps = (List>) callStep.get("subSteps");
 
 				for (Map subStep : subSteps) {
-					Map link = new HashMap();
+					Map link = new HashMap<>();
 
 					String source = (String) subStep.get("source_tosca_id");
 					String destination = (String) subStep.get("destination_tosca_id");
@@ -177,12 +133,12 @@ public class ElementLinkService {
 					if ((checkDuplicateMap.get(source) == null || checkDuplicateMap.get(source).isEmpty()
 							|| !checkDuplicateMap.get(source).contains(destination)) && !source.equals(destination)) {
 						if (checkDuplicateMap.get(destination) == null) {
-							List toscaList = new ArrayList();
+							List toscaList = new ArrayList<>();
 							checkDuplicateMap.put(destination, toscaList);
 						}
 
 						if (checkDuplicateMap.get(source) == null) {
-							List toscaList = new ArrayList();
+							List toscaList = new ArrayList<>();
 							checkDuplicateMap.put(source, toscaList);
 						}
 
@@ -195,30 +151,14 @@ public class ElementLinkService {
 						link.put("s", source);
 						link.put("d", destination);
 						links.add(link);
-
-						/*
-						 * may be needed in future but nnot currently
-						 * 
-						 * if((String) subStep.get("link_visibility")!=null){
-						 * if(((String)
-						 * subStep.get("link_visibility")).equals("No")){
-						 * 
-						 * } }else{
-						 * 
-						 * links.add(link); }
-						 */
-
 					}
 
 				}
 
-				Map callFlowUI = new HashMap();
+				Map callFlowUI = new HashMap<>();
 				callFlowUI.put("linkList", links);
 
 				return YamlUtils.returnYaml(callFlowUI);
-
-				// YamlUtils.writeYamlFile(filePath, callFlowStepName,
-				// callFlowUI);
 			}
 
 		}
@@ -232,25 +172,24 @@ public class ElementLinkService {
 
 			if (((String) callStep.get("name")).split(":")[0].trim().replace(" ", "_").equals(callFlowStep)) {
 
-				// String callFlowStepName = callFlowName + "_" +
-				// ((String)callStep.get("name")).split("-")[0].trim().replace("
-				// ", "_")+".yml";
-
-				Map callFlowUI = new HashMap();
+				Map callFlowUI = new HashMap<>();
 				try {
 					List> links = addLinkVertices(callStep);
 					callFlowUI.put("linkList", links);
 				} catch (Exception e) {
+					logger.error(EELFLoggerDelegate.errorLogger, "addLinksAdditional failed", e);
 				}
 				try {
 					List activeIds = addActiveNodes(callStep);
 					callFlowUI.put("activeIds", activeIds);
 				} catch (Exception e) {
+					logger.error(EELFLoggerDelegate.errorLogger, "addLinksAdditional failed", e);
 				}
 				try {
 					List> disconnectLinks = addDisconnectLinks(callStep);
 					callFlowUI.put("disconnectLinks", disconnectLinks);
 				} catch (Exception e) {
+					logger.error(EELFLoggerDelegate.errorLogger, "addLinksAdditional failed", e);
 				}
 
 				return YamlUtils.returnYaml(callFlowUI);
@@ -274,13 +213,13 @@ public class ElementLinkService {
 
 	@SuppressWarnings("unchecked")
 	List> addLinkVertices(Map callStep) {
-		List> links = new ArrayList>();
+		List> links = new ArrayList<>();
 
 		List> vertices = (List>) callStep.get("vertices");
 
 		for (int i = 0; i < vertices.size() - 1; i++) {
-			Map vertex = (Map) vertices.get(i);
-			Map vertexNext = (Map) vertices.get(i + 1);
+			Map vertex = vertices.get(i);
+			Map vertexNext = vertices.get(i + 1);
 
 			Integer sourceX = (Integer) vertex.get("x");
 			Integer sourceY = (Integer) vertex.get("y");
@@ -297,7 +236,7 @@ public class ElementLinkService {
 			if (destinationX == -999) // there is a break in the linkage
 				continue;
 
-			Map link = new HashMap();
+			Map link = new HashMap<>();
 
 			link.put("s", sourceX + "," + sourceY + "," + sourceD + "," + sourceL);
 			link.put("d", destinationX + "," + destinationY + "," + destinationD);
@@ -305,4 +244,12 @@ public class ElementLinkService {
 		}
 		return links;
 	}
+
+	public static void main(String[] args) throws Exception {
+		String filePath = "\\D2Platform\\war\\WEB-INF\\resources\\trisim_files";
+		String callFlowBusinessYml = "call_flow_hc-origination-termination-to-volteue-3.3.16-Override.yml";
+		ElementLinkService mapper = new ElementLinkService();
+		System.out.print(mapper.createLinkFileAdditional(filePath, callFlowBusinessYml, "Step_2"));
+	}
+
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/ElementMapService.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/ElementMapService.java
index 2c89dccd..d24bd503 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/ElementMapService.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/ElementMapService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -38,6 +38,7 @@
 package org.onap.portalsdk.core.service;
 
 import java.io.File;
+import java.io.IOException;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.HashSet;
@@ -63,28 +64,39 @@ public class ElementMapService {
 
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(ElementMapService.class);
 
+	private static HashMap toscaElementsMap = new HashMap<>();
+	private static HashMap elementMap = new HashMap<>();
+	private static HashMap miscElementMap = new HashMap<>();
+	private static HashMap outercontainers = new HashMap<>();
+	private static HashMap innercontainers = new HashMap<>();
+	private static HashMap domainMap = new HashMap<>();
+
+	private static String filePath = SystemProperties.getProperty("element_map_file_path");
+	private static String networkToscaYml = null;// "NetworkMap_topology_composition.yml";
+	private static String networkLayoutYml = null;// "network_map_layout.yml";
+
 	/**
 	 * 
 	 * @param contextRealPath
 	 * @param layout
 	 * @return
-	 * @throws Exception
+	 * @throws IOException
 	 */
-	private String convertToYAML(String contextRealPath, Layout layout) throws Exception {
+	private String convertToYAML(String contextRealPath, Layout layout) throws IOException {
 
 		// Used to build image file relative URLs
-		final String iconRelPath = SystemProperties.getProperty("element_map_icon_path"); // "static/img/map/icons/";
+		final String iconRelPath = SystemProperties.getProperty("element_map_icon_path");
 
-		Map resultAICDomain = layout.domainRowCol;
-		Map> domainMap = new HashMap>();
-		List domainList = new ArrayList();
+		Map resultAICDomain = layout.getDomainRowCol();
+		Map> domainMap = new HashMap<>();
+		List domainList = new ArrayList<>();
 		for (Domain d : resultAICDomain.values()) {
 			d.setWidth(10 * d.computeSize().getWidth());
 			d.setHeight(10 * d.computeSize().getHeight());
 			d.setLeft(10 * d.getP().getX());
 			d.setTop(10 * d.getP().getY());
 
-			List containerList = new ArrayList();
+			List containerList = new ArrayList<>();
 			for (Container c : d.getContainerRowCol().values()) {
 				c.setWidth(10 * c.computeSize().getWidth());
 				c.setHeight(10 * c.computeSize().getHeight());
@@ -97,7 +109,7 @@ public class ElementMapService {
 				}
 
 				if (c.getContainerRowCol() != null) {
-					List innerContainerList = new ArrayList();
+					List innerContainerList = new ArrayList<>();
 					for (Container innerC : c.getContainerRowCol().values()) {
 						innerC.setName(innerC.getName());
 						innerC.setWidth(10 * innerC.computeSize().getWidth());
@@ -106,9 +118,8 @@ public class ElementMapService {
 						innerC.setTop(10 * innerC.getP().getY());
 
 						if (innerC.getElementRowCol() != null) {
-							List innerContainerEList = new ArrayList();
+							List innerContainerEList = new ArrayList<>();
 							for (Element ele : innerC.getElementRowCol().values()) {
-								// ele.setName(ele.getName());
 								ele.setWidth(10 * ele.computeSize().getWidth());
 								ele.setHeight(10 * ele.computeSize().getHeight());
 								ele.setLeft(10 * ele.getP().getX());
@@ -128,9 +139,8 @@ public class ElementMapService {
 				}
 
 				if (c.getElementRowCol() != null) {
-					List elementList = new ArrayList();
+					List elementList = new ArrayList<>();
 					for (Element e : c.getElementRowCol().values()) {
-						// e.setName(e.getName());
 						e.setWidth(10 * e.computeSize().getWidth());
 						e.setHeight(10 * e.computeSize().getHeight());
 						e.setLeft(10 * e.getP().getX());
@@ -157,7 +167,7 @@ public class ElementMapService {
 		}
 		domainMap.put("domainList", domainList);
 
-		List collapsedDomains = new ArrayList();
+		List collapsedDomains = new ArrayList<>();
 
 		// nline
 		for (Domain collapsed : layout.getCollapsedDomainsNewList()) {
@@ -183,30 +193,17 @@ public class ElementMapService {
 
 	}
 
-	private static HashMap toscaElementsMap = new HashMap();
-	private static HashMap elementMap = new HashMap();
-	private static HashMap miscElementMap = new HashMap();
-	private static HashMap outercontainers = new HashMap();
-	private static HashMap innercontainers = new HashMap();
-	private static HashMap domainMap = new HashMap();
-
-	private static String filePath = SystemProperties.getProperty("element_map_file_path");
-	private static String networkToscaYml = null;// "NetworkMap_topology_composition.yml";
-	private static String networkLayoutYml = null;// "network_map_layout.yml";
-
 	/**
 	 * Builds renderable model of elements in the network map. Parses YAML files
-	 * with metadata and builds input for JoinJS to render in the browser as
-	 * SVG.
+	 * with metadata and builds input for JoinJS to render in the browser as SVG.
 	 * 
 	 * @param args
-	 *            arg 0 - collapsedDomains; arg 1 - expandedDomains; arg 2 -
-	 *            context real path; arg 3 - contentFileName; arg 4 -
-	 *            layoutFileName
+	 *            arg 0 - collapsedDomains; arg 1 - expandedDomains; arg 2 - context
+	 *            real path; arg 3 - contentFileName; arg 4 - layoutFileName
 	 * @return Renderable model of elements
-	 * @throws Exception
+	 * @throws IOException
 	 */
-	public String buildElementMapYaml(String args[]) throws Exception {
+	public String buildElementMapYaml(String args[]) throws IOException {
 
 		final String yamlDirPath = new File(args[2], filePath).getPath();
 		if (args != null && args.length > 4) {
@@ -219,12 +216,12 @@ public class ElementMapService {
 		Map toscaYaml = YamlUtils.readYamlFile(yamlDirPath, networkToscaYml);
 		Map networkMapLayoutYaml = YamlUtils.readYamlFile(yamlDirPath, networkLayoutYml);
 
-		toscaElementsMap = new HashMap();
-		elementMap = new HashMap();
-		domainMap = new HashMap();
-		outercontainers = new HashMap();
-		innercontainers = new HashMap();
-		miscElementMap = new HashMap();
+		toscaElementsMap = new HashMap<>();
+		elementMap = new HashMap<>();
+		domainMap = new HashMap<>();
+		outercontainers = new HashMap<>();
+		innercontainers = new HashMap<>();
+		miscElementMap = new HashMap<>();
 
 		if (toscaYaml != null) {
 			for (String key : toscaYaml.keySet()) {
@@ -238,12 +235,6 @@ public class ElementMapService {
 
 							toscaElementsMap = (HashMap) toscaTopologyDetails.get(detailsKey);
 
-							// for (String toscaElementKey :
-							// toscaElementsMap.keySet()) {
-							//// System.out.println("Element - "+ "key :" +
-							//// toscaElementKey);
-							// }
-
 						}
 					}
 				}
@@ -267,8 +258,6 @@ public class ElementMapService {
 
 				if (elementlist != null) {
 					for (Object eachElement : elementlist) {
-						// System.out.println("toscaNetworkMapElementStyleList
-						// Container : " +eachElement);
 						if (eachElement != null && eachElement instanceof HashMap) {
 							HashMap elementDetails = (HashMap) eachElement;
 							if (elementDetails != null) {
@@ -279,7 +268,7 @@ public class ElementMapService {
 								column = "0";
 								for (String detailsKey : elementDetails.keySet()) {
 									if ("tosca_id".equalsIgnoreCase(detailsKey))
-										elementName = elementDetails.get(detailsKey).toString();
+										elementName = elementDetails.get(detailsKey);
 									if ("id".equalsIgnoreCase(detailsKey)) {
 										elementID = String.valueOf(elementDetails.get(detailsKey));
 									}
@@ -290,7 +279,7 @@ public class ElementMapService {
 										column = String.valueOf(elementDetails.get(detailsKey));
 									}
 									if ("icon".equalsIgnoreCase(detailsKey))
-										imgPath = elementDetails.get(detailsKey).toString();
+										imgPath = elementDetails.get(detailsKey);
 								}
 
 								if (elementMap.containsKey(elementName.concat("/").concat(row).concat(column))) {
@@ -313,12 +302,11 @@ public class ElementMapService {
 
 				for (String elementkey : elementMap.keySet()) {
 					Element c = (Element) elementMap.get(elementkey);
-					// System.out.println("Element - "+ "key :" +elementkey +" -
-					// " + "value :" + c.getName());
+					logger.trace(EELFLoggerDelegate.debugLogger, "buildElementMapYaml: element {}", c);
 				}
 
 				if (!elementMap.isEmpty()) {
-					miscElementMap = new HashMap(elementMap);
+					miscElementMap = new HashMap<>(elementMap);
 				}
 			}
 
@@ -349,12 +337,12 @@ public class ElementMapService {
 
 								for (String detailsKey : containerDetails.keySet()) {
 									if ("logical_group_name".equalsIgnoreCase(detailsKey))
-										containerName = containerDetails.get(detailsKey).toString();
+										containerName = containerDetails.get(detailsKey);
 									if ("id".equalsIgnoreCase(detailsKey)) {
 										containerID = String.valueOf(containerDetails.get(detailsKey));
 									}
 									if ("domain".equalsIgnoreCase(detailsKey)) {
-										domain = containerDetails.get(detailsKey).toString();
+										domain = containerDetails.get(detailsKey);
 									}
 									if ("row".equalsIgnoreCase(detailsKey)) {
 										row = String.valueOf(containerDetails.get(detailsKey));
@@ -401,12 +389,12 @@ public class ElementMapService {
 
 								for (String detailsKey : containerDetails.keySet()) {
 									if ("logical_group_name".equalsIgnoreCase(detailsKey))
-										containerName = containerDetails.get(detailsKey).toString();
+										containerName = containerDetails.get(detailsKey);
 									if ("id".equalsIgnoreCase(detailsKey)) {
 										containerID = String.valueOf(containerDetails.get(detailsKey));
 									}
 									if ("domain".equalsIgnoreCase(detailsKey)) {
-										domain = containerDetails.get(detailsKey).toString();
+										domain = containerDetails.get(detailsKey);
 									}
 									if ("row".equalsIgnoreCase(detailsKey)) {
 										row = String.valueOf(containerDetails.get(detailsKey));
@@ -430,9 +418,6 @@ public class ElementMapService {
 									outercontainers.put(mapKey, fetchContainerObject(containerID, containerName, false,
 											containerName, domain));
 								}
-								// else innercontainers.put(domain +":"+
-								// containerName,
-								// fetchContainerObject(containerID,containerName.substring(containerName.indexOf("/")+1),false,containerName,domain));
 
 							}
 						}
@@ -442,10 +427,12 @@ public class ElementMapService {
 
 				for (String innerContainerkey : innercontainers.keySet()) {
 					Container c = (Container) innercontainers.get(innerContainerkey);
+					logger.trace(EELFLoggerDelegate.debugLogger, "buildElementMapYaml: inner container {}", c);
 				}
 
 				for (String outerContainerkey : outercontainers.keySet()) {
 					Container c = (Container) outercontainers.get(outerContainerkey);
+					logger.trace(EELFLoggerDelegate.debugLogger, "buildElementMapYaml: outer container {}", c);
 				}
 
 			}
@@ -463,10 +450,8 @@ public class ElementMapService {
 
 				if (domainlist != null) {
 
-					HashMap domainStagingMap = new HashMap();
+					HashMap domainStagingMap = new HashMap<>();
 					for (Object eachDomain : domainlist) {
-						// System.out.println("domainlist Container : "
-						// +eachDomain);
 						if (eachDomain != null && eachDomain instanceof HashMap) {
 							HashMap domainDetails = (HashMap) eachDomain;
 							if (domainDetails != null) {
@@ -476,7 +461,7 @@ public class ElementMapService {
 								column = "0";
 								for (String detailsKey : domainDetails.keySet()) {
 									if ("name".equalsIgnoreCase(detailsKey))
-										domainName = domainDetails.get(detailsKey).toString();
+										domainName = domainDetails.get(detailsKey);
 									if ("id".equalsIgnoreCase(detailsKey)) {
 										domainID = String.valueOf(domainDetails.get(detailsKey));
 									}
@@ -510,11 +495,6 @@ public class ElementMapService {
 					}
 				}
 
-				// for (String domainkey : domainMap.keySet()) {
-				// Domain c = (Domain) domainMap.get(domainkey);
-				// System.out.println("Domain - "+ "key :" +domainkey +" - "
-				// + "value :" + c.getName());
-				// }
 			}
 
 		}
@@ -522,35 +502,20 @@ public class ElementMapService {
 		Layout dynamicLayout = new Layout(domainMap, 2, 10, 1, 5);
 		dynamicLayout.computeDomainPositionsModified();
 
-		/*
-		 * Map resultAICDomain2 = dynamicLayout.domainRowCol;
-		 * for (String key : resultAICDomain2.keySet()) { if
-		 * (resultAICDomain2.get(key).getP() != null) {
-		 * System.out.println(resultAICDomain2.get(key).name+" "+"x:"+
-		 * resultAICDomain2.get(key).getP().getX()+","+"y:"+
-		 * resultAICDomain2.get(key).getP().getY()+","+"width:"+
-		 * resultAICDomain2.get(key).computeSize().getWidth()
-		 * +","+"height:"+resultAICDomain2.get(key).computeSize(). getHeight());
-		 * 
-		 * } }
-		 */
-
 		ElementMapService cm2 = new ElementMapService();
 		try {
 
 			if (args != null && args.length > 0) {
 
 				if (args[0] != null) {
-					String collapsedDomains[] = args[0].split(",");
+					String[] collapsedDomains = args[0].split(",");
 					for (String collapsedDomain : collapsedDomains)
-						// dynamicLayout.collapseDomainModified(collapsedDomain);
 						dynamicLayout.collapseDomainNew(collapsedDomain);
 				}
 
 				if (args[1] != null) {
-					String expandedDomains[] = args[1].split(",");
+					String[] expandedDomains = args[1].split(",");
 					for (String expandedDomain : expandedDomains)
-						// dynamicLayout.uncollapseDomainNew(expandedDomain);
 						dynamicLayout.uncollapseDomainNew1(expandedDomain);
 				}
 
@@ -605,7 +570,7 @@ public class ElementMapService {
 
 	private static Container fetchContainerObject(String id, String name, boolean isInner, String logicalGroupName,
 			String domain) {
-		Map containerElementsMap = new HashMap();
+		Map containerElementsMap = new HashMap<>();
 
 		containerElementsMap = fetchElementsMapForContainer(name, isInner, logicalGroupName, domain);
 		int rows = 1;
@@ -620,7 +585,6 @@ public class ElementMapService {
 
 			Container thisContainer = new Container(id, name, rows, columns, 1, 4, 8, 12, 1, 2);
 			thisContainer.setElements(containerElementsMap);
-			// thisContainer.setVisibilityType("");
 
 			return thisContainer;
 		} else {
@@ -629,7 +593,7 @@ public class ElementMapService {
 
 			if (innerContainersMap != null && !innerContainersMap.isEmpty()) {
 				if (containerElementsMap != null && !containerElementsMap.isEmpty()) {
-					Set keys = new HashSet(innerContainersMap.keySet());
+					Set keys = new HashSet<>(innerContainersMap.keySet());
 					keys.addAll(containerElementsMap.keySet());
 					rows = computeRows(keys);
 					columns = computeColumns(keys);
@@ -648,8 +612,7 @@ public class ElementMapService {
 
 			if (containerElementsMap != null && !containerElementsMap.isEmpty()) {
 				for (Element thisElement : containerElementsMap.values()) {
-					if (thisElement.getId() != null
-							) {
+					if (thisElement.getId() != null) {
 						thisContainer.setVisibilityType("invisible");
 					}
 				}
@@ -660,7 +623,7 @@ public class ElementMapService {
 	}
 
 	private static Domain fetchDomainObject(String id, String name) {
-		HashMap domainContainersMap = fetchContainersForDomain(name);
+		Map domainContainersMap = fetchContainersForDomain(name);
 
 		int rows = 1;
 		int columns = 1;
@@ -671,31 +634,25 @@ public class ElementMapService {
 
 		double domainWidth = 11;
 		Domain thisDomain;
-
 		if (domainMap != null && !domainMap.isEmpty()) {
 			int domainsCountSoFar = domainMap.size();
 			switch (domainsCountSoFar) {
-			case 1: {
+			case 1:
 				domainWidth = 12.1;
 				break;
-			}
-			case 2: {
+			case 2:
 				domainWidth = 13.3;
 				break;
-			}
-			case 3: {
+			case 3:
 				domainWidth = 14.5;
 				break;
-			}
-			case 4: {
+			case 4:
 				domainWidth = 15.6;
 				break;
-			}
-			default: {
+			default:
 				domainWidth = 11;
 				break;
 			}
-			}
 
 			for (String domainsKey : new TreeSet(domainMap.keySet())) {
 				Domain eachDomain = domainMap.get(domainsKey);
@@ -707,8 +664,6 @@ public class ElementMapService {
 			thisDomain = new Domain(id, name, 2, 1, 11, 10, 3, rows, columns);
 		}
 
-		// Domain thisDomain = new Domain(id, name, 2, 1, leftPosition, 10, 3,
-		// rows, columns);
 		thisDomain.setContainers(domainContainersMap);
 
 		thisDomain.computeConatinerPositions();
@@ -716,42 +671,18 @@ public class ElementMapService {
 			for (Container thisContainer : domainContainersMap.values()) {
 				thisContainer.computeSize();
 				thisContainer.computeElementPositions();
-				Map resultElementMap = thisContainer.elementRowCol;
+				Map resultElementMap = thisContainer.getElementRowCol();
 				for (String key : resultElementMap.keySet()) {
 					if (resultElementMap.get(key) == null || resultElementMap.get(key).getP() == null) {
-						// System.out.println("culprit " +key);
+						logger.debug(EELFLoggerDelegate.debugLogger, "fetchDomainObject: {}", key);
 					}
-					/*
-					 * System.out.println(resultElementMap.get(key).name+" "
-					 * +"x:"+resultElementMap.get(key).getP().getX()+","+"y:"+
-					 * resultElementMap.get(key).getP().getY()+","+"width:"+
-					 * resultElementMap.get(key).computeSize().getWidth()
-					 * +","+"height:"+resultElementMap.get(key).computeSize().
-					 * getHeight());
-					 */
-
 				}
 
 				HashMap innerContainersMap = (HashMap) thisContainer
 						.getContainerRowCol();
 				if (innerContainersMap != null && !innerContainersMap.isEmpty()) {
 					for (Container thisInnerContainer : innerContainersMap.values()) {
-						// thisInnerContainer.computeSize();
 						thisInnerContainer.computeElementPositions();
-						/*
-						 * Map resultInnerElementMap =
-						 * thisContainer.elementRowCol; for (String key :
-						 * resultElementMap.keySet()) { //
-						 * System.out.println(resultElementMap.get(key).name+" "
-						 * +"x:"+resultElementMap.get(key).getP().getX()+","+
-						 * "y:"+
-						 * resultElementMap.get(key).getP().getY()+","+"width:"+
-						 * resultElementMap.get(key).computeSize().getWidth()
-						 * +","+"height:"+resultElementMap.get(key).computeSize(
-						 * ).getHeight());
-						 * 
-						 * }
-						 */
 					}
 				}
 			}
@@ -760,29 +691,12 @@ public class ElementMapService {
 		return thisDomain;
 	}
 
-	private static HashMap fetchContainersForDomain(String domain) {
-		HashMap domainContainersMap = new HashMap();
-
-		domainContainersMap = fetchFromOuterContainers(domain);
-
+	private static Map fetchContainersForDomain(String domain) {
+		Map domainContainersMap = fetchFromOuterContainers(domain);
 		return domainContainersMap;
-
 	}
 
 	private static Element fetchElementObject(String id, String name, String imgPath) {
-		String bgColor = "bgColor";
-		String logical_group;
-		String display_longname;
-		String display_shortname;
-		String description;
-		String primary_function;
-		String key_interfaces;
-		String location;
-		String vendor;
-		String vendor_shortname;
-		String enclosingContainer;
-		String borderType;
-		String network_function;
 
 		if (toscaElementsMap.containsKey(name)) {
 
@@ -791,35 +705,33 @@ public class ElementMapService {
 
 				for (String detailsKey : toscaElementDetails.keySet()) {
 					if ("properties".equalsIgnoreCase(detailsKey)
-							&& toscaElementDetails.get(detailsKey) instanceof HashMap) {
-						HashMap elementDetails = (HashMap) toscaElementDetails
-								.get(detailsKey);
+							&& toscaElementDetails.get(detailsKey) instanceof Map) {
+						Map elementDetails = (Map) toscaElementDetails.get(detailsKey);
 
 						if (elementDetails != null) {
-							logical_group = elementDetails.get("logical_group") == null ? ""
-									: elementDetails.get("logical_group").toString();
-							display_longname = elementDetails.get("display_longname") == null ? ""
-									: elementDetails.get("display_longname").toString();
-							display_shortname = elementDetails.get("display_shortname") == null ? ""
-									: elementDetails.get("display_shortname").toString();
-							description = elementDetails.get("description") == null ? ""
-									: elementDetails.get("description").toString();
-							primary_function = elementDetails.get("primary_function") == null ? ""
-									: elementDetails.get("primary_function").toString();
-							key_interfaces = elementDetails.get("key_interfaces") == null ? ""
-									: elementDetails.get("key_interfaces").toString();
-							location = elementDetails.get("location") == null ? ""
-									: elementDetails.get("location").toString();
-							vendor = elementDetails.get("vendor") == null ? ""
-									: elementDetails.get("vendor").toString();
-							vendor_shortname = elementDetails.get("vendor_shortname") == null ? ""
-									: elementDetails.get("vendor_shortname").toString();
-							enclosingContainer = logical_group.replace("/", "-");
-							network_function = elementDetails.get("network_function");
-							borderType = elementDetails.get("network_function") == null ? "P"
-									: elementDetails.get("network_function").toString().toUpperCase();
-							bgColor = elementDetails.get("background_color") == null ? "bgColor"
-									: elementDetails.get("background_color").toString();
+							String logical_group = elementDetails.get("logical_group") == null ? ""
+									: elementDetails.get("logical_group");
+							String display_longname = elementDetails.get("display_longname") == null ? ""
+									: elementDetails.get("display_longname");
+							String display_shortname = elementDetails.get("display_shortname") == null ? ""
+									: elementDetails.get("display_shortname");
+							String description = elementDetails.get("description") == null ? ""
+									: elementDetails.get("description");
+							String primary_function = elementDetails.get("primary_function") == null ? ""
+									: elementDetails.get("primary_function");
+							String key_interfaces = elementDetails.get("key_interfaces") == null ? ""
+									: elementDetails.get("key_interfaces");
+							String location = elementDetails.get("location") == null ? ""
+									: elementDetails.get("location");
+							String vendor = elementDetails.get("vendor") == null ? "" : elementDetails.get("vendor");
+							String vendor_shortname = elementDetails.get("vendor_shortname") == null ? ""
+									: elementDetails.get("vendor_shortname");
+							String enclosingContainer = logical_group.replace("/", "-");
+							String network_function = elementDetails.get("network_function");
+							String borderType = elementDetails.get("network_function") == null ? "P"
+									: elementDetails.get("network_function").toUpperCase();
+							String bgColor = elementDetails.get("background_color") == null ? "bgColor"
+									: elementDetails.get("background_color");
 
 							ElementDetails details = new ElementDetails(logical_group, display_longname, description,
 									primary_function, network_function, key_interfaces, location, vendor,
@@ -833,10 +745,6 @@ public class ElementMapService {
 
 			}
 
-			// Element(id, name, imgPath, bgColor, logical_group,
-			// display_longname,
-			// description, primary_function, key_interfaces, location, vendor,
-			// vendor_shortname);
 		} else {
 			return new Element(id, name);
 		}
@@ -857,7 +765,7 @@ public class ElementMapService {
 								.get(detailsKey);
 
 						if (elementDetails != null) {
-							return elementDetails.get("domain") == null ? "" : elementDetails.get("domain").toString();
+							return elementDetails.get("domain") == null ? "" : elementDetails.get("domain");
 						}
 
 					}
@@ -872,34 +780,29 @@ public class ElementMapService {
 		return "";
 	}
 
-	private static HashMap fetchInnerContainersMapForOuter(String name, boolean isInner,
+	private static Map fetchInnerContainersMapForOuter(String name, boolean isInner,
 			String logicalGroupName, String domain) {
 		return fetchInnerContainersMap(name, logicalGroupName, domain);
 	}
 
-	private static HashMap fetchElementsMapForContainer(String name, boolean isInner,
+	private static Map fetchElementsMapForContainer(String name, boolean isInner,
 			String logicalGroupName, String domain) {
 		return fetchElementsMap(logicalGroupName, domain);
 	}
 
-	private static HashMap fetchInnerContainersMap(String name, String logicalGroupName,
-			String domain) {
-		HashMap containersMap = new HashMap();
-		String rowColumnKey = "";
-		int count = 0;
+	private static Map fetchInnerContainersMap(String name, String logicalGroupName, String domain) {
+		HashMap containersMap = new HashMap<>();
 
 		if (innercontainers != null && !innercontainers.isEmpty()) {
 			for (String key : innercontainers.keySet()) {
-
 				Container eachContainer = innercontainers.get(key);
-
 				if (key.toUpperCase().contains((domain + ":" + name).toUpperCase())) {
+					String rowColumnKey = "";
 					if (key.contains("/")) {
 						rowColumnKey = key.substring(key.lastIndexOf("/") + 1);
 					}
-
 					if (rowColumnKey.isEmpty() || containersMap.containsKey(rowColumnKey)) {
-						count = 0;
+						int count = 0;
 						while (count <= 9) {
 							if (containersMap.containsKey(String.valueOf(count).concat(String.valueOf(count)))) {
 								count++;
@@ -920,22 +823,21 @@ public class ElementMapService {
 
 	}
 
-	private static HashMap fetchFromOuterContainers(String domain) {
-		HashMap thisContainersMap = new HashMap();
-		String rowColumnKey = "";
-		int count = 0;
+	private static Map fetchFromOuterContainers(String domain) {
+		HashMap thisContainersMap = new HashMap<>();
 
 		if (outercontainers != null && !outercontainers.isEmpty()) {
 			for (String key : outercontainers.keySet()) {
 				Container eachContainer = outercontainers.get(key);
 
 				if (key.toUpperCase().contains((domain + ":").toUpperCase())) {
+					String rowColumnKey = "";
 					if (key.contains("/")) {
 						rowColumnKey = key.substring(key.lastIndexOf("/") + 1);
 					}
 
 					if (rowColumnKey.isEmpty() || thisContainersMap.containsKey(rowColumnKey)) {
-						count = 0;
+						int count = 0;
 						while (count <= 9) {
 							if (thisContainersMap.containsKey(String.valueOf(count).concat(String.valueOf(count)))) {
 								count++;
@@ -962,9 +864,10 @@ public class ElementMapService {
 				String domainName = fetchDomainNameOfElement(elementName);
 
 				if (domain.equalsIgnoreCase(domainName)) {
+					String rowColumnKey = "";
 					Container eachContainer = new Container(domainName + ":" + elementName, elementName, 1, 1, 3, 6, 2,
 							5, 0, 0);
-					count = 0;
+					int count = 0;
 					while (count <= 9) {
 						if (thisContainersMap.containsKey(String.valueOf(count).concat(String.valueOf(count)))) {
 							count++;
@@ -984,45 +887,25 @@ public class ElementMapService {
 		return thisContainersMap.isEmpty() ? null : thisContainersMap;
 	}
 
-	private static HashMap addOuterContainersForMiscElements(String domain) {
-		HashMap containerElementsMap = new HashMap();
-		if (miscElementMap != null && !miscElementMap.isEmpty()) {
-			for (String key : miscElementMap.keySet()) {
-				Element eachElement = miscElementMap.get(key);
-				String elementName = eachElement.getName();
-				String domainName = fetchDomainNameOfElement(elementName);
-
-				if (domain.equalsIgnoreCase(domainName)) {
-					Container newContainer = new Container(domainName + ":" + elementName, elementName, 1, 1, 3, 6, 2,
-							5, 0, 0);
-					containerElementsMap.put(domainName + ":" + elementName, newContainer);
-				}
-
-			}
-
-		}
-		return containerElementsMap.isEmpty() ? null : containerElementsMap;
-	}
-
-	private static HashMap fetchElementsMap(String logicalGroupName, String domain) {
-		HashMap innerElementMap = new HashMap();
-		String rowColumnKey = "";
-		int count = 0;
+	private static Map fetchElementsMap(String logicalGroupName, String domain) {
+		HashMap innerElementMap = new HashMap<>();
 
 		if (elementMap != null && !elementMap.isEmpty()) {
 			for (String key : elementMap.keySet()) {
 				Element eachElement = elementMap.get(key);
 
 				String elementName = eachElement.getId();
-				String elementLogicalGroup = eachElement.details == null ? "" : eachElement.details.logical_group;
+				String elementLogicalGroup = eachElement.getDetails() == null ? ""
+						: eachElement.getDetails().getLogical_group();
 				if (elementLogicalGroup.equalsIgnoreCase(logicalGroupName)
 						&& domain.equalsIgnoreCase(fetchDomainNameOfElement(elementName))) {
+					String rowColumnKey = "";
 					if (key.contains("/")) {
 						rowColumnKey = key.substring(key.indexOf("/") + 1);
 					}
 
 					if (rowColumnKey.isEmpty() || innerElementMap.containsKey(rowColumnKey)) {
-						count = 0;
+						int count = 0;
 						while (count <= 9) {
 							if (innerElementMap.containsKey(String.valueOf(count).concat(String.valueOf(count)))) {
 								count++;
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/FnMenuService.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/FnMenuService.java
index 12203671..c426f2b5 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/FnMenuService.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/FnMenuService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/FnMenuServiceImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/FnMenuServiceImpl.java
index 8c445a46..6d7251ec 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/FnMenuServiceImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/FnMenuServiceImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -56,6 +56,7 @@ public class FnMenuServiceImpl implements FnMenuService {
 	@Autowired
 	private DataAccessService dataAccessService;
 
+	@Override
 	@SuppressWarnings("unchecked")
 	public List getFnMenuItems() {
 		return getDataAccessService().getList(MenuData.class, null, "1", null);
@@ -77,7 +78,7 @@ public class FnMenuServiceImpl implements FnMenuService {
 	@SuppressWarnings("unchecked")
 	@Override
 	public List getParentId(String label) {
-		Map params = new HashMap();
+		Map params = new HashMap<>();
 		params.put("paramLabel", label);
 		return getDataAccessService().executeNamedQuery("IdForLabelList", params, null);
 	}
@@ -98,6 +99,7 @@ public class FnMenuServiceImpl implements FnMenuService {
 		getDataAccessService().deleteDomainObject(domainFnMenu, null);
 	}
 
+	@Override
 	public MenuData getMenuItemRow(Long id) {
 		return (MenuData) getDataAccessService().getDomainObject(MenuData.class, id, null);
 	}
@@ -121,7 +123,7 @@ public class FnMenuServiceImpl implements FnMenuService {
 			parentData.setAction(menu.getAction());
 			parentData.setImageSrc(menu.getImageSrc());
 			parentList.add(parentData);
-			List tempList = new ArrayList();
+			List tempList = new ArrayList<>();
 			for (Object o : menu.getChildMenus()) {
 				MenuData m = (MenuData) o;
 				MenuData data = new MenuData();
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/FunctionalMenuListService.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/FunctionalMenuListService.java
index e2e6349d..53328315 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/FunctionalMenuListService.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/FunctionalMenuListService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -45,7 +45,7 @@ import javax.servlet.http.HttpServletRequest;
 import org.onap.portalsdk.core.domain.RoleFunction;
 
 public interface FunctionalMenuListService {
-	
+
 	List getFunctionCDList(HttpServletRequest request) throws IOException;
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/FunctionalMenuListServiceCentralizedImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/FunctionalMenuListServiceCentralizedImpl.java
index 7192198d..d4d04538 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/FunctionalMenuListServiceCentralizedImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/FunctionalMenuListServiceCentralizedImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -50,7 +50,7 @@ import org.springframework.beans.factory.annotation.Autowired;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.type.TypeFactory;
 
-public class FunctionalMenuListServiceCentralizedImpl implements FunctionalMenuListService{
+public class FunctionalMenuListServiceCentralizedImpl implements FunctionalMenuListService {
 
 	@Autowired
 	private RestApiRequestBuilder restApiRequestBuilder;
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/FunctionalMenuListServiceImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/FunctionalMenuListServiceImpl.java
index b9e70e6e..becb1734 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/FunctionalMenuListServiceImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/FunctionalMenuListServiceImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -45,10 +45,10 @@ import javax.servlet.http.HttpServletRequest;
 import org.onap.portalsdk.core.domain.RoleFunction;
 import org.springframework.beans.factory.annotation.Autowired;
 
-public class FunctionalMenuListServiceImpl implements FunctionalMenuListService{
-	
+public class FunctionalMenuListServiceImpl implements FunctionalMenuListService {
+
 	@Autowired
-	private DataAccessService  dataAccessService;
+	private DataAccessService dataAccessService;
 
 	public DataAccessService getDataAccessService() {
 		return dataAccessService;
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LdapService.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LdapService.java
index 9156c8a7..c810c19d 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LdapService.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LdapService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,13 +37,15 @@
  */
 package org.onap.portalsdk.core.service;
 
+import javax.naming.NamingException;
+
 import org.onap.portalsdk.core.command.support.SearchResult;
 import org.onap.portalsdk.core.domain.support.DomainVo;
 
-
 public interface LdapService {
 
-    // search POST for users based on the criteria selected in the Request
-    SearchResult searchPost(DomainVo searchCriteria, String sortBy1, String sortBy2, String sortBy3, int pageNo, int dataSize, int userId) throws Exception;
+	// search POST for users based on the criteria selected in the Request
+	SearchResult searchPost(DomainVo searchCriteria, String sortBy1, String sortBy2, String sortBy3, int pageNo,
+			int dataSize, int userId) throws NamingException;
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LdapServiceImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LdapServiceImpl.java
index ca2e13aa..6470ca63 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LdapServiceImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LdapServiceImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -62,225 +62,189 @@ import org.springframework.transaction.annotation.Transactional;
 @Service("ldapService")
 @Transactional
 public class LdapServiceImpl extends FusionService implements LdapService {
-	
+
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(LdapServiceImpl.class);
-	
+
 	@Autowired
 	private ServiceLocator serviceLocator;
-	
-	@SuppressWarnings({ "unchecked", "rawtypes" })
-    public SearchResult searchPost(DomainVo searchCriteria, String sortBy1, String sortBy2, String sortBy3, 
-    		int pageNo, int dataSize, int userId) throws Exception {
-
-        // initialize the directory context to access POST
-        DirContext dirContext = serviceLocator.getDirContext(SystemProperties.getProperty(SystemProperties.POST_INITIAL_CONTEXT_FACTORY),
-                                                                  SystemProperties.getProperty(SystemProperties.POST_PROVIDER_URL),
-                                                                  SystemProperties.getProperty(SystemProperties.POST_SECURITY_PRINCIPAL));
-
-        SearchResult searchResult = new SearchResult();
-
-        try {
-          
-          String[] postAttributes =  {"nickname","givenName","initials","sn","employeeNumber","mail","telephoneNumber",
-        		  	"departmentNumber","a1","street","roomNumber","l","st","postalCode","zip4","physicalDeliveryOfficeName","bc",
-        		  	"friendlyCountryName","bd","bdname","bu","buname","jtname","mgrid","a2","compcode","compdesc",
-        		  	"costcenter","silo","b2"};
-
-          SearchControls searchControls = new SearchControls();
-          searchControls.setTimeLimit(5000);
-          searchControls.setReturningAttributes(postAttributes);
-
-          StringBuffer filterClause = new StringBuffer("(&(objectClass=*)");
-
-          User user = (User)searchCriteria;
-
-          if(Utilities.nvl(user.getFirstName()).length() > 0) {
-            filterClause.append("(givenName=").append(user.getFirstName()).append("*)");
-          }
-          if(Utilities.nvl(user.getLastName()).length() > 0) {
-            filterClause.append("(sn=").append(user.getLastName()).append("*)");
-          }
-          if(Utilities.nvl(user.getHrid()).length() > 0) {
-            filterClause.append("(employeeNumber=").append(user.getHrid()).append("*)");
-          }
-          if(Utilities.nvl(user.getOrgManagerUserId()).length() > 0) {
-              filterClause.append("(mgrid=").append(user.getOrgManagerUserId()).append("*)");
-            }
-          if(Utilities.nvl(user.getOrgCode()).length() > 0) {
-            filterClause.append("(departmentNumber=").append(user.getOrgCode()).append("*)");
-          }
-          if(Utilities.nvl(user.getEmail()).length() > 0) {
-            filterClause.append("(mail=").append(user.getEmail()).append("*)");
-          }
-          if(Utilities.nvl(user.getOrgUserId()).length() > 0) {
-            filterClause.append("(a1=").append(user.getOrgUserId()).append("*)");
-          }
-          filterClause.append("(c3=N)"); // this has been added to filter CP09 entries on the LDAP server that are duplicates of existing individuals
-          filterClause.append(")");
 
-          List list = new ArrayList();
-          if (!filterClause.toString().equals("(&(objectClass=*))")) {
-              NamingEnumeration e = dirContext.search(SystemProperties.getProperty(SystemProperties.POST_PROVIDER_URL) + "/" +
-                                                      SystemProperties.getProperty(SystemProperties.POST_SECURITY_PRINCIPAL),
-                                                      filterClause.toString(),
-                                                      searchControls);
-
-              list = processResults(e);
-          }
-
-          Collections.sort(list);
-
-          searchResult = new SearchResult(list);
-          searchResult.setPageNo(pageNo);
-          if(dataSize >= 0) {
-            searchResult.setDataSize(dataSize);
-          }
-          else {
-            searchResult.setDataSize(list.size());
-          }	// else
-
-        }
-        catch(NamingException ne) {
-          logger.error(EELFLoggerDelegate.errorLogger,ne.getMessage());
-        }
-        finally {
-          dirContext.close();
-        }
-
-        return searchResult;
-    }
+	@Override
+	@SuppressWarnings({ "unchecked", "rawtypes" })
+	public SearchResult searchPost(DomainVo searchCriteria, String sortBy1, String sortBy2, String sortBy3, int pageNo,
+			int dataSize, int userId) throws NamingException {
+
+		// initialize the directory context to access POST
+		DirContext dirContext = serviceLocator.getDirContext(
+				SystemProperties.getProperty(SystemProperties.POST_INITIAL_CONTEXT_FACTORY),
+				SystemProperties.getProperty(SystemProperties.POST_PROVIDER_URL),
+				SystemProperties.getProperty(SystemProperties.POST_SECURITY_PRINCIPAL));
+
+		SearchResult searchResult = new SearchResult();
+
+		String[] postAttributes = { "nickname", "givenName", "initials", "sn", "employeeNumber", "mail",
+				"telephoneNumber", "departmentNumber", "a1", "street", "roomNumber", "l", "st", "postalCode", "zip4",
+				"physicalDeliveryOfficeName", "bc", "friendlyCountryName", "bd", "bdname", "bu", "buname", "jtname",
+				"mgrid", "a2", "compcode", "compdesc", "costcenter", "silo", "b2" };
+
+		SearchControls searchControls = new SearchControls();
+		searchControls.setTimeLimit(5000);
+		searchControls.setReturningAttributes(postAttributes);
+
+		StringBuilder filterClause = new StringBuilder("(&(objectClass=*)");
+		User user = (User) searchCriteria;
+
+		if (Utilities.nvl(user.getFirstName()).length() > 0) {
+			filterClause.append("(givenName=").append(user.getFirstName()).append("*)");
+		}
+		if (Utilities.nvl(user.getLastName()).length() > 0) {
+			filterClause.append("(sn=").append(user.getLastName()).append("*)");
+		}
+		if (Utilities.nvl(user.getHrid()).length() > 0) {
+			filterClause.append("(employeeNumber=").append(user.getHrid()).append("*)");
+		}
+		if (Utilities.nvl(user.getOrgManagerUserId()).length() > 0) {
+			filterClause.append("(mgrid=").append(user.getOrgManagerUserId()).append("*)");
+		}
+		if (Utilities.nvl(user.getOrgCode()).length() > 0) {
+			filterClause.append("(departmentNumber=").append(user.getOrgCode()).append("*)");
+		}
+		if (Utilities.nvl(user.getEmail()).length() > 0) {
+			filterClause.append("(mail=").append(user.getEmail()).append("*)");
+		}
+		if (Utilities.nvl(user.getOrgUserId()).length() > 0) {
+			filterClause.append("(a1=").append(user.getOrgUserId()).append("*)");
+		}
+		filterClause.append("(c3=N)"); // this has been added to filter CP09 entries on the LDAP server that are
+										// duplicates of existing individuals
+		filterClause.append(")");
+
+		List list = new ArrayList();
+		if (!"(&(objectClass=*))".equals(filterClause.toString())) {
+			NamingEnumeration e = dirContext.search(
+					SystemProperties.getProperty(SystemProperties.POST_PROVIDER_URL) + "/"
+							+ SystemProperties.getProperty(SystemProperties.POST_SECURITY_PRINCIPAL),
+					filterClause.toString(), searchControls);
+
+			list = processResults(e);
+		}
+
+		Collections.sort(list);
+
+		searchResult = new SearchResult(list);
+		searchResult.setPageNo(pageNo);
+		if (dataSize >= 0) {
+			searchResult.setDataSize(dataSize);
+		} else {
+			searchResult.setDataSize(list.size());
+		} // else
+
+		dirContext.close();
+
+		return searchResult;
+	}
 
 	@SuppressWarnings({ "rawtypes", "unchecked" })
-    private ArrayList processResults(NamingEnumeration e) throws NamingException {
-      ArrayList results = new ArrayList();
-      int count = 0;
+	private ArrayList processResults(NamingEnumeration e) throws NamingException {
+		ArrayList results = new ArrayList();
+		int count = 0;
 
-      while (e.hasMore()) {
-        javax.naming.directory.SearchResult searchResult = (javax.naming.directory.SearchResult)e.next();
-        results.add(processAttributes(searchResult.getAttributes()));
-        count++;
+		while (e.hasMore()) {
+			javax.naming.directory.SearchResult searchResult = (javax.naming.directory.SearchResult) e.next();
+			results.add(processAttributes(searchResult.getAttributes()));
+			count++;
 
-        if(count > Integer.parseInt(SystemProperties.getProperty(SystemProperties.POST_MAX_RESULT_SIZE))) {
-          break;
-        }
+			if (count > Integer.parseInt(SystemProperties.getProperty(SystemProperties.POST_MAX_RESULT_SIZE))) {
+				break;
+			}
 
-      }
+		}
 
-      return results;
-    }
+		return results;
+	}
 
 	@SuppressWarnings("rawtypes")
-    private DomainVo processAttributes(Attributes resultAttributes) throws NamingException {
-      User user = new User();
-
-      try {
-        if (resultAttributes == null) {
-          // System.out.println("This result has no attributes");
-        } else {
-          for (NamingEnumeration e = resultAttributes.getAll(); e.hasMore();) { //why the nested loop?
-            Attribute attribute = (Attribute)e.next();
-            for (NamingEnumeration ie = attribute.getAll(); ie.hasMore();) {
-              if (attribute.getID().equalsIgnoreCase("nickname")) {
-                  user.setFirstName((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("initials")) {
-                  user.setMiddleInitial((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("sn")) {
-                  user.setLastName((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("employeeNumber")) {
-                  user.setHrid((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("mail")) {
-                  user.setEmail((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("telephoneNumber")) {
-                  user.setPhone((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("departmentNumber")) {
-                  user.setOrgCode((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("a1")) {
-                  user.setOrgUserId((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("street")) {
-                  user.setAddress1((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("roomNumber")) {
-                  user.setAddress2((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("l")) {
-                  user.setCity((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("st")) {
-                  user.setState((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("postalCode")) {
-                  user.setZipCode((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("zip4")) {
-                  user.setZipCodeSuffix((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("physicalDeliveryOfficeName")) {
-                  user.setLocationClli((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("bc")) {
-                  user.setBusinessCountryCode((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("friendlyCountryName")) {
-                  user.setBusinessCountryName((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("bd")) {
-                  user.setDepartment((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("bdname")) {
-                  user.setDepartmentName((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("jtname")) {
-                  user.setJobTitle((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("mgrid")) {
-                  user.setOrgManagerUserId((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("a2")) {
-                  user.setCommandChain((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("compcode")) {
-                  user.setCompanyCode((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("compdesc")) {
-                  user.setCompany((String) ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("bu")) {
-                  user.setBusinessUnit((String)ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("buname")) {
-                  user.setBusinessUnitName((String)ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("silo")) {
-                  user.setSiloStatus((String)ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("costcenter")) {
-                  user.setCostCenter((String)ie.next());
-              }
-              else if (attribute.getID().equalsIgnoreCase("b2")) {
-                  user.setFinancialLocCode((String)ie.next());
-              }
-              else { //we don't care about returned attribute, let's move on
-                ie.next();
-              }
-
-            }
-          }
-        }
-      } catch (NamingException e) {
-    	  logger.error(EELFLoggerDelegate.errorLogger, "An error occurred while processing the following user from POST with an ORGUSERID of " + user.getOrgUserId() + e.getMessage());
-      } 
-      
-      return user;
-
-    }
-
+	private DomainVo processAttributes(Attributes resultAttributes) {
+		User user = new User();
+		try {
+			if (resultAttributes == null) {
+				logger.debug(EELFLoggerDelegate.debugLogger, "processAttributes: no attributes");
+			} else {
+				for (NamingEnumeration e = resultAttributes.getAll(); e.hasMore();) { // why the nested loop?
+					Attribute attribute = (Attribute) e.next();
+					for (NamingEnumeration ie = attribute.getAll(); ie.hasMore();) {
+						if (attribute.getID().equalsIgnoreCase("nickname")) {
+							user.setFirstName((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("initials")) {
+							user.setMiddleInitial((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("sn")) {
+							user.setLastName((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("employeeNumber")) {
+							user.setHrid((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("mail")) {
+							user.setEmail((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("telephoneNumber")) {
+							user.setPhone((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("departmentNumber")) {
+							user.setOrgCode((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("a1")) {
+							user.setOrgUserId((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("street")) {
+							user.setAddress1((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("roomNumber")) {
+							user.setAddress2((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("l")) {
+							user.setCity((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("st")) {
+							user.setState((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("postalCode")) {
+							user.setZipCode((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("zip4")) {
+							user.setZipCodeSuffix((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("physicalDeliveryOfficeName")) {
+							user.setLocationClli((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("bc")) {
+							user.setBusinessCountryCode((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("friendlyCountryName")) {
+							user.setBusinessCountryName((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("bd")) {
+							user.setDepartment((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("bdname")) {
+							user.setDepartmentName((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("jtname")) {
+							user.setJobTitle((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("mgrid")) {
+							user.setOrgManagerUserId((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("a2")) {
+							user.setCommandChain((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("compcode")) {
+							user.setCompanyCode((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("compdesc")) {
+							user.setCompany((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("bu")) {
+							user.setBusinessUnit((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("buname")) {
+							user.setBusinessUnitName((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("silo")) {
+							user.setSiloStatus((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("costcenter")) {
+							user.setCostCenter((String) ie.next());
+						} else if (attribute.getID().equalsIgnoreCase("b2")) {
+							user.setFinancialLocCode((String) ie.next());
+						} else { // we don't care about returned attribute, let's move on
+							ie.next();
+						}
+
+					}
+				}
+			}
+		} catch (NamingException e) {
+			logger.error(EELFLoggerDelegate.errorLogger,
+					"An error occurred while processing the following user from POST with an ORGUSERID of "
+							+ user.getOrgUserId() + e.getMessage());
+		}
+
+		return user;
+
+	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LocalAccessCondition.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LocalAccessCondition.java
index 772b2559..c7636f10 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LocalAccessCondition.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LocalAccessCondition.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -43,14 +43,16 @@ import org.springframework.context.annotation.Condition;
 import org.springframework.context.annotation.ConditionContext;
 import org.springframework.core.type.AnnotatedTypeMetadata;
 
-public class LocalAccessCondition implements Condition{
-	
+public class LocalAccessCondition implements Condition {
+
 	/**
 	 * returns true if the application is not centralized
 	 */
 	@Override
-	public boolean matches(ConditionContext context, AnnotatedTypeMetadata metadata) {	
-		return PortalApiProperties.getProperty(PortalApiConstants.ROLE_ACCESS_CENTRALIZED) == null || (PortalApiProperties.getProperty(PortalApiConstants.ROLE_ACCESS_CENTRALIZED) != null && ! PortalApiProperties.getProperty(PortalApiConstants.ROLE_ACCESS_CENTRALIZED).equals("remote"));
-	}		
+	public boolean matches(ConditionContext context, AnnotatedTypeMetadata metadata) {
+		return PortalApiProperties.getProperty(PortalApiConstants.ROLE_ACCESS_CENTRALIZED) == null
+				|| (PortalApiProperties.getProperty(PortalApiConstants.ROLE_ACCESS_CENTRALIZED) != null && !"remote"
+						.equals(PortalApiProperties.getProperty(PortalApiConstants.ROLE_ACCESS_CENTRALIZED)));
+	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LoginService.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LoginService.java
index f3a62de7..b03be694 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LoginService.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LoginService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,36 +37,34 @@
  */
 package org.onap.portalsdk.core.service;
 
+import java.io.IOException;
+import java.util.Map;
 
-import java.util.*;
-
-import org.onap.portalsdk.core.command.*;
-
+import org.onap.portalsdk.core.command.LoginBean;
 
 public interface LoginService {
 
 	/**
-	 * 
+	 * validate user exists in the system
 	 * @param bean
 	 * @param menuPropertiesFilename
 	 * @param additionalParams
 	 * @return returns login user bean
-	 * @throws Exception
+	 * @throws IOException
 	 */
-    // validate user exists in the system
 	@SuppressWarnings("rawtypes")
-    LoginBean findUser(LoginBean bean, String menuPropertiesFilename, HashMap additionalParams) throws Exception;
-    
-	
+	LoginBean findUser(LoginBean bean, String menuPropertiesFilename, Map additionalParams) throws IOException;
+
 	/**
 	 * 
 	 * @param bean
 	 * @param menuPropertiesFilename
 	 * @param additionalParams
 	 * @param matchPassword
-	 * @return returns login user bean 
-	 * @throws Exception
+	 * @return returns login user bean
+	 * @throws IOException
 	 */
 	@SuppressWarnings("rawtypes")
-    LoginBean findUser(LoginBean bean, String menuPropertiesFilename, HashMap additionalParams, boolean matchPassword) throws Exception;
+	LoginBean findUser(LoginBean bean, String menuPropertiesFilename, Map additionalParams, boolean matchPassword)
+			throws IOException;
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LoginServiceCentralizedImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LoginServiceCentralizedImpl.java
index 9956cc48..749fdc38 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LoginServiceCentralizedImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LoginServiceCentralizedImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,6 +37,7 @@
  */
 package org.onap.portalsdk.core.service;
 
+import java.io.IOException;
 import java.util.Date;
 import java.util.HashMap;
 import java.util.HashSet;
@@ -48,6 +49,7 @@ import java.util.Set;
 import org.onap.portalsdk.core.command.LoginBean;
 import org.onap.portalsdk.core.domain.Role;
 import org.onap.portalsdk.core.domain.User;
+import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
 import org.onap.portalsdk.core.menu.MenuBuilder;
 import org.onap.portalsdk.core.service.support.FusionService;
 import org.onap.portalsdk.core.util.SystemProperties;
@@ -56,19 +58,17 @@ import org.onap.portalsdk.core.web.support.UserUtils;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.transaction.annotation.Transactional;
 
-
 @Transactional
 public class LoginServiceCentralizedImpl extends FusionService implements LoginService {
 
-	@Autowired
-	private AppService appService;
+	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(LoginServiceCentralizedImpl.class);
 
 	@Autowired
 	private DataAccessService dataAccessService;
-	
+
 	@Autowired
 	private RestApiRequestBuilder restApiRequestBuilder;
-	
+
 	@Autowired
 	private UserService userService;
 
@@ -76,28 +76,26 @@ public class LoginServiceCentralizedImpl extends FusionService implements LoginS
 	private MenuBuilder menuBuilder;
 
 	@Override
-	public LoginBean findUser(LoginBean bean, String menuPropertiesFilename, HashMap additionalParams)
-			throws Exception {
+	public LoginBean findUser(LoginBean bean, String menuPropertiesFilename, Map additionalParams) throws IOException {
 		return findUser(bean, menuPropertiesFilename, additionalParams, true);
 	}
 
+	@Override
 	@SuppressWarnings("rawtypes")
-	public LoginBean findUser(LoginBean bean, String menuPropertiesFilename, HashMap additionalParams,
-			boolean matchPassword) throws Exception {
-		User user = null;
-		User userCopy = null;
+	public LoginBean findUser(LoginBean bean, String menuPropertiesFilename, Map additionalParams,
+			boolean matchPassword) throws IOException {
 
-		if (bean.getUserid() != null && bean.getUserid() != null) {
-			user = (User) findUser(bean);
+		User user;
+		if (bean.getUserid() != null) {
+			user = findUser(bean);
 		} else {
 			if (matchPassword)
-				user = (User) findUser(bean.getLoginId(), bean.getLoginPwd());
+				user = findUser(bean.getLoginId(), bean.getLoginPwd());
 			else
-				user = (User) findUserWithoutPwd(bean.getLoginId());
+				user = findUserWithoutPwd(bean.getLoginId());
 		}
 
 		if (user != null) {
-
 			if (AppUtils.isApplicationLocked()
 					&& !UserUtils.hasRole(user, SystemProperties.getProperty(SystemProperties.SYS_ADMIN_ROLE_ID))) {
 				bean.setLoginErrorMessage(SystemProperties.MESSAGE_KEY_LOGIN_ERROR_APPLICATION_LOCKED);
@@ -116,14 +114,19 @@ public class LoginServiceCentralizedImpl extends FusionService implements LoginS
 
 				// this will be a snapshot of the user's information as
 				// retrieved from the database
-				userCopy = (User) user.clone();
+				User userCopy = null;
+				try {
+					userCopy = (User) user.clone();
+				} catch (CloneNotSupportedException ex) {
+					// Never happens
+					logger.error(EELFLoggerDelegate.errorLogger, "findUser failed", ex);
+				}
 
 				User appuser = getUser(userCopy);
 
 				appuser.setLastLoginDate(new Date());
 
 				// update the last logged in date for the user
-				// user.setLastLoginDate(new Date());
 				getDataAccessService().saveDomainObject(appuser, additionalParams);
 
 				// update the audit log of the user
@@ -162,17 +165,15 @@ public class LoginServiceCentralizedImpl extends FusionService implements LoginS
 		return hasActiveRole;
 	}
 
-	@SuppressWarnings("null")
-	public User findUser(LoginBean bean) throws Exception {
-		User user = null;
+	public User findUser(LoginBean bean) throws IOException {
 		String repsonse = restApiRequestBuilder.getViaREST("/user/" + bean.getUserid(), true, bean.getUserid());
-		user = userService.userMapper(repsonse);
+		User user = userService.userMapper(repsonse);
 		user.setId(getUserIdByOrgUserId(user.getOrgUserId()));
 		return user;
 	}
-	
+
 	public Long getUserIdByOrgUserId(String orgUserId) {
-		Map params = new HashMap();
+		Map params = new HashMap<>();
 		params.put("orgUserId", orgUserId);
 		@SuppressWarnings("rawtypes")
 		List list = getDataAccessService().executeNamedQuery("getUserIdByorgUserId", params, null);
@@ -181,26 +182,20 @@ public class LoginServiceCentralizedImpl extends FusionService implements LoginS
 			userId = (Long) list.get(0);
 		return userId;
 	}
-	
 
 	public User findUser(String loginId, String password) {
-
-		List list = null;
-
-		StringBuffer criteria = new StringBuffer();
+		StringBuilder criteria = new StringBuilder();
 		criteria.append(" where login_id = '").append(loginId).append("'").append(" and login_pwd = '").append(password)
 				.append("'");
-
-		list = getDataAccessService().getList(User.class, criteria.toString(), null, null);
-		return (list == null || list.size() == 0) ? null : (User) list.get(0);
+		List list = getDataAccessService().getList(User.class, criteria.toString(), null, null);
+		return (list == null || list.isEmpty()) ? null : (User) list.get(0);
 	}
 
 	private User findUserWithoutPwd(String loginId) {
-		List list = null;
-		StringBuffer criteria = new StringBuffer();
+		StringBuilder criteria = new StringBuilder();
 		criteria.append(" where login_id = '").append(loginId).append("'");
-		list = getDataAccessService().getList(User.class, criteria.toString(), null, null);
-		return (list == null || list.size() == 0) ? null : (User) list.get(0);
+		List list = getDataAccessService().getList(User.class, criteria.toString(), null, null);
+		return (list == null || list.isEmpty()) ? null : (User) list.get(0);
 	}
 
 	public DataAccessService getDataAccessService() {
@@ -220,14 +215,10 @@ public class LoginServiceCentralizedImpl extends FusionService implements LoginS
 	}
 
 	public User getUser(User user) {
-		List list = null;
-
-		StringBuffer criteria = new StringBuffer();
+		StringBuilder criteria = new StringBuilder();
 		criteria.append(" where login_id = '").append(user.getLoginId()).append("'");
-
-		list = getDataAccessService().getList(User.class, criteria.toString(), null, null);
-		return (list == null || list.size() == 0) ? null : (User) list.get(0);
-
+		List list = getDataAccessService().getList(User.class, criteria.toString(), null, null);
+		return (list == null || list.isEmpty()) ? null : (User) list.get(0);
 	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LoginServiceImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LoginServiceImpl.java
index 6965bf3c..4d240972 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LoginServiceImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LoginServiceImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -38,15 +38,16 @@
 package org.onap.portalsdk.core.service;
 
 import java.util.Date;
-import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Iterator;
 import java.util.List;
+import java.util.Map;
 import java.util.Set;
 
 import org.onap.portalsdk.core.command.LoginBean;
 import org.onap.portalsdk.core.domain.Role;
 import org.onap.portalsdk.core.domain.User;
+import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
 import org.onap.portalsdk.core.menu.MenuBuilder;
 import org.onap.portalsdk.core.service.support.FusionService;
 import org.onap.portalsdk.core.util.SystemProperties;
@@ -58,161 +59,144 @@ import org.springframework.transaction.annotation.Transactional;
 @Transactional
 public class LoginServiceImpl extends FusionService implements LoginService {
 
+	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(LoginServiceImpl.class);
+
 	@SuppressWarnings("unused")
-    private MenuBuilder  menuBuilder;
- 
-    @Autowired
-	private DataAccessService  dataAccessService;
-
-    @SuppressWarnings("rawtypes")
-    public LoginBean findUser(LoginBean bean, String menuPropertiesFilename, HashMap additionalParams ) throws Exception {
-    	return findUser(bean, menuPropertiesFilename, additionalParams, true);
-    }
-       
-    @SuppressWarnings("rawtypes")
-    public LoginBean findUser(LoginBean bean, String menuPropertiesFilename, HashMap additionalParams, boolean matchPassword) throws Exception {
-      User           user = null;
-      User       userCopy = null;
-      
-      if (bean.getUserid() != null && bean.getUserid() != null) {
-        user = (User)findUser(bean);
-      }
-      else {
-    	  if (matchPassword)
-    		  user = (User)findUser(bean.getLoginId(), bean.getLoginPwd());
-    	  else
-    		  user = (User)findUserWithoutPwd(bean.getLoginId());
-      }
-
-      if (user != null) {
-
-        // raise an error if the application is locked and the user does not have system administrator privileges
-        if (AppUtils.isApplicationLocked() && !UserUtils.hasRole(user, SystemProperties.getProperty(SystemProperties.SYS_ADMIN_ROLE_ID))) {
-          bean.setLoginErrorMessage(SystemProperties.MESSAGE_KEY_LOGIN_ERROR_APPLICATION_LOCKED);
-        }
-
-        // raise an error if the user is inactive
-        if (!user.getActive()) {
-          bean.setLoginErrorMessage(SystemProperties.MESSAGE_KEY_LOGIN_ERROR_USER_INACTIVE);
-        }
-
-        // raise an error if no active roles exist for the user
-//        boolean hasActiveRole = false;
-//        Iterator roles = user.getRoles().iterator();
-//        while (roles.hasNext()) {
-//          Role role = (Role)roles.next();
-//          if (role.getActive()) {
-//            hasActiveRole = true;
-//            break;
-//          }
-//        }
-      
-//        if (!hasActiveRole) {
-//          bean.setLoginErrorMessage(SystemProperties.MESSAGE_KEY_LOGIN_ERROR_USER_INACTIVE);
-//        }
-        if (!userHasActiveRoles(user)) {
-			bean.setLoginErrorMessage(SystemProperties.MESSAGE_KEY_LOGIN_ERROR_USER_INACTIVE);
-		}
-        // only login the user if no errors have occurred
-        if (bean.getLoginErrorMessage() == null) {
-
-          // this will be a snapshot of the user's information as retrieved from the database
-          userCopy = (User)user.clone();
-
-          // update the last logged in date for the user
-          user.setLastLoginDate(new Date());
-          getDataAccessService().saveDomainObject(user, additionalParams);
-
-          // update the audit log of the user
-          //Check for the client device type and set log attributes appropriately
-          
-
-          // save the above changes to the User and their audit trail
-
-          // create the application menu based on the user's privileges
-          Set appMenu = getMenuBuilder().getMenu(SystemProperties.getProperty(SystemProperties.APPLICATION_MENU_SET_NAME),dataAccessService);
-          bean.setMenu(appMenu != null?appMenu:new HashSet());
-          Set businessDirectMenu = getMenuBuilder().getMenu(SystemProperties.getProperty(SystemProperties.BUSINESS_DIRECT_MENU_SET_NAME),dataAccessService);
-          bean.setBusinessDirectMenu(businessDirectMenu != null?businessDirectMenu:new HashSet());
-          
-          bean.setUser(userCopy);
-        }
-
-      }
-
-      return bean;
-    }
-    
-    private boolean userHasActiveRoles(User user) {
-    	boolean hasActiveRole = false;
-        @SuppressWarnings("rawtypes")
-		Iterator roles = user.getRoles().iterator();
-        while (roles.hasNext()) {
-          Role role = (Role)roles.next();
-          if (role.getActive()) {
-            hasActiveRole = true;
-            break;
-          }
-        }
-        return hasActiveRole;
-	}
+	private MenuBuilder menuBuilder;
 
-    @SuppressWarnings("rawtypes")
-    public User findUser(String loginId, String password) {
-      List      list     = null;
+	@Autowired
+	private DataAccessService dataAccessService;
 
-      StringBuffer criteria = new StringBuffer();
-      criteria.append(" where login_id = '").append(loginId).append("'")
-              .append(" and login_pwd = '").append(password).append("'");
-      
-      list = getDataAccessService().getList(User.class, criteria.toString(), null, null);
+	@Override
+	@SuppressWarnings("rawtypes")
+	public LoginBean findUser(LoginBean bean, String menuPropertiesFilename, Map additionalParams) {
+		return findUser(bean, menuPropertiesFilename, additionalParams, true);
+	}
 
-      return (list == null || list.size() == 0) ? null : (User)list.get(0);
-    }
-    
-    @SuppressWarnings("rawtypes")
-    private User findUserWithoutPwd(String loginId) {
-        List      list     = null;
+	@Override
+	@SuppressWarnings("rawtypes")
+	public LoginBean findUser(LoginBean bean, String menuPropertiesFilename, Map additionalParams,
+			boolean matchPassword) {
+
+		User user;
+		if (bean.getUserid() != null && bean.getUserid() != null) {
+			user = findUser(bean);
+		} else {
+			if (matchPassword)
+				user = findUser(bean.getLoginId(), bean.getLoginPwd());
+			else
+				user = findUserWithoutPwd(bean.getLoginId());
+		}
 
-        StringBuffer criteria = new StringBuffer();
-        criteria.append(" where login_id = '").append(loginId).append("'");
-        
-        list = getDataAccessService().getList(User.class, criteria.toString(), null, null);
+		if (user != null) {
+
+			// raise an error if the application is locked and the user does not have system
+			// administrator privileges
+			if (AppUtils.isApplicationLocked()
+					&& !UserUtils.hasRole(user, SystemProperties.getProperty(SystemProperties.SYS_ADMIN_ROLE_ID))) {
+				bean.setLoginErrorMessage(SystemProperties.MESSAGE_KEY_LOGIN_ERROR_APPLICATION_LOCKED);
+			}
+
+			// raise an error if the user is inactive
+			if (!user.getActive()) {
+				bean.setLoginErrorMessage(SystemProperties.MESSAGE_KEY_LOGIN_ERROR_USER_INACTIVE);
+			}
+
+			if (!userHasActiveRoles(user)) {
+				bean.setLoginErrorMessage(SystemProperties.MESSAGE_KEY_LOGIN_ERROR_USER_INACTIVE);
+			}
+			// only login the user if no errors have occurred
+			if (bean.getLoginErrorMessage() == null) {
+
+				// this will be a snapshot of the user's information as retrieved from the
+				// database
+				User userCopy = null;
+				try {
+					userCopy = (User) user.clone();
+				} catch (CloneNotSupportedException ex) {
+					// Never happens
+					logger.error(EELFLoggerDelegate.errorLogger, "findUser failed", ex);
+				}
+
+				// update the last logged in date for the user
+				user.setLastLoginDate(new Date());
+				getDataAccessService().saveDomainObject(user, additionalParams);
+
+				// update the audit log of the user
+				// Check for the client device type and set log attributes appropriately
+
+				// save the above changes to the User and their audit trail
+
+				// create the application menu based on the user's privileges
+				Set appMenu = getMenuBuilder().getMenu(
+						SystemProperties.getProperty(SystemProperties.APPLICATION_MENU_SET_NAME), dataAccessService);
+				bean.setMenu(appMenu != null ? appMenu : new HashSet());
+				Set businessDirectMenu = getMenuBuilder().getMenu(
+						SystemProperties.getProperty(SystemProperties.BUSINESS_DIRECT_MENU_SET_NAME),
+						dataAccessService);
+				bean.setBusinessDirectMenu(businessDirectMenu != null ? businessDirectMenu : new HashSet());
+
+				bean.setUser(userCopy);
+			}
 
-        return (list == null || list.size() == 0) ? null : (User)list.get(0);
-      }
+		}
 
-    @SuppressWarnings("rawtypes")
-    public User findUser(LoginBean bean) {
-      List          list = null;
+		return bean;
+	}
 
-      StringBuffer criteria = new StringBuffer();
-      criteria.append(" where org_user_id = '").append(bean.getUserid()).append("'");
-      
-      list = getDataAccessService().getList(User.class, criteria.toString(), null, null);
+	private boolean userHasActiveRoles(User user) {
+		boolean hasActiveRole = false;
+		@SuppressWarnings("rawtypes")
+		Iterator roles = user.getRoles().iterator();
+		while (roles.hasNext()) {
+			Role role = (Role) roles.next();
+			if (role.getActive()) {
+				hasActiveRole = true;
+				break;
+			}
+		}
+		return hasActiveRole;
+	}
 
-      return (list == null || list.size() == 0) ? null : (User)list.get(0);
-    }
+	@SuppressWarnings("rawtypes")
+	public User findUser(String loginId, String password) {
+		StringBuilder criteria = new StringBuilder();
+		criteria.append(" where login_id = '").append(loginId).append("'").append(" and login_pwd = '").append(password)
+				.append("'");
+		List list = getDataAccessService().getList(User.class, criteria.toString(), null, null);
+		return (list == null || list.isEmpty()) ? null : (User) list.get(0);
+	}
 
+	@SuppressWarnings("rawtypes")
+	private User findUserWithoutPwd(String loginId) {
+		StringBuilder criteria = new StringBuilder();
+		criteria.append(" where login_id = '").append(loginId).append("'");
+		List list = getDataAccessService().getList(User.class, criteria.toString(), null, null);
+		return (list == null || list.isEmpty()) ? null : (User) list.get(0);
+	}
 
-    public MenuBuilder getMenuBuilder() {
-        return new MenuBuilder();
-    }
+	@SuppressWarnings("rawtypes")
+	public User findUser(LoginBean bean) {
+		StringBuilder criteria = new StringBuilder();
+		criteria.append(" where org_user_id = '").append(bean.getUserid()).append("'");
+		List list = getDataAccessService().getList(User.class, criteria.toString(), null, null);
+		return (list == null || list.isEmpty()) ? null : (User) list.get(0);
+	}
 
+	public MenuBuilder getMenuBuilder() {
+		return new MenuBuilder();
+	}
 
-    public void setMenuBuilder(MenuBuilder menuBuilder) {
-        this.menuBuilder = menuBuilder;
-    }
+	public void setMenuBuilder(MenuBuilder menuBuilder) {
+		this.menuBuilder = menuBuilder;
+	}
 
-    
-    public DataAccessService getDataAccessService() {
+	public DataAccessService getDataAccessService() {
 		return dataAccessService;
 	}
 
-
 	public void setDataAccessService(DataAccessService dataAccessService) {
 		this.dataAccessService = dataAccessService;
 	}
 
-
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/PostDroolsService.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/PostDroolsService.java
index b299f021..831b2734 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/PostDroolsService.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/PostDroolsService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -44,9 +44,9 @@ import org.onap.portalsdk.core.command.PostDroolsBean;
 public interface PostDroolsService {
 
 	String execute(String droolsFile, String className, String selectedRules);
-	
+
 	List fetchDroolBeans();
-	
+
 	String retrieveClass(String droolsFile);
-	
+
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/PostDroolsServiceImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/PostDroolsServiceImpl.java
index 1d5d9cc9..faa15329 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/PostDroolsServiceImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/PostDroolsServiceImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -38,8 +38,6 @@
 package org.onap.portalsdk.core.service;
 
 import java.io.File;
-import java.io.IOException;
-import java.nio.file.DirectoryIteratorException;
 import java.nio.file.DirectoryStream;
 import java.nio.file.FileSystems;
 import java.nio.file.Files;
@@ -65,14 +63,10 @@ import org.springframework.transaction.annotation.Transactional;
 
 import com.fasterxml.jackson.databind.ObjectMapper;
 
-/**
- * TODO REFACTOR
- *
- */
 @Service("postDroolsService")
 @Transactional
-public class PostDroolsServiceImpl implements PostDroolsService{
-	
+public class PostDroolsServiceImpl implements PostDroolsService {
+
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(PostDroolsServiceImpl.class);
 
 	@Override
@@ -82,29 +76,26 @@ public class PostDroolsServiceImpl implements PostDroolsService{
 		return resultsString;
 	}
 
-	
+	@Override
 	public List fetchDroolBeans() {
-		
-		List beanList = new ArrayList();
+
+		List beanList = new ArrayList<>();
 		Path path = FileSystems.getDefault().getPath(SystemProperties.getProperty(SystemProperties.FILES_PATH));
-		try (DirectoryStream stream = Files.newDirectoryStream(path,"*.{drl}")) {
-	           for (Path entry: stream) {
-	        	   
-	        	PostDroolsBean postDroolsBean = new PostDroolsBean();
-				String fileName = entry.getName(entry.getNameCount()-1).toString();
-				postDroolsBean.setDroolsFile(fileName);//sample populated
+		try (DirectoryStream stream = Files.newDirectoryStream(path, "*.{drl}")) {
+			for (Path entry : stream) {
+
+				PostDroolsBean postDroolsBean = new PostDroolsBean();
+				String fileName = entry.getName(entry.getNameCount() - 1).toString();
+				postDroolsBean.setDroolsFile(fileName);// sample populated
 				postDroolsBean.setClassName(retrieveClass(fileName));
-				//postDroolsBean.setSelectedRules("[\"NJ\",\"NY\",\"KY\"]");
 				beanList.add(postDroolsBean);
-	           }
-	       } catch (DirectoryIteratorException ex) {
-	           logger.error(EELFLoggerDelegate.errorLogger, ex.getMessage());
-	       } catch (IOException e) {
-			   logger.error(EELFLoggerDelegate.errorLogger, e.getMessage());
+			}
+		} catch (Exception ex) {
+			logger.error(EELFLoggerDelegate.errorLogger, "fetchDroolBeans failed", ex);
 		}
-	       return beanList;
+		return beanList;
 	}
-	
+
 	@Override
 	public String retrieveClass(String fileName) {
 		String resultsString = "";
@@ -113,51 +104,43 @@ public class PostDroolsServiceImpl implements PostDroolsService{
 			final KnowledgeBuilder kbuilder = loadKBuilder(fileName);
 			final Collection pkgs = kbuilder.getKnowledgePackages();
 			return pkgs.iterator().next().getFactTypes().iterator().next().getFactClass().getName();
-			
+
 		} catch (Exception e) {
 			logger.error(EELFLoggerDelegate.errorLogger, "retrieveClass failed", e);
 		}
-		
+
 		return resultsString;
 	}
-	
+
 	protected static KnowledgeBuilder loadKBuilder(String fileName) {
 		final KnowledgeBuilder kbuilder = KnowledgeBuilderFactory.newKnowledgeBuilder();
 
 		// this will parse and compile in one step
-		kbuilder.add(ResourceFactory.newFileResource(SystemProperties.getProperty(SystemProperties.FILES_PATH) + File.separator + fileName),
-		//kbuilder.add(ResourceFactory.newClassPathResource(SystemProperties.getProperty(SystemProperties.FILES_PATH) + File.separator + drl_file_path, DroolsRuleService.class),
+		kbuilder.add(
+				ResourceFactory.newFileResource(
+						SystemProperties.getProperty(SystemProperties.FILES_PATH) + File.separator + fileName),
 				ResourceType.DRL);
-		// kbuilder.add(ResourceFactory.newClassPathResource("rules.drl",DroolsRuleService.class),
-		// ResourceType.DRL);
 
 		// Check the builder for errors
 		if (kbuilder.hasErrors()) {
-
 			logger.error(EELFLoggerDelegate.errorLogger, kbuilder.getErrors().toString());
-
-			throw new RuntimeException("Unable to compile \".drl\".");
-
+			throw new IllegalArgumentException("Unable to compile \".drl\".");
 		}
 		return kbuilder;
 	}
-	
 
 	@SuppressWarnings({ "deprecation", "unchecked" })
 	public static String executeDemoRules(String fileName, String className, String ruleValue) {
 		String resultsString = "";
 		try {
 			// load up the knowledge base
-			// KieServices ks = KieServices.Factory.get();
-			// KieContainer kContainer = ks.getKieClasspathContainer();
-			// KieSession kSession = kContainer.newKieSession("ksession-rules");
 
 			final KnowledgeBuilder kbuilder = loadKBuilder(fileName);
 
 			// get the compiled packages (which are serializable)
 
 			final Collection pkgs = kbuilder.getKnowledgePackages();
-			
+
 			// add the packages to a knowledgebase (deploy the knowledge
 			// packages).
 
@@ -168,37 +151,29 @@ public class PostDroolsServiceImpl implements PostDroolsService{
 			final StatefulKnowledgeSession kSession = kbase.newStatefulKnowledgeSession();
 
 			ObjectMapper mapper = new ObjectMapper();
-			if(ruleValue == null || ruleValue.equals("")) {
+			if (ruleValue == null || "".equals(ruleValue)) {
 				resultsString = "Please enter valid rule";
 				return resultsString;
 			}
 			List selectedRules = mapper.readValue(ruleValue, List.class);
-			List ruleResponse = new ArrayList();
-			
-			for(String rule : selectedRules){
+			List ruleResponse = new ArrayList<>();
+
+			for (String rule : selectedRules) {
 				Class clazz = (Class) Class.forName(className);
-				DroolsRuleService droolsIntroduction =clazz.newInstance();
+				DroolsRuleService droolsIntroduction = clazz.newInstance();
 				droolsIntroduction.init(rule);
 				kSession.insert(droolsIntroduction);
 				kSession.fireAllRules();
 				ruleResponse.add(droolsIntroduction.getResultsString());
 			}
-			
+
 			resultsString = mapper.writeValueAsString(ruleResponse);
-			
-//			kSession.insert(new DroolsRuleService("KY"));
-//			kSession.fireAllRules();
-//
-//			kSession.setGlobal("age", "25");
-//			kSession.insert(new DroolsRuleService("NY"));
-//			kSession.fireAllRules();
+
 		} catch (Exception e) {
 			logger.error(EELFLoggerDelegate.errorLogger, "executeDemoRules failed", e);
 		}
-		
+
 		return resultsString;
 	}
 
-	
-
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/PostSearchService.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/PostSearchService.java
index 91d21776..248fdbfb 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/PostSearchService.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/PostSearchService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/PostSearchServiceImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/PostSearchServiceImpl.java
index e799e313..4bf78eed 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/PostSearchServiceImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/PostSearchServiceImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/ProfileService.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/ProfileService.java
index 2ee612a6..b2831c5b 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/ProfileService.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/ProfileService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,42 +37,42 @@
  */
 package org.onap.portalsdk.core.service;
 
+import java.io.IOException;
 import java.util.List;
 
 import org.onap.portalsdk.core.domain.Profile;
 import org.onap.portalsdk.core.domain.User;
 
-
 public interface ProfileService {
-	
+
 	/**
 	 * 
 	 * @return returns list of profiles
-	 * @throws Exception
+	 * @throws IOException
 	 */
-	List findAll() throws Exception;
-	
+	List findAll() throws IOException;
+
 	/**
 	 * 
 	 * @param id
 	 * @return returns profile of requested ID
-	 * @throws Exception
+	 * @throws IOException
 	 */
-	Profile getProfile(int id) throws Exception;
-	
-	
+	Profile getProfile(int id) throws IOException;
+
 	/**
 	 * 
-	 * @param id loginId
+	 * @param id
+	 *            loginId
 	 * @return returns User info of requested ID
-	 * @throws Exception
+	 * @throws IOException
 	 */
-	User getUser(String id) throws Exception;
-	
+	User getUser(String id) throws IOException;
+
 	/**
 	 * 
 	 * @param user
-	 *saveUser method saves the user object
+	 *            saveUser method saves the user object
 	 */
 	void saveUser(User user);
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/ProfileServiceCentralizedImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/ProfileServiceCentralizedImpl.java
index 91661e61..6503dd34 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/ProfileServiceCentralizedImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/ProfileServiceCentralizedImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,27 +37,25 @@
  */
 package org.onap.portalsdk.core.service;
 
+import java.io.IOException;
 import java.util.List;
 
 import org.onap.portalsdk.core.domain.Profile;
 import org.onap.portalsdk.core.domain.User;
-import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.transaction.annotation.Transactional;
 
 import com.fasterxml.jackson.databind.ObjectMapper;
 
 @Transactional
-public class ProfileServiceCentralizedImpl implements ProfileService{
-	
-	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(ProfileServiceCentralizedImpl.class);
-
+public class ProfileServiceCentralizedImpl implements ProfileService {
+		
 	@Autowired
-	AppService appService;
-	
+	private DataAccessService dataAccessService;
+
 	@Autowired
-	private DataAccessService  dataAccessService;
-	
+	private RestApiRequestBuilder restApiRequestBuilder;
+
 	public DataAccessService getDataAccessService() {
 		return dataAccessService;
 	}
@@ -66,40 +64,30 @@ public class ProfileServiceCentralizedImpl implements ProfileService{
 		this.dataAccessService = dataAccessService;
 	}
 
-	@Autowired
-	RestApiRequestBuilder restApiRequestBuilder ;
-
 	@SuppressWarnings("unchecked")
 	@Override
-	public List findAll() throws Exception{	
+	public List findAll() throws IOException {
 		return getDataAccessService().getList(Profile.class, null);
 	}
 
 	@Override
-	public Profile getProfile(int id) throws Exception{
+	public Profile getProfile(int id) throws IOException {
 		ObjectMapper mapper = new ObjectMapper();
-		Profile user = null;
-		String responseString = restApiRequestBuilder.getViaREST("/getProfile/" + id, true,Integer.toString(id));
-			user = mapper.readValue(responseString, Profile.class);
-		return user;
+		String responseString = restApiRequestBuilder.getViaREST("/getProfile/" + id, true, Integer.toString(id));
+		Profile profile = mapper.readValue(responseString, Profile.class);
+		return profile;
 	}
 
 	@Override
-	public User getUser(String id) throws Exception{
+	public User getUser(String id) throws IOException {
 		ObjectMapper mapper = new ObjectMapper();
-		User user = new User();
-		String responseString =restApiRequestBuilder.getViaREST("/user/" + id, true,id);
-			user = mapper.readValue(responseString, User.class);
-		
+		String responseString = restApiRequestBuilder.getViaREST("/user/" + id, true, id);
+		User user = mapper.readValue(responseString, User.class);
 		return user;
 	}
 
 	@Override
 	public void saveUser(User user) {
-		try {
-			getDataAccessService().saveDomainObject(user, null);
-		} catch (Exception e) {
-			logger.error(EELFLoggerDelegate.errorLogger, "saveUser failed", e);
-		}
-	}	
+		getDataAccessService().saveDomainObject(user, null);
+	}
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/ProfileServiceImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/ProfileServiceImpl.java
index ac7c2d01..20b14eb6 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/ProfileServiceImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/ProfileServiceImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -46,44 +46,41 @@ import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.transaction.annotation.Transactional;
 
 @Transactional
-public class ProfileServiceImpl implements ProfileService{
+public class ProfileServiceImpl implements ProfileService {
 
 	@Autowired
 	private ProfileDao profileDao;
-	
+
 	@Autowired
 	private DataAccessService dataAccessService;
-	
+
+	@Override
 	@SuppressWarnings("unchecked")
 	public List findAll() {
-		//List msgDB = getDataAccessService().getList(Profile.class, null);
 		return getDataAccessService().getList(Profile.class, null);
 	}
-	
-	public User getUser(String userId){
+
+	@Override
+	public User getUser(String userId) {
 		return (User) getDataAccessService().getDomainObject(User.class, Long.parseLong(userId), null);
 	}
-	
-	public void saveUser(User user){
-		
+
+	@Override
+	public void saveUser(User user) {
 		getDataAccessService().saveDomainObject(user, null);
 	}
-	
-	
+
+	@Override
 	public Profile getProfile(int id) {
 		return profileDao.getProfile(id);
 	}
 
-
 	public DataAccessService getDataAccessService() {
 		return dataAccessService;
 	}
 
-
 	public void setDataAccessService(DataAccessService dataAccessService) {
 		this.dataAccessService = dataAccessService;
 	}
-	
-	
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/RestApiRequestBuilder.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/RestApiRequestBuilder.java
index 5870dc29..c6c40b70 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/RestApiRequestBuilder.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/RestApiRequestBuilder.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -54,11 +54,11 @@ public class RestApiRequestBuilder {
 
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(RestApiRequestBuilder.class);
 
+	private static final String APPLICATION_JSON = "application/json";
+
 	@Autowired
 	private AppService appService;
 
-	private static final String content_type = "application/json";
-
 	/**
 	 * 
 	 * @param restEndPoint
@@ -69,9 +69,9 @@ public class RestApiRequestBuilder {
 	 */
 	public String getViaREST(String restEndPoint, boolean isBasicAuth, String userId) throws IOException {
 		logger.info(EELFLoggerDelegate.debugLogger, "getViaRest: endpoint {}", restEndPoint);
-		String appName = "";
-		String appUserName = "";
-		String decryptedPwd = "";
+		String appName;
+		String appUserName;
+		String decryptedPwd = null;
 		App app = appService.getDefaultApp();
 		if (app != null) {
 			appName = app.getName();
@@ -81,12 +81,13 @@ public class RestApiRequestBuilder {
 						SystemProperties.getProperty(SystemProperties.Decryption_Key));
 			} catch (CipherUtilException e) {
 				logger.error(EELFLoggerDelegate.errorLogger, "getViaREST failed", e);
-				throw new IOException(e.toString());
+				throw new IOException("getViaREST failed", e);
 			}
 		} else {
 			logger.warn(EELFLoggerDelegate.errorLogger,
 					"getViaREST: Unable to locate the app information from the database.");
 			appName = SystemProperties.SDK_NAME;
+			appUserName = "unknown";
 		}
 		String requestId = MDC.get(MDC_KEY_REQUEST_ID);
 		String response = RestWebServiceClient.getInstance().getPortalContent(restEndPoint, userId, appName, requestId,
@@ -106,9 +107,9 @@ public class RestApiRequestBuilder {
 	public void postViaREST(String restEndPoint, boolean isBasicAuth, String content, String userId)
 			throws IOException {
 		logger.info(EELFLoggerDelegate.debugLogger, "postViaRest: endpoint {}", restEndPoint);
-		String appName = "";
-		String appUserName = "";
-		String decryptedPwd = "";
+		String appName;
+		String appUserName;
+		String decryptedPwd = null;
 		App app = appService.getDefaultApp();
 		if (app != null) {
 			appName = app.getName();
@@ -118,16 +119,17 @@ public class RestApiRequestBuilder {
 						SystemProperties.getProperty(SystemProperties.Decryption_Key));
 			} catch (CipherUtilException e) {
 				logger.error(EELFLoggerDelegate.errorLogger, "postViaREST failed", e);
-				throw new IOException(e.toString());
+				throw new IOException("postViaREST failed", e);
 			}
 		} else {
 			logger.warn(EELFLoggerDelegate.errorLogger,
 					"postViaRest: Unable to locate the app information from the database.");
 			appName = SystemProperties.SDK_NAME;
+			appUserName = "unknown";
 		}
 		String requestId = MDC.get(MDC_KEY_REQUEST_ID);
 		String response = RestWebServiceClient.getInstance().postPortalContent(restEndPoint, userId, appName, requestId,
-				appUserName, decryptedPwd, content_type, content, isBasicAuth);
+				appUserName, decryptedPwd, APPLICATION_JSON, content, isBasicAuth);
 		logger.debug(EELFLoggerDelegate.debugLogger, "postViaRest response: {}", response);
 	}
 
@@ -142,9 +144,9 @@ public class RestApiRequestBuilder {
 	public void deleteViaRest(String restEndPoint, boolean isBasicAuth, String content, String userId)
 			throws IOException {
 		logger.info(EELFLoggerDelegate.debugLogger, "deleteViaRest: endpoint {}", restEndPoint);
-		String appName = "";
-		String appUserName = "";
-		String decryptedPwd = "";
+		String appName;
+		String appUserName;
+		String decryptedPwd = null;
 		App app = appService.getDefaultApp();
 		if (app != null) {
 			appName = app.getName();
@@ -153,17 +155,18 @@ public class RestApiRequestBuilder {
 				decryptedPwd = CipherUtil.decrypt(app.getAppPassword(),
 						SystemProperties.getProperty(SystemProperties.Decryption_Key));
 			} catch (CipherUtilException e) {
-				logger.error(EELFLoggerDelegate.errorLogger, "postViaREST failed", e);
-				throw new IOException(e.toString());
+				logger.error(EELFLoggerDelegate.errorLogger, "deleteViaRest failed", e);
+				throw new IOException("deleteViaRest failed", e);
 			}
 		} else {
 			logger.warn(EELFLoggerDelegate.errorLogger,
 					"deleteViaRest: Unable to locate the app information from the database.");
 			appName = SystemProperties.SDK_NAME;
+			appUserName = "unknown";
 		}
 		String requestId = MDC.get(MDC_KEY_REQUEST_ID);
 		String response = RestWebServiceClient.getInstance().deletePortalContent(restEndPoint, userId, appName,
-				requestId, appUserName, decryptedPwd, content_type, content, isBasicAuth);
+				requestId, appUserName, decryptedPwd, APPLICATION_JSON, content, isBasicAuth);
 		logger.debug(EELFLoggerDelegate.debugLogger, "deleteViaRest response: {}", response);
 	}
 
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/RoleService.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/RoleService.java
index 12c9d59e..b0730859 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/RoleService.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/RoleService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,111 +37,118 @@
  */
 package org.onap.portalsdk.core.service;
 
+import java.io.IOException;
 import java.util.List;
 
 import org.onap.portalsdk.core.domain.Role;
 import org.onap.portalsdk.core.domain.RoleFunction;
 
-
 public interface RoleService {
 	/**
+	 * returns list of Role Functions
 	 * 
-	 * @param requestedLoginId loginId
+	 * @param requestedLoginId
+	 *            loginId
 	 * @return returns List of RoleFunction
-	 * @throws Exception
-	 * Method getRoleFunctions returns list of Role Functions
+	 * @throws IOException
 	 */
-	List getRoleFunctions(String requestedLoginId) throws Exception;
-	
-	
+	List getRoleFunctions(String requestedLoginId) throws IOException;
+
 	/**
+	 * returns list of avialable child roles
 	 * 
 	 * @param requestedLoginId
 	 * @param roleId
 	 * @return returns List of Role
-	 * @throws Exception
-	 * Method getAvailableChildRoles returns list of avialable child roles
+	 * @throws IOException
 	 */
-	List getAvailableChildRoles(String requestedLoginId,Long roleId) throws Exception;
-	
-	
+	List getAvailableChildRoles(String requestedLoginId, Long roleId) throws IOException;
+
 	/**
+	 * returns Role object with requested roleID
 	 * 
 	 * @param requestedLoginId
-	 * @param id roleId
-	 * @return returns role 
-	 * @throws Exception
-	 * Method getRole returns Role object if requested roleID
+	 * @param id
+	 *            roleId
+	 * @return returns role
+	 * @throws IOException
 	 */
-	Role getRole(String requestedLoginId,Long id) throws Exception;
-	
+	Role getRole(String requestedLoginId, Long id) throws IOException;
+
 	/**
+	 * saves the Role Object
 	 * 
 	 * @param requestedLoginId
-	 * @param domainRole Object to be saved
-	 * Method saveRole saves the Role Object
+	 * @param domainRole
+	 *            Object to be saved
+	 * @throws IOException
 	 */
-	void saveRole(String requestedLoginId,Role domainRole) throws Exception;
-	
+	void saveRole(String requestedLoginId, Role domainRole) throws IOException;
+
 	/**
+	 * 
+	 * deletes the requested Role Object
 	 * 
 	 * @param requestedLoginId
-	 * @param domainRole Object to be removed
-	 * Method deleteRole deletes the requested Role Object
+	 * @param domainRole
+	 *            Object to be removed
+	 * @throws IOException
 	 */
-	void deleteRole(String requestedLoginId,Role domainRole) throws Exception;
-	
+	void deleteRole(String requestedLoginId, Role domainRole) throws IOException;
+
 	/**
+	 * gets the list of available roles
 	 * 
 	 * @param requestedLoginId
 	 * @return returns list of available roles
-	 * @throws Exception
-	 * Method getAvailableRoles gets the list of available roles
+	 * @throws IOException
 	 */
-	
-	List getAvailableRoles(String requestedLoginId) throws Exception;
-	
+	List getAvailableRoles(String requestedLoginId) throws IOException;
+
 	/**
+	 * gets the list of active roles of application
 	 * 
 	 * @param requestedLoginId
 	 * @return List of active roles
-	 * @throws Exception
-	 * Method getActiveRoles gets the list of active roles of application
-	 * 
+	 * @throws IOException
 	 */
-	List getActiveRoles(String requestedLoginId) throws Exception;
+	List getActiveRoles(String requestedLoginId) throws IOException;
 
 	/**
+	 * returns RoleFunction of requested function code
 	 * 
 	 * @param requestedLoginId
-	 * @param code function code
+	 * @param code
+	 *            function code
 	 * @return RoleFunction of requested function code
-	 * @throws Exception
-	 * Method getRoleFunction returns RoleFunction of requested function code
+	 * @throws IOException
 	 */
-	RoleFunction getRoleFunction(String requestedLoginId,String code) throws Exception;
-	
+	RoleFunction getRoleFunction(String requestedLoginId, String code) throws IOException;
+
 	/**
+	 * saves the requested RoleFunction object
 	 * 
 	 * @param requestedLoginId
 	 * @param domainRoleFunction
-	 * Method saveRoleFunction saves the requested RoleFunction object
+	 * @throws IOException
 	 */
-	void saveRoleFunction(String requestedLoginId,RoleFunction domainRoleFunction) throws Exception;
-	
+	void saveRoleFunction(String requestedLoginId, RoleFunction domainRoleFunction) throws IOException;
+
 	/**
+	 * deletes the requested RoleFunction object
 	 * 
 	 * @param requestedLoginId
 	 * @param domainRoleFunction
-	 * Method deleteRoleFunction deletes the requested RoleFunction object
+	 * @throws IOException
 	 */
-	void deleteRoleFunction(String requestedLoginId,RoleFunction domainRoleFunction) throws Exception;
-	
+	void deleteRoleFunction(String requestedLoginId, RoleFunction domainRoleFunction) throws IOException;
+
 	/**
+	 * deletes the requested object
 	 * 
 	 * @param requestedLoginId
 	 * @param id
-	 * Method deleteDependcyRoleRecord deletes the requested object
+	 * @throws IOException
 	 */
-	void deleteDependcyRoleRecord(String requestedLoginId,Long id);
+	void deleteDependcyRoleRecord(String requestedLoginId, Long id) throws IOException;
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/RoleServiceCentralizedAccess.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/RoleServiceCentralizedAccess.java
index 13da750c..3ef7cb8b 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/RoleServiceCentralizedAccess.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/RoleServiceCentralizedAccess.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,6 +37,7 @@
  */
 package org.onap.portalsdk.core.service;
 
+import java.io.IOException;
 import java.util.HashSet;
 import java.util.Iterator;
 import java.util.List;
@@ -61,26 +62,23 @@ public class RoleServiceCentralizedAccess implements RoleService {
 	private RestApiRequestBuilder restApiRequestBuilder;
 
 	@Override
-	public List getRoleFunctions(String loginId) throws Exception {
-
-		List roleFunctionList = null;
-		String role_function_list = "";
-		role_function_list = restApiRequestBuilder.getViaREST("/functions", true, loginId);
+	public List getRoleFunctions(String loginId) throws IOException {
+		String roleFunctionString = restApiRequestBuilder.getViaREST("/functions", true, loginId);
 		ObjectMapper mapper = new ObjectMapper();
-		roleFunctionList = mapper.readValue(role_function_list,
+		List roleFunctionList = mapper.readValue(roleFunctionString,
 				TypeFactory.defaultInstance().constructCollectionType(List.class, RoleFunction.class));
 		return roleFunctionList;
 	}
 
 	@Override
-	public List getAvailableChildRoles(String loginId, Long roleId) throws Exception {
+	public List getAvailableChildRoles(String loginId, Long roleId) throws IOException {
 		List availableChildRoles = getAvailableRoles(loginId);
 		if (roleId == null || roleId == 0) {
 			return availableChildRoles;
 		}
 
 		Role currentRole = getRole(loginId, roleId);
-		Set allParentRoles = new TreeSet();
+		Set allParentRoles = new TreeSet<>();
 		allParentRoles = getAllParentRolesAsList(loginId, currentRole, allParentRoles);
 
 		Iterator availableChildRolesIterator = availableChildRoles.iterator();
@@ -105,11 +103,10 @@ public class RoleServiceCentralizedAccess implements RoleService {
 	}
 
 	@Override
-	public Role getRole(String loginId, Long id) throws Exception {
+	public Role getRole(String loginId, Long id) throws IOException {
 		ObjectMapper mapper = new ObjectMapper();
 		String roleString = restApiRequestBuilder.getViaREST("/role/" + id, true, loginId);
-		Role role = new Role();
-		role = mapper.readValue(roleString, Role.class);
+		Role role = mapper.readValue(roleString, Role.class);
 		if (role.getRoleFunctions() != null) {
 			@SuppressWarnings("unchecked")
 			Set roleFunctionList = role.getRoleFunctions();
@@ -129,50 +126,38 @@ public class RoleServiceCentralizedAccess implements RoleService {
 	}
 
 	@Override
-	public void saveRole(String loginId, Role domainRole) throws Exception {
+	public void saveRole(String loginId, Role domainRole) throws IOException {
 		ObjectMapper mapper = new ObjectMapper();
 		String role = mapper.writeValueAsString(domainRole);
-		try {
-			restApiRequestBuilder.postViaREST("/role", true, role, loginId);
-		} catch (Exception e) {
-			logger.error(EELFLoggerDelegate.errorLogger, "saveRole Failed", e);
-			throw new Exception(e.getMessage());
-		}
+		restApiRequestBuilder.postViaREST("/role", true, role, loginId);
 	}
 
 	@Override
-	public void deleteRole(String loginId, Role domainRole) throws Exception {
+	public void deleteRole(String loginId, Role domainRole) throws IOException {
 		String roleName = domainRole.getName().replaceAll(" ", "%20");
-		try {
-			restApiRequestBuilder.deleteViaRest("/deleteRole/"+ roleName, true, null, loginId);
-		} catch (Exception e) {
-			logger.error(EELFLoggerDelegate.errorLogger, "deleteRole Failed", e);
-			throw new Exception(e.getMessage());
-		}
+		restApiRequestBuilder.deleteViaRest("/deleteRole/" + roleName, true, null, loginId);
 	}
+
 	@Override
-	public List getAvailableRoles(String requestedLoginId) throws Exception {
+	public List getAvailableRoles(String requestedLoginId) throws IOException {
 		ObjectMapper mapper = new ObjectMapper();
 		String roleList = restApiRequestBuilder.getViaREST("/roles", true, requestedLoginId);
-		List roles = null;
-		roles = mapper.readValue(roleList,
+		List roles = mapper.readValue(roleList,
 				TypeFactory.defaultInstance().constructCollectionType(List.class, Role.class));
 		return roles;
 	}
 
 	@Override
-	public List getActiveRoles(String requestedLoginId) throws Exception {
+	public List getActiveRoles(String requestedLoginId) throws IOException {
 		ObjectMapper mapper = new ObjectMapper();
 		String roleString = restApiRequestBuilder.getViaREST("/activeRoles", true, requestedLoginId);
-		List roles = null;
-		roles = mapper.readValue(roleString,
+		List roles = mapper.readValue(roleString,
 				TypeFactory.defaultInstance().constructCollectionType(List.class, Role.class));
 		return roles;
-
 	}
 
 	@Override
-	public RoleFunction getRoleFunction(String requestedLoginId, String code) throws Exception {
+	public RoleFunction getRoleFunction(String requestedLoginId, String code) throws IOException {
 		ObjectMapper mapper = new ObjectMapper();
 		String responseString = restApiRequestBuilder.getViaREST("/function/" + code, true, requestedLoginId);
 		RoleFunction roleFunction = new RoleFunction();
@@ -183,35 +168,21 @@ public class RoleServiceCentralizedAccess implements RoleService {
 	}
 
 	@Override
-	public void saveRoleFunction(String requestedLoginId, RoleFunction domainRoleFunction) throws Exception {
+	public void saveRoleFunction(String requestedLoginId, RoleFunction domainRoleFunction) throws IOException {
 		ObjectMapper mapper = new ObjectMapper();
 		String roleFunction = mapper.writeValueAsString(domainRoleFunction);
-		try{
 		restApiRequestBuilder.postViaREST("/roleFunction", true, roleFunction, requestedLoginId);
-		}catch(Exception e){
-			logger.error(EELFLoggerDelegate.errorLogger, "saveRoleFunction Failed", e);
-			throw new Exception(e.getMessage());
-		}
 	}
 
 	@Override
-	public void deleteRoleFunction(String requestedLoginId, RoleFunction domainRoleFunction) throws Exception {
+	public void deleteRoleFunction(String requestedLoginId, RoleFunction domainRoleFunction) throws IOException {
 		String code = domainRoleFunction.getCode();
-		try {
-			restApiRequestBuilder.deleteViaRest("/roleFunction/"+ code, true, null, requestedLoginId);
-		} catch (Exception e) {
-			logger.error(EELFLoggerDelegate.errorLogger, "deleteRoleFunction Failed ", e);
-			throw new Exception(e.getMessage());
-		}
+		restApiRequestBuilder.deleteViaRest("/roleFunction/" + code, true, null, requestedLoginId);
 	}
 
 	@Override
-	public void deleteDependcyRoleRecord(String requestedLoginId, Long id) {
-		try {
-			restApiRequestBuilder.deleteViaRest("/deleteDependcyRoleRecord/" + id, true, null, requestedLoginId);
-		} catch (Exception e) {
-			logger.error(EELFLoggerDelegate.errorLogger, "deleteDependcyRoleRecord Failed", e);
-		}
+	public void deleteDependcyRoleRecord(String requestedLoginId, Long id) throws IOException {
+		restApiRequestBuilder.deleteViaRest("/deleteDependcyRoleRecord/" + id, true, null, requestedLoginId);
 	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/RoleServiceImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/RoleServiceImpl.java
index abf785a0..e0e2d2e3 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/RoleServiceImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/RoleServiceImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -61,7 +61,7 @@ public class RoleServiceImpl implements RoleService {
 	@Autowired
 	private DataAccessService dataAccessService;
 
-	DataSource dataSource;
+	private DataSource dataSource;
 
 	public DataSource getDataSource() {
 		return dataSource;
@@ -72,22 +72,23 @@ public class RoleServiceImpl implements RoleService {
 		this.dataSource = dataSource;
 	}
 
+	@Override
 	@SuppressWarnings("unchecked")
 	public List getRoleFunctions(String loginId) {
-		// List msgDB = getDataAccessService().getList(Profile.class, null);
 		return getDataAccessService().getList(RoleFunction.class, null);
 	}
 
+	@Override
 	@SuppressWarnings("unchecked")
-	public List getAvailableChildRoles(String loginId,Long roleId) {
+	public List getAvailableChildRoles(String loginId, Long roleId) {
 		List availableChildRoles = (List) getDataAccessService().getList(Role.class, null);
 		if (roleId == null || roleId == 0) {
 			return availableChildRoles;
 		}
 
 		Role currentRole = (Role) getDataAccessService().getDomainObject(Role.class, roleId, null);
-		Set allParentRoles = new TreeSet();
-		allParentRoles = getAllParentRolesAsList(loginId,currentRole, allParentRoles);
+		Set allParentRoles = new TreeSet<>();
+		allParentRoles = getAllParentRolesAsList(loginId, currentRole, allParentRoles);
 
 		Iterator availableChildRolesIterator = availableChildRoles.iterator();
 		while (availableChildRolesIterator.hasNext()) {
@@ -100,47 +101,54 @@ public class RoleServiceImpl implements RoleService {
 	}
 
 	@SuppressWarnings("unchecked")
-	private Set getAllParentRolesAsList(String loginId,Role role, Set allParentRoles) {
+	private Set getAllParentRolesAsList(String loginId, Role role, Set allParentRoles) {
 		Set parentRoles = role.getParentRoles();
 		allParentRoles.addAll(parentRoles);
 		Iterator parentRolesIterator = parentRoles.iterator();
 		while (parentRolesIterator.hasNext()) {
-			getAllParentRolesAsList( loginId,parentRolesIterator.next(), allParentRoles);
+			getAllParentRolesAsList(loginId, parentRolesIterator.next(), allParentRoles);
 		}
 		return allParentRoles;
 	}
 
-	public RoleFunction getRoleFunction(String loginId,String code) {
+	@Override
+	public RoleFunction getRoleFunction(String loginId, String code) {
 		return (RoleFunction) getDataAccessService().getDomainObject(RoleFunction.class, code, null);
 	}
 
-	public void saveRoleFunction(String loginId,RoleFunction domainRoleFunction) {
+	@Override
+	public void saveRoleFunction(String loginId, RoleFunction domainRoleFunction) {
 		getDataAccessService().saveDomainObject(domainRoleFunction, null);
 	}
 
-	public void deleteRoleFunction(String loginId,RoleFunction domainRoleFunction) {
+	@Override
+	public void deleteRoleFunction(String loginId, RoleFunction domainRoleFunction) {
 		getDataAccessService().deleteDomainObject(domainRoleFunction, null);
 	}
 
-	public Role getRole(String loginId,Long id) {
+	@Override
+	public Role getRole(String loginId, Long id) {
 		return (Role) getDataAccessService().getDomainObject(Role.class, id, null);
 	}
 
-	public void saveRole(String loginId,Role domainRole) {
+	@Override
+	public void saveRole(String loginId, Role domainRole) {
 		getDataAccessService().saveDomainObject(domainRole, null);
 	}
 
-	public void deleteRole(String loginId,Role domainRole) {
+	@Override
+	public void deleteRole(String loginId, Role domainRole) {
 		getDataAccessService().deleteDomainObject(domainRole, null);
 	}
 
+	@Override
 	@SuppressWarnings("unchecked")
 	public List getAvailableRoles(String loginId) {
 		return getDataAccessService().getList(Role.class, null);
 	}
 
-	@SuppressWarnings("unchecked")
 	@Override
+	@SuppressWarnings("unchecked")
 	public List getActiveRoles(String loginId) {
 		String filter = " where active_yn = 'Y' ";
 		return getDataAccessService().getList(Role.class, filter, null, null);
@@ -155,7 +163,7 @@ public class RoleServiceImpl implements RoleService {
 	}
 
 	@Override
-	public void deleteDependcyRoleRecord(String loginId,Long id) {
+	public void deleteDependcyRoleRecord(String loginId, Long id) {
 		Connection conn = null;
 		Statement stmt = null;
 		try {
@@ -163,22 +171,16 @@ public class RoleServiceImpl implements RoleService {
 			stmt = conn.createStatement();
 			String sql = "delete from fn_user_role where role_id = '" + id + "'";
 			stmt.executeUpdate(sql);
-			stmt.close();
-			conn.close();
 		} catch (Exception e) {
 			logger.error(EELFLoggerDelegate.errorLogger, "deleteDependcyRoleRecord failed", e);
 		} finally {
 			try {
 				if (stmt != null)
 					stmt.close();
-			} catch (SQLException se2) {
-				logger.error(EELFLoggerDelegate.errorLogger, "deleteDependcyRoleRecord failed", se2);
-			}
-			try {
 				if (conn != null)
 					conn.close();
 			} catch (SQLException se) {
-				logger.error(EELFLoggerDelegate.errorLogger, "deleteDependcyRoleRecord failed", se);
+				logger.error(EELFLoggerDelegate.errorLogger, "deleteDependcyRoleRecord failed to close", se);
 			}
 		}
 
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UrlAccessImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UrlAccessImpl.java
index 2a9718a6..4dde6116 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UrlAccessImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UrlAccessImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -64,11 +64,10 @@ public class UrlAccessImpl implements UrlAccessService {
 		List list = dataAccessService.executeNamedQuery("restrictedUrls", params, null);
 
 		// loop through the list of restricted URL's
-		if (list != null && list.size() > 0) {
+		if (list != null && !list.isEmpty()) {
 			for (int i = 0; i < list.size(); i++) {
 				UrlsAccessible urlFunctions = (UrlsAccessible) list.get(i);
-				// String url = (String) urlFunctions.getUrl();
-				String functionCd = (String) urlFunctions.getFunctionCd();
+				String functionCd = urlFunctions.getFunctionCd();
 				if (UserUtils.isAccessible(request, functionCd)) {
 					isAccessible = true;
 				}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UrlAccessService.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UrlAccessService.java
index 7b915854..106dcb1b 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UrlAccessService.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UrlAccessService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -40,7 +40,7 @@ package org.onap.portalsdk.core.service;
 import javax.servlet.http.HttpServletRequest;
 
 public interface UrlAccessService {
-	
+
 	/**
 	 * Answers whether the specified URL is accessible.
 	 * 
@@ -48,5 +48,5 @@ public interface UrlAccessService {
 	 * @param currentUrl
 	 * @return true if yes, false if no.
 	 */
-	public  boolean isUrlAccessible(HttpServletRequest request, String currentUrl);
+	public boolean isUrlAccessible(HttpServletRequest request, String currentUrl);
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserProfileService.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserProfileService.java
index a7537959..c9dfae12 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserProfileService.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserProfileService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -41,11 +41,14 @@ import java.util.List;
 
 import org.onap.portalsdk.core.domain.User;
 
-
 public interface UserProfileService {
 	List findAll();
+
 	User getUserByLoginId(String loginId);
+
 	void saveUser(User user);
+
 	public List findAllUserWithOnOffline(String originOrgUserId);
+
 	List findAllActive();
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserProfileServiceImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserProfileServiceImpl.java
index 5a123393..184ec85b 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserProfileServiceImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserProfileServiceImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -38,9 +38,9 @@
 package org.onap.portalsdk.core.service;
 
 import java.util.ArrayList;
-import java.util.HashSet;
 import java.util.Iterator;
 import java.util.List;
+import java.util.Set;
 import java.util.SortedSet;
 
 import org.hibernate.criterion.Criterion;
@@ -54,75 +54,78 @@ import org.springframework.transaction.annotation.Transactional;
 
 @Service("userProfile")
 @Transactional
-public class UserProfileServiceImpl implements UserProfileService{
+public class UserProfileServiceImpl implements UserProfileService {
 
-	
 	@Autowired
-	private DataAccessService  dataAccessService;
-	
+	private DataAccessService dataAccessService;
+
+	@Override
 	@SuppressWarnings("unchecked")
 	public List findAll() {
 		return getDataAccessService().getList(User.class, null);
 	}
-	
+
+	@Override
 	@SuppressWarnings("unchecked")
-	public User getUserByLoginId(String loginId){
-		User user=null;
+	public User getUserByLoginId(String loginId) {
+		User user = null;
 		List restrictionsList = new ArrayList();
-		Criterion criterion1= Restrictions.eq("loginId",loginId);
+		Criterion criterion1 = Restrictions.eq("loginId", loginId);
 		restrictionsList.add(criterion1);
-		List users = (List) getDataAccessService().getList(User.class,null, restrictionsList, null);
-		if(users!=null && users.size()==1)
+		List users = (List) getDataAccessService().getList(User.class, null, restrictionsList, null);
+		if (users != null && users.size() == 1)
 			user = users.get(0);
 		return user;
 	}
-	
-	public void saveUser(User user){
-		
+
+	@Override
+	public void saveUser(User user) {
 		getDataAccessService().saveDomainObject(user, null);
 	}
-	
+
 	public DataAccessService getDataAccessService() {
 		return dataAccessService;
 	}
 
-
 	public void setDataAccessService(DataAccessService dataAccessService) {
 		this.dataAccessService = dataAccessService;
 	}
-	
+
+	@Override
 	@SuppressWarnings("unchecked")
 	public List findAllUserWithOnOffline(String originOrgUserId) {
-		HashSet onlineUser = CollaborateList.getInstance().getAllUserName();
-		List users =  getDataAccessService().getList(User.class, null);
-		for(User u:users){
-			if(onlineUser.contains(u.getOrgUserId()))
+		Set onlineUser = CollaborateList.getInstance().getAllUserName();
+		List users = getDataAccessService().getList(User.class, null);
+		for (User u : users) {
+			if (onlineUser.contains(u.getOrgUserId()))
 				u.setOnline(true);
-			if(u.getOrgUserId()!=null){
-				if(originOrgUserId.compareTo(u.getOrgUserId()) > 0) {
+			if (u.getOrgUserId() != null) {
+				if (originOrgUserId.compareTo(u.getOrgUserId()) > 0) {
 					u.setChatId(originOrgUserId + "-" + u.getOrgUserId());
-				} else u.setChatId(u.getOrgUserId() + "-" + originOrgUserId  );
+				} else
+					u.setChatId(u.getOrgUserId() + "-" + originOrgUserId);
 			}
 		}
 		return users;
-		
+
 	}
-	
+
+	@Override
 	public List findAllActive() {
 		@SuppressWarnings("unchecked")
-		List users =  getDataAccessService().getList(User.class, null);
+		List users = getDataAccessService().getList(User.class, null);
 		Iterator itr = users.iterator();
-		while(itr.hasNext()){
-			User u = (User) itr.next();
-			if(!u.getActive())
-				itr.remove();//if not active remove user from list
+		while (itr.hasNext()) {
+			User u = itr.next();
+			if (!u.getActive())
+				itr.remove();// if not active remove user from list
 			else {
 				SortedSet roles = u.getRoles();
 				Iterator itrRoles = roles.iterator();
-				while(itrRoles.hasNext()){
-					Role role = (Role) itrRoles.next();
-					if(!role.getActive())
-						u.removeRole(role.getId());//if not active remove role from list
+				while (itrRoles.hasNext()) {
+					Role role = itrRoles.next();
+					if (!role.getActive())
+						u.removeRole(role.getId());// if not active remove role from list
 				}
 			}
 		}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserService.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserService.java
index 8a667462..1f6e240d 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserService.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -41,8 +41,6 @@ import java.io.IOException;
 
 import org.onap.portalsdk.core.domain.User;
 
-import com.fasterxml.jackson.core.JsonProcessingException;
-
 public interface UserService {
 
 	/**
@@ -61,7 +59,6 @@ public interface UserService {
 	 * @param response
 	 * @return User object
 	 * @throws IOException
-	 * @throws JsonProcessingException
 	 */
-	User userMapper(String response) throws IOException, JsonProcessingException;
+	User userMapper(String response) throws IOException;
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserServiceCentalizedImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserServiceCentalizedImpl.java
index 17735bd6..d1b05695 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserServiceCentalizedImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserServiceCentalizedImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -54,7 +54,6 @@ import org.onap.portalsdk.core.domain.UserApp;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.transaction.annotation.Transactional;
 
-import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 
 @Transactional
@@ -94,7 +93,7 @@ public class UserServiceCentalizedImpl implements UserService {
 	}
 
 	@Override
-	public User userMapper(String res) throws IOException, JsonProcessingException {
+	public User userMapper(String res) throws IOException {
 		ObjectMapper mapper = new ObjectMapper();
 		User user = mapper.readValue(res, User.class);
 		Set roleFunctionListNew = new HashSet<>();
@@ -108,9 +107,9 @@ public class UserServiceCentalizedImpl implements UserService {
 			Role role = nextApp.getRole();
 			@SuppressWarnings("unchecked")
 			Set roleFunctionList = role.getRoleFunctions();
-			Iterator itetaror = roleFunctionList.iterator();
-			while (itetaror.hasNext()) {
-				Object nextValue = itetaror.next();
+			Iterator roleFnIter = roleFunctionList.iterator();
+			while (roleFnIter.hasNext()) {
+				Object nextValue = roleFnIter.next();
 				RoleFunction roleFunction = mapper.convertValue(nextValue, RoleFunction.class);
 				roleFunctionListNew.add(roleFunction);
 			}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserServiceImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserServiceImpl.java
index d41499a0..0318020d 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserServiceImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserServiceImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -45,13 +45,13 @@ import org.springframework.transaction.annotation.Transactional;
 public class UserServiceImpl implements UserService {
 
 	@Autowired
-	private DataAccessService  dataAccessService;
-	
+	private DataAccessService dataAccessService;
+
 	@Override
 	public User getUser(String id) {
 		return (User) dataAccessService.getDomainObject(User.class, Long.parseLong(id), null);
 	}
-	
+
 	@Override
 	public User userMapper(String response) {
 		throw new UnsupportedOperationException("method cannot be used");
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/WebServiceCallService.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/WebServiceCallService.java
index 6db9cb86..23ff1f99 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/WebServiceCallService.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/WebServiceCallService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,8 +37,9 @@
  */
 package org.onap.portalsdk.core.service;
 
+import org.onap.portalsdk.core.onboarding.exception.CipherUtilException;
 
 public interface WebServiceCallService {
-	public boolean verifyRESTCredential(String secretKey, String requestAppName, String requestPassword)throws Exception;
-	/*public String get(String restURL, String restPath);*/
+	public boolean verifyRESTCredential(String secretKey, String requestAppName, String requestPassword)
+			throws CipherUtilException;
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/WebServiceCallServiceImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/WebServiceCallServiceImpl.java
index f1a0cb28..71479820 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/WebServiceCallServiceImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/WebServiceCallServiceImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -40,7 +40,7 @@ package org.onap.portalsdk.core.service;
 import java.util.List;
 
 import org.onap.portalsdk.core.domain.App;
-import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
+import org.onap.portalsdk.core.onboarding.exception.CipherUtilException;
 import org.onap.portalsdk.core.onboarding.util.CipherUtil;
 import org.onap.portalsdk.core.util.SystemProperties;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -49,159 +49,51 @@ import org.springframework.transaction.annotation.Transactional;
 
 @Service("webServiceCallService")
 @Transactional
-public class WebServiceCallServiceImpl implements WebServiceCallService{
-	
-	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(WebServiceCallServiceImpl.class);
+public class WebServiceCallServiceImpl implements WebServiceCallService {
 
 	@Autowired
-	private DataAccessService  dataAccessService;
-	
+	private DataAccessService dataAccessService;
+
 	@Autowired
 	private AppService appService;
-	
+
 	/**
-	 * Verify REST Credential 
+	 * Verify REST Credential
+	 * 
 	 * @return true if the credential is accepted; else false.
 	 */
 	@Override
-	public boolean verifyRESTCredential(String secretKey, String requestAppName, String requestPassword)throws Exception {
+	public boolean verifyRESTCredential(String secretKey, String requestAppName, String requestPassword)
+			throws CipherUtilException {
 		App app = appService.getDefaultApp();
-		if (app!=null) {
+		if (app != null) {
 			String encriptedPwdDB = app.getAppPassword();
 			String appUserName = app.getUsername();
-			String decreptedPwd = CipherUtil.decrypt(encriptedPwdDB, secretKey==null?SystemProperties.getProperty(SystemProperties.Decryption_Key):secretKey);
-			if(decreptedPwd.equals(requestPassword) && appUserName.equals(requestAppName)) {
+			String decreptedPwd = CipherUtil.decrypt(encriptedPwdDB,
+					secretKey == null ? SystemProperties.getProperty(SystemProperties.Decryption_Key) : secretKey);
+			if (decreptedPwd.equals(requestPassword) && appUserName.equals(requestAppName)) {
 				return true;
 			}
 		}
 		return false;
 	}
-	
+
 	/**
 	 * Getting App information from FN_APP table
+	 * 
 	 * @return App domain object, or null if not found.
 	 */
-	public App findApp(){
-		List  list = null;
-		StringBuffer criteria = new StringBuffer();
-		criteria.append(" where id = 1");
-		list = getDataAccessService().getList(App.class, criteria.toString(), null, null);
-		return (list == null || list.size() == 0) ? null : (App) list.get(0);
+	public App findApp() {
+		List list = getDataAccessService().getList(App.class, " where id = 1", null, null);
+		return (list == null || list.isEmpty()) ? null : (App) list.get(0);
 	}
-	
+
 	public DataAccessService getDataAccessService() {
 		return dataAccessService;
 	}
-	
+
 	public void setDataAccessService(DataAccessService dataAccessService) {
 		this.dataAccessService = dataAccessService;
 	}
 	
-	/*/
-	@Override
-	public String get(String restURL, String restPath) {
-		String appUserName 		= "";
-		String appUebKey		= "";
-		String decreptedPwd 	= "";
-		String appName			= "";
-		String inputLine 		= "";
-		String serviceName		= "";
-		String loginId			= "";
-		StringBuffer jsonResponse	= new StringBuffer();
-		
-		StopWatch stopWatch = new StopWatch("WebServiceCallServiceImpl.get");
-		stopWatch.start();
-		try {
-			logger.info(EELFLoggerDelegate.metricsLogger, "WebServiceCallServiceImpl.get (" + restPath + ") operation is started.");
-			logger.debug(EELFLoggerDelegate.debugLogger, "WebServiceCallServiceImpl.get (" + restPath + ") operation is started.");
-			loginId = MDC.get("LoginId");
-			appUebKey 			= PortalApiProperties.getProperty(PortalApiConstants.UEB_APP_KEY);
-			App app 			= appService.getDefaultApp();
-			if (app!=null) {
-				appName		= app.getName();
-				appUserName = app.getUsername();
-				try{
-					decreptedPwd = CipherUtil.decrypt(app.getAppPassword(), SystemProperties.getProperty(SystemProperties.Decryption_Key));
-				} catch(Exception e) {
-					logger.error(EELFLoggerDelegate.errorLogger, "Exception occurred in WebServiceCallServiceImpl.get while decrypting the password. Details: " + e.getMessage());
-				}
-			} else {
-				logger.warn(EELFLoggerDelegate.errorLogger, "Unable to locate the app information from the database.");
-				appName			= SystemProperties.SERVICE_NAME;
-			}
-						
-			//Create the connection object
-			URL obj = new URL(restURL + restPath);
-			HttpURLConnection con = (HttpURLConnection) obj.openConnection();
-			con.setRequestMethod("GET");
-			con.setConnectTimeout(3000);
-			con.setReadTimeout(8000);
-			
-			//add request header
-			con.setRequestProperty("username", 	appUserName);
-			con.setRequestProperty("password", 	decreptedPwd);
-			con.setRequestProperty("uebkey", 	appUebKey);
-			con.setRequestProperty(SystemProperties.LOGIN_ID, loginId);
-			con.setRequestProperty(SystemProperties.USERAGENT_NAME, appName);
-			con.setRequestProperty(SystemProperties.ECOMP_REQUEST_ID, MDC.get(MDC_KEY_REQUEST_ID));
-			
-			//set MDC context for outgoing audit logging
-			serviceName = String.format("%s:%s.%s", appName, SystemProperties.ECOMP_PORTAL_BE, restPath);
-			MDC.put(Configuration.MDC_SERVICE_NAME, serviceName);
-			MDC.put(Configuration.MDC_REMOTE_HOST, restURL);
-			MDC.put(SystemProperties.MDC_APPNAME, appName);
-			MDC.put(SystemProperties.MDC_REST_PATH, restPath);
-			MDC.put(SystemProperties.MDC_REST_METHOD, "GET");
-			
-			int responseCode = con.getResponseCode();
-			logger.info(EELFLoggerDelegate.errorLogger, "Received the response code '" + responseCode + "' while getting the '" + restPath + "' for user: " + loginId);
-			
-			BufferedReader in = new BufferedReader(
-				 new InputStreamReader(con.getInputStream()));
-			
-			while ((inputLine = in.readLine()) != null) {
-				jsonResponse.append(inputLine);
-			}
-			in.close();
-			
-			logSecurityMessage(RESULT_ENUM.SUCCESS);
-		    logger.debug(EELFLoggerDelegate.debugLogger, restPath + " response: " + jsonResponse.toString());
-		    logger.debug(EELFLoggerDelegate.debugLogger, "WebServiceCallServiceImpl.get (" + restPath + ") operation is started.");
-		} catch(UrlAccessRestrictedException e) {
-			logger.error(EELFLoggerDelegate.errorLogger, "Authentication exception occurred in WebServiceCallServiceImpl.get (" + restPath + "). Details: " + e.getMessage());
-			logSecurityMessage(RESULT_ENUM.FAILURE);
-		} catch(Exception e) {
-			logger.error(EELFLoggerDelegate.errorLogger, "Exception occurred in WebServiceCallServiceImpl.get (" + restPath + "). Details: " + e.getMessage());
-			logSecurityMessage(RESULT_ENUM.FAILURE);
-		} finally {
-			if (stopWatch.isRunning()) stopWatch.stop();
-		    MDC.put(SystemProperties.MDC_TIMER, stopWatch.getTotalTimeMillis() + "ms");
-			logger.info(EELFLoggerDelegate.metricsLogger, "WebServiceCallServiceImpl.get (" + restPath + ") operation is completed.");
-			
-			//clear the temporary MDC context values
-			MDC.remove(SystemProperties.MDC_TIMER);
-			MDC.remove(SystemProperties.MDC_REST_METHOD);
-			MDC.remove(SystemProperties.MDC_REST_PATH);
-			MDC.remove(SystemProperties.MDC_APPNAME);
-			MDC.remove(Configuration.MDC_REMOTE_HOST);
-			MDC.remove(Configuration.MDC_SERVICE_NAME);
-		}
-		
-		return jsonResponse.toString();
-	}
-		
-	//Handles all the outgoing rest/ueb messages.
-	public void logSecurityMessage(RESULT_ENUM isSuccess) {
-		String additionalInfo = "";
-		String protocol = "HTTP";
-		String loginId = MDC.get("LoginId");
-		additionalInfo = String.format("Rest API=%s, Rest Method=%s, App-Name=%s, Request-URL=%s", 
-							MDC.get(SystemProperties.MDC_REST_PATH), MDC.get(SystemProperties.MDC_REST_METHOD), 
-							MDC.get(SystemProperties.MDC_APPNAME), MDC.get(Configuration.MDC_REMOTE_HOST));
-								
-		logger.info(EELFLoggerDelegate.auditLogger, AuditLogFormatter.getInstance().createMessage(
-				protocol, SecurityEventTypeEnum.OUTGOING_REST_MESSAGE.name(), loginId, SystemProperties.SERVICE_NAME, 
-				isSuccess.name(), additionalInfo));
-	}
-	/**/
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/support/FusionService.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/support/FusionService.java
index 601afc66..da043820 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/support/FusionService.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/support/FusionService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,9 +37,8 @@
  */
 package org.onap.portalsdk.core.service.support;
 
-
 import org.onap.portalsdk.core.FusionObject;
 
 public class FusionService implements FusionObject {
-  /** Logger for this class and subclasses */
+	/** Logger for this class and subclasses */
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/support/ServiceLocator.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/support/ServiceLocator.java
index bcd55878..ef12d3db 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/support/ServiceLocator.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/support/ServiceLocator.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -39,7 +39,6 @@ package org.onap.portalsdk.core.service.support;
 
 import javax.naming.directory.DirContext;
 
-
 public interface ServiceLocator {
 	DirContext getDirContext(String initialContextFactory, String providerUrl, String securityPrincipal);
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/support/ServiceLocatorImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/support/ServiceLocatorImpl.java
index b72d5d51..704cd39a 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/support/ServiceLocatorImpl.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/support/ServiceLocatorImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -55,68 +55,58 @@ import org.springframework.stereotype.Service;
 @Service("serviceLocator")
 public class ServiceLocatorImpl implements ServiceLocator {
 
-  private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(ServiceLocatorImpl.class);
+	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(ServiceLocatorImpl.class);
 
-  private Context            context;       // JNDI context (not currently in use)
-  private Context            rootContext;   // Java env root context (not currently in use)
-  private DirContext         dirContext;    // LDAP DIR context
-  private InitialLdapContext ldapContext;   // LDAP context LDAPv3-style (not currently in use)
+	private Context context; // JNDI context (not currently in use)
+	private Context rootContext; // Java env root context (not currently in use)
+	private DirContext dirContext; // LDAP DIR context
+	private InitialLdapContext ldapContext; // LDAP context LDAPv3-style (not currently in use)
 
+	// cannot directly instantiate
+	public ServiceLocatorImpl() {
+	}
 
-  // cannot directly instantiate
-  public ServiceLocatorImpl() {}
-
-  /*public static ServiceLocator getLocator() {
-    if (locator == null)
-        locator = new ServiceLocator();
-    return locator;
-  }
-
-  public Object clone() throws CloneNotSupportedException {
-    throw new CloneNotSupportedException();
-  }*/
-
-
-  // Get an LDAP directory context
-  public DirContext getDirContext(String initialContextFactory, String providerUrl, String securityPrincipal) {
-
-    if (dirContext == null) {
-
-      Properties properties = new Properties();
-      properties.put(Context.INITIAL_CONTEXT_FACTORY, initialContextFactory);
-      properties.put(Context.PROVIDER_URL, providerUrl);
-      properties.put(Context.SECURITY_PRINCIPAL, securityPrincipal);
-
-      try {
-        dirContext = new InitialDirContext(properties);
-      }
-      catch (NamingException ne) {
-        logger.error(EELFLoggerDelegate.errorLogger, "An error has occurred while creating an Initial Directory Context: " + ne.getMessage());
-        logger.error(EELFLoggerDelegate.errorLogger, "Explanation: " + ne.getExplanation());
-      }
-    }
-
-    return dirContext;
-  }
-
-  // Get an LDAP directory context - LDAPv3-style
-  /*public InitialLdapContext getLdapContext() { //throws NamingException {
-	if (ldapContext == null) {
-	  Properties properties = new Properties();
-	  // @todo - need to parameterize context factoy class and url
-	  properties.put(Context.INITIAL_CONTEXT_FACTORY, AttLdap.DIR_INITIAL_CONTEXT_FACTORY);
-	  properties.put(Context.PROVIDER_URL, AttLdap.DIR_PROVIDER_URL);
-	  properties.put(Context.SECURITY_PRINCIPAL, AttLdap.DIR_SECURITY_PRINCIPAL);
-	  Control[] ctrl = null;
-	  try {
-			ldapContext = new InitialLdapContext(properties, ctrl);
-	  }
-	  catch (NamingException ne) {
-		// MJ FIX log exception?
-	  }
+	/*
+	 * public static ServiceLocator getLocator() { if (locator == null) locator =
+	 * new ServiceLocator(); return locator; }
+	 * 
+	 * public Object clone() throws CloneNotSupportedException { throw new
+	 * CloneNotSupportedException(); }
+	 */
+
+	// Get an LDAP directory context
+	public DirContext getDirContext(String initialContextFactory, String providerUrl, String securityPrincipal) {
+
+		if (dirContext == null) {
+
+			Properties properties = new Properties();
+			properties.put(Context.INITIAL_CONTEXT_FACTORY, initialContextFactory);
+			properties.put(Context.PROVIDER_URL, providerUrl);
+			properties.put(Context.SECURITY_PRINCIPAL, securityPrincipal);
+
+			try {
+				dirContext = new InitialDirContext(properties);
+			} catch (NamingException ne) {
+				logger.error(EELFLoggerDelegate.errorLogger,
+						"An error has occurred while creating an Initial Directory Context: " + ne.getMessage());
+				logger.error(EELFLoggerDelegate.errorLogger, "Explanation: " + ne.getExplanation());
+			}
+		}
+
+		return dirContext;
 	}
-	return ldapContext;
-  }*/
 
+	// Get an LDAP directory context - LDAPv3-style
+	/*
+	 * public InitialLdapContext getLdapContext() { //throws NamingException { if
+	 * (ldapContext == null) { Properties properties = new Properties(); // @todo -
+	 * need to parameterize context factoy class and url
+	 * properties.put(Context.INITIAL_CONTEXT_FACTORY,
+	 * AttLdap.DIR_INITIAL_CONTEXT_FACTORY); properties.put(Context.PROVIDER_URL,
+	 * AttLdap.DIR_PROVIDER_URL); properties.put(Context.SECURITY_PRINCIPAL,
+	 * AttLdap.DIR_SECURITY_PRINCIPAL); Control[] ctrl = null; try { ldapContext =
+	 * new InitialLdapContext(properties, ctrl); } catch (NamingException ne) { //
+	 * MJ FIX log exception? } } return ldapContext; }
+	 */
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/CacheManager.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/CacheManager.java
index 774943d4..ba68539d 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/CacheManager.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/CacheManager.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -39,23 +39,26 @@ package org.onap.portalsdk.core.util;
 
 import org.onap.portalsdk.core.objectcache.jcs.JCSCacheManager;
 import org.springframework.context.annotation.Configuration;
+
 @Configuration
 public class CacheManager extends JCSCacheManager {
-    public CacheManager() {
-    	
-    }
-
-    /* The following can be customized for your application to cache the appropriate data upon application startup. The provided
-       example retrieves a list of sample lookup data and puts the list in the Cache Manager. To retrieve that data, simply call the
-       Cache Manager's getObject(String key) method which will return an Object instance. To put additional data in the Cache Manager
-       outside of application startup, call the Cache Manager's putObject(String key, Object objectToCache) method. */
-    public void loadLookUpCache() {
-        /*
-    	List result = (List)getDataAccessService().getList(Role.class,null);
+	
+	public CacheManager() {
+		super();
+	}
 
-        if (result != null) {
-          putObject("lookupRoles", result);
-        }*/
-    }
+	/*
+	 * The following can be customized for your application to cache the appropriate
+	 * data upon application startup. The provided example retrieves a list of
+	 * sample lookup data and puts the list in the Cache Manager. To retrieve that
+	 * data, simply call the Cache Manager's getObject(String key) method which will
+	 * return an Object instance. To put additional data in the Cache Manager
+	 * outside of application startup, call the Cache Manager's putObject(String
+	 * key, Object objectToCache) method.
+	 */
+	@Override
+	public void loadLookUpCache() {
+		// Example code removed to silence Sonar.
+	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/EncDecUtilTest.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/EncDecUtilTest.java
index 3a13e362..926ed347 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/EncDecUtilTest.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/EncDecUtilTest.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -36,12 +36,13 @@
  * ECOMP is a trademark and service mark of AT&T Intellectual Property.
  */
 package org.onap.portalsdk.core.util;
+
+import java.io.UnsupportedEncodingException;
 import java.security.AlgorithmParameters;
+import java.security.GeneralSecurityException;
 import java.security.SecureRandom;
 
-import javax.crypto.BadPaddingException;
 import javax.crypto.Cipher;
-import javax.crypto.IllegalBlockSizeException;
 import javax.crypto.SecretKey;
 import javax.crypto.SecretKeyFactory;
 import javax.crypto.spec.IvParameterSpec;
@@ -49,82 +50,60 @@ import javax.crypto.spec.PBEKeySpec;
 import javax.crypto.spec.SecretKeySpec;
 
 import org.apache.commons.codec.binary.Base64;
- 
+
 public class EncDecUtilTest {
- 
-    private static final String password = "test";
-	private static final String salt = "r n�HN~��|f��X�" ;
-	private static int pswdIterations = 65536  ;
-    private static int keySize = 256;
-    private byte[] ivBytes;
- 
-    public String encrypt(String plainText) throws Exception {   
-         
-        //get salt
-        //salt = generateSalt();      
-        byte[] saltBytes = salt.getBytes("UTF-8");
-         
-        // Derive the key
-        SecretKeyFactory factory = SecretKeyFactory.getInstance("PBKDF2WithHmacSHA1");
-        PBEKeySpec spec = new PBEKeySpec(
-                password.toCharArray(), 
-                saltBytes, 
-                pswdIterations, 
-                keySize
-                );
- 
-        SecretKey secretKey = factory.generateSecret(spec);
-        SecretKeySpec secret = new SecretKeySpec(secretKey.getEncoded(), "AES");
- 
-        //encrypt the message
-        Cipher cipher = Cipher.getInstance("AES/CBC/PKCS5Padding");
-        cipher.init(Cipher.ENCRYPT_MODE, secret);
-        AlgorithmParameters params = cipher.getParameters();
-        ivBytes = params.getParameterSpec(IvParameterSpec.class).getIV();
-        byte[] encryptedTextBytes = cipher.doFinal(plainText.getBytes("UTF-8"));
-        return new Base64().encodeAsString(encryptedTextBytes);
-    }
- 
-    @SuppressWarnings("static-access")
-    public String decrypt(String encryptedText) throws Exception {
- 
-        byte[] saltBytes = salt.getBytes("UTF-8");
-        byte[] encryptedTextBytes = new Base64().decodeBase64(encryptedText);
- 
-        // Derive the key
-        SecretKeyFactory factory = SecretKeyFactory.getInstance("PBKDF2WithHmacSHA1");
-        PBEKeySpec spec = new PBEKeySpec(
-                password.toCharArray(), 
-                saltBytes, 
-                pswdIterations, 
-                keySize
-                );
- 
-        SecretKey secretKey = factory.generateSecret(spec);
-        SecretKeySpec secret = new SecretKeySpec(secretKey.getEncoded(), "AES");
- 
-        // Decrypt the message
-        Cipher cipher = Cipher.getInstance("AES/CBC/PKCS5Padding");
-        cipher.init(Cipher.DECRYPT_MODE, secret, new IvParameterSpec(ivBytes));
-     
- 
-        byte[] decryptedTextBytes = null;
-        try {
-            decryptedTextBytes = cipher.doFinal(encryptedTextBytes);
-        } catch (IllegalBlockSizeException e) {
-            e.printStackTrace();
-        } catch (BadPaddingException e) {
-            e.printStackTrace();
-        }
- 
-        return new String(decryptedTextBytes);
-    }
- 
-    public String generateSalt() {
-        SecureRandom random = new SecureRandom();
-        byte bytes[] = new byte[20];
-        random.nextBytes(bytes);
-        String s = new String(bytes);
-        return s;
-    }
+
+	private static final String WORD = "test";
+	private static final String SALT = "r n�HN~��|f��X�";
+	private static final int ITERATIONS = 65536;
+	private static final int KEY_SIZE = 256;
+	private byte[] ivBytes;
+
+	public String encrypt(String plainText) throws UnsupportedEncodingException, GeneralSecurityException {
+
+		// get salt
+		// salt = generateSalt();
+		byte[] saltBytes = SALT.getBytes("UTF-8");
+
+		// Derive the key
+		SecretKeyFactory factory = SecretKeyFactory.getInstance("PBKDF2WithHmacSHA1");
+		PBEKeySpec spec = new PBEKeySpec(WORD.toCharArray(), saltBytes, ITERATIONS, KEY_SIZE);
+
+		SecretKey secretKey = factory.generateSecret(spec);
+		SecretKeySpec secret = new SecretKeySpec(secretKey.getEncoded(), "AES");
+
+		// encrypt the message
+		Cipher cipher = Cipher.getInstance("AES/CBC/PKCS5Padding");
+		cipher.init(Cipher.ENCRYPT_MODE, secret);
+		AlgorithmParameters params = cipher.getParameters();
+		ivBytes = params.getParameterSpec(IvParameterSpec.class).getIV();
+		byte[] encryptedTextBytes = cipher.doFinal(plainText.getBytes("UTF-8"));
+		return Base64.encodeBase64String(encryptedTextBytes);
+	}
+
+	public String decrypt(String encryptedText) throws UnsupportedEncodingException, GeneralSecurityException  {
+		byte[] saltBytes = SALT.getBytes("UTF-8");
+		byte[] encryptedTextBytes = Base64.decodeBase64(encryptedText);
+
+		// Derive the key
+		SecretKeyFactory factory = SecretKeyFactory.getInstance("PBKDF2WithHmacSHA1");
+		PBEKeySpec spec = new PBEKeySpec(WORD.toCharArray(), saltBytes, ITERATIONS, KEY_SIZE);
+
+		SecretKey secretKey = factory.generateSecret(spec);
+		SecretKeySpec secret = new SecretKeySpec(secretKey.getEncoded(), "AES");
+
+		// Decrypt the message
+		Cipher cipher = Cipher.getInstance("AES/CBC/PKCS5Padding");
+		cipher.init(Cipher.DECRYPT_MODE, secret, new IvParameterSpec(ivBytes));
+
+		byte[] decryptedTextBytes = cipher.doFinal(encryptedTextBytes);
+		return new String(decryptedTextBytes);
+	}
+
+	public String generateSalt() {
+		SecureRandom random = new SecureRandom();
+		byte [] bytes = new byte[20];
+		random.nextBytes(bytes);
+		return new String(bytes);
+	}
 }
\ No newline at end of file
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/JSONUtil.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/JSONUtil.java
index 8bbd791a..3375bee7 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/JSONUtil.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/JSONUtil.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -46,14 +46,19 @@ import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 
 public class JSONUtil {
-	public static String convertResponseToJSON(String response) throws JsonProcessingException{
+	
+	private JSONUtil() {
+		// Class has only static methods
+	}
+	
+	public static String convertResponseToJSON(String response) throws JsonProcessingException {
 		ObjectMapper mapper = new ObjectMapper();
-		Map responseMap = new HashMap();
+		Map responseMap = new HashMap<>();
 		responseMap.put("response", response);
-		response = mapper.writeValueAsString(responseMap);
-		return response;
+		String result = mapper.writeValueAsString(responseMap);
+		return result;
 	}
-	
+
 	public static User mapToDomainUser(User domainUser, User editUser) {
 		domainUser.setOrgId(editUser.getOrgId());
 		domainUser.setManagerId(editUser.getManagerId());
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/SystemProperties.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/SystemProperties.java
index 31d2f04d..6f119104 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/SystemProperties.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/SystemProperties.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -69,82 +69,6 @@ public class SystemProperties {
 
 	private ServletContext servletContext;
 
-	public SystemProperties() {
-	}
-
-	protected Environment getEnvironment() {
-		return environment;
-	}
-
-	@Autowired
-	public void setEnvironment(Environment environment) {
-		SystemProperties.environment = environment;
-	}
-
-	public ServletContext getServletContext() {
-		return servletContext;
-	}
-
-	public void setServletContext(ServletContext servletContext) {
-		this.servletContext = servletContext;
-	}
-
-	/**
-	 * Tests whether a property value is available for the specified key.
-	 * 
-	 * @param key Property key
-	 * @return True if the key is known, otherwise false.
-	 */
-	public static boolean containsProperty(String key) {
-		return environment.containsProperty(key);
-	}
-
-	/**
-	 * Returns the property value associated with the given key (never
-	 * {@code null}), after trimming any trailing space.
-	 * 
-	 * @param key
-	 *            Property key
-	 * @return Property value; the empty string if the environment was not
-	 *         autowired, which should never happen.
-	 * @throws IllegalStateException
-	 *             if the key cannot be resolved
-	 */
-	public static String getProperty(String key) {
-		String value = "";
-		if (environment == null) {
-			logger.error(EELFLoggerDelegate.errorLogger, "getProperty: environment is null, should never happen!");
-		}
-		else {
-			value = environment.getRequiredProperty(key);
-			// java.util.Properties preserves trailing space
-			if (value != null)
-				value = value.trim();
-		}
-		return value;
-	}
-
-	/**
-	 * Gets the property value for the key {@link #APPLICATION_NAME}.
-	 * 
-	 * method created to get around JSTL 1.0 limitation of not being able to
-	 * access a static method of a bean
-	 * 
-	 * @return Application name
-	 */
-	public String getApplicationName() {
-		return getProperty(APPLICATION_NAME);
-	}
-
-	/**
-	 * Gets the property value for the key {@link #APP_DISPLAY_NAME}.
-	 * 
-	 * @return Application display name
-	 */
-	public String getAppDisplayName() {
-		return getProperty(APP_DISPLAY_NAME);
-	}
-
 	// keys used to reference values in the system properties file
 	public static final String DOMAIN_CLASS_LOCATION = "domain_class_location";
 	public static final String DEFAULT_ERROR_MESSAGE = "default_error_message";
@@ -228,7 +152,6 @@ public class SystemProperties {
 	public static final String LOGIN_METHOD_BACKDOOR = "login_method_backdoor";
 	public static final String LOGIN_METHOD_ATTRIBUTE_NAME = "login_method_attribute_name";
 	public static final String ROLE_FUNCTION_LIST = "role_function_list";
-	
 
 	// login error message keys
 	public static final String MESSAGE_KEY_LOGIN_ERROR_COOKIE_EMPTY = "login.error.hrid.empty";
@@ -265,7 +188,7 @@ public class SystemProperties {
 	public static final String HB_DIALECT = "hb.dialect";
 	public static final String HB_SHOW_SQL = "hb.show_sql";
 	public static final String IDLE_CONNECTION_TEST_PERIOD = "hb.idle_connection_test_period";
-	
+
 	// DataSource
 	public static final String DB_DRIVER = "db.driver";
 	public static final String DB_CONNECTIONURL = "db.connectionURL";
@@ -333,7 +256,14 @@ public class SystemProperties {
 	public static final String HTTP = "HTTP";
 	public static final String HTTPS = "HTTPS";
 	public static final String SSO_VALUE = "sso";
-	
+
+	// Menu
+	public static final String CONTACT_US_LINK = "contact_us_link";
+
+	// Left Menu
+	public static final String LEFT_MENU_PARENT = "parentList";
+	public static final String LEFT_MENU_CHILDREND = "childItemList";
+
 	public enum RESULT_ENUM {
 		SUCCESS, FAILURE
 	}
@@ -342,10 +272,81 @@ public class SystemProperties {
 		FE_LOGIN_ATTEMPT, FE_LOGOUT, SSO_LOGIN_ATTEMPT_PHASE_1, SSO_LOGIN_ATTEMPT_PHASE_2, SSO_LOGOUT, LDAP_PHONEBOOK_USER_SEARCH, INCOMING_REST_MESSAGE, OUTGOING_REST_MESSAGE, REST_AUTHORIZATION_CREDENTIALS_MODIFIED, ECOMP_PORTAL_USER_MODIFIED, ECOMP_PORTAL_USER_ADDED, ECOMP_PORTAL_USER_REMOVED, ECOMP_PORTAL_WIDGET, INCOMING_UEB_MESSAGE, ECOMP_PORTAL_HEALTHCHECK
 	}
 
-	// Menu
-	public static final String CONTACT_US_LINK = "contact_us_link";
+	public SystemProperties() {
+		super();
+	}
+
+	protected Environment getEnvironment() {
+		return environment;
+	}
+
+	@Autowired
+	public void setEnvironment(Environment environment) {
+		SystemProperties.environment = environment;
+	}
+
+	public ServletContext getServletContext() {
+		return servletContext;
+	}
+
+	public void setServletContext(ServletContext servletContext) {
+		this.servletContext = servletContext;
+	}
+
+	/**
+	 * Tests whether a property value is available for the specified key.
+	 * 
+	 * @param key
+	 *            Property key
+	 * @return True if the key is known, otherwise false.
+	 */
+	public static boolean containsProperty(String key) {
+		return environment.containsProperty(key);
+	}
+
+	/**
+	 * Returns the property value associated with the given key (never
+	 * {@code null}), after trimming any trailing space.
+	 * 
+	 * @param key
+	 *            Property key
+	 * @return Property value; the empty string if the environment was not
+	 *         autowired, which should never happen.
+	 * @throws IllegalStateException
+	 *             if the key is not found
+	 */
+	public static String getProperty(String key) {
+		String value = "";
+		if (environment == null) {
+			logger.error(EELFLoggerDelegate.errorLogger, "getProperty: environment is null, should never happen!");
+		} else {
+			value = environment.getRequiredProperty(key);
+			// java.util.Properties preserves trailing space
+			if (value != null)
+				value = value.trim();
+		}
+		return value;
+	}
+
+	/**
+	 * Gets the property value for the key {@link #APPLICATION_NAME}.
+	 * 
+	 * method created to get around JSTL 1.0 limitation of not being able to access
+	 * a static method of a bean
+	 * 
+	 * @return Application name
+	 */
+	public String getApplicationName() {
+		return getProperty(APPLICATION_NAME);
+	}
+
+	/**
+	 * Gets the property value for the key {@link #APP_DISPLAY_NAME}.
+	 * 
+	 * @return Application display name
+	 */
+	public String getAppDisplayName() {
+		return getProperty(APP_DISPLAY_NAME);
+	}
 
-	// Left Menu
-	public static final String LEFT_MENU_PARENT = "parentList";
-	public static final String LEFT_MENU_CHILDREND = "childItemList";
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/UsageUtils.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/UsageUtils.java
index faf410fc..569c2b87 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/UsageUtils.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/UsageUtils.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -40,8 +40,9 @@ package org.onap.portalsdk.core.util;
 import java.text.SimpleDateFormat;
 import java.util.ArrayList;
 import java.util.Date;
-import java.util.HashMap;
 import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
 
 import javax.servlet.http.HttpSession;
 
@@ -49,62 +50,61 @@ import org.onap.portalsdk.core.command.UserRowBean;
 import org.onap.portalsdk.core.domain.User;
 
 public class UsageUtils {
+	
+	private UsageUtils() {
+		// Class has only static methods
+	}
+
 	@SuppressWarnings("rawtypes")
-	public static ArrayList getActiveUsers(HashMap activeUsers) {
-		ArrayList rows        = new ArrayList();
-        SimpleDateFormat sdf = new SimpleDateFormat("yyyy/MM/dd HH:mm:ss");
+	public static List getActiveUsers(Map activeUsers) {
+		ArrayList rows = new ArrayList<>();
+		SimpleDateFormat sdf = new SimpleDateFormat("yyyy/MM/dd HH:mm:ss");
+
+		for (Iterator i = activeUsers.keySet().iterator(); i.hasNext();) {
+			String sessionId = (String) i.next();
+			HttpSession session = (HttpSession) activeUsers.get(sessionId);
+			User userBean = (User) session.getAttribute("user");
+		
+			// Not all sessions will be valid logins
+			if (null == userBean)
+				continue;
 
-        for(Iterator i = activeUsers.keySet().iterator(); i.hasNext(); ){
-            String sessionId = (String)i.next();
-            HttpSession session = (HttpSession)activeUsers.get(sessionId);
-            User userBean = (User)session.getAttribute("user");
-            // 
-            // Not all sessions will be valid logins
-            // Skip those ones
-            //
-            if(null == userBean)
-                continue;
+			UserRowBean userRow = new UserRowBean();
+			userRow.setFirstName(userBean.getFirstName());
+			userRow.setLastName(userBean.getLastName());
+			userRow.setEmail(userBean.getEmail());
+			userRow.setId(userBean.getId());
+			userRow.setSessionId(sessionId);
+			userRow.setLoginTime(sdf.format(new Date(session.getCreationTime())));
+			userRow.setLastLoginTime(sdf.format(userBean.getLastLoginDate()));
 
-            UserRowBean userRow = new UserRowBean();
-            userRow.setFirstName(userBean.getFirstName());
-            userRow.setLastName(userBean.getLastName());
-            userRow.setEmail(userBean.getEmail());
-            userRow.setId(userBean.getId());
-            userRow.setSessionId(sessionId);
-            userRow.setLoginTime(sdf.format(new Date(session.getCreationTime())));
-            userRow.setLastLoginTime(sdf.format(userBean.getLastLoginDate()));
+			// Calculate the last time and time remaining for these sessions.
+			int sessionLength = session.getMaxInactiveInterval();
+			long now = new java.util.Date().getTime();
+			long lastAccessed = (now - session.getLastAccessedTime()) / 1000;
+			long lengthInactive = now - session.getLastAccessedTime();
+			long minutesRemaining = sessionLength - (lengthInactive / 1000);
 
-            //
-            // Calculate the last time and time remaining for these sessions.
-            //
-            int  sessionLength    = session.getMaxInactiveInterval();
-            long now              = new java.util.Date().getTime();
-            long lastAccessed     = (now - session.getLastAccessedTime()) / 1000;
-            long lengthInactive   = (now - session.getLastAccessedTime());
-            long minutesRemaining = sessionLength - (lengthInactive / 1000);
+			userRow.setLastAccess((lastAccessed / 60) + ":" + String.format("%02d", lastAccessed % 60));
+			userRow.setRemaining((minutesRemaining / 60) + ":" + String.format("%02d", minutesRemaining % 60));
 
-            userRow.setLastAccess((lastAccessed / 60) + ":" + String.format("%02d", (lastAccessed % 60)));
-            userRow.setRemaining((minutesRemaining / 60) + ":" + String.format("%02d", (minutesRemaining % 60)));
+			rows.add(userRow);
+		}
 
-            rows.add(userRow);
-        }
-        
-        return rows;
+		return rows;
 	}
-	
+
 	@SuppressWarnings("rawtypes")
-	public static ArrayList getActiveUsersAfterDelete(HashMap activeUsers, final java.lang.Object data) {
-		 return getActiveUsers(deleteSession(activeUsers,data));
-		 
+	public static List getActiveUsersAfterDelete(Map activeUsers, final java.lang.Object data) {
+		return getActiveUsers(deleteSession(activeUsers, data));
 	}
-	
+
 	@SuppressWarnings("rawtypes")
-	private static HashMap deleteSession(HashMap activeUsers, Object data) {
-		String sessionId = ((UserRowBean)data).getSessionId();
-		HttpSession session = (HttpSession)activeUsers.get(sessionId);
+	private static Map deleteSession(Map activeUsers, Object data) {
+		String sessionId = ((UserRowBean) data).getSessionId();
+		HttpSession session = (HttpSession) activeUsers.get(sessionId);
 		session.invalidate();
 		activeUsers.remove(sessionId);
-		
 		return activeUsers;
 	}
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/YamlUtils.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/YamlUtils.java
index 38206d55..38bd2075 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/YamlUtils.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/util/YamlUtils.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -38,7 +38,6 @@
 package org.onap.portalsdk.core.util;
 
 import java.io.File;
-import java.io.FileNotFoundException;
 import java.io.FileReader;
 import java.io.FileWriter;
 import java.io.IOException;
@@ -48,43 +47,34 @@ import org.yaml.snakeyaml.Yaml;
 import org.yaml.snakeyaml.representer.Representer;
 
 public class YamlUtils {
-	
-	static Yaml yaml;
-	
-	static {
 
+	private YamlUtils() {
+		// Class has only static methods
+	}
+
+	private static Yaml yaml;
+
+	static {
 		Representer representer = new Representer();
-		//representer.addClassTag(Domain.class, Tag.MAP);
-		
-		
-		 yaml = new Yaml(representer);
-		
+		yaml = new Yaml(representer);
 	}
-	
-	public static void writeYamlFile(String filePath, String fileName,
-			Map model) throws IOException {
+
+	public static void writeYamlFile(String filePath, String fileName, Map model) throws IOException {
 		FileWriter writer = new FileWriter(filePath + File.separator + fileName);
-		yaml.dump(model, writer); 
+		yaml.dump(model, writer);
 		writer.close();
 	}
-	
-	public static String returnYaml(
-			Map model) throws IOException {
-		
-		return yaml.dump(model); 
-	
+
+	public static String returnYaml(Map model) throws IOException {
+		return yaml.dump(model);
 	}
 
 	@SuppressWarnings("unchecked")
-	public static Map readYamlFile(
-			String filePath, String fileName) throws FileNotFoundException,
-			IOException {
+	public static Map readYamlFile(String filePath, String fileName) throws IOException {
 		FileReader reader = new FileReader(filePath + File.separator + fileName);
-		
-		Map callFlowBs = (Map)yaml.load(reader);
+		Map callFlowBs = (Map) yaml.load(reader);
 		reader.close();
 		return callFlowBs;
 	}
 
-
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/socket/PeerBroadcastSocket.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/socket/PeerBroadcastSocket.java
index e00e05b7..122f1333 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/socket/PeerBroadcastSocket.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/socket/PeerBroadcastSocket.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -56,14 +56,13 @@ public class PeerBroadcastSocket {
 
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(PeerBroadcastSocket.class);
 
-	public static Map channelMap = new Hashtable();
-	public Map sessionMap = new Hashtable();
-	ObjectMapper mapper = new ObjectMapper();
+	private final static Map channelMap = new Hashtable<>();
+	private final Map sessionMap = new Hashtable<>();
+	private final ObjectMapper mapper = new ObjectMapper();
 
 	@OnMessage
 	public void message(String message, Session session) {
 		try {
-			// JSONObject jsonObject = new JSONObject(message);
 			@SuppressWarnings("unchecked")
 			Map jsonObject = mapper.readValue(message, Map.class);
 			try {
@@ -73,7 +72,7 @@ public class PeerBroadcastSocket {
 					sessionMap.put(session.getId(), from.toString());
 				}
 			} catch (Exception je) {
-				logger.error(EELFLoggerDelegate.errorLogger, "Failed to read value" + je.getMessage());
+				logger.error(EELFLoggerDelegate.errorLogger, "Failed to read value", je);
 			}
 
 			try {
@@ -82,24 +81,23 @@ public class PeerBroadcastSocket {
 					return;
 				Object toSessionObj = channelMap.get(to);
 				if (toSessionObj != null) {
-					Session toSession = null;
-					toSession = (Session) toSessionObj;
+					Session 	toSession = (Session) toSessionObj;
 					toSession.getBasicRemote().sendText(message);
 				}
 
 			} catch (Exception ex) {
-				logger.error(EELFLoggerDelegate.errorLogger, "Failed to send text" + ex.getMessage());
+				logger.error(EELFLoggerDelegate.errorLogger, "Failed to send text", ex);
 			}
 
 		} catch (Exception ex) {
-			logger.error(EELFLoggerDelegate.errorLogger, "Failed" + ex.getMessage());
+			logger.error(EELFLoggerDelegate.errorLogger, "Failed", ex);
 		}
 
 	}
 
 	@OnOpen
 	public void open(Session session) {
-		logger.info(EELFLoggerDelegate.debugLogger, "Channel opened");
+		logger.debug(EELFLoggerDelegate.debugLogger, "Session opened {}", session);
 	}
 
 	@OnClose
@@ -111,12 +109,12 @@ public class PeerBroadcastSocket {
 				try {
 					((Session) sessObj).close();
 				} catch (IOException e) {
-					logger.error(EELFLoggerDelegate.errorLogger, "Failed to close" + e.getMessage());
+					logger.error(EELFLoggerDelegate.errorLogger, "Failed to close", e);
 				}
 			}
 			channelMap.remove(channel);
 		}
-		logger.info(EELFLoggerDelegate.debugLogger, "Channel closed");
+		logger.debug(EELFLoggerDelegate.debugLogger, "Channel closed");
 	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/socket/WebRTCSocket.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/socket/WebRTCSocket.java
index 76cb3b8f..f65a07cc 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/socket/WebRTCSocket.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/socket/WebRTCSocket.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -46,116 +46,92 @@ import javax.websocket.OnOpen;
 import javax.websocket.Session;
 import javax.websocket.server.ServerEndpoint;
 
+import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
+
 import com.fasterxml.jackson.databind.ObjectMapper;
 
 @ServerEndpoint("/webrtc")
 public class WebRTCSocket {
-	
-	
-	   public static Map> channelMap = new Hashtable>();
-	   public  Map sessionMap = new Hashtable();
-	   ObjectMapper mapper = new ObjectMapper(); 
-
-	     
-		@OnMessage
-	     public void message(String message, Session session) {
-	    	 try {
-	    	 //JSONObject jsonObject = new JSONObject(message);
-	    	 @SuppressWarnings("unchecked")
-			 Map jsonObject = mapper.readValue(message, Map.class);
-		    	 try {
-		    	    Object isOpen = jsonObject.get("open");
-		    	    if(isOpen != null && (Boolean)isOpen == true) {
-		    		String channel = (String) jsonObject.get("channel");
+
+	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(WebRTCSocket.class);
+
+	private final static Map> channelMap = new Hashtable>();
+	private final Map sessionMap = new Hashtable();
+	private final ObjectMapper mapper = new ObjectMapper();
+
+	@OnMessage
+	public void message(String message, Session session) {
+		try {
+			@SuppressWarnings("unchecked")
+			Map jsonObject = mapper.readValue(message, Map.class);
+			try {
+				Object isOpen = jsonObject.get("open");
+				if (isOpen != null && (Boolean) isOpen) {
+					String channel = (String) jsonObject.get("channel");
 					Object value = channelMap.get(channel);
-					Hashtable sourceDestMap = null;
-		    		if(value == null) 
-		    			sourceDestMap = new Hashtable();
-		    		else
-		    			sourceDestMap = (Hashtable) value;
-		    		
-		    		sourceDestMap.put(session.getId(), new Object[]{session});
-		    		channelMap.put(channel, sourceDestMap);
-		    		sessionMap.put(session.getId(), channel);
-			    	
-		    		 		    		 
-		    	    }
-		    	 }
-				 catch (Exception je) {
-		    		 je.printStackTrace();
-		    	 }
-	    		 
-	    		 try{
-	    		 
-	    		 Object dataObj = jsonObject.get("data");
-	    		 if(dataObj == null)
-	    			 return;
-	    		 Map dataMapObj =  ( Map)dataObj; 
-	    		 //Object thisUserId = dataMapObj.get("userid");
-	    		 String channel = null;
-	    		 try{
-	    			 Object channelObj = dataMapObj.get("sessionid");
-	    			 if(channelObj != null)
-	    				 channel = (String) channelObj;
-	    			 else 
-	    				 channel = (String) jsonObject.get("channel");
-	    		 }
-	    		 catch(Exception json) {
-	    			 json.printStackTrace();
-	    		 }
-	    		 
-	    		/* 
-	    		 JSONObject dataMapObj =  (JSONObject)dataObj; 
-	    		 Object thisUserId = dataMapObj.get("userid");
-	    		 String channel = (String) dataMapObj.get("sessionid");
-	    		 Hashtable sourceDestMap = sessionMap.get(channel);
-	    		 
-				 if(thisUserId != null && sourceDestMap.get((String)thisUserId) == null) {
-	    			 sourceDestMap.put((String)thisUserId, new Object[] {message, session});
-	    		 }
-				 
-				 for(String userId : sourceDestMap.keySet()){
-					 if(!userId.equals(thisUserId)) {
-						 Session otherSession = (Session) ((Object[])sourceDestMap.get(userId))[1];
-						 otherSession.getBasicRemote().sendText(message);
-					 }
-				 }
-				 */
-	    		  
-	    		 Hashtable sourceDestMap = channelMap.get(channel);
-	    		 if(sourceDestMap != null)
-	    		 for(String id : sourceDestMap.keySet()){
-					 if(!id.equals(session.getId())) {
-						 Session otherSession = (Session) ((Object[])sourceDestMap.get(id))[0];
-						 if(otherSession.isOpen())
-							 otherSession.getBasicRemote().sendText(mapper.writeValueAsString(dataObj));
-					 }
-	    		 
-	    		 }
-	    		 }
-	    		 catch (Exception  je) {
-		    		 je.printStackTrace();
-		    	 }
-	    		 
-	    	 }
-	    	 catch (Exception  je) {
-	    		 je.printStackTrace();
-	    	 }
-	         //System.out.println("Message received:" + message);
-	     }
-	     
-	     @OnOpen
-	     public void open(Session session) {
-	         // System.out.println("Channel opened");
-	     }
-	     
-	     @OnClose
-	     public void close(Session session) {
-	    	 String channel = sessionMap.get(session.getId());
-	    	 if (channel != null) {
-	    		 channelMap.remove(channel); 
-	    	 }
-	    	 // System.out.println("Channel closed");
-	     }
+					Hashtable sourceDestMap;
+					if (value == null)
+						sourceDestMap = new Hashtable<>();
+					else
+						sourceDestMap = (Hashtable) value;
+
+					sourceDestMap.put(session.getId(), new Object[] { session });
+					channelMap.put(channel, sourceDestMap);
+					sessionMap.put(session.getId(), channel);
+
+				}
+			} catch (Exception je) {
+				logger.error(EELFLoggerDelegate.errorLogger, "mesage failed", je);
+			}
+
+			try {
+				Object dataObj = jsonObject.get("data");
+				if (dataObj == null)
+					return;
+				Map dataMapObj = (Map) dataObj;
+				String channel = null;
+				try {
+					Object channelObj = dataMapObj.get("sessionid");
+					if (channelObj != null)
+						channel = (String) channelObj;
+					else
+						channel = (String) jsonObject.get("channel");
+				} catch (Exception json) {
+					logger.error(EELFLoggerDelegate.errorLogger, "mesage failed", json);
+				}
+
+
+				Hashtable sourceDestMap = channelMap.get(channel);
+				if (sourceDestMap != null)
+					for (String id : sourceDestMap.keySet()) {
+						if (!id.equals(session.getId())) {
+							Session otherSession = (Session) (sourceDestMap.get(id))[0];
+							if (otherSession.isOpen())
+								otherSession.getBasicRemote().sendText(mapper.writeValueAsString(dataObj));
+						}
+
+					}
+			} catch (Exception je) {
+				logger.error(EELFLoggerDelegate.errorLogger, "mesage failed", je);
+			}
+
+		} catch (Exception je) {
+			logger.error(EELFLoggerDelegate.errorLogger, "mesage failed", je);
+		}
+	}
+
+	@OnOpen
+	public void open(Session session) {
+		logger.debug(EELFLoggerDelegate.debugLogger, "Session opened {}", session);
+	}
+
+	@OnClose
+	public void close(Session session) {
+		String channel = sessionMap.get(session.getId());
+		if (channel != null) {
+			channelMap.remove(channel);
+		}
+		logger.debug(EELFLoggerDelegate.debugLogger, "Channel closed");
+	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/AppUtils.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/AppUtils.java
index f6655399..135fb4cf 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/AppUtils.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/AppUtils.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,19 +37,8 @@
  */
 package org.onap.portalsdk.core.web.support;
 
-import java.io.File;
-import java.net.InetAddress;
-import java.net.UnknownHostException;
-import java.util.Date;
-import java.util.Enumeration;
-import java.util.Hashtable;
 import java.util.Iterator;
 import java.util.List;
-import java.util.Map;
-import java.util.Vector;
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
-
 
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpSession;
@@ -59,112 +48,99 @@ import org.hibernate.Session;
 import org.onap.portalsdk.core.exception.SessionExpiredException;
 import org.onap.portalsdk.core.objectcache.AbstractCacheManager;
 import org.onap.portalsdk.core.service.DataAccessService;
-import org.onap.portalsdk.core.util.SystemProperties;
 import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.context.annotation.Configuration;
-import org.springframework.core.io.FileSystemResource;
-import org.springframework.stereotype.Service;
-import org.springframework.transaction.annotation.Transactional;
-import org.springframework.util.StringUtils;
-
 
 public class AppUtils {
-    
-	
-	
-	private static DataAccessService  dataAccessService;
-	
-    private static AbstractCacheManager cacheManager;
 
-    private static boolean applicationLocked;
+	private static DataAccessService dataAccessService;
+
+	private static AbstractCacheManager cacheManager;
+
+	private static boolean applicationLocked;
 
-    private static Hashtable feedback = new Hashtable();
-    
-    private static DataSource datasource;
+	private static DataSource datasource;
 
-    public static DataSource getDatasource() {
+	public static DataSource getDatasource() {
 		return datasource;
 	}
-    
-    @Autowired
+
+	public AppUtils() {
+		super();
+	}
+
+	@Autowired
 	public void setDatasource(DataSource datasource) {
 		AppUtils.datasource = datasource;
 	}
-    
-    public AppUtils() {
-    }
-
-    public static HttpSession getSession(HttpServletRequest request) {
-        HttpSession session = null;
-        if (request != null) {
-            session = request.getSession(false);
-            if (session == null) {
-                throw new SessionExpiredException();
-            }
-        } else {
-            throw new SessionExpiredException();
-        }
-        return session;
-    }
-    
-    public static List getLookupList(String dbTable, String dbValueCol, String dbLabelCol, String dbFilter, String dbOrderBy) {
-        return getLookupList(dbTable, dbValueCol, dbLabelCol, dbFilter, dbOrderBy, null);
-    } // getLookupList
-    
-    public static List getLookupList(String dbTable, String dbValueCol, String dbLabelCol, String dbFilter, String dbOrderBy, Session session) {
-        String cacheKey = dbTable + "|" + dbValueCol + "|" + dbLabelCol + "|" + dbFilter + "|" + dbOrderBy;
-        List list = getLookupListFromCache(cacheKey);
-        if (list == null) {
-            list = getDataAccessService().getLookupList(dbTable, dbValueCol, dbLabelCol, dbFilter, dbOrderBy, null);
-            if (list != null) {
-                addLookupListToCache(cacheKey, list);
-            }
-        } // if
-        return list;
-    } // getLookupList
-    
-    private static List getLookupListFromCache(String key) {
-        return (List)getObjectFromCache(key);
-    } // getLookupListFromCache
-    
-    public static Object getObjectFromCache(String key) {
-        if (isCacheManagerAvailable()) {
-      	return getCacheManager().getObject(key);
-        } else {
-      	return null;
-        }
-    } // getObjectFromCache
-    
-    private static void addLookupListToCache(String key, List list) {
-        addObjectToCache(key, list);
-    } // addLookupListToCache
-    
-    public static void addObjectToCache(String key, Object o) {
-        if (isCacheManagerAvailable()) {
-            getCacheManager().putObject(key, o);
-        }
-    } // addObjectToCache
-    
-    @Autowired
-    public void setCacheManager(AbstractCacheManager cacheManager) {
+
+	public static HttpSession getSession(HttpServletRequest request) {
+		if (request != null) {
+			HttpSession session = request.getSession(false);
+			if (session == null)
+				throw new SessionExpiredException();
+			else
+				return session;
+		} else {
+			throw new SessionExpiredException();
+		}
+	}
+
+	public static List getLookupList(String dbTable, String dbValueCol, String dbLabelCol, String dbFilter,
+			String dbOrderBy) {
+		return getLookupList(dbTable, dbValueCol, dbLabelCol, dbFilter, dbOrderBy, null);
+	} // getLookupList
+
+	public static List getLookupList(String dbTable, String dbValueCol, String dbLabelCol, String dbFilter,
+			String dbOrderBy, Session session) {
+		String cacheKey = dbTable + "|" + dbValueCol + "|" + dbLabelCol + "|" + dbFilter + "|" + dbOrderBy;
+		List list = getLookupListFromCache(cacheKey);
+		if (list == null) {
+			list = getDataAccessService().getLookupList(dbTable, dbValueCol, dbLabelCol, dbFilter, dbOrderBy, null);
+			if (list != null) {
+				addLookupListToCache(cacheKey, list);
+			}
+		} // if
+		return list;
+	} // getLookupList
+
+	private static List getLookupListFromCache(String key) {
+		return (List) getObjectFromCache(key);
+	} // getLookupListFromCache
+
+	public static Object getObjectFromCache(String key) {
+		if (isCacheManagerAvailable()) {
+			return getCacheManager().getObject(key);
+		} else {
+			return null;
+		}
+	} // getObjectFromCache
+
+	private static void addLookupListToCache(String key, List list) {
+		addObjectToCache(key, list);
+	} // addLookupListToCache
+
+	public static void addObjectToCache(String key, Object o) {
+		if (isCacheManagerAvailable()) {
+			getCacheManager().putObject(key, o);
+		}
+	} // addObjectToCache
+
+	@Autowired
+	public void setCacheManager(AbstractCacheManager cacheManager) {
 		this.cacheManager = cacheManager;
 	}
 
 	public static AbstractCacheManager getCacheManager() {
-        return cacheManager;
-    }
-    
-    public static boolean isCacheManagerAvailable() {
-        return (getCacheManager() != null);
-    }
-    
-    public void setFeedback(Hashtable feedback) {
-        this.feedback = feedback;
-    }
-    
-    public static boolean isApplicationLocked() {
-        return applicationLocked;
-    }
+		return cacheManager;
+	}
+
+	public static boolean isCacheManagerAvailable() {
+		return getCacheManager() != null;
+	}
+
+	public static boolean isApplicationLocked() {
+		return applicationLocked;
+	}
 
 	public static DataAccessService getDataAccessService() {
 		return dataAccessService;
@@ -176,56 +152,50 @@ public class AppUtils {
 	}
 
 	public static void setApplicationLocked(boolean locked) {
-       applicationLocked = locked;
-    }
-
-   public static String getLookupValueByLabel(String label, String dbTable, String dbValueCol, String dbLabelCol) {
-        if (label == null || label.equals("")) {
-            return "";
-        }
-
-        List lstResult = getLookupListNoCache(dbTable, dbValueCol, dbLabelCol, dbLabelCol + "='" + label.replaceAll("'", "''") + "'", "");
-        if (lstResult == null) {
-            return "";
-        }
-        if (lstResult.size() > 0) {
-            return ((org.onap.portalsdk.core.domain.Lookup)lstResult.toArray()[0]).getValue();
-        } else {
-            return "";
-        }
-    }
-
-    public static String getLookupValueByLabel(String label, List lookupList) {
-      Iterator i = null;
-
-      if (label == null || label.equalsIgnoreCase("")) {
-          return "";
-      }
-
-      if (lookupList == null || lookupList.size() == 0) {
-          return "";
-      }
-
-      i = lookupList.iterator();
-      while (i.hasNext()) {
-        org.onap.portalsdk.core.domain.Lookup lookup = (org.onap.portalsdk.core.domain.Lookup)i.next();
-
-        if (lookup.getLabel().equals(label)) {
-            return lookup.getValue();
-        }
-      }
-
-      return "";
-}
- public static List getLookupListNoCache(String dbTable, String dbValueCol, String dbLabelCol, String dbFilter, String dbOrderBy) {
-        return getLookupListNoCache(dbTable, dbValueCol, dbLabelCol, dbFilter, dbOrderBy, null);
-    } // getLookupListNoCache
+		applicationLocked = locked;
+	}
 
+	public static String getLookupValueByLabel(String label, String dbTable, String dbValueCol, String dbLabelCol) {
+		if (label == null || label.equals("")) {
+			return "";
+		}
+
+		List lstResult = getLookupListNoCache(dbTable, dbValueCol, dbLabelCol,
+				dbLabelCol + "='" + label.replaceAll("'", "''") + "'", "");
+		if (lstResult == null) {
+			return "";
+		}
+		if (!lstResult.isEmpty()) {	
+			return ((org.onap.portalsdk.core.domain.Lookup) lstResult.toArray()[0]).getValue();
+		} else {
+			return "";
+		}
+	}
 
-    public static List getLookupListNoCache(String dbTable, String dbValueCol, String dbLabelCol, String dbFilter, String dbOrderBy, Session session) {
-        return getDataAccessService().getLookupList(dbTable, dbValueCol, dbLabelCol, dbFilter, dbOrderBy, null);
-    } // getLookupListNoCache
-    
-	
+	public static String getLookupValueByLabel(String label, List lookupList) {
+		if (label == null || "".equals(label)) 
+			return "";
+		if (lookupList == null || lookupList.size() == 0)
+			return "";
+
+		Iterator i = lookupList.iterator();
+		while (i.hasNext()) {
+			org.onap.portalsdk.core.domain.Lookup lookup = (org.onap.portalsdk.core.domain.Lookup) i.next();
+			if (lookup.getLabel().equals(label)) {
+				return lookup.getValue();
+			}
+		}
+		return "";
+	}
+
+	public static List getLookupListNoCache(String dbTable, String dbValueCol, String dbLabelCol, String dbFilter,
+			String dbOrderBy) {
+		return getLookupListNoCache(dbTable, dbValueCol, dbLabelCol, dbFilter, dbOrderBy, null);
+	}
 
-} // AppUtils
+	public static List getLookupListNoCache(String dbTable, String dbValueCol, String dbLabelCol, String dbFilter,
+			String dbOrderBy, Session session) {
+		return getDataAccessService().getLookupList(dbTable, dbValueCol, dbLabelCol, dbFilter, dbOrderBy, null);
+	}
+
+}
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/ControllerProperties.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/ControllerProperties.java
index c1c2f24a..31b810db 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/ControllerProperties.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/ControllerProperties.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -39,21 +39,21 @@ package org.onap.portalsdk.core.web.support;
 
 public interface ControllerProperties {
 
-  static final String TASK_GET           = "get";
-  static final String TASK_DELETE        = "delete";
-  static final String TASK_SAVE          = "save";
-  static final String TASK_PROCESS       = "process";
-  static final String TASK_TOGGLE_ACTIVE = "toggleActive";
-  static final String TASK_DOWNLOAD      = "download";
-  static final String TASK_POPUP         = "popup";
-  static final String TASK_LOOKUP        = "lookup";
-  static final String TASK_ADD_ROW       = "addRow";
-  static final String TASK_APPROVE       = "approve";
-  static final String TASK_REJECT        = "reject";
-  static final String TASK_RESET         = "reset";
-  static final String TASK_ASSIGN        = "assign";
-  static final String TASK_CUT           = "cut";
-  static final String TASK_COPY          = "copy";
-  static final String TASK_PASTE         = "paste";
-  static final String TASK_SELECT        = "select";
+	static final String TASK_GET = "get";
+	static final String TASK_DELETE = "delete";
+	static final String TASK_SAVE = "save";
+	static final String TASK_PROCESS = "process";
+	static final String TASK_TOGGLE_ACTIVE = "toggleActive";
+	static final String TASK_DOWNLOAD = "download";
+	static final String TASK_POPUP = "popup";
+	static final String TASK_LOOKUP = "lookup";
+	static final String TASK_ADD_ROW = "addRow";
+	static final String TASK_APPROVE = "approve";
+	static final String TASK_REJECT = "reject";
+	static final String TASK_RESET = "reset";
+	static final String TASK_ASSIGN = "assign";
+	static final String TASK_CUT = "cut";
+	static final String TASK_COPY = "copy";
+	static final String TASK_PASTE = "paste";
+	static final String TASK_SELECT = "select";
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/FeedbackMessage.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/FeedbackMessage.java
index e2dadb50..013d153b 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/FeedbackMessage.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/FeedbackMessage.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -39,60 +39,60 @@ package org.onap.portalsdk.core.web.support;
 
 public class FeedbackMessage {
 
-  private String  message;
-  private int     messageType;
-  private boolean keyed;
+	private String message;
+	private int messageType;
+	private boolean keyed;
 
-  public static final int MESSAGE_TYPE_ERROR   = 10;
-  public static final int MESSAGE_TYPE_WARNING = 20;
-  public static final int MESSAGE_TYPE_INFO    = 30;
-  public static final int MESSAGE_TYPE_SUCCESS = 40;
+	public static final int MESSAGE_TYPE_ERROR = 10;
+	public static final int MESSAGE_TYPE_WARNING = 20;
+	public static final int MESSAGE_TYPE_INFO = 30;
+	public static final int MESSAGE_TYPE_SUCCESS = 40;
 
-  public static final String DEFAULT_MESSAGE_SUCCESS = "Update successful.";
-  public static final String DEFAULT_MESSAGE_ERROR   = "An error occurred while processing the request: ";
+	public static final String DEFAULT_MESSAGE_SUCCESS = "Update successful.";
+	public static final String DEFAULT_MESSAGE_ERROR = "An error occurred while processing the request: ";
 
-  public static final String DEFAULT_MESSAGE_SYSTEM_ADMINISTRATOR = "If the problem persists, please contact your Administrator.";
+	public static final String DEFAULT_MESSAGE_SYSTEM_ADMINISTRATOR = "If the problem persists, please contact your Administrator.";
 
-  public FeedbackMessage() {
-  }
+	public FeedbackMessage() {
+		this(null);
+	}
 
-  public FeedbackMessage(String message) {
-    this(message, MESSAGE_TYPE_ERROR);
-  }
+	public FeedbackMessage(String message) {
+		this(message, MESSAGE_TYPE_ERROR);
+	}
 
-  public FeedbackMessage(String message, int messageType) {
-    this(message, messageType, false);
-  }
+	public FeedbackMessage(String message, int messageType) {
+		this(message, messageType, false);
+	}
 
-  public FeedbackMessage(String message, int messageType, boolean keyed) {
-    this.message     = message;
-    this.messageType = messageType;
-    this.keyed       = keyed;
-  }
+	public FeedbackMessage(String message, int messageType, boolean keyed) {
+		this.message = message;
+		this.messageType = messageType;
+		this.keyed = keyed;
+	}
 
-  public String getMessage() {
-      return message;
-  }
+	public String getMessage() {
+		return message;
+	}
 
-  public int getMessageType() {
-      return messageType;
-  }
+	public int getMessageType() {
+		return messageType;
+	}
 
-    public boolean isKeyed() {
-        return keyed;
-    }
+	public boolean isKeyed() {
+		return keyed;
+	}
 
-    public void setMessage(String message) {
-      this.message = message;
-  }
+	public void setMessage(String message) {
+		this.message = message;
+	}
 
-  public void setMessageType(int messageType) {
-      this.messageType = messageType;
-  }
-
-    public void setKeyed(boolean keyed) {
-        this.keyed = keyed;
-    }
+	public void setMessageType(int messageType) {
+		this.messageType = messageType;
+	}
 
+	public void setKeyed(boolean keyed) {
+		this.keyed = keyed;
+	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/JsonMessage.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/JsonMessage.java
index 9b7a65ca..ce4cab3a 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/JsonMessage.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/JsonMessage.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -40,6 +40,7 @@ package org.onap.portalsdk.core.web.support;
 import java.io.PrintWriter;
 import java.io.StringWriter;
 
+import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
 import org.onap.portalsdk.core.onboarding.crossapi.PortalAPIResponse;
 
 import com.fasterxml.jackson.core.JsonProcessingException;
@@ -47,26 +48,30 @@ import com.fasterxml.jackson.databind.ObjectMapper;
 
 public class JsonMessage {
 
+	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(JsonMessage.class);
+
 	private String data;
 	private String data2;
 	private String data3;
+
 	public JsonMessage(String data) {
 		super();
 		this.data = data;
 	}
-	public JsonMessage(String data,String data2) {
+
+	public JsonMessage(String data, String data2) {
 		super();
 		this.data = data;
 		this.data2 = data2;
 	}
 
-	public JsonMessage(String data,String data2,String data3) {
+	public JsonMessage(String data, String data2, String data3) {
 		super();
 		this.data = data;
 		this.data2 = data2;
 		this.data3 = data3;
 	}
-	
+
 	public String getData() {
 		return data;
 	}
@@ -74,20 +79,23 @@ public class JsonMessage {
 	public void setData(String data) {
 		this.data = data;
 	}
+
 	public String getData2() {
 		return data2;
 	}
+
 	public void setData2(String data2) {
 		this.data2 = data2;
 	}
+
 	public String getData3() {
 		return data3;
 	}
+
 	public void setData3(String data3) {
 		this.data3 = data3;
 	}
-	
-	
+
 	/**
 	 * Builds JSON object with status + message response body.
 	 * 
@@ -107,15 +115,16 @@ public class JsonMessage {
 		try {
 			json = new ObjectMapper().writeValueAsString(response);
 		} catch (JsonProcessingException ex) {
-			// Truly should never, ever happen
+			// Truly should never happen
+			logger.error(EELFLoggerDelegate.errorLogger, "buildJsonResponse failed", ex);
 			json = "{ \"status\": \"error\",\"message\":\"" + ex.toString() + "\" }";
 		}
 		return json;
 	}
 
 	/**
-	 * Builds JSON object with status of error and message containing stack
-	 * trace for the specified throwable.
+	 * Builds JSON object with status of error and message containing stack trace
+	 * for the specified throwable.
 	 * 
 	 * @param t
 	 *            Throwable with stack trace to use as message
@@ -131,6 +140,5 @@ public class JsonMessage {
 		t.printStackTrace(pw);
 		return buildJsonResponse(false, sw.toString());
 	}
-	
-	
+
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/MessagesList.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/MessagesList.java
index a3ab7896..a1d3e276 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/MessagesList.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/MessagesList.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,74 +37,73 @@
  */
 package org.onap.portalsdk.core.web.support;
 
-import java.util.*;
+import java.util.ArrayList;
+import java.util.List;
 
 public class MessagesList {
 
-    private boolean successMessageDisplayed        = true;
-    private boolean includeCauseInCustomExceptions = false;
+	private boolean successMessageDisplayed = true;
+	private boolean includeCauseInCustomExceptions = false;
 
-    private List successMessages;
-    private List exceptionMessages;
+	private List successMessages;
+	private List exceptionMessages;
 
-    public MessagesList() {
-        setExceptionMessages(new ArrayList());
-        setSuccessMessages(new ArrayList());
-    }
+	public MessagesList() {
+		setExceptionMessages(new ArrayList());
+		setSuccessMessages(new ArrayList());
+	}
 
-    public MessagesList(boolean displaySuccess) {
-        this();
-        setSuccessMessageDisplayed(displaySuccess);
-    }
+	public MessagesList(boolean displaySuccess) {
+		this();
+		setSuccessMessageDisplayed(displaySuccess);
+	}
 
-    public List getExceptionMessages() {
-        return exceptionMessages;
-    }
+	public List getExceptionMessages() {
+		return exceptionMessages;
+	}
 
-    public List getSuccessMessages() {
-        return successMessages;
-    }
+	public List getSuccessMessages() {
+		return successMessages;
+	}
 
-    public boolean isSuccessMessageDisplayed() {
-        return successMessageDisplayed;
-    }
+	public boolean isSuccessMessageDisplayed() {
+		return successMessageDisplayed;
+	}
 
-    public boolean isIncludeCauseInCustomExceptions() {
-        return includeCauseInCustomExceptions;
-    }
+	public boolean isIncludeCauseInCustomExceptions() {
+		return includeCauseInCustomExceptions;
+	}
 
+	public void setExceptionMessages(List exceptionMessages) {
+		this.exceptionMessages = exceptionMessages;
+	}
 
-    public void setExceptionMessages(List exceptionMessages) {
-        this.exceptionMessages = exceptionMessages;
-    }
+	public void setSuccessMessages(List successMessages) {
+		this.successMessages = successMessages;
+	}
 
-    public void setSuccessMessages(List successMessages) {
-        this.successMessages = successMessages;
-    }
+	public void setSuccessMessageDisplayed(boolean successMessageDisplayed) {
+		this.successMessageDisplayed = successMessageDisplayed;
+	}
 
-    public void setSuccessMessageDisplayed(boolean successMessageDisplayed) {
-        this.successMessageDisplayed = successMessageDisplayed;
-    }
+	public void setIncludeCauseInCustomExceptions(boolean includeCauseInCustomExceptions) {
+		this.includeCauseInCustomExceptions = includeCauseInCustomExceptions;
+	}
 
-    public void setIncludeCauseInCustomExceptions(boolean includeCauseInCustomExceptions) {
-        this.includeCauseInCustomExceptions = includeCauseInCustomExceptions;
-    }
+	public void addSuccessMessage(FeedbackMessage message) {
+		getSuccessMessages().add(message);
+	}
 
+	public void addExceptionMessage(FeedbackMessage message) {
+		getExceptionMessages().add(message);
+	}
 
-    public void addSuccessMessage(FeedbackMessage message) {
-        getSuccessMessages().add(message);
-    }
+	public boolean hasExceptionMessages() {
+		return !getExceptionMessages().isEmpty();
+	}
 
-    public void addExceptionMessage(FeedbackMessage message) {
-        getExceptionMessages().add(message);
-    }
-
-    public boolean hasExceptionMessages() {
-        return!getExceptionMessages().isEmpty();
-    }
-
-    public boolean hasSuccessMessages() {
-        return!getSuccessMessages().isEmpty();
-    }
+	public boolean hasSuccessMessages() {
+		return !getSuccessMessages().isEmpty();
+	}
 
 }
diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/UserUtils.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/UserUtils.java
index 98e437d9..5395521b 100644
--- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/UserUtils.java
+++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/UserUtils.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -44,6 +44,7 @@ import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Iterator;
 import java.util.List;
+import java.util.Map;
 import java.util.Set;
 import java.util.TreeSet;
 import java.util.UUID;
@@ -61,9 +62,7 @@ import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
 import org.onap.portalsdk.core.menu.MenuBuilder;
 import org.onap.portalsdk.core.restful.domain.EcompRole;
 import org.onap.portalsdk.core.restful.domain.EcompUser;
-import org.onap.portalsdk.core.service.DataAccessService;
 import org.onap.portalsdk.core.util.SystemProperties;
-import org.springframework.beans.factory.annotation.Autowired;
 
 @SuppressWarnings("rawtypes")
 public class UserUtils {
@@ -72,10 +71,8 @@ public class UserUtils {
 
 	public static final String KEY_USER_ROLES_CACHE = "userRoles";
 
-	private static DataAccessService dataAccessService;
-
 	public static void setUserSession(HttpServletRequest request, User user, Set applicationMenuData,
-			Set businessDirectMenuData, String loginMethod , List roleFunctionList) {
+			Set businessDirectMenuData, String loginMethod, List roleFunctionList) {
 		HttpSession session = request.getSession(true);
 
 		UserUtils.clearUserSession(request); // let's clear the current user
@@ -97,7 +94,7 @@ public class UserUtils {
 		try {
 			licenseVarificationFlag = (Integer) context.getAttribute("licenseVerification");
 		} catch (Exception e) {
-			logger.error(EELFLoggerDelegate.debugLogger, "Error while get license varification " + e.getMessage());
+			logger.error(EELFLoggerDelegate.errorLogger, "setUserSession failed on license verification", e);
 		}
 		String displayName = "";
 		if (SystemProperties.getProperty(SystemProperties.APP_DISPLAY_NAME) != null)
@@ -146,14 +143,12 @@ public class UserUtils {
 
 	@SuppressWarnings("unchecked")
 	public static Set getRoleFunctions(HttpServletRequest request) {
-		HashSet roleFunctions = null;
-//		HashSet rolefun = null;
 		HttpSession session = request.getSession();
-		roleFunctions = (HashSet) session
+		HashSet roleFunctions = (HashSet) session
 				.getAttribute(SystemProperties.getProperty(SystemProperties.ROLE_FUNCTIONS_ATTRIBUTE_NAME));
 
 		if (roleFunctions == null) {
-			HashMap roles = getRoles(request);
+			Map roles = getRoles(request);
 			roleFunctions = new HashSet();
 
 			Iterator i = roles.keySet().iterator();
@@ -175,12 +170,10 @@ public class UserUtils {
 		return roleFunctions;
 	}
 
-	public static HashMap getRoles(HttpServletRequest request) {
-		HashMap roles = null;
-
+	public static Map getRoles(HttpServletRequest request) {
 		// HttpSession session = request.getSession();
 		HttpSession session = AppUtils.getSession(request);
-		roles = (HashMap) session.getAttribute(SystemProperties.getProperty(SystemProperties.ROLES_ATTRIBUTE_NAME));
+		Map roles = (Map) session.getAttribute(SystemProperties.getProperty(SystemProperties.ROLES_ATTRIBUTE_NAME));
 
 		// if roles are not already cached, let's grab them from the user
 		// session
@@ -208,7 +201,7 @@ public class UserUtils {
 	}
 
 	@SuppressWarnings("unchecked")
-	public static HashMap getAllUserRoles(User user) {
+	public static Map getAllUserRoles(User user) {
 		HashMap roles = new HashMap();
 		Iterator i = user.getRoles().iterator();
 
@@ -228,9 +221,9 @@ public class UserUtils {
 	}
 
 	@SuppressWarnings("unchecked")
-	private static void addChildRoles(Role role, HashMap roles) {
+	private static void addChildRoles(Role role, Map roles) {
 		Set childRoles = role.getChildRoles();
-		if (childRoles != null && childRoles.size() > 0) {
+		if (childRoles != null && !childRoles.isEmpty()) {
 			Iterator j = childRoles.iterator();
 			while (j.hasNext()) {
 				Role childRole = (Role) j.next();
@@ -243,8 +236,6 @@ public class UserUtils {
 
 	}
 
-
-
 	public static boolean hasRole(HttpServletRequest request, String roleKey) {
 		return getRoles(request).keySet().contains(new Long(roleKey));
 	}
@@ -268,27 +259,15 @@ public class UserUtils {
 				.getAttribute(SystemProperties.getProperty(SystemProperties.LOGIN_METHOD_ATTRIBUTE_NAME));
 	}
 
-	public static DataAccessService getDataAccessService() {
-		return dataAccessService;
-	}
-
-	@Autowired
-	public void setDataAccessService(DataAccessService dataAccessService) {
-		UserUtils.dataAccessService = dataAccessService;
-	}
-
 	public static int getUserId(HttpServletRequest request) {
 		return getUserIdAsLong(request).intValue();
 	}
 
 	public static Long getUserIdAsLong(HttpServletRequest request) {
 		Long userId = new Long(SystemProperties.getProperty(SystemProperties.APPLICATION_USER_ID));
-
-		if (request != null) {
-			if (getUserSession(request) != null) {
+		if (request != null  && getUserSession(request) != null) 
 				userId = getUserSession(request).getId();
-			}
-		}
+
 		return userId;
 	}
 
@@ -313,8 +292,7 @@ public class UserUtils {
 	}
 
 	/**
-	 * Gets the full URL of the request by joining the request and any query
-	 * string.
+	 * Gets the full URL of the request by joining the request and any query string.
 	 * 
 	 * @param request
 	 * @return Full URL of the request including query parameters
@@ -334,8 +312,8 @@ public class UserUtils {
 	}
 
 	/**
-	 * Gets or generates a request ID by searching for header X-ECOMP-RequestID.
-	 * If not found, generates a new random UUID.
+	 * Gets or generates a request ID by searching for header X-ECOMP-RequestID. If
+	 * not found, generates a new random UUID.
 	 * 
 	 * @param request
 	 * @return Request ID for the specified request
@@ -346,7 +324,7 @@ public class UserUtils {
 		String requestId = "";
 		try {
 			while (headerNames.hasMoreElements()) {
-				String headerName = (String) headerNames.nextElement();
+				String headerName = headerNames.nextElement();
 				if (logger.isTraceEnabled())
 					logger.trace(EELFLoggerDelegate.debugLogger, "getRequestId: header {} = {}", headerName,
 							request.getHeader(headerName));
@@ -386,7 +364,7 @@ public class UserUtils {
 		userJson.setOrgId(user.getOrgId());
 		userJson.setPhone(user.getPhone());
 		userJson.setOrgUserId(user.getOrgUserId());
-		Set ecompRoles = new TreeSet();
+		Set ecompRoles = new TreeSet<>();
 		for (Role role : user.getRoles()) {
 			ecompRoles.add(convertToEcompRole(role));
 		}
@@ -408,6 +386,4 @@ public class UserUtils {
 		return ecompRole;
 	}
 
-	}
-
-
+}
diff --git a/ecomp-sdk/epsdk-core/src/test/java/org/onap/portalsdk/MockApplicationContextTestSuite.java b/ecomp-sdk/epsdk-core/src/test/java/org/onap/portalsdk/MockApplicationContextTestSuite.java
index 3b661672..64b21344 100644
--- a/ecomp-sdk/epsdk-core/src/test/java/org/onap/portalsdk/MockApplicationContextTestSuite.java
+++ b/ecomp-sdk/epsdk-core/src/test/java/org/onap/portalsdk/MockApplicationContextTestSuite.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-core/src/test/java/org/onap/portalsdk/MockHibernateMappingLocations.java b/ecomp-sdk/epsdk-core/src/test/java/org/onap/portalsdk/MockHibernateMappingLocations.java
index 6a0d7e11..8afe46e2 100644
--- a/ecomp-sdk/epsdk-core/src/test/java/org/onap/portalsdk/MockHibernateMappingLocations.java
+++ b/ecomp-sdk/epsdk-core/src/test/java/org/onap/portalsdk/MockHibernateMappingLocations.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/crossapi/IPortalRestAPIService.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/crossapi/IPortalRestAPIService.java
index 182d2675..2fd141a0 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/crossapi/IPortalRestAPIService.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/crossapi/IPortalRestAPIService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/crossapi/IPortalUebAPIService.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/crossapi/IPortalUebAPIService.java
index aa11aafe..3f6614a4 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/crossapi/IPortalUebAPIService.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/crossapi/IPortalUebAPIService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/crossapi/PortalAPIResponse.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/crossapi/PortalAPIResponse.java
index 6ae2cdd8..6e55c9e3 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/crossapi/PortalAPIResponse.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/crossapi/PortalAPIResponse.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -51,10 +51,10 @@ public class PortalAPIResponse {
 	 * Optional if status is ok
 	 */
 	private String message;
-	
+
 	public PortalAPIResponse(boolean isOk, String msg) {
-		status = (isOk? "ok" : "error");
-		message = msg; 
+		status = isOk ? "ok" : "error";
+		message = msg;
 	}
 
 	public String getStatus() {
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/crossapi/PortalRestAPIProxy.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/crossapi/PortalRestAPIProxy.java
index 869500f2..83dc9c43 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/crossapi/PortalRestAPIProxy.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/crossapi/PortalRestAPIProxy.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -88,11 +88,12 @@ import com.fasterxml.jackson.databind.ObjectMapper;
 
 @WebServlet(urlPatterns = { PortalApiConstants.API_PREFIX + "/*" })
 public class PortalRestAPIProxy extends HttpServlet implements IPortalRestAPIService {
+	
 	private static final long serialVersionUID = 1L;
 
-	private static final String contentTypeAppJson = "application/json";
+	private static final String APPLICATION_JSON = "application/json";
 
-	private final Log logger = LogFactory.getLog(getClass());
+	private static final Log logger = LogFactory.getLog(PortalRestAPIProxy.class);
 
 	/**
 	 * Mapper for JSON to object etc.
@@ -163,8 +164,7 @@ public class PortalRestAPIProxy extends HttpServlet implements IPortalRestAPISer
 					requestBody = mapper.writeValueAsString(bodyMap);
 					responseJson = RestWebServiceClient.getInstance().postPortalContent(storeAnalyticsContextPath,
 							userId, credential, null, credential, credential, "application/json", requestBody, true);
-					if (logger.isDebugEnabled())
-						logger.debug("doPost: postPortalContent returns " + responseJson);
+					logger.debug("doPost: postPortalContent returns " + responseJson);
 					response.setStatus(HttpServletResponse.SC_OK);
 				} catch (Exception ex) {
 					logger.error("doPost: " + storeAnalyticsContextPath + " caught exception", ex);
@@ -172,7 +172,7 @@ public class PortalRestAPIProxy extends HttpServlet implements IPortalRestAPISer
 					response.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
 				}
 			}
-			writeAndFlush(response, contentTypeAppJson, responseJson);
+			writeAndFlush(response, APPLICATION_JSON, responseJson);
 			return;
 		} // post analytics
 
@@ -186,10 +186,9 @@ public class PortalRestAPIProxy extends HttpServlet implements IPortalRestAPISer
 			return;
 		}
 		if (!secure) {
-			if (logger.isDebugEnabled())
-				logger.debug("doPost: isAppAuthenticated answered false");
+			logger.debug("doPost: isAppAuthenticated answered false");
 			response.setStatus(HttpServletResponse.SC_UNAUTHORIZED);
-			writeAndFlush(response, contentTypeAppJson, buildJsonResponse(false, "Not authorized"));
+			writeAndFlush(response, APPLICATION_JSON, buildJsonResponse(false, "Not authorized"));
 			return;
 		}
 
@@ -212,8 +211,7 @@ public class PortalRestAPIProxy extends HttpServlet implements IPortalRestAPISer
 
 			if (requestUri.endsWith("/updateSessionTimeOuts")) {
 				if (updateSessionTimeOuts(requestBody)) {
-					if (logger.isDebugEnabled())
-						logger.debug("doPost: updated session timeouts");
+					logger.debug("doPost: updated session timeouts");
 					response.setStatus(HttpServletResponse.SC_OK);
 				} else {
 					String msg = "Failed to update session time outs";
@@ -227,8 +225,7 @@ public class PortalRestAPIProxy extends HttpServlet implements IPortalRestAPISer
 					portalJSessionId = "";
 				}
 				if (timeoutSession(portalJSessionId)) {
-					if (logger.isDebugEnabled())
-						logger.debug("doPost: timed out session");
+					logger.debug("doPost: timed out session");
 					response.setStatus(HttpServletResponse.SC_OK);
 				} else {
 					String msg = "Failed to timeout session";
@@ -242,8 +239,7 @@ public class PortalRestAPIProxy extends HttpServlet implements IPortalRestAPISer
 				try {
 					EcompUser user = mapper.readValue(requestBody, EcompUser.class);
 					pushUser(user);
-					if (logger.isDebugEnabled())
-						logger.debug("doPost: pushUser: success");
+					logger.debug("doPost: pushUser: success");
 					responseJson = buildJsonResponse(true, null);
 					response.setStatus(HttpServletResponse.SC_OK);
 				} catch (Exception ex) {
@@ -258,8 +254,7 @@ public class PortalRestAPIProxy extends HttpServlet implements IPortalRestAPISer
 				try {
 					EcompUser user = mapper.readValue(requestBody, EcompUser.class);
 					editUser(loginId, user);
-					if (logger.isDebugEnabled())
-						logger.debug("doPost: editUser: success");
+					logger.debug("doPost: editUser: success");
 					responseJson = buildJsonResponse(true, null);
 					response.setStatus(HttpServletResponse.SC_OK);
 				} catch (Exception ex) {
@@ -277,8 +272,7 @@ public class PortalRestAPIProxy extends HttpServlet implements IPortalRestAPISer
 					};
 					List roles = mapper.readValue(requestBody, typeRef);
 					pushUserRole(loginId, roles);
-					if (logger.isDebugEnabled())
-						logger.debug("doPost: pushUserRole: success");
+					logger.debug("doPost: pushUserRole: success");
 					responseJson = buildJsonResponse(true, null);
 					response.setStatus(HttpServletResponse.SC_OK);
 				} catch (Exception ex) {
@@ -298,7 +292,7 @@ public class PortalRestAPIProxy extends HttpServlet implements IPortalRestAPISer
 			responseJson = buildJsonResponse(ex);
 		}
 
-		writeAndFlush(response, contentTypeAppJson, responseJson);
+		writeAndFlush(response, APPLICATION_JSON, responseJson);
 
 	}
 
@@ -310,17 +304,16 @@ public class PortalRestAPIProxy extends HttpServlet implements IPortalRestAPISer
 			// Should never happen due to checks in init()
 			logger.error("doGet: no service class instance");
 			response.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
-			writeAndFlush(response, contentTypeAppJson,
+			writeAndFlush(response, APPLICATION_JSON,
 					buildJsonResponse(false, "Misconfigured - no instance of service class"));
 			return;
 		}
 
 		String requestUri = request.getRequestURI();
-		String responseString = "";
-		String contentType = contentTypeAppJson;
-
+		String contentType = APPLICATION_JSON;
 		String webAnalyticsContextPath = "/analytics";
 		if (requestUri.endsWith(PortalApiConstants.API_PREFIX + webAnalyticsContextPath)) {
+			String responseString;
 			String userId;
 			try {
 				userId = getUserId(request);
@@ -360,7 +353,7 @@ public class PortalRestAPIProxy extends HttpServlet implements IPortalRestAPISer
 		} catch (PortalAPIException ex) {
 			logger.error("doGet: isAppAuthenticated threw exception", ex);
 			response.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
-			writeAndFlush(response, contentTypeAppJson, buildJsonResponse(false, "Failed to authenticate request"));
+			writeAndFlush(response, APPLICATION_JSON, buildJsonResponse(false, "Failed to authenticate request"));
 			return;
 		}
 
@@ -368,16 +361,14 @@ public class PortalRestAPIProxy extends HttpServlet implements IPortalRestAPISer
 			if (logger.isDebugEnabled())
 				logger.debug("doGet: isAppAuthenticated answered false");
 			response.setStatus(HttpServletResponse.SC_UNAUTHORIZED);
-			writeAndFlush(response, contentTypeAppJson, buildJsonResponse(false, "Not authorized"));
+			writeAndFlush(response, APPLICATION_JSON, buildJsonResponse(false, "Not authorized"));
 			return;
 		}
 
 		String responseJson = null;
 		try {
 			// Ignore any request body in a GET.
-			// String requestBody = readRequestBody(request);
-			if (logger.isDebugEnabled())
-				logger.debug("doGet: URI =  " + requestUri);
+			logger.debug("doGet: URI =  " + requestUri);
 
 			/*
 			 * 1. /roles <-- get roles
@@ -392,8 +383,7 @@ public class PortalRestAPIProxy extends HttpServlet implements IPortalRestAPISer
 			if (requestUri.endsWith("/sessionTimeOuts")) {
 				responseJson = getSessionTimeOuts();
 				if (responseJson != null && responseJson.length() > 0) {
-					if (logger.isDebugEnabled())
-						logger.debug("doGet: got session timeouts");
+					logger.debug("doGet: got session timeouts");
 					response.setStatus(HttpServletResponse.SC_OK);
 				} else {
 					String msg = "Failed to get session time outs";
@@ -467,7 +457,7 @@ public class PortalRestAPIProxy extends HttpServlet implements IPortalRestAPISer
 			response.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
 			responseJson = buildJsonResponse(ex);
 		}
-		writeAndFlush(response, contentTypeAppJson, responseJson);
+		writeAndFlush(response, APPLICATION_JSON, responseJson);
 	}
 
 	public String getSessionTimeOuts() {
@@ -567,7 +557,7 @@ public class PortalRestAPIProxy extends HttpServlet implements IPortalRestAPISer
 				try {
 					bufferedReader.close();
 				} catch (IOException ex) {
-					throw ex;
+					logger.error("readRequestBody", ex);
 				}
 			}
 		}
@@ -595,6 +585,7 @@ public class PortalRestAPIProxy extends HttpServlet implements IPortalRestAPISer
 			json = mapper.writeValueAsString(response);
 		} catch (JsonProcessingException ex) {
 			// Truly should never, ever happen
+			logger.error("buildJsonResponse", ex);
 			json = "{ \"status\": \"error\",\"message\":\"" + ex.toString() + "\" }";
 		}
 		return json;
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/crossapi/SessionCommunicationService.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/crossapi/SessionCommunicationService.java
index 1f9bfd07..fb2e6f86 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/crossapi/SessionCommunicationService.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/crossapi/SessionCommunicationService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -47,7 +47,7 @@ import org.apache.commons.logging.LogFactory;
 
 public class SessionCommunicationService {
 
-	protected static final Log logger = LogFactory.getLog(SessionCommunicationService.class);
+	private static final Log logger = LogFactory.getLog(SessionCommunicationService.class);
 
 	/**
 	 * Calls the ECOMP Portal to retrieve the session slot check interval.
@@ -87,13 +87,12 @@ public class SessionCommunicationService {
 				logger.debug("getSessionSlotCheckInterval: Response Code : " + responseCode);
 			}
 
-			StringBuffer response = new StringBuffer();			
+			StringBuilder response = new StringBuilder();
 			try (BufferedReader in = new BufferedReader(new InputStreamReader(con.getInputStream(), "UTF-8"))) {
 				String inputLine;
 				while ((inputLine = in.readLine()) != null)
 					response.append(inputLine);
-			}
-			catch (Exception ex) {
+			} catch (Exception ex) {
 				logger.error("getSessionSlotCheckInterval failed to read stream", ex);
 			}
 			return response.toString();
@@ -124,7 +123,6 @@ public class SessionCommunicationService {
 			String uebKey, String sessionTimeoutMap) {
 
 		try {
-
 			String url = ecompRestURL + "/extendSessionTimeOuts";
 			URL obj = new URL(url);
 
@@ -145,16 +143,14 @@ public class SessionCommunicationService {
 			con.getOutputStream().flush();
 			con.getOutputStream().close();
 
-			// con.set
-
 			int responseCode = con.getResponseCode();
 			if (logger.isDebugEnabled()) {
 				logger.debug("requestPortalSessionTimeoutExtension: Sending 'GET' request to URL : " + url);
 				logger.debug("requestPortalSessionTimeoutExtension: Response Code : " + responseCode);
 			}
 
-			StringBuffer response = new StringBuffer();
-			try (BufferedReader       in = new BufferedReader(new InputStreamReader(con.getInputStream()))) {
+			StringBuilder response = new StringBuilder();
+			try (BufferedReader in = new BufferedReader(new InputStreamReader(con.getInputStream()))) {
 				String inputLine;
 				while ((inputLine = in.readLine()) != null) {
 					response.append(inputLine);
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/exception/CipherUtilException.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/exception/CipherUtilException.java
index a1109abe..3f7b8905 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/exception/CipherUtilException.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/exception/CipherUtilException.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/exception/PortalAPIException.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/exception/PortalAPIException.java
index ccfb95b2..0f572073 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/exception/PortalAPIException.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/exception/PortalAPIException.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/listener/PortalTimeoutBindingListener.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/listener/PortalTimeoutBindingListener.java
index f700f261..664ce41d 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/listener/PortalTimeoutBindingListener.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/listener/PortalTimeoutBindingListener.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -56,7 +56,7 @@ public class PortalTimeoutBindingListener implements HttpSessionBindingListener,
 	@Override
 	public void valueBound(HttpSessionBindingEvent event) {
 		final HttpSession session = event.getSession();
-		PortalTimeoutHandler.sessionMap.put((String) session.getAttribute(PortalApiConstants.PORTAL_JSESSION_ID),
+		PortalTimeoutHandler.getSessionMap().put((String) session.getAttribute(PortalApiConstants.PORTAL_JSESSION_ID),
 				session);
 	}
 
@@ -65,7 +65,7 @@ public class PortalTimeoutBindingListener implements HttpSessionBindingListener,
 		final HttpSession session = event.getSession();
 		String portalJSessionId = (String) session.getAttribute(PortalApiConstants.PORTAL_JSESSION_ID);
 		logger.debug(portalJSessionId + " getting removed");
-		PortalTimeoutHandler.sessionMap.remove(portalJSessionId);
+		PortalTimeoutHandler.getSessionMap().remove(portalJSessionId);
 	}
 
 }
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/listener/PortalTimeoutHandler.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/listener/PortalTimeoutHandler.java
index 649fb747..3cc1eb98 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/listener/PortalTimeoutHandler.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/listener/PortalTimeoutHandler.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -60,6 +60,11 @@ import com.fasterxml.jackson.databind.ObjectMapper;
  */
 public class PortalTimeoutHandler {
 
+	private static final Map sessionMap = new Hashtable();
+	private static final Log logger = LogFactory.getLog(PortalTimeoutHandler.class);
+	private static ObjectMapper mapper = new ObjectMapper();
+	private static PortalTimeoutHandler timeoutHandler;
+
 	protected static final SessionCommInf sessionComm = new SessionComm();
 
 	public interface SessionCommInf {
@@ -69,13 +74,13 @@ public class PortalTimeoutHandler {
 	}
 
 	public static class SessionComm implements SessionCommInf {
+		
+		@Override
 		public Integer fetchSessionSlotCheckInterval(String... params) {
-
 			String ecompRestURL = params[0];
 			String userName = params[1];
 			String pwd = params[2];
 			String uebKey = params[3];
-
 			String sessionSlot = SessionCommunicationService.getSessionSlotCheckInterval(ecompRestURL, userName, pwd,
 					uebKey);
 			if (sessionSlot == null)
@@ -83,25 +88,22 @@ public class PortalTimeoutHandler {
 			return Integer.parseInt(sessionSlot);
 		}
 
+		@Override
 		public void extendSessionTimeOuts(String... params) {
-
 			String ecompRestURL = params[0];
 			String userName = params[1];
 			String pwd = params[2];
 			String uebKey = params[3];
 			String sessionTimeoutMap = params[4];
-
 			SessionCommunicationService.requestPortalSessionTimeoutExtension(ecompRestURL, userName, pwd, uebKey,
 					sessionTimeoutMap);
 		}
 	}
 
-	public static final Map sessionMap = new Hashtable();
-	public static final Integer repeatInterval = 15 * 60; // 15 minutes
-	protected static final Log logger = LogFactory.getLog(PortalTimeoutHandler.class);
-	static ObjectMapper mapper = new ObjectMapper();
-	private static PortalTimeoutHandler timeoutHandler;
-
+	public static Map getSessionMap() {
+		return sessionMap;
+	}
+	
 	public static PortalTimeoutHandler getInstance() {
 		if (timeoutHandler == null)
 			timeoutHandler = new PortalTimeoutHandler();
@@ -141,9 +143,6 @@ public class PortalTimeoutHandler {
 		// and with session replication the listener will fire in all tomcat
 		// instances
 		session.setAttribute(PortalApiConstants.PORTAL_JSESSION_BIND, new PortalTimeoutBindingListener());
-		// sessionMap.put((String)session.getAttribute(PortalApiConstants.PORTAL_JSESSION_ID),
-		// session);
-
 	}
 
 	/**
@@ -166,7 +165,6 @@ public class PortalTimeoutHandler {
 		try {
 			logger.info(" Session getting destroyed - id: " + session.getId());
 			session.removeAttribute(PortalApiConstants.PORTAL_JSESSION_BIND);
-			// sessionMap.remove((String)session.getAttribute(PortalApiConstants.PORTAL_JSESSION_ID));
 		} catch (Exception e) {
 			logger.error("sessionDestroyed failed", e);
 		}
@@ -204,21 +202,17 @@ public class PortalTimeoutHandler {
 	public static String gatherSessionExtensions() {
 		logger.debug("Session Management: gatherSessionExtensions");
 
-		Map sessionTimeoutMap = new Hashtable();
+		Map sessionTimeoutMap = new Hashtable<>();
 		String jsonMap = "";
 
 		for (String jSessionKey : sessionMap.keySet()) {
 
 			try {
-				// get the expirytime in seconds
+				// get the expiry time in seconds
 				HttpSession session = sessionMap.get(jSessionKey);
 
 				Long lastAccessedTimeMilliSec = session.getLastAccessedTime();
 				Long maxIntervalMilliSec = session.getMaxInactiveInterval() * 1000L;
-				// Long currentTimeMilliSec =
-				// Calendar.getInstance().getTimeInMillis() ;
-				// (maxIntervalMilliSec - (currentTimeMilliSec -
-				// lastAccessedTimeMilliSec) + ;
 				Calendar instance = Calendar.getInstance();
 				instance.setTimeInMillis(session.getLastAccessedTime());
 				logger.debug("Session Management: Last Accessed time for " + jSessionKey + ": " + instance.getTime());
@@ -237,9 +231,7 @@ public class PortalTimeoutHandler {
 			}
 
 		}
-
 		return jsonMap;
-
 	}
 
 	/**
@@ -251,10 +243,7 @@ public class PortalTimeoutHandler {
 	 */
 	public static boolean updateSessionExtensions(String sessionTimeoutMapStr) {
 		logger.debug("Session Management: updateSessionExtensions");
-		// Map sessionTimeoutMap =
-		// mapper.readValue(sessionTimeoutMapStr, Map.class);
 		Map sessionTimeoutMap = null;
-
 		try {
 			TypeReference> typeRef = new TypeReference>() {
 			};
@@ -284,9 +273,6 @@ public class PortalTimeoutHandler {
 					session.setMaxInactiveInterval((int) (maxTimeoutTimeMilliSec - lastAccessedTimeMilliSec) / 1000);
 					logger.debug("Session Management: extended session for :" + session.getId() + " to :"
 							+ (int) (maxTimeoutTimeMilliSec / 1000));
-					// System.out.println("!!!!!!!!!extended session for :" +
-					// session.getId() + " to :" +
-					// (int)(maxTimeoutTimeMilliSec/1000));
 				}
 			} catch (Exception e) {
 				logger.error("updateSessionExtensions failed to update session timeouts", e);
@@ -381,7 +367,7 @@ public class PortalTimeoutHandler {
 					- (lastAccessedTimeMilliSec - previousToLastAccessTime) <= portalSessionSlotCheckinMilliSec) {
 
 				String jSessionKey = (String) session.getAttribute(PortalApiConstants.PORTAL_JSESSION_ID);
-				Map sessionTimeoutMap = new Hashtable();
+				Map sessionTimeoutMap = new Hashtable<>();
 				Long sessionTimOutMilliSec = maxIntervalMilliSec + lastAccessedTimeMilliSec;
 
 				sessionTimeoutMap.put(PortalTimeoutHandler.portalJSessionId(jSessionKey),
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/listener/UserContextListener.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/listener/UserContextListener.java
index 8599a67c..3b422c3e 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/listener/UserContextListener.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/listener/UserContextListener.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -50,19 +50,21 @@ import org.onap.portalsdk.core.onboarding.util.PortalApiConstants;
 @WebListener
 public class UserContextListener implements ServletContextListener {
 
+	@Override
 	public void contextInitialized(ServletContextEvent event) {
 		ServletContext context = event.getServletContext();
 		//
 		// create a map to store references to all the active
 		// sessions and bind it to context scope.
 		//
-		HashMap activeUsers = new HashMap();
+		HashMap activeUsers = new HashMap<>();
 		context.setAttribute(PortalApiConstants.ACTIVE_USERS_NAME, activeUsers);
 	}
 
 	/**
 	 * Needed for the ServletContextListener interface.
 	 */
+	@Override
 	public void contextDestroyed(ServletContextEvent event) {
 		// To overcome the problem with losing the session references
 		// during server restarts, put code here to serialize the
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/listener/UserSessionListener.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/listener/UserSessionListener.java
index 95b2d44e..bf1732a0 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/listener/UserSessionListener.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/listener/UserSessionListener.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -60,7 +60,7 @@ public class UserSessionListener implements HttpSessionListener {
 
 	private Log logger = LogFactory.getLog(getClass());
 
-	public static Map activeSessions = new Hashtable();
+	private static Map activeSessions = new Hashtable<>();
 
 	public void init(ServletConfig config) {
 	}
@@ -68,6 +68,7 @@ public class UserSessionListener implements HttpSessionListener {
 	/**
 	 * Adds sessions to the context-scoped HashMap when they begin.
 	 */
+	@Override
 	public void sessionCreated(HttpSessionEvent event) {
 		HttpSession session = event.getSession();
 		ServletContext context = session.getServletContext();
@@ -85,6 +86,7 @@ public class UserSessionListener implements HttpSessionListener {
 	 * Removes sessions from the context-scoped HashMap when they expire or are
 	 * invalidated.
 	 */
+	@Override
 	public void sessionDestroyed(HttpSessionEvent event) {
 		try {
 			HttpSession session = event.getSession();
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/rest/FavoritesClient.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/rest/FavoritesClient.java
index 92ea75a8..6c1a63c3 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/rest/FavoritesClient.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/rest/FavoritesClient.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/rest/FunctionalMenuClient.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/rest/FunctionalMenuClient.java
index 7fc98c67..cd5d510f 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/rest/FunctionalMenuClient.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/rest/FunctionalMenuClient.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/rest/RestWebServiceClient.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/rest/RestWebServiceClient.java
index 7c9f72a1..1533db79 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/rest/RestWebServiceClient.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/rest/RestWebServiceClient.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -365,7 +365,7 @@ public class RestWebServiceClient {
 		con.getOutputStream().close();
 
 		int responseCode = con.getResponseCode();
-		logger.debug("Response Code : " + responseCode);
+		logger.debug("RestWebServiceClient.post: response code " + responseCode);
 		final String response = readAndCloseStream(con.getInputStream());
 		return response;
 	}
@@ -461,7 +461,7 @@ public class RestWebServiceClient {
 			throws IOException {
 
 		if (logger.isDebugEnabled())
-			logger.debug("RestWebServiceClient.post to URL " + url);
+			logger.debug("RestWebServiceClient.delete to URL " + url);
 		if (appName == null || appName.trim().length() == 0)
 			appName = "Unknown";
 		if (requestId == null || requestId.trim().length() == 0)
@@ -505,14 +505,13 @@ public class RestWebServiceClient {
 		con.getOutputStream().close();
 
 		int responseCode = con.getResponseCode();
-		logger.debug("Response Code : " + responseCode);
+		logger.debug("RestWebServiceClient.delete: response code " + responseCode);
 		final String response = readAndCloseStream(con.getInputStream());
 		return response;
 	}
 
 	/**
-	 * Reads content of string to a StringBuffer, decoded as UTF-8, and returns as
-	 * string.
+	 * Reads content of stream, decodes as UTF-8, and returns as string.
 	 * 
 	 * @param inputStream
 	 *            Stream to read
@@ -520,17 +519,15 @@ public class RestWebServiceClient {
 	 * @throws IOException
 	 */
 	private String readAndCloseStream(InputStream inputStream) throws IOException {
-		StringBuffer sb = new StringBuffer();
-		InputStreamReader in = null;
-		char[] buf = new char[8196];
-		int bytes;
-		try {
-			in = new InputStreamReader(inputStream, "UTF-8");
+		StringBuilder sb = new StringBuilder();
+		try (InputStreamReader in = new InputStreamReader(inputStream, "UTF-8")) {
+			char[] buf = new char[8196];
+			int bytes;
 			while ((bytes = in.read(buf)) > 0)
 				sb.append(new String(buf, 0, bytes));
-		} finally {
-			if (in != null)
-				in.close();
+		}
+		catch (Exception ex) {
+			logger.error("readAndCloseStream", ex);
 		}
 		return sb.toString();
 	}
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/util/CipherUtil.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/util/CipherUtil.java
index f3125f03..ce70c717 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/util/CipherUtil.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/util/CipherUtil.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -145,14 +145,14 @@ public class CipherUtil {
 
 	public static void main(String[] args) throws CipherUtilException {
 
-		String password = "Welcome123";
+		String testValue = "Welcome123";
 		String encrypted;
 		String decrypted;
 
 		if (args.length != 2) {
 			System.out.println("Default password testing... ");
-			System.out.println("Plain password: " + password);
-			encrypted = encrypt(password);
+			System.out.println("Plain password: " + testValue);
+			encrypted = encrypt(testValue);
 			System.out.println("Encrypted password: " + encrypted);
 			decrypted = decrypt(encrypted);
 			System.out.println("Decrypted  password: " + decrypted);
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/util/PortalApiConstants.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/util/PortalApiConstants.java
index 1419851a..eb931f5c 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/util/PortalApiConstants.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/util/PortalApiConstants.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/util/PortalApiProperties.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/util/PortalApiProperties.java
index 3d5ddae8..7f67818e 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/util/PortalApiProperties.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/util/PortalApiProperties.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/util/SSOFilter.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/util/SSOFilter.java
index 00afecaf..855786ba 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/util/SSOFilter.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/util/SSOFilter.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -56,18 +56,19 @@ public class SSOFilter implements Filter {
 
 	private final Log logger = LogFactory.getLog(getClass());
 
+	@Override
 	public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain)
 			throws java.io.IOException, ServletException {
 
 		try {
 			if (PortalRestAPIProxy.getPortalRestApiServiceImpl().getUserId((HttpServletRequest) request) == null) {
-				String redirectURL = SSOUtil.getECOMPSSORedirectURL(((HttpServletRequest) request),
-						((HttpServletResponse) response),
-						(((HttpServletRequest) request).getRequestURI()
+				String redirectURL = SSOUtil.getECOMPSSORedirectURL((HttpServletRequest) request,
+						(HttpServletResponse) response,
+						((HttpServletRequest) request).getRequestURI()
 								.substring(((HttpServletRequest) request).getContextPath().length() + 1)
 								+ (((HttpServletRequest) request).getQueryString() != null
 										? ("?" + ((HttpServletRequest) request).getQueryString())
-										: "")));
+										: ""));
 
 				((HttpServletResponse) response).sendRedirect(redirectURL);
 
@@ -83,12 +84,14 @@ public class SSOFilter implements Filter {
 
 	}
 
+	@Override
 	public void destroy() {
-
+		logger.trace("destroy called");
 	}
 
+	@Override
 	public void init(FilterConfig arg0) throws ServletException {
-		// TODO Auto-generated method stub
-
+		logger.trace("init called");
 	}
+	
 }
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/util/SSOUtil.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/util/SSOUtil.java
index 9a5428f4..2d491cfa 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/util/SSOUtil.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/onboarding/util/SSOUtil.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -69,7 +69,7 @@ public class SSOUtil {
 		try {
 			encodedAppURL = URLEncoder.encode(appURL, "UTF-8");
 		} catch (UnsupportedEncodingException ex) {
-			logger.error("getECOMPSSORedirectURL: Failed to encode app URL " + appURL);
+			logger.error("getECOMPSSORedirectURL: Failed to encode app URL " + appURL, ex);
 		}
 		String portalURL = PortalApiProperties.getProperty(PortalApiConstants.ECOMP_REDIRECT_URL);
 		if (portalURL == null || portalURL.length() == 0) {
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/restful/domain/EcompRole.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/restful/domain/EcompRole.java
index 5d757de7..5def2d43 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/restful/domain/EcompRole.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/restful/domain/EcompRole.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -43,7 +43,6 @@ import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
  * This bean holds the information for a role in the role and user management
  * REST API.
  */
-
 @JsonIgnoreProperties(ignoreUnknown = true)
 public class EcompRole implements Comparable {
 
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/restful/domain/EcompUser.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/restful/domain/EcompUser.java
index 7c9ab8b3..fc097be5 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/restful/domain/EcompUser.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/restful/domain/EcompUser.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -210,4 +210,16 @@ public class EcompUser implements Comparable {
 		return this.loginId.compareTo(o.loginId);
 	}
 
+	@Override
+	public boolean equals(Object other) {
+		if (this == other)
+			return true;
+		if (other == null)
+			return false;
+		if (!(other instanceof EcompUser))
+			return false;
+		EcompUser castOther = (EcompUser) other;
+		return this.loginId.equals(castOther.getLoginId());
+	}
+
 }
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/restful/domain/PortalTimeoutVO.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/restful/domain/PortalTimeoutVO.java
index ee075cf4..75cd3657 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/restful/domain/PortalTimeoutVO.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/restful/domain/PortalTimeoutVO.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -43,13 +43,12 @@ public class PortalTimeoutVO implements Comparable {
 	private Long sessionTimOutMilliSec;
 
 	public PortalTimeoutVO() {
-
+		super();
 	}
 
-	public PortalTimeoutVO(String _jSessionId, Long _sessionTimOutMilliSec) {
-		setjSessionId(_jSessionId);
-		setSessionTimOutMilliSec(_sessionTimOutMilliSec);
-
+	public PortalTimeoutVO(final String jSessionId, final Long sessionTimOutMilliSec) {
+		this.jSessionId = jSessionId;
+		this.sessionTimOutMilliSec = sessionTimOutMilliSec;
 	}
 
 	public String getjSessionId() {
@@ -73,4 +72,16 @@ public class PortalTimeoutVO implements Comparable {
 		return sessionTimOutMilliSec.compareTo(o.sessionTimOutMilliSec);
 	}
 
-}
\ No newline at end of file
+	@Override
+	public boolean equals(Object other) {
+		if (this == other)
+			return true;
+		if (other == null)
+			return false;
+		if (!(other instanceof PortalTimeoutVO))
+			return false;
+		PortalTimeoutVO castOther = (PortalTimeoutVO) other;
+		return this.getSessionTimOutMilliSec() == castOther.getSessionTimOutMilliSec();
+	}
+
+}
diff --git a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/restful/domain/SharedContext.java b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/restful/domain/SharedContext.java
index c8087e7b..7abde95d 100644
--- a/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/restful/domain/SharedContext.java
+++ b/ecomp-sdk/epsdk-fw/src/main/java/org/onap/portalsdk/core/restful/domain/SharedContext.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -40,8 +40,7 @@ package org.onap.portalsdk.core.restful.domain;
 import java.util.Objects;
 
 /**
- * Bean that represents shared-context data transferred in JSON objects. This is
- * a minimum example:
+ * Model for shared-context data. This is a minimum example:
  * 
  * 
      * {
@@ -56,10 +55,18 @@ public class SharedContext {
 	// Response field indicates nothing else is present
 	private String response;
 	// Required fields when data is present
-	private String context_id, ckey, cvalue;
+	private String context_id;
+	private String ckey;
+	private String cvalue;
 	private Long id, create_time;
 	// Additional database fields from the DomainVO object.
-	private String created, modified, createdId, modifiedId, auditUserId, auditTrail, rowNum;
+	private String created;
+	private String modified;
+	private String createdId;
+	private String modifiedId;
+	private String auditUserId;
+	private String auditTrail;
+	private String rowNum;
 
 	/**
 	 * Gets the response field.
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/NotebookController.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/NotebookController.java
index d5f4288d..406acd80 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/NotebookController.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/NotebookController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,12 +37,7 @@
  */
 package org.onap.portalsdk.rnotebookintegration.controller;
 
-import javax.servlet.http.HttpServletRequest;
-
 import org.onap.portalsdk.core.controller.RestrictedBaseController;
-import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
-import org.onap.portalsdk.core.service.UserProfileService;
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Controller;
 import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RequestMethod;
@@ -53,16 +48,8 @@ import org.springframework.web.servlet.ModelAndView;
 public class NotebookController  extends RestrictedBaseController{
 	
 	@RequestMapping(value = {"/notebook" }, method = RequestMethod.GET)
-	public ModelAndView noteBook(HttpServletRequest request) {
-		
-		try {
-			
-		} catch (Exception e) {
-			
-
-		} 
+	public ModelAndView noteBook() {
 		return new ModelAndView(getViewName());
 	}
 	
-	
 }
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/NotebookTestController.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/NotebookTestController.java
index 973f8d05..e4da0ae3 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/NotebookTestController.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/NotebookTestController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -36,11 +36,8 @@
  * ECOMP is a trademark and service mark of AT&T Intellectual Property.
  */
 
-
 package org.onap.portalsdk.rnotebookintegration.controller;
 
-import javax.servlet.http.HttpServletRequest;
-
 import org.onap.portalsdk.core.controller.RestrictedBaseController;
 import org.springframework.stereotype.Controller;
 import org.springframework.web.bind.annotation.RequestMapping;
@@ -48,13 +45,12 @@ import org.springframework.web.bind.annotation.RequestMethod;
 import org.springframework.web.servlet.ModelAndView;
 
 @Controller
-@RequestMapping("/")  
-public class NotebookTestController  extends RestrictedBaseController{
-	
-	@RequestMapping(value = {"/nbooktest" }, method = RequestMethod.GET)
-	public ModelAndView noteBook(HttpServletRequest request) {
+@RequestMapping("/")
+public class NotebookTestController extends RestrictedBaseController {
+
+	@RequestMapping(value = { "/nbooktest" }, method = RequestMethod.GET)
+	public ModelAndView noteBook() {
 		return new ModelAndView(getViewName());
 	}
-	
-	
+
 }
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/RNoteBookController.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/RNoteBookController.java
index 9a178450..37e7c4de 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/RNoteBookController.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/RNoteBookController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,82 +37,58 @@
  */
 package org.onap.portalsdk.rnotebookintegration.controller;
 
-import java.util.HashMap;
-
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-
-import org.hibernate.validator.internal.util.privilegedactions.GetMethodFromPropertyName;
-import org.onap.portalsdk.core.controller.RestrictedBaseController;
 import org.onap.portalsdk.core.controller.RestrictedRESTfulBaseController;
-import org.onap.portalsdk.core.domain.User;
-import org.onap.portalsdk.core.restful.domain.EcompUser;
-import org.onap.portalsdk.core.util.SystemProperties;
+import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
 import org.onap.portalsdk.core.web.support.JsonMessage;
-import org.onap.portalsdk.core.web.support.UserUtils;
 import org.onap.portalsdk.rnotebookintegration.exception.RNotebookIntegrationException;
 import org.onap.portalsdk.rnotebookintegration.service.RNoteBookIntegrationService;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
 import org.springframework.stereotype.Controller;
-import org.springframework.web.bind.annotation.RequestBody;
 import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RequestMethod;
 import org.springframework.web.bind.annotation.ResponseBody;
 
-import com.fasterxml.jackson.databind.DeserializationFeature;
-import com.fasterxml.jackson.databind.JsonNode;
-import com.fasterxml.jackson.databind.ObjectMapper;
-
 @Controller
 @RequestMapping("/rNotebook/")
-
 public class RNoteBookController extends RestrictedRESTfulBaseController {
-	
+
+	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(RNoteBookController.class);
+
 	@Autowired
 	private RNoteBookIntegrationService rNoteBookIntegrationService;
-	
-	
 
 	public RNoteBookIntegrationService getrNoteBookIntegrationService() {
 		return rNoteBookIntegrationService;
 	}
 
-
-
-	public void setrNoteBookIntegrationService(
-			RNoteBookIntegrationService rNoteBookIntegrationService) {
+	public void setrNoteBookIntegrationService(RNoteBookIntegrationService rNoteBookIntegrationService) {
 		this.rNoteBookIntegrationService = rNoteBookIntegrationService;
 	}
 
-
-
 	@RequestMapping(value = { "authCr" }, method = RequestMethod.GET, produces = "application/json")
-	public @ResponseBody ResponseEntity getRNotebookCredentials (String token) throws Exception {
-		//ObjectMapper mapper = new ObjectMapper();
-		//mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
-		//JsonNode root = mapper.readTree(request.getReader());
-		//String token = root.get("authenticationToken").textValue();
-		
+	@ResponseBody 
+	public ResponseEntity getRNotebookCredentials(String token) {
 		String returnJSON = "";
-		try{
+		try {
 			returnJSON = this.getrNoteBookIntegrationService().getRNotebookCredentials(token);
-		} catch(RNotebookIntegrationException re){
-			if (re.getErrorCode().equals(RNotebookIntegrationException.ERROR_CODE_TOKEN_EXPIRED)){
-				return new ResponseEntity(JsonMessage.buildJsonResponse(false, re.getMessage()), HttpStatus.BAD_REQUEST);
+		} catch (RNotebookIntegrationException re) {
+			logger.error(EELFLoggerDelegate.errorLogger, "getRNotebookCredentials failed 1", re);
+			if (re.getErrorCode().equals(RNotebookIntegrationException.ERROR_CODE_TOKEN_EXPIRED)) {
+				return new ResponseEntity<>(JsonMessage.buildJsonResponse(false, re.getMessage()),
+						HttpStatus.BAD_REQUEST);
+			} else {
+				return new ResponseEntity<>(JsonMessage.buildJsonResponse(false, re.getMessage()),
+						HttpStatus.BAD_REQUEST);
 			}
-			else {
-				return new ResponseEntity(JsonMessage.buildJsonResponse(false, re.getMessage()), HttpStatus.BAD_REQUEST);
-			}
-		} 
-		catch (Exception e){
-			return new ResponseEntity(JsonMessage.buildJsonResponse(false, e.getMessage()), HttpStatus.BAD_REQUEST);
+		} catch (Exception e) {
+			logger.error(EELFLoggerDelegate.errorLogger, "getRNotebookCredentials failed 2", e);
+			return new ResponseEntity<>(JsonMessage.buildJsonResponse(false, e.getMessage()),
+					HttpStatus.BAD_REQUEST);
 		}
-		
-		return new ResponseEntity(returnJSON, HttpStatus.OK);
-		
+
+		return new ResponseEntity<>(returnJSON, HttpStatus.OK);
 	}
-	
-	
+
 }
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/RNoteBookFEController.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/RNoteBookFEController.java
index 0268284c..4cad5b39 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/RNoteBookFEController.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/controller/RNoteBookFEController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -46,6 +46,7 @@ import javax.servlet.http.HttpServletResponse;
 import org.json.JSONObject;
 import org.onap.portalsdk.core.controller.RestrictedBaseController;
 import org.onap.portalsdk.core.domain.User;
+import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
 import org.onap.portalsdk.core.restful.domain.EcompUser;
 import org.onap.portalsdk.core.util.SystemProperties;
 import org.onap.portalsdk.core.web.support.UserUtils;
@@ -63,69 +64,55 @@ import org.springframework.web.bind.annotation.ResponseBody;
 @Controller
 @RequestMapping("/rNotebookFE/")
 public class RNoteBookFEController extends RestrictedBaseController {
+
+	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(RNoteBookController.class);
+
 	@Autowired
 	private RNoteBookIntegrationService rNoteBookIntegrationService;
-	
-	
 
 	public RNoteBookIntegrationService getrNoteBookIntegrationService() {
 		return rNoteBookIntegrationService;
 	}
 
-
-
-	public void setrNoteBookIntegrationService(
-			RNoteBookIntegrationService rNoteBookIntegrationService) {
+	public void setrNoteBookIntegrationService(RNoteBookIntegrationService rNoteBookIntegrationService) {
 		this.rNoteBookIntegrationService = rNoteBookIntegrationService;
 	}
-	
+
 	@RequestMapping(value = { "authCr" }, method = RequestMethod.POST, produces = "application/json")
-	public @ResponseBody ResponseEntity saveRNotebookCredentials (@RequestBody String notebookId, HttpServletRequest request,
-			HttpServletResponse response) throws Exception {
-		//ObjectMapper mapper = new ObjectMapper();
-		//mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
-		//JsonNode root = mapper.readTree(request.getReader());
-		//String token = root.get("authenticationToken").textValue();
-		System.out.println("Notebook id "+notebookId);
-		System.out.println("Query parameters "+request.getParameter("qparams"));
+	@ResponseBody
+	public ResponseEntity saveRNotebookCredentials(@RequestBody String notebookId, HttpServletRequest request,
+			HttpServletResponse response) {
+		logger.debug(EELFLoggerDelegate.debugLogger, "saveRNotebookCredentials: Notebook id {}", notebookId);
+		logger.debug(EELFLoggerDelegate.debugLogger, "saveRNotebookCredentials: Query parameters {}", request.getParameter("qparams"));
 		String retUrl = "";
-		try{
-			
+		try {
 			User user = UserUtils.getUserSession(request);
-			user = (User) this.getDataAccessService().getDomainObject(User.class, user.getId(), null);
-			
-			EcompUser ecUser =UserUtils.convertToEcompUser(user);
-			
-			HashMap map = new HashMap();
-	        JSONObject jObject = new JSONObject(request.getParameter("qparams"));
-	        Iterator keys = jObject.keys();
-
-	        while( keys.hasNext() ){
-	            String key = (String)keys.next();
-	            String value = jObject.getString(key); 
-	            map.put(key, value);
-
-	        }
-
-	        System.out.println("json : "+jObject);
-	        System.out.println("map : "+map);
-			
-		//	String token = this.getrNoteBookIntegrationService().saveRNotebookCredentials(notebookId, ecUser, new HashMap());
-	        String token = this.getrNoteBookIntegrationService().saveRNotebookCredentials(notebookId, ecUser, map);
-			
-			String guard = SystemProperties.getProperty("guard_notebook_url");
-			
+			user = (User) getDataAccessService().getDomainObject(User.class, user.getId(), null);
+			EcompUser ecUser = UserUtils.convertToEcompUser(user);
+			HashMap map = new HashMap<>();
+			JSONObject jObject = new JSONObject(request.getParameter("qparams"));
+			Iterator keys = jObject.keys();
+			while (keys.hasNext()) {
+				String key = (String) keys.next();
+				String value = jObject.getString(key);
+				map.put(key, value);
+			}
+			logger.debug(EELFLoggerDelegate.debugLogger, "saveRNotebookCredentials: json {}", jObject);
+			logger.debug(EELFLoggerDelegate.debugLogger, "saveRNotebookCredentials: map {}", map);
+			String token = this.getrNoteBookIntegrationService().saveRNotebookCredentials(notebookId, ecUser, map);
+			final String guardNotebookUrl = "guard_notebook_url";
+			if (!SystemProperties.containsProperty(guardNotebookUrl))
+				throw new IllegalArgumentException("Failed to find property " + guardNotebookUrl);
+			String guard = SystemProperties.getProperty(guardNotebookUrl);
 			retUrl = guard + "id=" + token;
-			
-		
-		} catch (RNotebookIntegrationException re){
-			return new ResponseEntity(re.getMessage(), HttpStatus.BAD_REQUEST);
-		} catch (Exception e){
-			return new ResponseEntity(e.getMessage(), HttpStatus.BAD_REQUEST);
+		} catch (RNotebookIntegrationException re) {
+			logger.error(EELFLoggerDelegate.errorLogger, "saveRNotebookCredentials failed 1", re);
+			return new ResponseEntity<>(re.getMessage(), HttpStatus.BAD_REQUEST);
+		} catch (Exception e) {
+			logger.error(EELFLoggerDelegate.errorLogger, "saveRNotebookCredentials failed 2", e);
+			return new ResponseEntity<>(e.getMessage(), HttpStatus.BAD_REQUEST);
 		}
-		
-		return new ResponseEntity(retUrl, HttpStatus.OK);
-		
+		return new ResponseEntity<>(retUrl, HttpStatus.OK);
 	}
 
 }
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/domain/RNoteBookCredentials.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/domain/RNoteBookCredentials.java
index 0744aab3..99d7085b 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/domain/RNoteBookCredentials.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/domain/RNoteBookCredentials.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -40,7 +40,6 @@ package org.onap.portalsdk.rnotebookintegration.domain;
 import java.util.Date;
 import java.util.Map;
 
-import org.onap.portalsdk.core.domain.User;
 import org.onap.portalsdk.core.domain.support.DomainVo;
 import org.onap.portalsdk.core.restful.domain.EcompUser;
 
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/exception/RNotebookIntegrationException.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/exception/RNotebookIntegrationException.java
index ff576725..d4ae7352 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/exception/RNotebookIntegrationException.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/exception/RNotebookIntegrationException.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -38,10 +38,18 @@
 package org.onap.portalsdk.rnotebookintegration.exception;
 
 public class RNotebookIntegrationException extends Exception {
+
+	private static final long serialVersionUID = -2930083784603307194L;
+	
 	public static final String ERROR_CODE_TOKEN_EXPIRED = "ERROR_CODE_TOKEN_EXPIRED";
 	public static final String ERROR_CODE_TOKEN_INVALID = "ERROR_CODE_TOKEN_INVALID";
 	
-	String errorCode;
+	private final String errorCode;
+	
+	public RNotebookIntegrationException(Exception ex){
+		super(ex);
+		this.errorCode = null;
+	}
 	
 	public RNotebookIntegrationException(String errorCodeStr){
 		super(errorCodeStr);
@@ -52,8 +60,4 @@ public class RNotebookIntegrationException extends Exception {
 		return errorCode;
 	}
 
-	public void setErrorCode(String errorCode) {
-		this.errorCode = errorCode;
-	}
-	
 }
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/service/RNoteBookIntegrationService.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/service/RNoteBookIntegrationService.java
index 11de7d25..15536c80 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/service/RNoteBookIntegrationService.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/service/RNoteBookIntegrationService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -43,7 +43,8 @@ import org.onap.portalsdk.core.restful.domain.EcompUser;
 import org.onap.portalsdk.rnotebookintegration.exception.RNotebookIntegrationException;
 
 public interface RNoteBookIntegrationService {
-	public String getRNotebookCredentials(String token)  throws RNotebookIntegrationException, Exception;
+
+	public String getRNotebookCredentials(String token)  throws RNotebookIntegrationException;
 	
-	public String saveRNotebookCredentials(String notebookId, EcompUser user, Map params) throws RNotebookIntegrationException, Exception;
+	public String saveRNotebookCredentials(String notebookId, EcompUser user, Map params) throws RNotebookIntegrationException;
 }
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/service/RNoteBookIntegrationServiceImpl.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/service/RNoteBookIntegrationServiceImpl.java
index 8a21b71a..bac23706 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/service/RNoteBookIntegrationServiceImpl.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/rnotebookintegration/service/RNoteBookIntegrationServiceImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,7 +37,6 @@
  */
 package org.onap.portalsdk.rnotebookintegration.service;
 
-import java.security.SecureRandom;
 import java.util.Date;
 import java.util.HashMap;
 import java.util.Map;
@@ -46,28 +45,27 @@ import java.util.UUID;
 import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
 import org.onap.portalsdk.core.restful.domain.EcompUser;
 import org.onap.portalsdk.core.service.DataAccessService;
-import org.onap.portalsdk.core.web.support.UserUtils;
 import org.onap.portalsdk.rnotebookintegration.domain.RNoteBookCredentials;
 import org.onap.portalsdk.rnotebookintegration.exception.RNotebookIntegrationException;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
-import com.fasterxml.jackson.core.JsonParseException;
-import com.fasterxml.jackson.databind.JsonMappingException;
+import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 
 @Service("RNoteBookIntegrationService")
 @Transactional
 public class RNoteBookIntegrationServiceImpl implements RNoteBookIntegrationService {
-	
-	private final long tokenTTL = 50000L;
-	
-	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(RNoteBookIntegrationServiceImpl.class);
-	
+
+	private static final EELFLoggerDelegate logger = EELFLoggerDelegate
+			.getLogger(RNoteBookIntegrationServiceImpl.class);
+
+	private static final long TOKEN_TTL = 50000L;
+
 	@Autowired
-	private DataAccessService  dataAccessService;
-	
+	private DataAccessService dataAccessService;
+
 	public DataAccessService getDataAccessService() {
 		return dataAccessService;
 	}
@@ -75,89 +73,78 @@ public class RNoteBookIntegrationServiceImpl implements RNoteBookIntegrationServ
 	public void setDataAccessService(DataAccessService dataAccessService) {
 		this.dataAccessService = dataAccessService;
 	}
-	
+
 	@Override
-	public String getRNotebookCredentials(String token) throws RNotebookIntegrationException, Exception {
+	public String getRNotebookCredentials(String token) throws RNotebookIntegrationException {
 		String retString = "";
-		
-		try{
-			RNoteBookCredentials notebookCredentials = (RNoteBookCredentials) this.getDataAccessService().getDomainObject(RNoteBookCredentials.class, token, new HashMap());
-			if (notebookCredentials.getToken() == null || notebookCredentials.getToken().equals("")){
+
+		try {
+			RNoteBookCredentials notebookCredentials = (RNoteBookCredentials) this.getDataAccessService()
+					.getDomainObject(RNoteBookCredentials.class, token, new HashMap());
+			if (notebookCredentials.getToken() == null || "".equals(notebookCredentials.getToken())) {
 				throw new RNotebookIntegrationException(RNotebookIntegrationException.ERROR_CODE_TOKEN_INVALID);
 			}
 			Date currDate = new Date();
-			if ((currDate.getTime() - notebookCredentials.getCreatedDate().getTime() > tokenTTL) || (notebookCredentials.getTokenReadDate() != null)){
+			if ((currDate.getTime() - notebookCredentials.getCreatedDate().getTime() > TOKEN_TTL)
+					|| (notebookCredentials.getTokenReadDate() != null)) {
 				throw new RNotebookIntegrationException(RNotebookIntegrationException.ERROR_CODE_TOKEN_EXPIRED);
 			}
 			ObjectMapper mapper = new ObjectMapper();
-			
-			try{
+
+			try {
 				EcompUser userInfo = mapper.readValue(notebookCredentials.getUserString(), EcompUser.class);
-				notebookCredentials.setUserInfo(userInfo);			
-			} catch(JsonMappingException me){
-				logger.error("error converting string to user. from JSON" + me.getMessage());
-			} catch(JsonParseException pe){
-				logger.error("error converting string to user. from JSON" + pe.getMessage());
+				notebookCredentials.setUserInfo(userInfo);
+			} catch (JsonProcessingException me) {
+				logger.error(EELFLoggerDelegate.errorLogger, "error converting string to user. from JSON", me);
 			}
-			
-			try{
-				Map params = mapper.readValue(notebookCredentials.getParametersString(), HashMap.class);
+
+			try {
+				Map params = mapper.readValue(notebookCredentials.getParametersString(), Map.class);
 				notebookCredentials.setParameters(params);
-			} catch(JsonMappingException me){
-				logger.error("error converting string to parameters. from JSON" + me.getMessage());
-			} catch(JsonParseException pe){
-				logger.error("error converting string to parameters. from JSON" + pe.getMessage());
+			} catch (JsonProcessingException me) {
+				logger.error(EELFLoggerDelegate.errorLogger, "error converting string to parameters. from JSON", me);
 			}
-			
-			//expiring the token
-			try{
+
+			// expiring the token
+			try {
 				notebookCredentials.setTokenReadDate(new Date());
 				this.getDataAccessService().saveDomainObject(notebookCredentials, null);
-			} catch(Exception e){
-				logger.info("Error while expiring the token");
-				logger.error(e.getMessage());
-				throw new Exception();
+			} catch (Exception e) {
+				logger.error(EELFLoggerDelegate.errorLogger, "Error while expiring the token", e);
+				throw new RNotebookIntegrationException(e);
 			}
-			//notebookCredentials.setUserString(null);
 			retString = mapper.writeValueAsString(notebookCredentials);
-		} catch(RNotebookIntegrationException re){
-			logger.error(re.getMessage());
+		} catch (RNotebookIntegrationException re) {
+			logger.error(EELFLoggerDelegate.errorLogger, "getRNotebookCredentials failed", re);
 			throw re;
-		} catch(Exception e){
-			logger.info("Error while parsing the rcloud notebook credentials");
-			logger.error(e.getMessage());
-			throw new Exception();
+		} catch (Exception e) {
+			logger.error(EELFLoggerDelegate.errorLogger, "Error while parsing the rcloud notebook credentials", e);
+			throw new RNotebookIntegrationException(e);
 		}
-		
-		return  retString;
+
+		return retString;
 	}
-	
+
 	@Override
-	public String saveRNotebookCredentials(String notebookId, EcompUser user, Map params) throws RNotebookIntegrationException, Exception {
-		
+	public String saveRNotebookCredentials(String notebookId, EcompUser user, Map params)
+			throws RNotebookIntegrationException {
+
 		String token = "";
-		try{
+		try {
 			token = UUID.randomUUID().toString();
-			
 			ObjectMapper mapper = new ObjectMapper();
-			;
 			RNoteBookCredentials rc = new RNoteBookCredentials();
 			rc.setToken(token);
 			rc.setCreatedDate(new Date());
 			rc.setNotebookID(notebookId);
 			rc.setParametersString(mapper.writeValueAsString(params));
 			rc.setUserString(mapper.writeValueAsString(user));
-			
 			this.getDataAccessService().saveDomainObject(rc, null);
-			
-		} catch(Exception e){
-			logger.info("Error while parsing the rcloud notebook credentials");
-			logger.error(e.getMessage());
-			throw new Exception();
+		} catch (Exception e) {
+			logger.error(EELFLoggerDelegate.errorLogger, "Error while parsing the rcloud notebook credentials", e);
+			throw new RNotebookIntegrationException(e);
 		}
-		
-		return  token;
+		return token;
 	}
 
-
 }
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/controllers/WorkflowController.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/controllers/WorkflowController.java
index 2566868e..42386821 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/controllers/WorkflowController.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/controllers/WorkflowController.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -47,7 +47,6 @@ import java.util.Map;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 
-import org.json.JSONObject;
 import org.onap.portalsdk.core.controller.RestrictedBaseController;
 import org.onap.portalsdk.core.domain.User;
 import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
@@ -73,19 +72,16 @@ import com.fasterxml.jackson.databind.ObjectMapper;
 @Controller
 @RequestMapping("/")
 public class WorkflowController extends RestrictedBaseController {
- 
+
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(WorkflowController.class);
 
 	@Autowired
 	private WorkflowService workflowService;
-	// @Autowired
-	// private CronJobService cronJobService;
 
 	@RequestMapping(value = { "workflows/saveCronJob" }, method = RequestMethod.POST)
 	public void saveCronJob(HttpServletRequest request, HttpServletResponse response) throws Exception {
 
 		try {
-			// System.out.println("inside save cron job...");
 			ObjectMapper mapper = new ObjectMapper();
 			mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
 			JsonNode root = mapper.readTree(request.getReader());
@@ -93,38 +89,33 @@ public class WorkflowController extends RestrictedBaseController {
 			WorkflowSchedule domainCronJobData = new WorkflowSchedule();
 			SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd hh:mm:ss");
 
-			domainCronJobData.setCronDetails(root.get("cronJobDataObj").get("startDateTime_CRON").textValue());
-			domainCronJobData.setWorkflowKey(root.get("cronJobDataObj").get("workflowKey").textValue());
-			domainCronJobData.setArguments(root.get("cronJobDataObj").get("workflow_arguments").textValue());
-			domainCronJobData.setServerUrl(root.get("cronJobDataObj").get("workflow_server_url").textValue());
-			domainCronJobData
-					.setStartDateTime(dateFormat.parse(root.get("cronJobDataObj").get("startDateTime").textValue()));
-			domainCronJobData
-					.setEndDateTime(dateFormat.parse(root.get("cronJobDataObj").get("endDateTime").textValue()));
-			domainCronJobData.setRecurrence(root.get("cronJobDataObj").get("recurrence").textValue());
-
+			final JsonNode cronJobDataObj = root.get("cronJobDataObj");
+			domainCronJobData.setCronDetails(cronJobDataObj.get("startDateTime_CRON").textValue());
+			domainCronJobData.setWorkflowKey(cronJobDataObj.get("workflowKey").textValue());
+			domainCronJobData.setArguments(cronJobDataObj.get("workflow_arguments").textValue());
+			domainCronJobData.setServerUrl(cronJobDataObj.get("workflow_server_url").textValue());
+			domainCronJobData.setStartDateTime(dateFormat.parse(cronJobDataObj.get("startDateTime").textValue()));
+			domainCronJobData.setEndDateTime(dateFormat.parse(cronJobDataObj.get("endDateTime").textValue()));
+			domainCronJobData.setRecurrence(cronJobDataObj.get("recurrence").textValue());
 			workflowService.saveCronJob(domainCronJobData);
-
-			// response.getWriter().write("hello".toString());
-
 		} catch (Exception e) {
+			logger.error(EELFLoggerDelegate.errorLogger, "saveCronJob failed", e);
 			response.setCharacterEncoding("UTF-8");
 			request.setCharacterEncoding("UTF-8");
 			PrintWriter out = response.getWriter();
 			out.write(e.getMessage());
-
 		}
 
 	}
 
 	@RequestMapping(value = { "workflows/list" }, method = RequestMethod.GET, produces = "application/json")
-	public @ResponseBody String getWorkflowList() {
+	@ResponseBody
+	public String getWorkflowList() {
 		ObjectMapper mapper = new ObjectMapper();
 		List workflows = workflowService.getAllWorkflows();
-		List workflowLites = new ArrayList();
+		List workflowLites = new ArrayList<>();
 
 		try {
-
 			for (Workflow workflow : workflows) {
 				WorkflowLite wfl = new WorkflowLite();
 				wfl.setId(workflow.getId());
@@ -146,59 +137,43 @@ public class WorkflowController extends RestrictedBaseController {
 
 			return mapper.writeValueAsString(workflowLites);
 		} catch (Exception e) {
-			// TODO Auto-generated catch block
-			e.printStackTrace();
+			logger.error(EELFLoggerDelegate.errorLogger, "getWorkflowList failed", e);
 		}
 		return "";
 	}
 
 	@RequestMapping(value = "workflows/addWorkflow", method = RequestMethod.POST, consumes = "application/json")
-	public @ResponseBody Workflow addWorkflow(@RequestBody Workflow workflow, HttpServletRequest request,
-			HttpServletResponse response) {
+	@ResponseBody
+	public Workflow addWorkflow(@RequestBody Workflow workflow, HttpServletRequest request) {
 		String loginId = ((User) (request.getSession().getAttribute("user"))).getLoginId();
 		return workflowService.addWorkflow(workflow, loginId);
 	}
 
 	@RequestMapping(value = "workflows/editWorkflow", method = RequestMethod.POST, consumes = "application/json")
-	public @ResponseBody Workflow editWorkflow(@RequestBody WorkflowLite workflow, HttpServletRequest request,
-			HttpServletResponse response) {
+	@ResponseBody
+	public Workflow editWorkflow(@RequestBody WorkflowLite workflow, HttpServletRequest request) {
 		String loginId = ((User) (request.getSession().getAttribute("user"))).getLoginId();
 		return workflowService.editWorkflow(workflow, loginId);
 	}
 
-	// @RequestMapping(value = "workflows/removeWorkflow", method =
-	// RequestMethod.DELETE)
 	@RequestMapping(value = { "workflows/removeWorkflow" }, method = RequestMethod.POST, consumes = "application/json")
-	public @ResponseBody void removeWorkflow(@RequestBody Long workflowId, HttpServletRequest request,
-			HttpServletResponse response) {
-
-		// System.out.println("Removing ... " + workflowId);
-
+	@ResponseBody
+	public String removeWorkflow(@RequestBody Long workflowId, HttpServletRequest request, HttpServletResponse response) {
 		workflowService.deleteWorkflow(workflowId);
-
 		response.setCharacterEncoding("UTF-8");
 		response.setContentType("application / json");
-		PrintWriter out = null;
-		try {
-			request.setCharacterEncoding("UTF-8");
-			out = response.getWriter();
-		} catch (Exception e) {
-			logger.error(EELFLoggerDelegate.errorLogger, "removeWorkflow failed", e);
-		}
-
-		JSONObject j = new JSONObject("{removed: 123}");
-		out.write(j.toString());
-
+		return "{removed: 123}";
 	}
 
 	@RequestMapping(value = "workflows/removeAllWorkflows", method = RequestMethod.DELETE)
-	public @ResponseBody void removeAllWorkflows() {
-		// workflowService.deleteAll();
+	@ResponseBody
+	public void removeAllWorkflows() {
+		throw new UnsupportedOperationException();
 	}
 
 	@RequestMapping(value = { "/workflows" }, method = RequestMethod.GET)
 	public ModelAndView getWorkflowPartialPage() {
-		Map model = new HashMap();
+		Map model = new HashMap<>();
 		return new ModelAndView(getViewName(), "workflows", model);
 	}
 }
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/dao/WorkflowDAO.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/dao/WorkflowDAO.java
index cb7b27a3..c3b805aa 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/dao/WorkflowDAO.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/dao/WorkflowDAO.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/dao/WorkflowDAOImpl.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/dao/WorkflowDAOImpl.java
index 8fdb64fc..3208997f 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/dao/WorkflowDAOImpl.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/dao/WorkflowDAOImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -45,83 +45,88 @@ import org.hibernate.Session;
 import org.hibernate.SessionFactory;
 import org.hibernate.Transaction;
 import org.onap.portalsdk.core.domain.User;
+import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
 import org.onap.portalsdk.workflow.models.Workflow;
 import org.onap.portalsdk.workflow.models.WorkflowLite;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Repository;
+
 @Repository
-public class WorkflowDAOImpl implements WorkflowDAO{
-	
+public class WorkflowDAOImpl implements WorkflowDAO {
+
+	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(WorkflowDAOImpl.class);
+
 	@Autowired
 	private SessionFactory sessionFactory;
-	
-	public Workflow save(Workflow workflow, String creatorId){
-        Session session = this.sessionFactory.openSession();
-        Transaction tx = session.beginTransaction();
-        
-        try{
-        	Query query = session.createQuery("from User where loginId =:loginId");
-        	query.setParameter("loginId", creatorId);
-        	User creator = (User)(query.list().get(0));
-        	
-        	workflow.setCreatedBy(creator);
-            workflow.setCreated(new Date());
-        }
-        catch(Exception e){
-        	e.printStackTrace();
-        }
-        
-        long id = (Long) session.save(workflow);
-        Workflow savedWorkflow = (Workflow) session.get(Workflow.class, id);        
-        tx.commit();
-        session.close();
-        return savedWorkflow;
+
+	@Override
+	public Workflow save(Workflow workflow, String creatorId) {
+		Session session = this.sessionFactory.openSession();
+		Transaction tx = session.beginTransaction();
+
+		try {
+			Query query = session.createQuery("from User where loginId =:loginId");
+			query.setParameter("loginId", creatorId);
+			User creator = (User) (query.list().get(0));
+			workflow.setCreatedBy(creator);
+			workflow.setCreated(new Date());
+		} catch (Exception e) {
+			logger.error(EELFLoggerDelegate.errorLogger, "save failed", e);
+		}
+
+		long id = (Long) session.save(workflow);
+		Workflow savedWorkflow = (Workflow) session.get(Workflow.class, id);
+		tx.commit();
+		session.close();
+		return savedWorkflow;
 	}
-	
-	public List getWorkflows(){
+
+	@Override
+	public List getWorkflows() {
 		Session session = this.sessionFactory.openSession();
-        @SuppressWarnings("unchecked")
+		@SuppressWarnings("unchecked")
 		List workflows = session.createQuery("from Workflow").list();
-        session.close();
-        return workflows;
+		session.close();
+		return workflows;
 	}
 
 	@Override
 	public void delete(Long workflowId) {
 		Session session = this.sessionFactory.openSession();
-        Transaction tx = session.beginTransaction();
-        Query query = session.createQuery("delete from Workflow where id =:id");
-        query.setParameter("id", workflowId);
-        query.executeUpdate();    
-        tx.commit();
-        session.close();        	
-    }
+		Transaction tx = session.beginTransaction();
+		Query query = session.createQuery("delete from Workflow where id =:id");
+		query.setParameter("id", workflowId);
+		query.executeUpdate();
+		tx.commit();
+		session.close();
+	}
 
 	@Override
 	public Workflow edit(WorkflowLite workflowLight, String creatorId) {
-        Session session = this.sessionFactory.openSession();
-        Transaction tx = session.beginTransaction();
-        
-        Query query = session.createQuery("from User where loginId =:loginId");
-    	query.setParameter("loginId", creatorId);
-    	User creator = (User)(query.list().get(0));
-    	
-    	Workflow workflowToModify = (Workflow) session.get(Workflow.class, workflowLight.getId());
-        
-    	workflowToModify.setActive(workflowLight.getActive().equalsIgnoreCase("true") ? true : false );
-    	workflowToModify.setSuspendLink(workflowLight.getSuspendLink());
-    	workflowToModify.setRunLink(workflowLight.getRunLink());
-    	workflowToModify.setDescription(workflowLight.getDescription());
-    	workflowToModify.setWorkflowKey(workflowLight.getWorkflowKey());
-    	workflowToModify.setName(workflowLight.getName());
-    	
-    	workflowToModify.setModifiedBy(creator);
-    	workflowToModify.setLastUpdated(new Date());
-        
-        session.update(workflowToModify);
-        Workflow savedWorkflow = (Workflow) session.get(Workflow.class, workflowLight.getId());
-        tx.commit();
-        session.close();
-        return savedWorkflow;
+		Session session = this.sessionFactory.openSession();
+		Transaction tx = session.beginTransaction();
+
+		Query query = session.createQuery("from User where loginId =:loginId");
+		query.setParameter("loginId", creatorId);
+		User creator = (User) (query.list().get(0));
+
+		Workflow workflowToModify = (Workflow) session.get(Workflow.class, workflowLight.getId());
+
+		final boolean active = "true".equalsIgnoreCase(workflowLight.getActive()) ? true : false;
+		workflowToModify.setActive(active);
+		workflowToModify.setSuspendLink(workflowLight.getSuspendLink());
+		workflowToModify.setRunLink(workflowLight.getRunLink());
+		workflowToModify.setDescription(workflowLight.getDescription());
+		workflowToModify.setWorkflowKey(workflowLight.getWorkflowKey());
+		workflowToModify.setName(workflowLight.getName());
+
+		workflowToModify.setModifiedBy(creator);
+		workflowToModify.setLastUpdated(new Date());
+
+		session.update(workflowToModify);
+		Workflow savedWorkflow = (Workflow) session.get(Workflow.class, workflowLight.getId());
+		tx.commit();
+		session.close();
+		return savedWorkflow;
 	}
 }
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/domain/WorkflowSchedule.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/domain/WorkflowSchedule.java
index 58f1377a..ecc3ac6d 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/domain/WorkflowSchedule.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/domain/WorkflowSchedule.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -36,74 +36,90 @@
  * ECOMP is a trademark and service mark of AT&T Intellectual Property.
  */
 package org.onap.portalsdk.workflow.domain;
+
 import java.util.Date;
 
 import org.onap.portalsdk.core.domain.support.DomainVo;
-public class WorkflowSchedule extends DomainVo{
-	/**
-	 * 
-	 */
+
+public class WorkflowSchedule extends DomainVo {
 	private static final long serialVersionUID = 1L;
 	private Long id;
-    private String serverUrl;
-    private String workflowKey;
-    private String arguments;
-    private String cronDetails;
-    private Date endDateTime;
-    private Date startDateTime;
-    private String recurrence;
-    
+	private String serverUrl;
+	private String workflowKey;
+	private String arguments;
+	private String cronDetails;
+	private Date endDateTime;
+	private Date startDateTime;
+	private String recurrence;
+
+	@Override
 	public Long getId() {
 		return id;
 	}
+
+	@Override
 	public void setId(Long id) {
 		this.id = id;
 	}
+
 	public String getServerUrl() {
 		return serverUrl;
 	}
+
 	public void setServerUrl(String serverUrl) {
 		this.serverUrl = serverUrl;
 	}
+
 	public String getWorkflowKey() {
 		return workflowKey;
 	}
+
 	public void setWorkflowKey(String workflowKey) {
 		this.workflowKey = workflowKey;
 	}
+
 	public String getArguments() {
 		return arguments;
 	}
+
 	public void setArguments(String arguments) {
 		this.arguments = arguments;
 	}
+
 	public String getCronDetails() {
 		return cronDetails;
 	}
+
 	public void setCronDetails(String cronDetails) {
 		this.cronDetails = cronDetails;
 	}
+
 	public Date getEndDateTime() {
 		return endDateTime;
 	}
+
 	public void setEndDateTime(Date endDateTime) {
 		this.endDateTime = endDateTime;
 	}
+
 	public Date getStartDateTime() {
 		return startDateTime;
 	}
+
 	public void setStartDateTime(Date startDateTime) {
 		this.startDateTime = startDateTime;
 	}
+
 	public String getRecurrence() {
 		return recurrence;
 	}
+
 	public void setRecurrence(String recurrence) {
 		this.recurrence = recurrence;
 	}
+
 	public static long getSerialversionuid() {
 		return serialVersionUID;
 	}
-    
-  
+
 }
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/models/Workflow.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/models/Workflow.java
index 734b356f..76ba3d39 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/models/Workflow.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/models/Workflow.java
@@ -7,7 +7,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -20,7 +20,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/models/WorkflowLite.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/models/WorkflowLite.java
index 3f689095..1dfce84e 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/models/WorkflowLite.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/models/WorkflowLite.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/scheduler/WorkFlowScheduleJob.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/scheduler/WorkFlowScheduleJob.java
index 3882865a..f9816c26 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/scheduler/WorkFlowScheduleJob.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/scheduler/WorkFlowScheduleJob.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -43,18 +43,15 @@ import org.quartz.JobExecutionContext;
 import org.quartz.JobExecutionException;
 import org.springframework.scheduling.quartz.QuartzJobBean;
 
-public class WorkFlowScheduleJob extends QuartzJobBean{
-	
+public class WorkFlowScheduleJob extends QuartzJobBean {
+
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(WorkFlowScheduleJob.class);
 
 	@Override
-	protected void executeInternal(JobExecutionContext context)
-			throws JobExecutionException {
-		
-		String serverUrl = (String)context.getMergedJobDataMap().get("serverUrl");
-		String workflowKey = (String)context.getMergedJobDataMap().get("workflowKey");
-		//String arguments = (String)context.getMergedJobDataMap().get("arguments");
-		logger.info(EELFLoggerDelegate.debugLogger, ("Executing the job for the workflow " + workflowKey));
+	protected void executeInternal(JobExecutionContext context) throws JobExecutionException {
+		String serverUrl = (String) context.getMergedJobDataMap().get("serverUrl");
+		String workflowKey = (String) context.getMergedJobDataMap().get("workflowKey");
+		logger.debug(EELFLoggerDelegate.debugLogger, "Executing the job for the workflow {}", workflowKey);
 		WorkflowScheduleExecutor executor = new WorkflowScheduleExecutor(serverUrl, workflowKey);
 		executor.execute();
 	}
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/scheduler/WorkFlowScheduleRegistry.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/scheduler/WorkFlowScheduleRegistry.java
index 2412b992..2ac9cddb 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/scheduler/WorkFlowScheduleRegistry.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/scheduler/WorkFlowScheduleRegistry.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -37,6 +37,7 @@
  */
 package org.onap.portalsdk.workflow.scheduler;
 
+import java.text.ParseException;
 import java.util.Calendar;
 import java.util.Date;
 import java.util.HashMap;
@@ -56,20 +57,16 @@ public class WorkFlowScheduleRegistry{
 
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(WorkFlowScheduleRegistry.class);
 
-	public WorkFlowScheduleRegistry() {
-
-	}
-
 	private static final String groupName = "AppGroup";
 	private static final String jobName = "WorkflowScheduleJob";
 	private static final String triggerName = "WorkflowScheduleTrigger";
 
-	// @Autowired
-	// private SystemProperties systemProperties;
+	public WorkFlowScheduleRegistry() {
+		super();
+	}
 
 	// @Bean
 	public JobDetailFactoryBean jobDetailFactoryBean(Map contextInfoMap) {
-
 		JobDetailFactoryBean jobDetailFactory = new JobDetailFactoryBean();
 		jobDetailFactory.setJobClass(WorkFlowScheduleJob.class);
 		jobDetailFactory.setJobDataAsMap(contextInfoMap);
@@ -81,13 +78,13 @@ public class WorkFlowScheduleRegistry{
 
 	// @Bean
 	public CronTriggerFactoryBean cronTriggerFactoryBean(JobDetailFactoryBean jobDetailFactory, Long id,
-			String cronExpression, Date startDateTime, Date enddatetime) throws Exception {
+			String cronExpression, Date startDateTime, Date enddatetime) throws ParseException {
 		CronTriggerFactoryBean cronTriggerFactory = new CronTriggerFactoryBean();
 		cronTriggerFactory.setJobDetail(jobDetailFactory.getObject());
 		cronTriggerFactory.setStartDelay(3000);
 		cronTriggerFactory.setName(triggerName + "_" + id);
 		cronTriggerFactory.setGroup(groupName);
-		logger.debug(EELFLoggerDelegate.debugLogger, (triggerName + " Scheduled: " + cronExpression));
+		logger.debug(EELFLoggerDelegate.debugLogger, triggerName + " Scheduled: " + cronExpression);
 		cronTriggerFactory.setCronExpression( cronExpression);  //"0 * * * * ? *"
 		cronTriggerFactory.afterPropertiesSet();
 
@@ -96,27 +93,21 @@ public class WorkFlowScheduleRegistry{
 		cronTrigger.setEndTime(enddatetime);
 		Date fireAgainTime = cronTrigger.getFireTimeAfter(cronTrigger.getStartTime());
 		if (fireAgainTime == null)
-			throw new Exception("Cron not added as it may not fire again " + " Expr: " + cronExpression + " End Time: "
+			throw new IllegalArgumentException("Cron not added as it may not fire again " + " Expr: " + cronExpression + " End Time: "
 					+ cronTrigger.getEndTime());
 		return cronTriggerFactory;
-
 	}
 
 	public CronTriggerFactoryBean setUpTrigger(Long wfId, String serverUrl, String workflowKey, String arguments,
-			String startdatetimecron, Date startDateTime, Date enddatetime) throws Exception {
+			String startdatetimecron, Date startDateTime, Date enddatetime) throws ParseException {
 
-		Map contextInfo = new HashMap();
+		Map contextInfo = new HashMap<>();
 		contextInfo.put("serverUrl", serverUrl);
 		contextInfo.put("workflowKey", workflowKey);
 		contextInfo.put("arguments", arguments);
 		JobDetailFactoryBean jobDetailFactory = jobDetailFactoryBean(contextInfo);
-
 		CronTriggerFactoryBean cronTriggerFactory = cronTriggerFactoryBean(jobDetailFactory, wfId, startdatetimecron, startDateTime, enddatetime);
-		
-		logger.debug(EELFLoggerDelegate.debugLogger, (" Job to be Scheduled: " + contextInfo.get("workflowKey")));
-		
-		//cronTriggerFactory.
-		
+		logger.debug(EELFLoggerDelegate.debugLogger, " Job to be Scheduled: " + contextInfo.get("workflowKey"));		
 		return cronTriggerFactory;
 	}
 
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/services/WorkflowScheduleExecutor.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/services/WorkflowScheduleExecutor.java
index 90b9e96a..b97a00b4 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/services/WorkflowScheduleExecutor.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/services/WorkflowScheduleExecutor.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -48,7 +48,7 @@ import java.nio.charset.Charset;
 import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
 
 public class WorkflowScheduleExecutor {
-	
+
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(WorkflowScheduleExecutor.class);
 
 	private String serverURL;
@@ -56,22 +56,18 @@ public class WorkflowScheduleExecutor {
 	private String myUrl;
 	private String payload;
 
-	//constructor
-	public WorkflowScheduleExecutor(String serverURL,String workflowKey){
+	public WorkflowScheduleExecutor(String serverURL, String workflowKey) {
 		this.serverURL = serverURL;
 		this.workflowKey = workflowKey;
-		this.myUrl = this.serverURL + "/engine-rest/process-definition/key/" + this.workflowKey + "/submit-form";;
-        this.payload="{\"variables\":{}}";
+		this.myUrl = this.serverURL + "/engine-rest/process-definition/key/" + this.workflowKey + "/submit-form";
+		;
+		this.payload = "{\"variables\":{}}";
 	}
-	
-	public static void main(String [] args)  throws Exception {		
 
-	}
-	
 	public void execute() {
-		POST_fromURL(myUrl,payload);
+		POST_fromURL(myUrl, payload);
 	}
-	
+
 	public static String get_fromURL(String myURL) {
 		logger.debug(EELFLoggerDelegate.debugLogger, "get_fromURL: Requested URL {}", myURL);
 		StringBuilder sb = new StringBuilder();
@@ -83,8 +79,7 @@ public class WorkflowScheduleExecutor {
 			if (urlConn != null)
 				urlConn.setReadTimeout(60 * 1000);
 			if (urlConn != null && urlConn.getInputStream() != null) {
-				in = new InputStreamReader(urlConn.getInputStream(),
-						Charset.defaultCharset());
+				in = new InputStreamReader(urlConn.getInputStream(), Charset.defaultCharset());
 				BufferedReader bufferedReader = new BufferedReader(in);
 				int cp;
 				while ((cp = bufferedReader.read()) != -1)
@@ -93,46 +88,43 @@ public class WorkflowScheduleExecutor {
 				in.close();
 			}
 		} catch (Exception e) {
-		    	logger.error(EELFLoggerDelegate.errorLogger, "get_fromURL failed", e);
-			throw new RuntimeException("Exception while calling URL:"+ myURL, e);
-		} 
-		finally {
+			logger.error(EELFLoggerDelegate.errorLogger, "get_fromURL failed", e);
+			throw new RuntimeException("Exception while calling URL:" + myURL, e);
+		} finally {
 			try {
 				if (in != null)
 					in.close();
-				} catch (Exception e) {
-					logger.error(EELFLoggerDelegate.errorLogger, "get_fromURL close failed", e);
-				}
+			} catch (Exception e) {
+				logger.error(EELFLoggerDelegate.errorLogger, "get_fromURL close failed", e);
+			}
 		}
 		return sb.toString();
 	}
-	
-	
-	public static String POST_fromURL(String myURL, String payload) {
-		   	String line;
-		    StringBuffer jsonString = new StringBuffer();
-		    try {
-		        URL url = new URL(myURL);
 
-		        HttpURLConnection connection = (HttpURLConnection) url.openConnection();
-		        connection.setDoInput(true);
-		        connection.setDoOutput(true);
-		        connection.setRequestMethod("POST");
-		        connection.setRequestProperty("Accept", "application/json");
-		        connection.setRequestProperty("Content-Type", "application/json; charset=UTF-8");
-		        OutputStreamWriter writer = new OutputStreamWriter(connection.getOutputStream(), "UTF-8");
-		        writer.write(payload);
-		        writer.close();
-		        BufferedReader br = new BufferedReader(new InputStreamReader(connection.getInputStream()));
-		        while ((line = br.readLine()) != null) {
-		                jsonString.append(line);
-		        }
-		        br.close();
-		        connection.disconnect();
-		    } catch (Exception e) {
-		    	logger.error(EELFLoggerDelegate.errorLogger, "POST_fromURL failed", e);
-		    	throw new RuntimeException(e.getMessage());
-		    }
-		    return jsonString.toString();
-		}					
+	public static String POST_fromURL(String myURL, String payload) {
+		String line;
+		StringBuilder jsonString = new StringBuilder();
+		try {
+			URL url = new URL(myURL);
+			HttpURLConnection connection = (HttpURLConnection) url.openConnection();
+			connection.setDoInput(true);
+			connection.setDoOutput(true);
+			connection.setRequestMethod("POST");
+			connection.setRequestProperty("Accept", "application/json");
+			connection.setRequestProperty("Content-Type", "application/json; charset=UTF-8");
+			OutputStreamWriter writer = new OutputStreamWriter(connection.getOutputStream(), "UTF-8");
+			writer.write(payload);
+			writer.close();
+			BufferedReader br = new BufferedReader(new InputStreamReader(connection.getInputStream()));
+			while ((line = br.readLine()) != null) {
+				jsonString.append(line);
+			}
+			br.close();
+			connection.disconnect();
+		} catch (Exception e) {
+			logger.error(EELFLoggerDelegate.errorLogger, "POST_fromURL failed", e);
+			throw new RuntimeException(e.getMessage());
+		}
+		return jsonString.toString();
+	}
 }
\ No newline at end of file
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/services/WorkflowScheduleService.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/services/WorkflowScheduleService.java
index 1a64812d..c4513dd7 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/services/WorkflowScheduleService.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/services/WorkflowScheduleService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/services/WorkflowScheduleServiceImpl.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/services/WorkflowScheduleServiceImpl.java
index 73da941c..b7a21a4e 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/services/WorkflowScheduleServiceImpl.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/services/WorkflowScheduleServiceImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -56,63 +56,56 @@ import org.springframework.scheduling.quartz.SchedulerFactoryBean;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
-
-
 @Service("workflowScheduleService")
 @Transactional
 
-public class WorkflowScheduleServiceImpl implements WorkflowScheduleService{
-	
+public class WorkflowScheduleServiceImpl implements WorkflowScheduleService {
+
 	private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(WorkflowScheduleServiceImpl.class);
-	
+
 	@Autowired
-	private DataAccessService  dataAccessService;
-	
+	private DataAccessService dataAccessService;
+
 	@Autowired
 	private WorkFlowScheduleRegistry workflowRegistry;
-	
+
 	@Autowired
 	private ApplicationContext appContext;
-	
 
+	@Override
 	public List findAll() {
-		
-	/*	List allworkflows = getDataAccessService().getList(WorkflowSchedule.class, null);
-		for (WorkflowSchedule ws : allworkflows) {
-			
-			System.out.println("Key:"+ws.getWorkflowKey()+" "+"CronDetails:"+ws.getStartdatetimecron());
-		} */
 		@SuppressWarnings("unchecked")
 		List list = getDataAccessService().getList(WorkflowSchedule.class, null);
 		return list;
 	}
-	
-	
-	public void saveWorkflowSchedule(WorkflowSchedule ws){
-		
+
+	@Override
+	public void saveWorkflowSchedule(WorkflowSchedule ws) {
 		getDataAccessService().saveDomainObject(ws, null);
-		logger.info(EELFLoggerDelegate.debugLogger, ("Workflow Scheduled " + ws.getId() + " " + ws.getEndDateTime()));
-		triggerWorkflowScheduling((SchedulerFactoryBean)appContext.getBean(SchedulerFactoryBean.class),ws);
-		
+		logger.info(EELFLoggerDelegate.debugLogger, "Workflow Scheduled " + ws.getId() + " " + ws.getEndDateTime());
+		triggerWorkflowScheduling((SchedulerFactoryBean) appContext.getBean(SchedulerFactoryBean.class), ws);
 	}
-	
+
+	@Override
 	public void triggerWorkflowScheduling(SchedulerFactoryBean schedulerBean, WorkflowSchedule ws) {
-		
 		try {
-			final CronTriggerFactoryBean triggerBean = workflowRegistry.setUpTrigger(ws.getId(), ws.getServerUrl(), ws.getWorkflowKey(),ws.getArguments(),ws.getCronDetails(), ws.getStartDateTime(),ws.getEndDateTime());
-			schedulerBean.getScheduler().scheduleJob((JobDetail)triggerBean.getJobDataMap().get("jobDetail"),triggerBean.getObject());
+			final CronTriggerFactoryBean triggerBean = workflowRegistry.setUpTrigger(ws.getId(), ws.getServerUrl(),
+					ws.getWorkflowKey(), ws.getArguments(), ws.getCronDetails(), ws.getStartDateTime(),
+					ws.getEndDateTime());
+			schedulerBean.getScheduler().scheduleJob((JobDetail) triggerBean.getJobDataMap().get("jobDetail"),
+					triggerBean.getObject());
 		} catch (Exception e) {
-			logger.debug(EELFLoggerDelegate.debugLogger, ("Error scheduling work flow with Id" + ws.getId() + e.getMessage()));
+			logger.error(EELFLoggerDelegate.errorLogger, "Error scheduling work flow with Id" + ws.getId(), e);
 		}
-		
 	}
-	
+
+	@Override
 	public List triggerWorkflowScheduling() {
-		
-		 Date date = new Date();
-		 List triggers = new ArrayList();
-		 
-		 DateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
+
+		Date date = new Date();
+		List triggers = new ArrayList<>();
+
+		DateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
 
 		if (getDataAccessService() != null) {
 			@SuppressWarnings("unchecked")
@@ -120,42 +113,32 @@ public class WorkflowScheduleServiceImpl implements WorkflowScheduleService{
 					.executeQuery("From  WorkflowSchedule where endDateTime > '" + dateFormat.format(date) + "'", null);
 
 			for (WorkflowSchedule ws : allWorkflows) {
-				logger.info(EELFLoggerDelegate.debugLogger, ("Workflow Scheduled " + ws.getId() + "/ End Time: " + ws.getEndDateTime()));
-		
+				logger.info(EELFLoggerDelegate.debugLogger,
+						"Workflow Scheduled " + ws.getId() + "/ End Time: " + ws.getEndDateTime());
 				try {
-					
-					final CronTriggerFactoryBean triggerBean = workflowRegistry.setUpTrigger(ws.getId(), ws.getServerUrl(), ws.getWorkflowKey(),ws.getArguments(), ws.getCronDetails(), ws.getStartDateTime(),ws.getEndDateTime());
-					
+					final CronTriggerFactoryBean triggerBean = workflowRegistry.setUpTrigger(ws.getId(),
+							ws.getServerUrl(), ws.getWorkflowKey(), ws.getArguments(), ws.getCronDetails(),
+							ws.getStartDateTime(), ws.getEndDateTime());
 					triggers.add(triggerBean.getObject());
-					
-					//schedulerBean.getScheduler().scheduleJob(trigger);
-				
-				
 				} catch (Exception e) {
-					logger.debug(EELFLoggerDelegate.debugLogger, ("Error scheduling work flow with Id" + ws.getId() + e.getMessage()));
+					logger.error(EELFLoggerDelegate.errorLogger, "Error scheduling work flow with Id" + ws.getId(), e);
 				}
-			
-			
 			}
 		}
-		
+
 		return triggers;
 	}
-	
-	
+
 	public DataAccessService getDataAccessService() {
 		return dataAccessService;
 	}
 
-
 	public void setDataAccessService(DataAccessService dataAccessService) {
 		this.dataAccessService = dataAccessService;
 	}
 
 	@Override
 	public WorkflowSchedule getWorkflowScheduleByKey(Long key) {
-		return  (WorkflowSchedule)(getDataAccessService().getDomainObject(WorkflowSchedule.class, key, null));
+		return (WorkflowSchedule) (getDataAccessService().getDomainObject(WorkflowSchedule.class, key, null));
 	}
 }
-
-
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/services/WorkflowService.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/services/WorkflowService.java
index a246273b..42346280 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/services/WorkflowService.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/services/WorkflowService.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
diff --git a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/services/WorkflowServiceImpl.java b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/services/WorkflowServiceImpl.java
index b12aba87..72adba91 100644
--- a/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/services/WorkflowServiceImpl.java
+++ b/ecomp-sdk/epsdk-workflow/src/main/java/org/onap/portalsdk/workflow/services/WorkflowServiceImpl.java
@@ -6,7 +6,7 @@
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
- * under the Apache License, Version 2.0 (the “License”);
+ * under the Apache License, Version 2.0 (the "License");
  * you may not use this software except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -19,7 +19,7 @@
  * limitations under the License.
  *
  * Unless otherwise specified, all documentation contained herein is licensed
- * under the Creative Commons License, Attribution 4.0 Intl. (the “License”);
+ * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
  * you may not use this documentation except in compliance with the License.
  * You may obtain a copy of the License at
  *
@@ -52,26 +52,14 @@ public class WorkflowServiceImpl implements WorkflowService {
     
     @Autowired
     private WorkflowDAO workflowDAO;
-    
-	//@Autowired
-	//private DataAccessService  dataAccessService;
-	
+    	
 	@Autowired
 	private WorkflowScheduleService workflowScheduleService;
 
 	@Override
 	public void saveCronJob(WorkflowSchedule domainCronJobData) {
-		// TODO Auto-generated method stub
 		workflowScheduleService.saveWorkflowSchedule(domainCronJobData);
-/*		triggerWorkflowScheduling((SchedulerFactoryBean)appContext.getBean(SchedulerFactoryBean.class),domainCronJobData);		
-*/	}
-
-	/*
-    private DataAccessService getDataAccessService() {
-		// TODO Auto-generated method stub
-    	return dataAccessService;
 	}
-	*/
 
 	@Override
     public Workflow addWorkflow(Workflow workflow, String creatorId) {
-- 
cgit 1.2.3-korg