diff options
author | Christopher Lott (cl778h) <clott@research.att.com> | 2017-09-25 15:52:24 -0400 |
---|---|---|
committer | Christopher Lott (cl778h) <clott@research.att.com> | 2017-09-25 15:53:55 -0400 |
commit | 3a2b5c60384feb490e878020bdb9c01f514d7856 (patch) | |
tree | 840d02d1090640b08aa481f52d3385ad92552991 /ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system | |
parent | 65c475eb72271f674f5ec4502fa67fd972344543 (diff) |
Sonar Scans and Role Centralization; clean nl
PORTAL-21: centralized user role management
PORTAL-72: Address Sonar Scan code issues for ONAP - mostly on raptor
PORTAL-86: ONAP - Remove internal att.com usages from tests and otherfiles
PORTAL-90: Add debug statements to demo app's class; no functional change
Issue: PORTAL-21 PORTAL-72 PORTAL-86 PORTAL-90
Change-Id: I72a6c812009f51446330bf42bab6d3338d053805
Signed-off-by: Christopher Lott (cl778h) <clott@research.att.com>
Diffstat (limited to 'ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system')
2 files changed, 11 insertions, 2 deletions
diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/AntBuild.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/AntBuild.java index e9a03eec..cc038cab 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/AntBuild.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/AntBuild.java @@ -57,8 +57,9 @@ public class AntBuild { } public static void readManifest() { + JarFile jar = null; try { - JarFile jar = new JarFile("./raptor_fusion.jar"); + jar = new JarFile("./raptor_fusion.jar"); Manifest manifest = jar.getManifest(); Attributes attribs = manifest.getMainAttributes(); @@ -80,6 +81,14 @@ public class AntBuild { } catch (IOException e) { System.err.println("Cannot read jar-file manifest: " + e.getMessage()); + } finally { + if (jar != null) { + try { + jar.close(); + } catch (IOException e) { + throw new RuntimeException("Failed to close jar '"); + } + } } } }
\ No newline at end of file diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/Lookup.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/Lookup.java index ff5fc276..f5447289 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/Lookup.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/system/fusion/adapter/Lookup.java @@ -93,7 +93,7 @@ public class Lookup extends FusionVo implements Serializable { boolean equivalent = false; Lookup lookup = (Lookup)obj; - if( lookup.getValue().equals(getValue()) && lookup.getLabel().equals(getLabel())) { + if(lookup!=null && lookup.getValue().equals(getValue()) && lookup.getLabel().equals(getLabel())) { equivalent = true; } |