From 2f3daf7701f9d0a6a4388c9391eeeb91bbdfb3b6 Mon Sep 17 00:00:00 2001 From: Parshad Patel Date: Thu, 26 Jul 2018 17:26:56 +0900 Subject: Fix sonar issues Fix use try-with-resource issue in portal Issue-ID: PORTAL-342 Change-Id: Ieda3384feddae688c66890743978eaf4deda41e0 Signed-off-by: Parshad Patel --- .../portalapp/widget/service/impl/InitializationServiceImpl.java | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) (limited to 'ecomp-portal-widget-ms') diff --git a/ecomp-portal-widget-ms/widget-ms/src/main/java/org/onap/portalapp/widget/service/impl/InitializationServiceImpl.java b/ecomp-portal-widget-ms/widget-ms/src/main/java/org/onap/portalapp/widget/service/impl/InitializationServiceImpl.java index cbc0c9d0..c9365c46 100644 --- a/ecomp-portal-widget-ms/widget-ms/src/main/java/org/onap/portalapp/widget/service/impl/InitializationServiceImpl.java +++ b/ecomp-portal-widget-ms/widget-ms/src/main/java/org/onap/portalapp/widget/service/impl/InitializationServiceImpl.java @@ -114,18 +114,13 @@ public class InitializationServiceImpl implements InitializationService { long widgetId = widgetCatalogService.saveWidgetCatalog(newWidget); File tmpZipFile = new File("/tmp/" + fileLocation); - InputStream fileInputStream = null; - OutputStream outputStream = null; - try { - fileInputStream = this.getClass().getClassLoader().getResourceAsStream(fileLocation); - outputStream = new FileOutputStream(tmpZipFile); + try(OutputStream outputStream = new FileOutputStream(tmpZipFile); + InputStream fileInputStream = this.getClass().getClassLoader().getResourceAsStream(fileLocation)) { int read = 0; byte[] bytes = new byte[4096]; while ((read = fileInputStream.read(bytes)) != -1) { outputStream.write(bytes, 0, read); } - outputStream.close(); - fileInputStream.close(); } catch (Exception e) { logger.error( "Exception occurred while performing InitializationServiceImpl.initCommonWidget in widget microservices. Details:", e); -- cgit 1.2.3-korg