From b8d51d3080fe8c99b70b3a62ed484ad9ef267ba9 Mon Sep 17 00:00:00 2001
From: Dominik Mizyn <d.mizyn@samsung.com>
Date: Mon, 1 Jul 2019 11:52:31 +0200
Subject: EPAppServiceImpl class fix.

Sonar issues fix:
Remove this unused "logger" private field.
Remove this unused "syncRests" private field.

unused imports delete and unneeded fields initialization fix.
StringBuilder performance fix.

Issue-ID: PORTAL-620
Change-Id: Ibd1cf732b216594b47801767d0a98e59b0aba200
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
---
 .../portalapp/portal/service/EPAppServiceImpl.java | 44 +++++-----------------
 1 file changed, 9 insertions(+), 35 deletions(-)

diff --git a/ecomp-portal-BE-os/src/main/java/org/onap/portalapp/portal/service/EPAppServiceImpl.java b/ecomp-portal-BE-os/src/main/java/org/onap/portalapp/portal/service/EPAppServiceImpl.java
index c2385085..8cee88de 100644
--- a/ecomp-portal-BE-os/src/main/java/org/onap/portalapp/portal/service/EPAppServiceImpl.java
+++ b/ecomp-portal-BE-os/src/main/java/org/onap/portalapp/portal/service/EPAppServiceImpl.java
@@ -2,7 +2,7 @@
  * ============LICENSE_START==========================================
  * ONAP Portal
  * ===================================================================
- * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * Copyright (C) 2019 AT&T Intellectual Property. All rights reserved.
  * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
@@ -33,53 +33,32 @@
  *
  * ============LICENSE_END============================================
  *
- * 
+ *
  */
 package org.onap.portalapp.portal.service;
 
+import com.att.nsa.cambria.client.CambriaClientFactory;
+import com.att.nsa.cambria.client.CambriaTopicManager;
 import java.net.MalformedURLException;
 import java.security.GeneralSecurityException;
 import java.util.ArrayList;
-import java.util.LinkedList;
 import java.util.List;
 import java.util.TreeSet;
-import java.util.UUID;
-
-import javax.servlet.http.HttpServletResponse;
-
-import org.hibernate.Session;
-import org.hibernate.Transaction;
 import org.onap.portalapp.portal.domain.EPApp;
-import org.onap.portalapp.portal.domain.EPUser;
 import org.onap.portalapp.portal.logging.aop.EPMetricsLog;
-import org.onap.portalapp.portal.logging.format.EPAppMessagesEnum;
-import org.onap.portalapp.portal.logging.logic.EPLogUtil;
-import org.onap.portalapp.portal.service.EPAppCommonServiceImpl;
-import org.onap.portalapp.portal.service.EPAppService;
-import org.onap.portalapp.portal.transport.FieldsValidator;
-import org.onap.portalapp.portal.transport.OnboardingApp;
-import org.onap.portalapp.portal.utils.EcompPortalUtils;
-import org.onap.portalsdk.core.logging.logic.EELFLoggerDelegate;
 import org.onap.portalsdk.core.service.DataAccessService;
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.context.annotation.Configuration;
 import org.springframework.context.annotation.EnableAspectJAutoProxy;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
-import com.att.nsa.cambria.client.CambriaClientFactory;
-import com.att.nsa.cambria.client.CambriaTopicManager;
-
 @Service("epAppService")
 @Transactional
-@org.springframework.context.annotation.Configuration
+@Configuration
 @EnableAspectJAutoProxy
 @EPMetricsLog
 public class EPAppServiceImpl extends EPAppCommonServiceImpl implements EPAppService {
-
-	private EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(EPAppServiceImpl.class);
-
-	private static Object syncRests = new Object();
-
 	@Autowired
 	private DataAccessService dataAccessService;
 
@@ -87,17 +66,12 @@ public class EPAppServiceImpl extends EPAppCommonServiceImpl implements EPAppSer
 	public List<EPApp> getUserRemoteApps(String id) {
 		StringBuilder query = new StringBuilder();
 		query.append("SELECT * FROM FN_APP join FN_USER_ROLE ON FN_USER_ROLE.APP_ID = FN_APP.APP_ID where ");
-		query.append("FN_USER_ROLE.USER_ID = " + id + " AND FN_USER_ROLE.ROLE_ID != " + SUPER_ADMIN_ROLE_ID);
+		query.append("FN_USER_ROLE.USER_ID = ").append(id).append(" AND FN_USER_ROLE.ROLE_ID != ")
+			.append(SUPER_ADMIN_ROLE_ID);
 		query.append(" AND FN_APP.ENABLED = 'Y'");
-		TreeSet<EPApp> distinctApps = new TreeSet<EPApp>();
 		@SuppressWarnings("unchecked")
 		List<EPApp> adminApps = dataAccessService.executeSQLQuery(query.toString(), EPApp.class, null);
-		for (EPApp app : adminApps) {
-			distinctApps.add(app);
-		}
-		List<EPApp> userApps = new ArrayList<EPApp>();
-		userApps.addAll(distinctApps);
-		return userApps;
+		return new ArrayList<>(new TreeSet<>(adminApps));
 	}
 
 
-- 
cgit 1.2.3-korg