From 7ae3ab19d0556a0308f0d293d4dd2e58dd3d3929 Mon Sep 17 00:00:00 2001 From: Pamela Dragosh Date: Fri, 2 Oct 2020 09:13:13 -0400 Subject: Remove duplicated code Initially, just moving the applicationName and actions as protected fields got rid of the sonar issue. I included also the supportedPolicyTypes also. But that triggered another sonar duplicate code, so I had to rename a few private fields to rid that. Seems like a very sensitive sonar detection that results in kludgy code. Issue-ID: POLICY-2681 Change-Id: Ie79a95786cdb80381cbce4b182e9e66a2776e0dd Signed-off-by: Pamela Dragosh --- .../monitoring/MonitoringPdpApplication.java | 22 ++++------------------ 1 file changed, 4 insertions(+), 18 deletions(-) (limited to 'applications/monitoring/src') diff --git a/applications/monitoring/src/main/java/org/onap/policy/xacml/pdp/application/monitoring/MonitoringPdpApplication.java b/applications/monitoring/src/main/java/org/onap/policy/xacml/pdp/application/monitoring/MonitoringPdpApplication.java index ada347e2..a3456aea 100644 --- a/applications/monitoring/src/main/java/org/onap/policy/xacml/pdp/application/monitoring/MonitoringPdpApplication.java +++ b/applications/monitoring/src/main/java/org/onap/policy/xacml/pdp/application/monitoring/MonitoringPdpApplication.java @@ -23,9 +23,7 @@ package org.onap.policy.xacml.pdp.application.monitoring; import com.att.research.xacml.api.Response; -import java.util.ArrayList; import java.util.Arrays; -import java.util.List; import java.util.Map; import java.util.Map.Entry; import org.apache.commons.lang3.tuple.Pair; @@ -56,33 +54,21 @@ public class MonitoringPdpApplication extends StdXacmlApplicationServiceProvider public static final String VERSION_100 = "1.0.0"; private StdCombinedPolicyResultsTranslator translator = new StdCombinedPolicyResultsTranslator(); - private List supportedPolicyTypes = new ArrayList<>(); /** * Constructor. */ public MonitoringPdpApplication() { + super(); + + applicationName = "monitoring"; + actions = Arrays.asList("configure"); // // By default this supports just Monitoring policy types // supportedPolicyTypes.add(new ToscaPolicyTypeIdentifier(ONAP_MONITORING_BASE_POLICY_TYPE, VERSION_100)); } - @Override - public String applicationName() { - return "monitoring"; - } - - @Override - public List actionDecisionsSupported() { - return Arrays.asList("configure"); - } - - @Override - public synchronized List supportedPolicyTypes() { - return supportedPolicyTypes; - } - @Override public boolean canSupportPolicyType(ToscaPolicyTypeIdentifier policyTypeId) { // -- cgit 1.2.3-korg