From 248a660d61fa03caa4710cf8cfe144eb245b807b Mon Sep 17 00:00:00 2001 From: Jim Hahn Date: Tue, 21 Jul 2020 09:55:38 -0400 Subject: Fix some sonars in policy-models Fixed the following sonar issues in some of the project directories: - use assertNull, assertEquals, etc. - swap assertEquals arguments - extract a constant - don't invoke toString() in logger calls - TODOs - generic types Issue-ID: POLICY-2714 Change-Id: Id8803f9bf617ea9fc173a67b8606600709b55bdc Signed-off-by: Jim Hahn --- .../java/org/onap/policy/models/sim/pdp/TestPdpSimulatorMain.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'models-sim/policy-models-sim-pdp/src') diff --git a/models-sim/policy-models-sim-pdp/src/test/java/org/onap/policy/models/sim/pdp/TestPdpSimulatorMain.java b/models-sim/policy-models-sim-pdp/src/test/java/org/onap/policy/models/sim/pdp/TestPdpSimulatorMain.java index de0181b70..0f82e6608 100644 --- a/models-sim/policy-models-sim-pdp/src/test/java/org/onap/policy/models/sim/pdp/TestPdpSimulatorMain.java +++ b/models-sim/policy-models-sim-pdp/src/test/java/org/onap/policy/models/sim/pdp/TestPdpSimulatorMain.java @@ -24,6 +24,7 @@ package org.onap.policy.models.sim.pdp; import static org.assertj.core.api.Assertions.assertThatCode; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; import org.junit.After; @@ -81,14 +82,14 @@ public class TestPdpSimulatorMain { public void testPdpSimulator_NoArguments() { final String[] pdpSimulatorConfigParameters = {}; pdpSimulator = new PdpSimulatorMain(pdpSimulatorConfigParameters); - assertTrue(pdpSimulator.getParameters() == null); + assertNull(pdpSimulator.getParameters()); } @Test public void testPdpSimulator_InvalidArguments() { final String[] pdpSimulatorConfigParameters = { "src/test/resourcesPdpSimulatorConfigParameters.json" }; pdpSimulator = new PdpSimulatorMain(pdpSimulatorConfigParameters); - assertTrue(pdpSimulator.getParameters() == null); + assertNull(pdpSimulator.getParameters()); } @Test @@ -102,6 +103,6 @@ public class TestPdpSimulatorMain { final String[] pdpSimulatorConfigParameters = { "-c", "src/test/resources/PdpSimulatorConfigParameters_InvalidName.json" }; pdpSimulator = new PdpSimulatorMain(pdpSimulatorConfigParameters); - assertTrue(pdpSimulator.getParameters() == null); + assertNull(pdpSimulator.getParameters()); } } -- cgit 1.2.3-korg