From fd3c23fd777f49603d370b88d0fb55405d92ce0a Mon Sep 17 00:00:00 2001 From: Jim Hahn Date: Mon, 15 Apr 2019 11:10:58 -0400 Subject: Use keys to speed DB queries When a filter specifies a name (and possibly version), those can be used to speed DB searches. Modified the code to use the keys rather than always retrieving every record before applying the filter. Change-Id: I6b48d9e6880ab7e8132d5d8f770394720031b9b5 Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn --- .../onap/policy/models/pdp/persistence/provider/PdpProvider.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'models-pdp') diff --git a/models-pdp/src/main/java/org/onap/policy/models/pdp/persistence/provider/PdpProvider.java b/models-pdp/src/main/java/org/onap/policy/models/pdp/persistence/provider/PdpProvider.java index 0a0f5f7ef..efdf5f2c8 100644 --- a/models-pdp/src/main/java/org/onap/policy/models/pdp/persistence/provider/PdpProvider.java +++ b/models-pdp/src/main/java/org/onap/policy/models/pdp/persistence/provider/PdpProvider.java @@ -1,6 +1,7 @@ /*- * ============LICENSE_START======================================================= * Copyright (C) 2019 Nordix Foundation. + * Modifications Copyright (C) 2019 AT&T Intellectual Property. All rights reserved. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -79,9 +80,8 @@ public class PdpProvider { */ public List getFilteredPdpGroups(@NonNull final PfDao dao, @NonNull final PdpGroupFilter filter) { - List jpaPdpGroupList = dao.getAll(JpaPdpGroup.class); - - return filter.filter(asPdpGroupList(jpaPdpGroupList)); + return filter.filter( + asPdpGroupList(dao.getFiltered(JpaPdpGroup.class, filter.getName(), PfKey.NULL_KEY_VERSION))); } /** -- cgit 1.2.3-korg