From ddd8b56d7bce562a9990199af9bfe36be4c2ca56 Mon Sep 17 00:00:00 2001 From: Jim Hahn Date: Sat, 13 Apr 2019 20:26:33 -0400 Subject: Disallow empty subgroup list in group request Change-Id: I8a00caf1b22363fe3ab90bdf57244af687a2cb6d Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn --- .../src/main/java/org/onap/policy/models/pdp/concepts/PdpGroup.java | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'models-pdp/src/main/java/org/onap') diff --git a/models-pdp/src/main/java/org/onap/policy/models/pdp/concepts/PdpGroup.java b/models-pdp/src/main/java/org/onap/policy/models/pdp/concepts/PdpGroup.java index 49dfd6fbb..4cb0ac54e 100644 --- a/models-pdp/src/main/java/org/onap/policy/models/pdp/concepts/PdpGroup.java +++ b/models-pdp/src/main/java/org/onap/policy/models/pdp/concepts/PdpGroup.java @@ -89,6 +89,11 @@ public class PdpGroup implements PfNameVersion, Comparable { result.validateNotNull("name", name); result.validateNotNullList("pdpSubgroups", pdpSubgroups, PdpSubGroup::validatePapRest); + if (pdpSubgroups != null && pdpSubgroups.isEmpty()) { + result.addResult(new ObjectValidationResult("pdpSubgroups", pdpSubgroups, ValidationStatus.INVALID, + "is empty")); + } + checkDuplicateSubgroups(result); return result; -- cgit