From 645f53bc65ca649d0ffbdea31d720a371f20811a Mon Sep 17 00:00:00 2001 From: Hengye Date: Fri, 29 Mar 2019 15:07:38 +0000 Subject: fix code smell in model-impl Issue-ID: POLICY-1264 Change-Id: Idacb7151978373e48098790d9d86825410b65aa6 Signed-off-by: Hengye --- .../java/org/onap/policy/sdnr/PciCommonHeader.java | 32 ++++++++--------- .../main/java/org/onap/policy/sdnr/PciWrapper.java | 41 ++++++++++------------ 2 files changed, 34 insertions(+), 39 deletions(-) (limited to 'models-interactions/model-impl/sdnr') diff --git a/models-interactions/model-impl/sdnr/src/main/java/org/onap/policy/sdnr/PciCommonHeader.java b/models-interactions/model-impl/sdnr/src/main/java/org/onap/policy/sdnr/PciCommonHeader.java index 5c1ed4839..f575a73c3 100644 --- a/models-interactions/model-impl/sdnr/src/main/java/org/onap/policy/sdnr/PciCommonHeader.java +++ b/models-interactions/model-impl/sdnr/src/main/java/org/onap/policy/sdnr/PciCommonHeader.java @@ -8,9 +8,9 @@ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at - * + * * http://www.apache.org/licenses/LICENSE-2.0 - * + * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. @@ -57,7 +57,7 @@ public class PciCommonHeader implements Serializable { /** * Used to copy a pci common header. - * + * * @param commonHeader a header that is defined by the Pci api guide that contains information * about the request (requestId, flags, etc.) */ @@ -75,7 +75,7 @@ public class PciCommonHeader implements Serializable { /** * Get the timestamp. - * + * * @return the timeStamp */ public Instant getTimeStamp() { @@ -84,7 +84,7 @@ public class PciCommonHeader implements Serializable { /** * Set the timestamp. - * + * * @param timeStamp * the timeStamp to set */ @@ -94,7 +94,7 @@ public class PciCommonHeader implements Serializable { /** * Get the API version. - * + * * @return the apiVer */ public String getApiVer() { @@ -103,7 +103,7 @@ public class PciCommonHeader implements Serializable { /** * Set the API version. - * + * * @param apiVer * the apiVer to set */ @@ -113,7 +113,7 @@ public class PciCommonHeader implements Serializable { /** * Get the request Id. - * + * * @return the requestId */ public UUID getRequestId() { @@ -122,7 +122,7 @@ public class PciCommonHeader implements Serializable { /** * Set the request Id. - * + * * @param requestId * the requestId to set */ @@ -132,7 +132,7 @@ public class PciCommonHeader implements Serializable { /** * Get the sub request Id. - * + * * @return the subRequestId */ public String getSubRequestId() { @@ -141,7 +141,7 @@ public class PciCommonHeader implements Serializable { /** * Set the sub request Id. - * + * * @param subRequestId * the subRequestId to set */ @@ -150,7 +150,7 @@ public class PciCommonHeader implements Serializable { } /** * Set the request track. - * + * * @param requestTrack * the requestTrack to set */ @@ -159,7 +159,7 @@ public class PciCommonHeader implements Serializable { } /** * Get the request track. - * + * * @return the requestTrack */ public Map getRequestTrack() { @@ -168,7 +168,7 @@ public class PciCommonHeader implements Serializable { /** * Get the flags. - * + * * @return the flags */ public Map getFlags() { @@ -177,7 +177,7 @@ public class PciCommonHeader implements Serializable { /** * Set the flags. - * + * * @param flags * the flags to set */ @@ -187,7 +187,7 @@ public class PciCommonHeader implements Serializable { @Override public String toString() { - return "CommonHeader [timeStamp=" + timeStamp + ", apiVer=" + apiVer + return "CommonHeader [timeStamp=" + timeStamp + ", apiVer=" + apiVer + ", requestId=" + requestId + ", subRequestId=" + subRequestId + ", requestTrack=" + requestTrack + ", flags=" + flags + "]"; } diff --git a/models-interactions/model-impl/sdnr/src/main/java/org/onap/policy/sdnr/PciWrapper.java b/models-interactions/model-impl/sdnr/src/main/java/org/onap/policy/sdnr/PciWrapper.java index 7b8b5b1c1..fd9bb937f 100644 --- a/models-interactions/model-impl/sdnr/src/main/java/org/onap/policy/sdnr/PciWrapper.java +++ b/models-interactions/model-impl/sdnr/src/main/java/org/onap/policy/sdnr/PciWrapper.java @@ -8,9 +8,9 @@ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at - * + * * http://www.apache.org/licenses/LICENSE-2.0 - * + * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. @@ -50,7 +50,7 @@ public class PciWrapper implements Serializable { /** * Get the version. - * + * * @return the version */ public String getVersion() { @@ -59,9 +59,8 @@ public class PciWrapper implements Serializable { /** * Set the version. - * - * @param version - * the version to set + * + * @param version the version to set */ public void setVersion(String version) { this.version = version; @@ -69,7 +68,7 @@ public class PciWrapper implements Serializable { /** * Get the cambria partition. - * + * * @return the cambriaPartition */ public String getCambriaPartition() { @@ -78,9 +77,8 @@ public class PciWrapper implements Serializable { /** * Set the cambria partition. - * - * @param cambriaPartition - * the cambriaPartition to set + * + * @param cambriaPartition the cambriaPartition to set */ public void setCambriaPartition(String cambriaPartition) { this.cambriaPartition = cambriaPartition; @@ -88,7 +86,7 @@ public class PciWrapper implements Serializable { /** * Get the RPN name. - * + * * @return the rpcName */ public String getRpcName() { @@ -97,9 +95,8 @@ public class PciWrapper implements Serializable { /** * Set the RPC name. - * - * @param rpcName - * the rpcName to set + * + * @param rpcName the rpcName to set */ public void setRpcName(String rpcName) { this.rpcName = rpcName; @@ -107,7 +104,7 @@ public class PciWrapper implements Serializable { /** * Get the correlation Id. - * + * * @return the correlationId */ public String getCorrelationId() { @@ -116,9 +113,8 @@ public class PciWrapper implements Serializable { /** * Set the correclation Id. - * - * @param correlationId - * the correlationId to set + * + * @param correlationId the correlationId to set */ public void setCorrelationId(String correlationId) { this.correlationId = correlationId; @@ -126,7 +122,7 @@ public class PciWrapper implements Serializable { /** * Get the type. - * + * * @return the type */ public String getType() { @@ -135,9 +131,8 @@ public class PciWrapper implements Serializable { /** * Set the type. - * - * @param type - * the type to set + * + * @param type the type to set */ public void setType(String type) { this.type = type; @@ -146,7 +141,7 @@ public class PciWrapper implements Serializable { @Override public String toString() { return "Wrapper [version=" + version + ", cambriaPartition=" + cambriaPartition + ", rpcName=" + rpcName - + ", correlationId=" + correlationId + ", type=" + type + "]"; + + ", correlationId=" + correlationId + ", type=" + type + "]"; } @Override -- cgit 1.2.3-korg