From 56bc6f68baeb376b99e0dbe4de4790f494dbe3c2 Mon Sep 17 00:00:00 2001 From: Jim Hahn Date: Mon, 23 Mar 2020 15:04:46 -0400 Subject: New Guard actor request structure is incorrect Missing various fields within the request structure (e.g., ONAPName). Fixed. In the process, also modified makeGuardPayload() so that it only constructs the inner "guard" JSON object, making it easier for invoking code to modify it. Issue-ID: POLICY-2434 Signed-off-by: Jim Hahn Change-Id: I7d34a279845bb98425caf66565eab7513d310815 --- .../actorserviceprovider/impl/OperationPartialTest.java | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) (limited to 'models-interactions/model-actors/actorServiceProvider/src/test') diff --git a/models-interactions/model-actors/actorServiceProvider/src/test/java/org/onap/policy/controlloop/actorserviceprovider/impl/OperationPartialTest.java b/models-interactions/model-actors/actorServiceProvider/src/test/java/org/onap/policy/controlloop/actorserviceprovider/impl/OperationPartialTest.java index b73a3a068..7b8eed59e 100644 --- a/models-interactions/model-actors/actorServiceProvider/src/test/java/org/onap/policy/controlloop/actorserviceprovider/impl/OperationPartialTest.java +++ b/models-interactions/model-actors/actorServiceProvider/src/test/java/org/onap/policy/controlloop/actorserviceprovider/impl/OperationPartialTest.java @@ -324,13 +324,7 @@ public class OperationPartialTest { Map payload = params.getPayload(); assertNotNull(payload); - @SuppressWarnings("unchecked") - Map resource = (Map) payload.get("resource"); - assertNotNull(resource); - - @SuppressWarnings("unchecked") - Map guard = (Map) resource.get("guard"); - assertEquals(oper.makeGuardPayload(), guard); + assertEquals(oper.makeGuardPayload(), payload); } @Test @@ -341,13 +335,13 @@ public class OperationPartialTest { // request id changes, so remove it payload.remove("requestId"); - assertEquals("{actor=my-actor, recipe=my-operation, target=my-entity}", payload.toString()); + assertEquals("{actor=my-actor, operation=my-operation, target=my-entity}", payload.toString()); // repeat, but with closed loop name event.setClosedLoopControlName("my-loop"); payload = oper.makeGuardPayload(); payload.remove("requestId"); - assertEquals("{actor=my-actor, recipe=my-operation, target=my-entity, clname=my-loop}", payload.toString()); + assertEquals("{actor=my-actor, operation=my-operation, target=my-entity, clname=my-loop}", payload.toString()); } @Test -- cgit