From c2779afe6761065de7b06e74dd2a36886c05653f Mon Sep 17 00:00:00 2001 From: waynedunican Date: Thu, 18 Jun 2020 10:46:36 +0100 Subject: Replaced try/catch blocks in policy/models with assertj assertions. Issue-ID: POLICY-2451 Change-Id: I095beb674196d5ec5c4dd9b93d3a56cca5ee4788 Signed-off-by: waynedunican --- .../errors/concepts/ErrorResponseUtilsTest.java | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) (limited to 'models-errors') diff --git a/models-errors/src/test/java/org/onap/policy/models/errors/concepts/ErrorResponseUtilsTest.java b/models-errors/src/test/java/org/onap/policy/models/errors/concepts/ErrorResponseUtilsTest.java index 261e58a8d..c19b18b63 100644 --- a/models-errors/src/test/java/org/onap/policy/models/errors/concepts/ErrorResponseUtilsTest.java +++ b/models-errors/src/test/java/org/onap/policy/models/errors/concepts/ErrorResponseUtilsTest.java @@ -1,6 +1,6 @@ /*- * ============LICENSE_START======================================================= - * Copyright (C) 2019 Nordix Foundation. + * Copyright (C) 2019-2020 Nordix Foundation. * Modifications Copyright (C) 2019 AT&T Intellectual Property. All rights reserved. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); @@ -21,10 +21,10 @@ package org.onap.policy.models.errors.concepts; +import static org.assertj.core.api.Assertions.assertThat; import static org.junit.Assert.assertEquals; import java.io.IOException; - import org.junit.Test; /** @@ -37,15 +37,13 @@ public class ErrorResponseUtilsTest { @Test public void testErrorResponseUtils() { - try { - throw new IOException(EXCEPTION1, new NumberFormatException("Exception 0")); - } catch (Exception ioe) { - ErrorResponse errorResponse = new ErrorResponse(); - ErrorResponseUtils.getExceptionMessages(errorResponse, ioe); + final IOException ioe = new IOException(EXCEPTION1, new NumberFormatException("Exception 0")); + final ErrorResponse errorResponse = new ErrorResponse(); + assertThat(ioe).hasMessage(EXCEPTION1); - assertEquals(EXCEPTION1, errorResponse.getErrorMessage()); - assertEquals(EXCEPTION1, errorResponse.getErrorDetails().get(0)); - assertEquals("Exception 0", errorResponse.getErrorDetails().get(1)); - } + ErrorResponseUtils.getExceptionMessages(errorResponse, ioe); + assertEquals(EXCEPTION1, errorResponse.getErrorMessage()); + assertEquals(EXCEPTION1, errorResponse.getErrorDetails().get(0)); + assertEquals("Exception 0", errorResponse.getErrorDetails().get(1)); } } -- cgit 1.2.3-korg