From 77df45928640808633af05908c680955848e4cd2 Mon Sep 17 00:00:00 2001 From: Jim Hahn Date: Fri, 14 Jun 2019 15:02:00 -0400 Subject: Fix simple sonar issues in models: errors to sim-pdp models-errors models-pdp models-provider models-sim-pdp Also had to work around this checkstyle issue: src/test/java/org/onap/policy/models/sim/pdp/comm/ TestPdpStateChangeListener.java:[77,32] (javadoc) JavadocMethod: Unable to get class information for @throws tag 'PdpSimulatorException'. The error appears to be bogus, as PdpSimulatorException is on the "throws" line thus indicating that the class IS accessible to the above java file. Change-Id: Iaca58457a32b00121000fc0bab12a8be4cb19bac Issue-ID: POLICY-1791 Signed-off-by: Jim Hahn --- .../models/errors/concepts/ErrorResponseUtilsTest.java | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) (limited to 'models-errors') diff --git a/models-errors/src/test/java/org/onap/policy/models/errors/concepts/ErrorResponseUtilsTest.java b/models-errors/src/test/java/org/onap/policy/models/errors/concepts/ErrorResponseUtilsTest.java index 4f4ef395a..261e58a8d 100644 --- a/models-errors/src/test/java/org/onap/policy/models/errors/concepts/ErrorResponseUtilsTest.java +++ b/models-errors/src/test/java/org/onap/policy/models/errors/concepts/ErrorResponseUtilsTest.java @@ -1,6 +1,7 @@ /*- * ============LICENSE_START======================================================= * Copyright (C) 2019 Nordix Foundation. + * Modifications Copyright (C) 2019 AT&T Intellectual Property. All rights reserved. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -32,21 +33,18 @@ import org.junit.Test; * @author Liam Fallon (liam.fallon@est.tech) */ public class ErrorResponseUtilsTest { + private static final String EXCEPTION1 = "Exception 1"; + @Test public void testErrorResponseUtils() { try { - try { - throw new NumberFormatException("Exception 0"); - } - catch (Exception nfe) { - throw new IOException("Exception 1", nfe); - } + throw new IOException(EXCEPTION1, new NumberFormatException("Exception 0")); } catch (Exception ioe) { ErrorResponse errorResponse = new ErrorResponse(); ErrorResponseUtils.getExceptionMessages(errorResponse, ioe); - assertEquals("Exception 1", errorResponse.getErrorMessage()); - assertEquals("Exception 1", errorResponse.getErrorDetails().get(0)); + assertEquals(EXCEPTION1, errorResponse.getErrorMessage()); + assertEquals(EXCEPTION1, errorResponse.getErrorDetails().get(0)); assertEquals("Exception 0", errorResponse.getErrorDetails().get(1)); } } -- cgit 1.2.3-korg