diff options
| author |   waynedunican <wayne.dunican@est.tech> | 2024-07-23 09:23:51 +0100 |
|---|---|---|
| committer | waynedunican <wayne.dunican@est.tech> | 2024-08-13 08:49:10 +0100 |
| commit | b7804abcf865dc58a01bed3f2be4756e731d9288 (patch) | |
| tree | 7f6fc3b50622578bb8612de9fe5e5c6adddfaf28 /models-interactions/model-impl/appc | |
| parent | a029ccab07f2dd71286804da620c513da9fdfc0e (diff) | |
Improve code coverage and sonar fixes
Increased code coverage to 90%
SONAR - Removed TODO comments
SONAR - Added NOSONAR where appropriate
SONAR - Replaced stream.Collect() with stream.toList() where applicable
SONAR - Made variables serializable or transient to comply with sonar rules
Issue-ID: POLICY-5069
Change-Id: Ife256eaf4e6f427fe40b138bacc6f112dc5bcea4
Signed-off-by: waynedunican <wayne.dunican@est.tech>
Diffstat (limited to 'models-interactions/model-impl/appc')
4 files changed, 4 insertions, 4 deletions
diff --git a/models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/CommonHeaderTest.java b/models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/CommonHeaderTest.java index 72a78147b..0a47fcb05 100644 --- a/models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/CommonHeaderTest.java +++ b/models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/CommonHeaderTest.java @@ -87,7 +87,7 @@ class CommonHeaderTest { assertEquals(commonHeader, (Object) commonHeader); assertEquals(commonHeader, copiedCommonHeader); - assertNotEquals(commonHeader, null); + assertNotNull(commonHeader); assertNotEquals(commonHeader, (Object) "Hello"); CommonHeader clonedCommonHeader = new CommonHeader(commonHeader); diff --git a/models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/RequestTest.java b/models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/RequestTest.java index 7ab4ae746..67b3d85d4 100644 --- a/models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/RequestTest.java +++ b/models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/RequestTest.java @@ -76,7 +76,7 @@ class RequestTest { assertEquals(request, (Object) request); assertEquals(request, copiedRequest); - assertNotEquals(request, null); + assertNotNull(request); assertNotEquals(request, (Object) "Hello"); checkField(commonHeader, Request::setCommonHeader); diff --git a/models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/ResponseStatusTest.java b/models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/ResponseStatusTest.java index a13e08f64..f095df909 100644 --- a/models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/ResponseStatusTest.java +++ b/models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/ResponseStatusTest.java @@ -58,7 +58,7 @@ class ResponseStatusTest { assertEquals(status, (Object) status); assertEquals(status, copiedStatus); - assertNotEquals(status, null); + assertNotNull(status); assertNotEquals(status, (Object) "Hello"); status.setCode(-1); diff --git a/models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/ResponseTest.java b/models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/ResponseTest.java index ee0ff371b..dffb9588c 100644 --- a/models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/ResponseTest.java +++ b/models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/ResponseTest.java @@ -70,7 +70,7 @@ class ResponseTest { assertEquals(response, (Object) response); assertEquals(response, copiedResponse); - assertNotEquals(response, null); + assertNotNull(response); assertNotEquals(response, (Object) "Hello"); response.setCommonHeader(null); |