From 13a50bb9b035c6408019ef58297009f7e3fe2779 Mon Sep 17 00:00:00 2001 From: Jim Hahn Date: Thu, 11 Feb 2021 15:55:33 -0500 Subject: Fix sonars in gui Addressed the following issues (java only): - assignment to static field - expression is always true - duplicate character in regex - duplicate code - remove Thread.sleep() from junit test Issue-ID: POLICY-3063 Change-Id: I70951ed47defad5baa6c957852663688e51fa88a Signed-off-by: Jim Hahn --- .../onap/policy/gui/pdp/monitoring/MonitoringMainTest.java | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) (limited to 'gui-pdp-monitoring/src/test/java') diff --git a/gui-pdp-monitoring/src/test/java/org/onap/policy/gui/pdp/monitoring/MonitoringMainTest.java b/gui-pdp-monitoring/src/test/java/org/onap/policy/gui/pdp/monitoring/MonitoringMainTest.java index 6421b01..b680cac 100644 --- a/gui-pdp-monitoring/src/test/java/org/onap/policy/gui/pdp/monitoring/MonitoringMainTest.java +++ b/gui-pdp-monitoring/src/test/java/org/onap/policy/gui/pdp/monitoring/MonitoringMainTest.java @@ -1,6 +1,7 @@ /*- * ============LICENSE_START======================================================= * Copyright (C) 2020 Nordix Foundation. + * Modifications Copyright (C) 2021 AT&T Intellectual Property. All rights reserved. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -150,9 +151,18 @@ public class MonitoringMainTest { try { monThread.start(); - Thread.sleep(2000); + /* + * For some reason, getResource("webapp") returns null to PdpMonitoringServer, + * which results in an NPE, thus the server never gets started (in ANY of + * these test cases). Therefore, commented out the code that waits for it to + * start. + */ + // assertThat(monRestMain.awaitStart(5, TimeUnit.SECONDS)).isTrue(); monRestMain.shutdown(); + monThread.join(5000); + assertThat(monThread.isAlive()).isFalse(); } catch (Exception ex) { + monRestMain.shutdown(); fail("test should not throw an exception"); } } -- cgit