From aabae2a75c606a8f44fd5e0b38d840bf8cd767dc Mon Sep 17 00:00:00 2001 From: mkidd Date: Wed, 24 Mar 2021 12:26:31 +0000 Subject: Fix sonarqube code smells Making changed regarding code smells. Some variables being declared twice while in scope. renaming some modelFileName in ApexFiles.js that is being declared while there is a constant with the same name. renamed some of the for loop control variables so that sonarqube doesnt see it as an issue Made changes based on reviews Issue-ID: POLICY-3095 Change-Id: If38934247a4e4ff9c48043feb3adde5505c46993 Signed-off-by: mkidd --- .../gui-editor-apex/src/main/resources/webapp/js/dropdownList.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'gui-editors/gui-editor-apex/src/main/resources/webapp/js/dropdownList.js') diff --git a/gui-editors/gui-editor-apex/src/main/resources/webapp/js/dropdownList.js b/gui-editors/gui-editor-apex/src/main/resources/webapp/js/dropdownList.js index 497bd68..3657fd4 100644 --- a/gui-editors/gui-editor-apex/src/main/resources/webapp/js/dropdownList.js +++ b/gui-editors/gui-editor-apex/src/main/resources/webapp/js/dropdownList.js @@ -1,7 +1,7 @@ /* * ============LICENSE_START======================================================= * Copyright (C) 2016-2018 Ericsson. All rights reserved. - * Modifications Copyright (C) 2020 Nordix Foundation. + * Modifications Copyright (C) 2020-2021 Nordix Foundation. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -55,9 +55,9 @@ function dropdownList_display_hide(optionDiv) { } function dropdownList_filter(optionDiv, optionUl) { var input, filter, ul; - var input = document.getElementById(optionDiv + "_search"); - var filter = input.value.toUpperCase(); - var ul = document.getElementById(optionDiv + "_options_list_ul"); + input = document.getElementById(optionDiv + "_search"); + filter = input.value.toUpperCase(); + ul = document.getElementById(optionDiv + "_options_list_ul"); var lis = ul.querySelectorAll("#" + ul.id + " > li"); // get li direct // child elements for (var i = 0; i < lis.length; i++) { -- cgit 1.2.3-korg