diff options
author | mkidd <michael.kidd@est.tech> | 2021-03-24 12:26:31 +0000 |
---|---|---|
committer | mkidd <michael.kidd@est.tech> | 2021-03-25 16:14:07 +0000 |
commit | aabae2a75c606a8f44fd5e0b38d840bf8cd767dc (patch) | |
tree | d9a4a1f0c6addb20cde96bb5edd6c60259bda868 /gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexTaskTab.js | |
parent | e13710d3bd6c6aa1c02ccc3ee9e1ecf8b77581c0 (diff) |
Fix sonarqube code smells
Making changed regarding code smells. Some variables being declared twice while in scope.
renaming some modelFileName in ApexFiles.js that is being declared while there is a constant with the same name.
renamed some of the for loop control variables so that sonarqube doesnt see it as an issue
Made changes based on reviews
Issue-ID: POLICY-3095
Change-Id: If38934247a4e4ff9c48043feb3adde5505c46993
Signed-off-by: mkidd <michael.kidd@est.tech>
Diffstat (limited to 'gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexTaskTab.js')
-rw-r--r-- | gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexTaskTab.js | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexTaskTab.js b/gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexTaskTab.js index cb442be..28d9379 100644 --- a/gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexTaskTab.js +++ b/gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexTaskTab.js @@ -1,7 +1,7 @@ /* * ============LICENSE_START======================================================= * Copyright (C) 2016-2018 Ericsson. All rights reserved. - * Modifications Copyright (C) 2020 Nordix Foundation. + * Modifications Copyright (C) 2020-2021 Nordix Foundation. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -41,7 +41,6 @@ function taskTab_activate() { const task = JSON.parse(data.messages.message[i]).apexTask; const taskRow_tr = document.createElement("tr"); - const taskid = task.key.name + ":" + task.key.version; var taskTableRow = "<td>" + @@ -68,8 +67,8 @@ function taskTab_activate() { taskTableRow += "</tbody></table></td>"; taskTableRow += "<td><table class='ebTable'><thead><tr class='headerRow'><th>Field Name</th><th>Field Type/Schema</th><th>Optional</th></tr></thead><tbody>"; - for (var f = 0; f < task.outputFields.entry.length; f++) { - var fieldEntry = task.outputFields.entry[f]; + for (var t = 0; t < task.outputFields.entry.length; t++) { + fieldEntry = task.outputFields.entry[t]; taskTableRow += "<tr><td>" + @@ -134,7 +133,7 @@ function taskTab_create() { return } - var taskTabContent = document.createElement("taskTabContent"); + taskTabContent = document.createElement("taskTabContent"); taskTab.appendChild(taskTabContent); taskTabContent.setAttribute("id", "taskTabContent"); taskTabContent.addEventListener('contextmenu', rightClickMenu_scopePreserver("taskTabContent", "Task", null, null)); |