From 7a0d068cd318eedce284c48dd46faccf2f5335ec Mon Sep 17 00:00:00 2001 From: "Magnusen, Drew (dm741q)" Date: Thu, 21 Dec 2017 12:03:33 -0600 Subject: Sonar cleanup for PolicyEngineUtils Changes to resolve some sonar "major" issues in the PolicyEngineUtils module. Patch 2: Updated the NotificationStoreTest junit to account for the return of a "Collections.emptyList()" rather than "null" in StdPDPNotification class. Patch 3: Updated the StdPDPNotificationTest junit to account for the return of a "Collections.emptyList()" rather than "null" in StdPDPNotifaction class. Issue-ID: POLICY-474 Change-Id: I925774ac181fd38d1206637f47ab27ba499629ef Signed-off-by: Magnusen, Drew (dm741q) --- .../src/test/java/org/onap/policy/utils/test/NotificationStoreTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'PolicyEngineUtils/src/test/java') diff --git a/PolicyEngineUtils/src/test/java/org/onap/policy/utils/test/NotificationStoreTest.java b/PolicyEngineUtils/src/test/java/org/onap/policy/utils/test/NotificationStoreTest.java index 7bae4239d..774bf8a7e 100644 --- a/PolicyEngineUtils/src/test/java/org/onap/policy/utils/test/NotificationStoreTest.java +++ b/PolicyEngineUtils/src/test/java/org/onap/policy/utils/test/NotificationStoreTest.java @@ -43,7 +43,7 @@ public class NotificationStoreTest { public void notificationTest() throws IOException{ // Notification Delta test first. NotificationStore.recordNotification(new StdPDPNotification()); - assertEquals("{\"removedPolicies\":null,\"loadedPolicies\":null,\"notificationType\":null}", PolicyUtils.objectToJsonString(NotificationStore.getDeltaNotification(new StdPDPNotification()))); + assertEquals("{\"removedPolicies\":[],\"loadedPolicies\":[],\"notificationType\":null}", PolicyUtils.objectToJsonString(NotificationStore.getDeltaNotification(new StdPDPNotification()))); // Initialize test StdPDPNotification notification = new StdPDPNotification(); notification.setNotificationType(NotificationType.BOTH); -- cgit 1.2.3-korg