From 7a0d068cd318eedce284c48dd46faccf2f5335ec Mon Sep 17 00:00:00 2001 From: "Magnusen, Drew (dm741q)" Date: Thu, 21 Dec 2017 12:03:33 -0600 Subject: Sonar cleanup for PolicyEngineUtils Changes to resolve some sonar "major" issues in the PolicyEngineUtils module. Patch 2: Updated the NotificationStoreTest junit to account for the return of a "Collections.emptyList()" rather than "null" in StdPDPNotification class. Patch 3: Updated the StdPDPNotificationTest junit to account for the return of a "Collections.emptyList()" rather than "null" in StdPDPNotifaction class. Issue-ID: POLICY-474 Change-Id: I925774ac181fd38d1206637f47ab27ba499629ef Signed-off-by: Magnusen, Drew (dm741q) --- .../test/java/org/onap/policy/std/test/StdPDPNotificationTest.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'PolicyEngineAPI') diff --git a/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/StdPDPNotificationTest.java b/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/StdPDPNotificationTest.java index 6a558006d..23b570e9a 100644 --- a/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/StdPDPNotificationTest.java +++ b/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/StdPDPNotificationTest.java @@ -21,6 +21,7 @@ package org.onap.policy.std.test; import java.util.Collection; +import java.util.Collections; import java.util.LinkedList; import org.junit.*; @@ -115,7 +116,7 @@ public class StdPDPNotificationTest { Collection result = fixture.getLoadedPolicies(); // add additional test code here - assertEquals(null, result); + assertEquals(Collections.EMPTY_LIST, result); } /** @@ -204,7 +205,7 @@ public class StdPDPNotificationTest { Collection result = fixture.getRemovedPolicies(); // add additional test code here - assertEquals(null, result); + assertEquals(Collections.EMPTY_LIST, result); } /** -- cgit 1.2.3-korg