From 1148834bc4b10d00c1b1830b087357e63af8293f Mon Sep 17 00:00:00 2001
From: rb7147 <rb7147@att.com>
Date: Thu, 1 Feb 2018 12:07:13 -0500
Subject: Included Policy GUI Enhancements and validations

Added hover messages for all policy templates.
Resolved few sonar issues.
Added fixes for Policy GUI Validations.

Issue-ID: POLICY-597
Change-Id: I74abb92dd6ac8722d7869b6a316fad1d8db11d9c
Signed-off-by: rb7147 <rb7147@att.com>
---
 .../PolicyTemplates/FirewallPolicyTemplate.html    | 36 ++++++++++++----------
 1 file changed, 20 insertions(+), 16 deletions(-)

(limited to 'POLICY-SDK-APP/src/main/webapp/app/policyApp/policy-models/Editor/PolicyTemplates/FirewallPolicyTemplate.html')

diff --git a/POLICY-SDK-APP/src/main/webapp/app/policyApp/policy-models/Editor/PolicyTemplates/FirewallPolicyTemplate.html b/POLICY-SDK-APP/src/main/webapp/app/policyApp/policy-models/Editor/PolicyTemplates/FirewallPolicyTemplate.html
index 7f6a36b39..af1bea1d6 100644
--- a/POLICY-SDK-APP/src/main/webapp/app/policyApp/policy-models/Editor/PolicyTemplates/FirewallPolicyTemplate.html
+++ b/POLICY-SDK-APP/src/main/webapp/app/policyApp/policy-models/Editor/PolicyTemplates/FirewallPolicyTemplate.html
@@ -7,12 +7,13 @@
 						class="form-control" ng-disabled="temp.policy.readOnly"
 						ng-readonly="temp.policy.editPolicy"
 						ng-model="temp.policy.policyName" required pattern="\S+"
-						title="Enter the Policy Name without any spaces" />
+						title="Enter Policy Name without any spaces and special characters and will accept _." />
 				</div>
 				<div class="form-group col-sm-6">
 					<label>Description:</label> <input type="text" class="form-control"
 						ng-disabled="temp.policy.readOnly"
-						ng-model="temp.policy.policyDescription" />
+						ng-model="temp.policy.policyDescription" 
+						title="Description field will accept any type of data."/>
 				</div>
 			</div>
 			<div class="form-group row">
@@ -21,13 +22,13 @@
 						class="form-control" ng-disabled="temp.policy.readOnly"
 						ng-model="temp.policy.riskType"
 						ng-options="option for option in riskTypeDictionaryDatas track by option"
-						required pattern="\S+" title="RiskType is required"></select>
+						required pattern="\S+" title="Select the dropdown value driven from RiskType (Safe Policy)Dictionary."></select>
 				</div>
 				<div class="form-group col-sm-3">
 					<label>Risk Level:<sup><b>*</b></sup></label> <select
 						class="form-control" ng-disabled="temp.policy.readOnly"
 						ng-model="temp.policy.riskLevel"
-						required pattern="\S+" title="RiskLevel is required">
+						required pattern="\S+" title="Select the dropdown Risk level value.">
 						<option>1</option>
 						<option>2</option>
 						<option>3</option>
@@ -38,7 +39,7 @@
 					<label>Guard:<sup><b>*</b></sup></label> <select
 						class="form-control" ng-disabled="temp.policy.readOnly"
 						ng-model="temp.policy.guard"
-						required pattern="\S+" title="Guard is required">
+						required pattern="\S+" title="Select the dropdown Guard value.">
 						<option>True</option>
 						<option>False</option></select>
 				</div>
@@ -47,18 +48,19 @@
 				<div class="form-group col-sm-3">
 					<label>Config Name:<sup><b>*</b></sup></label> <input type="text"
 						class="form-control" ng-disabled="temp.policy.readOnly"
-						ng-model="temp.policy.configName" required />
+						ng-model="temp.policy.configName" required title="Enter the Config Name without any spaces and special characters." />
 				</div>
 				<div class="form-group col-sm-3">
 					<label>Time to Live Date:</label> <input type="text" id="ttlDate"
 						class="form-control" name="ttlDate" ng-disabled="temp.policy.readOnly"
-						ng-model="temp.policy.ttlDate" />
+						ng-model="temp.policy.ttlDate" title="Select the date from calender onclick on the field."/>
 				</div>
 				<div class="form-group col-sm-3">
 					<label>Security Zone:<sup><b>*</b></sup></label> <select class="form-control"
 						ng-disabled="temp.policy.readOnly"
 						ng-model="temp.policy.securityZone"
-						ng-options="option for option in securityZoneDictionaryDatas track by option"></select>
+						ng-options="option for option in securityZoneDictionaryDatas track by option"
+						title="Select the dropdown value driven from Security Zone (Firewall Policy)Dictionary."></select>
 				</div>
 			</div>
 		</div>
@@ -67,7 +69,7 @@
 				<div class="form-group col-sm-1">
 					<label>Rule Setup:</label><br>
 					<button type="button" class="btn btn-default"
-						ng-disabled="temp.policy.readOnly" ng-click="addNewChoice()">
+						ng-disabled="temp.policy.readOnly" ng-click="addNewChoice()" title="onClick Rule Setup row is added.">
 						<i class="fa fa-plus"></i>
 					</button>
 				</div>
@@ -78,19 +80,21 @@
 						<div class="form-group col-sm-3">
 							<select class="form-control" ng-model="choice.key"
 								ng-disabled="temp.policy.readOnly"
-								ng-options="option for option in termListDictionaryDatas track by option"><option
+								ng-options="option for option in termListDictionaryDatas track by option"
+								title="Select the dropdown value driven from Term List (Firewall Policy)Dictionary."><option
 									value="">{{choice.key}}</option></select>
 						</div>
 						<div class="form-group col-sm-3">
 							<select class="form-control" ng-model="choice.value"
 								ng-disabled="temp.policy.readOnly"
-								ng-options="option for option in fwTagPickerDictionaryDatas track by option"><option
+								ng-options="option for option in fwTagPickerDictionaryDatas track by option"
+								title="Select the dropdown value driven from FW TagPicker (Firewall Policy)Dictionary."><option
 									value="">{{choice.value}}</option></select>
 						</div>
 						<div class="form-group col-sm-1">
 							<button type="button" class="btn btn-default"
 								ng-disabled="temp.policy.readOnly" ng-show="$last"
-								ng-click="removeChoice()">
+								ng-click="removeChoice()" title="onClick will remove the last row">
 								<i class="fa fa-minus"></i>
 							</button>
 						</div>
@@ -103,15 +107,15 @@
 		<br>
 		<div class="modal-footer">
 			<button type="button" class="btn btn-default"
-				herf="javascript:void(0)" ng-click="viewFWRule(temp.policy);">Rule
+				herf="javascript:void(0)" ng-click="viewFWRule(temp.policy);" title="onClick Firewall Policy Rule is previewed based on the values entered in the template.">Rule
 				Preview</button>
 			<button class="btn btn-primary" herf="javascript:void(0)"
 				ng-disabled="temp.policy.readOnly"
-				ng-click="validatePolicy(temp.policy);">Validate</button>
+				ng-click="validatePolicy(temp.policy);" title="Validate the data entered in the Policy fields.">Validate</button>
 			<button class="btn btn-success" herf="javascript:void(0)"
 				ng-disabled="savebutton" ng-disabled="temp.policy.readOnly"
-				ng-click="saveFWPolicy(temp);">Save</button>
-			<button type="button" class="btn btn-default" ng-click="refresh();">Close</button>
+				ng-click="saveFWPolicy(temp);" title="Save the Policy with validated data.">Save</button>
+			<button type="button" class="btn btn-default" ng-click="refresh();" title="Close the template.">Close</button>
 		</div>
 	</form>
 </div>
\ No newline at end of file
-- 
cgit 1.2.3-korg