From 1148834bc4b10d00c1b1830b087357e63af8293f Mon Sep 17 00:00:00 2001
From: rb7147 <rb7147@att.com>
Date: Thu, 1 Feb 2018 12:07:13 -0500
Subject: Included Policy GUI Enhancements and validations

Added hover messages for all policy templates.
Resolved few sonar issues.
Added fixes for Policy GUI Validations.

Issue-ID: POLICY-597
Change-Id: I74abb92dd6ac8722d7869b6a316fad1d8db11d9c
Signed-off-by: rb7147 <rb7147@att.com>
---
 .../PolicyTemplates/BRMSParamPolicyTemplate.html   | 37 +++++++++++-----------
 1 file changed, 19 insertions(+), 18 deletions(-)

(limited to 'POLICY-SDK-APP/src/main/webapp/app/policyApp/policy-models/Editor/PolicyTemplates/BRMSParamPolicyTemplate.html')

diff --git a/POLICY-SDK-APP/src/main/webapp/app/policyApp/policy-models/Editor/PolicyTemplates/BRMSParamPolicyTemplate.html b/POLICY-SDK-APP/src/main/webapp/app/policyApp/policy-models/Editor/PolicyTemplates/BRMSParamPolicyTemplate.html
index d941c2404..24994d3da 100644
--- a/POLICY-SDK-APP/src/main/webapp/app/policyApp/policy-models/Editor/PolicyTemplates/BRMSParamPolicyTemplate.html
+++ b/POLICY-SDK-APP/src/main/webapp/app/policyApp/policy-models/Editor/PolicyTemplates/BRMSParamPolicyTemplate.html
@@ -8,12 +8,13 @@
 						class="form-control" ng-disabled="temp.policy.readOnly"
 						ng-readonly="temp.policy.editPolicy"
 						ng-model="temp.policy.policyName" required pattern="\S+"
-						title="Enter the Policy Name without any spaces" />
+						title="Enter Policy Name without any spaces and special characters and will accept _." />
 				</div>
 				<div class="form-group col-sm-6">
 					<label>Description:</label> <input type="text" class="form-control"
 						ng-disabled="temp.policy.readOnly"
-						ng-model="temp.policy.policyDescription" />
+						ng-model="temp.policy.policyDescription" 
+						title="Description field will accept any type of data."/>
 				</div>
 			</div>
 			<div class="form-group row">
@@ -22,13 +23,13 @@
 						class="form-control" ng-disabled="temp.policy.readOnly"
 						ng-model="temp.policy.riskType"
 						ng-options="option for option in riskTypeDictionaryDatas track by option"
-						required pattern="\S+" title="RiskType is required"></select>
+						required pattern="\S+" title="Select the dropdown value driven from RiskType (Safe Policy)Dictionary."></select>
 				</div>
 				<div class="form-group col-sm-3">
 					<label>Risk Level:<sup><b>*</b></sup></label> <select
 						class="form-control" ng-disabled="temp.policy.readOnly"
 						ng-model="temp.policy.riskLevel"
-						required pattern="\S+" title="RiskLevel is required">
+						required pattern="\S+" title="Select the dropdown Risk level value.">
 						<option>1</option>
 						<option>2</option>
 						<option>3</option>
@@ -39,7 +40,7 @@
 					<label>Guard:<sup><b>*</b></sup></label> <select
 						class="form-control" ng-disabled="temp.policy.readOnly"
 						ng-model="temp.policy.guard"
-						required pattern="\S+" title="Guard is required">
+						required pattern="\S+" title="Select the dropdown Guard value.">
 						<option>True</option>
 						<option>False</option></select>
 				</div>
@@ -48,19 +49,19 @@
 				<div class="form-group col-sm-3">
 					<label>Time to Live Date:</label> <input type="text" id="ttlDate"
 						class="form-control" name="ttlDate" ng-disabled="temp.policy.readOnly"
-						ng-model="temp.policy.ttlDate" />
+						ng-model="temp.policy.ttlDate" title="Select the date from calender onclick on the field."/>
 				</div>
 				<div class="form-group col-sm-3">
 					<label>Controller:<sup></sup></label> <select
 						class="form-control" ng-disabled="temp.policy.readOnly"
 						ng-model="temp.policy.brmsController"
-						ng-options="option for option in brmsControllerDatas track by option"></select>
+						ng-options="option for option in brmsControllerDatas track by option" title="Select the dropdown value driven from BRMS Controller (BRMS)Dictionary."></select>
 				</div>
 				<div class="form-group col-sm-3">
 					<label>Dependencies:<sup></sup></label> <select
 						class="form-control" multiple ng-disabled="temp.policy.readOnly"
 						ng-model="temp.policy.brmsDependency"
-						ng-options="option for option in brmsDependencyDatas track by option"></select>
+						ng-options="option for option in brmsDependencyDatas track by option" title="Select the dropdown value driven from BRMS Dependency (BRMS)Dictionary."></select>
 				</div>
 			</div>
 		</div>
@@ -69,7 +70,7 @@
 				<div class="form-group col-sm-2">
 					<label>Rule Attributes:<sup><b></b></sup></label>
 					<button type="button" class="btn btn-default"
-						ng-disabled="temp.policy.readOnly" ng-click="addNewChoice()">
+						ng-disabled="temp.policy.readOnly" ng-click="addNewChoice()" title="onClick Rule Attribute row is added.">
 						<i class="fa fa-plus"></i>
 					</button>
 				</div>
@@ -79,17 +80,17 @@
 					<div class="form-group row" style="margin-left: 2%">
 						<div class="form-group col-sm-3">
 							<input type="text" class="form-control"
-								ng-disabled="temp.policy.readOnly" ng-model="choice.key"
+								ng-disabled="temp.policy.readOnly" ng-model="choice.key" title="Enter the Rule Attribute Key without any spaces and special characters"
 								placeholder="Attribute Key" />
 						</div>
 						<div class="form-group col-sm-3">
 							<input type="text" class="form-control"
-								ng-disabled="temp.policy.readOnly" ng-model="choice.value"
+								ng-disabled="temp.policy.readOnly" ng-model="choice.value" title="Enter the Rule Attribute Value without any spaces and special characters"
 								placeholder="Attribute Value" />
 						</div>
 						<div class="form-group col-sm-1">
 							<button type="button" class="btn btn-default" ng-show="$last"
-								ng-disabled="temp.policy.readOnly" ng-click="removeChoice()">
+								ng-disabled="temp.policy.readOnly" ng-click="removeChoice()" title="onClick will remove the last row">
 								<i class="fa fa-minus"></i>
 							</button>
 						</div>
@@ -104,7 +105,7 @@
 						class="form-control" ng-disabled="temp.policy.readOnly"
 						ng-model="temp.policy.ruleName"
 						ng-options="option for option in brmsParamDictionaryDatas track by option"
-						ng-click="addDataToFields(temp.policy.ruleName);">
+						ng-click="addDataToFields(temp.policy.ruleName);" title="Select the dropdown value driven from BRMSParamTemplate (BRMS)Dictionary">
 						<option value="">{{temp.policy.ruleName}}</option>
 					</select>
 				</div>
@@ -129,7 +130,7 @@
 			<h2 class="font-showcase-font-name"> Rule Preview: </h2>
 			<div class="divider-container"><hr> </div>
 			<textarea type="text" style="width: 100%; height: 800px" ng-bind="datarule" ng-disabled="true"></textarea>
-			<button class="btn btn-default" herf="javascript:void(0)" ng-click="hideRule();">Hide Rule</button>
+			<button class="btn btn-default" herf="javascript:void(0)" ng-click="hideRule();" title="OnClick the BRMS Rule will be Hidden.">Hide Rule</button>
 		</div>	
 		</div>
 		<br>
@@ -137,14 +138,14 @@
 			<div>
 				<button class="btn btn-primary" herf="javascript:void(0)"
 					ng-disabled="temp.policy.readOnly"
-					ng-click="validatePolicy(temp.policy);">Validate</button>
+					ng-click="validatePolicy(temp.policy);" title="Validate the data entered in the Policy fields.">Validate</button>
 				<button class="btn btn-default" herf="javascript:void(0)"
-					ng-disabled="validateSuccess" ng-click="ShowRule(temp);">Show
+					ng-disabled="validateSuccess" ng-click="ShowRule(temp);" title="OnClick the BRMS Rule will be previewed.">Show
 					Rule</button>
 				<button class="btn btn-success" herf="javascript:void(0)"
 					ng-disabled="savebutton" ng-disabled="temp.policy.readOnly"
-					ng-click="saveBrmsParamPolicy(temp);">Save</button>
-				<button type="button" class="btn btn-default" ng-click="refresh();">Close</button>
+					ng-click="saveBrmsParamPolicy(temp);" title="Save the Policy with validated data.">Save</button>
+				<button type="button" class="btn btn-default" ng-click="refresh();" title="Close the template.">Close</button>
 			</div>
 		</div>
 	</form>
-- 
cgit 1.2.3-korg