From c8b426318857bf6907ccdf799c7f4317399b6028 Mon Sep 17 00:00:00 2001 From: "Tej, Tarun" Date: Mon, 11 Sep 2017 15:30:24 -0400 Subject: sonar blocker/critical fixes Fixes for sonar critical and blocker issues Issue-Id: POLICY-113 Change-Id: I33bf28abfc52bf289401c58409beaac01b5c2fa6 Signed-off-by: Tej, Tarun --- .../main/java/org/onap/policy/xacml/api/pap/PAPPolicyEngine.java | 8 ++++---- .../src/main/java/org/onap/policy/xacml/std/pap/StdEngine.java | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'ONAP-XACML/src') diff --git a/ONAP-XACML/src/main/java/org/onap/policy/xacml/api/pap/PAPPolicyEngine.java b/ONAP-XACML/src/main/java/org/onap/policy/xacml/api/pap/PAPPolicyEngine.java index 4f1cfaf4b..805293ec4 100644 --- a/ONAP-XACML/src/main/java/org/onap/policy/xacml/api/pap/PAPPolicyEngine.java +++ b/ONAP-XACML/src/main/java/org/onap/policy/xacml/api/pap/PAPPolicyEngine.java @@ -30,11 +30,11 @@ public interface PAPPolicyEngine{ public OnapPDPGroup getDefaultGroup() throws PAPException; - public void SetDefaultGroup(OnapPDPGroup group) throws PAPException; + public void setDefaultGroup(OnapPDPGroup group) throws PAPException; - public void newPDP(String id, OnapPDPGroup group, String name, String description, int jmxport) throws PAPException, NullPointerException; + public void newPDP(String id, OnapPDPGroup group, String name, String description, int jmxport) throws PAPException; - public void newGroup(String name, String description) throws PAPException, NullPointerException; + public void newGroup(String name, String description) throws PAPException; public OnapPDPGroup getGroup(String id) throws PAPException; @@ -54,7 +54,7 @@ public interface PAPPolicyEngine{ public void updateGroup(OnapPDPGroup group) throws PAPException; - public void removeGroup(OnapPDPGroup group, OnapPDPGroup newGroup) throws PAPException, NullPointerException; + public void removeGroup(OnapPDPGroup group, OnapPDPGroup newGroup) throws PAPException; public void publishPolicy(String id, String name, boolean isRoot, InputStream policy, OnapPDPGroup group) throws PAPException; diff --git a/ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdEngine.java b/ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdEngine.java index 14d7c7f62..09c5a6aba 100644 --- a/ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdEngine.java +++ b/ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdEngine.java @@ -810,7 +810,7 @@ public class StdEngine extends StdPDPItemSetChangeNotifier implements PAPPolicyE } @Override - public void SetDefaultGroup(OnapPDPGroup group) throws PAPException { + public void setDefaultGroup(OnapPDPGroup group) throws PAPException { boolean changesMade = false; for (OnapPDPGroup aGroup : groups) { if (aGroup.getId().equals(group.getId())) { -- cgit