From d417cdaf516523c2d3bc998ca246d0cf6a2c55ec Mon Sep 17 00:00:00 2001 From: bobbymander Date: Wed, 28 Feb 2018 16:31:24 -0500 Subject: JUnit additions for PAP-REST,REST,XACML Issue-ID: POLICY-603 Change-Id: I78c5e302c474613cbb22a80e0d931b4f47dd3b63 Signed-off-by: bobbymander --- .../main/java/org/onap/policy/rest/XACMLRestProperties.java | 5 +++++ .../src/test/java/org/onap/policy/rest/XACMLRestTest.java | 13 ++++++++++++- .../policy/rest/adapter/ClosedLoopPolicyAdaptersTest.java | 12 ++++++++++++ 3 files changed, 29 insertions(+), 1 deletion(-) (limited to 'ONAP-REST/src') diff --git a/ONAP-REST/src/main/java/org/onap/policy/rest/XACMLRestProperties.java b/ONAP-REST/src/main/java/org/onap/policy/rest/XACMLRestProperties.java index 73cb0f07e..e52a4110e 100644 --- a/ONAP-REST/src/main/java/org/onap/policy/rest/XACMLRestProperties.java +++ b/ONAP-REST/src/main/java/org/onap/policy/rest/XACMLRestProperties.java @@ -452,4 +452,9 @@ public class XACMLRestProperties extends XACMLProperties { * */ public static final String PROP_PAP_INCOMINGNOTIFICATION_TRIES = "xacml.rest.pap.incomingnotification.tries"; + + // Static class, hide constructor + private XACMLRestProperties() { + super(); + } } diff --git a/ONAP-REST/src/test/java/org/onap/policy/rest/XACMLRestTest.java b/ONAP-REST/src/test/java/org/onap/policy/rest/XACMLRestTest.java index 419b14daa..9b4cc3ffb 100644 --- a/ONAP-REST/src/test/java/org/onap/policy/rest/XACMLRestTest.java +++ b/ONAP-REST/src/test/java/org/onap/policy/rest/XACMLRestTest.java @@ -20,9 +20,13 @@ package org.onap.policy.rest; +import static org.junit.Assert.assertTrue; import static org.junit.Assert.fail; import java.io.IOException; +import java.lang.reflect.Constructor; +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Modifier; import java.util.ArrayList; import java.util.Collections; import java.util.List; @@ -95,6 +99,13 @@ public class XACMLRestTest extends Mockito{ } catch (Exception e) { fail(); } - + } + + @Test + public void testConstructorIsPrivate() throws NoSuchMethodException, IllegalAccessException, InvocationTargetException, InstantiationException { + Constructor constructor = XACMLRestProperties.class.getDeclaredConstructor(); + assertTrue(Modifier.isPrivate(constructor.getModifiers())); + constructor.setAccessible(true); + constructor.newInstance(); } } \ No newline at end of file diff --git a/ONAP-REST/src/test/java/org/onap/policy/rest/adapter/ClosedLoopPolicyAdaptersTest.java b/ONAP-REST/src/test/java/org/onap/policy/rest/adapter/ClosedLoopPolicyAdaptersTest.java index a153efe25..320c30213 100644 --- a/ONAP-REST/src/test/java/org/onap/policy/rest/adapter/ClosedLoopPolicyAdaptersTest.java +++ b/ONAP-REST/src/test/java/org/onap/policy/rest/adapter/ClosedLoopPolicyAdaptersTest.java @@ -21,6 +21,10 @@ package org.onap.policy.rest.adapter; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertTrue; + +import java.lang.reflect.Constructor; +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Modifier; import java.util.ArrayList; import java.util.HashMap; import java.util.List; @@ -164,4 +168,12 @@ public class ClosedLoopPolicyAdaptersTest { assertEquals(ClosedLoopPolicyStatus.ACTIVE.toString(), "active"); assertEquals(ClosedLoopPolicyStatus.INACTIVE.toString(), "inactive"); } + + @Test + public void testConstructorIsPrivate() throws NoSuchMethodException, IllegalAccessException, InvocationTargetException, InstantiationException { + Constructor constructor = ClosedLoopPerformanceMetrics.class.getDeclaredConstructor(); + assertTrue(Modifier.isPrivate(constructor.getModifiers())); + constructor.setAccessible(true); + constructor.newInstance(); + } } -- cgit 1.2.3-korg