From da8ae32083194628e581c1ddeb5423fec4ff7dc0 Mon Sep 17 00:00:00 2001 From: eramkve Date: Thu, 29 Mar 2018 12:44:57 +0100 Subject: Remove checkstyle warnings in policy/engine Remove checkstyle warnings in policy/engine ONAP-PDP Change-Id: Ibbe2d8c549c1f0c3ac8456c4d2de4c7d349dd171 Issue-ID: POLICY-713 Signed-off-by: eramkve --- .../org/onap/policy/xacml/action/DummyRest.java | 18 +- .../onap/policy/xacml/action/FindActionTest.java | 403 ++++++++++----------- .../policy/xacml/pdp/ONAPPDPEngineFactoryTest.java | 86 ----- .../onap/policy/xacml/pdp/ONAPPDPEngineTest.java | 45 --- .../policy/xacml/pdp/OnapPdpEngineFactoryTest.java | 88 +++++ .../onap/policy/xacml/pdp/OnapPdpEngineTest.java | 47 +++ .../FunctionDefinitionCustomRegexpMatchTest.java | 51 +-- .../xacml/pdp/std/functions/PolicyListTest.java | 76 ++-- 8 files changed, 394 insertions(+), 420 deletions(-) delete mode 100644 ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/ONAPPDPEngineFactoryTest.java delete mode 100644 ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/ONAPPDPEngineTest.java create mode 100644 ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/OnapPdpEngineFactoryTest.java create mode 100644 ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/OnapPdpEngineTest.java (limited to 'ONAP-PDP/src/test') diff --git a/ONAP-PDP/src/test/java/org/onap/policy/xacml/action/DummyRest.java b/ONAP-PDP/src/test/java/org/onap/policy/xacml/action/DummyRest.java index 7a7fe548d..1a6866c91 100644 --- a/ONAP-PDP/src/test/java/org/onap/policy/xacml/action/DummyRest.java +++ b/ONAP-PDP/src/test/java/org/onap/policy/xacml/action/DummyRest.java @@ -7,9 +7,9 @@ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at - * + * * http://www.apache.org/licenses/LICENSE-2.0 - * + * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. @@ -25,13 +25,13 @@ import javax.ws.rs.Path; @Path("/") public class DummyRest { - - @GET - @Path("/foobar") - public String subscribe() { - return "{\"Foo\":\"bar\"}"; - } - + @GET + @Path("/foobar") + public String subscribe() { + + return "{\"Foo\":\"bar\"}"; + } + } diff --git a/ONAP-PDP/src/test/java/org/onap/policy/xacml/action/FindActionTest.java b/ONAP-PDP/src/test/java/org/onap/policy/xacml/action/FindActionTest.java index 2a36fa280..f8a5e4b4a 100644 --- a/ONAP-PDP/src/test/java/org/onap/policy/xacml/action/FindActionTest.java +++ b/ONAP-PDP/src/test/java/org/onap/policy/xacml/action/FindActionTest.java @@ -7,9 +7,9 @@ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at - * + * * http://www.apache.org/licenses/LICENSE-2.0 - * + * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. @@ -17,16 +17,12 @@ * limitations under the License. * ============LICENSE_END========================================================= */ + package org.onap.policy.xacml.action; import static org.junit.Assert.assertTrue; import static org.junit.Assert.fail; -import org.junit.AfterClass; -import org.junit.Before; -import org.junit.BeforeClass; -import org.junit.Test; -import org.onap.policy.xacml.custom.OnapFunctionDefinitionFactory; import com.att.research.xacml.api.Decision; import com.att.research.xacml.api.Request; import com.att.research.xacml.api.XACML3; @@ -45,229 +41,196 @@ import com.att.research.xacml.std.datatypes.DataTypes; import com.att.research.xacml.std.json.JSONRequest; import com.att.research.xacml.util.XACMLProperties; +import org.junit.AfterClass; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Test; import org.onap.policy.drools.http.server.HttpServletServer; import org.onap.policy.drools.utils.NetworkUtil; +import org.onap.policy.xacml.custom.OnapFunctionDefinitionFactory; public class FindActionTest { - - - String xPathExampleFromSpec = "{ " + - "\"Request\" : { " + - "\"Resource\" : { " + - "\"Attribute\": [ " + - "{ " + - "\"Id\" : \"urn:oasis:names:tc:xacml:3.0:content-selector\", " + - "\"DataType\" : \"xpathExpression\", " + - "\"Value\" : { " + - "\"XPathCategory\" : \"urn:oasis:names:tc:xacml:3.0:attribute-category:resource\", " + - "\"Namespaces\" : [{ " + - "\"Namespace\" : \"urn:oasis:names:tc:xacml:3.0:core:schema:wd-17\" " + - "}, " + - "{ " + - "\"Prefix\" : \"md\", " + - "\"Namespace\" : \"urn:example:med:schemas:record\" " + - "} " + - "], " + - "\"XPath\" : \"md:record/md:patient/md:patientDoB\" " + - "} " + - "} " + - "] " + - "} " + - "} " + - "} "; - - String jsonResponse; - Request request; - private static final int MOCK_SERVER_PORT = 6670; - - @BeforeClass - public static void setUpServer() { + + String xpathexamplefromspec = "{ " + "\"Request\" : { " + "\"Resource\" : { " + "\"Attribute\": [ " + "{ " + + "\"Id\" : \"urn:oasis:names:tc:xacml:3.0:content-selector\", " + "\"DataType\" : \"xpathExpression\", " + + "\"Value\" : { " + "\"XPathCategory\" : \"urn:oasis:names:tc:xacml:3.0:attribute-category:resource\", " + + "\"Namespaces\" : [{ " + "\"Namespace\" : \"urn:oasis:names:tc:xacml:3.0:core:schema:wd-17\" " + "}, " + + "{ " + "\"Prefix\" : \"md\", " + "\"Namespace\" : \"urn:example:med:schemas:record\" " + "} " + "], " + + "\"XPath\" : \"md:record/md:patient/md:patientDoB\" " + "} " + "} " + "] " + "} " + "} " + "} "; + + String jsonResponse; + Request request; + private static final int MOCK_SERVER_PORT = 6670; + + /** + * Setup server before test class. + */ + @BeforeClass + public static void setUpServer() { try { - final HttpServletServer testServer = HttpServletServer.factory.build("dmaapSim", - "localhost", MOCK_SERVER_PORT, "/", false, true); - testServer.addServletClass("/*", DummyRest.class.getName()); - testServer.waitedStart(2000); - if (!NetworkUtil.isTcpPortOpen("localhost", testServer.getPort(), 5, 10000L)) - throw new IllegalStateException("cannot connect to port " + testServer.getPort()); + final HttpServletServer testServer = + HttpServletServer.factory.build("dmaapSim", "localhost", MOCK_SERVER_PORT, "/", false, true); + testServer.addServletClass("/*", DummyRest.class.getName()); + testServer.waitedStart(2000); + if (!NetworkUtil.isTcpPortOpen("localhost", testServer.getPort(), 5, 10000L)) { + throw new IllegalStateException("cannot connect to port " + testServer.getPort()); + } } catch (final Exception e) { - fail(e.getMessage()); + fail(e.getMessage()); } - - } - + + } + @AfterClass public static void tearDownSimulator() { HttpServletServer.factory.destroy(); } - - @Before - public void setUp() throws Exception { - new OnapFunctionDefinitionFactory(); - request = JSONRequest.load(xPathExampleFromSpec); - - try { - XACMLProperties.reloadProperties(); - System.setProperty(XACMLProperties.XACML_PROPERTIES_NAME, "src/test/resources/xacml.pdp.properties"); - XACMLProperties.getProperties(); - - assertTrue(true); - } catch (Exception e) { - fail(); - - } - } - - - @Test - public final void testRun() { - FindAction action = new FindAction(); - // fully-loaded multiple response - StdMutableResponse response = new StdMutableResponse(); - // create a Status object - StdMutableStatus status = new StdMutableStatus(StdStatusCode.STATUS_CODE_MISSING_ATTRIBUTE); - status.setStatusMessage("some status message"); - StdMutableStatusDetail statusDetailIn = new StdMutableStatusDetail(); - StdMutableMissingAttributeDetail mad = new StdMutableMissingAttributeDetail(); - mad.addAttributeValue(new StdAttributeValue(DataTypes.DT_STRING.getId(), "PEPACTION")); - mad.addAttributeValue(new StdAttributeValue(DataTypes.DT_INTEGER.getId(), "PDPACTION")); - mad.setAttributeId(XACML3.ID_ACTION_PURPOSE); - mad.setCategory(XACML3.ID_ATTRIBUTE_CATEGORY_ACTION); - mad.setDataTypeId(XACML3.ID_DATATYPE_STRING); - mad.setIssuer("an Issuer"); - statusDetailIn.addMissingAttributeDetail(mad); - status.setStatusDetail(statusDetailIn); - // create a single result object - StdMutableResult result = new StdMutableResult(status); - // set the decision - result.setDecision(Decision.INDETERMINATE); - // put the Result into the Response - response.add(result); - // create a new Result with a different Decision - status = new StdMutableStatus(StdStatusCode.STATUS_CODE_OK); - result = new StdMutableResult(status); - result.setDecision(Decision.DENY); - - StdMutableObligation obligation = new StdMutableObligation(); - obligation.setId(XACML3.ID_ACTION_IMPLIED_ACTION); - obligation.addAttributeAssignment(new StdMutableAttributeAssignment( - XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, - XACML3.ID_SUBJECT, - "obligation-issuer1", - new StdAttributeValue(DataTypes.DT_STRING.getId(), "Test"))); - result.addObligation(obligation); - - StdMutableAdvice advice = new StdMutableAdvice(); - advice.setId(XACML3.ID_ACTION_IMPLIED_ACTION); - advice.addAttributeAssignment(new StdMutableAttributeAssignment( - XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, - XACML3.ID_SUBJECT, - "advice-issuer1", - new StdAttributeValue(DataTypes.DT_STRING.getId(), "Test"))); - response.add(result); - - // The logic below exercises the callRest and takeAction methods in FindAction - // GET request - status = new StdMutableStatus(StdStatusCode.STATUS_CODE_OK); - result = new StdMutableResult(status); - result.setDecision(Decision.PERMIT); - - obligation = new StdMutableObligation(); - obligation.setId(XACML3.ID_ACTION_IMPLIED_ACTION); - obligation.addAttributeAssignment(new StdMutableAttributeAssignment( - XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, - new IdentifierImpl("performer"), - "obligation-issuer", - new StdAttributeValue(DataTypes.DT_STRING.getId(), "PDPACTION"))); - - obligation.addAttributeAssignment(new StdMutableAttributeAssignment( - XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, - new IdentifierImpl("URL"), - "obligation-issuer", - new StdAttributeValue(DataTypes.DT_STRING.getId(), "http://localhost:" + MOCK_SERVER_PORT))); - obligation.addAttributeAssignment(new StdMutableAttributeAssignment( - XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, - new IdentifierImpl("method"), - "obligation-issuer", - new StdAttributeValue(DataTypes.DT_STRING.getId(), "GET"))); - obligation.addAttributeAssignment(new StdMutableAttributeAssignment( - XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, - new IdentifierImpl("headers"), - "obligation-issuer", - new StdAttributeValue(DataTypes.DT_STRING.getId(), "foobar"))); - - - result.addObligation(obligation); - response.add(result); - - // POST request - status = new StdMutableStatus(StdStatusCode.STATUS_CODE_OK); - result = new StdMutableResult(status); - result.setDecision(Decision.PERMIT); - - obligation = new StdMutableObligation(); - obligation.setId(XACML3.ID_ACTION_IMPLIED_ACTION); - obligation.addAttributeAssignment(new StdMutableAttributeAssignment( - XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, - new IdentifierImpl("performer"), - "obligation-issuer", - new StdAttributeValue(DataTypes.DT_STRING.getId(), "PDPACTION"))); - - obligation.addAttributeAssignment(new StdMutableAttributeAssignment( - XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, - new IdentifierImpl("URL"), - "obligation-issuer", - new StdAttributeValue(DataTypes.DT_STRING.getId(), "http://localhost:" + MOCK_SERVER_PORT))); - obligation.addAttributeAssignment(new StdMutableAttributeAssignment( - XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, - new IdentifierImpl("method"), - "obligation-issuer", - new StdAttributeValue(DataTypes.DT_STRING.getId(), "POST"))); - obligation.addAttributeAssignment(new StdMutableAttributeAssignment( - XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, - new IdentifierImpl("body"), - "obligation-issuer", - new StdAttributeValue(DataTypes.DT_STRING.getId(), "http://localhost:" + MOCK_SERVER_PORT + "/foobar"))); - - result.addObligation(obligation); - response.add(result); - - //PUT request - status = new StdMutableStatus(StdStatusCode.STATUS_CODE_OK); - result = new StdMutableResult(status); - result.setDecision(Decision.PERMIT); - - obligation = new StdMutableObligation(); - obligation.setId(XACML3.ID_ACTION_IMPLIED_ACTION); - obligation.addAttributeAssignment(new StdMutableAttributeAssignment( - XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, - new IdentifierImpl("performer"), - "obligation-issuer", - new StdAttributeValue(DataTypes.DT_STRING.getId(), "PDPACTION"))); - - obligation.addAttributeAssignment(new StdMutableAttributeAssignment( - XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, - new IdentifierImpl("URL"), - "obligation-issuer", - new StdAttributeValue(DataTypes.DT_STRING.getId(), "http://localhost:" + MOCK_SERVER_PORT))); - obligation.addAttributeAssignment(new StdMutableAttributeAssignment( - XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, - new IdentifierImpl("method"), - "obligation-issuer", - new StdAttributeValue(DataTypes.DT_STRING.getId(), "PUT"))); - obligation.addAttributeAssignment(new StdMutableAttributeAssignment( - XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, - new IdentifierImpl("body"), - "obligation-issuer", - new StdAttributeValue(DataTypes.DT_STRING.getId(), "http://localhost:" + MOCK_SERVER_PORT + "/foobar"))); - - result.addObligation(obligation); - response.add(result); - - try { - assertTrue(action.run(response, request) != null); - } catch (Exception e) { - fail("operation failed, e="+e); - } - } + + /** + * Setup before test case execution. + * + * @throws Exception if any error occurs + */ + @Before + public void setUp() throws Exception { + new OnapFunctionDefinitionFactory(); + request = JSONRequest.load(xpathexamplefromspec); + + try { + XACMLProperties.reloadProperties(); + System.setProperty(XACMLProperties.XACML_PROPERTIES_NAME, "src/test/resources/xacml.pdp.properties"); + XACMLProperties.getProperties(); + + assertTrue(true); + } catch (final Exception e) { + fail(); + + } + } + + + @Test + public final void testRun() { + final FindAction action = new FindAction(); + // fully-loaded multiple response + final StdMutableResponse response = new StdMutableResponse(); + // create a Status object + StdMutableStatus status = new StdMutableStatus(StdStatusCode.STATUS_CODE_MISSING_ATTRIBUTE); + status.setStatusMessage("some status message"); + final StdMutableStatusDetail statusDetailIn = new StdMutableStatusDetail(); + final StdMutableMissingAttributeDetail mad = new StdMutableMissingAttributeDetail(); + mad.addAttributeValue(new StdAttributeValue(DataTypes.DT_STRING.getId(), "PEPACTION")); + mad.addAttributeValue(new StdAttributeValue(DataTypes.DT_INTEGER.getId(), "PDPACTION")); + mad.setAttributeId(XACML3.ID_ACTION_PURPOSE); + mad.setCategory(XACML3.ID_ATTRIBUTE_CATEGORY_ACTION); + mad.setDataTypeId(XACML3.ID_DATATYPE_STRING); + mad.setIssuer("an Issuer"); + statusDetailIn.addMissingAttributeDetail(mad); + status.setStatusDetail(statusDetailIn); + // create a single result object + StdMutableResult result = new StdMutableResult(status); + // set the decision + result.setDecision(Decision.INDETERMINATE); + // put the Result into the Response + response.add(result); + // create a new Result with a different Decision + status = new StdMutableStatus(StdStatusCode.STATUS_CODE_OK); + result = new StdMutableResult(status); + result.setDecision(Decision.DENY); + + StdMutableObligation obligation = new StdMutableObligation(); + obligation.setId(XACML3.ID_ACTION_IMPLIED_ACTION); + obligation.addAttributeAssignment( + new StdMutableAttributeAssignment(XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, XACML3.ID_SUBJECT, + "obligation-issuer1", new StdAttributeValue(DataTypes.DT_STRING.getId(), "Test"))); + result.addObligation(obligation); + + final StdMutableAdvice advice = new StdMutableAdvice(); + advice.setId(XACML3.ID_ACTION_IMPLIED_ACTION); + advice.addAttributeAssignment( + new StdMutableAttributeAssignment(XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, XACML3.ID_SUBJECT, + "advice-issuer1", new StdAttributeValue(DataTypes.DT_STRING.getId(), "Test"))); + response.add(result); + + // The logic below exercises the callRest and takeAction methods in FindAction + // GET request + status = new StdMutableStatus(StdStatusCode.STATUS_CODE_OK); + result = new StdMutableResult(status); + result.setDecision(Decision.PERMIT); + + obligation = new StdMutableObligation(); + obligation.setId(XACML3.ID_ACTION_IMPLIED_ACTION); + obligation.addAttributeAssignment(new StdMutableAttributeAssignment(XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, + new IdentifierImpl("performer"), "obligation-issuer", + new StdAttributeValue(DataTypes.DT_STRING.getId(), "PDPACTION"))); + + obligation.addAttributeAssignment(new StdMutableAttributeAssignment(XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, + new IdentifierImpl("URL"), "obligation-issuer", + new StdAttributeValue(DataTypes.DT_STRING.getId(), "http://localhost:" + MOCK_SERVER_PORT))); + obligation.addAttributeAssignment( + new StdMutableAttributeAssignment(XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, new IdentifierImpl("method"), + "obligation-issuer", new StdAttributeValue(DataTypes.DT_STRING.getId(), "GET"))); + obligation.addAttributeAssignment( + new StdMutableAttributeAssignment(XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, new IdentifierImpl("headers"), + "obligation-issuer", new StdAttributeValue(DataTypes.DT_STRING.getId(), "foobar"))); + + + result.addObligation(obligation); + response.add(result); + + // POST request + status = new StdMutableStatus(StdStatusCode.STATUS_CODE_OK); + result = new StdMutableResult(status); + result.setDecision(Decision.PERMIT); + + obligation = new StdMutableObligation(); + obligation.setId(XACML3.ID_ACTION_IMPLIED_ACTION); + obligation.addAttributeAssignment(new StdMutableAttributeAssignment(XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, + new IdentifierImpl("performer"), "obligation-issuer", + new StdAttributeValue(DataTypes.DT_STRING.getId(), "PDPACTION"))); + + obligation.addAttributeAssignment(new StdMutableAttributeAssignment(XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, + new IdentifierImpl("URL"), "obligation-issuer", + new StdAttributeValue(DataTypes.DT_STRING.getId(), "http://localhost:" + MOCK_SERVER_PORT))); + obligation.addAttributeAssignment( + new StdMutableAttributeAssignment(XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, new IdentifierImpl("method"), + "obligation-issuer", new StdAttributeValue(DataTypes.DT_STRING.getId(), "POST"))); + obligation.addAttributeAssignment(new StdMutableAttributeAssignment(XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, + new IdentifierImpl("body"), "obligation-issuer", new StdAttributeValue( + DataTypes.DT_STRING.getId(), "http://localhost:" + MOCK_SERVER_PORT + "/foobar"))); + + result.addObligation(obligation); + response.add(result); + + // PUT request + status = new StdMutableStatus(StdStatusCode.STATUS_CODE_OK); + result = new StdMutableResult(status); + result.setDecision(Decision.PERMIT); + + obligation = new StdMutableObligation(); + obligation.setId(XACML3.ID_ACTION_IMPLIED_ACTION); + obligation.addAttributeAssignment(new StdMutableAttributeAssignment(XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, + new IdentifierImpl("performer"), "obligation-issuer", + new StdAttributeValue(DataTypes.DT_STRING.getId(), "PDPACTION"))); + + obligation.addAttributeAssignment(new StdMutableAttributeAssignment(XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, + new IdentifierImpl("URL"), "obligation-issuer", + new StdAttributeValue(DataTypes.DT_STRING.getId(), "http://localhost:" + MOCK_SERVER_PORT))); + obligation.addAttributeAssignment( + new StdMutableAttributeAssignment(XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, new IdentifierImpl("method"), + "obligation-issuer", new StdAttributeValue(DataTypes.DT_STRING.getId(), "PUT"))); + obligation.addAttributeAssignment(new StdMutableAttributeAssignment(XACML3.ID_ATTRIBUTE_CATEGORY_RESOURCE, + new IdentifierImpl("body"), "obligation-issuer", new StdAttributeValue( + DataTypes.DT_STRING.getId(), "http://localhost:" + MOCK_SERVER_PORT + "/foobar"))); + + result.addObligation(obligation); + response.add(result); + + try { + assertTrue(action.run(response, request) != null); + } catch (final Exception e) { + fail("operation failed, e=" + e); + } + } } diff --git a/ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/ONAPPDPEngineFactoryTest.java b/ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/ONAPPDPEngineFactoryTest.java deleted file mode 100644 index 1bde7dd84..000000000 --- a/ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/ONAPPDPEngineFactoryTest.java +++ /dev/null @@ -1,86 +0,0 @@ -/*- - * ============LICENSE_START======================================================= - * ONAP-PDP - * ================================================================================ - * Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved. - * ================================================================================ - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - * ============LICENSE_END========================================================= - */ -package org.onap.policy.xacml.pdp; - -import static org.junit.Assert.assertTrue; -import static org.junit.Assert.fail; -import java.util.Properties; -import org.junit.Test; -import org.junit.runner.RunWith; -import org.mockito.Mockito; -import org.powermock.api.mockito.PowerMockito; -import org.powermock.core.classloader.annotations.PrepareForTest; -import org.powermock.modules.junit4.PowerMockRunner; -import com.att.research.xacml.util.FactoryException; -import com.att.research.xacml.util.FactoryFinder; -import com.att.research.xacmlatt.pdp.eval.EvaluationContextFactory; - -@RunWith(PowerMockRunner.class) -public class ONAPPDPEngineFactoryTest { - @Test - public final void testNewEngine() { - ONAPPDPEngineFactory pdpEngine = new ONAPPDPEngineFactory(); - try { - assertTrue(pdpEngine.newEngine() != null); - } catch (Exception e) { - fail("operation failed, e=" + e); - } - } - - @Test - public final void testNewEngineProperties() { - ONAPPDPEngineFactory pdpEngine = new ONAPPDPEngineFactory(); - Properties properties = new Properties(); - try { - assertTrue(pdpEngine.newEngine(properties) != null); - } catch (Exception e) { - fail("operation failed, e=" + e); - } - } - - @PrepareForTest({EvaluationContextFactory.class, FactoryFinder.class}) - @Test(expected = FactoryException.class) - public void negTestEngine() throws FactoryException { - // Setup test data - PowerMockito.mockStatic(FactoryFinder.class); - PowerMockito.when(FactoryFinder.find(Mockito.any(), Mockito.any(), Mockito.any())) - .thenReturn(null); - - // Negative test factory - ONAPPDPEngineFactory factory = new ONAPPDPEngineFactory(); - factory.newEngine(); - fail("Expecting an exception."); - } - - @PrepareForTest({EvaluationContextFactory.class, FactoryFinder.class}) - @Test(expected = FactoryException.class) - public void negTestEngine2() throws FactoryException { - // Setup test data - PowerMockito.mockStatic(FactoryFinder.class); - PowerMockito.when(FactoryFinder.find(Mockito.any(), Mockito.any(), Mockito.any())) - .thenReturn(null); - - // Negative test factory - ONAPPDPEngineFactory factory = new ONAPPDPEngineFactory(); - Properties properties = new Properties(); - factory.newEngine(properties); - fail("Expecting an exception."); - } -} diff --git a/ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/ONAPPDPEngineTest.java b/ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/ONAPPDPEngineTest.java deleted file mode 100644 index 6eb6e4cfc..000000000 --- a/ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/ONAPPDPEngineTest.java +++ /dev/null @@ -1,45 +0,0 @@ -/*- - * ============LICENSE_START======================================================= - * ONAP-PDP - * ================================================================================ - * Copyright (C) 2018 AT&T Intellectual Property. All rights reserved. - * ================================================================================ - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - * ============LICENSE_END========================================================= - */ - -package org.onap.policy.xacml.pdp; - -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertNotNull; -import org.junit.Test; -import org.mockito.Mockito; -import com.att.research.xacml.api.Request; -import com.att.research.xacml.api.Response; -import com.att.research.xacml.api.pdp.PDPException; -import com.att.research.xacml.api.pdp.ScopeResolver; -import com.att.research.xacmlatt.pdp.eval.EvaluationContextFactory; - -public class ONAPPDPEngineTest { - @Test - public void testEngine() throws PDPException { - EvaluationContextFactory factory = Mockito.mock(EvaluationContextFactory.class); - ScopeResolver resolver = Mockito.mock(ScopeResolver.class); - ONAPPDPEngine engine = new ONAPPDPEngine(factory, resolver); - assertNotNull(engine); - - Request pepRequest = Mockito.mock(Request.class); - Response response = engine.decide(pepRequest); - assertEquals(1, response.getResults().size()); - } -} diff --git a/ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/OnapPdpEngineFactoryTest.java b/ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/OnapPdpEngineFactoryTest.java new file mode 100644 index 000000000..d3ee544a5 --- /dev/null +++ b/ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/OnapPdpEngineFactoryTest.java @@ -0,0 +1,88 @@ +/*- + * ============LICENSE_START======================================================= + * ONAP-PDP + * ================================================================================ + * Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.xacml.pdp; + +import static org.junit.Assert.assertTrue; +import static org.junit.Assert.fail; + +import com.att.research.xacml.util.FactoryException; +import com.att.research.xacml.util.FactoryFinder; +import com.att.research.xacmlatt.pdp.eval.EvaluationContextFactory; + +import java.util.Properties; + +import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.Mockito; +import org.powermock.api.mockito.PowerMockito; +import org.powermock.core.classloader.annotations.PrepareForTest; +import org.powermock.modules.junit4.PowerMockRunner; + +@RunWith(PowerMockRunner.class) +public class OnapPdpEngineFactoryTest { + @Test + public final void testNewEngine() { + final OnapPdpEngineFactory pdpEngine = new OnapPdpEngineFactory(); + try { + assertTrue(pdpEngine.newEngine() != null); + } catch (final Exception e) { + fail("operation failed, e=" + e); + } + } + + @Test + public final void testNewEngineProperties() { + final OnapPdpEngineFactory pdpEngine = new OnapPdpEngineFactory(); + final Properties properties = new Properties(); + try { + assertTrue(pdpEngine.newEngine(properties) != null); + } catch (final Exception e) { + fail("operation failed, e=" + e); + } + } + + @PrepareForTest({ EvaluationContextFactory.class, FactoryFinder.class }) + @Test(expected = FactoryException.class) + public void negTestEngine() throws FactoryException { + // Setup test data + PowerMockito.mockStatic(FactoryFinder.class); + PowerMockito.when(FactoryFinder.find(Mockito.any(), Mockito.any(), Mockito.any())).thenReturn(null); + + // Negative test factory + final OnapPdpEngineFactory factory = new OnapPdpEngineFactory(); + factory.newEngine(); + fail("Expecting an exception."); + } + + @PrepareForTest({ EvaluationContextFactory.class, FactoryFinder.class }) + @Test(expected = FactoryException.class) + public void negTestEngine2() throws FactoryException { + // Setup test data + PowerMockito.mockStatic(FactoryFinder.class); + PowerMockito.when(FactoryFinder.find(Mockito.any(), Mockito.any(), Mockito.any())).thenReturn(null); + + // Negative test factory + final OnapPdpEngineFactory factory = new OnapPdpEngineFactory(); + final Properties properties = new Properties(); + factory.newEngine(properties); + fail("Expecting an exception."); + } +} diff --git a/ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/OnapPdpEngineTest.java b/ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/OnapPdpEngineTest.java new file mode 100644 index 000000000..08a84477e --- /dev/null +++ b/ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/OnapPdpEngineTest.java @@ -0,0 +1,47 @@ +/*- + * ============LICENSE_START======================================================= + * ONAP-PDP + * ================================================================================ + * Copyright (C) 2018 AT&T Intellectual Property. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.xacml.pdp; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNotNull; + +import com.att.research.xacml.api.Request; +import com.att.research.xacml.api.Response; +import com.att.research.xacml.api.pdp.PDPException; +import com.att.research.xacml.api.pdp.ScopeResolver; +import com.att.research.xacmlatt.pdp.eval.EvaluationContextFactory; + +import org.junit.Test; +import org.mockito.Mockito; + +public class OnapPdpEngineTest { + @Test + public void testEngine() throws PDPException { + final EvaluationContextFactory factory = Mockito.mock(EvaluationContextFactory.class); + final ScopeResolver resolver = Mockito.mock(ScopeResolver.class); + final OnapPdpEngine engine = new OnapPdpEngine(factory, resolver); + assertNotNull(engine); + + final Request pepRequest = Mockito.mock(Request.class); + final Response response = engine.decide(pepRequest); + assertEquals(1, response.getResults().size()); + } +} diff --git a/ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/std/functions/FunctionDefinitionCustomRegexpMatchTest.java b/ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/std/functions/FunctionDefinitionCustomRegexpMatchTest.java index 5100dc7c5..da1759a22 100644 --- a/ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/std/functions/FunctionDefinitionCustomRegexpMatchTest.java +++ b/ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/std/functions/FunctionDefinitionCustomRegexpMatchTest.java @@ -7,9 +7,9 @@ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at - * + * * http://www.apache.org/licenses/LICENSE-2.0 - * + * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. @@ -17,12 +17,11 @@ * limitations under the License. * ============LICENSE_END========================================================= */ + package org.onap.policy.xacml.pdp.std.functions; import static org.junit.Assert.assertEquals; -import java.util.ArrayList; -import java.util.List; -import org.junit.Test; + import com.att.research.xacml.api.Identifier; import com.att.research.xacml.api.XACML; import com.att.research.xacml.std.IdentifierImpl; @@ -32,23 +31,29 @@ import com.att.research.xacmlatt.pdp.policy.ExpressionResult; import com.att.research.xacmlatt.pdp.policy.FunctionArgument; import com.att.research.xacmlatt.pdp.policy.FunctionArgumentAttributeValue; +import java.util.ArrayList; +import java.util.List; + +import org.junit.Test; + public class FunctionDefinitionCustomRegexpMatchTest { - @Test - public final void testRegexp() { - // Setup - String testVal = "testVal"; - String testId = "function:testId"; - IdentifierImpl testFnId = new IdentifierImpl(testId); - Identifier identifier = XACML.ID_DATATYPE_STRING; - StdAttributeValue attValue = new StdAttributeValue(identifier, testVal); - FunctionArgument fArg = new FunctionArgumentAttributeValue(attValue); - List listFA = new ArrayList(); - listFA.add(fArg); - listFA.add(fArg); - - // Try a match - FunctionDefinitionCustomRegexpMatch regexpMatch = new FunctionDefinitionCustomRegexpMatch(testFnId, DataTypes.DT_STRING); - ExpressionResult result = regexpMatch.evaluate(null, listFA); - assertEquals(result.getStatus().isOk(), true); - } + @Test + public final void testRegexp() { + // Setup + final String testVal = "testVal"; + final String testId = "function:testId"; + final IdentifierImpl testFnId = new IdentifierImpl(testId); + final Identifier identifier = XACML.ID_DATATYPE_STRING; + final StdAttributeValue attValue = new StdAttributeValue(identifier, testVal); + final FunctionArgument fArg = new FunctionArgumentAttributeValue(attValue); + final List listFa = new ArrayList(); + listFa.add(fArg); + listFa.add(fArg); + + // Try a match + final FunctionDefinitionCustomRegexpMatch regexpMatch = + new FunctionDefinitionCustomRegexpMatch(testFnId, DataTypes.DT_STRING); + final ExpressionResult result = regexpMatch.evaluate(null, listFa); + assertEquals(result.getStatus().isOk(), true); + } } diff --git a/ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/std/functions/PolicyListTest.java b/ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/std/functions/PolicyListTest.java index 17f509da4..ccab70418 100644 --- a/ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/std/functions/PolicyListTest.java +++ b/ONAP-PDP/src/test/java/org/onap/policy/xacml/pdp/std/functions/PolicyListTest.java @@ -2,14 +2,14 @@ * ============LICENSE_START======================================================= * ONAP-PDP * ================================================================================ - * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved. + * Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at - * + * * http://www.apache.org/licenses/LICENSE-2.0 - * + * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. @@ -17,47 +17,49 @@ * limitations under the License. * ============LICENSE_END========================================================= */ + package org.onap.policy.xacml.pdp.std.functions; -import static org.junit.Assert.*; +import static org.junit.Assert.assertTrue; +import static org.junit.Assert.fail; import org.junit.Before; import org.junit.Test; public class PolicyListTest { - @Before - public void setUp() throws Exception { - PolicyList.addPolicyID("Test"); - } - - @Test - public final void testGetpolicyList() { - try{ - assertTrue(PolicyList.getpolicyList().size() ==1); - }catch(Exception e){ - fail("operation failed, e="+e); - } - } - - @Test - public final void testAddPolicyID() { - try{ - PolicyList.addPolicyID("Test"); - assertTrue(PolicyList.getpolicyList().size() == 1); - }catch(Exception e){ - fail("operation failed, e="+e); - } - } - - @Test - public final void testClearPolicyList() { - try{ - PolicyList.clearPolicyList(); - assertTrue(PolicyList.getpolicyList().size() == 0); - }catch(Exception e){ - fail("operation failed, e="+e); - } - } + @Before + public void setUp() throws Exception { + PolicyList.addPolicyId("Test"); + } + + @Test + public final void testGetpolicyList() { + try { + assertTrue(PolicyList.getpolicyList().size() == 1); + } catch (final Exception e) { + fail("operation failed, e=" + e); + } + } + + @Test + public final void testAddPolicyId() { + try { + PolicyList.addPolicyId("Test"); + assertTrue(PolicyList.getpolicyList().size() == 1); + } catch (final Exception e) { + fail("operation failed, e=" + e); + } + } + + @Test + public final void testClearPolicyList() { + try { + PolicyList.clearPolicyList(); + assertTrue(PolicyList.getpolicyList().size() == 0); + } catch (final Exception e) { + fail("operation failed, e=" + e); + } + } } -- cgit 1.2.3-korg