From be10935d9bd9f08f17a9d23c46865f54b914cf21 Mon Sep 17 00:00:00 2001 From: guangxingwang Date: Wed, 21 Feb 2018 14:09:04 -0600 Subject: Fix Fortify Path Manipulation Issue Fix Fortify path manipulation issue by adding a validation on dictionary name. Issue-ID: POLICY-541 Change-Id: I87492b0d80bf96bebfc029d7d164cdd20ca5ef0f Signed-off-by: guangxingwang --- .../controller/DictionaryImportControllerTest.java | 52 ++++++++++++++++++++++ 1 file changed, 52 insertions(+) create mode 100644 ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/DictionaryImportControllerTest.java (limited to 'ONAP-PAP-REST/src/test/java') diff --git a/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/DictionaryImportControllerTest.java b/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/DictionaryImportControllerTest.java new file mode 100644 index 000000000..e8d602ce5 --- /dev/null +++ b/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/DictionaryImportControllerTest.java @@ -0,0 +1,52 @@ +/*- + * ============LICENSE_START======================================================= + * ONAP-PAP-REST + * ================================================================================ + * Copyright (C) 2018 AT&T Intellectual Property. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ +package org.onap.policy.pap.xacml.rest.controller; + +import static org.junit.Assert.assertTrue; +import org.onap.policy.pap.xacml.rest.controller.DictionaryImportController; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; +import org.onap.policy.common.logging.flexlogger.FlexLogger; +import org.onap.policy.common.logging.flexlogger.Logger; + +public class DictionaryImportControllerTest { + + private static Logger logger = FlexLogger.getLogger(DictionaryImportController.class); + + @Before + public void setUp() throws Exception { + logger.info("setUp: Entering"); + } + + @Test + public void testIsValidDictionaryName(){ + DictionaryImportController cotroller = new DictionaryImportController(); + //test invalid name + assertTrue(!cotroller.isValidDictionaryName("wrong-name")); + //test valid name + assertTrue(cotroller.isValidDictionaryName("ActionList")); + } + + @After + public void destroy(){ + + } +} -- cgit 1.2.3-korg