From 763a2328d939c1d400fd1c9595bec5717645914b Mon Sep 17 00:00:00 2001
From: krishnajinka <krishna.jinka@gmail.com>
Date: Sun, 5 Aug 2018 18:27:28 +0900
Subject: Fix basic Java issue in pdp drools sys comp

Modify pdp drools system component files to fix basic
Java warnings from analysis tools. Possibly flagged by
Sonar tool as well.Rework based on comments

Issue-ID: POLICY-1017
Change-Id: I1f2a5d727d2673cade5f69a07f708e16754c78e4
Signed-off-by: krisjinka <kris.jinka@samsung.com>
---
 .../onap/policy/drools/system/PolicyController.java | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

(limited to 'policy-management/src/main/java/org/onap/policy/drools/system/PolicyController.java')

diff --git a/policy-management/src/main/java/org/onap/policy/drools/system/PolicyController.java b/policy-management/src/main/java/org/onap/policy/drools/system/PolicyController.java
index 9e01634b..dcd4d11a 100644
--- a/policy-management/src/main/java/org/onap/policy/drools/system/PolicyController.java
+++ b/policy-management/src/main/java/org/onap/policy/drools/system/PolicyController.java
@@ -43,27 +43,27 @@ public interface PolicyController extends Startable, Lockable {
     /**
      * Factory that tracks and manages Policy Controllers
      */
-    public static PolicyControllerFactory factory = new IndexedPolicyControllerFactory();
+    static PolicyControllerFactory factory = new IndexedPolicyControllerFactory();
 
     /**
      * name of this Policy Controller
      */
-    public String getName();
+    String getName();
 
     /**
      * Get the topic readers of interest for this controller
      */
-    public List<? extends TopicSource> getTopicSources();
+    List<? extends TopicSource> getTopicSources();
 
     /**
      * Get the topic readers of interest for this controller
      */
-    public List<? extends TopicSink> getTopicSinks();
+    List<? extends TopicSink> getTopicSinks();
 
     /**
      * Get the Drools Controller
      */
-    public DroolsController getDrools();
+    DroolsController getDrools();
 
     /**
      * update maven configuration
@@ -71,17 +71,18 @@ public interface PolicyController extends Startable, Lockable {
      * @param newDroolsConfiguration new drools configuration
      * @return true if the update was successful, false otherwise
      */
-    public boolean updateDrools(DroolsConfiguration newDroolsConfiguration);
+    boolean updateDrools(DroolsConfiguration newDroolsConfiguration);
 
     /**
      * Get the Properties
      */
-    public Properties getProperties();
+    Properties getProperties();
 
     /**
      * Attempts delivering of an String over communication infrastructure "busType"
      * 
-     * @param eventBus Communication infrastructure identifier
+     * @param event Communication infrastructure identifier
+     * @param busType
      * @param topic topic
      * @param event the event object to send
      * 
@@ -92,13 +93,13 @@ public interface PolicyController extends Startable, Lockable {
      * @throws UnsupportedOperationException when the engine cannot deliver due to the functionality
      *         missing (ie. communication infrastructure not supported.
      */
-    public boolean deliver(CommInfrastructure busType, String topic, Object event);
+    boolean deliver(CommInfrastructure busType, String topic, Object event);
 
     /**
      * halts and permanently releases all resources
      * 
      * @throws IllegalStateException
      */
-    public void halt();
+    void halt();
 
 }
-- 
cgit 1.2.3-korg