From dbdef1e3e3803b5848a1fad746c652f9359d4313 Mon Sep 17 00:00:00 2001 From: "Magnusen, Drew (dm741q)" Date: Tue, 17 Apr 2018 11:59:43 -0500 Subject: Sonar cleanup More sonar cleanup. Resolved some of the simpler issues. Issue-ID: POLICY-728 Change-Id: If9c4718f10c6d3524239d2a05c09badb791ef2f0 Signed-off-by: Magnusen, Drew (dm741q) --- .../event/comm/bus/internal/SingleThreadedDmaapTopicSource.java | 2 +- .../java/org/onap/policy/drools/http/client/HttpClientFactory.java | 4 ++-- .../onap/policy/drools/http/server/HttpServletServerFactory.java | 4 ++-- .../org/onap/policy/drools/http/server/test/HttpClientTest.java | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) (limited to 'policy-endpoints/src') diff --git a/policy-endpoints/src/main/java/org/onap/policy/drools/event/comm/bus/internal/SingleThreadedDmaapTopicSource.java b/policy-endpoints/src/main/java/org/onap/policy/drools/event/comm/bus/internal/SingleThreadedDmaapTopicSource.java index 88d67fd2..b0c456da 100644 --- a/policy-endpoints/src/main/java/org/onap/policy/drools/event/comm/bus/internal/SingleThreadedDmaapTopicSource.java +++ b/policy-endpoints/src/main/java/org/onap/policy/drools/event/comm/bus/internal/SingleThreadedDmaapTopicSource.java @@ -38,7 +38,7 @@ public class SingleThreadedDmaapTopicSource extends SingleThreadedBusTopicSource private static Logger logger = LoggerFactory.getLogger(SingleThreadedDmaapTopicSource.class); - protected boolean allowSelfSignedCerts; + protected final String userName; protected final String password; diff --git a/policy-endpoints/src/main/java/org/onap/policy/drools/http/client/HttpClientFactory.java b/policy-endpoints/src/main/java/org/onap/policy/drools/http/client/HttpClientFactory.java index 06aa4630..1094a2fb 100644 --- a/policy-endpoints/src/main/java/org/onap/policy/drools/http/client/HttpClientFactory.java +++ b/policy-endpoints/src/main/java/org/onap/policy/drools/http/client/HttpClientFactory.java @@ -50,7 +50,7 @@ public interface HttpClientFactory { /** * build http client from properties */ - public ArrayList build(Properties properties) + public List build(Properties properties) throws KeyManagementException, NoSuchAlgorithmException; /** @@ -106,7 +106,7 @@ class IndexedHttpClientFactory implements HttpClientFactory { } @Override - public synchronized ArrayList build(Properties properties) + public synchronized List build(Properties properties) throws KeyManagementException, NoSuchAlgorithmException { ArrayList clientList = new ArrayList<>(); diff --git a/policy-endpoints/src/main/java/org/onap/policy/drools/http/server/HttpServletServerFactory.java b/policy-endpoints/src/main/java/org/onap/policy/drools/http/server/HttpServletServerFactory.java index b6366d00..8c35602b 100644 --- a/policy-endpoints/src/main/java/org/onap/policy/drools/http/server/HttpServletServerFactory.java +++ b/policy-endpoints/src/main/java/org/onap/policy/drools/http/server/HttpServletServerFactory.java @@ -58,7 +58,7 @@ public interface HttpServletServerFactory { * @return list of http servers * @throws IllegalArgumentException when invalid parameters are provided */ - public ArrayList build(Properties properties) throws IllegalArgumentException; + public List build(Properties properties) throws IllegalArgumentException; /** * gets a server based on the port @@ -119,7 +119,7 @@ class IndexedHttpServletServerFactory implements HttpServletServerFactory { } @Override - public synchronized ArrayList build(Properties properties) + public synchronized List build(Properties properties) throws IllegalArgumentException { ArrayList serviceList = new ArrayList<>(); diff --git a/policy-endpoints/src/test/java/org/onap/policy/drools/http/server/test/HttpClientTest.java b/policy-endpoints/src/test/java/org/onap/policy/drools/http/server/test/HttpClientTest.java index dd9a7c2b..6a84d142 100644 --- a/policy-endpoints/src/test/java/org/onap/policy/drools/http/server/test/HttpClientTest.java +++ b/policy-endpoints/src/test/java/org/onap/policy/drools/http/server/test/HttpClientTest.java @@ -23,7 +23,7 @@ package org.onap.policy.drools.http.server.test; import static org.junit.Assert.assertTrue; import java.io.IOException; -import java.util.ArrayList; +import java.util.List; import java.util.Properties; import javax.ws.rs.core.Response; @@ -180,10 +180,10 @@ public class HttpClientTest { httpProperties.setProperty(PolicyProperties.PROPERTY_HTTP_CLIENT_SERVICES + "." + "PDP" + PolicyProperties.PROPERTY_MANAGED_SUFFIX, "true"); - final ArrayList servers = HttpServletServer.factory.build(httpProperties); + final List servers = HttpServletServer.factory.build(httpProperties); assertTrue(servers.size() == 2); - final ArrayList clients = HttpClient.factory.build(httpProperties); + final List clients = HttpClient.factory.build(httpProperties); assertTrue(clients.size() == 2); for (final HttpServletServer server : servers) { -- cgit 1.2.3-korg