From 15014b8ca386a8bfd5c26435f45de94ca06e95e8 Mon Sep 17 00:00:00 2001 From: Jim Hahn Date: Mon, 6 Apr 2020 15:33:23 -0400 Subject: Address sonar issues in drools-pdp Addressed the following sonar issues: - add "final" to public static fields - commented code; some were bogus - just updated the comments so sonar is happy - use "{}" instead of string concatenation - junit should assert something - when using logger, invoke compute-intensive tasks conditionally - use superclass name instead of subclass name to access static fields - don't always return the same value - remove "transient" from fields of classes that aren't Serializable - don't nest try/catch blocks - use appropriate class name in Logger.getLogger() - use Predicate instead of Function - remove unused parameters from private methods - either log or throw - remove duplicate methods - use remove() TLS instead of set(null) - null check is implicit in instanceof check - do something with return value - don't use volatile - don't return "null" list; used Optional instead - add no-arg constructor to non-Serializable superclass - add callSuper=true for EqualsAndHashCode - don't declare "throws XXX" where XXX is a subclass of RuntimeException - remove serialVersionUID field if the class isn't Serializable Also addressed some eclipse warnings: - unused fields - suppress generic typic cast warnings Issue-ID: POLICY-2305 Change-Id: I906d5bf71c1f86531423e23b3667a585cdba45e1 Signed-off-by: Jim Hahn --- .../policy/drools/domain/models/artifact/NativeArtifactPolicy.java | 2 ++ .../policy/drools/domain/models/controller/ControllerPolicy.java | 2 ++ .../drools/domain/models/controller/ControllerSinkTopic.java | 2 ++ .../drools/domain/models/controller/ControllerSourceTopic.java | 2 ++ .../policy/drools/domain/models/controller/ControllerTopic.java | 2 ++ .../org/onap/policy/drools/domain/models/legacy/LegacyPolicy.java | 2 ++ .../policy/drools/domain/models/operational/OperationalPolicy.java | 2 ++ .../drools/domain/models/operational/OperationalProperties.java | 2 ++ .../org/onap/policy/drools/domain/models/DroolsPolicyTest.java | 2 ++ .../onap/policy/drools/domain/models/legacy/LegacyPolicyTest.java | 2 +- .../drools/domain/models/operational/OperationalPolicyTest.java | 7 ------- 11 files changed, 19 insertions(+), 8 deletions(-) (limited to 'policy-domains/src') diff --git a/policy-domains/src/main/java/org/onap/policy/drools/domain/models/artifact/NativeArtifactPolicy.java b/policy-domains/src/main/java/org/onap/policy/drools/domain/models/artifact/NativeArtifactPolicy.java index 0f53b532..9fa8230d 100644 --- a/policy-domains/src/main/java/org/onap/policy/drools/domain/models/artifact/NativeArtifactPolicy.java +++ b/policy-domains/src/main/java/org/onap/policy/drools/domain/models/artifact/NativeArtifactPolicy.java @@ -22,6 +22,7 @@ package org.onap.policy.drools.domain.models.artifact; import java.io.Serializable; import lombok.Data; +import lombok.EqualsAndHashCode; import lombok.experimental.SuperBuilder; import org.onap.policy.drools.domain.models.DroolsPolicy; @@ -31,6 +32,7 @@ import org.onap.policy.drools.domain.models.DroolsPolicy; @Data @SuperBuilder +@EqualsAndHashCode(callSuper = true) public class NativeArtifactPolicy extends DroolsPolicy implements Serializable { private static final long serialVersionUID = -8171337852833516581L; diff --git a/policy-domains/src/main/java/org/onap/policy/drools/domain/models/controller/ControllerPolicy.java b/policy-domains/src/main/java/org/onap/policy/drools/domain/models/controller/ControllerPolicy.java index 09236c84..92372765 100644 --- a/policy-domains/src/main/java/org/onap/policy/drools/domain/models/controller/ControllerPolicy.java +++ b/policy-domains/src/main/java/org/onap/policy/drools/domain/models/controller/ControllerPolicy.java @@ -22,6 +22,7 @@ package org.onap.policy.drools.domain.models.controller; import java.io.Serializable; import lombok.Data; +import lombok.EqualsAndHashCode; import lombok.experimental.SuperBuilder; import org.onap.policy.drools.domain.models.DroolsPolicy; @@ -31,6 +32,7 @@ import org.onap.policy.drools.domain.models.DroolsPolicy; @Data @SuperBuilder +@EqualsAndHashCode(callSuper = true) public class ControllerPolicy extends DroolsPolicy implements Serializable { private static final long serialVersionUID = -8171337852833516581L; diff --git a/policy-domains/src/main/java/org/onap/policy/drools/domain/models/controller/ControllerSinkTopic.java b/policy-domains/src/main/java/org/onap/policy/drools/domain/models/controller/ControllerSinkTopic.java index 87af6c36..c4772f3b 100644 --- a/policy-domains/src/main/java/org/onap/policy/drools/domain/models/controller/ControllerSinkTopic.java +++ b/policy-domains/src/main/java/org/onap/policy/drools/domain/models/controller/ControllerSinkTopic.java @@ -22,6 +22,7 @@ package org.onap.policy.drools.domain.models.controller; import java.io.Serializable; import lombok.Data; +import lombok.EqualsAndHashCode; import lombok.experimental.SuperBuilder; @@ -31,6 +32,7 @@ import lombok.experimental.SuperBuilder; @Data @SuperBuilder +@EqualsAndHashCode(callSuper = true) public class ControllerSinkTopic extends ControllerTopic implements Serializable { private static final long serialVersionUID = 8770353732981476267L; } diff --git a/policy-domains/src/main/java/org/onap/policy/drools/domain/models/controller/ControllerSourceTopic.java b/policy-domains/src/main/java/org/onap/policy/drools/domain/models/controller/ControllerSourceTopic.java index e41f4dc3..97a21e6c 100644 --- a/policy-domains/src/main/java/org/onap/policy/drools/domain/models/controller/ControllerSourceTopic.java +++ b/policy-domains/src/main/java/org/onap/policy/drools/domain/models/controller/ControllerSourceTopic.java @@ -22,6 +22,7 @@ package org.onap.policy.drools.domain.models.controller; import java.io.Serializable; import lombok.Data; +import lombok.EqualsAndHashCode; import lombok.experimental.SuperBuilder; @@ -31,6 +32,7 @@ import lombok.experimental.SuperBuilder; @Data @SuperBuilder +@EqualsAndHashCode(callSuper = true) public class ControllerSourceTopic extends ControllerTopic implements Serializable { private static final long serialVersionUID = -1732598566914643612L; } diff --git a/policy-domains/src/main/java/org/onap/policy/drools/domain/models/controller/ControllerTopic.java b/policy-domains/src/main/java/org/onap/policy/drools/domain/models/controller/ControllerTopic.java index 2954350d..fd78da76 100644 --- a/policy-domains/src/main/java/org/onap/policy/drools/domain/models/controller/ControllerTopic.java +++ b/policy-domains/src/main/java/org/onap/policy/drools/domain/models/controller/ControllerTopic.java @@ -22,6 +22,7 @@ package org.onap.policy.drools.domain.models.controller; import java.util.List; import lombok.Data; +import lombok.NoArgsConstructor; import lombok.experimental.SuperBuilder; @@ -31,6 +32,7 @@ import lombok.experimental.SuperBuilder; @Data @SuperBuilder +@NoArgsConstructor public abstract class ControllerTopic { protected String topicName; protected List events; diff --git a/policy-domains/src/main/java/org/onap/policy/drools/domain/models/legacy/LegacyPolicy.java b/policy-domains/src/main/java/org/onap/policy/drools/domain/models/legacy/LegacyPolicy.java index f4fcb702..d18300d1 100644 --- a/policy-domains/src/main/java/org/onap/policy/drools/domain/models/legacy/LegacyPolicy.java +++ b/policy-domains/src/main/java/org/onap/policy/drools/domain/models/legacy/LegacyPolicy.java @@ -22,6 +22,7 @@ package org.onap.policy.drools.domain.models.legacy; import java.io.Serializable; import lombok.Data; +import lombok.EqualsAndHashCode; import lombok.experimental.SuperBuilder; import org.onap.policy.drools.domain.models.DroolsPolicy; @@ -32,6 +33,7 @@ import org.onap.policy.drools.domain.models.DroolsPolicy; @Data @SuperBuilder +@EqualsAndHashCode(callSuper = true) public class LegacyPolicy extends DroolsPolicy implements Serializable { private static final long serialVersionUID = 4100092564657497713L; diff --git a/policy-domains/src/main/java/org/onap/policy/drools/domain/models/operational/OperationalPolicy.java b/policy-domains/src/main/java/org/onap/policy/drools/domain/models/operational/OperationalPolicy.java index d158608b..433dc3e1 100644 --- a/policy-domains/src/main/java/org/onap/policy/drools/domain/models/operational/OperationalPolicy.java +++ b/policy-domains/src/main/java/org/onap/policy/drools/domain/models/operational/OperationalPolicy.java @@ -22,6 +22,7 @@ package org.onap.policy.drools.domain.models.operational; import java.io.Serializable; import lombok.Data; +import lombok.EqualsAndHashCode; import lombok.experimental.SuperBuilder; import org.onap.policy.drools.domain.models.DroolsPolicy; @@ -32,6 +33,7 @@ import org.onap.policy.drools.domain.models.DroolsPolicy; @Data @SuperBuilder +@EqualsAndHashCode(callSuper = true) public class OperationalPolicy extends DroolsPolicy implements Serializable { private static final long serialVersionUID = 4100092564657497713L; diff --git a/policy-domains/src/main/java/org/onap/policy/drools/domain/models/operational/OperationalProperties.java b/policy-domains/src/main/java/org/onap/policy/drools/domain/models/operational/OperationalProperties.java index 993ba024..f41d5c0f 100644 --- a/policy-domains/src/main/java/org/onap/policy/drools/domain/models/operational/OperationalProperties.java +++ b/policy-domains/src/main/java/org/onap/policy/drools/domain/models/operational/OperationalProperties.java @@ -44,11 +44,13 @@ public class OperationalProperties implements Serializable { /** * Timeout in seconds. */ + @Builder.Default private int timeout = 30; /** * Abatement. */ + @Builder.Default private boolean abatement = false; /** diff --git a/policy-domains/src/test/java/org/onap/policy/drools/domain/models/DroolsPolicyTest.java b/policy-domains/src/test/java/org/onap/policy/drools/domain/models/DroolsPolicyTest.java index c6e8990e..98ddd4c8 100644 --- a/policy-domains/src/test/java/org/onap/policy/drools/domain/models/DroolsPolicyTest.java +++ b/policy-domains/src/test/java/org/onap/policy/drools/domain/models/DroolsPolicyTest.java @@ -32,6 +32,7 @@ import com.openpojo.validation.test.impl.SetterTester; import java.io.Serializable; import java.util.List; import lombok.Data; +import lombok.EqualsAndHashCode; import lombok.NoArgsConstructor; import lombok.experimental.SuperBuilder; import org.junit.Test; @@ -41,6 +42,7 @@ public class DroolsPolicyTest { @Data @SuperBuilder @NoArgsConstructor + @EqualsAndHashCode(callSuper = true) public static class DerivedDomainPolicy extends DroolsPolicy implements Serializable { private static final long serialVersionUID = -1027974819756498893L; } diff --git a/policy-domains/src/test/java/org/onap/policy/drools/domain/models/legacy/LegacyPolicyTest.java b/policy-domains/src/test/java/org/onap/policy/drools/domain/models/legacy/LegacyPolicyTest.java index 7eb2532f..13e91cc0 100644 --- a/policy-domains/src/test/java/org/onap/policy/drools/domain/models/legacy/LegacyPolicyTest.java +++ b/policy-domains/src/test/java/org/onap/policy/drools/domain/models/legacy/LegacyPolicyTest.java @@ -38,7 +38,7 @@ public class LegacyPolicyTest { private static final String OPERATIONAL_LEGACY_POLICY_TYPE = "onap.policies.controlloop.Operational"; // Operational vCPE Legacy Policy - private static final String OP_POLICY_NAME_VCPE = "operational.restart"; + public static final String OP_POLICY_NAME_VCPE = "operational.restart"; public static final String VCPE_OPERATIONAL_LEGACY_POLICY_JSON = "src/test/resources/tosca-legacy-vcpe.json"; @Test diff --git a/policy-domains/src/test/java/org/onap/policy/drools/domain/models/operational/OperationalPolicyTest.java b/policy-domains/src/test/java/org/onap/policy/drools/domain/models/operational/OperationalPolicyTest.java index bf50a3df..8f37b47c 100644 --- a/policy-domains/src/test/java/org/onap/policy/drools/domain/models/operational/OperationalPolicyTest.java +++ b/policy-domains/src/test/java/org/onap/policy/drools/domain/models/operational/OperationalPolicyTest.java @@ -23,9 +23,6 @@ package org.onap.policy.drools.domain.models.operational; import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertTrue; -import java.io.IOException; -import java.nio.file.Files; -import java.nio.file.Paths; import java.util.List; import org.junit.Before; import org.junit.Test; @@ -102,10 +99,6 @@ public class OperationalPolicyTest { assertNotNull(policy); } - private String getJsonFromFile(String filePath) throws IOException { - return Files.readString(Paths.get(filePath)); - } - private String getJsonFromResource(String resourcePath) { return ResourceUtils.getResourceAsString(resourcePath); } -- cgit 1.2.3-korg