From 56a15039437ba5bf5d0fb422551bfb12e1f59eb1 Mon Sep 17 00:00:00 2001 From: Jim Hahn Date: Fri, 19 Jun 2020 14:32:10 -0400 Subject: Address checkstyle version issues in drools-pdp Also added serializationId to several classes to address eclipse warnings. Issue-ID: POLICY-2188 Change-Id: I3df5e8abaad8da9261c0d5cd19a93ed68dceb870 Signed-off-by: Jim Hahn --- .../main/java/org/onap/policy/drools/core/PolicyContainer.java | 1 - .../src/main/java/org/onap/policy/drools/core/PolicySession.java | 1 - .../main/java/org/onap/policy/drools/core/jmx/PdpJmxListener.java | 8 +++----- .../src/main/java/org/onap/policy/drools/util/KieUtils.java | 4 +--- 4 files changed, 4 insertions(+), 10 deletions(-) (limited to 'policy-core/src/main/java/org') diff --git a/policy-core/src/main/java/org/onap/policy/drools/core/PolicyContainer.java b/policy-core/src/main/java/org/onap/policy/drools/core/PolicyContainer.java index fee18a05..6547ca73 100644 --- a/policy-core/src/main/java/org/onap/policy/drools/core/PolicyContainer.java +++ b/policy-core/src/main/java/org/onap/policy/drools/core/PolicyContainer.java @@ -26,7 +26,6 @@ import java.util.HashMap; import java.util.HashSet; import java.util.List; import java.util.concurrent.ConcurrentHashMap; - import org.kie.api.KieBase; import org.kie.api.KieServices; import org.kie.api.builder.KieScanner; diff --git a/policy-core/src/main/java/org/onap/policy/drools/core/PolicySession.java b/policy-core/src/main/java/org/onap/policy/drools/core/PolicySession.java index cee7c368..49ff7bb8 100644 --- a/policy-core/src/main/java/org/onap/policy/drools/core/PolicySession.java +++ b/policy-core/src/main/java/org/onap/policy/drools/core/PolicySession.java @@ -22,7 +22,6 @@ package org.onap.policy.drools.core; import java.util.concurrent.ConcurrentHashMap; - import org.kie.api.event.rule.AfterMatchFiredEvent; import org.kie.api.event.rule.AgendaEventListener; import org.kie.api.event.rule.AgendaGroupPoppedEvent; diff --git a/policy-core/src/main/java/org/onap/policy/drools/core/jmx/PdpJmxListener.java b/policy-core/src/main/java/org/onap/policy/drools/core/jmx/PdpJmxListener.java index 04f0dfd0..924f2b00 100644 --- a/policy-core/src/main/java/org/onap/policy/drools/core/jmx/PdpJmxListener.java +++ b/policy-core/src/main/java/org/onap/policy/drools/core/jmx/PdpJmxListener.java @@ -7,9 +7,9 @@ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at - * + * * http://www.apache.org/licenses/LICENSE-2.0 - * + * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. @@ -21,7 +21,6 @@ package org.onap.policy.drools.core.jmx; import java.lang.management.ManagementFactory; - import javax.management.InstanceAlreadyExistsException; import javax.management.InstanceNotFoundException; import javax.management.MBeanRegistrationException; @@ -29,7 +28,6 @@ import javax.management.MBeanServer; import javax.management.MalformedObjectNameException; import javax.management.NotCompliantMBeanException; import javax.management.ObjectName; - import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -49,7 +47,7 @@ public class PdpJmxListener { server.unregisterMBean(new ObjectName("PolicyEngine:type=PdpJmx")); } catch (MBeanRegistrationException | InstanceNotFoundException | MalformedObjectNameException e) { - logger.error("PdpJmxListener.stop(): " + logger.error("PdpJmxListener.stop(): " + "Could not unregister PolicyEngine:type=PdpJmx MBean " + "with the MBean server", e); } diff --git a/policy-core/src/main/java/org/onap/policy/drools/util/KieUtils.java b/policy-core/src/main/java/org/onap/policy/drools/util/KieUtils.java index bcad792c..d56af118 100644 --- a/policy-core/src/main/java/org/onap/policy/drools/util/KieUtils.java +++ b/policy-core/src/main/java/org/onap/policy/drools/util/KieUtils.java @@ -33,9 +33,7 @@ import java.util.HashSet; import java.util.List; import java.util.Optional; import java.util.stream.Collectors; - import lombok.NonNull; - import org.apache.commons.io.IOUtils; import org.drools.compiler.kie.builder.impl.InternalKieModule; import org.drools.compiler.kproject.models.KieModuleModelImpl; @@ -246,7 +244,7 @@ public class KieUtils { if (!stillNeeded.isEmpty()) { // there are still packages we need to add -- // this code makes use of an internal class and method - ((KnowledgeBaseImpl)kieBase).addPackages(stillNeeded); + ((KnowledgeBaseImpl) kieBase).addPackages(stillNeeded); } } } -- cgit 1.2.3-korg