From e5b8cf8fc75789f8d22e01e9002e66600d6e1460 Mon Sep 17 00:00:00 2001 From: Kevin McKiou Date: Wed, 27 Sep 2017 16:06:33 -0500 Subject: SonarCube Critical Issue Patch 1: Modifying DbAudit to access isJunit variable to, hopefully, satisfy SonarCube on a critical issue. Issue-ID: POLICY-261 Change-Id: Ibc1a2876bdf08377798c503110b05e79a0986c38 Signed-off-by: Kevin McKiou --- .../org/onap/policy/drools/statemanagement/DbAudit.java | 16 +++++++++++++--- .../drools/statemanagement/test/StateManagementTest.java | 2 +- 2 files changed, 14 insertions(+), 4 deletions(-) (limited to 'feature-state-management') diff --git a/feature-state-management/src/main/java/org/onap/policy/drools/statemanagement/DbAudit.java b/feature-state-management/src/main/java/org/onap/policy/drools/statemanagement/DbAudit.java index cde6e4e4..b2830e8c 100644 --- a/feature-state-management/src/main/java/org/onap/policy/drools/statemanagement/DbAudit.java +++ b/feature-state-management/src/main/java/org/onap/policy/drools/statemanagement/DbAudit.java @@ -44,11 +44,21 @@ public class DbAudit extends DroolsPDPIntegrityMonitor.AuditBase // invoked -- doing this avoids the need to create the table in advance. static private boolean createTableNeeded = true; - static public boolean isJunit = false; - synchronized private static void setCreateTableNeeded(boolean b) { DbAudit.createTableNeeded = b; - } + } + + static private boolean isJunit = false; + + synchronized public static void setIsJunit(boolean b) { + DbAudit.isJunit = b; + } + + public static boolean isJunit(){ + return DbAudit.isJunit; + } + + /** * @return the single 'DbAudit' instance */ diff --git a/feature-state-management/src/test/java/org/onap/policy/drools/statemanagement/test/StateManagementTest.java b/feature-state-management/src/test/java/org/onap/policy/drools/statemanagement/test/StateManagementTest.java index ba7ce3ea..6f2a0e25 100644 --- a/feature-state-management/src/test/java/org/onap/policy/drools/statemanagement/test/StateManagementTest.java +++ b/feature-state-management/src/test/java/org/onap/policy/drools/statemanagement/test/StateManagementTest.java @@ -110,7 +110,7 @@ public class StateManagementTest { String configDir = "src/test/resources"; - DbAudit.isJunit = true; + DbAudit.setIsJunit(true); Properties fsmProperties = new Properties(); fsmProperties.load(new FileInputStream(new File( -- cgit 1.2.3-korg