From f38687b040bec7b8556fb4bde229343831fa43fd Mon Sep 17 00:00:00 2001 From: jhh Date: Fri, 8 Nov 2019 08:42:55 -0600 Subject: Miscellaneous code clean up Issue-ID: POLICY-2203 Signed-off-by: jhh Change-Id: I5731d4636bd2aaecbc486406298bcba1b19e8f4d Signed-off-by: jhh --- .../java/org/onap/policy/drools/pooling/FeatureTest.java | 2 +- .../onap/policy/drools/pooling/PoolingManagerImplTest.java | 5 ++--- .../drools/pooling/extractor/ClassExtractorsTest.java | 8 ++++---- .../drools/pooling/message/SupportBasicMessageTester.java | 14 +++++++------- 4 files changed, 14 insertions(+), 15 deletions(-) (limited to 'feature-pooling-dmaap/src/test') diff --git a/feature-pooling-dmaap/src/test/java/org/onap/policy/drools/pooling/FeatureTest.java b/feature-pooling-dmaap/src/test/java/org/onap/policy/drools/pooling/FeatureTest.java index 5768e1d8..d51e61e6 100644 --- a/feature-pooling-dmaap/src/test/java/org/onap/policy/drools/pooling/FeatureTest.java +++ b/feature-pooling-dmaap/src/test/java/org/onap/policy/drools/pooling/FeatureTest.java @@ -1105,6 +1105,6 @@ public class FeatureTest { @FunctionalInterface private static interface VoidFunction { - public void apply(); + void apply(); } } diff --git a/feature-pooling-dmaap/src/test/java/org/onap/policy/drools/pooling/PoolingManagerImplTest.java b/feature-pooling-dmaap/src/test/java/org/onap/policy/drools/pooling/PoolingManagerImplTest.java index a711a7e9..5293b794 100644 --- a/feature-pooling-dmaap/src/test/java/org/onap/policy/drools/pooling/PoolingManagerImplTest.java +++ b/feature-pooling-dmaap/src/test/java/org/onap/policy/drools/pooling/PoolingManagerImplTest.java @@ -95,7 +95,6 @@ public class PoolingManagerImplTest { */ private Queue> futures; - private Properties plainProps; private PoolingProperties poolProps; private ListeningController controller; private ClassExtractors extractors; @@ -111,12 +110,12 @@ public class PoolingManagerImplTest { /** * Setup. - * + * * @throws Exception throws exception */ @Before public void setUp() throws Exception { - plainProps = new Properties(); + Properties plainProps = new Properties(); poolProps = mock(PoolingProperties.class); when(poolProps.getSource()).thenReturn(plainProps); diff --git a/feature-pooling-dmaap/src/test/java/org/onap/policy/drools/pooling/extractor/ClassExtractorsTest.java b/feature-pooling-dmaap/src/test/java/org/onap/policy/drools/pooling/extractor/ClassExtractorsTest.java index c277a00f..0bf087a3 100644 --- a/feature-pooling-dmaap/src/test/java/org/onap/policy/drools/pooling/extractor/ClassExtractorsTest.java +++ b/feature-pooling-dmaap/src/test/java/org/onap/policy/drools/pooling/extractor/ClassExtractorsTest.java @@ -2,14 +2,14 @@ * ============LICENSE_START======================================================= * ONAP * ================================================================================ - * Copyright (C) 2018 AT&T Intellectual Property. All rights reserved. + * Copyright (C) 2018-2019 AT&T Intellectual Property. All rights reserved. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at - * + * * http://www.apache.org/licenses/LICENSE-2.0 - * + * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. @@ -412,7 +412,7 @@ public class ClassExtractorsTest { */ private static interface WithString { - public String getStrValue(); + String getStrValue(); } /** diff --git a/feature-pooling-dmaap/src/test/java/org/onap/policy/drools/pooling/message/SupportBasicMessageTester.java b/feature-pooling-dmaap/src/test/java/org/onap/policy/drools/pooling/message/SupportBasicMessageTester.java index 19e7ab0b..86247835 100644 --- a/feature-pooling-dmaap/src/test/java/org/onap/policy/drools/pooling/message/SupportBasicMessageTester.java +++ b/feature-pooling-dmaap/src/test/java/org/onap/policy/drools/pooling/message/SupportBasicMessageTester.java @@ -207,7 +207,7 @@ public abstract class SupportBasicMessageTester { /** * Verifies that fields are set as expected by {@link #makeValidMessage()}. - * + * * @param msg message whose fields are to be validated */ public void testValidFields(T msg) { @@ -217,7 +217,7 @@ public abstract class SupportBasicMessageTester { /** * Function that updates a message. - * + * * @param type of Message the function updates */ @FunctionalInterface @@ -225,15 +225,15 @@ public abstract class SupportBasicMessageTester { /** * Updates a message. - * + * * @param msg message to be updated */ - public void update(T msg); + void update(T msg); } /** * Function that updates a single field within a message. - * + * * @param type of Message the function updates */ @FunctionalInterface @@ -241,10 +241,10 @@ public abstract class SupportBasicMessageTester { /** * Updates a field within a message. - * + * * @param msg message to be updated * @param newValue new field value */ - public void update(T msg, String newValue); + void update(T msg, String newValue); } } -- cgit 1.2.3-korg