From 757a65fe95f5f203545085ea63f659a817dad260 Mon Sep 17 00:00:00 2001 From: Jim Hahn Date: Fri, 12 Feb 2021 08:03:49 -0500 Subject: Fix sonars from dependency upgrade The dependency upgrades in policy-parent caused some new sonars. In particular, initMocks() has been deprecated - replaced with calls to the Mockito Runner. Changed one to openMocks() because using the Runner caused it to fail on jenkins, but not in the local eclipse. Also fixed a type safety issue with EMPTY_LIST. Issue-ID: POLICY-2909 Change-Id: Iea9420190f208d7de3bf3ad531515c92e0fab83f Signed-off-by: Jim Hahn --- .../java/org/onap/policy/drools/lifecycle/LifecycleFsmTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'feature-lifecycle/src') diff --git a/feature-lifecycle/src/test/java/org/onap/policy/drools/lifecycle/LifecycleFsmTest.java b/feature-lifecycle/src/test/java/org/onap/policy/drools/lifecycle/LifecycleFsmTest.java index 0e3680dc..a77b03f5 100644 --- a/feature-lifecycle/src/test/java/org/onap/policy/drools/lifecycle/LifecycleFsmTest.java +++ b/feature-lifecycle/src/test/java/org/onap/policy/drools/lifecycle/LifecycleFsmTest.java @@ -145,9 +145,9 @@ public class LifecycleFsmTest { List.of(opPolicy, op2Policy, unvalPolicy, valPolicy, artifactPolicy, artifact2Policy, controller2Policy, controllerPolicy); - assertEquals(expectedUndeployOrder, fsm.getUndeployablePoliciesAction(Collections.EMPTY_LIST)); - assertEquals(expectedUndeployOrder, fsm.getUndeployablePoliciesAction(Collections.EMPTY_LIST)); - assertEquals(expectedUndeployOrder, fsm.getUndeployablePoliciesAction(Collections.EMPTY_LIST)); + assertEquals(expectedUndeployOrder, fsm.getUndeployablePoliciesAction(Collections.emptyList())); + assertEquals(expectedUndeployOrder, fsm.getUndeployablePoliciesAction(Collections.emptyList())); + assertEquals(expectedUndeployOrder, fsm.getUndeployablePoliciesAction(Collections.emptyList())); } @Test -- cgit 1.2.3-korg