From d04af420514c9c852af77780f0bd5ee23ebb401a Mon Sep 17 00:00:00 2001 From: Jim Hahn Date: Thu, 26 Aug 2021 14:36:35 -0400 Subject: Fix sonars in drools-pdp Fixed sonars: - use "var" - override "equals" - unused imports Also changed some of the JPA queries to make them typed queries. Issue-ID: POLICY-3289 Change-Id: Ib3a00be322d8d00ba492673708439cacfe2c7fc4 Signed-off-by: Jim Hahn --- .../org/onap/policy/drools/healthcheck/HealthCheckManager.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'feature-healthcheck/src/main/java') diff --git a/feature-healthcheck/src/main/java/org/onap/policy/drools/healthcheck/HealthCheckManager.java b/feature-healthcheck/src/main/java/org/onap/policy/drools/healthcheck/HealthCheckManager.java index 418fe8eb..8bbd19ad 100644 --- a/feature-healthcheck/src/main/java/org/onap/policy/drools/healthcheck/HealthCheckManager.java +++ b/feature-healthcheck/src/main/java/org/onap/policy/drools/healthcheck/HealthCheckManager.java @@ -74,11 +74,11 @@ public class HealthCheckManager implements HealthCheck { */ @Override public Reports healthCheck() { - Reports reports = new Reports(); + var reports = new Reports(); boolean thisEngineIsAlive = getEngineManager().isAlive(); reports.setHealthy(thisEngineIsAlive); - HealthCheck.Report engineReport = new Report(); + var engineReport = new Report(); engineReport.setHealthy(thisEngineIsAlive); engineReport.setName("PDP-D"); engineReport.setUrl("self"); @@ -87,12 +87,12 @@ public class HealthCheckManager implements HealthCheck { reports.getDetails().add(engineReport); for (HttpClient client : clients) { - HealthCheck.Report report = new Report(); + var report = new Report(); report.setName(client.getName()); report.setUrl(client.getBaseUrl()); report.setHealthy(true); try { - Response response = client.get(); + var response = client.get(); report.setCode(response.getStatus()); if (report.getCode() != 200) { report.setHealthy(false); -- cgit 1.2.3-korg