From a0e0c7840f72392152a970d88a5a66d394c4a793 Mon Sep 17 00:00:00 2001 From: Pamela Dragosh Date: Fri, 28 Sep 2018 04:58:26 -0400 Subject: Set drools-pdp checkstyle config Fixed last remaining checkstyle issues along with setting the pom.xml to the correct path setting. Fixed forbidden summary fragments, not allowed to prepend summary with "This method returns" Issue-ID: POLICY-1153 Change-Id: I267842080494132a7b5507731e14f027a3f6fe44 Signed-off-by: Pamela Dragosh --- .../drools/activestandby/ActiveStandbyFeature.java | 16 ++++++++-------- .../policy/drools/activestandby/DroolsPdpEntity.java | 2 +- .../drools/activestandby/DroolsPdpsElectionHandler.java | 6 +++--- .../activestandby/PMStandbyStateChangeNotifier.java | 4 ++-- 4 files changed, 14 insertions(+), 14 deletions(-) (limited to 'feature-active-standby-management/src/main/java/org/onap') diff --git a/feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/ActiveStandbyFeature.java b/feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/ActiveStandbyFeature.java index 9e481f01..1b7d91bd 100644 --- a/feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/ActiveStandbyFeature.java +++ b/feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/ActiveStandbyFeature.java @@ -62,12 +62,12 @@ public class ActiveStandbyFeature implements ActiveStandbyFeatureAPI, public static final int SEQ_NUM = 1; - /**************************/ + /*========================*/ /* 'FeatureAPI' interface */ - /**************************/ + /*========================*/ /** - * {@inheritDoc} + * {@inheritDoc}. */ @Override public int getSequenceNumber() { @@ -75,7 +75,7 @@ public class ActiveStandbyFeature implements ActiveStandbyFeatureAPI, } /** - * {@inheritDoc} + * {@inheritDoc}. */ @Override public void globalInit(String[] args, String configDir) { @@ -121,7 +121,7 @@ public class ActiveStandbyFeature implements ActiveStandbyFeatureAPI, /** - * {@inheritDoc} + * {@inheritDoc}. */ @Override public boolean afterStart(PolicyEngine engine) { @@ -210,7 +210,7 @@ public class ActiveStandbyFeature implements ActiveStandbyFeatureAPI, } /** - * {@inheritDoc} + * {@inheritDoc}. */ @Override public String getPdpdNowActive() { @@ -218,7 +218,7 @@ public class ActiveStandbyFeature implements ActiveStandbyFeatureAPI, } /** - * {@inheritDoc} + * {@inheritDoc}. */ @Override public String getPdpdLastActive() { @@ -226,7 +226,7 @@ public class ActiveStandbyFeature implements ActiveStandbyFeatureAPI, } /** - * {@inheritDoc} + * {@inheritDoc}. */ @Override public String getResourceName() { diff --git a/feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/DroolsPdpEntity.java b/feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/DroolsPdpEntity.java index f0fd2789..12d716a6 100644 --- a/feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/DroolsPdpEntity.java +++ b/feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/DroolsPdpEntity.java @@ -39,7 +39,7 @@ import org.onap.policy.drools.activestandby.DroolsPdpObject; @NamedQueries({ @NamedQuery(name = "DroolsPdpEntity.findAll", query = "SELECT e FROM DroolsPdpEntity e "), @NamedQuery(name = "DroolsPdpEntity.deleteAll", query = "DELETE FROM DroolsPdpEntity WHERE 1=1") -}) + }) public class DroolsPdpEntity extends DroolsPdpObject implements Serializable { private static final long serialVersionUID = 1L; diff --git a/feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/DroolsPdpsElectionHandler.java b/feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/DroolsPdpsElectionHandler.java index 08592f23..fddf0246 100644 --- a/feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/DroolsPdpsElectionHandler.java +++ b/feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/DroolsPdpsElectionHandler.java @@ -637,7 +637,7 @@ public class DroolsPdpsElectionHandler implements ThreadRunningChecker { * Sanitize designated list. * * @param listOfDesignated list of designated pdps - * @return + * @return list of drools pdps */ public List santizeDesignatedList(List listOfDesignated) { @@ -668,7 +668,7 @@ public class DroolsPdpsElectionHandler implements ThreadRunningChecker { * * @param pdps collection of pdps * @param listOfDesignated list of designated pdps - * @return + * @return drools pdp object */ public DroolsPdp computeMostRecentPrimary(Collection pdps, List listOfDesignated) { boolean containsDesignated = false; @@ -778,7 +778,7 @@ public class DroolsPdpsElectionHandler implements ThreadRunningChecker { * * @param listOfDesignated list of designated pdps * @param mostRecentPrimary most recent primary pdpd - * @return + * @return drools pdp object */ public DroolsPdp computeDesignatedPdp(List listOfDesignated, DroolsPdp mostRecentPrimary) { DroolsPdp designatedPdp = null; diff --git a/feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/PMStandbyStateChangeNotifier.java b/feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/PMStandbyStateChangeNotifier.java index 554376ce..53f825d0 100644 --- a/feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/PMStandbyStateChangeNotifier.java +++ b/feature-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/PMStandbyStateChangeNotifier.java @@ -122,7 +122,7 @@ public class PMStandbyStateChangeNotifier extends StateChangeNotifier { String pdpId = ActiveStandbyProperties.getProperty(ActiveStandbyProperties.NODE_NAME); if (logger.isDebugEnabled()) { - logger.debug("handleStateChange: previousStandbyStatus = {}" + "; standbyStatus = {}", + logger.debug("handleStateChange: previousStandbyStatus = {}; standbyStatus = {}", previousStandbyStatus, standbyStatus); } @@ -201,7 +201,7 @@ public class PMStandbyStateChangeNotifier extends StateChangeNotifier { } else if (standbyStatus.equals(StateManagement.PROVIDING_SERVICE)) { if (logger.isDebugEnabled()) { - logger.debug("handleStateChange: standbyStatus= {} " + "scheduling activation of PDP={}", standbyStatus, + logger.debug("handleStateChange: standbyStatus= {} scheduling activation of PDP={}", standbyStatus, pdpId); } if (previousStandbyStatus.equals(StateManagement.PROVIDING_SERVICE)) { -- cgit 1.2.3-korg