From 6dee9fba7e3c471bab358d8567a9e3e0a3fca769 Mon Sep 17 00:00:00 2001 From: Jim Hahn Date: Wed, 10 Jul 2019 15:42:40 -0400 Subject: Fix checkstyle issues in api-active-standby-management Also deleted the checkstyle suppression file. Change-Id: I3518f29c75061dced8f507b274388f7588859037 Issue-ID: POLICY-1901 Signed-off-by: Jim Hahn --- .../checkstyle-suppressions.xml | 30 ----------- api-active-standby-management/pom.xml | 3 +- .../activestandby/ActiveStandbyFeatureAPI.java | 61 ---------------------- .../activestandby/ActiveStandbyFeatureApi.java | 61 ++++++++++++++++++++++ 4 files changed, 62 insertions(+), 93 deletions(-) delete mode 100644 api-active-standby-management/checkstyle-suppressions.xml delete mode 100644 api-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/ActiveStandbyFeatureAPI.java create mode 100644 api-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/ActiveStandbyFeatureApi.java (limited to 'api-active-standby-management') diff --git a/api-active-standby-management/checkstyle-suppressions.xml b/api-active-standby-management/checkstyle-suppressions.xml deleted file mode 100644 index b6fa7eff..00000000 --- a/api-active-standby-management/checkstyle-suppressions.xml +++ /dev/null @@ -1,30 +0,0 @@ - - - - - - - - diff --git a/api-active-standby-management/pom.xml b/api-active-standby-management/pom.xml index 0d6861bd..9182c5a8 100644 --- a/api-active-standby-management/pom.xml +++ b/api-active-standby-management/pom.xml @@ -2,7 +2,7 @@ ============LICENSE_START======================================================= ECOMP Policy Engine - Drools PDP ================================================================================ - Copyright (C) 2017 AT&T Intellectual Property. All rights reserved. + Copyright (C) 2017, 2019 AT&T Intellectual Property. All rights reserved. ================================================================================ Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. @@ -69,7 +69,6 @@ true - ${project.baseUri}checkstyle-suppressions.xml true true warning diff --git a/api-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/ActiveStandbyFeatureAPI.java b/api-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/ActiveStandbyFeatureAPI.java deleted file mode 100644 index 5f99e6bb..00000000 --- a/api-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/ActiveStandbyFeatureAPI.java +++ /dev/null @@ -1,61 +0,0 @@ -/*- - * ============LICENSE_START======================================================= - * api-active-standby-management - * ================================================================================ - * Copyright (C) 2017-2019 AT&T Intellectual Property. All rights reserved. - * ================================================================================ - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - * ============LICENSE_END========================================================= - */ - -package org.onap.policy.drools.activestandby; - -import org.onap.policy.common.utils.services.OrderedService; -import org.onap.policy.common.utils.services.OrderedServiceImpl; - -/** - * This interface provides a way to invoke optional features at various points in the code. At - * appropriate points in the application, the code iterates through this list, invoking these - * optional methods. - */ -public interface ActiveStandbyFeatureAPI extends OrderedService { - /** - * 'FeatureAPI.impl.getList()' returns an ordered list of objects implementing the 'FeatureAPI' - * interface. - */ - public static OrderedServiceImpl impl = - new OrderedServiceImpl<>(ActiveStandbyFeatureAPI.class); - - /** - * Returns the resourceName (PDP ID) for the Drools-PDP that is - * currently designated as active. - * - * @return String (resourceName) - */ - public String getPdpdNowActive(); - - /** - * Returns the resourceName (PDP ID) for the Drools-PDP that is - * previously designated as active. - * - * @return String (resourceName) - */ - public String getPdpdLastActive(); - - /** - * Returns the resourceName associated with this instance of the feature. - * - * @return String (resourceName) - */ - public String getResourceName(); -} diff --git a/api-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/ActiveStandbyFeatureApi.java b/api-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/ActiveStandbyFeatureApi.java new file mode 100644 index 00000000..8637fa5c --- /dev/null +++ b/api-active-standby-management/src/main/java/org/onap/policy/drools/activestandby/ActiveStandbyFeatureApi.java @@ -0,0 +1,61 @@ +/*- + * ============LICENSE_START======================================================= + * api-active-standby-management + * ================================================================================ + * Copyright (C) 2017-2019 AT&T Intellectual Property. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.drools.activestandby; + +import org.onap.policy.common.utils.services.OrderedService; +import org.onap.policy.common.utils.services.OrderedServiceImpl; + +/** + * This interface provides a way to invoke optional features at various points in the code. At + * appropriate points in the application, the code iterates through this list, invoking these + * optional methods. + */ +public interface ActiveStandbyFeatureApi extends OrderedService { + /** + * 'FeatureAPI.impl.getList()' returns an ordered list of objects implementing the 'FeatureAPI' + * interface. + */ + public static OrderedServiceImpl impl = + new OrderedServiceImpl<>(ActiveStandbyFeatureApi.class); + + /** + * Returns the resourceName (PDP ID) for the Drools-PDP that is + * currently designated as active. + * + * @return String (resourceName) + */ + public String getPdpdNowActive(); + + /** + * Returns the resourceName (PDP ID) for the Drools-PDP that is + * previously designated as active. + * + * @return String (resourceName) + */ + public String getPdpdLastActive(); + + /** + * Returns the resourceName associated with this instance of the feature. + * + * @return String (resourceName) + */ + public String getResourceName(); +} -- cgit 1.2.3-korg