From 26374a9c185b29d85b12611735469e8543415031 Mon Sep 17 00:00:00 2001 From: Jim Hahn Date: Wed, 10 Feb 2021 17:41:25 -0500 Subject: More sonars in drools-pdp Addressed the following issues: - log user-controlled data; moved the "NOSONAR" to a different line - make constructors protected Issue-ID: POLICY-2909 Change-Id: Ic69c100af777779e791c38cc444dd2ea726258f2 Signed-off-by: Jim Hahn --- .../src/main/java/org/onap/policy/drools/pooling/state/State.java | 4 ++-- .../onap/policy/drools/statemanagement/DroolsPdpIntegrityMonitor.java | 2 +- .../onap/policy/drools/controller/internal/MavenDroolsController.java | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/feature-pooling-dmaap/src/main/java/org/onap/policy/drools/pooling/state/State.java b/feature-pooling-dmaap/src/main/java/org/onap/policy/drools/pooling/state/State.java index 853c24d4..66728ee2 100644 --- a/feature-pooling-dmaap/src/main/java/org/onap/policy/drools/pooling/state/State.java +++ b/feature-pooling-dmaap/src/main/java/org/onap/policy/drools/pooling/state/State.java @@ -2,7 +2,7 @@ * ============LICENSE_START======================================================= * ONAP * ================================================================================ - * Copyright (C) 2018, 2020 AT&T Intellectual Property. All rights reserved. + * Copyright (C) 2018, 2020-2021 AT&T Intellectual Property. All rights reserved. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -59,7 +59,7 @@ public abstract class State { * * @param mgr pooling manager */ - public State(PoolingManager mgr) { + protected State(PoolingManager mgr) { this.mgr = mgr; } diff --git a/feature-state-management/src/main/java/org/onap/policy/drools/statemanagement/DroolsPdpIntegrityMonitor.java b/feature-state-management/src/main/java/org/onap/policy/drools/statemanagement/DroolsPdpIntegrityMonitor.java index 081a8292..680abf3f 100644 --- a/feature-state-management/src/main/java/org/onap/policy/drools/statemanagement/DroolsPdpIntegrityMonitor.java +++ b/feature-state-management/src/main/java/org/onap/policy/drools/statemanagement/DroolsPdpIntegrityMonitor.java @@ -318,7 +318,7 @@ public class DroolsPdpIntegrityMonitor extends IntegrityMonitor { * * @param name name of the audit */ - public AuditBase(String name) { + protected AuditBase(String name) { this.name = name; this.response = null; } diff --git a/policy-management/src/main/java/org/onap/policy/drools/controller/internal/MavenDroolsController.java b/policy-management/src/main/java/org/onap/policy/drools/controller/internal/MavenDroolsController.java index 46049138..6ddcc364 100644 --- a/policy-management/src/main/java/org/onap/policy/drools/controller/internal/MavenDroolsController.java +++ b/policy-management/src/main/java/org/onap/policy/drools/controller/internal/MavenDroolsController.java @@ -485,8 +485,8 @@ public class MavenDroolsController implements DroolsController { this.getArtifactId(), topic)) { - logger.warn("{}: DECODING-UNSUPPORTED {}:{}:{}", this, - topic, this.getGroupId(), this.getArtifactId()); // NOSONAR + logger.warn("{}: DECODING-UNSUPPORTED {}:{}:{}", this, // NOSONAR + topic, this.getGroupId(), this.getArtifactId()); return true; } -- cgit 1.2.3-korg