Age | Commit message (Collapse) | Author | Files | Lines |
|
When GSON is made the default serialization provider, several
junits break. Modified them to specify the GsonJackson provider,
which is what the REST classes use in production.
Issue-ID: POLICY-1526
Change-Id: If1bcb955d7411cf747a14a0bf1dc069b02e2f2ea
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2514
Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
Change-Id: Ib18f045a621ce15f8381607ba87639dd188887e5
|
|
Issue-ID: POLICY-2514
Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
Change-Id: Icb874f6b91488c5003e9d22460ce57e37b11dc30
|
|
Issue-ID: POLICY-2514
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ic20bfc53e3216290fc2a75158b2ccd6fdd87863b
|
|
Issue-ID: POLICY-2514
Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
Change-Id: I8dbb9269ebdaa906e19a05efcc4a588164b06667
|
|
|
|
Issue-ID: POLICY-2514
Change-Id: Idf97f7bd6308e954deaa40d33147025dfdac2268
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2546
Change-Id: Ibddde78d705349b3c8510678f25dfce817b1a091
Signed-off-by: Straubs, Ralph (rs8887) <rs8887@att.com>
|
|
Issue-ID: POLICY-2510
Change-Id: Ic6ce8069e65c9b7606ab3529ee6291bc772a4191
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2510
Change-Id: I31213a695e2fdaf9ae83a1b63e9bc435a7192809
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2510
Change-Id: I7c9a32c61cc88bca072f035526c16b5019d29e84
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2510
Change-Id: I86db56cc373269b97822f9e243a189b9272a394e
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
description is an optional field, CLAMP users, may not populate
it and send an empty string value
description: ''
This change removes the requirement to be a non-empty string when
present.
Issue-ID: POLICY-2503
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I0c80368b5b6aa5fe5b1c25516cb9ba0a677d7b9a
|
|
Issue-ID: POLICY-2501
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I028ad6f018aec4a41810273f597c631983b88052
|
|
Issue-ID: POLICY-2378
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I75d0acdc4bfb4f2c1870d3c01591e81ada2b7a5f
|
|
Issue-ID: POLICY-2378
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I52b40e034427237387d8bc66da6ae10e4878ddda
|
|
Issue-ID: POLICY-2378
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I5de39953b359b0afca71195f7876f44c33997942
|
|
|
|
Issue-ID: POLICY-2378
Change-Id: Iba4bac51ab85ba14ac3c28d74b1fa99a49bd8480
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Additional instrumetation and tests have been added
as well.
Issue-ID: POLICY-2489
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I65df586f3a44acf3d6f825ebfb8bd73107255a1f
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Fixed naming policy string and yaml coder string fix
Issue-ID: POLICY-2486
Change-Id: I77dc1593a0d4c744090aa7b89303ea5e76d36ead
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2378
Change-Id: Ic80fe0334919361f973c7ae7796c5d8868882fcb
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2305
Change-Id: If056c7e9179e245fafd6badc70ff9eee78fb23b3
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Addressed the following sonar issues:
- use of "synchronized"
- use Files.delete() instead of File.delete()
Issue-ID: POLICY-2305
Change-Id: Id55628fe12d9d764616e57321382a70cb5704ba1
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Addressed the following sonar issues:
- modified code to specify the correct class name in the
getLogger() call
- use equals() instead of "==" for string comparison
- remove deprecated code
- use ',' instead of "," in indexOf
- remove code that is commented out; typically bogus, so the comment
was adjusted to satisfy sonar
- missing assert in junits
- use "{}" instead of concatenation when using logger
- either log or rethrow
- put arguments for assertEquals() in the correct order
- remove "return" statements from the end of void methods
- don't always return the same value; just disabled sonar as
refactoring would have obfuscated the code
- cognitive complexity; used eclipse auto-refactoring to extract
out chunks of code into separate methods
- don't pass array of classes to class.getDeclaredMethod(); use
ellided arguments instead
- fix argument count in logger calls
- remove unnecessary casts
- don't use "volatile"
- make methods "synchronized" to match parent class definitions
Issue-ID: POLICY-2305
Change-Id: Ie96418f696da4ae6c2ca8d4a914371469e695419
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Addressed the following sonar issues:
- add "final" to public static fields
- commented code; some were bogus - just updated the comments
so sonar is happy
- use "{}" instead of string concatenation
- junit should assert something
- when using logger, invoke compute-intensive tasks conditionally
- use superclass name instead of subclass name to access static fields
- don't always return the same value
- remove "transient" from fields of classes that aren't Serializable
- don't nest try/catch blocks
- use appropriate class name in Logger.getLogger()
- use Predicate<T> instead of Function<T,Boolean>
- remove unused parameters from private methods
- either log or throw
- remove duplicate methods
- use remove() TLS instead of set(null)
- null check is implicit in instanceof check
- do something with return value
- don't use volatile
- don't return "null" list; used Optional instead
- add no-arg constructor to non-Serializable superclass
- add callSuper=true for EqualsAndHashCode
- don't declare "throws XXX" where XXX is a subclass of RuntimeException
- remove serialVersionUID field if the class isn't Serializable
Also addressed some eclipse warnings:
- unused fields
- suppress generic typic cast warnings
Issue-ID: POLICY-2305
Change-Id: I906d5bf71c1f86531423e23b3667a585cdba45e1
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
As native policies introduce temporality in policy types
supported as they are removed and added, the associated
policy types that can be honored at a a given time, may
need to adjust.
A significan portion of this review is dedicated to multi-policy
junits and telemetry instrumentation.
Issue-ID: POLICY-2459
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I62bbc03411446849eaa55c9b1524220dc13c2cb0
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
|
|
Issue-ID: POLICY-2378
Change-Id: I20672bed90931ff9d3cac5f63c238248f8b39406
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
|
|
This will ensure proper invocation of all feature hooks.
Issue-ID: POLICY-2388
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I8d1666bb5e9526faa588e4f613674e080181d4ba
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
|
|
Issue-ID: POLICY-2378
Change-Id: Ie8671969f79fc1e2ce767cd4ab9a426eddea5d55
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Upgrade ant, hibernate-core and commons-configuration
Issue-ID: POLICY-2439
Change-Id: I6c22e634e81850ed97c6214ffc202eb68007b8b3
Signed-off-by: Joseph Chou <jc2555@att.com>
|
|
Issue-ID: POLICY-2370
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I221fb5887d280536fbfef120b0a2cf41813684fc
|
|
Issue-ID: POLICY-2378
Change-Id: I59fb1860178cc7960f7aa553557d83d60b686ac6
Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
|
|
Issue-ID: POLICY-2378
Change-Id: I0408fbf5ff5883a7661329ba28420a773b475f49
Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
|
|
Issue-ID: POLICY-2378
Change-Id: I510fec491f1952e2312e4a018a22d4d3bd2db53c
Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
|
|
Issue-ID: POLICY-2378
Change-Id: Ibe9073fd7cd1b741e197040e32f2de3927b05658
Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
|
|
|
|
Issue-ID: POLICY-2378
Change-Id: I9186874a4a4253105f3bff602c5c5b01b7f1d1c3
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
for legacy operational policies, PAP does not populate the
metadata.policy-id field. The metadata structure is empty.
Issue-ID: POLICY-2356
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ib726c935a9ea344577dc58638bdd39192c7a10d1
|
|
Fix a bug when distributing a policy to the right
controller plus additional junits to catch similar
issues.
Issue-ID: POLICY-2356
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I25fefa64ad54c55e6516ae18c6895b6de9407419
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
|
|
Issue-ID: POLICY-2402
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ib7112b7ebefcb3a4ce743ec654556bd6cbd789e6
|
|
Fix server-pool junit hang due to hardcoded IP
Issue-ID: POLICY-2425
Change-Id: Icaf54c0bbd81fa755a031df91ee6cf5cdee98f27
Signed-off-by: Joseph Chou <jc2555@att.com>
|
|
- Native Drools Controller Policy support.
- Move domain policies into the policy-domains project.
- Route legacy/compliant operational policies to one or
all controller supporting the policy's policy type.
- Enhancements to scripts to invoke commands external
to the container.
Issue-ID: POLICY-2388
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Id41f04d10a28d2ea86bdd41334e499c28d0438ae
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Update timeout value in testcase and add logback-test.xml
Issue-ID: POLICY-2351
Change-Id: Idccf87144e137d7a0d18112a5e1442c4b04a0ac2
Signed-off-by: Joseph Chou <jc2555@att.com>
|
|
Issue-ID: POLICY-2351
Change-Id: I8ddde547a73a51c04c8dd9f1d66232e8281599a9
Signed-off-by: Straubs, Ralph (rs8887) <rs8887@att.com>
|