From 61af63956d0fa9022667c56c8874d83be35c8102 Mon Sep 17 00:00:00 2001 From: Charles Cole Date: Tue, 26 Sep 2017 14:43:58 -0500 Subject: Fix Sonar criticals Fixed two Sonar criticals. Changed VFC actor service provider to eliminate redundant AAI queries. Issue-ID: POLICY-115 Change-Id: Ic4993b5d498a1cb3d3fc51ce1d2b4e90bb26353d Signed-off-by: Charles Cole --- .../controlloop/eventmanager/ControlLoopEventManager.java | 11 ++++------- .../controlloop/eventmanager/ControlLoopOperationManager.java | 2 +- 2 files changed, 5 insertions(+), 8 deletions(-) (limited to 'controlloop/common/eventmanager/src/main/java/org/onap') diff --git a/controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ControlLoopEventManager.java b/controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ControlLoopEventManager.java index 7aaac9ead..f8f3b4cc8 100644 --- a/controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ControlLoopEventManager.java +++ b/controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ControlLoopEventManager.java @@ -72,14 +72,11 @@ public class ControlLoopEventManager implements LockCallback, Serializable { private LinkedList controlLoopHistory = new LinkedList<>(); private ControlLoopOperationManager currentOperation = null; private transient TargetLock targetLock = null; - private static AAIGETVnfResponse vnfResponse = null; - private static AAIGETVserverResponse vserverResponse = null; + private AAIGETVnfResponse vnfResponse = null; + private AAIGETVserverResponse vserverResponse = null; private static String aaiHostURL; private static String aaiUser; private static String aaiPassword; - private static String aaiGetQueryByVserver; - private static String aaiGetQueryByVnfID; - private static String aaiGetQueryByVnfName; private static Collection requiredAAIKeys = new ArrayList<>(); static { @@ -438,7 +435,7 @@ public class ControlLoopEventManager implements LockCallback, Serializable { public NEW_EVENT_STATUS onNewEvent(VirtualControlLoopEvent event) { try { - ControlLoopEventManager.checkEventSyntax(event); + this.checkEventSyntax(event); if (event.closedLoopEventStatus == ControlLoopEventStatus.ONSET) { // // Check if this is our original ONSET @@ -521,7 +518,7 @@ public class ControlLoopEventManager implements LockCallback, Serializable { return vserverResponse; } - public static void checkEventSyntax(VirtualControlLoopEvent event) throws ControlLoopException { + public void checkEventSyntax(VirtualControlLoopEvent event) throws ControlLoopException { if (event.closedLoopEventStatus == null || (event.closedLoopEventStatus != ControlLoopEventStatus.ONSET && event.closedLoopEventStatus != ControlLoopEventStatus.ABATED)) { diff --git a/controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ControlLoopOperationManager.java b/controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ControlLoopOperationManager.java index e13352ac0..262c4c6de 100644 --- a/controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ControlLoopOperationManager.java +++ b/controlloop/common/eventmanager/src/main/java/org/onap/policy/controlloop/eventmanager/ControlLoopOperationManager.java @@ -225,7 +225,7 @@ public class ControlLoopOperationManager implements Serializable { return operationRequest; case "VFC": - this.operationRequest = VFCActorServiceProvider.constructRequest((VirtualControlLoopEvent) onset, operation.operation, this.policy); + this.operationRequest = VFCActorServiceProvider.constructRequest((VirtualControlLoopEvent) onset, operation.operation, this.policy, this.eventManager.getVnfResponse()); this.currentOperation = operation; return operationRequest; -- cgit 1.2.3-korg