From 7f6929e5ea6da4015090b3adac73b35f9b3afb18 Mon Sep 17 00:00:00 2001 From: Jim Hahn Date: Thu, 12 Mar 2020 15:16:44 -0400 Subject: Fix sonar issues in drools-applications Fixed various sonar issues, including moving some code to policy-common. Fixed some eclipse warnings, including deprecated junit APIs. Issue-ID: POLICY-2426 Signed-off-by: Jim Hahn Change-Id: I10b40c1e5af62308f2e4c315e4d399aafff2998f --- .../src/main/java/org/onap/policy/database/std/StdOnapPip.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'controlloop/common/database') diff --git a/controlloop/common/database/src/main/java/org/onap/policy/database/std/StdOnapPip.java b/controlloop/common/database/src/main/java/org/onap/policy/database/std/StdOnapPip.java index 1416b3ef9..ab5fc4ec7 100644 --- a/controlloop/common/database/src/main/java/org/onap/policy/database/std/StdOnapPip.java +++ b/controlloop/common/database/src/main/java/org/onap/policy/database/std/StdOnapPip.java @@ -1,6 +1,8 @@ /*- * ============LICENSE_START======================================================= - * Copyright (C) 2019 AT&T Intellectual Property. All rights reserved. + * ONAP + * ================================================================================ + * Copyright (C) 2019-2020 AT&T Intellectual Property. All rights reserved. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -105,7 +107,7 @@ public abstract class StdOnapPip extends StdConfigurableEngine { properties.getProperty(issuerName + ".persistenceunit"), emProperties).createEntityManager(); } catch (Exception e) { - logger.error("Persistence failed {} operations history db {}", e.getLocalizedMessage(), e); + logger.error("Persistence failed operations history db", e); } } @@ -200,7 +202,7 @@ public abstract class StdOnapPip extends StdConfigurableEngine { pipResponse = null; } } catch (PIPException ex) { - logger.error("PIPException getting subject-id attribute: " + ex.getMessage(), ex); + logger.error("PIPException getting subject-id attribute", ex); } return pipResponse; } @@ -229,7 +231,7 @@ public abstract class StdOnapPip extends StdConfigurableEngine { stdPipResponse.addAttribute(new StdMutableAttribute(category, attributeId, attributeValue, pipRequest.getIssuer(), false)); } catch (Exception e) { - logger.error("Failed to convert {} to integer {}", value, e); + logger.error("Failed to convert {} to integer", value, e); } } -- cgit 1.2.3-korg