From bf2a2faad8e56abfe39cba37fe5e8cee6bfe3a5c Mon Sep 17 00:00:00 2001 From: Pamela Dragosh Date: Fri, 8 Sep 2017 11:52:11 -0400 Subject: Clearing sonar critical for missing serialization These classes should be serializable in order to remove the sonar critical. Also clearing unused import/code messages. Issue-ID: POLICY-115 Change-Id: I25e504f6edae9fb38080e7d4d33b2b3e4cde4637 Signed-off-by: Pamela Dragosh --- .../policy/controlloop/actor/appc/APPCActorServiceProvider.java | 5 +---- .../java/org/onap/policy/aai/AAINQF199/AAINQF199VServer.java | 9 ++++++++- .../aai/src/main/java/org/onap/policy/aai/RelationshipList.java | 7 ++++++- 3 files changed, 15 insertions(+), 6 deletions(-) diff --git a/controlloop/common/actors/actor.appc/src/main/java/org/onap/policy/controlloop/actor/appc/APPCActorServiceProvider.java b/controlloop/common/actors/actor.appc/src/main/java/org/onap/policy/controlloop/actor/appc/APPCActorServiceProvider.java index e7b7d2371..2d2992106 100644 --- a/controlloop/common/actors/actor.appc/src/main/java/org/onap/policy/controlloop/actor/appc/APPCActorServiceProvider.java +++ b/controlloop/common/actors/actor.appc/src/main/java/org/onap/policy/controlloop/actor/appc/APPCActorServiceProvider.java @@ -24,7 +24,6 @@ import java.util.Collections; import java.util.List; import org.onap.policy.controlloop.VirtualControlLoopEvent; -import org.onap.policy.controlloop.actor.appclcm.AppcLcmActorServiceProvider; import org.onap.policy.appc.CommonHeader; import org.onap.policy.appc.Request; import org.onap.policy.controlloop.ControlLoopOperation; @@ -101,9 +100,7 @@ public class APPCActorServiceProvider implements Actor { * specified in the yaml, the target vnf-id is retrieved by * a named query to A&AI. */ - String resourceId = policy.getTarget().getResourceID(); - String sourceVnfId = onset.AAI.get("generic-vnf.vnf-id"); - String vnfId = "test"; //AppcLcmActorServiceProvider.vnfNamedQuery(resourceId, sourceVnfId); + String vnfId = "test"; /* * For now Policy generates the PG Streams as a demo, in the diff --git a/controlloop/common/model-impl/aai/src/main/java/org/onap/policy/aai/AAINQF199/AAINQF199VServer.java b/controlloop/common/model-impl/aai/src/main/java/org/onap/policy/aai/AAINQF199/AAINQF199VServer.java index 8667544eb..823dc76a0 100644 --- a/controlloop/common/model-impl/aai/src/main/java/org/onap/policy/aai/AAINQF199/AAINQF199VServer.java +++ b/controlloop/common/model-impl/aai/src/main/java/org/onap/policy/aai/AAINQF199/AAINQF199VServer.java @@ -20,9 +20,16 @@ package org.onap.policy.aai.AAINQF199; +import java.io.Serializable; + import com.google.gson.annotations.SerializedName; -public class AAINQF199VServer { +public class AAINQF199VServer implements Serializable { + + /** + * + */ + private static final long serialVersionUID = -6718526692734215643L; @SerializedName("vserver-id") public String vserverId; diff --git a/controlloop/common/model-impl/aai/src/main/java/org/onap/policy/aai/RelationshipList.java b/controlloop/common/model-impl/aai/src/main/java/org/onap/policy/aai/RelationshipList.java index 36d34f75b..4799733da 100644 --- a/controlloop/common/model-impl/aai/src/main/java/org/onap/policy/aai/RelationshipList.java +++ b/controlloop/common/model-impl/aai/src/main/java/org/onap/policy/aai/RelationshipList.java @@ -21,12 +21,17 @@ package org.onap.policy.aai; import java.util.List; +import java.io.Serializable; import java.util.LinkedList; import com.google.gson.annotations.SerializedName; -public class RelationshipList { +public class RelationshipList implements Serializable { + /** + * + */ + private static final long serialVersionUID = -1769880386474240406L; @SerializedName("relationship") public List relationship = new LinkedList(); -- cgit 1.2.3-korg