aboutsummaryrefslogtreecommitdiffstats
path: root/controlloop
AgeCommit message (Collapse)AuthorFilesLines
2020-08-25Add Usecases-specific event managerJim Hahn4-5/+1840
Created new "usecases" event manager. Also fixed a couple of sonar issues in the new code. Issue-ID: POLICY-2748 Change-Id: I17a2c41bbf4f4e8158adbd8aa5e32ef570daa9d3 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-24Add Step classes for usecases controllerJim Hahn14-0/+2235
Add usecases-specific classes for managing preprocessor steps. Issue-ID: POLICY-2748 Change-Id: I62a2bf8fbeb656a5017531a3f3de6a6dbad5a004 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-24Merge "Add "special" Operation classes for new usecases"Pamela Dragosh13-9/+1253
2020-08-21remove legacy operational policies supportjhh7-57/+11
Issue-ID: POLICY-2765 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I454365943465863b108ba8668b2bc4b201986959
2020-08-21Add "special" Operation classes for new usecasesJim Hahn13-9/+1253
Created place-holder for new "usecases" controller. Note: as of yet, this is still just a normal java project; it will be turned into a full-fledged kie-based controller in a later review. Added some Operation and a few other support classes that will be needed. Note: the detmTarget() method and it's various supporting methods, detmXxx(), found in GetTargetEntityOperation2 were cloned from the pre-existing ControlLoopOperationManager2 class, and modified to fit the strategy of the new controller. Likewise for the junit tests of those methods. Issue-ID: POLICY-2748 Change-Id: Idffa135a11a56bd6afdd2728706fd40168e80912 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-20Add generic eventmanager classesJim Hahn6-0/+1331
Added classes that are event-agnostic and support moving control from java into rules. Updates per review comments: - removed policy scope Issue-ID: POLICY-2748-event-mgr Change-Id: Icf811cc25a3975543fc5c725766b7b9df2bb87b0 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-14Remove legacy operational policy from drools-appsJim Hahn9-136/+4
Issue-ID: POLICY-2766 Change-Id: I1ff7bbc4e301cfe6fa746f38c839acf83f7584b6 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-11Refactor BaseRuleTest for Drools appsTaka Cho6-140/+500
1, rename BaseRuleTest to BaseTest. 2, remove drools related code in BaseTest that would use for tdjam controller. 3, DroolsRuleTest extends BaseTest that would use for frankfurt controller for drools base. Issue-ID: POLICY-2750 Change-Id: Ica9637a850de6e929f09532f077ae3e997aa2045 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-07-21Merge "Remove m2 model from drools-apps"Jim Hahn70-10367/+0
2020-07-20Support vDNS RainyDay test Case.uj426b3-0/+105
Change-Id: I6d2b17c5379b19b04589da4d7bc4a7f6ebc4d23a Issue-ID: POLICY-2432 Signed-off-by: uj426b <uj426b@att.com>
2020-07-17Remove m2 model from drools-appsJim Hahn70-10367/+0
With the advent of the new Actor model, then m2 model is no longer needed in drools-apps. Issue-ID: POLICY-2725 Change-Id: I3aa43619391552c00bd4e138aee96ca5d5bd55a8 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-17Merge "remove nexus function from entrypoint"Jim Hahn1-50/+3
2020-07-17remove nexus function from entrypointjhh1-50/+3
Issue-ID: POLICY-2673 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ib1bce9a813435718e83a6671d3790c610c14b709 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-07-16Fix drools-apps CSITJim Hahn1-0/+5
Saw this in the log: java.lang.NoClassDefFoundError: org/onap/policy/models/decisions/concepts/DecisionRequest Added decisions jar to the (hopefully correct) pom. Issue-ID: POLICY-2558 Change-Id: I5a2796b3eda6b3b39b2844cd112f5a18acfa0cf8 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-15Merge "Update-config simulator prop. with mvn assembly."Jorge Hernandez2-80/+63
2020-07-14Update-config simulator prop. with mvn assembly.uj426b2-80/+63
Change-Id: Ia91fad549dfba0b3caa623be18652b93d0bc7fce Issue-ID: POLICY-2716 Signed-off-by: uj426b <uj426b@att.com>
2020-07-14Remove usecases and legacy actor codeJim Hahn61-7249/+102
Made the following changes to remove usescase and legacy actor code: - deleted the usecases controller and feature - deleted code associated with legacy actors, with the exception of AaiManager, which is needed by RestControlLoopManager - moved the contents of the "guard" project into the m2/guard project, as that is the only thing that still needs it - modified the m2/GuardContext to get the name of its persistence unit from the properties so it could be overridden by junit tests - used eclipselink constants Also fixed a bug in the properties for the VFC actor. Addressed review comment: - removed usecases from Dockerfile Issue-ID: POLICY-2558 Change-Id: I677d68c9efed9247c3d55773abdcc736b577a6b4 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-10Bump drools-apps to 1.7.1-SNAPSHOTJim Hahn27-27/+27
Issue-ID: POLICY-2695 Change-Id: Iec9af37a01ba35c5b5419399cfb3d3bc80093101 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-09FIX context URI and https to false.uj426b1-1/+3
Change-Id: Iffecc4655d22b507188ea266e82046f2a82751e8 Issue-ID: POLICY-2703 Signed-off-by: uj426b <uj426b@att.com>
2020-07-06fix complete the assertionTaka Cho2-9/+19
add isInstanceOf for assertThatThrownBy. Issue-ID: POLICY-2616 Change-Id: If49255aec6004870d7d2acfeabe258def872c1fa Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-07-02Use new Actor names in drools-appsJim Hahn5-33/+33
Modified drools-apps to use XxxActor instead of XxxActorServiceProvider. This is the second step of the rename. Issue-ID: POLICY-2684 Change-Id: Iea60e92f914b7719ac765b086650479be9192d98 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-02Merge "Updating drools applications dependencies"Jorge Hernandez1-2/+3
2020-07-01Updating drools applications dependenciesRossC1-2/+3
Issue-ID: POLICY-2387 Change-Id: I1c3ee615f0a72a9e7cec8ccc573e27a0cbe3f02c Signed-off-by: RossC <ross.carter@est.tech>
2020-06-30sonar issue - drools appsTaka Cho2-1/+4
- elevate the visibility of readResolve - test case without assertions Issue-ID: POLICY-2616 Change-Id: Ifde4b8c5e1281f8625a1203858fbe0467defe353 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-29Fix build breakage in drools-apps due to pairJim Hahn3-29/+30
The Pair changes made in drools-pdp also broke drools-apps builds. Replaced usage of drools.utils.Pair with apache Pair. Issue-ID: POLICY-2202 Change-Id: I50aaad47c243637688602ae6cb680a929fe3edd9 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-29controlloop m2 sonar fixTaka Cho1-2/+1
- remove some unused statement - remove unnecessary check Issue-ID: POLICY-2616 Change-Id: Ieb2c898a3c6ad7210642aef990b43c9a01fc15b3 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-26Fix build error from Pair changesJim Hahn1-4/+4
This is a quick fix to get around a build error in drools-applications due to "Pair" changes made in policy-common and/or policy-models. Issue-ID: POLICY-2202 Change-Id: If1cb60947e55d97ef7cfb1d05d69e07c54c71a05 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-26m2 sonar fixTaka Cho1-10/+8
- "get" returns a string already - to avoid sonar issue for duplicated strings - formating Issue-ID: POLICY-2616 Change-Id: I1fac65bba5ecb402c784dd585ebcd7992cf31545 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-25Use parent snapshot in drools-appsJim Hahn29-106/+41
Fixed checkstyle issues that were subsequently reported. Also fixed a few eclipse warnings. Also fixed some of the sonar issues in the files that were touched: - use "{}" in logger calls - camelcase method names - use "<?>" instead of generics - add serialization ID Issue-ID: POLICY-2188 Change-Id: I5c94a2e26dd74a61a0a919e1c3da17ab02a5bc9d Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-19Changes for checkstyle 8.32Jim Hahn11-14/+6
Issue-ID: POLICY-2188 Change-Id: Ib90222c537c5440e0de52fa0acbaa99bbcc4772a Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-18fix sonar for m2/base - 2Taka Cho1-4/+5
- unused import - Hide Utility Class Constructor : Utility classes should not have a public or default constructor Issue-ID: POLICY-2616 Change-Id: I338a739b6e9fb5f4b47898566362b8a87201dae3 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-17Merge "m2 sonar issues"Ram Krishna Verma2-16/+7
2020-06-17m2 sonar issuesTaka Cho2-16/+7
- unused import - logger format - Extract the assignment out of this expression - Replace this if-then-else statement by a single return statement Issue-ID: POLICY-2616 Change-Id: I2d04569a7070f79fc8979274bce2b87b4b2f3e24 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-17Merge "fix sonar issue for m2/base"Jorge Hernandez1-10/+8
2020-06-16m2/appclcm sonar issue fixTaka Cho1-12/+12
swap the arguments use assertNull Issue-ID: POLICY-2616 Change-Id: Id5bd0b7acd0914566dfdebdb42fdcaabf9eb3012 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-16fix sonar issue for m2/baseTaka Cho1-10/+8
-using {} in logger in stead -diamond operator (<>) to reduce the verbosity of generics code. -rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$' Issue-ID: POLICY-2616 Change-Id: I8e722af52b08382ca53190a33a3a27ad1e7d4830 Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-06-16Merge "change audit and metric formats in feature-controlloop-trans"Jorge Hernandez2-6/+37
2020-06-15change audit and metric formats in feature-controlloop-transJoseph Chou2-6/+37
logging enhancement Issue-ID: POLICY-2579 Change-Id: Id1e0230d3cd2ac6d921be86f127f3721c65f3e52 Signed-off-by: Joseph Chou <jc2555@att.com>
2020-06-15Remove deprecated actor propertiesJim Hahn2-18/+0
Now that the actor change has been merged, the deprecated properties can be removed from drools-apps. Done. Issue-ID: POLICY-2632 Change-Id: If4dafc489c32da4dfccd6ebac97e8e7beac2454d Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-15Merge "Adjust properties in anticipation of actor changes"Ram Krishna Verma2-10/+28
2020-06-12Adjust properties in anticipation of actor changesJim Hahn2-10/+28
Issue-ID: POLICY-2632 Change-Id: I4d20fe6b46432298ba796fe978796d5d74e1eb14 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-12Clean up to remove controlloop.simulator.envuj426b1-42/+0
Change-Id: Ic336eb24f1f3ecda359f07714e59f075596cc105 Issue-ID: POLICY-2555 Signed-off-by: uj426b <uj426b@att.com>
2020-06-12Merge "Remove deprecated properties for CDS and VFC"Liam Fallon4-36/+6
2020-06-12Merge "sonar issue drools applications - 3"Pamela Dragosh4-12/+8
2020-06-11Remove deprecated properties for CDS and VFCJim Hahn4-36/+6
Now that the changes to the Actors have been merged, the former properties can be removed, too. Also fixed guard operator/operation name since it changed from "Guard" to "Decision". Issue-ID: POLICY-2629 Change-Id: I1c8d4575be598a8cab12b1aa4ad9b1d3e1f12113 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-11Merge "Match property changes to CDS and VFC actors"Ram Krishna Verma2-0/+30
2020-06-10Merge "sonar issue drools-application - 2"Ram Krishna Verma3-19/+14
2020-06-10Merge "reduce sonar issue - drool-applications"Ram Krishna Verma2-17/+17
2020-06-10Match property changes to CDS and VFC actorsJim Hahn2-0/+30
An "operations" level is being added to the properties for the CDS and VFC actor. Added the new properties; the old ones can be deleted once the change to the actors has been merged. Issue-ID: POLICY-2629 Change-Id: Ib0bb3f62d6a2d3380aa6ec5a6e8b61ddd0a44c00 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-10sonar issue drools applications - 3Taka Cho4-12/+8
get already returns string redudant return block unused import swap expected argument use equals method instead useless assignment for payload Issue-ID: POLICY-2616 Change-Id: Ie4f07085994420b7ea3f39db89f980f6594f01b7 Signed-off-by: Taka Cho <takamune.cho@att.com>