Merge "Technical Debt in AAI."

1 files changed, 466 insertions, 470 deletions

diff --git a/controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/builder/impl/ControlLoopPolicyBuilderImpl.java b/controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/builder/impl/ControlLoopPolicyBuilderImpl.java
index 18c80eed3..5f5baf0bd 100644
--- a/controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/builder/impl/ControlLoopPolicyBuilderImpl.java
+++ b/controlloop/common/policy-yaml/src/main/java/org/onap/policy/controlloop/policy/builder/impl/ControlLoopPolicyBuilderImpl.java
@@ -48,475 +48,471 @@ import org.yaml.snakeyaml.DumperOptions.FlowStyle;
 import org.yaml.snakeyaml.Yaml;
 
 public class ControlLoopPolicyBuilderImpl implements ControlLoopPolicyBuilder {
-    private static Logger logger = LoggerFactory.getLogger(ControlLoopPolicyBuilderImpl.class.getName());
-    private ControlLoopPolicy policy;
-    
-    public ControlLoopPolicyBuilderImpl(String controlLoopName, Integer timeout) throws BuilderException {
-        policy = new ControlLoopPolicy();
-        ControlLoop controlLoop = new ControlLoop();
-        controlLoop.setControlLoopName(controlLoopName);
-        controlLoop.setTimeout(timeout);
-        policy.setControlLoop(controlLoop);
-    }
-    
-    public ControlLoopPolicyBuilderImpl(String controlLoopName, Integer timeout, Resource resource, Service... services) throws BuilderException {
-        this(controlLoopName, timeout);
-        this.addResource(resource);
-        this.addService(services);
-    }
-    
-    public ControlLoopPolicyBuilderImpl(String controlLoopName, Integer timeout, PNF pnf) throws BuilderException {
-        this(controlLoopName, timeout);
-        this.setPNF(pnf);
-    }
-    
-    public ControlLoopPolicyBuilderImpl(String controlLoopName, Integer timeout, Service service, Resource[] resources) throws BuilderException {
-        this(controlLoopName, timeout);
-        this.addService(service);
-        this.addResource(resources);
-    }
-    
-    @Override
-    public ControlLoopPolicyBuilder removePNF() throws BuilderException {
-        policy.getControlLoop().setPnf(null);
-        return this;
-    }
-
-    @Override
-    public ControlLoopPolicyBuilder addService(Service... services) throws BuilderException {
-        if (services == null) {
-            throw new BuilderException("Service must not be null");
-        }
-        for (Service service : services) {
-            if (service.getServiceUUID() == null) {
-                if (service.getServiceName() == null || service.getServiceName().length() < 1) {
-                    throw new BuilderException("Invalid service - need either a serviceUUID or serviceName");
-                }
-                if(policy.getControlLoop().getServices()==null){
-                    policy.getControlLoop().setServices(new LinkedList<>());
-                }
-                policy.getControlLoop().getServices().add(service);
-            }
-        }
-        return this;
-    }
-    
-    @Override
-    public ControlLoopPolicyBuilder removeService(Service... services) throws BuilderException {
-        if (services == null) {
-            throw new BuilderException("Service must not be null");
-        }
-        if (policy.getControlLoop().getServices() == null) {
-            throw new BuilderException("No existing services to remove");
-        }
-        for (Service service : services) {
-            if (service.getServiceUUID() == null) {
-                if (service.getServiceName() == null || service.getServiceName().length() < 1) {
-                    throw new BuilderException("Invalid service - need either a serviceUUID or serviceName");
-                }
-            }
-            boolean removed = policy.getControlLoop().getServices().remove(service);
-            if (!removed) {
-                throw new BuilderException("Unknown service " + service.getServiceName());
-            }
-        }
-        return this;
-    }
-
-    @Override
-    public ControlLoopPolicyBuilder removeAllServices() throws BuilderException {
-        policy.getControlLoop().getServices().clear();
-        return this;
-    }
-
-    
-    @Override
-    public ControlLoopPolicyBuilder addResource(Resource... resources) throws BuilderException {
-        if (resources == null) {
-            throw new BuilderException("resources must not be null");
-        }
-        for (Resource resource : resources) {
-            if (resource.getResourceUUID() == null) {
-                if (resource.getResourceName() == null || resource.getResourceName().length() <= 0) {
-                    throw new BuilderException("Invalid resource - need either resourceUUID or resourceName");
-                }
-            }
-            if(policy.getControlLoop().getResources()==null){
-                policy.getControlLoop().setResources(new LinkedList<>());
-            }
-            policy.getControlLoop().getResources().add(resource);
-        }
-        return this;
-    }
-    
-    @Override
-    public ControlLoopPolicyBuilder setPNF(PNF pnf) throws BuilderException {
-        if (pnf == null) {
-            throw new BuilderException("PNF must not be null");
-        }
-        if (pnf.PNFName == null) {
-            if (pnf.PNFType == null) {
-                throw new BuilderException("Invalid PNF - need either pnfName or pnfType");
-            }
-        }
-        policy.getControlLoop().setPnf(pnf);
-        return this;
-    }
-    
-    @Override
-    public ControlLoopPolicyBuilder setAbatement(Boolean abatement) throws BuilderException{
-        if (abatement == null) {
-            throw new BuilderException("abatement must not be null");
-        }
-        policy.getControlLoop().setAbatement(abatement);
-        return this;
-    }
-    
-    @Override
-    public ControlLoopPolicyBuilder setTimeout(Integer timeout) {
-        policy.getControlLoop().setTimeout(timeout);
-        return this;
-    }
-    
-    @Override
-    public Policy setTriggerPolicy(String name, String description, String actor, Target target, String recipe,
-            Map<String, String> payload, Integer retries, Integer timeout) throws BuilderException {
-        
-        Policy trigger = new Policy(UUID.randomUUID().toString(), name, description, actor, payload, target, recipe, retries, timeout);
-        
-        policy.getControlLoop().setTrigger_policy(trigger.getId());
-        
-        this.addNewPolicy(trigger);
-        //
-        // Return a copy of the policy
-        //
-        return new Policy(trigger);
-    }
-
-    @Override
-    public Policy setPolicyForPolicyResult(String name, String description, String actor,
-            Target target, String recipe, Map<String, String> payload, Integer retries, Integer timeout, String policyID, PolicyResult... results) throws BuilderException {
-        //
-        // Find the existing policy
-        //
-        Policy existingPolicy = this.findPolicy(policyID);
-        if (existingPolicy == null) {
-            throw new BuilderException("Unknown policy " + policyID);
-        }
-        //
-        // Create the new Policy
-        //
-        Policy newPolicy = new Policy(UUID.randomUUID().toString(), name, description, actor, payload, target, recipe, retries, timeout);
-        //
-        // Connect the results
-        //
-        for (PolicyResult result : results) {
-            switch (result) {
-            case FAILURE:
-                existingPolicy.setFailure(newPolicy.getId());
-                break;
-            case FAILURE_EXCEPTION:
-                existingPolicy.setFailure_exception(newPolicy.getId());
-                break;
-            case FAILURE_RETRIES:
-                existingPolicy.setFailure_retries(newPolicy.getId());
-                break;
-            case FAILURE_TIMEOUT:
-                existingPolicy.setFailure_timeout(newPolicy.getId());
-                break;
-            case FAILURE_GUARD:
-                existingPolicy.setFailure_guard(newPolicy.getId());
-                break;
-            case SUCCESS:
-                existingPolicy.setSuccess(newPolicy.getId());
-                break;
-            default:
-                throw new BuilderException("Invalid PolicyResult " + result);
-            }
-        }
-        //
-        // Add it to our list
-        //
-        this.policy.getPolicies().add(newPolicy);
-        //
-        // Return a policy to them
-        //
-        return new Policy(newPolicy);
-    }
-    
-    private class BuilderCompilerCallback implements ControlLoopCompilerCallback {
-
-        private ResultsImpl results = new ResultsImpl();
-        
-        @Override
-        public boolean onWarning(String message) {
-            results.addMessage(new MessageImpl(message, MessageLevel.WARNING));
-            return false;
-        }
-
-        @Override
-        public boolean onError(String message) {
-            results.addMessage(new MessageImpl(message, MessageLevel.ERROR));
-            return false;
-        }
-    }
-
-    @Override
-    public Results  buildSpecification() {
-        //
-        // Dump the specification
-        //
-        DumperOptions options = new DumperOptions();
-        options.setDefaultFlowStyle(FlowStyle.BLOCK);
-        options.setPrettyFlow(true);
-        Yaml yaml = new Yaml(options);
-        String dumpedYaml = yaml.dump(policy);
-        //
-        // This is our callback class for our compiler
-        //
-        BuilderCompilerCallback callback = new BuilderCompilerCallback();
-        //
-        // Compile it
-        //
-        try {
-            ControlLoopCompiler.compile(policy, callback);
-        } catch (CompilerException e) {
-            logger.error(e.getMessage() + e);
-            callback.results.addMessage(new MessageImpl(e.getMessage(), MessageLevel.EXCEPTION));
-        }
-        //
-        // Save the spec
-        //
-        callback.results.setSpecification(dumpedYaml);
-        return callback.results;
-    }
-
-    private void addNewPolicy(Policy policy) {
-        if (this.policy.getPolicies() == null) {
-            this.policy.setPolicies(new LinkedList<>());
-        }
-        this.policy.getPolicies().add(policy);
-    }
-    
-    private Policy findPolicy(String id) {
-        for (Policy policy : this.policy.getPolicies()) {
-            if (policy.getId().equals(id)) {
-                return policy;
-            }
-        }
-        return null;
-    }
-
-    @Override
-    public ControlLoopPolicyBuilder removeResource(Resource... resources) throws BuilderException {
-        if (resources == null) {
-            throw new BuilderException("Resource must not be null");
-        }
-        if (policy.getControlLoop().getResources() == null) {
-            throw new BuilderException("No existing resources to remove");
-        }
-        for (Resource resource : resources) {
-            if (resource.getResourceUUID() == null) {
-                if (resource.getResourceName() == null || resource.getResourceName().length() < 1) {
-                    throw new BuilderException("Invalid resource - need either a resourceUUID or resourceName");
-                }
-            }
-            boolean removed = policy.getControlLoop().getResources().remove(resource); 
-            if (!removed) {
-                throw new BuilderException("Unknown resource " + resource.getResourceName());
-            }
-        }
-        return this; 
-    }
-
-    @Override
-    public ControlLoopPolicyBuilder removeAllResources() throws BuilderException {
-        policy.getControlLoop().getResources().clear();
-        return this;
-    }
-
-    @Override
-    public Integer calculateTimeout() {
-        int sum = 0;
-        for (Policy policy : this.policy.getPolicies()) {
-            sum += policy.getTimeout().intValue();
-        }
-        return new Integer(sum);
-    }
-
-    @Override
-    public ControlLoop setTriggerPolicy(String id) throws BuilderException {
-        if (id == null) {
-            throw new BuilderException("Id must not be null");
-        }
-        Policy trigger = this.findPolicy(id);
-        if (trigger == null) {
-            throw new BuilderException("Unknown policy " + id);
-        }
-        else {
-            this.policy.getControlLoop().setTrigger_policy(id);
-        }
-        return new ControlLoop(this.policy.getControlLoop());
-    }
-
-    @Override
-    public boolean isOpenLoop() {
-        if (this.policy.getControlLoop().getTrigger_policy().equals(FinalResult.FINAL_OPENLOOP.toString())) {
-            return true;
-        }   
-        else {
-            return false;
-        }
-    }
-
-    @Override
-    public Policy getTriggerPolicy() throws BuilderException {
-        if (this.policy.getControlLoop().getTrigger_policy().equals(FinalResult.FINAL_OPENLOOP.toString())) {
-            return null;
-        }
-        else {
-            Policy trigger = new Policy(this.findPolicy(this.policy.getControlLoop().getTrigger_policy()));
-            return trigger;
-        }
-    }
-
-    @Override
-    public ControlLoop getControlLoop() {
-        ControlLoop loop = new ControlLoop(this.policy.getControlLoop());
-        return loop;
-    }
-
-    @Override
-    public Policy setPolicyForPolicyResult(String policyResultID, String policyID, PolicyResult... results)
-            throws BuilderException {
-        //
-        // Find the existing policy
-        //
-        Policy existingPolicy = this.findPolicy(policyID);
-        if (existingPolicy == null) {
-            throw new BuilderException(policyID + " does not exist");
-        }
-        if (this.findPolicy(policyResultID) == null) {
-            throw new BuilderException("Operational policy " + policyResultID + " does not exist");
-        }
-        //
-        // Connect the results
-        //
-        for (PolicyResult result : results) {
-            switch (result) {
-            case FAILURE:
-                existingPolicy.setFailure(policyResultID);
-                break;
-            case FAILURE_EXCEPTION:
-                existingPolicy.setFailure_exception(policyResultID);
-                break;
-            case FAILURE_RETRIES:
-                existingPolicy.setFailure_retries(policyResultID);
-                break;
-            case FAILURE_TIMEOUT:
-                existingPolicy.setFailure_timeout(policyResultID);
-                break;
-            case FAILURE_GUARD:
-                existingPolicy.setFailure_guard(policyResultID);
-                break;
-            case SUCCESS:
-                existingPolicy.setSuccess(policyResultID);
-                break;
-            default:
-                throw new BuilderException("Invalid PolicyResult " + result);
-            }
-        }
-        return new Policy(this.findPolicy(policyResultID));
-    }
-
-    @Override
-    public boolean removePolicy(String policyID) throws BuilderException {
-        Policy existingPolicy = this.findPolicy(policyID);
-        if (existingPolicy == null) {
-            throw new BuilderException("Unknown policy " + policyID);
-        }
-        //
-        // Check if the policy to remove is trigger_policy
-        //
-        if (this.policy.getControlLoop().getTrigger_policy().equals(policyID)) {
-            this.policy.getControlLoop().setTrigger_policy(FinalResult.FINAL_OPENLOOP.toString());
-        }
-        else {
-            //
-            // Update policies
-            //
-            for (Policy policy : this.policy.getPolicies()) {
-                int index = this.policy.getPolicies().indexOf(policy);
-                if (policy.getSuccess().equals(policyID)) {
-                    policy.setSuccess(FinalResult.FINAL_SUCCESS.toString());
-                }
-                if (policy.getFailure().equals(policyID)) {
-                    policy.setFailure(FinalResult.FINAL_FAILURE.toString());
-                }
-                if (policy.getFailure_retries().equals(policyID)) {
-                    policy.setFailure_retries(FinalResult.FINAL_FAILURE_RETRIES.toString());
-                }
-                if (policy.getFailure_timeout().equals(policyID)) {
-                    policy.setFailure_timeout(FinalResult.FINAL_FAILURE_TIMEOUT.toString());
-                }
-                if (policy.getFailure_exception().equals(policyID)) {
-                    policy.setFailure_exception(FinalResult.FINAL_FAILURE_EXCEPTION.toString());
-                }
-                if (policy.getFailure_guard().equals(policyID)) {
-                    policy.setFailure_guard(FinalResult.FINAL_FAILURE_GUARD.toString());
-                }
-                this.policy.getPolicies().set(index, policy);
-            }
-        }
-        //
-        // remove the policy
-        //
-        boolean removed = this.policy.getPolicies().remove(existingPolicy);
-        return removed;
-    }
-
-    @Override
-    public Policy resetPolicyResults(String policyID) throws BuilderException {
-        Policy existingPolicy = this.findPolicy(policyID);
-        if (existingPolicy == null) {
-            throw new BuilderException("Unknown policy " + policyID);
-        }
-        //
-        // reset policy results
-        //
-        existingPolicy.setSuccess(FinalResult.FINAL_SUCCESS.toString());
-        existingPolicy.setFailure(FinalResult.FINAL_FAILURE.toString());
-        existingPolicy.setFailure_retries(FinalResult.FINAL_FAILURE_RETRIES.toString());
-        existingPolicy.setFailure_timeout(FinalResult.FINAL_FAILURE_TIMEOUT.toString());
-        existingPolicy.setFailure_exception(FinalResult.FINAL_FAILURE_EXCEPTION.toString());
-        existingPolicy.setFailure_guard(FinalResult.FINAL_FAILURE_GUARD.toString());
-        return new Policy(existingPolicy);
-    }
-
-    @Override
-    public ControlLoopPolicyBuilder removeAllPolicies() {
-        //
-        // Remove all existing operational policies
-        //
-        this.policy.getPolicies().clear();
-        //
-        // Revert controlLoop back to an open loop
-        //
-        this.policy.getControlLoop().setTrigger_policy(FinalResult.FINAL_OPENLOOP.toString());
-        return this;
-    }
-    
-    @Override
-    public Policy addOperationsAccumulateParams(String policyID, OperationsAccumulateParams operationsAccumulateParams) throws BuilderException {
-        Policy existingPolicy = this.findPolicy(policyID);
-        if (existingPolicy == null) {
-            throw new BuilderException("Unknown policy " + policyID);
-        }
-        //
-        // Add operationsAccumulateParams to existingPolicy
-        //
-        existingPolicy.setOperationsAccumulateParams(operationsAccumulateParams);
-        return new Policy(existingPolicy);
-    }
+	private static Logger logger = LoggerFactory.getLogger(ControlLoopPolicyBuilderImpl.class.getName());
+	private ControlLoopPolicy policy;
+
+	public ControlLoopPolicyBuilderImpl(String controlLoopName, Integer timeout) throws BuilderException {
+		policy = new ControlLoopPolicy();
+		ControlLoop controlLoop = new ControlLoop();
+		controlLoop.setControlLoopName(controlLoopName);
+		controlLoop.setTimeout(timeout);
+		policy.setControlLoop(controlLoop);
+	}
+
+	public ControlLoopPolicyBuilderImpl(String controlLoopName, Integer timeout, Resource resource, Service... services) throws BuilderException {
+		this(controlLoopName, timeout);
+		this.addResource(resource);
+		this.addService(services);
+	}
+
+	public ControlLoopPolicyBuilderImpl(String controlLoopName, Integer timeout, PNF pnf) throws BuilderException {
+		this(controlLoopName, timeout);
+		this.setPNF(pnf);
+	}
+
+	public ControlLoopPolicyBuilderImpl(String controlLoopName, Integer timeout, Service service, Resource[] resources) throws BuilderException {
+		this(controlLoopName, timeout);
+		this.addService(service);
+		this.addResource(resources);
+	}
+
+	@Override
+	public ControlLoopPolicyBuilder removePNF() throws BuilderException {
+		policy.getControlLoop().setPnf(null);
+		return this;
+	}
+
+	@Override
+	public ControlLoopPolicyBuilder addService(Service... services) throws BuilderException {
+		if (services == null) {
+			throw new BuilderException("Service must not be null");
+		}
+		for (Service service : services) {
+			if (service.getServiceUUID() == null) {
+				if (service.getServiceName() == null || service.getServiceName().length() < 1) {
+					throw new BuilderException("Invalid service - need either a serviceUUID or serviceName");
+				}
+				if(policy.getControlLoop().getServices()==null){
+					policy.getControlLoop().setServices(new LinkedList<>());
+				}
+				policy.getControlLoop().getServices().add(service);
+			}
+		}
+		return this;
+	}
+
+	@Override
+	public ControlLoopPolicyBuilder removeService(Service... services) throws BuilderException {
+		if (services == null) {
+			throw new BuilderException("Service must not be null");
+		}
+		if (policy.getControlLoop().getServices() == null) {
+			throw new BuilderException("No existing services to remove");
+		}
+		for (Service service : services) {
+			if (service.getServiceUUID() == null) {
+				if (service.getServiceName() == null || service.getServiceName().length() < 1) {
+					throw new BuilderException("Invalid service - need either a serviceUUID or serviceName");
+				}
+			}
+			boolean removed = policy.getControlLoop().getServices().remove(service);
+			if (!removed) {
+				throw new BuilderException("Unknown service " + service.getServiceName());
+			}
+		}
+		return this;
+	}
+
+	@Override
+	public ControlLoopPolicyBuilder removeAllServices() throws BuilderException {
+		policy.getControlLoop().getServices().clear();
+		return this;
+	}
+
+
+	@Override
+	public ControlLoopPolicyBuilder addResource(Resource... resources) throws BuilderException {
+		if (resources == null) {
+			throw new BuilderException("resources must not be null");
+		}
+		for (Resource resource : resources) {
+			if (resource.getResourceUUID() == null) {
+				if (resource.getResourceName() == null || resource.getResourceName().length() <= 0) {
+					throw new BuilderException("Invalid resource - need either resourceUUID or resourceName");
+				}
+			}
+			if(policy.getControlLoop().getResources()==null){
+				policy.getControlLoop().setResources(new LinkedList<>());
+			}
+			policy.getControlLoop().getResources().add(resource);
+		}
+		return this;
+	}
+
+	@Override
+	public ControlLoopPolicyBuilder setPNF(PNF pnf) throws BuilderException {
+		if (pnf == null) {
+			throw new BuilderException("PNF must not be null");
+		}
+		if (pnf.getPNFName() == null && pnf.getPNFType() == null) {
+			throw new BuilderException("Invalid PNF - need either pnfName or pnfType");
+		}
+		policy.getControlLoop().setPnf(pnf);
+		return this;
+	}
+
+	@Override
+	public ControlLoopPolicyBuilder setAbatement(Boolean abatement) throws BuilderException{
+		if (abatement == null) {
+			throw new BuilderException("abatement must not be null");
+		}
+		policy.getControlLoop().setAbatement(abatement);
+		return this;
+	}
+
+	@Override
+	public ControlLoopPolicyBuilder setTimeout(Integer timeout) {
+		policy.getControlLoop().setTimeout(timeout);
+		return this;
+	}
+
+	@Override
+	public Policy setTriggerPolicy(String name, String description, String actor, Target target, String recipe,
+			Map<String, String> payload, Integer retries, Integer timeout) throws BuilderException {
+
+		Policy trigger = new Policy(UUID.randomUUID().toString(), name, description, actor, payload, target, recipe, retries, timeout);
+
+		policy.getControlLoop().setTrigger_policy(trigger.getId());
+
+		this.addNewPolicy(trigger);
+		//
+		// Return a copy of the policy
+		//
+		return new Policy(trigger);
+	}
+
+	@Override
+	public Policy setPolicyForPolicyResult(String name, String description, String actor,
+			Target target, String recipe, Map<String, String> payload, Integer retries, Integer timeout, String policyID, PolicyResult... results) throws BuilderException {
+		//
+		// Find the existing policy
+		//
+		Policy existingPolicy = this.findPolicy(policyID);
+		if (existingPolicy == null) {
+			throw new BuilderException("Unknown policy " + policyID);
+		}
+		//
+		// Create the new Policy
+		//
+		Policy newPolicy = new Policy(UUID.randomUUID().toString(), name, description, actor, payload, target, recipe, retries, timeout);
+		//
+		// Connect the results
+		//
+		for (PolicyResult result : results) {
+			switch (result) {
+			case FAILURE:
+				existingPolicy.setFailure(newPolicy.getId());
+				break;
+			case FAILURE_EXCEPTION:
+				existingPolicy.setFailure_exception(newPolicy.getId());
+				break;
+			case FAILURE_RETRIES:
+				existingPolicy.setFailure_retries(newPolicy.getId());
+				break;
+			case FAILURE_TIMEOUT:
+				existingPolicy.setFailure_timeout(newPolicy.getId());
+				break;
+			case FAILURE_GUARD:
+				existingPolicy.setFailure_guard(newPolicy.getId());
+				break;
+			case SUCCESS:
+				existingPolicy.setSuccess(newPolicy.getId());
+				break;
+			default:
+				throw new BuilderException("Invalid PolicyResult " + result);
+			}
+		}
+		//
+		// Add it to our list
+		//
+		this.policy.getPolicies().add(newPolicy);
+		//
+		// Return a policy to them
+		//
+		return new Policy(newPolicy);
+	}
+
+	private class BuilderCompilerCallback implements ControlLoopCompilerCallback {
+
+		private ResultsImpl results = new ResultsImpl();
+
+		@Override
+		public boolean onWarning(String message) {
+			results.addMessage(new MessageImpl(message, MessageLevel.WARNING));
+			return false;
+		}
+
+		@Override
+		public boolean onError(String message) {
+			results.addMessage(new MessageImpl(message, MessageLevel.ERROR));
+			return false;
+		}
+	}
+
+	@Override
+	public Results  buildSpecification() {
+		//
+		// Dump the specification
+		//
+		DumperOptions options = new DumperOptions();
+		options.setDefaultFlowStyle(FlowStyle.BLOCK);
+		options.setPrettyFlow(true);
+		Yaml yaml = new Yaml(options);
+		String dumpedYaml = yaml.dump(policy);
+		//
+		// This is our callback class for our compiler
+		//
+		BuilderCompilerCallback callback = new BuilderCompilerCallback();
+		//
+		// Compile it
+		//
+		try {
+			ControlLoopCompiler.compile(policy, callback);
+		} catch (CompilerException e) {
+			logger.error(e.getMessage() + e);
+			callback.results.addMessage(new MessageImpl(e.getMessage(), MessageLevel.EXCEPTION));
+		}
+		//
+		// Save the spec
+		//
+		callback.results.setSpecification(dumpedYaml);
+		return callback.results;
+	}
+
+	private void addNewPolicy(Policy policy) {
+		if (this.policy.getPolicies() == null) {
+			this.policy.setPolicies(new LinkedList<>());
+		}
+		this.policy.getPolicies().add(policy);
+	}
+
+	private Policy findPolicy(String id) {
+		for (Policy policy : this.policy.getPolicies()) {
+			if (policy.getId().equals(id)) {
+				return policy;
+			}
+		}
+		return null;
+	}
+
+	@Override
+	public ControlLoopPolicyBuilder removeResource(Resource... resources) throws BuilderException {
+		if (resources == null) {
+			throw new BuilderException("Resource must not be null");
+		}
+		if (policy.getControlLoop().getResources() == null) {
+			throw new BuilderException("No existing resources to remove");
+		}
+		for (Resource resource : resources) {
+			if (resource.getResourceUUID() == null) {
+				if (resource.getResourceName() == null || resource.getResourceName().length() < 1) {
+					throw new BuilderException("Invalid resource - need either a resourceUUID or resourceName");
+				}
+			}
+			boolean removed = policy.getControlLoop().getResources().remove(resource); 
+			if (!removed) {
+				throw new BuilderException("Unknown resource " + resource.getResourceName());
+			}
+		}
+		return this; 
+	}
+
+	@Override
+	public ControlLoopPolicyBuilder removeAllResources() throws BuilderException {
+		policy.getControlLoop().getResources().clear();
+		return this;
+	}
+
+	@Override
+	public Integer calculateTimeout() {
+		int sum = 0;
+		for (Policy policy : this.policy.getPolicies()) {
+			sum += policy.getTimeout().intValue();
+		}
+		return new Integer(sum);
+	}
+
+	@Override
+	public ControlLoop setTriggerPolicy(String id) throws BuilderException {
+		if (id == null) {
+			throw new BuilderException("Id must not be null");
+		}
+		Policy trigger = this.findPolicy(id);
+		if (trigger == null) {
+			throw new BuilderException("Unknown policy " + id);
+		}
+		else {
+			this.policy.getControlLoop().setTrigger_policy(id);
+		}
+		return new ControlLoop(this.policy.getControlLoop());
+	}
+
+	@Override
+	public boolean isOpenLoop() {
+		if (this.policy.getControlLoop().getTrigger_policy().equals(FinalResult.FINAL_OPENLOOP.toString())) {
+			return true;
+		}   
+		else {
+			return false;
+		}
+	}
+
+	@Override
+	public Policy getTriggerPolicy() throws BuilderException {
+		if (this.policy.getControlLoop().getTrigger_policy().equals(FinalResult.FINAL_OPENLOOP.toString())) {
+			return null;
+		}
+		else {
+			return new Policy(this.findPolicy(this.policy.getControlLoop().getTrigger_policy()));
+		}
+	}
+
+	@Override
+	public ControlLoop getControlLoop() {
+		return new ControlLoop(this.policy.getControlLoop());
+	}
+
+	@Override
+	public Policy setPolicyForPolicyResult(String policyResultID, String policyID, PolicyResult... results)
+			throws BuilderException {
+		//
+		// Find the existing policy
+		//
+		Policy existingPolicy = this.findPolicy(policyID);
+		if (existingPolicy == null) {
+			throw new BuilderException(policyID + " does not exist");
+		}
+		if (this.findPolicy(policyResultID) == null) {
+			throw new BuilderException("Operational policy " + policyResultID + " does not exist");
+		}
+		//
+		// Connect the results
+		//
+		for (PolicyResult result : results) {
+			switch (result) {
+			case FAILURE:
+				existingPolicy.setFailure(policyResultID);
+				break;
+			case FAILURE_EXCEPTION:
+				existingPolicy.setFailure_exception(policyResultID);
+				break;
+			case FAILURE_RETRIES:
+				existingPolicy.setFailure_retries(policyResultID);
+				break;
+			case FAILURE_TIMEOUT:
+				existingPolicy.setFailure_timeout(policyResultID);
+				break;
+			case FAILURE_GUARD:
+				existingPolicy.setFailure_guard(policyResultID);
+				break;
+			case SUCCESS:
+				existingPolicy.setSuccess(policyResultID);
+				break;
+			default:
+				throw new BuilderException("Invalid PolicyResult " + result);
+			}
+		}
+		return new Policy(this.findPolicy(policyResultID));
+	}
+
+	@Override
+	public boolean removePolicy(String policyID) throws BuilderException {
+		Policy existingPolicy = this.findPolicy(policyID);
+		if (existingPolicy == null) {
+			throw new BuilderException("Unknown policy " + policyID);
+		}
+		//
+		// Check if the policy to remove is trigger_policy
+		//
+		if (this.policy.getControlLoop().getTrigger_policy().equals(policyID)) {
+			this.policy.getControlLoop().setTrigger_policy(FinalResult.FINAL_OPENLOOP.toString());
+		}
+		else {
+			//
+			// Update policies
+			//
+			for (Policy policy : this.policy.getPolicies()) {
+				int index = this.policy.getPolicies().indexOf(policy);
+				if (policy.getSuccess().equals(policyID)) {
+					policy.setSuccess(FinalResult.FINAL_SUCCESS.toString());
+				}
+				if (policy.getFailure().equals(policyID)) {
+					policy.setFailure(FinalResult.FINAL_FAILURE.toString());
+				}
+				if (policy.getFailure_retries().equals(policyID)) {
+					policy.setFailure_retries(FinalResult.FINAL_FAILURE_RETRIES.toString());
+				}
+				if (policy.getFailure_timeout().equals(policyID)) {
+					policy.setFailure_timeout(FinalResult.FINAL_FAILURE_TIMEOUT.toString());
+				}
+				if (policy.getFailure_exception().equals(policyID)) {
+					policy.setFailure_exception(FinalResult.FINAL_FAILURE_EXCEPTION.toString());
+				}
+				if (policy.getFailure_guard().equals(policyID)) {
+					policy.setFailure_guard(FinalResult.FINAL_FAILURE_GUARD.toString());
+				}
+				this.policy.getPolicies().set(index, policy);
+			}
+		}
+		//
+		// remove the policy
+		//
+		boolean removed = this.policy.getPolicies().remove(existingPolicy);
+		return removed;
+	}
+
+	@Override
+	public Policy resetPolicyResults(String policyID) throws BuilderException {
+		Policy existingPolicy = this.findPolicy(policyID);
+		if (existingPolicy == null) {
+			throw new BuilderException("Unknown policy " + policyID);
+		}
+		//
+		// reset policy results
+		//
+		existingPolicy.setSuccess(FinalResult.FINAL_SUCCESS.toString());
+		existingPolicy.setFailure(FinalResult.FINAL_FAILURE.toString());
+		existingPolicy.setFailure_retries(FinalResult.FINAL_FAILURE_RETRIES.toString());
+		existingPolicy.setFailure_timeout(FinalResult.FINAL_FAILURE_TIMEOUT.toString());
+		existingPolicy.setFailure_exception(FinalResult.FINAL_FAILURE_EXCEPTION.toString());
+		existingPolicy.setFailure_guard(FinalResult.FINAL_FAILURE_GUARD.toString());
+		return new Policy(existingPolicy);
+	}
+
+	@Override
+	public ControlLoopPolicyBuilder removeAllPolicies() {
+		//
+		// Remove all existing operational policies
+		//
+		this.policy.getPolicies().clear();
+		//
+		// Revert controlLoop back to an open loop
+		//
+		this.policy.getControlLoop().setTrigger_policy(FinalResult.FINAL_OPENLOOP.toString());
+		return this;
+	}
+
+	@Override
+	public Policy addOperationsAccumulateParams(String policyID, OperationsAccumulateParams operationsAccumulateParams) throws BuilderException {
+		Policy existingPolicy = this.findPolicy(policyID);
+		if (existingPolicy == null) {
+			throw new BuilderException("Unknown policy " + policyID);
+		}
+		//
+		// Add operationsAccumulateParams to existingPolicy
+		//
+		existingPolicy.setOperationsAccumulateParams(operationsAccumulateParams);
+		return new Policy(existingPolicy);
+	}
 
 }