diff options
| author |   Jim Hahn <jrh3@att.com> | 2020-03-12 15:16:44 -0400 |
|---|---|---|
| committer | Jim Hahn <jrh3@att.com> | 2020-03-13 09:27:55 -0400 |
| commit | 7f6929e5ea6da4015090b3adac73b35f9b3afb18 (patch) | |
| tree | e1321bf17bfc7cd6f2231088b8a1d8b3d7b790e3 /controlloop/common/feature-controlloop-management | |
| parent | aa8225b5211485b3c1150c21e51fd3e93b7f31d3 (diff) | |
Fix sonar issues in drools-applications
Fixed various sonar issues, including moving some
code to policy-common.
Fixed some eclipse warnings, including deprecated junit APIs.
Issue-ID: POLICY-2426
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I10b40c1e5af62308f2e4c315e4d399aafff2998f
Diffstat (limited to 'controlloop/common/feature-controlloop-management')
2 files changed, 2 insertions, 3 deletions
diff --git a/controlloop/common/feature-controlloop-management/src/main/java/org/onap/policy/drools/server/restful/RestControlLoopManager.java b/controlloop/common/feature-controlloop-management/src/main/java/org/onap/policy/drools/server/restful/RestControlLoopManager.java index 35aabe424..0f35b733b 100644 --- a/controlloop/common/feature-controlloop-management/src/main/java/org/onap/policy/drools/server/restful/RestControlLoopManager.java +++ b/controlloop/common/feature-controlloop-management/src/main/java/org/onap/policy/drools/server/restful/RestControlLoopManager.java @@ -79,7 +79,7 @@ public class RestControlLoopManager { return Response.status(Response.Status.OK).entity(controlLoopNames).build(); } catch (IllegalArgumentException e) { - logger.error("{}", e); + logger.error("'GET' controlloops threw an exception", e); return Response.status(Response.Status.NOT_FOUND).entity(e.getMessage()).build(); } } @@ -109,7 +109,7 @@ public class RestControlLoopManager { return Response.status(Response.Status.OK).entity(controlLoopParams).build(); } catch (IllegalArgumentException e) { - logger.error("{}", e); + logger.error("'GET' controlloop threw an exception", e); return Response.status(Response.Status.NOT_FOUND).entity(e.getMessage()).build(); } } diff --git a/controlloop/common/feature-controlloop-management/src/test/java/org/onap/policy/drools/server/restful/RestControlLoopManagerTest.java b/controlloop/common/feature-controlloop-management/src/test/java/org/onap/policy/drools/server/restful/RestControlLoopManagerTest.java index 7fad4468d..2a5bffc7f 100644 --- a/controlloop/common/feature-controlloop-management/src/test/java/org/onap/policy/drools/server/restful/RestControlLoopManagerTest.java +++ b/controlloop/common/feature-controlloop-management/src/test/java/org/onap/policy/drools/server/restful/RestControlLoopManagerTest.java @@ -82,7 +82,6 @@ public class RestControlLoopManagerTest { private static final String URL_CONTEXT_PATH_TOOLS_AAI = URL_CONTEXT_PATH_TOOLS + "aai/"; private static final String URL_CONTEXT_PATH_TOOLS_AAI_CQ = URL_CONTEXT_PATH_TOOLS_AAI + "customQuery/"; - private static final String POLICY = "src/test/resources/vCPE.yaml"; private static final String CONTROLLER_FILE = "op-controller.properties"; private static final String CONTROLLER_FILE_BAK = "op-controller.properties.bak"; |