Fix technical debt/JUnit on SO/VFC/SO ACTOR

Unit test expanded for SO POJOs, technical debt removed in SO actor and VFC pojos.

Change-Id: I23b886c40c1ac6ac8dc2ebbaade315b71cca9dd0
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Issue-ID: POLICY-455

1 files changed, 6 insertions, 6 deletions

diff --git a/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java b/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java
index cb31b7458..bc10a9b90 100644
--- a/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java
+++ b/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java
@@ -127,16 +127,16 @@ public class SOActorServiceProvider implements Actor {
 			return null;
 		}
 
-		AAINQInventoryResponseItem vnfItem = null;
-		AAINQInventoryResponseItem vnfServiceItem = null;
-		AAINQInventoryResponseItem tenantItem = null;
+		AAINQInventoryResponseItem vnfItem;
+		AAINQInventoryResponseItem vnfServiceItem;
+		AAINQInventoryResponseItem tenantItem;
 
 		// Extract the items we're interested in from the response
 		try 	{
 			vnfItem = aaiResponseWrapper.getAainqresponse().getInventoryResponseItems().get(0).getItems().getInventoryResponseItems().get(0);
 		}
 		catch (Exception e) {
-			logger.error("VNF Item not found in AAI response {}", Serialization.gsonPretty.toJson(aaiResponseWrapper));
+			logger.error("VNF Item not found in AAI response {}", Serialization.gsonPretty.toJson(aaiResponseWrapper), e);
 			return null;
 		}
 
@@ -144,7 +144,7 @@ public class SOActorServiceProvider implements Actor {
 			vnfServiceItem = vnfItem.getItems().getInventoryResponseItems().get(0);
 		}
 		catch (Exception e) {
-			logger.error("VNF Service Item not found in AAI response {}", Serialization.gsonPretty.toJson(aaiResponseWrapper));
+			logger.error("VNF Service Item not found in AAI response {}", Serialization.gsonPretty.toJson(aaiResponseWrapper), e);
 			return null;
 		}
 
@@ -152,7 +152,7 @@ public class SOActorServiceProvider implements Actor {
 			tenantItem = aaiResponseWrapper.getAainqresponse().getInventoryResponseItems().get(0).getItems().getInventoryResponseItems().get(1);
 		}
 		catch (Exception e) {
-			logger.error("Tenant Item not found in AAI response {}", Serialization.gsonPretty.toJson(aaiResponseWrapper));
+			logger.error("Tenant Item not found in AAI response {}", Serialization.gsonPretty.toJson(aaiResponseWrapper), e);
 			return null;
 		}