From 4da9d4476fe968d3b915f7ca28b22bb322899614 Mon Sep 17 00:00:00 2001 From: Paul Vaduva Date: Thu, 27 Jun 2019 18:00:57 +0200 Subject: Multiplatform support for policy Add multiplatfrom support for policy-base and policy-common docker images: - the pom.xml files are modified to push and pull from dockerhub instead of nexus repository (as nexus lacks support for manifest list) - for each image that is built with maven, an arch suffix is added to the tag. The currently supported architectures are amd64 and arm64. - the creation of the timestamped tag is moved from the pom.xml files to the docker_push_manifest.sh script - for each image built via the Jenkins CI jobs, the docker_push_manifest.sh is called. The script pushes a manifest list for each tag, plus it creates the timestamp tags for SNAPSHOT or STAGING images, depending on what job called the script (merge job, or stag job) For using the images, the name of the manifest list is to be used (which is the same as the current images in nexus) Issue-ID: POLICY-1997 Change-Id: If54e7ee6ac432a999844d3584e146a90e2247323 Signed-off-by: Paul Vaduva Signed-off-by: Cristina Pauna Signed-off-by: Alexandru Avadanii --- .gitignore | 1 + docker_push_manifest.sh | 59 +++++++++++++++++++++++++ policy-base/alpine/pom.xml | 17 ++++--- policy-base/pom.xml | 7 ++- policy-common/alpine/pom.xml | 17 ++++--- policy-common/alpine/src/main/docker/Dockerfile | 4 +- policy-common/pom.xml | 7 ++- pom.xml | 4 +- version.properties | 4 +- 9 files changed, 94 insertions(+), 26 deletions(-) create mode 100755 docker_push_manifest.sh diff --git a/.gitignore b/.gitignore index 1c47ce99..a5c40ebc 100644 --- a/.gitignore +++ b/.gitignore @@ -4,3 +4,4 @@ target install.log* policy-drools/install.log* +*.sw? diff --git a/docker_push_manifest.sh b/docker_push_manifest.sh new file mode 100755 index 00000000..7e2ba852 --- /dev/null +++ b/docker_push_manifest.sh @@ -0,0 +1,59 @@ +#!/bin/bash -ex +# ============LICENSE_START======================================================= +# Copyright (C) 2019 ENEA AB. All rights reserved. +# ================================================================================ +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +# SPDX-License-Identifier: Apache-2.0 +# ============LICENSE_END========================================================= + +# This script creates the multi-arch manifest for the docker images + +# shellcheck source=/dev/null +source version.properties +IMAGES="onap/policy-base-alpine onap/policy-common-alpine" +ARCHES="amd64 arm64" +TIMESTAMP=$(date -u +"%Y%m%d%H%M%S") +MT_RELEASE='v0.9.0' + +# Download the manifest tool based on the host's architecture +HOST_ARCH='amd64' +if [ "$(uname -m)" == 'aarch64' ]; then + HOST_ARCH='arm64' +fi +wget https://github.com/estesp/manifest-tool/releases/download/${MT_RELEASE}/manifest-tool-linux-${HOST_ARCH} -O ./manifest-tool +chmod u+x manifest-tool + +# Tag the images and push the manifest (do not fail if some prerequisite tags are not yet present) +set +e +for image in ${IMAGES}; do + # always (re)create both SNAPSHOT and STAGING tags to make sure everything is up to date + TAGS="latest ${release_version} ${release_version}-SNAPSHOT ${release_version}-SNAPSHOT-latest ${release_version}-STAGING-latest" + for tag in ${TAGS}; do + ./manifest-tool push from-args \ + --ignore-missing \ + --platforms "linux/${ARCHES// /,linux/}" \ + --template "${image}:${tag}-ARCH" \ + --target "${image}:${tag}" + done + + # Create timestamped multiarch tag; if the script is ran from the merge + # job then add the SNAPSHOT suffix + [[ "${PARENT_JOB_NAME}" =~ merge ]] && snapshot_suffix="SNAPSHOT-" + + ./manifest-tool push from-args \ + --ignore-missing \ + --platforms "linux/${ARCHES// /,linux/}" \ + --template "${image}:${release_version}-${snapshot_suffix:-}ARCH" \ + --target "${image}:${release_version}-${snapshot_suffix:-}${TIMESTAMP}" +done diff --git a/policy-base/alpine/pom.xml b/policy-base/alpine/pom.xml index 028cf466..d58a7772 100644 --- a/policy-base/alpine/pom.xml +++ b/policy-base/alpine/pom.xml @@ -26,7 +26,7 @@ org.onap.policy.docker policy-base - 1.5.0-SNAPSHOT + 2.0.0-SNAPSHOT pom @@ -43,7 +43,7 @@ 1.0 - validate + pre-clean execute @@ -62,6 +62,12 @@ } println 'New tag for docker: ' + project.properties['project.docker.latesttag.version']; + if ( "aarch64".equals(System.properties['os.arch']) ) { + project.properties['project.docker.arch'] = "arm64"; + } else { + project.properties['project.docker.arch'] = System.properties['os.arch']; + } + println 'Using arch for docker: ' + project.properties['project.docker.arch']; @@ -79,14 +85,13 @@ - onap/policy-base-alpine + onap/policy-base-alpine:latest-${project.docker.arch} try Dockerfile - ${project.version} - ${project.version}-${maven.build.timestamp} - ${project.docker.latesttag.version} + ${project.version}-${project.docker.arch} + ${project.docker.latesttag.version}-${project.docker.arch} diff --git a/policy-base/pom.xml b/policy-base/pom.xml index bae9e63c..ac4eaca3 100644 --- a/policy-base/pom.xml +++ b/policy-base/pom.xml @@ -23,7 +23,7 @@ org.onap.policy.docker docker - 1.5.0-SNAPSHOT + 2.0.0-SNAPSHOT policy-base @@ -37,9 +37,8 @@ false false false - nexus3.onap.org:10001 - nexus3.onap.org:10003 - yyyyMMdd'T'HHmm + docker.io + docker.io diff --git a/policy-common/alpine/pom.xml b/policy-common/alpine/pom.xml index bc4211b7..b36221c4 100644 --- a/policy-common/alpine/pom.xml +++ b/policy-common/alpine/pom.xml @@ -26,7 +26,7 @@ org.onap.policy.docker policy-common - 1.5.0-SNAPSHOT + 2.0.0-SNAPSHOT pom @@ -43,7 +43,7 @@ 1.0 - validate + pre-clean execute @@ -62,6 +62,12 @@ } println 'New tag for docker: ' + project.properties['project.docker.latesttag.version']; + if ( "aarch64".equals(System.properties['os.arch']) ) { + project.properties['project.docker.arch'] = "arm64"; + } else { + project.properties['project.docker.arch'] = System.properties['os.arch']; + } + println 'Using arch for docker: ' + project.properties['project.docker.arch']; @@ -79,14 +85,13 @@ ${docker.push.registry} - onap/policy-common-alpine + onap/policy-common-alpine:latest-${project.docker.arch} try Dockerfile - ${project.version} - ${project.version}-${maven.build.timestamp} - ${project.docker.latesttag.version} + ${project.version}-${project.docker.arch} + ${project.docker.latesttag.version}-${project.docker.arch} ${docker.build.version} diff --git a/policy-common/alpine/src/main/docker/Dockerfile b/policy-common/alpine/src/main/docker/Dockerfile index 96f4df53..ba8d2d17 100644 --- a/policy-common/alpine/src/main/docker/Dockerfile +++ b/policy-common/alpine/src/main/docker/Dockerfile @@ -17,9 +17,9 @@ # ============LICENSE_END========================================================= # -# Docker file to build an image that contains commom packages for Policy components +# Docker file to build an image that contains common packages for Policy components # -FROM onap/policy-base-alpine +FROM onap/policy-base-alpine:latest-${project.docker.arch} LABEL maintainer="Policy Team" diff --git a/policy-common/pom.xml b/policy-common/pom.xml index 433fd00f..d63bf4e5 100644 --- a/policy-common/pom.xml +++ b/policy-common/pom.xml @@ -23,7 +23,7 @@ org.onap.policy.docker docker - 1.5.0-SNAPSHOT + 2.0.0-SNAPSHOT policy-common @@ -37,9 +37,8 @@ false false false - nexus3.onap.org:10001 - nexus3.onap.org:10003 - yyyyMMdd'T'HHmm + docker.io + docker.io ${project.version} diff --git a/pom.xml b/pom.xml index 1b55d6d6..a1e47bf6 100644 --- a/pom.xml +++ b/pom.xml @@ -23,13 +23,13 @@ org.onap.policy.parent integration - 3.0.1-SNAPSHOT + 3.0.1 org.onap.policy.docker docker - 1.5.0-SNAPSHOT + 2.0.0-SNAPSHOT pom Policy Docker images diff --git a/version.properties b/version.properties index 99af3426..a3ac0d9c 100644 --- a/version.properties +++ b/version.properties @@ -2,8 +2,8 @@ # Note that these variables cannot be structured (e.g. : version.release or version.snapshot etc... ) # because they are used in Jenkins, whose plug-in doesn't support -major=1 -minor=5 +major=2 +minor=0 patch=0 base_version=${major}.${minor}.${patch} -- cgit 1.2.3-korg