From a2740a32f308b7385a44161ec40e25d72e4ef5e0 Mon Sep 17 00:00:00 2001 From: "adheli.tavares" Date: Wed, 3 Mar 2021 15:27:56 +0000 Subject: Code coverage for Policy distribution Added code coverage for some missing instructions on main package Issue-ID: POLICY-3090 Change-Id: I1ba870a4b3c7f63f6c00dfc3f4b908eee7ca701b Signed-off-by: adheli.tavares --- .../parameters/TestDistributionParameterGroup.java | 25 +++++++- .../TestDistributionCommandLineArguments.java | 71 ++++++++++++++++++++++ 2 files changed, 95 insertions(+), 1 deletion(-) create mode 100644 main/src/test/java/org/onap/policy/distribution/main/startstop/TestDistributionCommandLineArguments.java (limited to 'main/src/test') diff --git a/main/src/test/java/org/onap/policy/distribution/main/parameters/TestDistributionParameterGroup.java b/main/src/test/java/org/onap/policy/distribution/main/parameters/TestDistributionParameterGroup.java index 6e2f5377..fb5dfbd4 100644 --- a/main/src/test/java/org/onap/policy/distribution/main/parameters/TestDistributionParameterGroup.java +++ b/main/src/test/java/org/onap/policy/distribution/main/parameters/TestDistributionParameterGroup.java @@ -2,7 +2,7 @@ * ============LICENSE_START======================================================= * Copyright (C) 2018 Ericsson. All rights reserved. * Modifications Copyright (C) 2019-2020 AT&T Intellectual Property. All rights reserved. - * Modifications Copyright (C) 2020 Nordix Foundation + * Modifications Copyright (C) 2020-2021 Nordix Foundation. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -22,6 +22,7 @@ package org.onap.policy.distribution.main.parameters; +import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThatThrownBy; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; @@ -227,4 +228,26 @@ public class TestDistributionParameterGroup { .contains("\"org.onap.policy.common.endpoints.parameters.RestServerParameters\" INVALID, " + "parameter group has status INVALID")); } + + @Test + public void testDistributionParameterGroup_NullRestServerParameters() { + final RestServerParameters restServerParameters = null; + final Map receptionHandlerParameters = + commonTestData.getReceptionHandlerParameters(false); + final Map receptionHandlerConfigurations = + commonTestData.getReceptionHandlerConfigurationParameters(false); + final Map forwarderConfigurations = + commonTestData.getPolicyForwarderConfigurationParameters(false); + final Map decoderConfigurations = + commonTestData.getPolicyDecoderConfigurationParameters(false); + + final DistributionParameterGroup distributionParameters = new DistributionParameterGroup( + CommonTestData.DISTRIBUTION_GROUP_NAME, restServerParameters, receptionHandlerParameters, + receptionHandlerConfigurations, forwarderConfigurations, decoderConfigurations); + final GroupValidationResult validationResult = distributionParameters.validate(); + assertFalse(validationResult.isValid()); + assertThat(validationResult.getResult()) + .contains("parameter group \"UNDEFINED\" INVALID, " + + "must have restServerParameters to configure distribution rest server"); + } } diff --git a/main/src/test/java/org/onap/policy/distribution/main/startstop/TestDistributionCommandLineArguments.java b/main/src/test/java/org/onap/policy/distribution/main/startstop/TestDistributionCommandLineArguments.java new file mode 100644 index 00000000..7e72b852 --- /dev/null +++ b/main/src/test/java/org/onap/policy/distribution/main/startstop/TestDistributionCommandLineArguments.java @@ -0,0 +1,71 @@ +/*- + * ============LICENSE_START======================================================= + * Copyright (C) 2021 Nordix Foundation. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.distribution.main.startstop; + +import static org.assertj.core.api.Assertions.assertThatThrownBy; +import static org.junit.Assert.assertThrows; + +import org.junit.Test; +import org.onap.policy.distribution.main.PolicyDistributionException; +import org.onap.policy.distribution.main.PolicyDistributionRuntimeException; + +/** + * Class to perform unit test of DistributionCommandLineArguments. + * + * @author Adheli Tavares (adheli.tavares@est.tech) + * + */ +public class TestDistributionCommandLineArguments { + + @Test + public void testDistributionCommandLineArgumentsException() { + String[] wrongParams = {"arg1", "nothing", "{\"someJson\":1}"}; + assertThrows(PolicyDistributionRuntimeException.class, () -> new DistributionCommandLineArguments(wrongParams)); + } + + @Test + public void testValidateFileNameEmpty() { + String[] argsOnlyKeyNoValue = {"-c", ""}; + assertValidate(argsOnlyKeyNoValue, "policy distribution configuration file was not specified as an argument"); + } + + @Test + public void testValidateFileNameDoesNotExist() { + String[] fileNameNotExistentArgs = {"-c", "someFileName.json"}; + assertValidate(fileNameNotExistentArgs, + "policy distribution configuration file \"someFileName.json\" does not exist"); + } + + @Test + public void testValidateFileNameIsNotFile() { + String[] folderAsFileNameArgs = {"-c", "src/test/resources/parameters"}; + assertValidate(folderAsFileNameArgs, + "policy distribution configuration file \"src/test/resources/parameters\" is not a normal file"); + } + + protected void assertValidate(String[] testArgs, String expectedErrorMsg) { + DistributionCommandLineArguments sutArgs = new DistributionCommandLineArguments(testArgs); + + assertThatThrownBy(() -> sutArgs.validate()) + .isInstanceOf(PolicyDistributionException.class) + .hasMessage(expectedErrorMsg); + } +} -- cgit 1.2.3-korg