From ef2ff6bae65870a4fccc25373c0cfae881e14a81 Mon Sep 17 00:00:00 2001 From: ramverma Date: Thu, 23 Aug 2018 13:50:31 +0100 Subject: Fix sonar and checkstyle issues in distribution * Fixing all check style issues. * Fixing all sonar issues. * Adding maven check style plugin to fail at warning level. Change-Id: I791b8feef39a3a0c3e1e250efea7b6e78208bf07 Issue-ID: POLICY-1035 Signed-off-by: ramverma --- .../forwarding/parameters/PolicyForwarderParameters.java | 8 +++++--- .../forwarding/PolicyDecodingExceptionTest.java | 13 +++++++------ 2 files changed, 12 insertions(+), 9 deletions(-) (limited to 'forwarding/src') diff --git a/forwarding/src/main/java/org/onap/policy/distribution/forwarding/parameters/PolicyForwarderParameters.java b/forwarding/src/main/java/org/onap/policy/distribution/forwarding/parameters/PolicyForwarderParameters.java index 57d04248..7306cc64 100644 --- a/forwarding/src/main/java/org/onap/policy/distribution/forwarding/parameters/PolicyForwarderParameters.java +++ b/forwarding/src/main/java/org/onap/policy/distribution/forwarding/parameters/PolicyForwarderParameters.java @@ -67,14 +67,16 @@ public class PolicyForwarderParameters implements ParameterGroup { return forwarderClassName; } + /** + * {@inheritDoc} + */ @Override public String getName() { return null; } /** - * Validate the policy forwarder parameters. - * + * {@inheritDoc} */ @Override public GroupValidationResult validate() { @@ -95,7 +97,7 @@ public class PolicyForwarderParameters implements ParameterGroup { try { Class.forName(forwarderClassName); } catch (final ClassNotFoundException exp) { - LOGGER.error("policy forwarder class not found in classpath", exp); + LOGGER.trace("policy forwarder class not found in classpath", exp); validationResult.setResult("forwarderClassName", ValidationStatus.INVALID, "policy forwarder class not found in classpath"); } diff --git a/forwarding/src/test/java/org/onap/policy/distribution/forwarding/PolicyDecodingExceptionTest.java b/forwarding/src/test/java/org/onap/policy/distribution/forwarding/PolicyDecodingExceptionTest.java index 4b9ed273..af820883 100644 --- a/forwarding/src/test/java/org/onap/policy/distribution/forwarding/PolicyDecodingExceptionTest.java +++ b/forwarding/src/test/java/org/onap/policy/distribution/forwarding/PolicyDecodingExceptionTest.java @@ -5,15 +5,15 @@ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at - * + * * http://www.apache.org/licenses/LICENSE-2.0 - * + * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. - * + * * SPDX-License-Identifier: Apache-2.0 * ============LICENSE_END========================================================= */ @@ -21,20 +21,21 @@ package org.onap.policy.distribution.forwarding; import static org.junit.Assert.assertEquals; + import org.junit.Test; public class PolicyDecodingExceptionTest { @Test public void testPolicyDecodingExceptionString() { - PolicyForwardingException policyDecodingException = new PolicyForwardingException("error message"); + final PolicyForwardingException policyDecodingException = new PolicyForwardingException("error message"); assertEquals("error message", policyDecodingException.getMessage()); } @Test public void testPolicyDecodingExceptionStringThrowable() { - Exception cause = new IllegalArgumentException(); - PolicyForwardingException policyDecodingException = new PolicyForwardingException("error message", cause); + final Exception cause = new IllegalArgumentException(); + final PolicyForwardingException policyDecodingException = new PolicyForwardingException("error message", cause); assertEquals("error message", policyDecodingException.getMessage()); assertEquals(cause, policyDecodingException.getCause()); } -- cgit 1.2.3-korg