From ae4f69745dbbf780323b40d5345c287ea22776f9 Mon Sep 17 00:00:00 2001
From: Jim Hahn <jrh3@att.com>
Date: Mon, 17 Feb 2020 13:21:08 -0500
Subject: Add convert() to Coder

This addresses Liam's review comment about moving the "translate"
method from the actor Util class into policy-common.
Added a method to Coder to convert from one object type to
another (e.g., from a Map to a POJO, or vice versa).

Issue-ID: POLICY-2363
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I2a0b5ab4ce4b0eeda216a57cbe23a8bb64f64940
---
 .../common/utils/coder/StandardCoderTest.java      | 33 +++++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)

(limited to 'utils/src/test/java/org/onap/policy/common/utils/coder/StandardCoderTest.java')

diff --git a/utils/src/test/java/org/onap/policy/common/utils/coder/StandardCoderTest.java b/utils/src/test/java/org/onap/policy/common/utils/coder/StandardCoderTest.java
index d5cde55a..ad4382ce 100644
--- a/utils/src/test/java/org/onap/policy/common/utils/coder/StandardCoderTest.java
+++ b/utils/src/test/java/org/onap/policy/common/utils/coder/StandardCoderTest.java
@@ -23,6 +23,8 @@ package org.onap.policy.common.utils.coder;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertSame;
 import static org.mockito.Mockito.doThrow;
 import static org.mockito.Mockito.spy;
 import static org.mockito.Mockito.when;
@@ -65,6 +67,35 @@ public class StandardCoderTest {
         coder = new StandardCoder();
     }
 
+    @Test
+    public void testConvert() throws CoderException {
+        // null source
+        assertNull(coder.convert(null, StandardCoderObject.class));
+
+        // same class of object
+        StandardCoderObject sco = new StandardCoderObject();
+        assertSame(sco, coder.convert(sco, StandardCoderObject.class));
+
+        // source is a string
+        assertEquals(Integer.valueOf(10), coder.convert("10", Integer.class));
+
+        // target is a string
+        assertEquals("10", coder.convert(10, String.class));
+
+        // source and target are different types, neither is a string
+        sco = coder.convert(Map.of("hello", "world"), StandardCoderObject.class);
+        assertEquals("world", sco.getString("hello"));
+
+        // throw an exeception
+        coder = new StandardCoder() {
+            @Override
+            protected <T> T fromJson(JsonElement json, Class<T> clazz) {
+                throw jpe;
+            }
+        };
+        assertThatThrownBy(() -> coder.convert(10, Long.class)).isInstanceOf(CoderException.class).hasCause(jpe);
+    }
+
     @Test
     public void testEncodeObject() throws Exception {
         List<Integer> arr = Arrays.asList(1100, 1110);
@@ -312,7 +343,7 @@ public class StandardCoderTest {
 
         // test when decoding into a map
         @SuppressWarnings("unchecked")
-        Map<String,Object> map2 = coder.decode("{'intValue':10, 'dblVal':20.1}", TreeMap.class);
+        Map<String, Object> map2 = coder.decode("{'intValue':10, 'dblVal':20.1}", TreeMap.class);
         assertEquals("{dblVal=20.1, intValue=10}", map2.toString());
     }
 
-- 
cgit 1.2.3-korg