From af5e28cc353456a28204ce8ebe792a218607d8c9 Mon Sep 17 00:00:00 2001 From: Pamela Dragosh Date: Fri, 21 Sep 2018 12:48:29 -0400 Subject: Fix policy/common checkstyle issues The root pom.xml had a syntax error in a declaration. The suppressions xml was not being found by the sub-modules. It was better to create a copy in each of the sub-modules where we will not be fixing abbreviations or the interface declarations in own java file. Added specific checkstyle files for each submodule. One interesting note for the InheritDoc tag. It seems that the mvn compile has a bug that interprets these as missing a period after the tag. Even though the parent interface has it correctly. It was easier to just remove it than duplicate. There are new JIRA's for that work to be done in Dublin. Fixed some spacing in pom's. Issue-ID: POLICY-1131 Change-Id: I5f845958ccefd50a3b7290662da43c994870f1f7 Signed-off-by: Pamela Dragosh --- .../onap/policy/common/utils/validation/ToStringTester.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'utils/src/main/java/org/onap/policy/common/utils') diff --git a/utils/src/main/java/org/onap/policy/common/utils/validation/ToStringTester.java b/utils/src/main/java/org/onap/policy/common/utils/validation/ToStringTester.java index 9e73a3f4..ee303eb0 100644 --- a/utils/src/main/java/org/onap/policy/common/utils/validation/ToStringTester.java +++ b/utils/src/main/java/org/onap/policy/common/utils/validation/ToStringTester.java @@ -1,6 +1,7 @@ /*- * ============LICENSE_START======================================================= * Copyright (C) 2018 Ericsson. All rights reserved. + * Modifications Copyright (C) 2018 AT&T Intellectual Property. All rights reserved. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -39,21 +40,21 @@ import org.hamcrest.Matcher; @SuppressWarnings("rawtypes") public class ToStringTester implements Tester { - private final Matcher m; + private final Matcher matcher; public ToStringTester() { - m = anything(); + matcher = anything(); } - public ToStringTester(final Matcher m) { - this.m = m; + public ToStringTester(final Matcher matcher) { + this.matcher = matcher; } @SuppressWarnings("unchecked") @Override public void run(final PojoClass pojoClass) { final Class clazz = pojoClass.getClazz(); - if (anyOf(m).matches(clazz)) { + if (anyOf(matcher).matches(clazz)) { final Object classInstance = ValidationHelper.getBasicInstance(pojoClass); Affirm.affirmFalse("Found default toString output", -- cgit 1.2.3-korg