From f10d38d4af0178d008c69ada7cd1a6abc6ec075a Mon Sep 17 00:00:00 2001 From: Jim Hahn Date: Wed, 13 Feb 2019 16:16:45 -0500 Subject: Sonar fixes Added test for Serializer to increase junit coverage. Added tests for TestTimeMulti to increase junit coverage. Sonar fixes for PropertyConfiguration: - use equalsIgnoreCase - use the exception Updated license dates. Some fixes for LoggerFactoryWrapper to address sonar issue - utility classes should typically have a private constructor. Change-Id: I8957e9673fe8371ecca7abbb7ece87b0d6f46c1a Issue-ID: POLICY-1519 Signed-off-by: Jim Hahn --- .../java/org/onap/policy/common/utils/io/Serializer.java | 6 +++--- .../org/onap/policy/common/utils/time/TestTimeMulti.java | 14 +++++++------- 2 files changed, 10 insertions(+), 10 deletions(-) (limited to 'utils-test/src/main/java') diff --git a/utils-test/src/main/java/org/onap/policy/common/utils/io/Serializer.java b/utils-test/src/main/java/org/onap/policy/common/utils/io/Serializer.java index 600bbd39..9ab26d32 100644 --- a/utils-test/src/main/java/org/onap/policy/common/utils/io/Serializer.java +++ b/utils-test/src/main/java/org/onap/policy/common/utils/io/Serializer.java @@ -2,7 +2,7 @@ * ============LICENSE_START======================================================= * ONAP Policy Engine - Common Modules * ================================================================================ - * Copyright (C) 2018 AT&T Intellectual Property. All rights reserved. + * Copyright (C) 2018-2019 AT&T Intellectual Property. All rights reserved. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -126,7 +126,7 @@ public class Serializer { /** * Read the object. - * + * * @param ois input stream * @return the object * @throws IOException throws IO exception if cannot read @@ -134,7 +134,7 @@ public class Serializer { public Object readObject(ObjectInputStream ois) throws IOException { try { return ois.readObject(); - + } catch (ClassNotFoundException e) { throw new IOException(e); } diff --git a/utils-test/src/main/java/org/onap/policy/common/utils/time/TestTimeMulti.java b/utils-test/src/main/java/org/onap/policy/common/utils/time/TestTimeMulti.java index 2782eb72..b37e49e0 100644 --- a/utils-test/src/main/java/org/onap/policy/common/utils/time/TestTimeMulti.java +++ b/utils-test/src/main/java/org/onap/policy/common/utils/time/TestTimeMulti.java @@ -2,14 +2,14 @@ * ============LICENSE_START======================================================= * Common Utils-Test * ================================================================================ - * Copyright (C) 2018 AT&T Intellectual Property. All rights reserved. + * Copyright (C) 2018-2019 AT&T Intellectual Property. All rights reserved. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at - * + * * http://www.apache.org/licenses/LICENSE-2.0 - * + * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. @@ -57,7 +57,7 @@ public class TestTimeMulti extends CurrentTime { /** * Constructor. - * + * * @param nthreads number of threads that will be sleeping simultaneously */ public TestTimeMulti(int nthreads) { @@ -99,7 +99,7 @@ public class TestTimeMulti extends CurrentTime { * Indicates that a thread has terminated or that it will no longer be invoking * {@link #sleep(long)}. Awakens the next sleeping thread, if the queue is full after * removing the terminated thread. - * + * * @throws IllegalStateException if the queue is already full */ public void threadCompleted() { @@ -159,7 +159,7 @@ public class TestTimeMulti extends CurrentTime { /** * Constructor. - * + * * @param awakenAtMs time, in milliseconds, at which the associated thread should * awaken */ @@ -181,7 +181,7 @@ public class TestTimeMulti extends CurrentTime { /** * Blocks the current thread until awakened (i.e., until its latch is * decremented). - * + * * @throws InterruptedException can be interrupted */ public void await() throws InterruptedException { -- cgit 1.2.3-korg