From 269e543ba89dbf553fc66227f7123a302f56b5b4 Mon Sep 17 00:00:00 2001 From: Pamela Dragosh Date: Fri, 10 Aug 2018 14:45:45 -0400 Subject: Remove simple checkstyle Mostly concentrated on the period at the end of summary. But I did clear a few others for longer than 120 characters and placement of methods next to each other. Possibly a few others. I did not clear everything, but will submit a few more reviews to get the others. Issue-ID: POLICY-881 Change-Id: I692a5349d686d52fee4040757cdc2ed8b5cc221b Signed-off-by: Pamela Dragosh --- .../endpoints/http/server/test/HttpServerTest.java | 19 ++++++++++--------- .../endpoints/http/server/test/NoopTopicTest.java | 4 ++-- 2 files changed, 12 insertions(+), 11 deletions(-) (limited to 'policy-endpoints/src/test') diff --git a/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/http/server/test/HttpServerTest.java b/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/http/server/test/HttpServerTest.java index d4c14a8a..6dbe8a7e 100644 --- a/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/http/server/test/HttpServerTest.java +++ b/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/http/server/test/HttpServerTest.java @@ -37,12 +37,12 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; /** - * HttpServletServer JUNIT tests + * HttpServletServer JUNIT tests. */ public class HttpServerTest { /** - * Logger + * Logger. */ private static Logger logger = LoggerFactory.getLogger(HttpServerTest.class); @@ -178,17 +178,18 @@ public class HttpServerTest { } /** - * performs an http request + * performs an http request. * - * @throws MalformedURLException - * @throws IOException - * @throws InterruptedException + * @throws MalformedURLException make sure URL is good + * @throws IOException thrown is IO exception occurs + * @throws InterruptedException thrown if thread interrupted occurs */ protected String http(HttpServletServer server, String aUrl) throws MalformedURLException, IOException, InterruptedException { URL url = new URL(aUrl); String response = null; - int numRetries = 1, maxNumberRetries = 5; + int numRetries = 1; + int maxNumberRetries = 5; while (numRetries <= maxNumberRetries) { try { response = response(url); @@ -206,11 +207,11 @@ public class HttpServerTest { } /** - * gets http response + * gets http response. * * @param url url * - * @throws IOException + * @throws IOException if an I/O error occurs */ protected String response(URL url) throws IOException { String response = ""; diff --git a/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/http/server/test/NoopTopicTest.java b/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/http/server/test/NoopTopicTest.java index 849065c1..388524a9 100644 --- a/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/http/server/test/NoopTopicTest.java +++ b/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/http/server/test/NoopTopicTest.java @@ -36,12 +36,12 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; /** - * NOOP Endpoint Tests + * NOOP Endpoint Tests. */ public class NoopTopicTest implements TopicListener { /** - * Logger + * Logger. */ private static Logger logger = LoggerFactory.getLogger(NoopTopicTest.class); -- cgit 1.2.3-korg